Throw exception when item doesn't exist in Factory\Api\Mastodon\Status->createFromUriId

- Address https://github.com/friendica/friendica/issues/9250#issuecomment-750464977
2020-12-27 21:15:21 -05:00 · 2020-12-27 21:15:21 -05:00 · 8c1e2b9800
parent 97bbe3ae96
commit 8c1e2b9800
1 changed files with 4 additions and 0 deletions
--- a/src/Factory/Api/Mastodon/Status.php
+++ b/src/Factory/Api/Mastodon/Status.php
@ -61,6 +61,10 @@ class Status extends BaseFactory
 	public function createFromUriId(int $uriId, $uid = 0)
 	{
 		$item = Item::selectFirst([], ['uri-id' => $uriId, 'uid' => $uid]);
+		if (!$item) {
+			throw new HTTPException\NotFoundException('Item with URI ID ' . $uriId . 'not found' . ($uid ? ' for user ' . $uid : '.'));
+		}
+
 		$account = DI::mstdnAccount()->createFromContactId($item['author-id']);

 		$counts = new \Friendica\Object\Api\Mastodon\Status\Counts(