61693419e8
* [diaspora]: Maybe SimpleXMLElement is the right type-hint? * Changes proposed + pre-renaming: - pre-renamed $db -> $connection - added TODOs for not allowing bad method invocations (there is a BadMethodCallException in SPL) * If no record is found, below $r[0] will fail with a E_NOTICE and the code doesn't behave as expected. * Ops, one more left ... * Continued: - added documentation for Contact::updateSslPolicy() method - added type-hint for $contact of same method - empty lines added + TODO where the bug origins that $item has no element 'body' * Added empty lines for better readability * Cleaned up: - no more x() (deprecated) usage but empty() instead - fixed mixing of space/tab indending - merged else/if block goether in elseif() (lesser nested code blocks) * Re-fixed DBM -> DBA switch * Fixes/rewrites: - use empty()/isset() instead of deprecated x() - merged 2 nested if() blocks into one - avoided nested if() block inside else block by rewriting it to elseif() - $contact_id is an integer, let's test on > 0 here - added a lot spaces and some empty lines for better readability * Rewrite: - moved all CONTACT_* constants from boot.php to Contact class * CR request: - renamed Contact::CONTACT_IS_* -> Contact::* ;-) * Rewrites: - moved PAGE_* to Friendica\Model\Profile class - fixed mixure with "Contact::* rewrite" * Ops, one still there (return is no function) * Rewrite to Proxy class: - introduced new Friendica\Network\Proxy class for in exchange of proxy_*() functions - moved also all PROXY_* constants there as Proxy::* - removed now no longer needed mod/proxy.php loading as composer's auto-load will do this for us - renamed those proxy_*() functions to better names: + proxy_init() -> Proxy::init() (public) + proxy_url() -> Proxy::proxifyUrl() (public) + proxy_parse_html() -> Proxy::proxifyHtml() (public) + proxy_is_local_image() -> Proxy::isLocalImage() (private) + proxy_parse_query() -> Proxy::parseQuery() (private) + proxy_img_cb() -> Proxy::replaceUrl() (private) * CR request: - moved all PAGE_* constants to Friendica\Model\Contact class - fixed all references of both classes * Ops, need to set $a here ... * CR request: - moved Proxy class to Friendica\Module - extended BaseModule * Ops, no need for own instance of $a when self::getApp() is around. * Proxy-rewrite: - proxy_url() and proxy_parse_html() are both non-module functions (now methods) - so they must be splitted into a seperate class - also the SIZE_* and DEFAULT_TIME constants are both not relevant to module * No instances from utility classes * Fixed error: - proxify*() is now located in `Friendica\Util\ProxyUtils` * Moved back to original place, ops? How did they move here? Well, it was not intended by me. * Removed duplicate (left-over from split) constants and static array. Thank to MrPetovan finding it. * Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils. * Rewrite: - stopped using deprecated NETWORK_* constants, now Protocol::* should be used - still left them intact for slow/lazy developers ... * Ops, was added accidentally ... * Ops, why these wrong moves? * Ops, one to much (thanks to MrPetovan) * Ops, wrong moving ... * moved back to original place ... * spaces added * empty lines add for better readability. * convertered spaces -> tab for code indenting. * CR request: Add space between if and brace. * CR requests fixed + move reverted - ops, src/Module/*.php has been moved to src/Network/ accidentally - reverted some parts in src/Database/DBA.php as pointed out by Annando - removed internal TODO items - added some spaces for better readability
97 lines
3.2 KiB
PHP
97 lines
3.2 KiB
PHP
<?php
|
|
/**
|
|
* @file src/Model/Conversation
|
|
*/
|
|
|
|
namespace Friendica\Model;
|
|
|
|
use Friendica\Core\Protocol;
|
|
use Friendica\Database\DBA;
|
|
use Friendica\Util\DateTimeFormat;
|
|
|
|
require_once "include/dba.php";
|
|
|
|
class Conversation
|
|
{
|
|
/*
|
|
* These constants represent the parcel format used to transport a conversation independently of the message protocol.
|
|
* It currently is stored in the "protocol" field for legacy reasons.
|
|
*/
|
|
const PARCEL_UNKNOWN = 0;
|
|
const PARCEL_DFRN = 1;
|
|
const PARCEL_DIASPORA = 2;
|
|
const PARCEL_SALMON = 3;
|
|
const PARCEL_FEED = 4; // Deprecated
|
|
const PARCEL_SPLIT_CONVERSATION = 6;
|
|
const PARCEL_TWITTER = 67;
|
|
|
|
/**
|
|
* @brief Store the conversation data
|
|
*
|
|
* @param array $arr Item array with conversation data
|
|
* @return array Item array with removed conversation data
|
|
*/
|
|
public static function insert(array $arr)
|
|
{
|
|
if (in_array(defaults($arr, 'network', Protocol::PHANTOM),
|
|
[Protocol::DFRN, Protocol::DIASPORA, Protocol::OSTATUS, Protocol::TWITTER]) && !empty($arr['uri'])) {
|
|
$conversation = ['item-uri' => $arr['uri'], 'received' => DateTimeFormat::utcNow()];
|
|
|
|
if (isset($arr['parent-uri']) && ($arr['parent-uri'] != $arr['uri'])) {
|
|
$conversation['reply-to-uri'] = $arr['parent-uri'];
|
|
}
|
|
|
|
if (isset($arr['thr-parent']) && ($arr['thr-parent'] != $arr['uri'])) {
|
|
$conversation['reply-to-uri'] = $arr['thr-parent'];
|
|
}
|
|
|
|
if (isset($arr['conversation-uri'])) {
|
|
$conversation['conversation-uri'] = $arr['conversation-uri'];
|
|
}
|
|
|
|
if (isset($arr['conversation-href'])) {
|
|
$conversation['conversation-href'] = $arr['conversation-href'];
|
|
}
|
|
|
|
if (isset($arr['protocol'])) {
|
|
$conversation['protocol'] = $arr['protocol'];
|
|
}
|
|
|
|
if (isset($arr['source'])) {
|
|
$conversation['source'] = $arr['source'];
|
|
}
|
|
|
|
$fields = ['item-uri', 'reply-to-uri', 'conversation-uri', 'conversation-href', 'protocol', 'source'];
|
|
$old_conv = DBA::selectFirst('conversation', $fields, ['item-uri' => $conversation['item-uri']]);
|
|
if (DBA::isResult($old_conv)) {
|
|
// Don't update when only the source has changed.
|
|
// Only do this when there had been no source before.
|
|
if ($old_conv['source'] != '') {
|
|
unset($old_conv['source']);
|
|
}
|
|
// Update structure data all the time but the source only when its from a better protocol.
|
|
if (isset($conversation['protocol']) && isset($conversation['source']) && ($old_conv['protocol'] < $conversation['protocol']) && ($old_conv['protocol'] != 0)) {
|
|
unset($conversation['protocol']);
|
|
unset($conversation['source']);
|
|
}
|
|
if (!DBA::update('conversation', $conversation, ['item-uri' => $conversation['item-uri']], $old_conv)) {
|
|
logger('Conversation: update for ' . $conversation['item-uri'] . ' from ' . $old_conv['protocol'] . ' to ' . $conversation['protocol'] . ' failed',
|
|
LOGGER_DEBUG);
|
|
}
|
|
} else {
|
|
if (!DBA::insert('conversation', $conversation, true)) {
|
|
logger('Conversation: insert for ' . $conversation['item-uri'] . ' (protocol ' . $conversation['protocol'] . ') failed',
|
|
LOGGER_DEBUG);
|
|
}
|
|
}
|
|
}
|
|
|
|
unset($arr['conversation-uri']);
|
|
unset($arr['conversation-href']);
|
|
unset($arr['protocol']);
|
|
unset($arr['source']);
|
|
|
|
return $arr;
|
|
}
|
|
}
|