752953e472
Changes: - as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL - added some missing type-hints - added missing documentation - the added @TODO points out to avoid true|false|null for a boolean
Roland Häder
2022-06-20 20:59:08 +02:00
88eacbf66e
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
Hypolite Petovan
2022-06-20 14:34:02 -04:00
0c12e947dd
Changes: - null was 2nd argument's value before, an empty string is basically the same here
Roland Häder
2022-06-20 20:01:25 +02:00
feb87e8dc3
Changes: - let's start throwing exceptions on e.g. invalid arguments instead of returning FALSE
Roland Häder
2022-06-20 19:08:23 +02:00
4fb03cf163
Changes: - fixed a null value handled over to Friendica\Model\APContact::getByURL() - added missing type-hints
Roland Häder
2022-06-20 19:04:01 +02:00
e96a548286
Changes: - dumped default value for $input - added unknown 'platform' which prevents an "Undefined index: platform in /var/www/.../src/Model/GServer.php on line 940" error
Roland Häder
2022-06-20 18:55:17 +02:00
e5cc7a5ab1
Fixes: - Strings::isHex() should not be misused for checking on NULL
Roland Häder
2022-06-20 08:25:17 +02:00
6743de63f5
Changed: - DBA::exists() should only be used for checking if records exists. - if you want to check if a table exists, please ALWAYS use DBStructure::existsTable() instead
Roland Häder
2022-06-20 08:18:53 +02:00
cc750d743b
Changes: - some methods now need to return bool to be compatible - added some missing type-hints
Roland Häder
2022-06-20 08:12:09 +02:00
9c80dd35e5
Both declarations must be the same
Roland Häder
2022-06-20 08:06:45 +02:00
a063a89c57
Accesskey was used twice
Tobias Diekershoff
2022-06-19 06:30:00 +02:00
b6bfe72083
Wrong returned type, has to be array
Roland Häder
2022-06-19 02:39:51 +02:00
7bb0cb5323
Changes: - added more type-hints - DBStructure::existsTable() does no longer need array support for table name because this is no longer used (good work!)
Roland Häder
2022-06-19 02:10:04 +02:00
2c5685c89c
Changes: - changed to proper "use Foo\Bar;" - added doctag - added return type as this is fixed
Roland Häder
2022-06-19 01:10:50 +02:00
d7d2ad77ff
Ops, also this!
Roland Häder
2022-06-18 23:31:44 +02:00
39f2d197ea
Changed to suggestings (back to original) + fixed typo in scalar type
Roland Häder
2022-06-18 23:30:13 +02:00
6f1d52cf71
Changed back to suggestions by @MrPetovan
Roland Häder
2022-06-18 23:23:50 +02:00
2f961b11bf
Naming-convention: - variables should start lower-case: $image
Roland Häder
2022-06-18 23:16:07 +02:00
fa14a02a19
Changes: - added type-hints - added documentation - changed double-quotes to single
Roland Häder
2022-06-18 23:12:25 +02:00
f3b57008b5
Proper type is string
Roland Häder
2022-06-18 18:41:07 +02:00
41f34c4261
Maybe fix for:
Roland Häder
2022-06-18 18:30:03 +02:00
9691bb06fb
Changes: - added more type-hints - added missing documentation
Roland Häder
2022-06-18 18:21:05 +02:00
94eb426151
Nodeinfo::getOrganization() doesn't need configuration object being inserted when you have DI::config() around.
Roland Häder
2022-06-18 17:56:01 +02:00
c29c49797a
Added missing type-hints
Roland Häder
2022-06-18 17:52:34 +02:00
4e437190c5
Renamed variable, no need for "orig_" prefix
Roland Häder
2022-06-18 17:49:57 +02:00
a1a81cdc6b
Continued: - changed some double-quotes to single - added missing type-hints - added missing documentation - fixed indenting a bit
Roland Häder
2022-06-18 17:45:53 +02:00
8fc710f82a
Continued: - added more type-hints - added some missing documentation - Return the result from DBA::delete() to let other methods know about it
Roland Häder
2022-06-18 17:22:10 +02:00
8ba3f13fae
Changes: - added more type-hints - added missing documentation
Roland Häder
2022-06-18 17:09:18 +02:00
92a1d14e5e
Updated documentation and SQL dump, according to woodpecker tests
Roland Häder
2022-06-18 16:02:10 +02:00
8756d92316
Continued: - prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned"
Roland Häder
2022-06-18 15:56:58 +02:00
8aaf99c61d
Sizes increased for: - video files that have sizes var being int allowes - URLs that might be longer (e.g. magnet: URLs) than varbinary(511) allows
Roland Häder
2022-06-18 15:30:36 +02:00
bd3a7b9877
Ops, needs to be a variable:
Roland Häder
2022-06-18 09:58:44 +02:00
69cda4f760
Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php on line 37"
Roland Häder
2022-06-18 05:41:19 +02:00
7cbb818c93
Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() is the same and being handled over.
Roland Häder
2022-06-18 05:18:38 +02:00
89302d0843
Some outside code relies on returned "false"
Roland Häder
2022-06-18 05:06:00 +02:00
aaf5c323b6
Fixed indenting
Roland Häder
2022-06-18 05:04:04 +02:00
adb4aea6ad
Changes: - added some type-hints - replaced most double-quotes (only Diaspora.php, later more) with single - added some documentation - normalized indenting in Diaspora.php (I hope I got all?)
Roland Häder
2022-06-18 05:01:51 +02:00
51f43278d6
Fixed incompatible types
Roland Häder
2022-06-17 18:00:06 +02:00
88c40f3336
Ops, wrong type again
Roland Häder
2022-06-17 13:02:43 +02:00
a770634b95
Ops, wrong type
Roland Häder
2022-06-17 12:22:40 +02:00
36d56a4041
Continued: - changed back to 'return false;' as other methods heavily rely on false instead of an empty array as pointed out by @heluecht@pirati.ca - $fetched_contact should be initialized as an empty array, let's not make this code more crazier than it already is (see APContact::getByURL())
Roland Häder
2022-06-17 11:48:52 +02:00
c467bff79f
Some more type-hints added
Roland Häder
2022-06-17 11:17:53 +02:00
4f3321cc9f
Nore fixes
Roland Häder
2022-06-17 11:04:47 +02:00
10bb7d5625
Possible fix for
Roland Häder
2022-06-17 10:57:17 +02:00
fdd237a090
Fix for "Uncaught Exception TypeError: "Argument 1 passed to Friendica\Model\APContact::unarchiveInbox() must be of the type string, null given" error message
Roland Häder
2022-06-17 10:53:45 +02:00
605e7d55b3
Continued: - added more type-hints - some methods in Diaspora returned void but integer was documented so I changed it to -1 to have a proper type-hint
Roland Häder
2022-06-17 10:44:13 +02:00
0c9aff8a09
Also need to declare $profile or otherwise an invocation of Receiver::getReceiverForActor() will fail.
Roland Häder
2022-06-17 09:51:11 +02:00
af8cd5ca86
Worker::getWaitingJobForPID() can also return FALSE on failure ... :-(
Roland Häder
2022-06-16 22:17:37 +02:00
227bab43a8
Ops, wrong type-hint here, must be string ($nickname can never be an integer).
Roland Häder
2022-06-16 22:15:06 +02:00
f7c1eaa858
Continued: - added type-hints - removed out-dated documentation - added some missing documentation
Roland Häder
2022-06-16 22:12:38 +02:00
e484b6d6dc
Continued: - added more type-hints - added some documentation - Contact::getAccountType() should only process string, not null
Roland Häder
2022-06-16 21:57:02 +02:00
45b5f67bca
Fix for non-existing record system.mobile_theme in config table
Roland Häder
2022-06-16 20:58:24 +02:00
5c9ce790bf
Fixed: - $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd parameter expect it to be string
Roland Häder
2022-06-16 20:47:59 +02:00
33768ea1c6
Some fixes: - $gsid's default value cannot sadly be 0, it now must be null to allow some code work - added some more type-hints - documented a bit more
Roland Häder
2022-06-16 20:42:40 +02:00
4e53666c70
Added more type-hints
Roland Häder
2022-06-16 20:33:10 +02:00
7560dccc08
Added again more type-hints
Roland Häder
2022-06-16 20:17:04 +02:00
2766c7d9cf
Continued: - added more type-hints - added some missing documentation
Roland Häder
2022-06-16 20:01:09 +02:00
a587217f47
Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool"
Roland Häder
2022-06-16 19:39:49 +02:00
dd54e52575
MrPetovan brought the right one up: > Since this is depending on remote systems, the log can quickly fill with unactionable messages.
Roland Häder
2022-06-16 19:21:07 +02:00
c351099c5a
Ops, bad type-hint here
Roland Häder
2022-06-16 19:17:25 +02:00
2c5595c358
Another incompatible method declaration fixed + type-hints added
Roland Häder
2022-06-16 18:36:56 +02:00
40d7f29a11
Continued: - more type-hints - fixed incompatible method declarations
Roland Häder
2022-06-16 18:28:38 +02:00
1edc6b3c3b
Added more type-hints for "App" classes
Roland Häder
2022-06-16 16:49:43 +02:00
42b04f397b
Added more type-hints
Roland Häder
2022-06-16 16:38:58 +02:00
aa5f0d5ec1
Added more type-hints and documented a few methods
Roland Häder
2022-06-16 16:35:39 +02:00
97e27cb523
Added more type-hints
Roland Häder
2022-06-16 16:25:30 +02:00
c2e889cfae
Added more type-hints
Roland Häder
2022-06-16 14:59:29 +02:00
Roland Häder
Hypolite Petovan
Tobias Diekershoff