be35349495
added more curyl braces + spaces between "if" and brace
Roland Häder
2016-12-20 10:44:27 +01:00
e5461df082
Coding convention: - added curly braces - added space between "if" and brace - also added TODO (old-lost code?)
Roland Häder
2016-12-20 10:39:06 +01:00
e6463c8af6
Coding convention: - added curly braces - added space between "if" and brace
Roland Häder
2016-12-20 10:35:28 +01:00
4dfe64bd5a
Coding convention: - added curly braces - added space between "if" and brace - also added TODO (old-lost code?)
Roland Häder
2016-12-20 10:39:06 +01:00
65e1cd728c
Coding convention: - added curly braces - added space between "if" and brace
Roland Häder
2016-12-20 10:35:28 +01:00
064b53e673
Coding convention: - added curly braces - added space between "if" and brace - also added TODO (old-lost code?)
Roland Häder
2016-12-20 10:39:06 +01:00
a5e4882e25
Coding convention: - added curly braces - added space between "if" and brace
Roland Häder
2016-12-20 10:35:28 +01:00
5a90e7f822
Continued a bit: - converted some bad checks to use dbm::is_result() - added space between "if" and brace - added curly braces
Roland Häder
2016-12-20 10:16:48 +01:00
f42c4b6d7f
Continued a bit: - converted some bad checks to use dbm::is_result() - added space between "if" and brace - added curly braces
Roland Häder
2016-12-20 10:16:48 +01:00
98b7270295
Coding convention applied: - space between "if" and brace - curly braces on conditional blocks
Roland Häder
2016-12-20 10:10:33 +01:00
e1f3661645
*much* more usage of App::get_baseurl() instead of $a->get_baseurl() (coding convention applied)
Roland Häder
2016-12-19 14:26:13 +01:00
abff6372dd
Coding convention applied: - space between "if" and brace - curly braces on conditional blocks
Roland Häder
2016-12-20 10:10:33 +01:00
fb676335db
Coding convention applied: - space between "if" and brace - curly braces on conditional blocks
Roland Häder
2016-12-20 10:10:33 +01:00
37ce5ce886
Remove indexes that we don't use anymore
Michael
2016-12-20 07:14:59 +00:00
4c77ae2fe9
Only distribute items to active contacts
Michael
2016-12-20 07:13:22 +00:00
6e46987515
The object type "photo" is deprecated and was replaced by "image"
Michael
2016-12-20 07:10:47 +00:00
75711a947e
Workaround for vanished database connections while authentication
Michael
2016-12-20 07:08:03 +00:00
81d003cad1
Diaspora: Complete /people/* links from fcontact or author domain
Hypolite Petovan
2016-12-19 23:30:50 -05:00
403d1f987f
proxy_url: Fix extension extraction for URLs containing a . after a ?
Hypolite Petovan
2016-12-19 20:19:26 -05:00
dac1dbd3e9
Merge branch 'rewrites/dbm_is_result' into develop
Roland Häder
2016-12-19 14:47:05 +01:00
a96eb3428d
Used more dbm::is_result() instead of (!$r) or (!count($r)), still there are more pending ...
Roland Häder
2016-12-19 14:42:20 +01:00
884f44ce94
*much* more usage of App::get_baseurl() instead of $a->get_baseurl() (coding convention applied)
Roland Häder
2016-12-19 14:26:13 +01:00
c43389f79a
No more needed ... util/typo.php is there.
Roland Häder
2016-12-14 16:43:03 +01:00
e06cac420b
Use [] instead of test.
Roland Häder
2016-12-14 12:51:20 +01:00
7f1da5b1a9
added lint.sh which needs to be executed like this:
Roland Häder
2016-12-14 12:45:11 +01:00
4615f39836
Merge remote-tracking branch 'upstream/develop' into develop
Roland Häder
2016-12-19 14:21:26 +01:00
52f12ee28d
Merge pull request #3010 from Quix0r/rewrites/mixed-static-object-reference-calls
Michael Vogel
2016-12-19 14:12:50 +01:00
cae6a0c9fb
Merge pull request #3026 from tobiasd/20161219-lng
Michael Vogel
2016-12-19 14:09:57 +01:00
85dec3cf30
DE translation of the core
Tobias Diekershoff
2016-12-19 12:22:47 +01:00
ff569756ee
Merge remote-tracking branch 'upstream/develop' into rewrites/mixed-static-object-reference-calls
Roland Häder
2016-12-19 09:40:34 +01:00
fd1afcbd35
Merge pull request #3025 from tobiasd/20161219-messagespo
Michael Vogel
2016-12-19 08:40:49 +01:00
a58d8d2c71
This error message had me confused for about twenty minutes. I couldn't figure out what was wrong with my imagick install that would make it give me an orange button if it was installed. Of course, the problem was that it wasn't installed, and the message was worded badly. This is a bit less confusing.
Thomas Willingham
2016-12-19 00:10:11 +00:00
8cab220387
Bugfix: Reimported Friendica posts from pump.io had the links missing.
Michael
2016-12-18 23:39:44 +00:00
a126db451c
Convention: SQL keywords all upper-case, columns and table names (better) lower-cased and always in back-ticks.
Roland Häder
2016-12-15 10:11:25 +01:00
2c9d282136
Convention: SQL keywords all upper-case, columns and table names (better) lower-cased and always in back-ticks.
Roland Häder
2016-12-15 10:11:25 +01:00
f89044ed61
Garrr ...
Roland Häder
2016-12-15 09:52:15 +01:00
9c564c4fd3
Again, static *OR* object-referencing calls? Blue or red pill?
Roland Häder
2016-12-15 10:05:18 +01:00
c43e9aa74e
get_basepath() uses a lot $this (which means object-referenced calls, or non-static calls). but still it is called statically in many places.
Roland Häder
2016-12-15 10:03:06 +01:00
2eb3727542
Again, static *OR* object-referencing calls? Blue or red pill?
Roland Häder
2016-12-15 10:05:18 +01:00
b54c22666c
get_basepath() uses a lot $this (which means object-referenced calls, or non-static calls). but still it is called statically in many places.
Roland Häder
2016-12-15 10:03:06 +01:00
378cbd9027
Continued with #3010: - more reverts of $a->get_baseurl() - you always do: function foo (&$a), please read my TODO why it is not so good. - for now I have fixed this inconsistency (compared to other method signatures)
Roland Häder
2016-12-15 09:57:55 +01:00
8e1796bb1f
Continued with #3010: - more reverts of $a->get_baseurl() - you always do: function foo (&$a), please read my TODO why it is not so good. - for now I have fixed this inconsistency (compared to other method signatures)
Roland Häder
2016-12-15 09:57:55 +01:00
d26009e408
Garrr ...
Roland Häder
2016-12-15 09:52:15 +01:00
1c82ad0734
Opps, tpzo found ...
Roland Häder
2016-12-15 09:51:06 +01:00
8ad1bdaac1
Opps, tpzo found ...
Roland Häder
2016-12-15 09:51:06 +01:00
d4f737577b
And more reverts: - $a->get_baseurl() -> App::get_baseurl() - was_recently_delayed() (entirely)
Roland Häder
2016-12-15 09:49:00 +01:00
f42935421e
And more reverts: - $a->get_baseurl() -> App::get_baseurl() - was_recently_delayed() (entirely)
Roland Häder
2016-12-15 09:49:00 +01:00
dea8bef472
more reverts ...
Roland Häder
2016-12-15 09:32:32 +01:00
7849b3f8e3
more reverts ...
Roland Häder
2016-12-15 09:32:32 +01:00
ba3bc420ca
Also reverted these + added spaces for nicer appearance.
Roland Häder
2016-12-15 09:22:38 +01:00
6cef88c24e
Also reverted these + added spaces for nicer appearance.
Roland Häder
2016-12-15 09:22:38 +01:00
53417aaf39
Create missing self contact
Michael
2016-12-15 07:15:33 +00:00
9e28f5a0c3
fixed SQL writing: keywords upper-case, column/table names in back-ticks. #3010
Roland Haeder
2016-12-14 20:50:39 +01:00
c830bfcd96
fixed SQL writing: keywords upper-case, column/table names in back-ticks. #3010
Roland Haeder
2016-12-14 20:50:39 +01:00
ab50585e9a
reverted change (which duplicated above query), thanks to @annano to point this out. #3010
Roland Häder
2016-12-14 17:41:28 +01:00
cef6fce7f0
reverted change (which duplicated above query), thanks to @annano to point this out. #3010
Roland Häder
2016-12-14 17:41:28 +01:00
467cdfeb34
3 slashes for Doxygen, 2 are enough for PHP ... :-(
Roland Häder
2016-12-14 17:28:18 +01:00
ba45a292c4
3 slashes for Doxygen, 2 are enough for PHP ... :-(
Roland Häder
2016-12-14 17:28:18 +01:00
41db906dc4
Continued with #3010: - removed added debug messages (maybe they will come back in accordance to code-style guidelines?) - converted $a->get_baseurl() back to App::get_baseurl() - reverted back other code I have touched/merged as this was double: (substr($url, 0, 4) !== 'http') on $url = 'https://bla'; will be FALSE (means found http at start), too.
Roland Häder
2016-12-14 16:59:35 +01:00
23d4db5149
Continued with #3010: - removed added debug messages (maybe they will come back in accordance to code-style guidelines?) - converted $a->get_baseurl() back to App::get_baseurl() - reverted back other code I have touched/merged as this was double: (substr($url, 0, 4) !== 'http') on $url = 'https://bla'; will be FALSE (means found http at start), too.
Roland Häder
2016-12-14 16:59:35 +01:00
4b860e7575
No more needed ... util/typo.php is there.
Roland Häder
2016-12-14 16:43:03 +01:00
307df4ee5c
Also removed this, seems to come in from wrong merging? #3010 Thanks to @annando
Roland Häder
2016-12-14 16:39:39 +01:00
a31acb5fda
Opps, this has vanished by accident, thanks to @annando
Roland Häder
2016-12-14 16:36:32 +01:00
b21a1437f4
Also removed this, seems to come in from wrong merging? #3010 Thanks to @annando
Roland Häder
2016-12-14 16:39:39 +01:00
a85470b172
Opps, this has vanished by accident, thanks to @annando
Roland Häder
2016-12-14 16:36:32 +01:00
09a24955df
Use [] instead of test.
Roland Häder
2016-12-14 12:51:20 +01:00
d5b4e09ec4
added lint.sh which needs to be executed like this:
Roland Häder
2016-12-14 12:45:11 +01:00
c75d6ad850
More dbm::is_result() instead of count()
Roland Häder
2016-12-14 12:03:02 +01:00
582b8db8e8
Maybe no longer needed: converted $a->get_baseurl() to App::get_baseurl(). #3010
Roland Häder
2016-12-14 11:55:12 +01:00
cee169997e
Opps, no && and AND in same line (confusing, thanks to @annando)
Roland Häder
2016-12-14 10:02:39 +01:00
042ed17826
removed own debug lines (no more needed).
Roland Häder
2016-12-14 09:58:27 +01:00
036edc2fd0
added extra spaces to make it look nice. #3010
Roland Häder
2016-12-14 09:56:27 +01:00
b5776ab959
Fixes for #3010: - used static call, still App::get_baseurl() wraps it into an object-referencing call which seems to be a bit redundant? - added spaces around dot (see one line below)
Roland Häder
2016-12-14 09:49:52 +01:00
a905522eb5
Cleanup for #3010 - added spaces, thanks to @annando .
Roland Häder
2016-12-14 09:42:36 +01:00
448c5aa694
Cleanup for #3010 - added spaces, thanks to @annando .
Roland Häder
2016-12-14 09:42:28 +01:00
46d383369c
Cleanup for #3010 - added spaces, thanks to @annando .
Roland Häder
2016-12-14 09:41:33 +01:00
dd8d797d9f
Fixes for #3010 - removed baseurl as this is no longer done, still there are 89 left in templates.
Roland Häder
2016-12-14 09:34:13 +01:00
6de232c60a
Cleanup for #3010 - removed all redundant lines found by @rabuzarus
Roland Häder
2016-12-14 09:31:27 +01:00
a8dc8b288c
import dbm here to avoid adding everywhere the namespace (if later changed, only here it needs change, cool ha? ;-)
Roland Häder
2016-12-13 15:24:44 +01:00
797de5bfe0
Nope, get_basepath() should be static, then also mark it as static (in signature).
Roland Häder
2016-12-13 14:53:57 +01:00
63610c7b73
Merge branch 'rewrites/dbm_is_result' of github.com:Quix0r/friendica into rewrites/dbm_is_result
Roland Häder
2016-12-13 11:00:44 +01:00
6a8a36f12d
More usage of dbm::is_result($r) instead of count($r): - count() returns very different results and never a boolean (not even false on error condition). - therefore you should NOT use it in boolean expressions. This still *can* be done in PHP because of its lazyness. But it is discouraged if it comes to more clean code.
Roland Häder
2016-12-13 10:44:13 +01:00
293436e5fd
Some rewrites: - max_proccesses_reach() and maxload_reached() (why no _ behind max?) are called both way, static and with object reference. - this is strongly discouraged and should be avoided as its support (in PHP) may be dropped in future releases. - used $a = get_app(); to encapsulate code (even when the function does currently the same, it may be changed later)
Roland Häder
2016-12-13 10:16:36 +01:00
47c60aa486
Opps, no need for this.
Roland Häder
2016-12-13 10:01:56 +01:00
d489ba1510
Merge remote-tracking branch 'upstream/develop' into develop
Roland Häder
2016-12-13 09:59:43 +01:00
789f13dd00
some issues closed
Tobias Diekershoff
2016-12-12 09:26:46 +01:00
Roland Häder
Michael
Hypolite Petovan
Michael Vogel
Tobias Diekershoff
Thomas Willingham