Commit Graph

8624 Commits

Author SHA1 Message Date
Hypolite Petovan f409bd7034 Remove all-numeric usernames condition
- False negatives aren't recoverable
2021-12-02 08:03:38 -05:00
Hypolite Petovan 1321a52f15 Reformat Probe::getWebfingerArray 2021-12-02 08:02:26 -05:00
Michael 5e912c2965 Unused use removed 2021-12-02 06:37:06 +00:00
Michael 4a90e6b1f0 Test code removed 2021-12-02 06:36:09 +00:00
Michael bd2ee581d3 Diaspora reshares via API are fixed now 2021-12-02 06:33:19 +00:00
Michael 03d2160690 Removed second ppst parameter 2021-11-30 21:41:10 +00:00
Michael 56f8adcb80 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-30 19:07:24 +00:00
Philipp d8ac002001 Fix Introduction user selection 2021-11-30 01:08:00 -05:00
Philipp a88cc8d5c8 Replace DI::apiResponse()->exit() with $this->response->exit() 2021-11-30 01:08:00 -05:00
Philipp 2dc60cfd33 Make API call permission checks more reliable
- don't need to inherit every Module method anymore
2021-11-30 01:07:59 -05:00
Philipp 9cec38f916 Make HTTPInputData dynamic
- Removing DI:: dependency inside App class
- Making testability easier & adapting tests
2021-11-30 01:07:59 -05:00
Philipp 2e4d654c0a Make $_REQUEST processing independent of sub-calls
- Move HTTPInputData::process() into App::runFrontend()
- Pass $_REQUEST (including processed Input) to every Module method
- Delete $_POST parameters at Module post() calls because of $_REQUEST
2021-11-30 01:07:58 -05:00
Philipp f580d8e5c0 extract "BaseApi::checkDefaults()" method for later usage 2021-11-30 01:07:57 -05:00
Michael 7dd757b7f9 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-30 05:48:03 +00:00
Michael 56824598ff Standards 2021-11-30 05:20:01 +00:00
Michael Vogel 3ff59cfdc3
Merge pull request #11045 from MrPetovan/bug/11029-contact-group
Use user-specific id to fetch the list of group appartenance in Module\Contact\Profile
2021-11-30 06:17:56 +01:00
Michael 2470482b4e Standards 2021-11-30 05:07:03 +00:00
Michael 33c8872c65 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-30 05:00:46 +00:00
Michael e7e74819a3 Fix posting pictures 2021-11-29 18:03:34 +00:00
Hypolite Petovan 2ba3b7f771
Merge pull request #11037 from MrPetovan/bug/11023-api-photo-delete
Fix Api\Friendica\Photo|album\Delete endpoints
2021-11-29 08:44:33 -05:00
Michael 6bd9c9f496 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-29 12:52:00 +00:00
Hypolite Petovan cd63533e2c Fix remaining references to BaseModule->parameters 2021-11-29 07:24:32 -05:00
Hypolite Petovan c2df5d66d7 Use user-specific id to fetch the list of group appartenance in Module\Contact\Profile 2021-11-29 07:06:41 -05:00
Hypolite Petovan c7a40906bf Fix Photoalbum delete endpoint
- Fix condition on a removed Item field
2021-11-29 06:29:38 -05:00
Hypolite Petovan e2016bc67d Fix Photo delete endpoint
- Set the request variable type
- Fix the condition on a nonexistant item field
2021-11-29 06:29:38 -05:00
Michael 477b8a91db Added endpoint 2021-11-29 06:09:28 +00:00
Michael 0440765849 Set item permissions on reshare 2021-11-29 04:38:58 +00:00
Michael 71f7679204 Fix function name 2021-11-28 21:40:38 +00:00
Michael cf999e681c Standards 2021-11-28 13:58:26 +00:00
Michael 367479e50e Standards 2021-11-28 13:52:39 +00:00
Michael 19019381e6 Fixes standards 2021-11-28 13:46:30 +00:00
Michael 61f1a4d14d Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-28 13:44:02 +00:00
Michael 222b35684d API: Added more functions, fixed function names 2021-11-28 13:34:00 +00:00
Philipp d576bb136b
Fix BaseApi and corresponding tests 2021-11-28 13:11:12 +01:00
Philipp 4cc36c9b2c
Fix BBCode::expandTags() & Remove AppMockTrait 2021-11-28 13:07:38 +01:00
Michael e381ca6ba0 Added group update 2021-11-27 22:25:40 -05:00
Michael b15d3a2523 API: Next bunch of functions transformed 2021-11-27 22:25:36 -05:00
Hypolite Petovan 9cc675233d Add a second parameter to BaseApi::getRequest to enable API tests 2021-11-27 18:38:09 -05:00
Philipp 056702c1e0
Fixing wrong inherited methodsyntax 2021-11-27 19:58:24 +01:00
Philipp e8ee312d80
Fix Tos Module 2021-11-27 14:11:48 +01:00
Philipp 77b092b4b9
Respect the Dollar(notation :-)) 2021-11-27 13:57:36 +01:00
Philipp 9207b9e408
Fixing https://github.com/friendica/friendica/issues/11033 2021-11-27 13:48:05 +01:00
Philipp 7cba74bb6c
Fix that (raw)content is always executed during Module::run() 2021-11-27 13:41:37 +01:00
Philipp f245fdaa5d
Fix Contact modules 2021-11-27 13:19:26 +01:00
Philipp e4000155f3
Fix Page Header usage 2021-11-27 12:40:58 +01:00
Philipp 6a9fff5100
Fixing Response 2021-11-27 12:40:57 +01:00
Philipp ae24bf8d54
Fixing Response 2021-11-27 12:40:57 +01:00
Philipp 7cd85873ee
Replace IRespondToRequests with PSR-7 ResponseInterface 2021-11-27 12:40:57 +01:00
Philipp 3b2946f98f
Replace header() with $response->setHeader() at BaseModule 2021-11-27 12:40:56 +01:00
Philipp 78c45bd142
Add NodeInfo Module test as an example 2021-11-27 12:40:56 +01:00
Philipp 537b74f307
Inherit ApiResponse from Response 2021-11-27 12:40:54 +01:00
Philipp 561aba18e3
Introduce Response for Modules to create a testable way for module responses 2021-11-27 12:40:38 +01:00
Philipp ad5b0762b0
Fix LegacyModule content return 2021-11-27 12:40:37 +01:00
Philipp 8bdd90066f
Make BaseModule a real entity
- Add all dependencies, necessary to run the content (baseUrl, Arguments)
- Encapsulate all POST/GET/DELETE/PATCH/PUT methods as protected methods inside the BaseModule
- Return Module content ONLY per `BaseModule::run()` (including the Hook logic there as well)
2021-11-27 12:40:36 +01:00
Philipp 238613fd01
Add feedback :) 2021-11-27 12:39:46 +01:00
Philipp b5d2d32b44
Split and delete ModuleController
- $moduleName is part of the argument string => App\Arguments
- $isBackend boolean already part of App\Mode::isBackend()
- $module is now the direct return of App\Router::getModule()
- ModuleController::run() moved to BaseModule::run()
2021-11-27 12:39:45 +01:00
Philipp a5ab184fb8
Merge pull request #11025 from MrPetovan/task/11022-improve-connector-hooks
Improve connector hooks
2021-11-27 12:37:47 +01:00
Philipp e852623c4f
Merge pull request #11030 from MrPetovan/bug/11029-add-remove-group
Add backward compatibility with user contacts in Module\Group
2021-11-27 12:37:18 +01:00
Michael a3e3d87a42 Standards 2021-11-26 21:57:18 +00:00
Michael d128b723c0 Code standards 2021-11-26 21:54:25 +00:00
Michael 0de9ae913b API: moved several lists 2021-11-26 21:48:13 +00:00
Hypolite Petovan 1c5aef0685 Escape dollar sign in replace string to prevent placeholder replacement in Model\Item::addShareDataFromOriginal 2021-11-26 12:38:34 -05:00
Hypolite Petovan 8bfe877629 Add backward compatibility with user contacts in Module\Group 2021-11-26 09:48:37 -05:00
Hypolite Petovan a26322b4c2 Replace args call with parameter from router in Module\Group 2021-11-26 09:48:05 -05:00
Michael 0e3c8e3f5e Mixed parameter order 2021-11-26 08:16:06 +00:00
Michael da9b5f32db Unneeded "use" removed 2021-11-26 07:56:54 +00:00
Michael fb47389c69 API: Fix profile_url handling / missing constant 2021-11-26 07:55:02 +00:00
Hypolite Petovan dbcaf51923
Merge pull request #11018 from annando/api-status
API: The status is now an object
2021-11-25 20:27:15 -05:00
Michael 68316c6e85 Coding standards 2021-11-25 11:31:01 +00:00
Michael 1ff6b1cf18 Coding standards 2021-11-25 11:28:56 +00:00
Michael 9c61bd3ffc Lists and tweet search moved 2021-11-25 11:16:47 +00:00
Michael d696c8d101 Use correct uri-id for attachments 2021-11-25 10:07:25 +00:00
Michael 44555cddb8 More functions moved 2021-11-25 06:00:58 +00:00
Michael 97719ca207 Standards 2021-11-24 23:36:41 +00:00
Michael 6d1d4789f1 Standards ... 2021-11-24 23:35:01 +00:00
Michael 299d70ca1d Standards 2021-11-24 23:31:10 +00:00
Michael 556bcfe78f Some more standards 2021-11-24 23:28:06 +00:00
Michael 260ee13d07 Standards 2021-11-24 23:24:35 +00:00
Michael bd1306d020 Removed whitespace 2021-11-24 23:20:42 +00:00
Michael 242fd646d2 Formatting 2021-11-24 23:06:28 +00:00
Michael c4d52feea5 Many API calls moved 2021-11-24 23:03:34 +00:00
Michael ab28fa32aa Added last status 2021-11-24 20:47:37 +00:00
Hypolite Petovan ba26a56f3d Add missing variable argument operator in BaseModule->t
- This was causing to wrongly pass the variable arguments as an array of variable arguments to L10n->t
2021-11-24 10:57:05 -05:00
Michael 2c7c63a493 Testing tests 2021-11-24 07:29:29 +00:00
Michael dfd63493b2 Standards 2021-11-24 07:14:19 +00:00
Michael a86dee8e59 Coding standards 2021-11-24 07:08:30 +00:00
Michael 57cf384fae Moved acitivites 2021-11-24 07:06:28 +00:00
Michael a3aab4a75a Entities, Source and api functions rearranged 2021-11-24 06:44:25 +00:00
Hypolite Petovan 39c763ce2f Add item_by_link hook to allow connectors to import remote posts 2021-11-23 17:47:02 -05:00
Hypolite Petovan a47830990a Improve probe_detect hook
- Remove Twitter probe from core
- Allow hook function to better abort the probe_detect process
2021-11-23 17:46:20 -05:00
Michael 452cd57437 Fixing tests 2021-11-23 22:02:46 +00:00
Michael 38b641ca6b Coding standards 2021-11-23 21:56:34 +00:00
Michael 07c2f36946 Removing unused functions, added (deactivated) attachments 2021-11-23 21:54:19 +00:00
Michael 082aa1bf65 Code Standards 2021-11-23 15:21:06 +00:00
Michael 4373a66f74 Coding standards 2021-11-23 14:55:52 +00:00
Michael b56ccbcf2b More objects added 2021-11-23 10:12:11 +00:00
Michael Vogel 06284e6007
Merge pull request #11015 from MrPetovan/task/10979-frio-time-tooltip
Move title attribute to <time> tag
2021-11-22 12:45:29 +01:00
Michael 8211cef49d Coding standards, changed database version 2021-11-22 07:39:40 +00:00
Michael 214a0524dd Merge remote-tracking branch 'upstream/develop' into api-status 2021-11-22 07:33:25 +00:00
Michael 670bbe58a1 API: The status is now an object 2021-11-22 07:28:02 +00:00
Hypolite Petovan 23e1130264 Move title attribute to <time> tag
- Use correct machine-readable value in datetime attribute
2021-11-21 22:51:21 -05:00
Hypolite Petovan 204b077353 Move contact profile GET actions to separate module class 2021-11-21 19:22:41 -05:00
Hypolite Petovan 974b750d6d Move contact profile module to its own class 2021-11-21 19:22:39 -05:00
Hypolite Petovan 197c77f43d Move contact conversation to its own module class 2021-11-21 19:21:58 -05:00
Hypolite Petovan eacfcc69c1 Move contact posts to their own module class
- Remove duplicated check for local_user() in Module\Contact
- [frio] Fix display issue for search items where the More button and icon would show but be inactive
2021-11-21 19:21:39 -05:00
Hypolite Petovan 25455eab63 Add new Local relationship classes 2021-11-21 18:59:37 -05:00
Hypolite Petovan f7714c09e6 Fix user-contact rows not being updated in Contact\User::updateByContactUpdate
- Add new update function to regenerate potentially outdated user-contact rows
2021-11-21 18:59:37 -05:00
Hypolite Petovan 84e7f65d52 Move sending follow message to remote server to Protocol class 2021-11-21 18:59:36 -05:00
Hypolite Petovan d011f747ff Remove unused parameter $network in Model\User::getDefaultGroup 2021-11-21 18:59:36 -05:00
Michael e1d4f96b06 Remove unused user fields 2021-11-21 20:14:48 +00:00
Michael f00792d370 Merge remote-tracking branch 'upstream/develop' into api-rework 2021-11-21 17:02:51 +00:00
Michael a4ef4589e6 Reworked friendship API endpoints 2021-11-21 16:59:09 +00:00
Hypolite Petovan e9b3a9426a
Merge pull request #11012 from annando/api-relations
Fix followers/following for the Mastodon API
2021-11-21 10:14:07 -05:00
Michael 87084a3e85 Fix followers/following for the Mastodon API 2021-11-21 14:47:18 +00:00
Hypolite Petovan 23c56b108b
Merge pull request #11003 from annando/fix-api
Fix legacy API
2021-11-21 07:55:25 -05:00
Michael 0e5f876680 function moved 2021-11-21 09:55:42 +00:00
Michael 2c6afe65a7 Use correct function to fetch the self user 2021-11-21 00:26:35 +00:00
Michael ae99144f57 Tests again 2021-11-21 00:15:36 +00:00
Michael c732027b04 Tests ... 2021-11-21 00:14:38 +00:00
Michael 0f09b4f636 Fixing (some) tests 2021-11-20 23:47:03 +00:00
Michael 647ecd4bd3 Relocate RSS header stuff, cleaning up the code 2021-11-20 13:44:12 +00:00
Michael 4327ccddcb Some more removed functions and parameters 2021-11-20 09:36:17 +00:00
Hypolite Petovan 88a327ba63
Merge pull request #11004 from nupplaphil/bug/module_const
`Module::init()` Fixings
2021-11-19 18:00:05 -05:00
Hypolite Petovan 5a9ef594bf
Merge pull request #10999 from nupplaphil/bug/configcache_set
Fix Installer setup
2021-11-19 17:59:32 -05:00
Philipp efe5d641a2
Fixing Mainentance & Exception vie 2021-11-19 22:51:12 +01:00
Michael d576e920d5 Fix legacy API 2021-11-19 20:15:12 +00:00
Philipp 296a9070a0
Fix LegacyModule init() 2021-11-19 20:21:37 +01:00
Philipp 645e4edc63
Revert "Revert "Replace Module::init() with Constructors""
This reverts commit 89d6c89b67.
2021-11-19 20:18:48 +01:00
Hypolite Petovan 89d6c89b67
Revert "Replace Module::init() with Constructors" 2021-11-19 07:23:23 -05:00
Hypolite Petovan 0b6e0566d7
Merge pull request #10987 from annando/api4
API: moved classes / unified user array creation
2021-11-19 06:13:52 -05:00
Philipp 2a22ddcf85
Fix Installer setup
- value "0" can now be saved
2021-11-19 08:48:44 +01:00
Philipp dab9e13c69
Replace $this->l10n->t() with $this->t() for Modules 2021-11-18 23:23:58 +01:00
Michael 8fd738f550 Removed "api_get_user" 2021-11-18 22:20:19 +00:00
Michael 1f79d25ffc Replaced "api_date" 2021-11-18 21:43:13 +00:00
Philipp 04a0cd9301
Add feedback 2021-11-18 21:25:09 +01:00
Philipp 14988ddf19
Replaced DI:: calls at BaseNotifications.phpt 2021-11-18 21:23:43 +01:00
Michael b67c10812a Merge remote-tracking branch 'upstream/develop' into api4 2021-11-18 20:15:57 +00:00
Michael 7c03eba98e Removed unused code 2021-11-18 14:49:12 +00:00
Michael 3dd35ef6ec Possibly fixing the test 2021-11-18 08:03:50 +00:00
Michael 42bd7918ad allow_api removed 2021-11-18 07:14:23 +00:00
Michael 3c0f22b2dd Testing tests 2021-11-17 22:50:43 +00:00
Michael abbe7895ae Fixing tests - maybe 2021-11-17 22:12:21 +00:00
Michael cdedf348e4 Replaced most "api_get_user" calls with newer BaseApi calls 2021-11-17 21:28:51 +00:00
Philipp ce578a7745
Replace Module::init() with Constructors 2021-11-17 22:14:33 +01:00
Philipp de6bb280b1
Hotfix: Deleted content 2021-11-17 13:39:48 +01:00
Hypolite Petovan 190efcefad
Merge pull request #10977 from nupplaphil/feat/dynamic_modules
Introduce interface for `Module`s
2021-11-17 06:36:54 -05:00
Philipp e73eda0156
Add feedback 2021-11-17 08:16:33 +01:00
Michael a9e1847afd Some more comments added 2021-11-17 06:36:12 +00:00
Michael eaf4bc6d4f Added contact 2021-11-17 06:28:39 +00:00
Philipp 804408e4bb
Update src/App/ModuleController.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-17 06:57:48 +01:00
Philipp 61a507000f
Update src/App/ModuleController.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-17 06:57:37 +01:00
Michael 2bb1805a67 Added profile picture 2021-11-16 23:57:12 +00:00
Michael 6ea426178a API: moved classes / unified user array creation 2021-11-16 23:21:40 +00:00
Philipp 766b3f0d01
Fixups 2021-11-16 22:40:39 +01:00
Philipp 90cde9898b
Update src/Capabilities/ICanHandleRequests.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-16 22:40:39 +01:00
Philipp c95d47b0b4
Refactor App\Module to App\ModuleController and rename properties 2021-11-16 22:40:39 +01:00
Philipp 8f741c8b78
Remove afterpost() handling 2021-11-16 22:40:38 +01:00
Philipp 85304b6e8f
Update src/App/Page.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-16 21:12:12 +01:00
Philipp 2f4e19a82f
Update src/App/Module.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-16 21:11:47 +01:00
Hypolite Petovan 877b90f7f0
Merge pull request #10986 from annando/issue-10983
Issue 10983: Use the user's settings for the help language
2021-11-16 06:57:33 -05:00
Michael 59787d718d Remove spaces 2021-11-16 07:04:39 +00:00
Michael Vogel ba031e4534
Update src/Module/Help.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-16 07:36:20 +01:00
Michael 84e62b5293 Issue 10983: Use the user's settings for the help language 2021-11-15 22:08:51 +00:00
Philipp cca1be21a3
Fixed static leftovers from #10975 2021-11-14 23:49:07 +01:00
Philipp 5879535822
Switch static::$parameters to $this->parameters 2021-11-14 23:49:07 +01:00
Philipp 489cd0884a
Make BaseModule methods dynamic 2021-11-14 23:49:06 +01:00
Philipp 714f0febc4
Replace $parameters argument per method with static::$parameters 2021-11-14 23:49:05 +01:00
Philipp 018275919c
Create interface for static Module calls 2021-11-14 23:30:04 +01:00
Philipp 2edb631b1f
Fix PHP-CS 2021-11-14 23:21:57 +01:00
Michael 66db55f0cd
Some more API functions moved 2021-11-14 23:21:54 +01:00
Philipp e7f84d4934
Move Api\unsupported tests and remove dependency to System::jsonExit() 2021-11-12 22:44:59 +01:00
Philipp 7797c3a0a8
Migrate API\error tests and fix ApiResponse for RSS/atom 2021-11-12 22:29:58 +01:00
Philipp 2c407a7323
Small improvement 2021-11-12 21:38:38 +01:00
Philipp 6725f05ab2
Moved API\Notification tests 2021-11-12 21:35:21 +01:00
Philipp e477cf215d
Make API testable & move PhotoAlbum tests to new destination 2021-11-12 21:08:36 +01:00
Philipp a0c5c91886
Simplify code 2021-11-12 20:13:04 +01:00
Philipp a9ddd6687b
Replace Logger:: with logger property 2021-11-12 20:08:30 +01:00
Philipp 5bfcc8b91c
Transform ApiResponse::unspported() into dynamic method 2021-11-12 20:07:05 +01:00
Philipp ebf56674f1
Transform ApiResponse::error() into dynamic method 2021-11-12 20:04:47 +01:00
Philipp ea0f41ecf0
Transform ApiResponse::exit() into dynamic method 2021-11-12 20:03:27 +01:00
Philipp 4309f814e0
Transform ApiResponse::formatData() into dynamic method 2021-11-12 19:59:16 +01:00
Philipp f28e64299e
Transform ApiResponse::createXML() into dynamic method 2021-11-12 19:56:37 +01:00
Philipp 319f91301d
Move API Response methods into an own class to make them mockable 2021-11-12 19:52:01 +01:00
Michael Vogel 4587cef677
Update src/Module/Api/Friendica/DirectMessages/Setseen.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-11 18:46:04 +01:00
Michael 293775ab4a Photo delete is moved as well 2021-11-10 23:31:42 +00:00
Michael 02210f285b API: some more converted functions 2021-11-10 23:07:46 +00:00
Michael 17fafd37dd Removed spaces 2021-11-10 07:38:48 +00:00
Michael 1518ad33ad API: Classes moved to the correct places according to their origin 2021-11-10 07:31:39 +00:00
Michael Vogel 58ffded0c8
Update src/Module/BaseApi.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-10 04:44:59 +01:00
Michael 1c84928727 Fix test 2021-11-09 23:04:07 +00:00
Michael bbc4fe851b "init" removed, moved error function 2021-11-09 22:59:58 +00:00
Michael 28a28517e5 Fix code standards 2021-11-09 21:50:56 +00:00
Michael b6943aff36 API call rate_limit_status moved 2021-11-09 21:41:37 +00:00
Michael a6db8df92d Using the "extension" parameter 2021-11-09 19:40:39 +00:00
Michael fb6c3e2912 Simplify the output of api results 2021-11-09 06:42:59 +00:00
Michael Vogel 83056df565
Update src/Util/Arrays.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-09 06:23:04 +01:00
Michael a66bb09b40 Moved function to Arrays.php 2021-11-08 22:10:07 +00:00
Michael ac1b8b7b3a Remove space 2021-11-08 21:54:55 +00:00
Michael 3e676f9cf0 Fixed tabs 2021-11-08 21:53:34 +00:00
Michael f5b47fccce API: spme Functionality is transferred to new places 2021-11-08 21:35:41 +00:00