Michael Vogel
790875d8be
Apply suggestions from code review
...
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-04 21:06:13 +02:00
Michael
b2c2283817
separate parameter values for different functionalities
2021-10-04 18:04:41 +00:00
Michael
9eba41598d
Code review changes
2021-10-04 14:01:46 +00:00
Michael
126aa6f148
Fix tests
2021-10-04 06:26:41 +00:00
Michael
43a17b6129
Merge remote-tracking branch 'upstream/develop' into photo-guid
2021-10-04 06:21:19 +00:00
Michael Vogel
c714595b70
Merge pull request #10821 from MrPetovan/bug/notices
...
Relax check on id parameter in /photo
2021-10-04 08:18:52 +02:00
Michael Vogel
2a8d8d402c
Merge pull request #10822 from MrPetovan/bug/fatal-errors
...
Trim XML before emptiness check in Protocol\Feed::import
2021-10-04 08:17:35 +02:00
Michael Vogel
6275159761
Merge pull request #10819 from MrPetovan/task/refactor-notifications
...
Cast object parameters to string in Database\Database
2021-10-04 08:16:58 +02:00
Michael
d30dc52101
Access contact avatars by guid
2021-10-04 06:13:52 +00:00
Hypolite Petovan
297ff76590
Relax check on id parameter in /photo
...
- Address https://github.com/friendica/friendica/issues/10756#issuecomment-933020126
- Address https://github.com/friendica/friendica/issues/10755#issuecomment-933020316
2021-10-03 20:59:47 -04:00
Hypolite Petovan
42e77e23ac
Add logging to track a Notice messages
...
- Part of https://github.com/friendica/friendica/issues/10755#issuecomment-933040517
2021-10-03 20:59:41 -04:00
Hypolite Petovan
a4706e9521
Trim XML before emptiness check in Protocol\Feed::import
...
- Address https://github.com/friendica/friendica/issues/10791
2021-10-03 19:32:20 -04:00
Michael
1d86d79778
Merge remote-tracking branch 'upstream/develop' into more-q
2021-10-03 19:49:11 +00:00
Michael Vogel
caa1a5aeac
Merge pull request #10818 from MrPetovan/task/10691-remove-event-adjust
...
Display the current timezone in date time picker fields
2021-10-03 21:46:33 +02:00
Michael
b0bf4b4359
Some more "q" calls and deprecated logging replaced
2021-10-03 19:43:49 +00:00
Hypolite Petovan
24734b05fe
Cast object parameters to string in Database\Database
...
- This makes string casting in Depository->save unnecessary
2021-10-03 15:35:47 -04:00
Hypolite Petovan
c40390c202
Revert "Explicitly cast Url objects to string"
...
This reverts commit ee5aa2d432
.
2021-10-03 15:22:40 -04:00
Michael Vogel
dd3f573fec
Merge pull request #10817 from MrPetovan/task/refactor-notifications
...
Explicitly cast Url objects to string
2021-10-03 21:03:03 +02:00
Hypolite Petovan
ee5aa2d432
Explicitly cast Url objects to string
...
- Some systems do not do this operation automatically and it results in empty DB fields
2021-10-03 14:53:06 -04:00
Hypolite Petovan
a31a64827f
Display the current timezone in date time picker fields
2021-10-03 13:42:32 -04:00
Hypolite Petovan
a9bb53b021
[frio] Fix event time display
2021-10-03 13:42:32 -04:00
Hypolite Petovan
9935e8e711
Remove event.adjust field
...
- It was confusing and introduced complexity that wasn't worth the unclear gain
2021-10-03 13:42:32 -04:00
Hypolite Petovan
6db211568a
Remove most calls to date_default_timezone_* calls
...
- It was wrongly used to set the node-wide ot user-specific timezone
- It is now fully managed from the App object
- Add a static variable to DateTimeFormat maintain the convenient local() method
2021-10-03 13:42:31 -04:00
Tobias Diekershoff
08c24fd4fa
Merge pull request #10816 from MrPetovan/task/refactor-notifications
...
Check if the string representation of Notify->link is empty in Module\Notifications\Notification
2021-10-03 17:39:14 +02:00
Hypolite Petovan
e91ba2b992
Check if the string representation of Notify->link is empty in Module\Notifications\Notification
...
- The property is a Url object which will always return true when tested for truthy value
2021-10-03 11:34:23 -04:00
Michael
6668591afe
Merge remote-tracking branch 'upstream/develop' into more-q
2021-10-03 15:06:31 +00:00
Michael
763e264196
More "q" calls have been replaced
2021-10-03 15:02:20 +00:00
Michael Vogel
3d97149007
Merge pull request #10722 from MrPetovan/task/refactor-notifications
...
Move notify, notifications and introduction notifications to new paradigm
2021-10-03 14:13:28 +02:00
Hypolite Petovan
c84d4104e8
Add missing Module\Photo route for post-media id with no customsize
2021-10-03 07:58:52 -04:00
Hypolite Petovan
5112dd06f2
Add missing Module\Photo route for contact avatar
2021-10-03 07:48:46 -04:00
Michael
9961943b73
Code Style: Replace "AS" with "as"
2021-10-03 10:34:41 +00:00
Hypolite Petovan
c1ab3801ba
Replace remaining reference to Model\Photo::stripExtension
2021-10-03 05:52:53 -04:00
Michael
42790fbc1f
Don't store emoji images as media but links
2021-10-03 09:42:14 +00:00
Hypolite Petovan
8cb0bb5deb
Switch uid with nickname in user picture URLs
...
- Keep previous URL scheme fallback as remote contact avatar URLs pointing to local user avatar URLs need to update
2021-10-02 19:06:59 -04:00
Hypolite Petovan
7cdd2d1336
Refactor User::getAvatarUrlForId into getAvatarUrl
...
- Use user/owner array as parameter instead of uid
- Rename $profile variables to $owner when it's the result of User::getOwnerDataByNick
- Replace Module\Photo::stripExtension with native pathinfo() calls
2021-10-02 19:06:25 -04:00
Hypolite Petovan
4f42522ebc
Simplify Depository\Notify->selectAllForUser parameters
...
- Shifts database structure knowledge from the controller to the depository where it should be
2021-10-02 18:15:45 -04:00
Hypolite Petovan
8a1a2f658c
Create new DI shorthands for notification-related factories
2021-10-02 18:15:45 -04:00
Hypolite Petovan
7a2d5f6a8e
Move notification to the new paradigm
2021-10-02 18:15:45 -04:00
Hypolite Petovan
bc0734e0f1
Move notification introductions to the new paradigm
2021-10-02 18:15:45 -04:00
Hypolite Petovan
43e5b317ed
Add new paradigm classes for notification and introduction notifications
...
- Add support for bounded select in BaseDepository
2021-10-02 18:15:44 -04:00
Hypolite Petovan
3e6fea30f2
Create constants for Mastodon notification types
2021-10-02 18:15:44 -04:00
Hypolite Petovan
ea6f7aba40
Fix method name typos in Model\Post\UserNotification
...
- Reformat file, improve type-hinting
2021-10-02 18:15:43 -04:00
Hypolite Petovan
dae5703e5c
Improve accuracy of accepted parameter types in phpDoc of Database->fetch
...
- Suppresses an unwarranted type error raised by static analyzers
2021-10-02 18:15:43 -04:00
Hypolite Petovan
bf81f21001
Rename Model\Post\UserNotifications type constants
2021-10-02 18:15:43 -04:00
Hypolite Petovan
47acb6a278
Move notify to the new paradigm
...
- Remove unused frion notify template
- Update API test
2021-10-02 18:15:42 -04:00
Hypolite Petovan
1b4e3564a5
Add new paradigm classes for notify
...
- Create BaseDepository class
- Create Entity, Collection, Factory and Depository classes
- Create FormattedNotification Entity, Collection and Factory to remove business logic from Notify repository
- Create new NotificationCreationIntercepted exception to allow addons to cancel notification creation
- Remove unused frio notifications/notify.tpl template
2021-10-02 18:15:34 -04:00
Hypolite Petovan
810699b454
Merge pull request #10803 from nupplaphil/feat/message_log
...
Forgot one Logpoint ..
2021-10-02 17:41:34 -04:00
Hypolite Petovan
ce7d394ff9
Merge pull request #10801 from annando/network-thread-view
...
Fixing "Unknown column 'network-thread-view.uri-id'"
2021-10-02 17:40:00 -04:00
Michael Vogel
2a442952b6
Merge pull request #10800 from MrPetovan/task/10739-block
...
Add block and unblock hooks
2021-10-02 23:39:06 +02:00
Hypolite Petovan
66fec8944f
Add block and unblock hooks
2021-10-02 17:30:40 -04:00
Hypolite Petovan
bd42f5757f
Implement relationship termination for Mastodon block
...
- This is the expected Mastodon behavior on block
2021-10-02 17:30:07 -04:00
Hypolite Petovan
b0d8136b00
Remove contact record instead of setting rel = 0 in Contact::revokeFollow
2021-10-02 17:30:03 -04:00
Philipp
254c32ac91
Forgot one Logpoint ..
2021-10-02 23:27:15 +02:00
Michael Vogel
fc9ac0ff46
Update src/Module/Conversation/Network.php
...
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-02 23:18:54 +02:00
Philipp
80753ed1b6
Remove disturbing/superfluous logging messages
2021-10-02 23:11:33 +02:00
Michael
eea355ae3b
Merge remote-tracking branch 'upstream/develop' into network-thread-view
2021-10-02 21:00:10 +00:00
Michael
bd85babc3e
Fixing "Unknown column 'network-thread-view.uri-id'"
2021-10-02 20:56:11 +00:00
Hypolite Petovan
c4a4473cd0
Remove the obsolete parameter $two_way from terminateFriendship methods
...
- Follow revokation is now done independently
2021-10-02 16:14:22 -04:00
Hypolite Petovan
222333f64f
Remove contact drop feature
...
- Feature was confusing, sometimes ineffective and overall overlapping with unfollow/block
2021-10-02 16:04:28 -04:00
Michael
1550c0cf13
Reverted unneeded changes
2021-10-02 19:33:51 +00:00
Michael
afa611bd50
The media class moved
2021-10-02 19:31:27 +00:00
Michael
da3fbced38
Merge branch 'contact-media' of github.com:annando/friendica into contact-media
2021-10-02 18:35:47 +00:00
Michael
2408ac8227
Merge remote-tracking branch 'upstream/develop' into contact-media
2021-10-02 18:35:43 +00:00
Michael Vogel
a2f5190bdb
Update src/Model/Contact.php
...
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-02 20:31:30 +02:00
Hypolite Petovan
72fae04e97
Add revoke follow feature
...
- Add new follow revoke module
- Add new hooks: revoke_follow, support_follow, support_revoke_follow
- Add link in contact page action menu
2021-10-02 14:01:46 -04:00
Hypolite Petovan
9918fa3ec0
Move translation strings in their own array for confirm templates
2021-10-02 13:52:54 -04:00
Hypolite Petovan
e6aef548fb
ActivityPub: Update relation when receiving a follow reject message
2021-10-02 13:52:54 -04:00
Michael
c822cdaebd
Removing "blubb"
2021-10-02 17:47:11 +00:00
Tobias Diekershoff
8dc4499bcf
Merge pull request #10797 from annando/diaspora-deprecated
...
Replaced deprecated code from the Diaspora implementation
2021-10-02 19:19:40 +02:00
Michael
e5ffda3478
Replaced deprecated code from the Diaspora implementation
2021-10-02 17:11:54 +00:00
Michael
a44d200c21
Merge remote-tracking branch 'upstream/develop' into contact-media
2021-10-02 15:13:55 +00:00
Michael
c3554ac0f4
"Video" is replaced by a "Media" tab in contact and profile
2021-10-02 15:09:43 +00:00
Hypolite Petovan
797391e1d8
Rework contact termination to separate protocol-level and contact-level
...
- Mail and Feed contacts are now removed automatically on relationship termination
- Added logging and notice messages for different results
2021-10-02 08:31:59 -04:00
Michael
865006682a
Merge remote-tracking branch 'upstream/develop' into user-contact
2021-10-02 11:57:43 +00:00
Michael
1979b4775d
New functionality to display media posted by a contact
2021-10-02 11:55:22 +00:00
Hypolite Petovan
de2352e34d
Merge pull request #10794 from annando/q-removed
...
"q" call is replaced
2021-10-02 07:44:33 -04:00
Michael
666cff7d55
"q" call is replaced
2021-10-02 11:08:12 +00:00
Michael
f1e2ceb32c
Issue 10747: Improved check for blocked domains
2021-10-02 10:25:50 +00:00
Hypolite Petovan
dae3e7d4c7
Merge pull request #10787 from fabrixxm/issue/10767
...
Mark string translatable in View logs
2021-10-01 11:08:11 -04:00
fabrixxm
e8c0d5d445
Logs view: remove unneeded tpl var
2021-10-01 17:00:06 +02:00
fabrixxm
0638e23f7a
Mark string translatable in View logs
...
and update messages.po
2021-10-01 16:46:55 +02:00
Tobias Diekershoff
3727be9d6c
Merge pull request #10786 from annando/sanitize-addon-author
...
Sanitize the addon author if it is not a valid URL but a handle
2021-10-01 15:30:30 +02:00
Michael
19d5987c9d
Sanitize the addon author if it is not a valid URL but a handle
2021-10-01 13:25:00 +00:00
Tobias Diekershoff
786596fec5
remove superfluous characters from warning messages in the admin panel
...
\r\n was shown in the warning messages of the admin panel log view page. They have
been removed. Additionally the messages.po file has been regenerated.
2021-10-01 14:02:27 +02:00
Hypolite Petovan
d9cd2f5bca
Merge pull request #10773 from annando/issue-10772
...
Issue 10772: Avoid duplicated links in AP posts
2021-09-28 07:03:39 -04:00
Michael
5a7bd4884a
Issue 10772: Avoid duplicated links in AP posts
2021-09-27 20:26:08 +00:00
fabrixxm
eadcc8dc93
Handle reading empty file in ReversedFileReader
...
fix #10766
2021-09-27 12:14:19 +02:00
Michael
e4b8536c75
Removing MySQL workaround
2021-09-26 18:30:44 +00:00
Michael
f26226229a
Issue 10768: Avoid MySQL problems when upgrading both index and structure
2021-09-26 17:13:26 +00:00
Hypolite Petovan
2a88262732
Merge pull request #10760 from annando/conversation-moved
...
The conversation functionality moved to a class
2021-09-26 10:03:26 -04:00
Michael
1bb25de287
Applied change from PR #10763
2021-09-26 12:17:30 +00:00
Hypolite Petovan
0bb169b4ed
Check for reply existence before using its values in Model\Mail
...
- Address https://github.com/friendica/friendica/issues/10474#issuecomment-925263894
2021-09-26 08:15:07 -04:00
Hypolite Petovan
9d77958247
Ensure parent exists before adding reply to elements in OStatus and Feed
...
- Address https://github.com/friendica/friendica/issues/10474#issuecomment-927118628
2021-09-26 08:15:07 -04:00
Michael
e08c5ca2e0
Another try ...
2021-09-26 04:16:21 +00:00
Michael
1e583b4f35
Space removed
2021-09-26 04:07:02 +00:00
Michael
171cbf0512
Removed spaces
2021-09-26 04:05:46 +00:00
Michael
96055cafff
Merge remote-tracking branch 'upstream/develop' into conversation-moved
2021-09-26 03:57:31 +00:00
Michael
a2532ad755
Merge remote-tracking branch 'upstream/develop' into user-contact
2021-09-26 03:07:59 +00:00
Hypolite Petovan
d8febbe45e
Add new hook to support unfollow contacts on non-native networks
2021-09-25 16:15:06 -04:00
Michael
1f96742695
Merge remote-tracking branch 'upstream/develop' into conversation-moved
2021-09-25 18:38:50 +00:00