clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
35,130 Commits 3 Branches 0 Tags 183 MiB
Commit Graph

10004 Commits

Author SHA1 Message Date
Roland Häder 39675fe683
Space for the rescue. ;-) 2022-06-25 16:48:35 +02:00
Roland Häder b0693c1ad7
Reformatted array 2022-06-25 16:48:35 +02:00
Roland Häder f12cc9648e
Changes: 
- added some type-hints
- changed some double-quotes to single
 2022-06-25 16:48:35 +02:00
Hypolite Petovan aa133b5437 Add explicit gserver.site_name string truncate in Model\GServer 
- Avoids "Data too long for column 'site_name'" database errors
 2022-06-25 06:25:48 -04:00
Hypolite Petovan a2afb101cd Fix off-by-one error in Message ID header count check in Util\Emailer 2022-06-25 05:35:24 -04:00
Hypolite Petovan c75dbfd3d7 Update default value for LocalRelationship->priority to avoid null values 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166192993
 2022-06-25 05:06:22 -04:00
Hypolite Petovan 636b84b41c Update return value type-hint of GServer::getProtocol 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1164880874
 2022-06-25 05:06:22 -04:00
Hypolite Petovan c5b46fe748
Merge pull request #11681 from Quix0r/fixes/item-guidfromuri-allow-null 
Allowing Item::getFromUri()'s 2nd parameter a null value
 2022-06-24 10:15:26 -04:00
Roland Häder 82bb36e13d
Changes: 
- Made Item::guidFromUri()'s $host parameter optional (allowing null)
- added some type-hints
- added documentation
- this may fix reported issue in #11630
 2022-06-24 03:17:57 +02:00
Philipp 2dc38e5632
Move documentation :-) 2022-06-23 23:23:36 +02:00
Philipp 5bf5b5e6c9
adaptions :-) 2022-06-23 23:01:09 +02:00
Philipp 12ba37e8d2
add more doc 2022-06-23 22:46:46 +02:00
Philipp 13783089e7
Add copyright 2022-06-23 22:44:17 +02:00
Philipp d441b90bda
Respect Forwarded-For headers 2022-06-23 22:42:35 +02:00
Roland Häder 657a8a7cb5
Changes: 
- documented null value
- two ' to much!
 2022-06-23 17:30:17 +02:00
Roland Häder 202857ba7d
No need to log $tid here 2022-06-23 17:30:17 +02:00
Roland Häder fd8f4269ff
Reformatted code 2022-06-23 17:30:17 +02:00
Roland Häder 5699b03e8d
Changes: 
- added some nodes to OpenSearch descriptor
- still no UTF-8 encoding!
- added some type-hints
 2022-06-23 17:30:16 +02:00
Roland Häder a49fb9cbf9
Changes: 
- added some type-hints
- added documentation
 2022-06-23 17:30:16 +02:00
Roland Häder 84d3eecc33
Changes: 
- added some type-hints
- changed double-quotes to single
 2022-06-23 17:30:15 +02:00
Roland Häder 57e741f2cf
More type-hints added 2022-06-23 17:30:15 +02:00
Roland Häder 182c3db9b8
Changes: 
- added type-hints
- added missing documentation
 2022-06-23 17:30:15 +02:00
Roland Häder b8353a6eb7
Changes: 
- reformatted some array
- added missing documentation
- added type-hints
- changed double-quotes to single
 2022-06-23 17:30:14 +02:00
Roland Häder c6c936a80f
Added more type-hints 2022-06-23 17:30:14 +02:00
Roland Häder 3f74a59f73
Added some type-hints 2022-06-23 17:30:14 +02:00
Roland Häder 69a68be800
Added some missing type-hints 2022-06-23 17:30:13 +02:00
Roland Häder d8ff966d21
Throw IAE again (should never become visible) 2022-06-23 17:30:13 +02:00
Roland Häder 35c78ce14c
Ops, cannot return Thread? 2022-06-23 17:30:12 +02:00
Roland Häder c2e26b4f49
Changed: 
- Introduced InvalidArgumentException (should never come)
- added type-hints
 2022-06-23 17:30:12 +02:00
Roland Häder 2f3705f471
Continued: 
- renamed varibales to $camelCase
- added type-hints
- updated documentation
 2022-06-23 17:30:11 +02:00
Roland Häder 0ddb315b23
$id in Transmitter::sendContactAccept() is a string, see Introduction class 2022-06-23 16:48:00 +02:00
Hypolite Petovan bf600905d3
Merge pull request #11676 from Quix0r/fixes/array-element-missing 
Maybe this fixes missing array element
 2022-06-23 09:06:59 -04:00
Roland Häder 636fef26f1
Maybe this fixes missing array element 2022-06-23 07:40:49 +02:00
Roland Häder 589d0360a4
So simple ... Ops! 2022-06-23 04:58:45 +02:00
Roland Häder 69676c9f7b
Changes: 
- enabled sub-directories for compiled/cached files which avoids large+slow
  directory descriptors
- changed some double-quotes to single
 2022-06-23 04:24:55 +02:00
Roland Häder 7eefb9aed8
Changed: 
- empty() is maybe superflous here, still I would prefer a code style that is
  written explicitly and not rely on "magic casting"
 2022-06-22 18:57:01 +02:00
Roland Häder 15d8341d9a
Converted multiple single-comment (//) to multi-line comment block (/* */) 2022-06-22 18:06:35 +02:00
Roland Häder b996712ef7
Images::getInfoFromURL[Cached]() will both return empty arrays on error and 
that needs to be reflected here, too.
 2022-06-22 17:20:59 +02:00
Roland Häder eb231bc548
Fixed: ?? didn't work here as bool won't be seen as null 2022-06-22 17:09:53 +02:00
Philipp 78bf7f187c
Merge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode 2022-06-22 16:51:23 +02:00
Roland Häder d5441da49a
Fixed: 
- TypeError: "Argument 1 passed to Friendica\Util\XML::escape() must be of the
  type string, null given, called in src/Util/XML.php line 171
 2022-06-22 16:20:26 +02:00
Roland Häder 101cd2dd10
Changes: 
- added some documentation
- fixed some documentation
- changed more double-quotes to singl
 2022-06-22 16:14:14 +02:00
Roland Häder ba45e59313
Changes: 
- added more type-hints
- added missing documentation
- Email::send() now returns what mail() returns (bool)
 2022-06-22 14:36:48 +02:00
Roland Häder ee8d0ad619
Changes: 
- added more type-hints
- added some documentation
 2022-06-22 14:36:47 +02:00
Roland Häder feec96cbc4
Return empty array on error (I hope it works this way). 2022-06-22 14:36:47 +02:00
Roland Häder 2dd7d465e8
Changes: 
- added more type-hints
- updated documentation
- changed double-quotes to single
 2022-06-22 14:36:47 +02:00
Roland Häder 74ab7648c6
Changes: 
- addHubLink()'s 2nd parameter is DOMElement
- added more type-hints
- converted double-quotes to single
 2022-06-22 14:36:46 +02:00
Roland Häder 12add2fb64
$data can turn into bool here 2022-06-22 14:36:46 +02:00
Roland Häder 08f55f0358
Ops, forgot to rename these, too. 2022-06-22 14:36:46 +02:00
Roland Häder abd0d9f3fd
Changes 
- added type-hints
- added some documentation
- added default: block for unknown 'rel' value
- changed return type void to empty array
 2022-06-22 14:36:45 +02:00
Roland Häder dfa95ea58d
Changes: 
- added type-hints
- added documentation
 2022-06-22 14:36:45 +02:00
Roland Häder 84bfc37bf1
Changes: 
- added more type-hints
- added missing documentation
 2022-06-22 14:36:45 +02:00
Hypolite Petovan e9f7bb477d Add expected type-hint to BoundariesPager::renderFull 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1162634199
 2022-06-22 07:49:45 -04:00
Hypolite Petovan 7295138f8d Remove type-hint inconsistent with expected return value in Database->getVariable 2022-06-22 07:47:15 -04:00
Hypolite Petovan d68f307337 Remove email subject encoding from ItemCCEmail constructor 
- It was wrongly re-encoded in Emailer::send
 2022-06-21 21:12:09 -04:00
Roland Häder 2f358607c7
Changes: 
- renamed Logger::getLogger() to getInstance() (@MrPetovan)
 2022-06-22 01:50:10 +02:00
Roland Häder cdcfb4064b
Changes: 
- added type-hints
- added missing documentation
- renamed Logger::getWorker() to Logger::getLogger() as there is no worker class
  returned but the actual (inner) logger
 2022-06-21 21:22:16 +02:00
Roland Häder 80c8ec17c2
Fixed documentation 2022-06-21 18:43:25 +02:00
Roland Häder 0332a57bfd
Rewrote to suggestions from @MrPetovan (I tried to maintain the old way of 
['scheme' => 'table'] with my version).
 2022-06-21 18:13:01 +02:00
Roland Häder 5fe428d3e4
Fixed: 
- PHPUnit\Framework\Error\Notice:  Undefined index: language in /.../src/Util/EMailer/MailBuilder.php on line 122
 2022-06-21 13:47:40 +02:00
Roland Häder 1080a840f5
Changes: 
- Database->$driver can no longer be NULL, an empty string is fine anyway
 2022-06-21 13:47:39 +02:00
Roland Häder 945cd1a2c2
Fixed: 
- since $table can be now schema.table, this needs being taken care off
- maybe this foreach(explode()) is a bit an overkill as only 1 or 2 entries
  can be found in it
 2022-06-21 13:47:39 +02:00
Roland Häder 0d81a08e3c
WIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed? 2022-06-21 13:47:39 +02:00
Roland Häder 44a9ec9b17
Rewrite: 
- avoid having array|string for $table to have a "string" type-hint for $table
- you now have to do it for yourself by giving 'schema.table' as parameter
 2022-06-21 13:47:38 +02:00
Roland Häder f62c28008a
Removed comment 2022-06-21 13:47:38 +02:00
Roland Häder cefffde691
Changes: 
- added type-hints
- added some missing documentation
 2022-06-21 13:47:37 +02:00
Roland Häder f1867463a0
Changes: 
- added more type-hints
 2022-06-21 13:47:37 +02:00
Roland Häder 77c37ff2db
Fixed: 
- Uncaught Exception TypeError: "Argument 3 passed to
  Friendica\Protocol\DFRN::createActivity() must be of the type string, null
  given, called ..."
 2022-06-21 13:47:37 +02:00
Tobias Diekershoff 4650ff53d9
Merge pull request #11662 from MrPetovan/bug/11661-splitattachment-null 
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
 2022-06-21 06:48:52 +02:00
Hypolite Petovan d2ca812647
Merge pull request #11660 from Quix0r/fixes/more-type-hints-003 
More type-hints - Batch 003
 2022-06-20 21:53:17 -04:00
Roland Häder 3e522ed512
Fixed: 
- prevent NULL from being handled over to XML::escape()
- still I wonder that an object can be? It is a string-only accepting method
 2022-06-21 01:42:37 +02:00
Roland Häder 95f9eb34ac
Fixed indenting 2022-06-21 01:29:33 +02:00
Roland Häder b6fa022a73
Changes: 
- added type-hints
- added some documentation
- marked some generic methods to be moved to Util\Strings class instead
 2022-06-20 23:50:24 +02:00
Roland Häder fbae0b8bcf
Changes: 
- renamed ItemArrayFromMail() to getItemArrayFromMail() to follow naming-convetion
- added missing type-hints
- added missing documentation
 2022-06-20 21:22:46 +02:00
Roland Häder ea22e88896
Added documentation 2022-06-20 21:02:34 +02:00
Roland Häder 752953e472
Changes: 
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean
 2022-06-20 21:00:19 +02:00
Hypolite Petovan 88eacbf66e Ensure parameter 4 of Post\Media::splitAttachment is a boolean value 2022-06-20 14:34:02 -04:00
Roland Häder 0c12e947dd
Changes: 
- null was 2nd argument's value before, an empty string is basically the same here
 2022-06-20 20:01:59 +02:00
Roland Häder feb87e8dc3
Changes: 
- let's start throwing exceptions on e.g. invalid arguments instead of returning
  FALSE
 2022-06-20 19:09:08 +02:00
Roland Häder 4fb03cf163
Changes: 
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints
 2022-06-20 19:05:02 +02:00
Roland Häder e96a548286
Changes: 
- dumped default value for $input
- added unknown 'platform' which prevents an "Undefined index: platform in
  /var/www/.../src/Model/GServer.php on line 940" error
 2022-06-20 18:56:22 +02:00
Roland Häder 6743de63f5
Changed: 
- DBA::exists() should only be used for checking if records exists.
- if you want to check if a table exists, please ALWAYS use
  DBStructure::existsTable() instead
 2022-06-20 08:20:07 +02:00
Roland Häder 9c80dd35e5
Both declarations must be the same 2022-06-20 08:07:12 +02:00
Tobias Diekershoff 13a5a30b28
Merge pull request #11659 from MrPetovan/bug/11511-relocate-quote-identifier 
Add missing identifier quote in Database->replaceInTableFields
 2022-06-20 06:26:33 +02:00
Roland Häder cd3b01fd82
Changed: 
- cannot have type-hints :-(
 2022-06-20 03:48:34 +02:00
Roland Häder 94a594eeb2
Ops, wrong type-hint 2022-06-20 03:36:36 +02:00
Roland Häder ec96f2252e
Changes: 
- added type-hints
- added some missing documentation
 2022-06-20 03:10:23 +02:00
Roland Häder 14bf72e4fe
Changes: 
- added some documentation
- added type-hints
 2022-06-20 02:48:05 +02:00
Roland Häder 97904ea7dd
Changes: 
- added type-hints
- added missing documentation
 2022-06-20 02:48:02 +02:00
Roland Häder a0c8fc6d6e
Changes: 
- added more type-hints
 2022-06-20 02:48:02 +02:00
Hypolite Petovan d48e40c1bf Add missing identifier quote in Database->replaceInTableFields 
- This caused hyphenated table names to fail the replace query
 2022-06-19 20:06:12 -04:00
Roland Häder d276f2c62b
Changes: 
- added type-hints
- changed some double-quotes to single
 2022-06-20 01:00:29 +02:00
Hypolite Petovan 622b978a84
Merge pull request #11655 from Quix0r/fixes/more-type-hints-002 
More type-hints and documentation added
 2022-06-19 09:27:29 -04:00
Roland Häder ed3c53a5f8
Ops, not here wanted. :-( 2022-06-19 14:06:32 +02:00
Roland Häder bff57bb030
Changes: 
- added type-hints
- added returned type-hints in interface (I checked all)
 2022-06-19 14:00:31 +02:00
Roland Häder c0d7f8944d
Some calls saved 2022-06-19 11:26:10 +02:00
Roland Häder 60f8c2d795
Changes: 
- added missing type-hints
- added documentation for a method
 2022-06-19 10:50:09 +02:00
Roland Häder 5792a01a01
Contact::getAccountType()'s parameter is never a string, ops 2022-06-19 09:36:24 +02:00
Roland Häder f3599fa3e9
Changes: 
- dbstructure(null) is no longer possible, an empty string does it
 2022-06-19 09:13:10 +02:00
Tobias Diekershoff a063a89c57
Accesskey was used twice 
The accesskey on the User Settings pages for the _account settings_ and the _two factor authentication_ were the same. This PR is assinging a new one to the 2FA.
 2022-06-19 06:30:00 +02:00
Roland Häder b6bfe72083
Wrong returned type, has to be array 2022-06-19 02:40:07 +02:00
Roland Häder 7bb0cb5323
Changes: 
- added more type-hints
- DBStructure::existsTable() does no longer need array support for table name
  because this is no longer used (good work!)
 2022-06-19 02:11:12 +02:00
Roland Häder 2c5685c89c
Changes: 
- changed to proper "use Foo\Bar;"
- added doctag
- added return type as this is fixed
 2022-06-19 01:11:30 +02:00
Roland Häder d7d2ad77ff
Ops, also this! 2022-06-18 23:31:52 +02:00
Roland Häder 39f2d197ea
Changed to suggestings (back to original) + fixed typo in scalar type 2022-06-18 23:30:37 +02:00
Roland Häder 6f1d52cf71
Changed back to suggestions by @MrPetovan 2022-06-18 23:24:08 +02:00
Roland Häder fa14a02a19
Changes: 
- added type-hints
- added documentation
- changed double-quotes to single
 2022-06-18 23:12:52 +02:00
Roland Häder f3b57008b5
Proper type is string 2022-06-18 18:41:16 +02:00
Roland Häder 41f34c4261
Maybe fix for: 
"Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"
 2022-06-18 18:30:50 +02:00
Roland Häder 9691bb06fb
Changes: 
- added more type-hints
- added missing documentation
 2022-06-18 18:21:29 +02:00
Roland Häder 94eb426151
Nodeinfo::getOrganization() doesn't need configuration object being inserted 
when you have DI::config() around.
 2022-06-18 17:56:33 +02:00
Roland Häder c29c49797a
Added missing type-hints 2022-06-18 17:52:46 +02:00
Roland Häder 4e437190c5
Renamed variable, no need for "orig_" prefix 2022-06-18 17:50:11 +02:00
Roland Häder a1a81cdc6b
Continued: 
- changed some double-quotes to single
- added missing type-hints
- added missing documentation
- fixed indenting a bit
 2022-06-18 17:46:34 +02:00
Roland Häder 8fc710f82a
Continued: 
- added more type-hints
- added some missing documentation
- Return the result from DBA::delete() to let other methods know about it
 2022-06-18 17:22:50 +02:00
Roland Häder 8ba3f13fae
Changes: 
- added more type-hints
- added missing documentation
 2022-06-18 17:09:46 +02:00
Roland Häder 7ec07178c8
Changes: 
- added missing type-hints
- added missing documentation
 2022-06-18 16:59:23 +02:00
Roland Häder 8756d92316
Continued: 
- prevents a "Return value of Friendica\Core\Worker::workerProcess() must be of the type array, bool returned"
 2022-06-18 15:57:31 +02:00
Roland Häder bd3a7b9877
Ops, needs to be a variable: 
Error: "Cannot pass parameter 2 by reference" at /var/www/.../src/Module/DFRN/Poll.php line 36
 2022-06-18 09:59:19 +02:00
Roland Häder 69cda4f760
Fixed TypeError: "Argument 1 passed to Friendica\Core\System::httpExit() must be 
of the type string, null given, called in /var/www/.../src/Module/DFRN/Poll.php
on line 37"
 2022-06-18 05:42:02 +02:00
Roland Häder 7cbb818c93
Set type-hint for parameter $data to SimpleXMLElement as $fields in dispatch() 
is the same and being handled over.
 2022-06-18 05:19:24 +02:00
Roland Häder 89302d0843
Some outside code relies on returned "false" 2022-06-18 05:06:18 +02:00
Roland Häder aaf5c323b6
Fixed indenting 2022-06-18 05:04:14 +02:00
Roland Häder adb4aea6ad
Changes: 
- added some type-hints
- replaced most double-quotes (only Diaspora.php, later more) with single
- added some documentation
- normalized indenting in Diaspora.php (I hope I got all?)
 2022-06-18 05:03:10 +02:00
Roland Häder 88c40f3336 Ops, wrong type again 2022-06-17 17:18:31 +02:00
Roland Häder a770634b95 Ops, wrong type 2022-06-17 17:18:31 +02:00
Roland Häder 36d56a4041 Continued: 
- changed back to 'return false;' as other methods heavily rely on false instead
  of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
  code more crazier than it already is (see APContact::getByURL())
 2022-06-17 17:18:31 +02:00
Roland Häder c467bff79f Some more type-hints added 2022-06-17 17:18:31 +02:00
Roland Häder 4f3321cc9f Nore fixes 2022-06-17 17:18:31 +02:00
Roland Häder 10bb7d5625 Possible fix for 
Uncaught Exception TypeError: "Return value of
Friendica\Model\APContact::getByURL() must be of the type array, bool returned"
 2022-06-17 17:18:31 +02:00
Roland Häder fdd237a090 Fix for "Uncaught Exception TypeError: "Argument 1 passed to 
Friendica\Model\APContact::unarchiveInbox() must be of the type string, null
given" error message
 2022-06-17 17:18:31 +02:00
Roland Häder 605e7d55b3 Continued: 
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
  changed it to -1 to have a proper type-hint
 2022-06-17 17:18:31 +02:00
Roland Häder 0c9aff8a09 Also need to declare $profile or otherwise an invocation of 
Receiver::getReceiverForActor() will fail.
 2022-06-17 17:18:31 +02:00
Roland Häder af8cd5ca86 Worker::getWaitingJobForPID() can also return FALSE on failure ... :-( 2022-06-17 17:18:31 +02:00
Roland Häder 227bab43a8 Ops, wrong type-hint here, must be string ($nickname can never be an integer). 2022-06-17 17:18:31 +02:00
Roland Häder f7c1eaa858 Continued: 
- added type-hints
- removed out-dated documentation
- added some missing documentation
 2022-06-17 17:18:31 +02:00
Roland Häder e484b6d6dc Continued: 
- added more type-hints
- added some documentation
- Contact::getAccountType() should only process string, not null
 2022-06-17 17:18:31 +02:00
Roland Häder 45b5f67bca Fix for non-existing record system.mobile_theme in config table 2022-06-17 17:18:31 +02:00
Roland Häder 5c9ce790bf Fixed: 
- $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd
  parameter expect it to be string
 2022-06-17 17:18:31 +02:00
Roland Häder 33768ea1c6 Some fixes: 
- $gsid's default value cannot sadly be 0, it now must be null to allow some
  code work
- added some more type-hints
- documented a bit more
 2022-06-17 17:18:31 +02:00
Roland Häder 4e53666c70 Added more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder 7560dccc08 Added again more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder 2766c7d9cf Continued: 
- added more type-hints
- added some missing documentation
 2022-06-17 17:18:31 +02:00
Roland Häder a587217f47 Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool" 2022-06-17 17:18:31 +02:00
Roland Häder dd54e52575 MrPetovan brought the right one up: 
> Since this is depending on remote systems, the log can quickly fill with unactionable messages.
 2022-06-17 17:18:31 +02:00
Roland Häder c351099c5a Ops, bad type-hint here 2022-06-17 17:18:31 +02:00
Roland Häder 2c5595c358 Another incompatible method declaration fixed + type-hints added 2022-06-17 17:18:31 +02:00
Roland Häder 40d7f29a11 Continued: 
- more type-hints
- fixed incompatible method declarations
 2022-06-17 17:18:31 +02:00
Roland Häder 1edc6b3c3b Added more type-hints for "App" classes 2022-06-17 17:18:31 +02:00
Roland Häder 42b04f397b Added more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder aa5f0d5ec1 Added more type-hints and documented a few methods 2022-06-17 17:18:31 +02:00
Roland Häder 97e27cb523 Added more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder c2e889cfae Added more type-hints 2022-06-17 17:18:31 +02:00
Roland Häder 5106bb2881
Added parenthesis 2022-06-17 09:41:11 +02:00
Roland Häder a903dbd77e
Wrong braces causing 'undefined index causer-id'. See #11632 2022-06-16 23:00:16 +02:00
Roland Häder 6035de6883
Continued: 
- added more type-hints
- also cannot return FALSE when array is set
 2022-06-16 19:06:41 +02:00
Roland Häder 51a7b5c584
Made also this one sweeter (null-coalscing) 2022-06-16 17:36:47 +02:00
Roland Häder 0e1f734b03
Also make this null-coalscing 2022-06-16 17:35:01 +02:00
Roland Häder e8fee5644b
Ops, syntax errors get unnoticed with a simple editor. :-( 2022-06-16 17:10:02 +02:00
Roland Häder 624e4c192c
Changed to null-coalscing style (??) as sugguested by @MrPetovan 2022-06-16 16:59:54 +02:00
Roland Häder 962b06bf41
Added check as suggested by @MrPetovan for empty $message. 2022-06-16 16:54:51 +02:00
Roland Häder f2b7326650
This will 2 things: 
1) The first change prevents "expensive" code in HTML::toBBcode() to be executed
   just for an empty string which makes no sense.
2) The above change was maybe flawed as $apcontact['about'] would have never
   been created, not even empty which could have side effects

Thanks to @annando to make me rethink this part of code.
 2022-06-16 16:54:50 +02:00
Roland Häder 7814ba4fc4
Fixes for bad invocations of HTML::toBBCode() (1st parameter is now string) 2022-06-16 16:54:50 +02:00
Roland Häder b200874f17
Ops: 
- wrong way around (!empty($foo)) is proper
- also needed to be checked on $acitivty['content']
 2022-06-16 16:54:50 +02:00
Roland Häder b1e4c0931a
Fixes and type-hints: 
- added more checked type-hints as they prevent bad method invocations
- fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong)
  argument, thanks to @tobias@social.diekershoff.de pointing this out.
 2022-06-16 16:54:49 +02:00
Roland Häder e9af4b5bb9
Shorter code, thanks to @annando pointing this out 2022-06-16 13:29:30 +02:00
Roland Häder 65da5246ca
Fixed possibble "Trying to access array offset on value of type bool" E_NOTICE 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2022-06-16 10:07:41 +02:00
Roland Häder 5fa954208a
Changes: 
- ops, wasn't actually fixing `return;` to proper `return '';`
- added more type-hints
- added TODO ($uid is unused)
 2022-06-15 22:28:33 +02:00
Roland Häder a3fa95e8e4
Changes: 
- added more type-hints
- changed `return;` to `return '';` when `string` was requested as returned type-hint
  (thanks to @MrPetovan)
 2022-06-15 22:05:38 +02:00
Roland Häder 34aee64349
Added more type-hints 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2022-06-15 21:52:51 +02:00
Roland Häder 143e4c4a18
Added more known type-hints 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2022-06-15 21:52:50 +02:00
Michael 726c4dff7d You can now store the avatar in a separate folder and host 2022-06-15 03:59:26 +00:00
Michael b816ae4db5 Some more default avatars 2022-06-13 20:07:54 +00:00
Michael 70b9a8114d Improve license comment 2022-06-13 10:30:21 +00:00
Michael d9fb081db9 Using separate avatars for different peertube account types 2022-06-13 10:27:46 +00:00
Michael c1a64b77c0 Improved license text 2022-06-13 10:03:34 +00:00
Michael e0a0c57c44 Use platform specific default avatar pictures 2022-06-13 05:18:54 +00:00
Michael d7d8a6ab55 Issue 11625: Don't parse the title through Markdown 2022-06-11 06:50:59 +00:00
Michael 4cf46b9770 API: Use the type field in the query for pinned posts 2022-06-11 06:05:55 +00:00
Michael 176f0c1216 API: Improve the performance for fetching pinned posts 2022-06-10 22:38:46 +00:00
Hypolite Petovan 143120b9c4
Merge pull request #11626 from annando/api-status 
API: Speed improvements when fetching posts
 2022-06-10 16:52:05 -04:00
Michael 4157f816f5 Fix for account variable name 2022-06-10 20:32:21 +00:00
Michael 9a1abda314 Use "avatar" instead of "contact" 2022-06-10 20:26:57 +00:00
Michael 7e747b2f41 API: Speed improvements when fetching posts 2022-06-10 18:49:03 +00:00
Hypolite Petovan 37405567c1
Merge pull request #11622 from Quix0r/fixes/switch-db-current-max-update 
Switched maximum database update with currently worked on to "current/max
 2022-06-08 11:22:38 -04:00
Roland Häder 1e890e16ac
Switched maximum database update with currently worked on to "current/max" as 
this is understandable that update X of maximum Y is applied.

Signed-off-by: Roland Häder <roland@mxchange.org>
 2022-06-08 11:48:05 +02:00
Michael 2064a2ce87 Avoid notice when a contact couldn't be fetched 2022-06-08 05:35:34 +00:00
Michael d2772908e4 Fix: respected the account type on the community page update 2022-06-07 18:52:46 +00:00
Michael 56e88d2c4c Fix the spelling 2022-06-06 21:52:47 +00:00
Michael 19772f29f3 API: Support for markers added 2022-06-06 21:38:59 +00:00
Hypolite Petovan 9c7568cffc
Merge pull request #11612 from annando/rearrange 
Rearrange the notification settings
 2022-06-06 07:33:23 -04:00
Michael 9bb371850a Different approach for empty values 2022-06-06 07:35:28 +00:00
Michael a07e47f50c Improved handling with empty user configuration 2022-06-06 05:43:24 +00:00
Michael 62701b49e1 Use constants 2022-06-06 04:44:29 +00:00
Michael da33517a2d Rearrange the notification settings 2022-06-05 21:19:21 +00:00
Michael 557b1125e2 Hopefully make threads writable 2022-06-05 20:38:05 +00:00
Michael 1196df4895 Remove test 2022-06-05 18:16:50 +00:00
Michael 001aac9952 Issue 11602: Fix error during contact merhe 2022-06-05 18:15:10 +00:00
Michael 9daeb552dd Suppress dislikes 2022-06-05 16:54:29 +00:00
Michael 24559b711b Notify about shared posts again 2022-06-05 16:26:20 +00:00
Michael d242332aa4 Add the notify type to the notification query 2022-06-05 15:02:03 +00:00
Michael 13e216032f Use the user id instead of "local_user()" 2022-06-05 14:22:16 +00:00
Michael 57b8708425 Issue 11566: More detailled notification configuration 2022-06-05 11:41:08 +00:00
Hypolite Petovan b1afcb5ebf
Merge pull request #11588 from annando/mergecontact 
New command to merge duplicated contacts
 2022-06-04 15:34:37 -04:00
Michael f1913b28e0 Issue 11594: Ensure to create notifications in the user language 2022-06-04 14:08:11 +00:00
Michael 50a0034744 Fix avatar for messages and feeds 2022-06-04 07:57:11 +00:00
Michael 4108704ee3 Fix: Only public posts can be pinned 2022-06-04 06:11:32 +00:00
Michael 194f0f7058 No dropping 2022-06-03 20:14:38 +00:00
Hypolite Petovan 6e3b5d251e
Merge pull request #11596 from annando/visible-activities 
Fix: Like/Dislike/Reshare actions should now be visible
 2022-06-03 15:54:49 -04:00
Michael 0aee9a054a Fix: Like/Dislike/Reshare actions should now be visible 2022-06-03 17:40:06 +00:00
Michael 5442d09cc1 Ensure that the avatar base path exists 2022-06-03 05:28:10 +00:00
Michael b794c599a9 Standards fixed 2022-06-01 22:18:18 +00:00
Michael e46354a522 New command to merge duplicated contacts 2022-06-01 22:11:03 +00:00
Michael 7b219718c4 Fix: Use correct follow notification texts 2022-05-31 14:02:43 +00:00
Michael cc6192df02 Issue 10926: Transmit pending events to accepted contacts 2022-05-30 20:52:43 +00:00
Hypolite Petovan 7f711e266f Assume unsettable system.always_my_theme pconfig value is always true 
- This was a logged in user setting so it assumes false for anonymous users
 2022-05-29 16:13:49 -04:00
Hypolite Petovan 220703575c
Merge pull request #11577 from annando/issue-11557 
Issue 11557: Update all local contacts
 2022-05-29 15:53:21 -04:00
Hypolite Petovan 1e68c90fb2
Merge pull request #11576 from annando/issue-11488 
Issue 11488: Don't search for mentions in shared posts
 2022-05-29 15:49:46 -04:00
Michael 540b3f892b Issue 11557: Update all local contacts 2022-05-29 17:48:09 +00:00
Hypolite Petovan 1301a53f20 Remove relocation form from Admin Site settings 2022-05-29 13:15:23 -04:00
Hypolite Petovan f1630ebb05 Add relocate console command 2022-05-29 13:13:59 -04:00
Hypolite Petovan 7d09ce86c4 Move relocation feature in its separate class 
- Create Database->replaceInTableFields method
 2022-05-29 12:11:18 -04:00
Michael 42d3e5c1ce Issue 11488: Don't search for mentions in shared posts 2022-05-29 16:07:53 +00:00
Hypolite Petovan 697b8a6cb8
Merge pull request #11575 from annando/issue-11469 
Issue 11469: Respect desktop notification settings
 2022-05-29 08:06:32 -04:00
Michael 1dccc31508 Issue 11469: Repect desktop notification settings 2022-05-29 09:20:06 +00:00
Michael 02473d8a0e Don't touch local avatars 2022-05-29 06:50:34 +00:00
Hypolite Petovan faa3f26d3b
Merge pull request #11570 from annando/issue-11470 
Issue 11470: Check for removed account
 2022-05-28 18:32:21 -04:00
Hypolite Petovan a503d5ac1b
Merge pull request #11569 from annando/issue-11431 
Issue 11431: Only show pinned posts on contacts and your own ones
 2022-05-28 18:24:37 -04:00
Michael 4ef7f42257 Issue 11470: Check for removed account 2022-05-28 16:21:41 +00:00
Michael 881c4204b4 Issue 11431: Only show pinned posts on contacts and your own ones 2022-05-28 15:55:31 +00:00
Michael ba8088bf3c Add timestamp data to the avatar path 2022-05-28 14:20:48 +00:00
Michael b05aa824f7 Don't move mail and feed 2022-05-27 06:32:19 +00:00
Michael 0a43fe857c Pass the "force" parameter to the avatar update 2022-05-27 05:36:07 +00:00
Michael 8c901ebd74 Issue-11560: Fix error when creating avatar cache file 2022-05-26 19:06:16 +00:00
Hypolite Petovan 488fdd9791
Merge pull request #11558 from annando/public-contact 
Ensure that the public contact exists before adding a user contact
 2022-05-25 09:06:13 -04:00
Michael 918c1eeb56 Check for phantom network 2022-05-25 11:46:58 +00:00
Michael f5d69b3b6a Ensure that the public contact exixts before adding a user contact 2022-05-25 11:43:29 +00:00
Michael e8864653d8 Merge remote-tracking branch 'upstream/2022.05-rc' into move-to-avatar-cache 2022-05-25 05:38:50 +00:00
Michael dadebdd061 Change output function 2022-05-25 05:24:31 +00:00
Michael Vogel e5e509ea21 Calculate totals 2022-05-24 22:32:30 +02:00
Michael 2fbfc0633a Fixed placeholder 2022-05-24 20:12:39 +00:00
Michael d3709d8497 Delete on invalid 2022-05-24 20:02:54 +00:00
Michael 9da0e637a3 Quit on invalid avatars 2022-05-24 19:47:49 +00:00
Michael 80adad3ad2 Additional method to fetch photo avatars 2022-05-24 19:41:38 +00:00
Michael 077c6ece64 Don't use a newline at the end 2022-05-24 17:51:28 +00:00
Michael 2ead69c7a5 Delete invalid photo data 2022-05-24 17:49:29 +00:00
Michael Vogel 0374f0e523 Use correct placeholder 2022-05-24 19:45:02 +02:00
Michael 0ff8ca8053 Trim the rid 2022-05-24 17:39:02 +00:00
Michael Vogel eddfab7122 A space in front of a message looks better 2022-05-24 19:36:48 +02:00
Michael f764ab7429 Improved messages 2022-05-24 17:33:10 +00:00
Michael 74b102b948 Increase the delivery queue counter on drop 2022-05-24 17:28:35 +00:00
Michael bee6ffe968 Support dropping delivery for single message transfer as well 2022-05-24 12:32:04 +00:00
Michael 034d838248 Ignore delivery problems with drops 2022-05-24 12:27:35 +00:00
Michael 8969e83134 Use a better query to fetch the relay actor 2022-05-24 08:06:48 +00:00
Michael e68ff3b3bb Return the actor, not the array 2022-05-24 08:02:55 +00:00
Michael b1a2de5cb5 Resubscribe to relay servers 2022-05-24 07:02:42 +00:00
Michael f16cb13dc7 Fixwd class description 2022-05-24 05:58:14 +00:00
Michael 7b91c4f333 Sorting by "id asc" makes more sense. 2022-05-23 15:31:37 +00:00
Michael 68599c7efa Some more code beauty 2022-05-23 12:44:21 +00:00
Michael 299c4df8f4 Convert to tabs 2022-05-23 12:35:44 +00:00
Michael d658c81107 Code standards 2022-05-23 12:33:25 +00:00
Michael d6242aacf6 Console command to move avatars to the avatar cache 2022-05-23 12:15:30 +00:00
Philipp 218fc0c20d
Fix unsupported animated webp parsing 2022-05-21 18:51:03 +02:00
Philipp 783b05cbb1
Fix unsupported animated webp parsing 2022-05-21 18:44:03 +02:00
Michael 087ad25c87 Escape the "share" as well 2022-05-21 11:55:38 +00:00
Michael 54d7a435a3 Don't parse tags in links 2022-05-21 11:46:38 +00:00
Tobias Diekershoff ed350e472f
Merge pull request #11544 from annando/image-proxy 
Only use proxied image links with images
 2022-05-21 13:40:46 +02:00
Michael 49dab14215 Only use proxied image links with images 2022-05-21 06:58:26 +00:00
Michael 3444c29b0b Avoid warning "Undefined namespace prefix" 2022-05-21 06:04:34 +00:00
Hypolite Petovan 11538376ed
Merge pull request #11539 from annando/worker-split 
The worker and the delivery is split into several classes
 2022-05-20 23:45:51 -04:00
Michael Vogel 7857c329cf Only deliver own content to the relay (possibly fix relay problems) 2022-05-20 19:04:03 +02:00
Michael 9ded39eff6 Renamed variable 2022-05-20 15:49:59 +00:00
Michael 2fc5957abb Spelling error fixed 2022-05-20 05:46:38 +00:00
Michael 653af77e5f Further formatting fixes 2022-05-20 04:52:18 +00:00
Michael 6ce23bd9ca Fixed code structure 2022-05-20 04:42:10 +00:00
Michael dc16e6d471 The worker is split into several classes 2022-05-19 19:24:21 +00:00
Philipp 87e14d9d28
Merge pull request #11533 from annando/notification-cache 
Cache notifications
 2022-05-19 20:32:30 +02:00
Michael 49c47008d1 Convert class calls into DI calls 2022-05-19 09:08:04 +00:00
Philipp c33611c484
Catch exceptions for Worker::AddContact() 2022-05-18 22:37:17 +02:00
Michael 5aa798b1dc Remove test logging 2022-05-18 20:10:14 +00:00
Michael 536ce232a7 Cache notifications 2022-05-18 20:05:29 +00:00
Tobias Diekershoff 7d958e8804
Merge pull request #11530 from annando/logruntime 
Configuration for logging added
 2022-05-18 08:17:50 +02:00
Tobias Diekershoff b18880221a
Merge pull request #11531 from annando/display-polls 
Improved poll texts for different conditions
 2022-05-18 08:16:41 +02:00
Michael 4622814e5f Configuration for logging added 2022-05-18 03:10:38 +00:00
Michael 2e6e3597e5 unused DI" removed 2022-05-18 02:19:45 +00:00
Michael f6167b4cfd New function to exit the program 2022-05-18 02:13:54 +00:00
Michael 4e9d7df31a Add missing DI 2022-05-17 21:26:35 +00:00
Michael aacaa3c2cf Log the command, not the module 2022-05-17 21:25:01 +00:00
Michael 4016a576d5 Log the execution time 2022-05-17 20:47:23 +00:00
Michael 0b50dc363b Caching of "noscrape" 2022-05-17 15:39:04 +00:00
Michael c3fd8b39aa Caching for profiles removed 2022-05-17 12:53:31 +00:00
Michael 4e3e9dc763 Cache the profile as well 2022-05-17 12:46:55 +00:00
Michael 75534fa3f3 Fix warning " Trying to access array offset on value of type bool" 2022-05-17 12:38:39 +00:00
Michael 73019284ce Increase cache lifespan / clear cache upon changes 2022-05-17 12:32:25 +00:00
Michael 610f8a086f Use cache key constants 2022-05-17 08:17:41 +00:00
Michael 10cdefa232 Fix: Fetch media in shared posts 2022-05-17 07:58:41 +00:00
Michael 1ccf22a496 AP endpoints are now cached 2022-05-17 04:58:54 +00:00
Michael 4daae255d8 Performance: Avoid queries where there is no media or category 2022-05-16 17:06:58 +00:00
Michael 62a1cf257e Improved poll texts for different conditions 2022-05-16 06:04:46 +00:00
Michael 2dc9b4eda2 Vote text changed 2022-05-16 05:31:53 +00:00
Michael a63caefe3d Polls are now displayed 2022-05-16 04:55:15 +00:00
Hypolite Petovan 4829c240e9
Merge pull request #11516 from annando/issue-11472 
Issue 11472: Store the "edit" history
 2022-05-15 20:24:59 -04:00
Michael 2c511b8a23 Check the edit date before storing history 2022-05-15 21:15:31 +00:00
Michael 440b6d7956 Issue 11504: Abstract has to be plaintext 2022-05-15 21:04:01 +00:00
Michael d77b043d9c Fixing tests 2022-05-15 20:26:14 +00:00
Michael 324cce7a19 Issue 11472: Store the "edit" history 2022-05-15 20:21:56 +00:00
Michael 972f91436c Issue 11492: Improvements for contact import 2022-05-15 18:40:46 +00:00
Michael 5af7c30026 Issue 11508: Sanitizing date fields for events and polls 2022-05-15 18:00:19 +00:00
Michael 30b9af10ac Fetch featured posts through a worker 2022-05-15 09:08:35 +00:00
Michael f0bfa9a690 Each 5xx error is a server fail 2022-05-14 13:49:01 +00:00
Michael 689b71c696 Added check for server failure 2022-05-14 11:34:00 +00:00
Michael fbdb73cdd6 Improved log levels 2022-05-14 11:18:48 +00:00
Michael 43dbd1c396 Add additional timeout checks 2022-05-14 11:09:59 +00:00
Michael f8d929d94e Ensure to set the network timeout 2022-05-14 09:53:12 +00:00
Michael a8839517fe Fix workerqueue entries with wrong priority 2022-05-14 06:36:43 +00:00
Michael 30bcb24af7 Display the runtime 2022-05-14 06:06:38 +00:00
Michael 4b5a743645 Handle timeout 2022-05-14 05:38:01 +00:00
Michael 4ef2679ca6 Fix test 2022-05-13 19:37:50 +00:00
Michael fab5ba39ff Failed post deliveries are now deleted via cron 2022-05-13 18:48:13 +00:00
Michael 065d73f860 Merge remote-tracking branch 'upstream/2022.05-rc' into bulk-delivery 2022-05-13 08:53:18 +00:00
Michael 65b86fe0d5 Blanks replaced 2022-05-13 07:44:36 +00:00
Michael 0f0f4bc2c7 New worker job for deliveries without a worker 2022-05-13 07:31:00 +00:00
Michael a662245c74 We now store the receivers as well 2022-05-13 05:52:05 +00:00
Michael 47cd1edb9f Change the featured collection to fix communication issues with Pleroma 2022-05-13 03:42:04 +00:00
Michael Vogel 201610dfe6 Don't look at the command when archiving an inbox 2022-05-13 04:24:22 +02:00
Michael 2595b5e12f Remove all posts of a given inbox 2022-05-13 02:18:46 +00:00
Michael 2049fbce91 Remove delivery when the inbox is archived 2022-05-13 02:11:02 +00:00
Michael 4f68be82ef Use a simpler worker call 2022-05-12 21:28:57 +00:00
Michael 67a74c15e1 Improve item fetching 2022-05-12 21:10:59 +00:00
Michael b0b67f1fde Remove failing posts 2022-05-12 12:43:49 +00:00
Michael a943dbb420 Introducing the "failed" counter 2022-05-12 06:54:58 +00:00
Michael d5d2892f59 Simplifications for the experimental bulk delivery 2022-05-12 06:17:55 +00:00
Michael 3d7ecb4fde Don't update the local avatar 2022-05-11 18:30:59 +00:00
Michael afa57edf8e Avoid warning "fileperms(): stat failed for ..." 2022-05-11 17:28:28 +00:00
Michael 47ee6fd009 Fix a warning because of an undefined array key 2022-05-11 16:01:37 +00:00
Michael 0f0b649e8d Replace unparse function 2022-05-11 11:06:14 +00:00
Michael 34f594137e Movwe the conversion after the cleaning 2022-05-11 10:56:44 +00:00
Michael 020ba7a4ed The function is now usable for all formats 2022-05-11 06:58:26 +00:00
Michael 695e3d8b61 Simplifiy the split 2022-05-11 06:55:02 +00:00
Michael 47808ab0e9 Issue 11487: IDN support added 2022-05-11 06:34:25 +00:00
Michael d9de8b6d2f Remove test logging 2022-05-10 18:37:02 +00:00
Michael fae414fedd Fix local avatar, improve speed for fetching cached photos 2022-05-10 18:18:24 +00:00
Hypolite Petovan 776ce3f63a
Merge pull request #11484 from annando/avatar-logging 
Improved logging for avatar storing
 2022-05-10 08:03:31 -04:00
Michael 7c3173a0ae Avoid endless loop when storing posts 2022-05-10 06:07:26 +00:00
Michael 945f5c6db2 Improved logging for avatar storing 2022-05-10 06:04:37 +00:00
Hypolite Petovan d195d934be
Merge pull request #11482 from annando/inherit-permissions 
Inherit avatar cache file permissions
 2022-05-09 23:15:47 -04:00
Michael 22da88b43f Changed log level 2022-05-10 01:14:27 +00:00
Michael 548bf469ca Added logging 2022-05-09 22:36:25 +00:00
Michael 630d25a24b Issue 11353: Suppress the forum sharer 2022-05-09 20:52:08 +00:00
Michael 34030a736d Use a constant for the avatar base path 2022-05-09 19:16:14 +00:00
Michael 916aa1c9a9 Inherit avatar cache file permissions 2022-05-09 17:36:46 +00:00
Hypolite Petovan e1f32f7f15
Merge pull request #11477 from annando/avatar-file-cache 
Cache contact avatars locally as files
 2022-05-09 11:13:08 -04:00
Michael cbe4a42906 Use a warning instead 2022-05-09 14:36:41 +00:00
Michael f785026289 Don't return a filename when it wasn't stored 2022-05-09 08:47:02 +00:00
Michael f744dd362d Picture shouldn't be executable 2022-05-09 08:28:23 +00:00
Michael 9d1ff0a4ce Set permissions 2022-05-09 08:20:09 +00:00
Michael 006b7a95f0 More avatar handling isolation 2022-05-09 06:57:47 +00:00
Michael 681d19a3bc Standards and renamed class 2022-05-09 06:31:09 +00:00
Michael 53d064c283 Avatar handling is moved to a separate class 2022-05-09 06:27:46 +00:00
Michael e3692c0105 Replaced check with hardwired path 2022-05-09 04:26:00 +00:00
Michael Vogel 6b9f543c4e GoToSocial added to the federation admin page 2022-05-08 20:50:11 +02:00
Michael f220e26f00 Use new function to check for a local avatar cache file 2022-05-08 10:32:29 +00:00
Michael 805dc8e6bd Fix config call 2022-05-08 09:34:30 +00:00
Michael dd422a1e03 Fix contact field name 2022-05-08 08:57:41 +00:00
Michael 7b0187c4c5 Don't overwrite already replaced cache file paths 2022-05-08 08:53:18 +00:00
Michael 2d856f48b7 Use the default timeout 2022-05-08 05:51:18 +00:00
Michael a31256412e Cache contact avatars locally as files 2022-05-08 05:37:17 +00:00
Hypolite Petovan 510dacf4df Escape BBCode tag parsing avoidance tags when processing abstracts 
- Improve documentation for related methods
 2022-05-07 22:19:50 -04:00
Michael 67c3a20c4f Issue 11440: Hashtags are now generated again 2022-05-06 17:03:51 +00:00
Hypolite Petovan 4729fca5d9
Merge pull request #11457 from annando/performance 
Improve page performance
 2022-05-06 11:11:05 -04:00
Michael Vogel 1e7a55180a
Update src/Content/Conversation.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-05-05 22:40:20 +02:00
Michael 2433fee461 Changes after code review 2022-05-05 12:23:44 +00:00
Michael 4d359b7de1 Move the plink functionality to the right function 2022-05-05 07:57:52 +00:00
Michael d34432c517 Ignore if the worker was added 2022-05-05 06:12:16 +00:00
Michael 10b453bfc2 Deprecated function removed 2022-05-04 07:49:37 +00:00
Michael 60532ee7e4 Fill the item cache when storing item 2022-05-04 06:17:34 +00:00
Michael f6218427a4 Use the uri-id to fetch the contact 2022-05-03 21:51:56 +00:00
Balázs Úr 4171ff7563
Add Danish language to list of native language names 2022-05-03 21:13:47 +02:00
Michael 4ba28e0199 Merge remote-tracking branch 'upstream/2022.05-rc' into performance 2022-05-03 08:23:09 +00:00
Michael 49ec5e5e6e Check for empty value 2022-05-03 08:20:48 +00:00
Michael e6440471ae Throw an error when the feed is invalid 2022-05-03 08:20:26 +00:00
Michael 690682a37e Only send "accept" headers on some HTTP methods 2022-05-03 08:20:05 +00:00
Michael 632a98965c Fetch contact via uri-id to improve performance 2022-05-03 08:19:35 +00:00
Michael 3163760343 Added configuration for the bulk delivery 2022-05-02 17:34:40 +00:00
Michael 6e394ac6ff Whitespaces removed 2022-05-02 14:36:21 +00:00
Michael 76789acace Reduce network request by transmitting to shared inboxes 2022-05-02 14:35:57 +00:00
Michael fcb245947e Fetch the receiver list from sharedinbox or personal inbox 2022-05-02 06:10:36 +00:00
Michael 9c2fe81ac6 Transmit via the sharedInbox 2022-05-02 05:53:11 +00:00
Michael a9990db98c Clean the worker queue directly from cron 2022-05-02 05:16:02 +00:00
Michael 40aa67f8be Bulk transmission for AP posts 2022-05-02 05:15:27 +00:00
Michael 13e4144ba6 Use a centralized function to check the priority 2022-05-01 09:29:31 +00:00
Michael f7b6507438 More checks for strange priorities 2022-05-01 08:58:48 +00:00
Michael 19c1b31ab2 Only add valid values to the worker 2022-05-01 07:03:10 +00:00
Michael e19681684b Fix worker priorities 2022-05-01 06:57:29 +00:00
Michael 1f43332a1d Only fetch category when it exists 2022-04-30 06:57:22 +00:00
Michael fb3353d4bd Separate loop to fetch thread parents 2022-04-30 06:19:18 +00:00
Hypolite Petovan 18c642f2a7
Merge pull request #11451 from atjn/update-icon 
Update default icon
 2022-04-29 07:25:51 -04:00
Michael a2452b33eb Add missing fields to collection 2022-04-29 10:13:23 +00:00
Michael 8dc0ab9bb3 Test: Disable magiclink in posts 2022-04-29 09:49:16 +00:00
Michael d3de2497bc Use gsid for the network name 2022-04-29 07:47:24 +00:00
Michael d44641e58c Fetch avatar by id 2022-04-29 07:30:13 +00:00
Michael 1326239576 Reduce the amount of queries 2022-04-29 05:32:12 +00:00
Hypolite Petovan aa65e3032d
Merge pull request #11455 from annando/update-avatar 
Update contact when the avatar hadn't been found
 2022-04-28 14:29:46 -04:00
Michael 9eafcf8484 Update contact when the avatar hadn't been found 2022-04-28 16:46:52 +00:00
atjn 420f4c54b7 Update app manifest icons 2022-04-28 13:26:59 +02:00
atjn 31ed9b450d Update default icon 2022-04-28 12:41:26 +02:00
Michael 144c9f00f4 Fix: Show reshared posts on the contact page 2022-04-27 03:25:47 +00:00
Michael 171354181d Use central function to fetch the global directory 2022-04-26 18:33:58 +00:00
Michael 83e311decb Standards 2022-04-25 13:49:17 +00:00
Michael 990eea2c4e We now store uncommon endpoints 2022-04-25 13:45:03 +00:00
Tobias Diekershoff b89f727cca
Merge pull request #11438 from MrPetovan/bug/11371-settings-forms 
Enclose account settings panels in separate forms
 2022-04-25 07:37:59 +02:00
Michael 069a008ca4 Removed unused tag entries 2022-04-24 15:27:20 +00:00
Hypolite Petovan 967c438312 Enclose account settings panels in separate forms 
- This prevents auto-filled password fields to abort settings save
- Move single-use settings/nick_set template HTML to settings/account
 2022-04-24 08:36:53 -04:00
Hypolite Petovan 90368d7484 Remove unused settings_post and settings_form hooks 
- Addons should use the addon_form hook instead
 2022-04-24 01:21:49 -04:00
Hypolite Petovan 64330f9895 Move /settings to src/ 2022-04-24 01:21:48 -04:00
Michael 4af6e730d3 Use different collections 2022-04-23 12:32:29 +00:00
Michael 0a3c5cc40c Add the function documentation 2022-04-23 11:43:30 +00:00
Michael 060597f619 Store the tag type for the post targets 2022-04-23 11:39:19 +00:00
Michael 9b646dad97 API: We can now display polls 2022-04-22 19:24:22 +00:00
Michael f34b7b91fa API: New Mastodon endpoints added 2022-04-21 19:58:56 +00:00
Michael 666b3bbca3 Use "received" for starred posts 2022-04-21 13:58:24 +00:00
Michael 5a41c2039a Order starred posts and posts with mention by the last comment date 2022-04-21 05:52:08 +00:00
Michael eb1f38df22 Issue 11427: id values of OrderedCollections have to contain the page number 2022-04-21 04:29:08 +00:00
Michael 2236e5cfb0 Issue 11425: Additional sorting by creation date 2022-04-20 21:03:33 +00:00
Michael 94a8f430e3 Avoid warning " Undefined variable $browsershare" 2022-04-20 12:03:09 +00:00
Michael 8d25094719 Fix test 2022-04-20 06:33:14 +00:00
Michael 834844573b We can now store incoming questions 2022-04-20 06:28:02 +00:00
Michael 62b31900a6 Renamed "share" with "share via" 2022-04-19 21:04:55 +00:00
Michael 0380a3e216 Fix: The language detection only searched for farsi 2022-04-19 06:16:44 +00:00
Michael cca7d40a8f Fix: Webfinger returned xml when json has been requested and vice versa 2022-04-18 05:42:05 +00:00
Hypolite Petovan 627e91f209
Merge pull request #11413 from annando/vote-preparation 
Preparation for storing incoming polls
 2022-04-15 10:22:41 -04:00
Michael eaa8163201 Preparation for storing incoming polls 2022-04-15 09:11:50 +00:00
Michael 0696da3d1b Fixes notice 2022-04-15 04:14:21 +00:00
Michael 0d8cf06e4a Experimental feature to enter a custom creation date 2022-04-13 05:31:32 +00:00
Michael 30e5ef928a Avoid wrong server type detection / Owncast added 2022-04-12 05:34:34 +00:00
Michael 62367923e0 Fix several notices 2022-04-11 18:57:30 +00:00
Hypolite Petovan 3842f02b02
Merge pull request #11402 from annando/featured-endpoint 
We now offer an endpoint for featured posts
 2022-04-11 11:17:56 -04:00
Michael c88d306a41 Use the correct content type 2022-04-11 06:07:50 +00:00
Michael 989ac2fda8 Some more "exit" replaced 2022-04-10 11:03:24 +00:00
Michael 4a22034be6 Unified output via the "httpExit" function 2022-04-10 08:31:55 +00:00
Michael d15023fe4b Unified JSON exit 2022-04-09 11:58:01 +00:00
Michael 344e12c4fc Use $request 2022-04-09 08:17:26 +00:00
Michael a1e675ded1 use jsonexit 2022-04-09 03:41:24 +00:00
Michael d7df0825db We now offer an endpoint for featured posts 2022-04-08 21:25:31 +00:00
Hypolite Petovan 4eecf733e1
Merge pull request #11389 from nupplaphil/feat/http_client_arg 
Introduce explicit HttpClient "Accept" parameter
 2022-04-08 15:05:40 -04:00
Philipp 3033f79529
head fixings 2022-04-08 20:48:57 +02:00
Philipp 8e2cc678dc
head fixings 2022-04-08 20:41:25 +02:00
Philipp 277cd51433
fix doc 2022-04-08 20:11:51 +02:00
Michael Vogel b2b8b23ed6
Update src/Model/Contact.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-04-08 13:59:43 +02:00
Michael 69b7923df2 Use centralized function to fetch query results 2022-04-08 06:04:50 +00:00
Michael 2764859350 Remove unfeatured posts from collection 2022-04-08 04:49:23 +00:00
Michael 6c8ea1d0d8 Updated messages.po / type added to query 2022-04-08 04:17:52 +00:00
Michael 75bc4eccb7 Display featured posts for contacts 2022-04-07 21:52:25 +00:00
Michael 65071ffc9e Issue 11393: Fix failing preview 2022-04-06 16:26:51 +00:00
Michael 5a3fe900f0 Fix test 2022-04-06 15:32:14 +00:00
Michael a1dd299eb3 Preparations for "featured" posts 2022-04-06 13:34:11 +00:00
Michael e6ea015cb4 "Person" is "Account" 2022-04-05 20:06:04 +00:00
Michael c0b3c527d6 Added processing of incoming block notices 2022-04-05 19:14:29 +00:00
Michael dcbca0c6a3 Store "View" activity from Peertube 2022-04-05 07:48:38 +00:00
Michael a5a5a4b603 Cleaned code 2022-04-05 05:53:17 +00:00
Michael 61abc6377d Preparation for "Featured" collection added 2022-04-04 23:07:44 +00:00
Michael e6caed7b5f Merge remote-tracking branch 'upstream/develop' into new-acitivities 2022-04-04 16:05:02 +00:00
Michael aa2a32d16f Store the "EmojiReact" activity 2022-04-04 16:03:53 +00:00
Hypolite Petovan eceaf782cc
Merge pull request #11385 from annando/ap-receiver-unhandled 
Added handling of some previously unhandled activities
 2022-04-04 10:59:35 -04:00
Philipp 04866195b4
Remove accept parameter for head/post again 2022-04-03 19:33:09 +02:00
Michael 1475f53e21 Merge branch 'ap-receiver-unhandled' of github.com:annando/friendica into ap-receiver-unhandled 2022-04-03 07:45:19 +00:00
Michael 39a1745361 Prevent the warning of an Undefined array key "object_object_type" 2022-04-03 07:45:15 +00:00
Michael 5290f0cd51 Improved handling of invalid links 2022-04-03 07:31:42 +00:00
Michael 029daef997 Only use and accept valid http links as links to an external resource 2022-04-03 07:21:36 +00:00
Michael Vogel 5fe75ed50d
Update src/Protocol/ActivityPub/Receiver.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-04-02 23:04:44 +02:00
Philipp 4aeccd3157
Added license 2022-04-02 21:22:14 +02:00
Philipp e299fc67c8
Introduce "accept_header" as specific argument to the http client 2022-04-02 21:16:53 +02:00
Philipp 73c3b21665
Move ACCEPT constants to own "enum" class 2022-04-02 20:26:11 +02:00
Michael 1db3143dc5 added empty object type 2022-04-01 21:27:40 +00:00
Michael 71afbabbd8 Added handling of some previously unhandled activities 2022-04-01 11:20:17 +00:00
Michael 2ca51f752d Use appropriate "accept" values 2022-03-30 14:39:53 +00:00
Michael 3e21b035b7 Added logging 2022-03-29 17:26:31 +00:00
Michael 94b7c1fc77 Use a more specific "accept" value 2022-03-29 14:02:10 +00:00
Michael 28e3eee91b Add "Accept" to "head" 2022-03-29 13:34:54 +00:00
Michael 908d2594ed Use "HttpClientOptions" 2022-03-29 08:57:38 +00:00
Michael 1fae0123ec Some more "accept" parameters are added 2022-03-29 06:24:20 +00:00
Michael 51b2bf6f70 Avoid returning of the actor when requesting friendica/json 2022-03-28 13:12:45 +00:00
Michael ff70f74952 "accept" constants introduced and used 2022-03-28 10:33:06 +00:00
Philipp 80a533ddab
Add Default Accept for HTTP Calls 2022-03-26 22:15:44 +01:00
Tobias Diekershoff c1fd163b97
Merge pull request #11376 from annando/no-group 
Don't display Peertube groups as forums
 2022-03-24 13:19:34 +01:00
Michael 8c34c3b8ae Don't display Peertube groups as forums 2022-03-24 11:30:32 +00:00
Michael 212eba327b Improve the compatibility with Lemmy 2022-03-24 10:57:55 +00:00
Michael 6f43821ebf Issue 11368: Prevent namespace prefix warning 2022-03-22 21:07:35 +00:00
Hypolite Petovan 2438eb78dd
Merge pull request #11369 from annando/empty-item 
Prevent further processing of incoming posts when thay are rejected
 2022-03-22 08:54:20 -04:00
Michael 53ba68e222 Remove "blubb" 2022-03-22 12:31:14 +00:00
Michael 45199b498d Prevent further processing of incoming posts when thay are rejected 2022-03-22 12:28:47 +00:00
Michael 13addaf901 Always provide the title variable 2022-03-22 07:07:33 +00:00
Michael be016b0c45 Prioritize the title over the content warning 2022-03-22 07:00:44 +00:00
Michael a2a5f05a19 Issue 11310: Show pinned posts when not logged in 2022-03-21 22:58:23 +00:00
Michael 4dace46159 Fix link to post in notification 2022-03-20 19:59:35 +00:00
Hypolite Petovan e738428876
Merge pull request #11360 from annando/announce-notification 
Don't create empty announce notifications
 2022-03-19 14:53:34 -04:00
Michael e4a5094c90 Don't show double introductions 2022-03-19 18:38:59 +00:00
Michael 91905bea89 Don't create empty announce notifications 2022-03-19 17:53:41 +00:00
Hypolite Petovan 014c7b5943
Merge pull request #11359 from annando/notification 
Avoid empty notifications / fixed link to the content
 2022-03-19 11:31:46 -04:00
Michael fb6a435a6a Avoid empty notifications / fixed link to the content 2022-03-19 15:25:00 +00:00
Michael 351e9a307c Fixed placeholder 2022-03-19 11:24:09 +00:00
Michael 4e45987f74 Merge remote-tracking branch 'upstream/develop' into fetch-usage 2022-03-19 11:21:38 +00:00
Hypolite Petovan 4329f5381b
Merge pull request #11355 from annando/notifications 
Fixes for the notifications
 2022-03-19 06:52:04 -04:00
Michael aef9cb9992 Moved "ignore" check to a better location 2022-03-19 09:48:50 +00:00
Michael 1fe756b5b6 Fixes for the notifications 2022-03-19 09:27:49 +00:00
Hypolite Petovan 9eb6299f19 Check array key existence in ActivityPub\Transmitter::createPermissionBlockForItem 
- APContact::getByURL can return empty array
- Address https://github.com/friendica/friendica/issues/11218#issuecomment-1066753232
 2022-03-19 03:15:08 -04:00
Michael 0aa229489f Improved function description 2022-03-18 07:24:45 -04:00
Michael 040abc7743 Use a nicer GUID style format 2022-03-18 07:24:44 -04:00
Hypolite Petovan 04ac4841f9 Add support for notification visibility settings 2022-03-16 22:03:26 -04:00
Michael 0b10806ce3 Fix the problem that the post update never stopped on larger systems 2022-03-16 22:00:34 -04:00
Michael Vogel f5bcc4ad4b
Merge pull request #11346 from MrPetovan/bug/11343-memcached-bad-key 
Suppress a couple MemcachedException
 2022-03-16 15:19:40 +01:00
Tobias Diekershoff 8d64cf4f9b
typo 2022-03-16 06:25:21 +01:00
Hypolite Petovan 7b9e62198e Suppress a couple MemcachedException 
- Replace URL by uri-id in apcontact
- Replace date with a space and nurl by nick and Zulu time in mod/poco
 2022-03-15 10:54:00 -04:00
Hypolite Petovan a07f840c74 Add correct ordering for detailed notifications 2022-03-15 07:05:59 -04:00
Tobias Diekershoff 02b6ac3ed3
limit parameter was missing from docblock 2022-03-15 08:46:26 +01:00
Tobias Diekershoff 12038d45d0
PHP deprecation warning due wrong order of function parameters 
With PHP 8.0 I got the following PHP Deprecation message

```
PHP Deprecated:  Required parameter $limit follows optional parameter $ids in src/Worker/UpdateContacts.php on line 104
```

this PR fixes the wrong order of the parameters.
 2022-03-15 08:44:17 +01:00
Michael Vogel e252b5972e
Merge pull request #11336 from MrPetovan/task/4639-soapbox-intro-notification 
Add exception when message is empty in FormatteNavNotification::createFromNotification
 2022-03-15 07:09:24 +01:00
Hypolite Petovan 07d4cdbdde Fix misleading notification message strings 
- The mentioned title is from the top-level post, not the liked post
 2022-03-14 22:56:46 -04:00
Hypolite Petovan 36e85b01c6 Hide like notifications from menu again 2022-03-14 22:56:46 -04:00
Hypolite Petovan 73c7b88fb2 Add exception when message is empty in FormatteNavNotification::createFromNotification 
- Filter out message less notifications in Ping
 2022-03-14 22:56:44 -04:00
Hypolite Petovan 371b2b22bd
Merge pull request #11333 from annando/feed-guid 
Don't use the GUID value directly
 2022-03-14 18:02:29 -04:00
Michael 7940b31685 Don't use the GUID value directly 2022-03-14 21:09:14 +00:00
Hypolite Petovan e6f745bcb1 Delete follow notification on unfollow 
- Fix translation string typo
 2022-03-14 07:58:39 -04:00
Hypolite Petovan 49971b1465 Switch data source from notify to notification in Module\Notifications\Ping 
- Change unused FormattedNotification classes to FormattedNavNotification classes
 2022-03-14 07:58:38 -04:00
Hypolite Petovan 1ae7cac236 Move mod/ping to module class 2022-03-14 07:57:41 -04:00
Hypolite Petovan 5a12bd87f3 Replace Javascript notification string formatting with Smarty templates 2022-03-14 07:56:58 -04:00
Hypolite Petovan b7cee324b0 Add legacy notification endpoint for deprecated Notify entity 
- Add dependencies to Notifications\Notification module class
 2022-03-14 07:56:21 -04:00
Hypolite Petovan deafdcde95 Use public contact ID in Model\Post\UserNotification::insertNotification 
- Add localRelationship dependency to Notification factory
- Remove dependencies from Factory\Notification->getMessageFromNotification method
 2022-03-14 07:56:20 -04:00
Hypolite Petovan 7ce97459d4 Deprecated the notify table/classes 2022-03-14 07:56:20 -04:00
Michael 0956d1dd64 Don't send forum posts to the user's followers 2022-03-14 06:07:51 +00:00
Michael 2642996171 Send community posts only to the community 2022-03-13 19:31:21 +00:00
Michael ca086b880b Some small improvements for importing feeds 2022-03-13 15:29:07 +00:00
Michael 12d7c99f46 Don't send notifications for activities caused by the community contact 2022-03-13 05:44:29 +00:00
Hypolite Petovan 9e3dbfab3e
Merge pull request #11323 from annando/direction 
Issue 11309: improved check for wanted posts
 2022-03-12 13:42:08 -05:00
Michael 314bf92ead Added Documentation 2022-03-12 17:29:46 +00:00
Michael fb13890341 Added parameter values 2022-03-12 15:27:56 +00:00
Michael 8c778ca02e Improved completion check for AP 2022-03-12 11:17:33 +00:00
Michael 56cd98b38b Further improved logging 2022-03-12 07:48:31 +00:00
Michael c1bb1cf0fc Improved logging 2022-03-12 07:34:30 +00:00
Michael Vogel 5c4871fe6d
Merge pull request #11321 from MrPetovan/bug/11319-wrong-path-subfolder-install 
Normalize base URL usage in admin templates
 2022-03-12 08:10:07 +01:00
Michael 5a16a424ac Issue 11309: improved check for wanted posts 2022-03-12 07:08:10 +00:00
Michael 073a6afaaf Reduce amount of notifications by communities 2022-03-12 04:20:19 +00:00
Hypolite Petovan d15ebb6fd3 Normalize base URL usage in admin templates 2022-03-11 23:14:21 -05:00
Michael 5eb647585d Issue 11315: Fix for all receivers in "to" 2022-03-11 20:39:03 +00:00
Michael f264923cad Issue 11309: Check if a post is wanted 2022-03-11 14:00:05 +00:00
Michael 2f97d61a09 Estimate active server users when not provided by the system 2022-03-10 21:50:00 +00:00
Michael 03d38d9e35 Show permissions for all posts when possible 2022-03-10 07:38:12 +00:00
Michael 38fbe281f9 API: Fixed the bookmarking 2022-03-08 22:38:06 +00:00
Hypolite Petovan 00aa905c15
Merge pull request #11307 from annando/api-reply-fix 
API: Fix "in_reply_to_status_id"
 2022-03-08 15:53:12 -05:00
Hypolite Petovan 0f9a239d59
Merge pull request #11306 from annando/abstract-space 
Replace abstract content with a space to prevent missing spaces
 2022-03-08 15:52:48 -05:00
Hypolite Petovan c13ae36256
Merge pull request #11305 from annando/api-spoiler 
API: Improve support for the summary field
 2022-03-08 15:48:46 -05:00
Michael 4803b99157 API: Fix "in_reply_to_status_id" 2022-03-08 20:46:26 +00:00
Michael e0295abdab Replace abstract content with a space to prevent missing spaces 2022-03-08 19:58:55 +00:00
Michael e0468ac914 API: Improve support for the summary field 2022-03-08 18:32:09 +00:00
Michael 8039ab731f Type hints reverted 2022-03-08 18:26:59 +00:00
Hypolite Petovan 285ff75482
Merge pull request #11294 from annando/fix-mail-setting 
Fix storing mail settings
 2022-03-06 10:17:02 -05:00
Michael Vogel acba7d25a0
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-03-06 14:15:59 +01:00
Michael 31dbdd3677 variable type for the return value is added 2022-03-06 12:21:27 +00:00
Michael 903bc9b679 Improved support for Mastodon style content warnings 2022-03-06 11:49:55 +00:00
Michael Vogel 1ec1adf904
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-03-06 05:49:49 +01:00
Michael 421dd028ce Fix storing mail settings 2022-03-05 13:08:09 +00:00
Michael 5539e42743 API: Support for the "direct" visibility 2022-03-05 06:14:30 +00:00
Michael 15de709b89 API: We can now post to groups via the Mastodon endpoint 2022-03-04 05:50:33 +00:00
Michael f059e56e0f Fix test / Use new expandTags function 2022-03-02 17:17:07 +00:00
Michael f853d58198 API: Forum mentions are now working 2022-03-02 06:59:07 +00:00
Michael 1f1d3b2578 API: Only display active incoming contact requests 2022-03-02 05:05:49 +00:00
Michael 772294494e API: Fix display of reshares / return value of activities 2022-02-28 20:10:42 +00:00
Hypolite Petovan f36d4891bc
Merge pull request #11282 from annando/api-fix 
API: several fixes to the Twitter/Statusnet API
 2022-02-25 16:11:18 -05:00
Michael 6415fc62a0 Fix missing field 2022-02-25 19:27:25 +00:00
Michael bf5c8a2c43 API: several fixes to the Twitter/Statusnet API 2022-02-25 19:16:40 +00:00
Hypolite Petovan 419fe67c6c
Merge pull request #11265 from k-alin/6606-k-alin-mysql-unix-socket 
Enable MySQL unix socket connection
 2022-02-25 10:36:43 -05:00
k-alin e4cfd4a7c3
Update src/Database/Database.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-02-25 16:09:54 +01:00
k-alin 8a10b0c635 add socket to database settings in the autoinstaller 2022-02-25 15:01:02 +01:00
k-alin 33c4fbf2a6
Update src/Database/Database.php 
Correct indent

Co-authored-by: Philipp <admin+Github@philipp.info>
 2022-02-25 12:09:54 +01:00
k-alin 470be2b5e4
Update src/Database/Database.php 
Correct indent

Co-authored-by: Philipp <admin+Github@philipp.info>
 2022-02-25 12:09:30 +01:00
k-alin 335be6f032
Update src/Database/Database.php 
Correct indent

Co-authored-by: Philipp <admin+Github@philipp.info>
 2022-02-25 12:09:12 +01:00
Hypolite Petovan cddead2343 Move follow revoke protocol to worker task 
- Switch to public contact for revoke_follow hook
 2022-02-24 09:35:55 -05:00
Hypolite Petovan 6a1f9a7fa3 Move unfollow protocol to worker task 
- Add uid parameter to unfollow hook
- Rework and unify Contact::unfollow, Contact::removeSharer and Contact::terminateFriendship
- Add missing twitterUser property to Twitter\Friendships\Destroy module
 2022-02-24 09:35:54 -05:00
Hypolite Petovan 48e2963ac7 Remove unused variable in Core\Worker::defer 2022-02-24 09:35:54 -05:00
Hypolite Petovan 52f5d924b7 Replace remaining instances of DBA::update('contact') with Contact::update() 
- This was breaking the synchronisation between the contact and user-contact tables
 2022-02-24 09:35:54 -05:00
Michael d32b9d5d95 Display the BCC receiver when it is the local user 2022-02-24 07:09:34 +00:00
Hypolite Petovan 1d779c6193 Ensure the private message recipient is valid in Mail::send 
- Arbitrary input could be used to circumvent most restrictions regarding recipients (except contact relationship)
 2022-02-23 21:30:18 -05:00
Michael 59630a2c82 Improve the name of the "followers" receiver 2022-02-23 20:18:37 +00:00
Michael Vogel 948405a486
Merge pull request #11267 from MrPetovan/task/11264-mastodon-api-version 
Update Mastodon API version string to include Mastodon version compatibility
 2022-02-23 05:38:25 +01:00
Michael ec0b05d826 Display announces identital for starting posts and comments 2022-02-21 05:17:54 +00:00
Hypolite Petovan d7b573c6d7 Update Mastodon API version string to include Mastodon version compatibility 2022-02-20 20:22:39 -05:00
Hypolite Petovan e0ea51818e Add constructors to a couple of Mastodon API value objects 2022-02-20 16:17:03 -05:00
Michael 2321c7a55b Updated messages.po 2022-02-20 20:47:08 +00:00
Michael d6725437b0 Merge remote-tracking branch 'upstream/develop' into display-permissions 2022-02-20 20:45:32 +00:00
Michael 39e820e6a3 Display the post receivers 2022-02-20 19:25:55 +00:00
k-alin ff439272b9 mysql connection via socket if location of mysqld.sock was specified 2022-02-20 17:45:51 +01:00
k-alin 50580fd04c
Merge branch 'friendica:develop' into 6606-k-alin-mysql-unix-socket 2022-02-20 17:27:03 +01:00
Hypolite Petovan c86cc83524
Merge pull request #11260 from mkljczk/develop 
API: add list members editing
 2022-02-20 09:45:25 -05:00
marcin mikołajczak 0209892631 Apply suggestions 
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
 2022-02-20 14:10:57 +01:00
Tobias Diekershoff 446775cdc8
Merge pull request #11261 from annando/notices 
Avoid warning and notice
 2022-02-20 07:23:53 +01:00
Michael Vogel d5373c583b
Merge pull request #11258 from MrPetovan/bug/11234-categories-profile 
Show only the user's categories on their profile
 2022-02-20 06:35:37 +01:00
Michael 311c1fdd81 Avoid warning and notice 2022-02-20 05:14:36 +00:00
marcin mikołajczak 9c6f6bcb95 API: add list members editing 
Signed-off-by: marcin mikołajczak <git@mkljczk.pl>
 2022-02-19 23:22:54 +01:00
Michael 00f39cd308 Reverted change 2022-02-19 20:32:19 +00:00
Michael 22952f88ca SImplify code 2022-02-19 19:45:27 +00:00
Michael 9aa0f6f547 Merge remote-tracking branch 'upstream/develop' into conversation-receivers 2022-02-19 13:52:45 +00:00
Michael c867581530 Store the receivers of a post in the tags 2022-02-19 13:31:49 +00:00
Tobias Diekershoff 32c4d8c565
Merge pull request #11256 from MrPetovan/bug/notices 
Check for array content before querying keys in Worker\Notifier
 2022-02-19 07:44:17 +01:00
Tobias Diekershoff 4770903f54
Merge pull request #11257 from MrPetovan/bug/11212-smarty-4-php8 
Switch to Smarty 4
 2022-02-19 07:38:28 +01:00
Hypolite Petovan 30dcf3380c Show only the user's categories on their profile 2022-02-18 23:58:23 -05:00
Hypolite Petovan 4fe2257d8e Prevent warnings on undefined Smarty template variables 2022-02-18 22:44:11 -05:00
Hypolite Petovan 35abf33c05 Check for array content before querying keys in Worker\Notifier 
- Address https://github.com/friendica/friendica/issues/11218#issuecomment-1045137358
 2022-02-18 20:25:18 -05:00
Hypolite Petovan c03ff7833b
Merge pull request #11253 from annando/forum3 
More rework to make private communities working
 2022-02-18 12:19:57 -05:00
Michael Vogel 4c39faca95
Merge pull request #11249 from MrPetovan/bug/11248-getinfofromurl-cache-key 
Hash the URL before using it as cache key in Util\Images::getInfoFromURLCached
 2022-02-18 17:53:20 +01:00
Tobias Diekershoff 4c7d3a6371
Merge pull request #11255 from MrPetovan/task/11245-thread-completion-like 
Relax comparison with pconfig system.accept_only_sharer value
 2022-02-18 17:09:42 +01:00
Hypolite Petovan c376081d0d Relax comparison with pconfig system.accept_only_sharer value 
- DI::pConfig()->get returns a string value, not an integer
- Removed superfluous default values now that we aren't doing strict type checking
 2022-02-18 09:32:30 -05:00
Hypolite Petovan 17d49422b4 Hash the URL before using it as cache key in Util\Images::getInfoFromURLCached 
- This prevents oversized URL from stunting the database cache
 2022-02-18 09:19:36 -05:00
Michael 39724d5079 Add the mentions 2022-02-18 09:12:33 +00:00
Michael ebb4c0f947 tests 2022-02-18 06:12:02 +00:00
Michael 0ce756596e Tests again 2022-02-18 05:56:17 +00:00
Michael 830a91e586 Avoid failed test 2022-02-18 05:34:18 +00:00
Michael 7a5a8c8d68 Improve look of reshared items on the forum profile 2022-02-17 23:06:57 +00:00
Michael 49dd97e5fd User lower case 2022-02-17 21:51:47 +00:00
Michael 234dac49b4 Rrepeat comments as well 2022-02-17 21:44:59 +00:00
Michael 1b6b6bcc6d Renamed function 2022-02-17 07:53:24 +00:00
Michael 51fb265621 Merge remote-tracking branch 'upstream/develop' into forum3 2022-02-17 07:11:50 +00:00
Michael Vogel 618dda7dd2
Merge pull request #11246 from MrPetovan/task/11245-thread-completion-like 
Expand system.accept_only_sharer pconfig value to include previous behavior with likes
 2022-02-17 08:02:19 +01:00
Michael 9ac24a0f36 More rework to make private communities working 2022-02-16 22:56:55 +00:00
Hypolite Petovan 6c0dbc1775
Merge pull request #11251 from annando/forum2 
Fix for private communities
 2022-02-15 20:16:07 -05:00
Hypolite Petovan 7dadc7f6dc
Merge pull request #11250 from nupplaphil/bug/redis_pw 
Don't use empty values for redis password and port
 2022-02-15 20:15:06 -05:00
Michael 33edfc6a5f Fix for private communities 2022-02-15 23:51:13 +00:00
Philipp be240ca500
Config Console Show 'NULL' for null-values 2022-02-15 23:10:41 +01:00
Philipp 4e58c6981c
Don't use empty, but not null values for redis password and port 2022-02-15 23:04:43 +01:00
Hypolite Petovan 3b6c40e2e6 Check the existence of the uid field before accessing it in Module\Photo 
- Address https://github.com/friendica/friendica/issues/11218#issuecomment-1039512291
 2022-02-15 15:59:35 -05:00
Hypolite Petovan 99979019bf Expand system.accept_only_sharer pconfig value to include previous behavior with likes 2022-02-15 15:54:36 -05:00
Hypolite Petovan 361fdccdc7
Merge pull request #11242 from annando/private-forums 
Private forums are now working via AP
 2022-02-15 12:06:34 -05:00
Michael d019ef57d2 Database version increased, code simplified 2022-02-15 15:44:44 +00:00
Michael Vogel 4d274cc3ea
Merge pull request #11244 from MrPetovan/bug/11232-post-media-order 
Use expected order for post medias
 2022-02-15 16:38:36 +01:00
Hypolite Petovan f329d5c067
Merge pull request #11241 from annando/timing 
Workaround for timing problems / Avoid a notice in the scheduled posts
 2022-02-15 10:20:04 -05:00
Hypolite Petovan 9ae0234bb5 Use expected order for post medias 
- This fixes the wrong display order of post pictures
 2022-02-15 09:53:24 -05:00
Michael 29d83c0ffb Block communication with Diaspora for communities 2022-02-15 07:08:02 +00:00
Michael 2b0518ac04 unset several table fields before distribution 2022-02-15 06:21:46 +00:00
k-alin 31ff583c5e mysql connection via unix sockets (mysqli + PDO) 2022-02-14 23:18:41 +01:00
Michael d404f15312 Improve local forum distribution 2022-02-14 22:04:33 +00:00
Michael a5a1c81790 Fetch the user id when not provided 2022-02-13 16:42:43 +00:00
Michael 9c60b4127b Merge remote-tracking branch 'upstream/develop' into private-forums 2022-02-13 07:03:20 +00:00
Tobias Diekershoff 41f502266e
Merge pull request #11240 from annando/thread-completion 
Avoid thread completion on activities
 2022-02-13 07:51:55 +01:00
Michael ee3a8ccb3b No notifcations for forum / fetch user for fetching content 2022-02-13 05:45:06 +00:00
Michael e394143148 Private forums are now working via ActivityPub 2022-02-12 18:38:36 +00:00
Michael Vogel 6bc69f3353 Workaround for timing problems / Avoid a notice in the scheduled posts 2022-02-12 18:27:58 +01:00
Michael cdee2b44db Avoid thread completion on activities 2022-02-12 13:05:56 +00:00
Tobias Diekershoff d65357dd92
added two help texts in the admin panel site config 2022-02-10 09:04:48 +01:00
Hypolite Petovan 1b73e4d267
Merge pull request #11230 from annando/account-type 
Use "account-type" instead of "page-flags"
 2022-02-09 22:23:55 -05:00
Hypolite Petovan 0e6fe8d8ad
Merge pull request #11228 from annando/no-db-exception 
Don't throw an exception when the database query fails
 2022-02-09 22:16:56 -05:00
Michael 5b46b41226 New function to add group members from a forum 2022-02-09 21:34:25 +00:00
Michael 9a764516d0 Use the "contact-type" instead of "forum" or "prv" 2022-02-09 06:52:16 +00:00
Michael b857c26999 Use "account-type" instead of "page-flags" 2022-02-09 05:56:12 +00:00
Michael 14f0a1a1ed Don't throw an exception when the database query fails 2022-02-08 21:28:42 +00:00
Michael f87b80266c Display followers for followers of private forums 2022-02-08 21:05:15 +00:00
Michael 061a6d9239 Use a thousands_separator to improve readability of the federation statistics 2022-02-07 19:21:39 +00:00
Michael cda348def2 Fixed grammar 2022-02-07 06:53:44 +00:00
Michael 8e70e19061 Improved texts 2022-02-07 06:43:37 +00:00
Michael 384fe562a8 More statistics 2022-02-07 06:23:49 +00:00
Michael bdba75ec47 Show detailled statistics per platform 2022-02-07 06:11:37 +00:00
Michael 58b4ecd6ae Show month/halfyear usage 2022-02-07 05:29:00 +00:00
Michael 92a71f8c27 Store wekk/month&halfyear usage / number of posts 2022-02-06 20:03:19 +00:00
Michael 8b585c6ccc Set the timeout to 10 seconds 2022-02-06 10:07:18 +00:00
Michael b3da88ceaa Don't assume AP with Wordpress 2022-02-06 09:21:14 +00:00
Michael 85f029a724 Enforce probing 2022-02-06 09:03:48 +00:00
Michael f1cac5170b mark sites as "phantom" that are up but couldn't be detected 2022-02-06 08:02:19 +00:00
Michael ea2faa28fe Use first word as platform / improvements for registered users 2022-02-06 05:59:47 +00:00
Michael 585af09b7d Only display federated servers 2022-02-06 05:58:37 +00:00
Michael 650f90df25 Platforms: only use and show trusted detections 2022-02-05 22:14:19 +00:00
Hypolite Petovan 121e40357c
Merge pull request #11209 from annando/issue-10365-Events 
Issue 10365: Event updates are now processed
 2022-02-05 12:08:00 -05:00
Michael 69d7391f90 Added comment 2022-02-05 16:49:21 +00:00
Michael 3e51309525 Check for a filled "event-id" field 2022-02-05 16:22:21 +00:00
Hypolite Petovan 321ad48649
Merge pull request #11210 from annando/detect-pumpio 
Detect pump.io servers
 2022-02-05 10:20:30 -05:00
Michael Vogel 3a96a97189
Update src/Model/GServer.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-02-05 16:01:04 +01:00
Michael 4914ee423f Issue 10914: Display events in the feed in the author's timezone 2022-02-05 11:29:50 +00:00
Michael 1564447b8c Detect pump.io servers 2022-02-05 11:25:06 +00:00
Michael bd8032f2ba Issue 10365: Event updates are now processed 2022-02-05 11:16:50 +00:00
Michael 3a6491f994 More system are added to the federation page 2022-02-04 20:45:27 +00:00
Michael 11b6c29a3a Fix for PR #11204 - Forums are now correctly detected 2022-02-04 06:02:21 +00:00
Michael 695d6ce461 Issue 10966: Ignore "only sharer" setting for forum accounts 2022-02-03 20:26:30 +00:00
Hypolite Petovan 4ad528a15c
Merge pull request #11200 from annando/issue-11034 
Issue 11034: Use the profile photo for local users
 2022-02-02 05:13:03 -05:00
Michael 4808713668 Don't cache local avatars 2022-02-01 20:22:40 +00:00
Michael c7b3c071c7 Issue 11034: Use the profile photo for local users 2022-02-01 19:12:33 +00:00
Hypolite Petovan 237492979c Add rel="tag" to the HTML Purifier allow list in BBCode::convert 
- This enables Mastodon to recognize hashtag links and prevent unwarranted link previews
 2022-02-01 08:20:45 -05:00
Michael 54d474d0e4 function documentation clarified 2022-01-31 05:47:18 +00:00
Michael 8034a48ffe "inform" functionality moved / unified functionality 2022-01-30 10:56:13 +00:00
Michael b9ea7adbda Issue 10966: Perform forum handling with the unified format 2022-01-30 04:48:22 +00:00
Michael d4f97f8a4b Issue 10966: Improved logging / reworked forum functionality 2022-01-29 19:09:18 +00:00
Michael cd0a0c3424 Issue 11189: Fix notifications for new posts 2022-01-28 05:28:13 +00:00
Michael 9eec2bf5f3 Improved support for "Page" type 2022-01-27 17:51:23 +00:00
Michael c5337c81e7 Improve contact search speed / assume octet-stream on missing content type 2022-01-27 04:05:11 +00:00
Tobias Diekershoff b6aeb6e903
Merge pull request #11180 from annando/announce-notification 
Desktop notification for announced posts
 2022-01-24 07:24:39 +01:00
Michael f23a264cb4 Fix wrong spelling 2022-01-24 04:58:46 +00:00
Michael 564517607f Notifications for participation added 2022-01-24 04:49:13 +00:00
Michael e4887d23d2 Needless coude duplication removed 2022-01-24 04:15:36 +00:00
Michael 27a306185a Improved notification for announced posts 2022-01-23 21:47:16 +00:00
Philipp 3d8e82d95d
Merge pull request #11141 from urbalazs/language-names 
Add native language names to language selector & fix config during install
 2022-01-23 20:55:40 +01:00
Hypolite Petovan 53f06b5122
Merge pull request #11179 from nupplaphil/bug/friendica-11178 
Fix Addons-Load for StorageManager
 2022-01-23 14:53:16 -05:00
Philipp 150e3a6f42
Add DEVELOP flag for StorageManager for testing purpose only 2022-01-23 20:40:38 +01:00
Michael 2b0c2a57a7 Merge remote-tracking branch 'upstream/2021.12-rc' into announce-notification 2022-01-23 19:38:16 +00:00
Michael 8bb2c9fc13 Support for desktop notifications for reshared posts 2022-01-23 19:37:52 +00:00