Hypolite Petovan
ad9c67663d
Move Contact::Page_* constants to User::PAGE_FLAGS_*
2019-01-21 10:55:37 -05:00
Hypolite Petovan
4a95ca280d
Remove unused code
...
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
Hypolite Petovan
cb3f09ae4f
Refactor namespaces
...
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
Hypolite Petovan
3282ce5389
Fix PHPDoc comments project-wide
2019-01-21 10:35:51 -05:00
fabrixxm
b640024b51
Item model, fix deletion of all attachments
...
Item model delete all attachments on item deletion, but it should check
if same attachment isn't used somewhere else.
2019-01-21 10:00:45 -05:00
fabrixxm
b7b3086263
Attach: store, update, delete. Model and views
2019-01-21 10:00:44 -05:00
Hypolite Petovan
55e54bb950
Replace deprecated Addon::callHooks with Hook::callAll
...
- Update documentation
2019-01-21 09:50:56 -05:00
Hypolite Petovan
16fabb4e04
Replace misuses ItemDeliveryData::FIELD_LIST with LEGACY_FIELD_LIST
2019-01-21 09:39:15 -05:00
Hypolite Petovan
38734f17b9
Honor item delivery data legacy fields
2019-01-21 09:39:15 -05:00
Hypolite Petovan
85eb6affdf
Unit test fix
2019-01-21 09:39:14 -05:00
Hypolite Petovan
1696ad962e
Add delivery queue number manipulation
...
- Add new ItemDeliveryData model class
- Add queue_count initialization in Notifier
- Add queue_done incrementation in various Delivery tasks
2019-01-21 09:36:51 -05:00
Hypolite Petovan
dea1a98a5d
Fix various documentation issues/unused variables
2019-01-21 09:33:24 -05:00
fabrixxm
8c75c26361
Use Model\Photo as much as possible
...
Most important is to use `Photo::delete()` to have backend
to remove data.
2019-01-21 09:12:28 -05:00
Michael
c359c162a7
Issue 6282: Update the contact data regularly (including the network)
2019-01-16 21:39:56 +00:00
Hypolite Petovan
5e1ceb57de
Escape global namespaced get_app() calls
...
- Add deprecated status
2019-01-03 21:27:36 -05:00
Hypolite Petovan
acaee626f5
Remove include/ requires that are now done directly from Composer
2018-12-24 09:56:25 -05:00
Michael
f2e2066d33
Non public content is now displayed again to visitors.
2018-12-09 13:09:49 +00:00
Hypolite Petovan
458981f75c
Replace x() by isset(), !empty() or defaults()
...
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Hypolite Petovan
4874f7f8ab
Remove useless rawurlencode calls for building hashtag bbcode
...
- Fix some formatting
2018-11-22 09:32:41 -05:00
Jonny Tischbein
458b0f3545
Change how to decide between empty update and not called field file
2018-11-17 16:04:54 +01:00
Jonny Tischbein
52eb2281e4
Fix deleting last element from saved folder + Fix displaying empty saved folder
2018-11-17 12:41:00 +01:00
Michael
6ad082a710
Improved delete text to clarify AP comment delete behaviour
2018-11-15 06:36:06 +00:00
Adam Magness
218f0734be
Rename removeTags to escapeTags
...
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
063f0e9cb0
Rename escapeTags to escapeHtml
...
rename function and update calls.
2018-11-09 13:27:58 -05:00
Adam Magness
b5a97c1abe
Move getTags to BBCode
...
move getTags function to BBCode class and update calls.
2018-11-09 13:24:19 -05:00
Adam Magness
ffc406d819
normalise_link calls
...
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
5276c28a78
link_compare calls
...
implement compareLink function.
2018-11-08 10:46:50 -05:00
Adam Magness
0e01568ccd
escape_tags calls
...
implement escapeTags function
2018-11-08 10:20:03 -05:00
Adam Magness
a0f65ca7a1
notags calls
...
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb
random_string calls
...
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness
003eee5912
Standards
...
fix indentation level, replace x() with !empty()
2018-11-07 14:16:59 -05:00
Adam Magness
7cb9138201
Move another function
...
move get_plink to Item class, and also fix up getApp since we extend BaseObject
2018-11-07 07:19:39 -05:00
Adam Magness
d50a1edef4
Split text to Item
...
move functions from text.php to Item class
2018-11-06 21:12:41 -05:00
Adam Magness
d9b558a8ed
Update function calls
...
update function calls to new class.
2018-10-30 14:51:45 -04:00
Adam Magness
50da89d861
Logger Levels
...
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
14fde5dc9b
Log function
...
implement log() function.
2018-10-30 09:57:14 -04:00
Michael
84be62982a
Diaspora signature transport via AP/DFRN should be repaired now
2018-10-29 21:15:37 +00:00
Michael
4831688dc0
Diaspora signatures are now stored and transmitted correctly
2018-10-27 14:35:22 +00:00
Michael
73f596cc46
Fixes duplicated transmissions and not working undo of like/dislike
2018-10-27 11:09:23 +00:00
Hypolite Petovan
f174bc1bc2
Merge pull request #6028 from annando/issue-5913
...
Issue 5913: Fix fatal error in "RemoveUser"
2018-10-26 00:32:16 -04:00
Michael
348e0300a6
Issue 5913: Fix fatal error in "RemoveUser"
2018-10-26 04:27:23 +00:00
Jonny Tischbein
e022bac339
Code Standard + renaming deleteAllTags + move its call and add type param
2018-10-25 21:47:10 +02:00
Jonny Tischbein
26ed71cc14
Only perform Term::deleteAllTags when needed + not needed redirect
2018-10-25 21:47:10 +02:00
Jonny Tischbein
fd2e06781d
Fix adding / removing photo tags + tagrm delete via GET + Item::update / add Term::deleteAllTags
2018-10-25 21:47:10 +02:00
Hypolite Petovan
ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security
...
Move and Split include/security
2018-10-19 08:55:08 -04:00
Michael
0628b44f8e
The handling with item-content and item-activity had been simplified
2018-10-18 21:35:48 +00:00
Jonny Tischbein
a937cf06a3
add remaning/moving to files not touch by refactoring because of typo
2018-10-17 22:35:49 +02:00
Jonny Tischbein
f3fc1f36ca
Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments
2018-10-17 21:30:41 +02:00
Hypolite Petovan
e254ace9d5
Merge pull request #5947 from annando/uri-id
...
Use "uri-id" for item relations
2018-10-17 14:45:40 -04:00
Michael
62ad755980
Use "uri-id" for item relations
2018-10-17 18:34:24 +00:00
Jonny Tischbein
05be2db725
Move include/security tp /src/Core/Authentication and /src/Util/Security
2018-10-17 14:19:58 +02:00
Hypolite Petovan
c50be325bd
Remove unused parameter $selected in Model\Item::fieldlist
2018-10-16 18:30:24 -04:00
Michael
8d0f4710a4
Signed Diaspora posts should now be stored more reliable
2018-10-15 21:42:55 +00:00
Michael
4d4dd1a99c
Some beautification
2018-10-12 20:52:22 +00:00
Michael
1b18be6715
The virtuel fields for the diaspora signatures have to be removed at any time
2018-10-12 18:47:32 +00:00
Philipp Holzer
5a02e39a65
Rename App Methods
...
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
Michael
510032444f
The owner of a "like" should be the author
2018-10-06 08:51:52 +00:00
Michael
518d461a8f
Issue 5811: "objects" instead of "object"
2018-10-02 20:12:38 +00:00
Michael
82987d018a
Some changes for better code quality
2018-09-30 07:21:57 +00:00
Michael
cb9be8a7ab
UUID is now createUUID
2018-09-27 11:52:15 +00:00
Michael
60b0759b50
UUID instead of GUID
2018-09-26 20:03:46 +00:00
Michael
834422d52f
Merge remote-tracking branch 'upstream/develop' into ap1
2018-09-24 21:48:40 +00:00
Hypolite Petovan
a6996601d5
Merge pull request #5789 from friendica/master
...
Update develop from master-2019.09
2018-09-23 18:55:20 -04:00
Michael
6df6d82427
We can now like and dislike
2018-09-23 08:52:07 +00:00
Michael
f772ece86f
New delivery module for ap
2018-09-17 21:13:08 +00:00
Michael
6f3b2b6586
Handling of unlisted posts, better uid detection
2018-09-16 09:06:09 +00:00
Michael
6a8ebc8639
Contact follow and unfollow workd partially
2018-09-15 18:54:45 +00:00
Michael
fb5b6e4a14
New uri format for our posts that is AP compatible
2018-09-15 07:37:34 +00:00
Michael
61e2c7d20d
Added AP to many network conditions / enabling inbox processing
2018-09-14 16:51:32 +00:00
Philipp Holzer
bd2b3b1ef5
LockDriverFixings
...
- release Locks in case of failures
- adding some cache tests
2018-09-06 08:11:18 +02:00
Michael
c72d1bc8fd
Issue 5653: The mastodonemoji addon hadn't got all needed data.
2018-08-29 20:46:52 +00:00
Michael Vogel
edcd0a3744
Issue 4960: Ignoring and blocking of contacts should work again ( #5657 )
...
* Issue 4960: Ignoring and blocking of contacts should work again
* Renamed functions
* This function should be renamed as well.
* We now have a frontend to block and ignore public contacts
* Hide some parts for public contacts
* Removed notices, public contact is now accessible from dirfind as well
* We now show contact conversations and contact posts
* We now use a new conversation mode
* The update functionality is disabled until it will work completely
* Fixing tabs chaos
* Update after posts on the contacts page will now work
* Show connect link
2018-08-25 09:48:00 -04:00
Michael Vogel
7f3fb34c24
Some easy to replace "q" calls have been replaced by "DBA" calls ( #5632 )
...
* Some easy to replace "q" calls have been replaced by "DBA" calls
* Simplified the GUID creation
* And one in the API ...
* And OStatus has got some DBA calls more
* Just some more replaced database calls
* The event query is now simplified
* Events are now shown again
* subthread is now using the DBA calls as well
* Some more replaced database calls
* And some more replaced database calls and prevented notices
* Better use gravity
* Some more replaced database stuff
* Some more replaced database calls in DFRN.php
* The gcontact class now has got the new DBA functions as well
* The Contact class is now changed to new database functions as well
* Small correction
* We can now delete without cascade
* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
Michael
bb0cf93374
Fix for storing posts of private forums
2018-08-15 20:13:10 +00:00
Michael
e8334c4655
Use the Item class instead of DBA calls when possible
2018-08-15 04:41:49 +00:00
Roland Häder
e06fc2aa69
Stopped using deprecated constants NETWORK_* ( #5537 )
...
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
Michael Vogel
276abfaba6
Issue 5158: Ignore all threads, even public ones ( #5588 )
...
* Issue 5158: Ignore all threads, even public ones
* Remove some notice
* Now it really should work
* Using "defaults"
2018-08-08 22:32:11 +02:00
Michael Vogel
c032011143
Post update script for setting the uri-id ( #5573 )
...
* Post update is working now
* Changed text.
2018-08-06 18:40:41 +02:00
Michael Vogel
ef1c73fb6b
Merge pull request #5561 from MrPetovan/bug/4584-fix-twitter-gif-still-image
...
Restore source storing for Twitter conversations
2018-08-05 14:00:19 +02:00
Michael Vogel
fa46e97f27
We now store the uri data in a separate table ( #5560 )
...
* We now have a item-uri table
* Fixing line endings
* New item uri table
* Rescued ItemURI.php file
* Reverting some git problem
* Corrected the dbstructure file
* Updated database.sql / we now store content in the new id fields
2018-08-05 13:09:59 +02:00
Hypolite Petovan
c13dc549ed
Rename PROTOCOL_* constants to Model\Conversation::PARCEL_*
...
- Remove unused Conversation::PROTOCOL_GS_CONVERSATION constant
- Remove now renamed PROTOCOL_* constant declarations
2018-08-05 12:24:42 +02:00
Michael Vogel
8dea36bd8f
We shouldn't cascade this deletion as well ( #5558 )
2018-08-05 11:02:36 +02:00
Michael Vogel
2f2b134e58
Fixes issue 5321: Likes can be undone and comments can be deleted again ( #5557 )
2018-08-05 06:35:11 +02:00
Michael Vogel
c39e0dcf2a
Fix for vanishing notes ( #5531 )
...
* Fix for vanishing notes
* The field needs to be part of the selected fields ...
2018-07-30 22:23:48 -04:00
Michael
dc9b10fb09
Moved expiring of item content
2018-07-29 03:54:34 +00:00
Michael Vogel
36d4516e7a
Missing stuff in "develop"? ( #5516 )
...
* "post-type" replaces "bookmark" and "type"
* Removed some more type
* Added index to permission set
* The permission set is now stored
* The permission set is now removed upon expiry
* Post update now stores the permission set
* New file
* Permissions are now sorted
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
* Postupdate now handles "postopts" as well
* Set deprecated fields to "null" if empty
* Postupdates are enabled again
* "post-type" replaces "bookmark" and "type"
* The permission set is now stored
* The permission set is now removed upon expiry
* Postupdate now handles "postopts" as well
2018-07-28 13:11:46 -04:00
Roland Häder
4a22710b3b
Moved global PAGE_* to Profile class ( #5500 )
...
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*
* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`
* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Michael Vogel
986106a8f7
Item storage: Permissions aren't stored in the items anymore ( #5495 )
...
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
2018-07-25 19:14:55 -04:00
Roland Häder
37253656e3
Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace ( #5490 )
...
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class
* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
2018-07-24 22:53:46 -04:00
Hypolite Petovan
b6e3da8443
Move addLanguageToItemArray call when body is ensured
2018-07-24 08:52:25 -04:00
Hypolite Petovan
4e9ba728c4
Fix undefined index body in Model\Item
2018-07-24 07:54:12 -04:00
Hypolite Petovan
ecea7425f8
Rename DBA::is_result to DBA::isResult
2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a
Rename DBM method calls to DBA method calls
2018-07-23 11:02:24 -04:00
Hypolite Petovan
415b982d39
Rename DBA::num_rows to DBA::numRows
2018-07-22 19:27:35 -04:00
Hypolite Petovan
f051ae1698
Rename DBA::fetch_first to DBA::fetchFirst
2018-07-22 19:27:34 -04:00
Hypolite Petovan
e42cf4d4fc
Rename DBA::affected_rows to DBA::affectedRows
2018-07-22 19:27:34 -04:00
Michael Vogel
7382be2766
Some more notices ( #5424 )
2018-07-20 14:07:54 -04:00
Hypolite Petovan
af6dbc654f
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 08:19:26 -04:00
Hypolite Petovan
daa1177e3a
Update use statement lists with new Friendica\Database\dba class
...
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Michael Vogel
ec49d004e3
We now store the item delivery data in a separate table ( #5413 )
...
* We now store the item delivery data in a separate table
* Reorganized table structure
2018-07-19 17:56:52 -04:00