Commit Graph

6723 Commits

Author SHA1 Message Date
Hypolite Petovan c7a2988454 Check for the existence of array key before using it in Protocol\ActivityPub\Transmitter
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-739534960
2020-12-08 10:08:49 -05:00
Hypolite Petovan 99828c0fea Suppress notice message when guid isn't supplied in Module\Admin\Item\Source
- https://github.com/friendica/friendica/issues/9252#issuecomment-740052103
2020-12-08 10:00:09 -05:00
Michael e17ca9cc35 Check for remote default avatars as well 2020-12-07 07:14:09 +00:00
Michael a49a35f459 Centralized fetching of the default avatar 2020-12-07 06:43:43 +00:00
Michael 9acecfd9e6 Issue 9630: Prevent negative values for registered users 2020-12-06 18:14:05 +00:00
Michael Vogel ce52d31afa
Merge pull request #9626 from MrPetovan/bug/9611-bbcode-convert-html-purify
Prevents share block new lines from being converted to HTML <br> tags
2020-12-06 15:53:18 +01:00
Hypolite Petovan e6270bc46d Enable back references in reg exp in BBCode::convert
- Bump BBCode version
2020-12-06 08:57:06 -05:00
Hypolite Petovan a863228e09
Merge pull request #9628 from annando/dfrn-delete
Don't create the parent during a deletion
2020-12-06 08:37:50 -05:00
Michael 1f1697222b Don't create the parent during a deletion 2020-12-06 09:54:34 +00:00
Hypolite Petovan f141f5acf4 Prevents share block new lines from being converted to HTML <br> tags
- Address https://github.com/friendica/friendica/pull/9621#issuecomment-739333767
2020-12-05 19:55:16 -05:00
Michael 878a418c6b Code standards 2020-12-05 21:58:15 +00:00
Michael 2b8adf5073 Remove unused contacts 2020-12-05 21:07:48 +00:00
Michael Vogel f9994548c1
Merge pull request #9621 from MrPetovan/bug/9611-bbcode-convert-html-purify
Add HTML Purify to BBCode::convert
2020-12-05 19:27:59 +01:00
Hypolite Petovan 1cc509c5ef Move BBCode version tagging inside of the hash to prevent item-content.rendered-hash overflow 2020-12-04 08:30:51 -05:00
Hypolite Petovan e712706302 Add BBCode versioning
- This will trigger the re-conversion of displayed items on version update
2020-12-04 07:29:49 -05:00
Hypolite Petovan a382798999 Add some more result panels to Babel 2020-12-04 07:29:48 -05:00
Hypolite Petovan a0f6d678c4 Add HTML Purify to BBCode::convert
- Replace previous HTML cleanup using DOMDocument
- Remove obsolete HTML::sanitizeCSS method
- Use Strings::autoLinkRegEx for PageInfo::getRelevantUrlFromBody
- Update previous tests expectations
- Add new specific XSS tests
2020-12-04 07:29:48 -05:00
Michael 8e9a9b2049 Improved logging 2020-12-04 07:54:29 +00:00
Michael 9f96f3ef34 Moved updating personal contacts to updatecontact 2020-12-04 05:53:11 +00:00
Michael 8d999f54d0 Check and add a server 2020-12-03 22:32:51 +00:00
Michael 0c9a0ce64e Merge remote-tracking branch 'upstream/develop' into worker-command 2020-12-03 15:48:46 +00:00
Michael edbdfbae6b workerqueue now has a "command" field 2020-12-03 15:47:50 +00:00
Michael bd4dc10588 Ensure that the database.sql contains "if exists" 2020-12-02 08:50:45 +00:00
Michael c1d1b189f7 Cleaned code 2020-12-02 08:36:23 +00:00
Michael 6c3b1ac4bd Moved direct storage 2020-12-02 05:41:33 +00:00
Michael b54465ba9c Directly post non mirrored feed items 2020-12-02 05:08:39 +00:00
Michael 775075c5db Only spool mirrored posts 2020-12-02 05:07:44 +00:00
Michael e9fecf1541 Only delay mirrored feeds 2020-12-02 04:53:54 +00:00
Michael b2dadf0f92 Use a combined unique index 2020-12-02 00:34:10 +00:00
Michael 425440ec24 The network doesn't matter 2020-12-02 00:29:57 +00:00
Michael c302b7c347 Check for existing post 2020-12-02 00:20:07 +00:00
Michael 4fbd0a46b5 Reducing parameter list 2020-12-02 00:05:03 +00:00
Michael b047d31a4f Added logging and default config value 2020-12-01 23:46:50 +00:00
Michael a283b1183b Move deletion 2020-12-01 23:04:04 +00:00
Michael Vogel b3f71d174c Added logging 2020-12-01 23:54:49 +01:00
Michael 2aa302c570 New class for handling delayed posts 2020-12-01 22:11:29 +00:00
Michael bb823c323b Configuration for the priority of the notification for expired messages 2020-11-30 21:40:55 +00:00
Hypolite Petovan 4f98da88c4
Merge pull request #9614 from annando/issue-8943
Issue 8943: Only check for too old postings for feeds
2020-11-30 16:09:27 -05:00
Michael b30d2c9c6b Renamed function 2020-11-30 20:59:18 +00:00
Hypolite Petovan 9636ffe27d
Merge pull request #9615 from annando/issue-9329
Issue 9329: prevent "Expression #1 of SELECT list is not in GROUP BY clause"
2020-11-30 15:58:39 -05:00
Michael ccc07b06de Issue 9329: prevent "Expression #1 of SELECT list is not in GROUP BY clause" 2020-11-30 20:44:21 +00:00
Michael 8bc799ff38 Issue 8943: Only check for too old postings for feeds 2020-11-30 20:32:56 +00:00
Michael 20649dd00e Replaced tab with space 2020-11-30 20:09:52 +00:00
Michael 1e09eab921 Another place found where "show less" had been "show more" 2020-11-30 19:52:57 +00:00
Michael d4d55a5865 Issue 8605: "show less" now displays "show less" 2020-11-30 19:30:57 +00:00
Michael 5b19469a4c Fix Notice: Undefined variable: publish_at 2020-11-30 18:27:02 +00:00
Michael Vogel d0f45c4ecb Fixed function name and variable 2020-11-30 09:59:29 +01:00
Michael 6e06e0cf20 New class for delayed postings 2020-11-30 06:59:00 +00:00
Michael cbd1ba8da2 Post delay is in seconds 2020-11-30 06:23:27 +00:00
Michael a7e0a1f7de The maximum delay should be a day 2020-11-30 06:19:10 +00:00
Michael Vogel 4c39c88b52 Adjusted log levels, removed spaces 2020-11-30 07:06:43 +01:00
Michael 3f3f56db57 Poll interval function moved to feed class, first steps for delayed posts 2020-11-30 05:39:12 +00:00
Hypolite Petovan d05d5a0381
Merge pull request #9608 from annando/delete-table-view
Ensure that a view is a view and not a table
2020-11-29 16:33:07 -05:00
Michael Vogel eb48a36061
Update src/Database/View.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-29 21:59:24 +01:00
Michael 5f1ea39bad Display posts that are reshared by the contact 2020-11-29 20:42:03 +00:00
Michael 7e6a9bd893 Ensure that a view is a view and not a table 2020-11-29 19:06:43 +00:00
Hypolite Petovan ea2923be67
Merge pull request #9607 from annando/cron-priority
Ensure to add the cron forkhood worker task with medium priority
2020-11-29 12:49:02 -05:00
Michael Vogel 03af4062ce Ensure to add the cron forkhood worker task with medium priority 2020-11-29 17:41:20 +01:00
Michael a68810301a Fix structure error 2020-11-29 11:43:07 +00:00
Michael 7ab63d2106 Store the protocol of the received message 2020-11-29 09:01:51 +00:00
Michael 8da8d3c4fd Only automatically reshare items from DFRN and AP 2020-11-29 00:05:46 +00:00
Michael bda5d43f1e New "remote self" option: Native Reshare 2020-11-28 22:53:58 +00:00
Hypolite Petovan 96d4ec0f53
Merge pull request #9603 from annando/notice
Fixes notice "Undefined index: parent-uri"
2020-11-28 08:01:28 -05:00
Michael 1d4be7b01f Fixes notice "Undefined index: parent-uri" 2020-11-28 10:17:55 +00:00
Michael b6f349076c Fix order of reshared items on the profile page 2020-11-28 06:23:17 +00:00
Michael bd9f36622e Cast field data when ATTR_EMULATE_PREPARES is enabled 2020-11-27 11:24:31 +00:00
Hypolite Petovan f0d6f8c45e
Merge pull request #9597 from annando/api-endpoints
API: Mastodon endpoints added as "unimplemented"
2020-11-26 09:34:36 -05:00
Michael Vogel 615eece22f
Update src/Module/Api/Mastodon/Unimplemented.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-26 14:35:06 +01:00
Michael db5cd6e66c API: Mastodon endpoints added as "unimplemented" 2020-11-26 07:02:31 +00:00
Michael 818c064c0a The notifications parameters are now simplified 2020-11-25 19:56:39 +00:00
Hypolite Petovan 486b43f09d Avoid unmarking for archival an empty contact in Protocol\ActivityPub\Receiver
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-733198306
2020-11-24 17:32:52 -05:00
Hypolite Petovan 1342825401
Merge pull request #9586 from annando/inbox-status
Don't transmit to archived inboxes
2020-11-24 03:04:03 -05:00
Michael 495252690b available is not vital 2020-11-24 07:49:36 +00:00
Michael 23bc725ce9 Fix: Only echo on verbose 2020-11-23 19:47:30 +00:00
Michael e4e9a20ac8 Don't transmit to archived inboxes 2020-11-23 19:25:22 +00:00
Michael 61ff99c410 Command line option to check initial values 2020-11-23 18:58:18 +00:00
Hypolite Petovan 794f98f479
Merge pull request #9578 from annando/onepoll-failed
OnePoll reworked, improved "failed" behaviour
2020-11-22 10:42:41 -05:00
Michael 7bdf22a0d5 Don't probe feeds so often 2020-11-22 14:56:38 +00:00
Michael 3ffd40c7da OnePoll reworked, improved "failed" behaviour 2020-11-22 14:42:24 +00:00
Hypolite Petovan 4fd9db1035
Merge pull request #9577 from annando/updateprofile
Contacts can now be updated from every theme
2020-11-22 08:14:09 -05:00
Michael b52ba79620 Contacts can now be updated from every theme 2020-11-22 08:15:17 +00:00
Hypolite Petovan ca823244cc Don't assume addons must have an *_install function
- Module-only addons don't have any
2020-11-21 23:19:03 -05:00
Hypolite Petovan 8b3ab4e6bb Refactor builtin_activity_puller() and format_like()
- Simplify output array
- Rename format_like() to format_activity()
- Remove duplicate parameters in format_activity()
2020-11-21 11:08:44 -05:00
Hypolite Petovan e6362c4923
Merge pull request #9566 from annando/update-foo
Avoid multiple database update mails, changed log level
2020-11-21 10:53:06 -05:00
Michael aec9f1ebf0 Remove unused config variable 2020-11-21 15:15:58 +00:00
Michael 1de6251627 Code cleaning 2020-11-21 14:58:48 +00:00
Michael Vogel b40218eb0b Immediately fail when lock hadn't been acquired to prevent stocked updates 2020-11-21 14:17:14 +01:00
Michael Vogel 2a1c82cf05 Avoid multiple database update mails, changed log level 2020-11-21 13:28:06 +01:00
Michael 8a29d20083 Comments on PeerTube videos not working
Fixes #9407
2020-11-21 08:28:33 +00:00
Michael 1bc76fdb6d Watchdog mode to check if the daemon is running 2020-11-20 19:50:08 +00:00
Michael cea2b13075 Parameter has to be float 2020-11-20 08:55:30 +00:00
Michael e4c95efd80 Added minimal execution time for rendertime addon 2020-11-20 08:44:00 +00:00
Michael 32e98327a1 Fix warning 2020-11-19 21:27:08 +00:00
Hypolite Petovan 1acc5ffb38
Merge pull request #9553 from annando/insert-mode
Mode switch for insert
2020-11-19 16:25:09 -05:00
Hypolite Petovan 10a4802d81
Merge pull request #9552 from annando/zero-user
Avoid problems with uid=0
2020-11-19 16:23:28 -05:00
Michael 303aaa00ca Mode switch for insert 2020-11-19 19:34:48 +00:00
Michael Vogel e4c6341bf4
Merge pull request #9551 from MrPetovan/task/4140-ldap-auth-logging
Make Model\User::getAuthenticationInfo accessible to addons
2020-11-19 18:21:34 +01:00
Michael bd0e2dc0a8 Avoid problems with uid=0 2020-11-19 17:19:14 +00:00
Hypolite Petovan a66e66359c Make Model\User::getAuthenticationInfo accessible to addons
- It contains the centralized authentication requirements for user records
2020-11-19 11:20:17 -05:00
Michael 3af5f6b8ee Some more foreign keys added 2020-11-19 06:26:30 +00:00
Michael Vogel f69c043bec
Update src/Protocol/OStatus.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-18 18:07:20 +01:00
Michael a1dcbedc6f Fix Notice: Undefined variable: valid in /src/Protocol/OStatus.php on line 526 2020-11-18 13:47:29 +00:00
Michael 0edc058a17 Ensure that the daemon is called faster and more reliably 2020-11-18 13:29:10 +00:00
Michael f36ecdf6bf Replacing deprecated log calls 2020-11-18 09:14:12 +00:00
Michael 4f7d42a0d3 Fixed copy&paste error 2020-11-18 05:55:15 +00:00
Michael b09ffa0697 Relocate system user creation 2020-11-18 05:33:17 +00:00
Michael d7fa58d81c Ensure to never delete the "0" user 2020-11-18 05:24:04 +00:00
Michael 81a03b137b Test: only insert empty user 2020-11-18 05:04:17 +00:00
Michael 1e9d3342a3 Changed order of inserts 2020-11-18 00:13:39 +00:00
Michael fed1ace311 Fix condition 2020-11-17 23:59:14 +00:00
Michael 317921e51c Changed order 2020-11-17 23:45:16 +00:00
Michael 3fe7d035d4 Merge remote-tracking branch 'upstream/develop' into post-user 2020-11-17 23:31:41 +00:00
Michael Vogel dc5624b0b6
Merge pull request #9543 from MrPetovan/bug/notices
Address several notices
2020-11-18 00:30:31 +01:00
Hypolite Petovan 096cb19d12 Suppress notice when causer-id exists but not causer-link in Model\Item::isAllowedByUser
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-723440980
2020-11-17 18:06:16 -05:00
Hypolite Petovan ccad67c68f Use correct contact key in Protocol\ActivityPub\Transmitter
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-719866843
2020-11-17 17:59:39 -05:00
Hypolite Petovan 93380b8471 Suppress notice while logging in Model\Contact
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-716042132
2020-11-17 17:57:37 -05:00
Hypolite Petovan 283b70928d Remove top-level parent check from Protocol\OStatus
- It's done in Item::insert instead
- Address part of https://github.com/friendica/friendica/issues/9252#issuecomment-729171051
2020-11-17 17:54:07 -05:00
Hypolite Petovan 54aef550c5 Remove superfluous mentions of parent-uri in Protocol\Diaspora
- Address part of https://github.com/friendica/friendica/issues/9252#issuecomment-729171051
2020-11-17 17:54:07 -05:00
Michael 7615c022be Improved logging 2020-11-17 22:41:53 +00:00
Michael 219c651289 Removed test logging 2020-11-17 22:38:52 +00:00
Michael eaa58da25b New table "post-user" and more foreign keys 2020-11-17 22:33:44 +00:00
Hypolite Petovan b2666e7794 Escape user name in introduction fields help text
- HTML help text aren't escaped in the template

# Conflicts:
#	src/Module/Notifications/Introductions.php
2020-11-16 18:21:11 -05:00
Hypolite Petovan ba0d3b2435
Merge pull request #9537 from annando/item-lock
Fallback to database lock if locking fails
2020-11-16 16:05:24 -05:00
Michael deb6b7a7c3 Fallback to database lock if locking fails 2020-11-16 19:46:20 +00:00
Hypolite Petovan a69c98e32f
Merge pull request #9535 from annando/ap-relay
Relay code reworked to support AP delivery
2020-11-15 20:27:08 -05:00
Michael 0384bf3e76 Relay code reworked to support AP delivery 2020-11-15 23:28:05 +00:00
Michael Vogel 42be636118
Merge pull request #9515 from MrPetovan/task/9464-block-replies
Reject replies when author is blocked by thread owner
2020-11-15 18:44:48 +01:00
Hypolite Petovan dbb33399bc Prevent image descriptions from being replaced by local smilies
- AP-received emojis have their code in the image description
2020-11-15 00:12:26 -05:00
Hypolite Petovan b5d3fcb8d4 Move top-level permission check outside of Model\Item::getTopLevelParentData
- It wasn't checked when the direct parent was also the top-level parent
2020-11-14 10:11:26 -05:00
Hypolite Petovan cb963a3259 Retrieve local top level parent item separately to check permissions in Model\Item::getTopLevelParentData 2020-11-14 10:11:26 -05:00
Hypolite Petovan 2e7c505ac0 Revert wrong item.thr-parent field usage in Protocol\OStatus 2020-11-14 10:08:52 -05:00
Hypolite Petovan 042f6b98ac Remove unnecessary data array assignment in Protocol\Feed 2020-11-14 10:08:51 -05:00
Hypolite Petovan 5ce8cc24de Clarify parameter type in DFRN::mail 2020-11-14 10:08:51 -05:00
Hypolite Petovan ff66633a44 Remove references to item.parent-uri in Worker\OnePoll 2020-11-14 10:08:51 -05:00
Hypolite Petovan a9d114316d Ensure the parent field isn't set during Item insertion
- Avoid a database error if a null value is provided
2020-11-14 10:08:51 -05:00
Hypolite Petovan d3708cf1c2 Fix wrong variable use in Model\Item::getTopLevelParent
- It was preventing items at levels 3 and beyond to be inserted
- Logging for missing top level parent has been bumped to notice
2020-11-14 10:08:51 -05:00
Hypolite Petovan 355cd401ae Replace uri fields conditions by gravity condition in Model\Item::insert 2020-11-14 10:08:51 -05:00
Hypolite Petovan ffc364f2a4 Reject replies when author is blocked by thread owner in Model\Item::insert
- Move user-level item permission to Model\Item::isAllowedByUser
- Add user-level check for comments on top-level item
2020-11-14 10:08:50 -05:00
Hypolite Petovan 0f2a5daf09 Replace confusing uses of item.parent-uri with expected item.thr-parent 2020-11-14 10:08:50 -05:00
Hypolite Petovan 0c3a5c815e Remove obsolete references to item.parent-uri 2020-11-14 10:08:50 -05:00
Hypolite Petovan d7e1ce47bb Use item.thr-parent as expected in Model\Item::insert()
- Rework Model\Item::getTopLevelParent
- Backward compatibility with item.parent-uri is ensured
2020-11-14 10:08:50 -05:00
Hypolite Petovan 490ce976c1
Merge pull request #9531 from annando/fatal
Check for empty body to prevent a fatal error
2020-11-12 13:41:26 -05:00
Michael ae363b74ad Check for empty body to prevent a fatal error 2020-11-12 16:52:55 +00:00
Hypolite Petovan 6dee10f340
Merge pull request #9530 from annando/fatal
Fix fatal errors
2020-11-12 07:57:53 -05:00
Michael 36c65643fb Fix fatal errors 2020-11-12 05:17:48 +00:00
Michael Vogel acae3df0a2
Merge pull request #9526 from MrPetovan/bug/9525-mastodon-emojis-tag
Restore expected implementation of JsonLD::fetchElementArray
2020-11-12 05:47:46 +01:00
Hypolite Petovan a8f16788f4 Prevent multiple replacements for the same emoji in Protocol\ActivityPub\Processor::replaceEmojis 2020-11-11 18:28:26 -05:00
Hypolite Petovan 42db861759
Merge pull request #9527 from annando/fetch-object-by-url
Fix: Fetch object by URL
2020-11-11 13:14:20 -05:00
Michael ba38ab2c55 Fix: Fetch object by URL 2020-11-11 17:55:33 +00:00
Hypolite Petovan fa003eaa84 Fix expected implementation of JsonLD::fetchElementArray
- Added expected field value matching
2020-11-11 11:19:08 -05:00