Commit Graph

1478 Commits

Author SHA1 Message Date
Hypolite Petovan
21f172c585 Merge pull request #12674 from nupplaphil/bug/config_typesafe
Config: Improve the node.config.php transformation
2023-01-15 09:38:29 -05:00
Philipp
bc60eb6cb7 Apply feedback and describe the encoding method 2023-01-15 11:57:43 +01:00
Philipp
4c28f9cf9c Config: Improve the node.config.php transformation
- Add more types
- Improvement for assoziative arrays and key-value arrays
- Add a lot more tests
2023-01-15 00:53:51 +01:00
Hypolite Petovan
e73adde5fb Remove App dependency from Hook::callSingle
- This was causing a circular dependency with the logger_instance hook
2023-01-14 10:38:37 -05:00
Philipp
fef10e8a57 Improve encapsulation 2023-01-11 22:00:29 +01:00
Philipp
11a8bd17e3 Assure that deleted cat/keys are working as expected
- A deleted cache-key would delete a merged cache-key as well
- Deleting a key in the Model results in reloading the config to assure any value from underlying files
2023-01-11 21:53:34 +01:00
Philipp
fd882abd80 Revert Cache delete() behavior to stable version 2023-01-11 21:10:59 +01:00
Hypolite Petovan
3966b58965 Only show line number if it's provided in System::callstack
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1377373973
2023-01-10 10:41:20 -05:00
Hypolite Petovan
4d5d8e5b64 Add line number to output in System::callstack 2023-01-09 16:06:22 -05:00
Philipp
979672a3c1 Filter disabled addons with "null" 2023-01-08 02:49:56 +01:00
Philipp
5ea50a9e81 Fix "null" addon list 2023-01-08 02:49:56 +01:00
Philipp
2293ff6206 Add test for Addon failures 2023-01-08 02:49:56 +01:00
Philipp
0429a4e429 Fix loading empty node.config.php 2023-01-08 02:49:56 +01:00
Philipp
6aaf1ea5d4 Fix addons problem more elegant 2023-01-07 20:49:29 +01:00
Philipp
9fb5b95b5e Fix other foreach() troubles at Addon.php 2023-01-07 19:54:59 +01:00
Philipp
6454c1dee7 Don't ksort() on null 2023-01-07 19:52:43 +01:00
Philipp
6bd1740a94 omg .. wrong assertion .. 2023-01-07 15:49:55 +01:00
Philipp
6e4e2c4a82 Fix warning text 2023-01-07 15:30:45 +01:00
Philipp
6e0d16f22b Add warning message in case node.config.php isn't writable 2023-01-07 15:16:55 +01:00
Philipp
80e8f4aa34 Execute critical worker tasks, even if we're in daemon mode 2023-01-07 13:43:16 +01:00
Philipp
5b2e02889e Fix Update::run() 2023-01-06 17:50:56 +01:00
Philipp
baf3225916 Apply Update::check() suggestions 2023-01-06 12:50:14 +01:00
Philipp
c35fd68ec2 Adapt doc 2023-01-06 12:47:00 +01:00
Philipp
beb3d376b2 Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:46:06 +01:00
Philipp
05048d4abf Update src/Core/Config/ValueObject/Cache.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:43:04 +01:00
Philipp
70704ccb19 Update src/Core/Update.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:42:56 +01:00
Philipp
9462bfa763 Update src/Core/Config/Util/ConfigFileManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:42:43 +01:00
Philipp
b3772163d8 Add doc 2023-01-06 03:06:11 +01:00
Philipp
ce8c820221 add description 2023-01-06 02:54:34 +01:00
Philipp
d53cb31869 Update src/Core/Config/Util/ConfigFileManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 02:16:35 +01:00
Philipp
e14050491a Config fixing
- unlock/close the `node.config.php` in every circumstances
2023-01-06 01:10:57 +01:00
Philipp
5aa8e8adf1 Config fixings
- Delete now really overwrites static default/setting.config.php keys
- Delete now really overwrites static default/setting.config.php categories
- The Update::check() routine is added to different places
- Merge the given config file with the new config before writing
- Remove ConfigTransaction::get() because it's no more reliable
2023-01-06 01:03:00 +01:00
Philipp
cdd57275eb Some improvements
- Move $_SERVER into ConfigFileManager constructor
- Rename "creatConfigFileLoader" to "createConfigFileManager"
- Rename variable "loader" to "manager" in all tests
2023-01-06 01:03:00 +01:00
Philipp
b4096251ba Check 'config' table as fallback for migrations 2023-01-06 01:03:00 +01:00
Philipp
4b17d6f3bf Update src/Core/Addon.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-04 23:12:41 +01:00
Philipp
01403d15c4 sort addon array 2023-01-04 21:55:51 +01:00
Philipp
13b234d279 Use addons config entries instead of the addon table 2023-01-04 21:55:51 +01:00
Philipp
dce86be58e Just commit config transactions if something changed 2023-01-04 19:55:22 +01:00
Philipp
aabe39220d Make flock writing easier 2023-01-04 08:16:40 +01:00
Philipp
c057954896 Make BaseURL check/save transactional and make the whole process easier 2023-01-04 08:14:00 +01:00
Philipp
17105cf7d1 Fix config read/write locking 2023-01-04 00:25:18 +01:00
Philipp
176af67e88 Fix empty fetchResult curResult at Link::fetchMimeType (thx to Marco R.) 2023-01-03 21:06:16 +01:00
Philipp
beff759c82 Update src/Core/Config/Model/ConfigTransaction.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-03 17:39:32 +01:00
Philipp
a46cd2fb36 Remove get() from config transaction interface 2023-01-03 17:26:48 +01:00
Philipp
b439df892a Apply suggestions 2023-01-03 17:24:05 +01:00
Philipp
dd88d193b9 Escape single quotes and backslashes 2023-01-03 15:36:36 +01:00
Philipp
65d79d4c93 Introduce ISetConfigValuesTransactional for transactional config behaviour 2023-01-03 14:22:07 +01:00
Philipp
ae1533e312 Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-03 14:22:06 +01:00
Philipp
88b3effc18 Use toConfigValue in case of serialized, legacy data 2023-01-03 14:22:05 +01:00
Philipp
1e574d5383 Refactor IManageConfigValues interface 2023-01-03 14:22:04 +01:00