Commit Graph

9764 Commits

Author SHA1 Message Date
Philipp 9cec38f916 Make HTTPInputData dynamic
- Removing DI:: dependency inside App class
- Making testability easier & adapting tests
2021-11-30 01:07:59 -05:00
Philipp 2e4d654c0a Make $_REQUEST processing independent of sub-calls
- Move HTTPInputData::process() into App::runFrontend()
- Pass $_REQUEST (including processed Input) to every Module method
- Delete $_POST parameters at Module post() calls because of $_REQUEST
2021-11-30 01:07:58 -05:00
Philipp f580d8e5c0 extract "BaseApi::checkDefaults()" method for later usage 2021-11-30 01:07:57 -05:00
Michael 7dd757b7f9 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-30 05:48:03 +00:00
Michael 56824598ff Standards 2021-11-30 05:20:01 +00:00
Michael Vogel 3ff59cfdc3
Merge pull request #11045 from MrPetovan/bug/11029-contact-group
Use user-specific id to fetch the list of group appartenance in Module\Contact\Profile
2021-11-30 06:17:56 +01:00
Michael 2470482b4e Standards 2021-11-30 05:07:03 +00:00
Michael 33c8872c65 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-30 05:00:46 +00:00
Michael e7e74819a3 Fix posting pictures 2021-11-29 18:03:34 +00:00
Hypolite Petovan 2ba3b7f771
Merge pull request #11037 from MrPetovan/bug/11023-api-photo-delete
Fix Api\Friendica\Photo|album\Delete endpoints
2021-11-29 08:44:33 -05:00
Michael 6bd9c9f496 Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-29 12:52:00 +00:00
Hypolite Petovan cd63533e2c Fix remaining references to BaseModule->parameters 2021-11-29 07:24:32 -05:00
Hypolite Petovan c2df5d66d7 Use user-specific id to fetch the list of group appartenance in Module\Contact\Profile 2021-11-29 07:06:41 -05:00
Hypolite Petovan c7a40906bf Fix Photoalbum delete endpoint
- Fix condition on a removed Item field
2021-11-29 06:29:38 -05:00
Hypolite Petovan e2016bc67d Fix Photo delete endpoint
- Set the request variable type
- Fix the condition on a nonexistant item field
2021-11-29 06:29:38 -05:00
Michael 477b8a91db Added endpoint 2021-11-29 06:09:28 +00:00
Michael 0440765849 Set item permissions on reshare 2021-11-29 04:38:58 +00:00
Michael 71f7679204 Fix function name 2021-11-28 21:40:38 +00:00
Michael cf999e681c Standards 2021-11-28 13:58:26 +00:00
Michael 367479e50e Standards 2021-11-28 13:52:39 +00:00
Michael 19019381e6 Fixes standards 2021-11-28 13:46:30 +00:00
Michael 61f1a4d14d Merge remote-tracking branch 'upstream/2021.12-rc' into api-fixes 2021-11-28 13:44:02 +00:00
Michael 222b35684d API: Added more functions, fixed function names 2021-11-28 13:34:00 +00:00
Philipp d576bb136b
Fix BaseApi and corresponding tests 2021-11-28 13:11:12 +01:00
Philipp 4cc36c9b2c
Fix BBCode::expandTags() & Remove AppMockTrait 2021-11-28 13:07:38 +01:00
Michael e381ca6ba0 Added group update 2021-11-27 22:25:40 -05:00
Michael b15d3a2523 API: Next bunch of functions transformed 2021-11-27 22:25:36 -05:00
Hypolite Petovan 9cc675233d Add a second parameter to BaseApi::getRequest to enable API tests 2021-11-27 18:38:09 -05:00
Philipp 056702c1e0
Fixing wrong inherited methodsyntax 2021-11-27 19:58:24 +01:00
Philipp e8ee312d80
Fix Tos Module 2021-11-27 14:11:48 +01:00
Philipp 77b092b4b9
Respect the Dollar(notation :-)) 2021-11-27 13:57:36 +01:00
Philipp 9207b9e408
Fixing https://github.com/friendica/friendica/issues/11033 2021-11-27 13:48:05 +01:00
Philipp 7cba74bb6c
Fix that (raw)content is always executed during Module::run() 2021-11-27 13:41:37 +01:00
Philipp f245fdaa5d
Fix Contact modules 2021-11-27 13:19:26 +01:00
Philipp e4000155f3
Fix Page Header usage 2021-11-27 12:40:58 +01:00
Philipp 6a9fff5100
Fixing Response 2021-11-27 12:40:57 +01:00
Philipp ae24bf8d54
Fixing Response 2021-11-27 12:40:57 +01:00
Philipp 7cd85873ee
Replace IRespondToRequests with PSR-7 ResponseInterface 2021-11-27 12:40:57 +01:00
Philipp 3b2946f98f
Replace header() with $response->setHeader() at BaseModule 2021-11-27 12:40:56 +01:00
Philipp 78c45bd142
Add NodeInfo Module test as an example 2021-11-27 12:40:56 +01:00
Philipp 537b74f307
Inherit ApiResponse from Response 2021-11-27 12:40:54 +01:00
Philipp 561aba18e3
Introduce Response for Modules to create a testable way for module responses 2021-11-27 12:40:38 +01:00
Philipp ad5b0762b0
Fix LegacyModule content return 2021-11-27 12:40:37 +01:00
Philipp 8bdd90066f
Make BaseModule a real entity
- Add all dependencies, necessary to run the content (baseUrl, Arguments)
- Encapsulate all POST/GET/DELETE/PATCH/PUT methods as protected methods inside the BaseModule
- Return Module content ONLY per `BaseModule::run()` (including the Hook logic there as well)
2021-11-27 12:40:36 +01:00
Philipp 238613fd01
Add feedback :) 2021-11-27 12:39:46 +01:00
Philipp b5d2d32b44
Split and delete ModuleController
- $moduleName is part of the argument string => App\Arguments
- $isBackend boolean already part of App\Mode::isBackend()
- $module is now the direct return of App\Router::getModule()
- ModuleController::run() moved to BaseModule::run()
2021-11-27 12:39:45 +01:00
Philipp a5ab184fb8
Merge pull request #11025 from MrPetovan/task/11022-improve-connector-hooks
Improve connector hooks
2021-11-27 12:37:47 +01:00
Philipp e852623c4f
Merge pull request #11030 from MrPetovan/bug/11029-add-remove-group
Add backward compatibility with user contacts in Module\Group
2021-11-27 12:37:18 +01:00
Michael a3e3d87a42 Standards 2021-11-26 21:57:18 +00:00
Michael d128b723c0 Code standards 2021-11-26 21:54:25 +00:00
Michael 0de9ae913b API: moved several lists 2021-11-26 21:48:13 +00:00
Hypolite Petovan 1c5aef0685 Escape dollar sign in replace string to prevent placeholder replacement in Model\Item::addShareDataFromOriginal 2021-11-26 12:38:34 -05:00
Hypolite Petovan 8bfe877629 Add backward compatibility with user contacts in Module\Group 2021-11-26 09:48:37 -05:00
Hypolite Petovan a26322b4c2 Replace args call with parameter from router in Module\Group 2021-11-26 09:48:05 -05:00
Michael 0e3c8e3f5e Mixed parameter order 2021-11-26 08:16:06 +00:00
Michael da9b5f32db Unneeded "use" removed 2021-11-26 07:56:54 +00:00
Michael fb47389c69 API: Fix profile_url handling / missing constant 2021-11-26 07:55:02 +00:00
Hypolite Petovan dbcaf51923
Merge pull request #11018 from annando/api-status
API: The status is now an object
2021-11-25 20:27:15 -05:00
Michael 68316c6e85 Coding standards 2021-11-25 11:31:01 +00:00
Michael 1ff6b1cf18 Coding standards 2021-11-25 11:28:56 +00:00
Michael 9c61bd3ffc Lists and tweet search moved 2021-11-25 11:16:47 +00:00
Michael d696c8d101 Use correct uri-id for attachments 2021-11-25 10:07:25 +00:00
Michael 44555cddb8 More functions moved 2021-11-25 06:00:58 +00:00
Michael 97719ca207 Standards 2021-11-24 23:36:41 +00:00
Michael 6d1d4789f1 Standards ... 2021-11-24 23:35:01 +00:00
Michael 299d70ca1d Standards 2021-11-24 23:31:10 +00:00
Michael 556bcfe78f Some more standards 2021-11-24 23:28:06 +00:00
Michael 260ee13d07 Standards 2021-11-24 23:24:35 +00:00
Michael bd1306d020 Removed whitespace 2021-11-24 23:20:42 +00:00
Michael 242fd646d2 Formatting 2021-11-24 23:06:28 +00:00
Michael c4d52feea5 Many API calls moved 2021-11-24 23:03:34 +00:00
Michael ab28fa32aa Added last status 2021-11-24 20:47:37 +00:00
Hypolite Petovan ba26a56f3d Add missing variable argument operator in BaseModule->t
- This was causing to wrongly pass the variable arguments as an array of variable arguments to L10n->t
2021-11-24 10:57:05 -05:00
Michael 2c7c63a493 Testing tests 2021-11-24 07:29:29 +00:00
Michael dfd63493b2 Standards 2021-11-24 07:14:19 +00:00
Michael a86dee8e59 Coding standards 2021-11-24 07:08:30 +00:00
Michael 57cf384fae Moved acitivites 2021-11-24 07:06:28 +00:00
Michael a3aab4a75a Entities, Source and api functions rearranged 2021-11-24 06:44:25 +00:00
Hypolite Petovan 39c763ce2f Add item_by_link hook to allow connectors to import remote posts 2021-11-23 17:47:02 -05:00
Hypolite Petovan a47830990a Improve probe_detect hook
- Remove Twitter probe from core
- Allow hook function to better abort the probe_detect process
2021-11-23 17:46:20 -05:00
Michael 452cd57437 Fixing tests 2021-11-23 22:02:46 +00:00
Michael 38b641ca6b Coding standards 2021-11-23 21:56:34 +00:00
Michael 07c2f36946 Removing unused functions, added (deactivated) attachments 2021-11-23 21:54:19 +00:00
Michael 082aa1bf65 Code Standards 2021-11-23 15:21:06 +00:00
Michael 4373a66f74 Coding standards 2021-11-23 14:55:52 +00:00
Michael b56ccbcf2b More objects added 2021-11-23 10:12:11 +00:00
Michael Vogel 06284e6007
Merge pull request #11015 from MrPetovan/task/10979-frio-time-tooltip
Move title attribute to <time> tag
2021-11-22 12:45:29 +01:00
Michael 8211cef49d Coding standards, changed database version 2021-11-22 07:39:40 +00:00
Michael 214a0524dd Merge remote-tracking branch 'upstream/develop' into api-status 2021-11-22 07:33:25 +00:00
Michael 670bbe58a1 API: The status is now an object 2021-11-22 07:28:02 +00:00
Hypolite Petovan 23e1130264 Move title attribute to <time> tag
- Use correct machine-readable value in datetime attribute
2021-11-21 22:51:21 -05:00
Hypolite Petovan 204b077353 Move contact profile GET actions to separate module class 2021-11-21 19:22:41 -05:00
Hypolite Petovan 974b750d6d Move contact profile module to its own class 2021-11-21 19:22:39 -05:00
Hypolite Petovan 197c77f43d Move contact conversation to its own module class 2021-11-21 19:21:58 -05:00
Hypolite Petovan eacfcc69c1 Move contact posts to their own module class
- Remove duplicated check for local_user() in Module\Contact
- [frio] Fix display issue for search items where the More button and icon would show but be inactive
2021-11-21 19:21:39 -05:00
Hypolite Petovan 25455eab63 Add new Local relationship classes 2021-11-21 18:59:37 -05:00
Hypolite Petovan f7714c09e6 Fix user-contact rows not being updated in Contact\User::updateByContactUpdate
- Add new update function to regenerate potentially outdated user-contact rows
2021-11-21 18:59:37 -05:00
Hypolite Petovan 84e7f65d52 Move sending follow message to remote server to Protocol class 2021-11-21 18:59:36 -05:00
Hypolite Petovan d011f747ff Remove unused parameter $network in Model\User::getDefaultGroup 2021-11-21 18:59:36 -05:00
Michael e1d4f96b06 Remove unused user fields 2021-11-21 20:14:48 +00:00
Michael f00792d370 Merge remote-tracking branch 'upstream/develop' into api-rework 2021-11-21 17:02:51 +00:00
Michael a4ef4589e6 Reworked friendship API endpoints 2021-11-21 16:59:09 +00:00
Hypolite Petovan e9b3a9426a
Merge pull request #11012 from annando/api-relations
Fix followers/following for the Mastodon API
2021-11-21 10:14:07 -05:00
Michael 87084a3e85 Fix followers/following for the Mastodon API 2021-11-21 14:47:18 +00:00
Hypolite Petovan 23c56b108b
Merge pull request #11003 from annando/fix-api
Fix legacy API
2021-11-21 07:55:25 -05:00
Michael 0e5f876680 function moved 2021-11-21 09:55:42 +00:00
Michael 2c6afe65a7 Use correct function to fetch the self user 2021-11-21 00:26:35 +00:00
Michael ae99144f57 Tests again 2021-11-21 00:15:36 +00:00
Michael c732027b04 Tests ... 2021-11-21 00:14:38 +00:00
Michael 0f09b4f636 Fixing (some) tests 2021-11-20 23:47:03 +00:00
Michael 647ecd4bd3 Relocate RSS header stuff, cleaning up the code 2021-11-20 13:44:12 +00:00
Michael 4327ccddcb Some more removed functions and parameters 2021-11-20 09:36:17 +00:00
Hypolite Petovan 88a327ba63
Merge pull request #11004 from nupplaphil/bug/module_const
`Module::init()` Fixings
2021-11-19 18:00:05 -05:00
Hypolite Petovan 5a9ef594bf
Merge pull request #10999 from nupplaphil/bug/configcache_set
Fix Installer setup
2021-11-19 17:59:32 -05:00
Philipp efe5d641a2
Fixing Mainentance & Exception vie 2021-11-19 22:51:12 +01:00
Michael d576e920d5 Fix legacy API 2021-11-19 20:15:12 +00:00
Philipp 296a9070a0
Fix LegacyModule init() 2021-11-19 20:21:37 +01:00
Philipp 645e4edc63
Revert "Revert "Replace Module::init() with Constructors""
This reverts commit 89d6c89b67.
2021-11-19 20:18:48 +01:00
Hypolite Petovan 89d6c89b67
Revert "Replace Module::init() with Constructors" 2021-11-19 07:23:23 -05:00
Hypolite Petovan 0b6e0566d7
Merge pull request #10987 from annando/api4
API: moved classes / unified user array creation
2021-11-19 06:13:52 -05:00
Philipp 2a22ddcf85
Fix Installer setup
- value "0" can now be saved
2021-11-19 08:48:44 +01:00
Philipp dab9e13c69
Replace $this->l10n->t() with $this->t() for Modules 2021-11-18 23:23:58 +01:00
Michael 8fd738f550 Removed "api_get_user" 2021-11-18 22:20:19 +00:00
Michael 1f79d25ffc Replaced "api_date" 2021-11-18 21:43:13 +00:00
Philipp 04a0cd9301
Add feedback 2021-11-18 21:25:09 +01:00
Philipp 14988ddf19
Replaced DI:: calls at BaseNotifications.phpt 2021-11-18 21:23:43 +01:00
Michael b67c10812a Merge remote-tracking branch 'upstream/develop' into api4 2021-11-18 20:15:57 +00:00
Michael 7c03eba98e Removed unused code 2021-11-18 14:49:12 +00:00
Michael 3dd35ef6ec Possibly fixing the test 2021-11-18 08:03:50 +00:00
Michael 42bd7918ad allow_api removed 2021-11-18 07:14:23 +00:00
Michael 3c0f22b2dd Testing tests 2021-11-17 22:50:43 +00:00
Michael abbe7895ae Fixing tests - maybe 2021-11-17 22:12:21 +00:00
Michael cdedf348e4 Replaced most "api_get_user" calls with newer BaseApi calls 2021-11-17 21:28:51 +00:00
Philipp ce578a7745
Replace Module::init() with Constructors 2021-11-17 22:14:33 +01:00
Philipp de6bb280b1
Hotfix: Deleted content 2021-11-17 13:39:48 +01:00
Hypolite Petovan 190efcefad
Merge pull request #10977 from nupplaphil/feat/dynamic_modules
Introduce interface for `Module`s
2021-11-17 06:36:54 -05:00
Philipp e73eda0156
Add feedback 2021-11-17 08:16:33 +01:00
Michael a9e1847afd Some more comments added 2021-11-17 06:36:12 +00:00
Michael eaf4bc6d4f Added contact 2021-11-17 06:28:39 +00:00
Philipp 804408e4bb
Update src/App/ModuleController.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-17 06:57:48 +01:00
Philipp 61a507000f
Update src/App/ModuleController.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-17 06:57:37 +01:00
Michael 2bb1805a67 Added profile picture 2021-11-16 23:57:12 +00:00
Michael 6ea426178a API: moved classes / unified user array creation 2021-11-16 23:21:40 +00:00
Philipp 766b3f0d01
Fixups 2021-11-16 22:40:39 +01:00
Philipp 90cde9898b
Update src/Capabilities/ICanHandleRequests.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-16 22:40:39 +01:00
Philipp c95d47b0b4
Refactor App\Module to App\ModuleController and rename properties 2021-11-16 22:40:39 +01:00
Philipp 8f741c8b78
Remove afterpost() handling 2021-11-16 22:40:38 +01:00
Philipp 85304b6e8f
Update src/App/Page.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-16 21:12:12 +01:00
Philipp 2f4e19a82f
Update src/App/Module.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-16 21:11:47 +01:00
Hypolite Petovan 877b90f7f0
Merge pull request #10986 from annando/issue-10983
Issue 10983: Use the user's settings for the help language
2021-11-16 06:57:33 -05:00
Michael 59787d718d Remove spaces 2021-11-16 07:04:39 +00:00
Michael Vogel ba031e4534
Update src/Module/Help.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-16 07:36:20 +01:00
Michael 84e62b5293 Issue 10983: Use the user's settings for the help language 2021-11-15 22:08:51 +00:00
Philipp cca1be21a3
Fixed static leftovers from #10975 2021-11-14 23:49:07 +01:00
Philipp 5879535822
Switch static::$parameters to $this->parameters 2021-11-14 23:49:07 +01:00
Philipp 489cd0884a
Make BaseModule methods dynamic 2021-11-14 23:49:06 +01:00
Philipp 714f0febc4
Replace $parameters argument per method with static::$parameters 2021-11-14 23:49:05 +01:00
Philipp 018275919c
Create interface for static Module calls 2021-11-14 23:30:04 +01:00
Philipp 2edb631b1f
Fix PHP-CS 2021-11-14 23:21:57 +01:00
Michael 66db55f0cd
Some more API functions moved 2021-11-14 23:21:54 +01:00
Philipp e7f84d4934
Move Api\unsupported tests and remove dependency to System::jsonExit() 2021-11-12 22:44:59 +01:00
Philipp 7797c3a0a8
Migrate API\error tests and fix ApiResponse for RSS/atom 2021-11-12 22:29:58 +01:00
Philipp 2c407a7323
Small improvement 2021-11-12 21:38:38 +01:00
Philipp 6725f05ab2
Moved API\Notification tests 2021-11-12 21:35:21 +01:00
Philipp e477cf215d
Make API testable & move PhotoAlbum tests to new destination 2021-11-12 21:08:36 +01:00
Philipp a0c5c91886
Simplify code 2021-11-12 20:13:04 +01:00
Philipp a9ddd6687b
Replace Logger:: with logger property 2021-11-12 20:08:30 +01:00
Philipp 5bfcc8b91c
Transform ApiResponse::unspported() into dynamic method 2021-11-12 20:07:05 +01:00
Philipp ebf56674f1
Transform ApiResponse::error() into dynamic method 2021-11-12 20:04:47 +01:00
Philipp ea0f41ecf0
Transform ApiResponse::exit() into dynamic method 2021-11-12 20:03:27 +01:00
Philipp 4309f814e0
Transform ApiResponse::formatData() into dynamic method 2021-11-12 19:59:16 +01:00
Philipp f28e64299e
Transform ApiResponse::createXML() into dynamic method 2021-11-12 19:56:37 +01:00
Philipp 319f91301d
Move API Response methods into an own class to make them mockable 2021-11-12 19:52:01 +01:00
Michael Vogel 4587cef677
Update src/Module/Api/Friendica/DirectMessages/Setseen.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-11 18:46:04 +01:00
Michael 293775ab4a Photo delete is moved as well 2021-11-10 23:31:42 +00:00
Michael 02210f285b API: some more converted functions 2021-11-10 23:07:46 +00:00
Michael 17fafd37dd Removed spaces 2021-11-10 07:38:48 +00:00
Michael 1518ad33ad API: Classes moved to the correct places according to their origin 2021-11-10 07:31:39 +00:00
Michael Vogel 58ffded0c8
Update src/Module/BaseApi.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-10 04:44:59 +01:00
Michael 1c84928727 Fix test 2021-11-09 23:04:07 +00:00
Michael bbc4fe851b "init" removed, moved error function 2021-11-09 22:59:58 +00:00
Michael 28a28517e5 Fix code standards 2021-11-09 21:50:56 +00:00
Michael b6943aff36 API call rate_limit_status moved 2021-11-09 21:41:37 +00:00
Michael a6db8df92d Using the "extension" parameter 2021-11-09 19:40:39 +00:00
Michael fb6c3e2912 Simplify the output of api results 2021-11-09 06:42:59 +00:00
Michael Vogel 83056df565
Update src/Util/Arrays.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-09 06:23:04 +01:00
Michael a66bb09b40 Moved function to Arrays.php 2021-11-08 22:10:07 +00:00
Michael ac1b8b7b3a Remove space 2021-11-08 21:54:55 +00:00
Michael 3e676f9cf0 Fixed tabs 2021-11-08 21:53:34 +00:00
Michael f5b47fccce API: spme Functionality is transferred to new places 2021-11-08 21:35:41 +00:00
Michael 789361de5f The API is now using the router 2021-11-08 07:23:18 +00:00
Hypolite Petovan 8d550ad4e8
Merge pull request #10961 from annando/deprecated
Removed and replaced deprecated functionalities
2021-11-07 10:53:17 -05:00
Hypolite Petovan 6730430919
Merge pull request #10957 from nupplaphil/feat/multi_node_process
Add `hostname` to `Process` entity
2021-11-07 10:01:20 -05:00
Michael eb1b2256a0 Removed and replaced deprecated functionalities 2021-11-07 14:00:47 +00:00
Philipp 882925b824
Update src/Core/Worker/Repository/Process.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-07 13:29:38 +01:00
Philipp fb908aca6d
Update src/Core/Worker/Factory/Process.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-07 13:29:33 +01:00
Michael cfac13790b "escapeTags" is finally removed 2021-11-07 09:18:25 +00:00
Michael 359dad4244 Some more "escapeTags" removed 2021-11-06 20:25:21 +00:00
Philipp c7be395e6a
use static table-variable 2021-11-06 20:33:02 +01:00
Philipp 5350e0852d
Add hostname to Process entity 2021-11-06 20:21:01 +01:00
Hypolite Petovan 41062eb7e4 Add new purge contacts option to admin server blocklist
- Move adding a server domain pattern to the blocklist in a separate module to allow reviewing the list of known servers that would be affected
2021-11-06 01:36:53 -04:00
Hypolite Petovan 068c567b3d Move server block list HTML escaping to templating 2021-11-06 01:34:16 -04:00
Hypolite Petovan edcfeaf66d
Merge pull request #10956 from annando/escapetags
Some removed escapeTags calls
2021-11-06 00:04:17 -04:00
Philipp ccc4e5e40c
Fixed MovedPermanently exception name 2021-11-05 21:13:27 +01:00
Philipp 9a5e6642b6
Add Unique-Id for each worker execution 2021-11-05 21:07:14 +01:00
Michael 23b10cf2ae Some removed escapeTags calls 2021-11-05 19:59:18 +00:00
Philipp da86581bf2
Deactivating isMinMemoryReached() 2021-11-05 20:52:45 +01:00
Philipp 62bacbb833
Remove 'maxloadavg_frontend' restriction in Friendica 2021-11-05 20:52:43 +01:00
Philipp c2b5eb2838
Improve repository usage 2021-11-05 20:52:34 +01:00
Philipp 7c6554451e
Update src/Core/System.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-05 20:52:33 +01:00
Philipp 63960bca05
Update src/Core/Worker.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-05 20:52:33 +01:00
Philipp 807c95b314
Update src/Core/System.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-05 20:52:32 +01:00
Philipp 388f9d5a5b
Update src/App.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-11-05 20:52:32 +01:00
Philipp a7487ee50d
Fix PID at forking 2021-11-05 20:52:31 +01:00
Philipp 32f0c3fb9c
Adds DI::flushLogger() to renew Logger instances 2021-11-05 20:52:31 +01:00
Philipp 7637ae1dcc
Fixup command argument 2021-11-05 20:52:31 +01:00
Philipp 38f70cc55a
Refactor Process for new paradigm 2021-11-05 20:52:28 +01:00
Michael 99a93a422b todo removed 2021-11-04 23:01:41 +00:00
Michael 63da4a75e9 The boot.php had been cleared of most functions 2021-11-04 20:29:59 +00:00
Tobias Diekershoff 13997c8c10
Merge pull request #10951 from friendica/logs
Replaced deprecated "log" function call
2021-11-04 07:52:46 +01:00
Michael 24ee87224f Replaced deprecated "log" function call 2021-11-03 23:19:24 +00:00
Hypolite Petovan d30955aa14 Move contact deleted check from RemoveContent to Remove task 2021-11-03 16:02:20 -04:00
Michael 1219a4d00e Issue 10947: Send correct accept-header for AP 2021-11-03 19:06:07 +00:00
Michael 2785e4dab8 Merge remote-tracking branch 'upstream/develop' into logger-json 2021-11-02 19:35:11 +00:00
Hypolite Petovan af8114af37
Merge pull request #10949 from annando/photo-octet
Accept photo fetching for octet-stream as well
2021-11-02 10:31:43 -04:00
Michael 1f7a3fb698 Accept photo fetching for octet-stream as well 2021-11-02 08:10:12 +00:00
Michael d56fc6d18f Improve the JSON output of the log entries 2021-11-02 08:06:55 +00:00
Hypolite Petovan 4a0127bcee
Merge pull request #10942 from annando/error-handling
Improved http error handling
2021-11-02 03:22:20 -04:00
Michael c3964a8735 Using internal redirect in case of missing scheme 2021-11-01 21:21:03 +00:00
Philipp fc233fd5e1
Replace REGEXP with LOCATE for allow_cid and deny_cid 2021-10-31 19:53:38 +01:00
Philipp 49c16a9dad
Fix HTTP Code 2021-10-31 15:14:57 +01:00
Philipp 130f97717d
Add tests & remove unused method 2021-10-31 13:58:52 +01:00
Philipp 71cdbcfc24
Add default value for "user_contact_str" (fixes https://github.com/friendica/friendica/issues/10943 ) 2021-10-31 13:50:02 +01:00
Philipp a38abd3363
AAdd domain specific Exceptions for PermissionSet 2021-10-31 13:50:01 +01:00
Michael 516018861e Merge remote-tracking branch 'upstream/develop' into error-handling 2021-10-31 05:25:39 +00:00
Michael 57353eb9b0 Changed scope 2021-10-31 04:54:24 +00:00
Michael ec5bd9a756 Reverting some parts because wouldn't work 2021-10-30 09:13:06 +00:00
Michael 4236a9a105 Improved http error handling 2021-10-29 23:21:07 +00:00
Philipp 22663c4ae5
Move Introspection to Logger package 2021-10-29 12:37:22 +02:00
Philipp f4ea74447e
Add Feedback :-) 2021-10-29 11:37:09 +02:00
Philipp 409d909d0f
Restructure HTTPClient for new paradigm 2021-10-28 20:01:03 +02:00
Philipp fa55928ea3
Replace own VoidLogger with PSR-Standard NullLogger() 2021-10-28 20:01:03 +02:00
Philipp 184f6cc255
Restructure Logger to new paradigm 2021-10-28 20:01:02 +02:00
Philipp d778af0b0e
Cleanup namespaces 2021-10-27 20:16:34 +02:00
Philipp 7c38647573
Cleanup namespace 2021-10-27 20:06:04 +02:00
Philipp 2ab0d06996
Restructure Storage to new paradigm 2021-10-27 20:00:19 +02:00
Hypolite Petovan 24f8ee8e67
Merge pull request #10918 from nupplaphil/feat/core_new_paradigm
Paradigm Restructuring Part 1 - Core classes
2021-10-27 13:45:40 -04:00
Tobias Diekershoff 2a0d3da070 fix link to media tab in navigation
In #10904 the wrong link was set, this PR should fix it and really point towards the media tab of the profiles.
2021-10-27 15:09:37 +02:00
Philipp 58eea1adaa
Cleanup namespaces 2021-10-26 22:11:10 +02:00
Philipp b216317477
Refactoring Core class structures ... 2021-10-26 22:11:09 +02:00
Philipp 57b4c008cb
Restructure Session to follow new paradigm 2021-10-26 22:11:07 +02:00
Philipp ff1a812e1a
Restructure Lock to follow new paradigm 2021-10-26 22:11:06 +02:00
Philipp ab83d0dd27
Restructure (P)Config to follow new paradigm 2021-10-26 22:11:06 +02:00
Philipp 68046573a4
Restructure Cache to follow new paradigm 2021-10-26 22:11:06 +02:00
Michael b2165cdf22 Speed up query for unused contacts 2021-10-26 20:06:18 +00:00
Hypolite Petovan 02e08d5fbc Use router parameters in Diaspora\Receive 2021-10-26 14:56:47 -04:00
Hypolite Petovan 8af86af3d9 Add new developer test console command 2021-10-26 11:42:22 -04:00
Michael a0c1c3f661 Fix notice "Array to string conversion" 2021-10-25 20:54:36 +00:00
Michael Vogel 81c9d8d479
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-25 21:27:21 +02:00
Michael 87673fd0c5 Merge remote-tracking branch 'upstream/develop' into logging 2021-10-25 18:56:29 +00:00
Michael Vogel 5dc283ba8d
Merge pull request #10917 from MrPetovan/bug/10914-event-feed-time
Add event timezone in Model\Event::getHTML
2021-10-25 06:33:20 +02:00
Hypolite Petovan d1417d74bc Add timezone to event dates format in Model\Event::getHTML
- Adds timezone information for user-less contexts like syndication feeds
2021-10-24 23:17:55 -04:00
Hypolite Petovan 40aaa51050 Skip session authentication for backend modules
- This was causing errors accessing these modules with an existing session with 2fa enabled while anonymous calls were going through
2021-10-24 23:17:55 -04:00
Hypolite Petovan c4fdc7466d Test item psid against PermissionSet::PUBLIC constant instead in ActivityPub\Objects
- Address https://github.com/friendica/friendica/issues/10755#issuecomment-950393419
2021-10-24 23:00:40 -04:00
Hypolite Petovan bcd3cf0bc0
Merge pull request #10923 from nupplaphil/feat/error_handling
Add extended ErrorHandling
2021-10-24 22:41:38 -04:00
Philipp 8f688b2a89
Update ErrorHandler 2021-10-24 19:44:38 +02:00
Michael 7fd202dbc9 Handle invalid avatar pictures 2021-10-24 11:33:35 +00:00
Philipp eacb584703 Fix PHP_NOTICE because of fsuggestion 2021-10-23 21:46:32 -04:00
Philipp 01659d731f Fix FSuggestselect 2021-10-23 21:46:04 -04:00
Philipp 8c9eb9a58d Fix FSuggestselect 2021-10-23 21:45:38 -04:00
Philipp 0d517b590d fetch new FSuggest after update 2021-10-23 21:45:38 -04:00
Philipp 92c7b99a4f Update src/Contact/FriendSuggest/Exception/FriendSuggestPersistenceException.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-23 21:45:38 -04:00
Philipp 74cfb32085 Update src/Contact/FriendSuggest/Exception/FriendSuggestNotFoundException.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-23 21:45:38 -04:00
Philipp 6623780cf8 Fix FSuggest conversation 2021-10-23 21:45:37 -04:00
Philipp 61839d503a Fix "Suggest a friend" text 2021-10-23 21:45:37 -04:00
Philipp 4a386b2f36 Add some missing Copyright header 2021-10-23 21:45:36 -04:00
Philipp 5d92713a8e Rename Depository to Repository 2021-10-23 21:45:36 -04:00
Philipp b407fbedc1 Replace all 'fsuggest' usages with the new paradigm 2021-10-23 21:45:35 -04:00
Philipp 82a6c78033 Move FSuggest to depository 2021-10-23 21:45:35 -04:00
Philipp acb06af28d
Add extended ErrorHandling 2021-10-23 20:58:38 +02:00
Michael 7ebf211ad2 Fixed indention 2021-10-23 17:23:11 +00:00
Michael 8185c591d8 New option to activate/deactivate contact avatar cache 2021-10-23 17:18:30 +00:00
Michael a497bd3a3d Merge remote-tracking branch 'upstream/develop' into logging 2021-10-22 06:06:39 +00:00
Philipp e0411743e2
Merge pull request #10913 from MrPetovan/bug/10903-profile-edit
Add redirection to clear the owner cache after profile update
2021-10-22 07:12:43 +02:00
Hypolite Petovan cb86048b8a Add redirection to clear the owner cache after profile update 2021-10-21 19:11:28 -04:00
Hypolite Petovan 82c2a30c59 Fix wrong array access to Entity object
- Address https://github.com/friendica/friendica/issues/10756#issuecomment-949051839
2021-10-21 18:58:18 -04:00
Hypolite Petovan 096dacf0fd Manually expand ACLs coming from non-permissionset tables
- Return early if parameter is empty in ACLFormatter->expand
- Address https://github.com/friendica/friendica/issues/10756#issuecomment-949049195
2021-10-21 18:56:43 -04:00
Michael 17aa00bff8 Fix: Use correct condition to update the avatar 2021-10-21 17:19:41 -04:00
Philipp 1cb76d23ff
Delete the intro after confirming it ;-) 2021-10-21 22:18:32 +02:00
Philipp e1574dc2e7
Fix foreign key violation for Notify insert with uri_id/parent_uri_id 0 instead NULL 2021-10-21 22:11:15 +02:00
Philipp bf7c66b2c7
Fix Model\Contact\Introduction::confirm() 2021-10-21 21:57:25 +02:00
Philipp f5786a8f4f
set intro::duplex deprecated because of no usage 2021-10-21 21:57:24 +02:00
Philipp d67b676ce5
Fix confirm parameter 2021-10-21 21:57:24 +02:00
Philipp 3153e098b0
Remove deprecated, impossible code for discarding with FID 2021-10-21 21:57:24 +02:00
Philipp 44627a0b12
fix intro.cid and intro.suggest-id 2021-10-21 21:57:23 +02:00
Philipp 690369cc4b
Fixings & add tests 2021-10-21 21:56:46 +02:00
Philipp ed184bd592
Set intro.blocked to deprecated 2021-10-21 21:56:46 +02:00
Philipp bf0782dc6b
Rename setIgnore() to ignore() 2021-10-21 21:49:22 +02:00
Philipp d2c210753a
Remove logging leftover for debugging 2021-10-21 21:49:21 +02:00
Philipp 7d7d310cc4
Replace almost every Introduction places 2021-10-21 21:49:21 +02:00
Philipp a40f503fdd
Move Introduction to new depository paradigm 2021-10-21 21:49:20 +02:00
Hypolite Petovan 0cf4a74dfe
Merge pull request #10907 from annando/notice
Avoid notice "Undefined property: Friendica\Util\Logger\StreamLogger::$DEBUG"
2021-10-20 16:06:04 -04:00
Michael f6faae5bb1 Replace deprecated log calls 2021-10-20 18:53:52 +00:00
Michael e041b969fc Avoid notice "Undefined property: Friendica\Util\Logger\StreamLogger::$DEBUG" 2021-10-20 17:50:16 +00:00
Tobias Diekershoff bc65f10190 replace the video entry in the Nav.php with media as well 2021-10-20 15:11:30 +02:00
Hypolite Petovan 353cd66b26
Merge pull request #10900 from annando/notify
`enotify.php` is removed and its functions were transferred
2021-10-19 22:22:41 -04:00
Philipp 7e433c66c1
RemoveContent fix column name 2021-10-19 23:34:36 +02:00
Michael Vogel e2d2f42802
Merge pull request #10901 from nupplaphil/bug/notify_post
Fix DB errors
2021-10-19 22:43:11 +02:00
Philipp 88825c2520
Split contact-relation deletion 2021-10-19 22:35:57 +02:00
Philipp b838b594cd
contact-relation - Fix DB error 2021-10-19 22:24:14 +02:00
Michael 2f1f6f6fb2 Replace "notification" call with new function, removing enotify.php 2021-10-19 19:45:36 +00:00
Michael 3781b34272 PROFILE_PHOTOS is mostly removed and replaced 2021-10-19 19:15:28 +00:00
Michael 4422be9cea Removing functionality from enotify.php 2021-10-19 19:09:53 +00:00
Michael b152fde9d1 Don't degrade an existing relationship when following again 2021-10-19 02:05:04 +00:00
Philipp bf224b58f8
Move to PermissionSet::isPublic() 2021-10-18 23:32:47 +02:00
Philipp 64a336ee8d
Rename method again 2021-10-18 23:32:46 +02:00
Philipp b5d994394e
Fixing PUBLIC usage, Fixing DB-View, Creating tests 2021-10-18 23:32:45 +02:00
Philipp a07acac463
Fix PHP-CS 2021-10-18 23:32:45 +02:00
Philipp 5fecc9ecf7
Adapt ProfileField & Fix current PermissionSet Usage at ProfileFields 2021-10-18 23:32:44 +02:00
Philipp 7c0c102f9f
Add tests 2021-10-18 23:32:42 +02:00
Philipp f273c27e3b
Fixups 2021-10-18 23:32:42 +02:00
Philipp 7061e16b27
Add copyright 2021-10-18 23:32:41 +02:00
Philipp 838cdac5d1
Move ProfileFieldRepository::migrateFromLegacyProfile() & delete old repository 2021-10-18 23:32:41 +02:00
Philipp f403851946
Move ProfileFieldRepository::updateCollectionFromForm() 2021-10-18 23:32:40 +02:00
Philipp 6f692b857b
Move ProfileField::selectByContactId() and ProfileField::selectByUserId() 2021-10-18 23:32:39 +02:00
Philipp a9981c792e
Use ProfileField::selectPublicFieldsByUserId 2021-10-18 23:32:39 +02:00
Philipp 1c0f92c382
Move ProfileField from Model to Entity 2021-10-18 23:32:38 +02:00
Hypolite Petovan 39a927f213
Merge pull request #10891 from nupplaphil/bug/httpclientfactory_dbstructure
Fix possible missing dbstructure.config.php in HTTPClientFactory.php
2021-10-18 16:34:22 -04:00
Michael Vogel df99ca8d82
Merge pull request #10888 from MrPetovan/task/10887-bbcode-style-block
Add conditional block output for BBCode tag [style]
2021-10-18 20:19:53 +02:00
Philipp 493b428991
require_once dbstructure.config.php for HTTPClientFactory.php in case we didn't load the DB 2021-10-18 19:36:56 +02:00
Michael Vogel 1dc613a0a1
Merge pull request #10889 from MrPetovan/task/10886-bbcode-remove-class
Deprecate limited-use and potentially confusing [class] BBCode tag
2021-10-18 19:28:07 +02:00
Hypolite Petovan 6f290607de
Merge pull request #10890 from xundeenergie/improve-links
Improve links
2021-10-18 09:08:48 -04:00
Hypolite Petovan 39aff642aa Deprecate limited-use and potentially confusing [class] BBCode tag
- Replace its usage in Mastodon emoji with an internal tag [emoji]
2021-10-18 02:45:42 -04:00
Jakobus Schürz (admin) 4aaa5a6a46 open provider-url in new tab 2021-10-18 08:41:45 +02:00
Jakobus Schürz (admin) c450a7a757 open link from picture in new tab 2021-10-18 08:39:01 +02:00
Hypolite Petovan 4bee4818cf Add conditional block output for BBCode tag [style]
- Move new line conversion to <br> tags
- Update BBCode help page
2021-10-17 21:27:05 -04:00
Philipp 5d0b7fd87b
Merge pull request #10882 from MrPetovan/task/10865-contact-purge
Add new purge contact content option to admin contact blocklist
2021-10-17 23:44:28 +02:00
Michael f1d3f60499 Remove "fcontact" from suggestions 2021-10-17 20:19:02 +00:00
Michael Vogel b0bb95bb0d
Merge pull request #10880 from MrPetovan/bug/10876-profile-edit
Account for the PUBLIC value for id parameter in Depository\PermissionSet::selectOneById
2021-10-17 08:36:18 +02:00
Hypolite Petovan aea07a7c15 Add new purge contact content option to admin contact blocklist 2021-10-16 19:29:38 -04:00
Hypolite Petovan fc2175260f Move Worker task RemoveContact to Contact\Remove 2021-10-16 19:22:24 -04:00
Hypolite Petovan efe0e45170 Create new Worker task to remove a contact's content from the database 2021-10-16 19:19:56 -04:00
Hypolite Petovan f80478f262 Improve argument handling in Core\Worker::add
- The argument name made it unclear the first argument is supposed to be a priority number
2021-10-16 19:19:56 -04:00
Hypolite Petovan 45fc6759b8 Remove unused method in Model\\Contact 2021-10-16 16:05:09 -04:00
Hypolite Petovan 66c0431144 Switch available contact selection to private-supporting networks in ACL 2021-10-16 16:00:41 -04:00
Hypolite Petovan ca2c73a2cd Account for the PUBLIC value for id parameter in Depository\PermissionSet::selectOneById 2021-10-16 15:42:21 -04:00
Hypolite Petovan f9165fbaf0 Decode HTML entities in code blocks in HTML::toBBCode
- Replace PHP_EOL uses with the more common \n
2021-10-15 11:36:40 -04:00
Michael c6021a45b1 Updated messages.po, keep a translatable string 2021-10-14 06:22:47 +00:00
Michael a33185f835 Use a constant for the profile photo album 2021-10-14 04:12:00 +00:00
Hypolite Petovan f05fecaec1
Merge pull request #10867 from annando/replace-p
replace "p" with higher level database functions
2021-10-13 19:33:59 -04:00
Michael 8d7846142d Hide blocked contacts when searching public contacts 2021-10-13 21:04:46 +00:00
martincodes aa433f9d87 add condition to count accounts that arent removed 2021-10-13 18:54:22 +02:00
Michael Vogel 09771e1a76
Merge pull request #10870 from MrPetovan/bug/fatal-errors
Use entity property in DB condition in Module\Profile\Status
2021-10-13 07:19:26 +02:00
Michael 2904f4ca0e Olq query removed, checking for deleted as well 2021-10-13 05:11:36 +00:00
Hypolite Petovan f622a541c3 Use entity property in DB condition in Module\Profile\Status
- Address https://github.com/friendica/friendica/issues/10756#issuecomment-939538157
2021-10-13 00:09:14 -04:00
Hypolite Petovan 2324dac4b2 Ignore max_id when it's 0 or less in BaseDepository->_selectByBoundaries
- It can cause a conflict when both min_id and max_id = 0 as default values
2021-10-12 21:18:32 -04:00
Hypolite Petovan b3c576b9ce Fix request parameter mapping to selectByBoundaries() in Api\Mastodon\Notifications 2021-10-12 21:17:19 -04:00
Michael 27b9da3df5 replace "p" with higher level database functions 2021-10-12 05:53:29 +00:00
Hypolite Petovan 9b68364b86
Merge pull request #10863 from annando/photo-type
New photo field "photo-type" as preparation for banners
2021-10-11 13:52:28 -04:00
Michael 13827edd2c New photo field "photo-type" as preparation for banners 2021-10-11 14:21:10 +00:00
Hypolite Petovan f05faf22a1
Merge pull request #10861 from annando/no-q
Replace the legacy function "unavailableNetworks"
2021-10-11 08:17:45 -04:00
Michael 86947b0997 Replace "p" with "select" 2021-10-11 06:25:04 +00:00
Michael d3ebb3ac49 Added missing "break" 2021-10-11 05:51:18 +00:00
Michael 41dc6cea2b Replace the legacy function 2021-10-11 04:33:10 +00:00
Hypolite Petovan a3e42a8c07
Merge pull request #10857 from annando/no-q
`q` is now completely removed
2021-10-10 23:40:28 -04:00
Michael ee2b249d00 Empty comments removed 2021-10-10 05:38:49 +00:00
Michael 2c134c5229 q is now completely removed 2021-10-09 21:16:15 +00:00
Hypolite Petovan ca2d0178fc Improve po2php transformation
- Use Geekwright\Po for po file parsing to catch corner case with multi-line message
- Switch from risky double quoted strings to safer single quoted strings in the output file
2021-10-09 15:46:58 -04:00
Philipp 58215e56c3
Merge pull request #10854 from MrPetovan/bug/10844-unfollow
Replace remaining explicit network value checks by Protocol::supportsFollow calls
2021-10-09 09:23:12 +02:00
Hypolite Petovan b214470b1a Replace remaining explicit network value checks by Protocol::supportsFollow calls 2021-10-09 02:10:16 -04:00
Hypolite Petovan 5028258c3b Remove exception throwing on null protocol action result in Console\Contact 2021-10-09 02:09:49 -04:00
Hypolite Petovan 479458a389 Add missing parameters to Contact::block/unblock 2021-10-09 02:09:01 -04:00
Hypolite Petovan 880c2148c2 Fix overly strict return value for revokeFollow methods 2021-10-09 02:08:04 -04:00
Hypolite Petovan 201d728b9e Fix addon reloading
- The wrong variable was used to uninstall/install addons, which led to absolutely nothing done
2021-10-09 00:12:11 -04:00
Hypolite Petovan 80a8cd86c4
Merge pull request #10836 from nupplaphil/feat/depository_permissionset
Migrate PermissionSet to Depository paradigm
2021-10-08 09:39:39 -04:00
Philipp 93c44e6186
exception msg .. once again ;-) 2021-10-08 13:36:19 +02:00
Philipp df8bd18673
Typo 2021-10-08 12:37:53 +02:00
Michael a32c10b354 Simplifid query 2021-10-08 04:24:59 +00:00
Michael 3972fe62fe More replaced "q" calls 2021-10-08 04:10:45 +00:00
Philipp f73e4adc44
Add explicit check for PermissionSet and ProfileField 2021-10-07 20:48:39 +02:00
Philipp 03164d00e8
Add feedback and tests 2021-10-07 19:53:39 +02:00
Philipp 9e6962eac6
Make php-cs happy :-) 2021-10-07 19:53:38 +02:00
Philipp 62eb16e9ad
Migrate PermissionSet to Depository paradigm 2021-10-07 19:53:38 +02:00
Hypolite Petovan 456ae169ab Fix overly strict return value for terminateFriendship methods 2021-10-06 20:18:44 -04:00
Michael 48f482665c Issue 10841: Redirect always to the same page 2021-10-06 19:02:26 +00:00
Hypolite Petovan c0f03889c5 Pass correct hook data for support_follow and support_revoke_follow 2021-10-06 12:07:48 -04:00
Michael ab17fbf6b2 Unneeded "ProxyUtils" renamed to "Proxy" 2021-10-05 20:18:19 +00:00
Hypolite Petovan 430e6c3285
Merge pull request #10834 from annando/legacy-reshare-removed
The legacy reshare functionality is removed
2021-10-05 15:19:15 -04:00
Michael d20aa5f557 The legacy reshare functionality is removed 2021-10-05 18:58:35 +00:00
Philipp 7471b7698b
Adapt filesystem tests 2021-10-05 20:29:52 +02:00
Philipp ccd8895237
Adress feedback :) 2021-10-05 20:07:14 +02:00
Philipp 065b46c721
Split Storage usage and Storage configuration 2021-10-05 20:07:12 +02:00
Michael Vogel 0509e8f37e
Update src/Module/Photo.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-04 21:17:22 +02:00
Michael Vogel 790875d8be
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-04 21:06:13 +02:00
Michael b2c2283817 separate parameter values for different functionalities 2021-10-04 18:04:41 +00:00
Michael 9eba41598d Code review changes 2021-10-04 14:01:46 +00:00
Michael 126aa6f148 Fix tests 2021-10-04 06:26:41 +00:00
Michael 43a17b6129 Merge remote-tracking branch 'upstream/develop' into photo-guid 2021-10-04 06:21:19 +00:00
Michael Vogel c714595b70
Merge pull request #10821 from MrPetovan/bug/notices
Relax check on id parameter in /photo
2021-10-04 08:18:52 +02:00
Michael Vogel 2a8d8d402c
Merge pull request #10822 from MrPetovan/bug/fatal-errors
Trim XML before emptiness check in Protocol\Feed::import
2021-10-04 08:17:35 +02:00
Michael Vogel 6275159761
Merge pull request #10819 from MrPetovan/task/refactor-notifications
Cast object parameters to string in Database\Database
2021-10-04 08:16:58 +02:00
Michael d30dc52101 Access contact avatars by guid 2021-10-04 06:13:52 +00:00
Hypolite Petovan 297ff76590 Relax check on id parameter in /photo
- Address https://github.com/friendica/friendica/issues/10756#issuecomment-933020126
- Address https://github.com/friendica/friendica/issues/10755#issuecomment-933020316
2021-10-03 20:59:47 -04:00
Hypolite Petovan 42e77e23ac Add logging to track a Notice messages
- Part of https://github.com/friendica/friendica/issues/10755#issuecomment-933040517
2021-10-03 20:59:41 -04:00
Hypolite Petovan a4706e9521 Trim XML before emptiness check in Protocol\Feed::import
- Address https://github.com/friendica/friendica/issues/10791
2021-10-03 19:32:20 -04:00
Michael 1d86d79778 Merge remote-tracking branch 'upstream/develop' into more-q 2021-10-03 19:49:11 +00:00
Michael Vogel caa1a5aeac
Merge pull request #10818 from MrPetovan/task/10691-remove-event-adjust
Display the current timezone in date time picker fields
2021-10-03 21:46:33 +02:00
Michael b0bf4b4359 Some more "q" calls and deprecated logging replaced 2021-10-03 19:43:49 +00:00
Hypolite Petovan 24734b05fe Cast object parameters to string in Database\Database
- This makes string casting in Depository->save unnecessary
2021-10-03 15:35:47 -04:00
Hypolite Petovan c40390c202 Revert "Explicitly cast Url objects to string"
This reverts commit ee5aa2d432.
2021-10-03 15:22:40 -04:00
Michael Vogel dd3f573fec
Merge pull request #10817 from MrPetovan/task/refactor-notifications
Explicitly cast Url objects to string
2021-10-03 21:03:03 +02:00
Hypolite Petovan ee5aa2d432 Explicitly cast Url objects to string
- Some systems do not do this operation automatically and it results in empty DB fields
2021-10-03 14:53:06 -04:00
Hypolite Petovan a31a64827f Display the current timezone in date time picker fields 2021-10-03 13:42:32 -04:00
Hypolite Petovan a9bb53b021 [frio] Fix event time display 2021-10-03 13:42:32 -04:00
Hypolite Petovan 9935e8e711 Remove event.adjust field
- It was confusing and introduced complexity that wasn't worth the unclear gain
2021-10-03 13:42:32 -04:00
Hypolite Petovan 6db211568a Remove most calls to date_default_timezone_* calls
- It was wrongly used to set the node-wide ot user-specific timezone
- It is now fully managed from the App object
- Add a static variable to DateTimeFormat maintain the convenient local() method
2021-10-03 13:42:31 -04:00
Tobias Diekershoff 08c24fd4fa
Merge pull request #10816 from MrPetovan/task/refactor-notifications
Check if the string representation of Notify->link is empty in Module\Notifications\Notification
2021-10-03 17:39:14 +02:00
Hypolite Petovan e91ba2b992 Check if the string representation of Notify->link is empty in Module\Notifications\Notification
- The property is a Url object which will always return true when tested for truthy value
2021-10-03 11:34:23 -04:00
Michael 6668591afe Merge remote-tracking branch 'upstream/develop' into more-q 2021-10-03 15:06:31 +00:00
Michael 763e264196 More "q" calls have been replaced 2021-10-03 15:02:20 +00:00
Michael Vogel 3d97149007
Merge pull request #10722 from MrPetovan/task/refactor-notifications
Move notify, notifications and introduction notifications to new paradigm
2021-10-03 14:13:28 +02:00
Hypolite Petovan c84d4104e8 Add missing Module\Photo route for post-media id with no customsize 2021-10-03 07:58:52 -04:00
Hypolite Petovan 5112dd06f2 Add missing Module\Photo route for contact avatar 2021-10-03 07:48:46 -04:00
Michael 9961943b73 Code Style: Replace "AS" with "as" 2021-10-03 10:34:41 +00:00
Hypolite Petovan c1ab3801ba Replace remaining reference to Model\Photo::stripExtension 2021-10-03 05:52:53 -04:00
Michael 42790fbc1f Don't store emoji images as media but links 2021-10-03 09:42:14 +00:00
Hypolite Petovan 8cb0bb5deb Switch uid with nickname in user picture URLs
- Keep previous URL scheme fallback as remote contact avatar URLs pointing to local user avatar URLs need to update
2021-10-02 19:06:59 -04:00
Hypolite Petovan 7cdd2d1336 Refactor User::getAvatarUrlForId into getAvatarUrl
- Use user/owner array as parameter instead of uid
- Rename $profile variables to $owner when it's the result of User::getOwnerDataByNick
- Replace Module\Photo::stripExtension with native pathinfo() calls
2021-10-02 19:06:25 -04:00
Hypolite Petovan 4f42522ebc Simplify Depository\Notify->selectAllForUser parameters
- Shifts database structure knowledge from the controller to the depository where it should be
2021-10-02 18:15:45 -04:00
Hypolite Petovan 8a1a2f658c Create new DI shorthands for notification-related factories 2021-10-02 18:15:45 -04:00
Hypolite Petovan 7a2d5f6a8e Move notification to the new paradigm 2021-10-02 18:15:45 -04:00
Hypolite Petovan bc0734e0f1 Move notification introductions to the new paradigm 2021-10-02 18:15:45 -04:00
Hypolite Petovan 43e5b317ed Add new paradigm classes for notification and introduction notifications
- Add support for bounded select in BaseDepository
2021-10-02 18:15:44 -04:00
Hypolite Petovan 3e6fea30f2 Create constants for Mastodon notification types 2021-10-02 18:15:44 -04:00
Hypolite Petovan ea6f7aba40 Fix method name typos in Model\Post\UserNotification
- Reformat file, improve type-hinting
2021-10-02 18:15:43 -04:00
Hypolite Petovan dae5703e5c Improve accuracy of accepted parameter types in phpDoc of Database->fetch
- Suppresses an unwarranted type error raised by static analyzers
2021-10-02 18:15:43 -04:00
Hypolite Petovan bf81f21001 Rename Model\Post\UserNotifications type constants 2021-10-02 18:15:43 -04:00
Hypolite Petovan 47acb6a278 Move notify to the new paradigm
- Remove unused frion notify template
- Update API test
2021-10-02 18:15:42 -04:00
Hypolite Petovan 1b4e3564a5 Add new paradigm classes for notify
- Create BaseDepository class
- Create Entity, Collection, Factory and Depository classes
- Create FormattedNotification Entity, Collection and Factory to remove business logic from Notify repository
- Create new NotificationCreationIntercepted exception to allow addons to cancel notification creation
- Remove unused frio notifications/notify.tpl template
2021-10-02 18:15:34 -04:00
Hypolite Petovan 810699b454
Merge pull request #10803 from nupplaphil/feat/message_log
Forgot one Logpoint ..
2021-10-02 17:41:34 -04:00
Hypolite Petovan ce7d394ff9
Merge pull request #10801 from annando/network-thread-view
Fixing "Unknown column 'network-thread-view.uri-id'"
2021-10-02 17:40:00 -04:00
Michael Vogel 2a442952b6
Merge pull request #10800 from MrPetovan/task/10739-block
Add block and unblock hooks
2021-10-02 23:39:06 +02:00
Hypolite Petovan 66fec8944f Add block and unblock hooks 2021-10-02 17:30:40 -04:00
Hypolite Petovan bd42f5757f Implement relationship termination for Mastodon block
- This is the expected Mastodon behavior on block
2021-10-02 17:30:07 -04:00
Hypolite Petovan b0d8136b00 Remove contact record instead of setting rel = 0 in Contact::revokeFollow 2021-10-02 17:30:03 -04:00
Philipp 254c32ac91
Forgot one Logpoint .. 2021-10-02 23:27:15 +02:00
Michael Vogel fc9ac0ff46
Update src/Module/Conversation/Network.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-02 23:18:54 +02:00
Philipp 80753ed1b6
Remove disturbing/superfluous logging messages 2021-10-02 23:11:33 +02:00
Michael eea355ae3b Merge remote-tracking branch 'upstream/develop' into network-thread-view 2021-10-02 21:00:10 +00:00
Michael bd85babc3e Fixing "Unknown column 'network-thread-view.uri-id'" 2021-10-02 20:56:11 +00:00
Hypolite Petovan c4a4473cd0 Remove the obsolete parameter $two_way from terminateFriendship methods
- Follow revokation is now done independently
2021-10-02 16:14:22 -04:00
Hypolite Petovan 222333f64f Remove contact drop feature
- Feature was confusing, sometimes ineffective and overall overlapping with unfollow/block
2021-10-02 16:04:28 -04:00
Michael 1550c0cf13 Reverted unneeded changes 2021-10-02 19:33:51 +00:00
Michael afa611bd50 The media class moved 2021-10-02 19:31:27 +00:00
Michael da3fbced38 Merge branch 'contact-media' of github.com:annando/friendica into contact-media 2021-10-02 18:35:47 +00:00
Michael 2408ac8227 Merge remote-tracking branch 'upstream/develop' into contact-media 2021-10-02 18:35:43 +00:00
Michael Vogel a2f5190bdb
Update src/Model/Contact.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-10-02 20:31:30 +02:00
Hypolite Petovan 72fae04e97 Add revoke follow feature
- Add new follow revoke module
- Add new hooks: revoke_follow, support_follow, support_revoke_follow
- Add link in contact page action menu
2021-10-02 14:01:46 -04:00
Hypolite Petovan 9918fa3ec0 Move translation strings in their own array for confirm templates 2021-10-02 13:52:54 -04:00
Hypolite Petovan e6aef548fb ActivityPub: Update relation when receiving a follow reject message 2021-10-02 13:52:54 -04:00
Michael c822cdaebd Removing "blubb" 2021-10-02 17:47:11 +00:00
Tobias Diekershoff 8dc4499bcf
Merge pull request #10797 from annando/diaspora-deprecated
Replaced deprecated code from the Diaspora implementation
2021-10-02 19:19:40 +02:00
Michael e5ffda3478 Replaced deprecated code from the Diaspora implementation 2021-10-02 17:11:54 +00:00
Michael a44d200c21 Merge remote-tracking branch 'upstream/develop' into contact-media 2021-10-02 15:13:55 +00:00
Michael c3554ac0f4 "Video" is replaced by a "Media" tab in contact and profile 2021-10-02 15:09:43 +00:00
Hypolite Petovan 797391e1d8 Rework contact termination to separate protocol-level and contact-level
- Mail and Feed contacts are now removed automatically on relationship termination
- Added logging and notice messages for different results
2021-10-02 08:31:59 -04:00
Michael 865006682a Merge remote-tracking branch 'upstream/develop' into user-contact 2021-10-02 11:57:43 +00:00
Michael 1979b4775d New functionality to display media posted by a contact 2021-10-02 11:55:22 +00:00
Hypolite Petovan de2352e34d
Merge pull request #10794 from annando/q-removed
"q" call is replaced
2021-10-02 07:44:33 -04:00
Michael 666cff7d55 "q" call is replaced 2021-10-02 11:08:12 +00:00
Michael f1e2ceb32c Issue 10747: Improved check for blocked domains 2021-10-02 10:25:50 +00:00
Hypolite Petovan dae3e7d4c7
Merge pull request #10787 from fabrixxm/issue/10767
Mark string translatable in View logs
2021-10-01 11:08:11 -04:00
fabrixxm e8c0d5d445 Logs view: remove unneeded tpl var 2021-10-01 17:00:06 +02:00
fabrixxm 0638e23f7a Mark string translatable in View logs
and update messages.po
2021-10-01 16:46:55 +02:00
Tobias Diekershoff 3727be9d6c
Merge pull request #10786 from annando/sanitize-addon-author
Sanitize the addon author if it is not a valid URL but a handle
2021-10-01 15:30:30 +02:00
Michael 19d5987c9d Sanitize the addon author if it is not a valid URL but a handle 2021-10-01 13:25:00 +00:00
Tobias Diekershoff 786596fec5 remove superfluous characters from warning messages in the admin panel
\r\n was shown in the warning messages of the admin panel log view page. They have
been removed. Additionally the messages.po file has been regenerated.
2021-10-01 14:02:27 +02:00
Hypolite Petovan d9cd2f5bca
Merge pull request #10773 from annando/issue-10772
Issue 10772: Avoid duplicated links in AP posts
2021-09-28 07:03:39 -04:00
Michael 5a7bd4884a Issue 10772: Avoid duplicated links in AP posts 2021-09-27 20:26:08 +00:00
fabrixxm eadcc8dc93 Handle reading empty file in ReversedFileReader
fix #10766
2021-09-27 12:14:19 +02:00
Michael e4b8536c75 Removing MySQL workaround 2021-09-26 18:30:44 +00:00
Michael f26226229a Issue 10768: Avoid MySQL problems when upgrading both index and structure 2021-09-26 17:13:26 +00:00
Hypolite Petovan 2a88262732
Merge pull request #10760 from annando/conversation-moved
The conversation functionality moved to a class
2021-09-26 10:03:26 -04:00
Michael 1bb25de287 Applied change from PR #10763 2021-09-26 12:17:30 +00:00
Hypolite Petovan 0bb169b4ed Check for reply existence before using its values in Model\Mail
- Address https://github.com/friendica/friendica/issues/10474#issuecomment-925263894
2021-09-26 08:15:07 -04:00
Hypolite Petovan 9d77958247 Ensure parent exists before adding reply to elements in OStatus and Feed
- Address https://github.com/friendica/friendica/issues/10474#issuecomment-927118628
2021-09-26 08:15:07 -04:00
Michael e08c5ca2e0 Another try ... 2021-09-26 04:16:21 +00:00
Michael 1e583b4f35 Space removed 2021-09-26 04:07:02 +00:00
Michael 171cbf0512 Removed spaces 2021-09-26 04:05:46 +00:00
Michael 96055cafff Merge remote-tracking branch 'upstream/develop' into conversation-moved 2021-09-26 03:57:31 +00:00
Michael a2532ad755 Merge remote-tracking branch 'upstream/develop' into user-contact 2021-09-26 03:07:59 +00:00
Hypolite Petovan d8febbe45e Add new hook to support unfollow contacts on non-native networks 2021-09-25 16:15:06 -04:00
Michael 1f96742695 Merge remote-tracking branch 'upstream/develop' into conversation-moved 2021-09-25 18:38:50 +00:00
Michael 3fddf3807a Merge remote-tracking branch 'upstream/develop' into user-contact 2021-09-25 18:34:55 +00:00
Michael d4fd151227 Partly reverting formatting to cause a code style checker error 2021-09-25 08:06:38 +00:00
Michael 5cfb0cb58a Last style stuff ... 2021-09-24 04:52:34 +00:00
Michael 943f1961ea Style again 2021-09-24 04:50:47 +00:00
Michael 8fd8241797 Style again 2021-09-24 04:46:30 +00:00
Michael 64d181c1cc Code style 2021-09-24 04:35:27 +00:00
Michael f696fce824 Reformatting 2021-09-23 21:53:52 +00:00
Michael 26fa5e8b3f Moved functions 2021-09-23 21:29:36 +00:00
Michael 0ad904c185 The conversation functionality moved to a class 2021-09-23 21:18:36 +00:00
Hypolite Petovan 7f7f0eb10c Improve compacting error logging in Util\JsonLD
- Exceptions thrown by friendica/json-ld are nested and their string representation shows all the exception chain
2021-09-22 23:09:46 -04:00
Michael 840d9823d4 Log unexpected value 2021-09-22 03:25:01 +00:00
Michael 7ac76639c5 AVoid warning when fetching page data 2021-09-22 02:41:24 +00:00
Hypolite Petovan be3fb5f205
Merge pull request #10730 from annando/public-contact-list
Display the public contacts for profile visitors
2021-09-19 17:32:51 -04:00
Michael 325342a886 Renamed variable 2021-09-19 17:56:44 +00:00
Michael 9c73e49db7 Make posts on the profile page writable 2021-09-19 10:53:19 +00:00
Michael f032f66b38 Display the public contacts for profile visitors 2021-09-19 10:06:42 +00:00
Michael 3dddea96fa Merge remote-tracking branch 'upstream/2021.09-rc' into user-contact 2021-09-18 20:27:24 +00:00
Hypolite Petovan 24ecf5954c
Merge pull request #10721 from annando/issue-10720-avatar
Issue 10720: Use different path scheme for user avatars
2021-09-18 09:30:08 -04:00
Philipp c00da77c67
Add feedback 2021-09-18 12:55:17 +02:00
Philipp fd22906d70
Add feedback 2021-09-18 12:51:10 +02:00
Philipp 6893e2c3f7
Add feedback / revert fix for $item['post-type'] 2021-09-18 12:51:09 +02:00
Philipp 462f76352e
Add feedback :-) 2021-09-18 12:51:09 +02:00
Philipp 89a085a12c
Check DBA::count() result 2021-09-18 12:51:08 +02:00
Philipp 644f312896
Fix various Notices 2021-09-18 12:51:06 +02:00
Michael a91e3f5dbc Issue 10720: Use different path scheme for user avatars 2021-09-17 18:36:20 +00:00
Hypolite Petovan 9a0c3cc834 Simplify max_data parameter for Temporal::getDateTimeField 2021-09-15 15:56:44 -04:00
Michael Vogel 695df7507a
Merge pull request #10713 from MrPetovan/task/10672-contact-module-security-token
Use CSRF token as name and value for contact deletion confirm form
2021-09-15 07:55:34 +02:00
Hypolite Petovan 44ec4de14c Use CSRF token as name and value for contact deletion confirm form 2021-09-14 17:28:42 -04:00
Michael Vogel a689db7b64
Update src/Protocol/ActivityPub.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-09-14 23:22:57 +02:00
Michael b18f92ea72 Fixed indendation 2021-09-14 20:46:59 +00:00
Michael f99c4ca704 Removing unused variable 2021-09-14 08:08:50 +00:00
Michael 72fa4e9970 Better handling of displaying peertube videos 2021-09-14 07:52:53 +00:00
Michael d33fea1993 Fix: Use the $uid 2021-09-14 02:00:40 +00:00
Michael e3413cf959 Issue 10706: Publish public custom fields in AP 2021-09-14 01:28:58 +00:00
Michael 2926282f8d More fields added to "user-contact" 2021-09-13 14:20:20 +00:00
Michael 5abc1543fd Merge remote-tracking branch 'upstream/2021.09-rc' into user-contact 2021-09-13 12:31:30 +00:00
Hypolite Petovan d78661817e
Merge pull request #10693 from nupplaphil/feat/config_dir
Add the possibility to use a different configuration directory
2021-09-13 07:02:52 -04:00
Philipp a65fbcebe7
Fixing #10699 (prohibits blocking and ignoreing from the photo menu) 2021-09-12 21:20:12 +02:00
Michael 3eea4b1130 Use "rel" for "self" instead of using a separate field 2021-09-12 19:04:27 +00:00
Michael 19c3e55ca8 Merge remote-tracking branch 'upstream/2021.09-rc' into user-contact 2021-09-12 12:36:04 +00:00
Philipp 27e4586597
Move path determination logic into the ConfigFactory 2021-09-12 13:44:29 +02:00
Michael Vogel 5246b9c4b0
Merge pull request #10697 from MrPetovan/bug/10692-api-expand-entities
Prevent expandTags to be performed on existing links in Module\Api\Mastodon\Statuses
2021-09-12 06:47:51 +02:00
Hypolite Petovan e3a2f17f9f
Merge pull request #10696 from annando/photo-type
Use post type "photo" for multiple photos as well
2021-09-12 00:19:47 -04:00
Hypolite Petovan 8e99b7f775 Refine BBCode::expandTags regular expression
- Now requires the tag to be preceded by either a non-word character or a start of a line
- Added corresponding tests
2021-09-12 00:06:14 -04:00
Hypolite Petovan 5a93bb6eff Prevent expandTags to be performed on existing links in Module\Api\Mastodon\Statuses
- We never need to expand tags inside of an already existing BBCode url tag
2021-09-12 00:05:22 -04:00
Michael 6579a3a106 Use post type "photo" for multiple photos as well 2021-09-12 01:58:29 +00:00
Michael 9191daf12f Fix commenting on public posts 2021-09-12 01:52:10 +00:00
Michael eeec6aaeb9 Removed unused "use" 2021-09-11 13:02:36 +00:00
Michael 1e123ace12 Only fetch, not probe 2021-09-11 13:00:12 +00:00
Michael 10cb52bc00 Only add user contacts, alternate way to fetch public contact id 2021-09-11 12:43:46 +00:00
Philipp 5702944116
Add the possibility to use a different configuration directory 2021-09-11 14:33:26 +02:00
Michael 5113987031 Added update function to add user-contact entry 2021-09-11 07:59:46 +00:00
Michael f33a98578d Capitalization 2021-09-10 23:59:33 +00:00
Michael b170dd765d Insert and update some more fields 2021-09-10 20:53:10 +00:00
Michael 2486c8031b update for user-contact is added 2021-09-10 20:22:24 +00:00
Michael 9c14eb0c6b Use centralized function to update contact entries 2021-09-10 18:21:19 +00:00
Hypolite Petovan 8b450be09b Move unsecured GET endpoint handlers before security token check in Module\Contact 2021-09-10 12:05:43 -04:00
Hypolite Petovan 75d3f5094b
Merge pull request #10683 from annando/proxify
Make the proxy functionality optional
2021-09-10 10:24:17 -04:00
Michael a4b0ab90b1 Insert a user-contact for every contact 2021-09-10 13:05:16 +00:00
Michael 634db1ec85 Changed text 2021-09-10 00:30:11 +00:00
Michael bdb5aa6bd9 Make the proxy functionality optional 2021-09-09 12:40:19 +00:00
Hypolite Petovan e9aa27b19f Add form security token to contact actions
- Add token to batch POST actions
- Add token to individual GET actions
2021-09-06 12:30:38 -04:00
Hypolite Petovan d20b53607d Distinguish between public and private contact in contact actions
- Block and ignore is done relating to a public contact (uid = 0)
- Update and drop is done relating to a private contact (uid !=0)
- Method documentation has been improved to precise the contact type it needs
- Public and private contact ids are retrieved before acting on contacts
2021-09-06 11:50:46 -04:00
Hypolite Petovan 5262843e63 Add redirect URL parameter to contact batch
- This allows redirection to the correct contact tab after a batch action
2021-09-05 14:54:51 -04:00
Hypolite Petovan 6e358bfacf Remove user-controlled contact archival feature
- Archival is managed at the system level for failed probing and doesn't make sense for a user to decide on it
2021-09-05 14:54:50 -04:00
Hypolite Petovan 7ee88c3457 Improve documentation of $old_fields possible values in DBA::update and Database->update 2021-09-05 14:54:50 -04:00
Hypolite Petovan bd09f5f665
Merge pull request #10669 from annando/no-rino
Remove all traces of "rino"
2021-09-05 14:53:46 -04:00
Michael 52ca3e5417 Remove all traces of "rino" 2021-09-05 18:34:44 +00:00
Philipp fc46744183
Fix Photo::delete() 2021-09-05 19:20:43 +02:00
Michael d89f004a2a Issue 10651: Improved logging 2021-09-04 04:51:20 +00:00
Michael ce6f6978bd Use the correct function is adviced ... 2021-09-03 04:20:32 +00:00
Michael 307cfef12b Select all fields 2021-09-03 04:09:02 +00:00
Michael 6bb8b63da0 Adding gravity to avoid notices 2021-09-03 04:05:29 +00:00
Hypolite Petovan 1852ea98cf
Merge pull request #10657 from annando/self-unfollow
Don't offer to unfollow yourself
2021-09-02 20:04:16 -04:00
Hypolite Petovan 4140a59332
Merge pull request #10658 from nupplaphil/feat/storage_naming
Rename Storage Backend labels
2021-09-02 19:55:15 -04:00
Philipp 687e6841bc
Rename Storage Backend labels 2021-09-02 23:27:35 +02:00
Michael 547a13661a Don't offer to unfollow yourself 2021-09-02 19:38:10 +00:00
Michael 64fd94fc74 Issue 10651: remote comments appeared as own posts 2021-09-02 05:57:50 +00:00
Michael 58abaf5c53 Merge remote-tracking branch 'upstream/2021.09-rc' into issue-10640-c 2021-09-01 18:34:24 +00:00
Michael c8d2c87af0 Issue 10640 - Inverse user display settings 2021-09-01 18:29:45 +00:00
Philipp 728e82d8b0
Improve translation for Storage module 2021-09-01 14:00:23 +02:00
Hypolite Petovan 1665b54c6f
Fix variable assignment alignment in Module\Admin\Site 2021-08-31 16:01:20 -04:00
Michael 13ae96e9e1 Some more "enable" 2021-08-31 19:54:05 +00:00
Michael 85e2328b23 Issue 10640: Some more inversed settings 2021-08-31 19:26:17 +00:00
Michael 80b13ec232 Fix translations for singular/plural strings 2021-08-31 05:51:08 +00:00
Michael 3944e5d38e Disable mail setting when imap support is disabled 2021-08-30 21:17:03 +00:00
Michael e3c7cd25e1 Issue 10640: Use consistent settings to enable protocol support 2021-08-30 19:46:10 +00:00
Michael 2bae4dde1f Avoid notices 2021-08-30 12:29:09 +00:00
Hypolite Petovan 4f7142198e
Merge pull request #10642 from annando/url-change
Set contact to failed when url changed
2021-08-30 08:12:10 -04:00
Michael 9135ff5124 Set contact to failed when url changed 2021-08-29 20:25:21 +00:00
Philipp 0d6884a8a9
Fix http_code usage in case of failures 2021-08-29 14:05:38 +02:00
Philipp 58001c729f
Fix https://github.com/friendica/friendica/issues/10473#issuecomment-907749093 2021-08-29 13:56:56 +02:00
Philipp b76634ea0c
Catch TransferExceptions for HTTPClient::finalUrl() in case the headers are empty 2021-08-29 13:37:08 +02:00
Philipp 1c089e8d89
[WIP] WebDav Storage backend 2021-08-25 23:47:18 +02:00
Philipp 13a91e63aa
Rename DI::httpRequest() into DI::httpClient() 2021-08-25 21:54:54 +02:00
Philipp 505100bdd7
Rename HTTPRequestOptions to HTTPClientOptions 2021-08-25 21:45:15 +02:00
Philipp 478f69c403
Realy fix setCookieJar 2021-08-25 21:32:44 +02:00
Philipp 2054a787da
Fix HTTPRequestOptions at HTTPClient::post() 2021-08-25 21:31:30 +02:00
Philipp 0cafa871f1
Use HTTPRequestOptions constants for HTTPClient::get() 2021-08-25 21:31:30 +02:00
Philipp aad7bac686
Use HTTPRequestOptions constants for HTTPClient::post() 2021-08-25 21:31:30 +02:00
Philipp e9902401a5
Fixing HTTPClient::post() and introduce HTTPRequestOptions 2021-08-25 21:31:30 +02:00
Philipp 660a3cd247
Expose IHTTPClient::request() 2021-08-25 21:31:30 +02:00
Philipp 749f3e158b
Use temporary files for the URLResolver CookieJar 2021-08-25 20:39:33 +02:00
Philipp 81ad618480
Merge branch 'task/httprequest_optimiziations' of https://github.com/nupplaphil/friendica into task/httprequest_optimiziations 2021-08-25 18:01:34 +02:00
Philipp 4ddaf49f53
Revert setCookieJar() and add overwrite parameter fpr rare cases 2021-08-25 18:01:07 +02:00
Philipp f10de08166
Update src/Network/IHTTPClient.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-08-25 17:02:42 +02:00
Philipp f00da9eccf
Update src/Network/IHTTPClient.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-08-25 17:02:34 +02:00
Philipp a6258cfbfa
Adapt description for "accept_content" 2021-08-25 14:28:59 +02:00
Philipp 12367648fa
Add suggestions 2021-08-25 14:22:43 +02:00
Philipp 7d251f092e
Add logpoint 2021-08-25 14:22:43 +02:00
Philipp befd5c860d
Fix headers (string to array) and make sure the signature doesn't change 2021-08-25 14:22:43 +02:00
Philipp f01d882e6c
Fix HTTPClient 2021-08-25 14:22:43 +02:00
Philipp d4a233a149
Extend test capability for HTTP Requests 2021-08-25 14:22:43 +02:00
Philipp a3d0404290
Fix curResult::getHeader() in GServer.php 2021-08-25 14:22:43 +02:00
Philipp 2356221aba
Fixup HTTP headers for httpClient requests 2021-08-25 14:22:43 +02:00
Philipp 10e6089405
Fixing https://github.com/friendica/friendica/issues/10473#issuecomment-903993836 2021-08-25 14:22:42 +02:00
Philipp 3eb2abdb2a
Adapt tests 2021-08-25 14:22:42 +02:00
Philipp 8385ee7a61
Use mattwright/urlresolver for HTTPClient::finalUrl() 2021-08-25 14:22:42 +02:00
Philipp e576af218b
Use Guzzle for HTTPClient::post() 2021-08-25 14:22:42 +02:00
Philipp 736277dcf0
Refactor HTTPClient::get() / ::head() 2021-08-25 14:22:42 +02:00
Philipp 52c7948526
Create HTTPClientFactory and introduce ImageTest 2021-08-25 14:22:42 +02:00
Hypolite Petovan 7a8d800024 Add probe support to @user@domain.tld search string format 2021-08-24 12:46:01 -04:00
Hypolite Petovan 17944c01ea Allow a GuzzleResponse body to be queried more than once
- Using `StreamInterface->getContents` left the stream index at the end of the stream, which made every subsequent call to `getBody()` return empty string
- Using `StreamInterface->__toString()` magic method correctly seek the stream to the start before reading
2021-08-24 11:30:11 -04:00
Hypolite Petovan e7fdf3c0c3
Merge pull request #10630 from annando/cleared-enotify
Unused parts of the old notification system are removed
2021-08-24 10:25:06 -04:00
Michael Vogel 9aca4b515f
Merge pull request #10628 from MrPetovan/bug/fatal-errors
Set profile fields for system user in Model\User::getOwnerDataById
2021-08-24 14:13:32 +02:00
Hypolite Petovan ceeb246128 Remove Profile::load from Module\HCard
- Renamed and re-scoped Profile::sidebar to getVcardHtml
2021-08-24 06:24:06 -04:00
Hypolite Petovan 8f0e36d617 Raise an Exception when Profile::load is profided the system user nickname 2021-08-24 05:54:15 -04:00
Hypolite Petovan e155821d7a Set profile fields for system user in Model\User::getOwnerDataById
- Address https://github.com/friendica/friendica/issues/10473#issuecomment-903676606
- This is required when Model\Profile::load is called for the system user for example
2021-08-24 05:53:46 -04:00
Michael 429a724bc1 Unused parts of the old notification system are removed 2021-08-24 08:53:15 +00:00
Hypolite Petovan 0651ace4e4
Merge pull request #10627 from annando/like-announce
Reliably display "like" and "share" notifications
2021-08-23 14:12:57 -04:00
Michael c78b7f45c5 Reliably diasplay "like" and "share" notifications 2021-08-23 15:07:14 +00:00
Hypolite Petovan 2108be7e07
Merge pull request #10619 from nupplaphil/task/guzzlehttp
PSR-7 Part 1: Use Guzzle PSR-7 library for HTTPRequest->get()
2021-08-22 18:11:30 -04:00
Philipp ff2d85b703
Initialize $curlOptions[CURLOPT_HTTPHEADER] outside of the checks 2021-08-22 22:49:55 +02:00
Philipp c3eca0cfae
Remove legacy header-parsing for guzzle 2021-08-22 22:43:28 +02:00
Michael e9c63ff075 Added "follow" subscription message 2021-08-22 08:27:56 +00:00
Michael 59045b2e23 Added handling another situation 2021-08-22 03:58:50 +00:00
Michael 4f1e61457d Fetch the user's post if present 2021-08-21 21:40:47 +00:00
Michael 42de5c77d0 The desktop notifications have been reworked 2021-08-21 20:35:04 +00:00
Philipp 8f13319c73
remove unused $redirect parameter 2021-08-20 22:30:54 +02:00
Philipp 9eba32226c
make CS happy :) 2021-08-20 22:11:36 +02:00
Philipp 653d49cb92
Fix getHeader() 2021-08-20 22:00:28 +02:00
Philipp 65ca164487
A lot of Fixings 2021-08-20 21:35:14 +02:00
Philipp 06371d29a6
Cleanup 2021-08-20 20:03:42 +02:00
Philipp a338e4cbff
Update src/Network/GuzzleResponse.php 2021-08-20 19:58:42 +02:00
Philipp 756f57f198
Revert "Use last entry for Content-Type 2021-08-20 19:58:42 +02:00
Philipp 50e2478189
Remove unnecessary exception message (avoid log flooding) 2021-08-20 19:58:42 +02:00
Philipp 1995feff61
Fix redirect logging 2021-08-20 19:58:42 +02:00
Philipp 26401e88b8
IHTTPResult::getContentType is now a string again 2021-08-20 19:58:42 +02:00
Philipp 82f767f2ee
Fix Content-Type for CurlResult class 2021-08-20 19:58:42 +02:00
Philipp 803c1d71de
Fix IHTTPResult::getHeader()
- Now returns a string array, like expected
- Fix usages
- Fix dataset
2021-08-20 19:58:42 +02:00
Philipp 3c074ab315
HTTPRequest: Replace getInfo() with new parameter 'content_length' 2021-08-20 19:58:42 +02:00
Philipp 89f718ec72
Use CurlResult for failed HTTPRequests (legacy usage) 2021-08-20 19:58:42 +02:00
Philipp dee1899628
Fix IHTTPResult::getHeader/s()
- Split functionality "getHeader()" and "getHeaders()" analog to IMessageInterface::getHeader/s()
- Fix functionality at various places - Adapt CurlResultTest
2021-08-20 19:58:42 +02:00
Philipp a60ca4a1cf
Use Guzzle for HTTPRequest and Result 2021-08-20 19:58:42 +02:00
Philipp 05ecd1e3d4
Replace IHTTPResult for CurlResult usages 2021-08-20 19:58:42 +02:00
Philipp 7009d90add
Introduce IHTTPResult Interface as abstraction for CurlResult 2021-08-20 19:58:42 +02:00
Hypolite Petovan 632d1024f7
Merge pull request #10309 from fabrixxm/feature/advanced-logsview
Display structured logs in admin
2021-08-20 05:24:07 -04:00
fabrixxm 3766204b05 Fix code standard 2021-08-20 11:09:35 +02:00
fabrixxm 7f695197aa Fix review points
- Fix headers hierarchy
- Improve accessibility:
 	- set mouse pointer
	- make rows focusable
	- open on key press
	- add tooltip with "title"
	- add role and aria attributes
- Rename `ParsedLog` to `ParsedLogLine`
- Add docs to `ReversedFileReader`'s implementation of `Iterator`'s methods
- Add docs to `ParsedLogIterator`'s implementation of `Iterator`'s methods
- Remove unnecessary comment
- Add more test for parsing log lines and fix some edge cases
- Fix function name in snake-case to camelCase
- Remove `DIRECTORY_SEPARATOR`
2021-08-20 11:02:18 +02:00
Hypolite Petovan 1de159a2ae Escape url tags before attempting to add missing mention links in Protocol\ActivityPub\Processor
- Mastodon uses @-sign in profile URLs which wrongly triggered the mention link add in existing mentions links
2021-08-20 03:45:15 -04:00
Hypolite Petovan 4b36f7e8c8
Merge pull request #10616 from annando/notification-message
Meaningful notification message
2021-08-19 19:20:46 -04:00
Michael c0d187f281 Added "causer" and "notification" for the "ping" mechanism 2021-08-19 14:57:35 +00:00
Michael 6899d3c618 Meaningful notification message 2021-08-19 13:58:55 +00:00
fabrixxm dd2abc7aff Fix code standard 2021-08-19 15:20:25 +02:00
fabrixxm ec4f53d56f Add DI to ParsedLogIterator, replace constructors with fluent api 2021-08-19 14:56:51 +02:00
fabrixxm a62124285d Add tests for ParsedLog and fix parsing 2021-08-19 14:55:33 +02:00
fabrixxm 84fa668845 Fix code formatting 2021-08-19 14:55:33 +02:00
fabrixxm 5b9aeeeca9 Add search and filter to log view 2021-08-19 14:55:33 +02:00
fabrixxm 9368f5445d Display structured logs in admin
Tries to parse log lines and to display info in a table.
Additional JSON data is parsed and displayed clicking on a row.

File reading and line parsing is handled in iterators, to avoid to keep
too much data in memory.
Search and filter should be trivial to add.
Log file is read backward to display log events newest first.
A "tail" functionality should be easy to implement.
2021-08-19 14:55:33 +02:00
Hypolite Petovan 9b64035231 ActivityPub: Add support for non-link mentions
- This enables implicit mention removal even if the remote server doesn't add links to mentions in the message body.
- This also enable interactive mentions in the message body when implicit mentions are disabled.
2021-08-18 14:36:21 -04:00
Hypolite Petovan f0bb83c225
Merge pull request #10613 from annando/improved-payload
The push api payload content is improved
2021-08-18 13:45:18 -04:00
Michael Vogel 9bc6b08618
Update src/Worker/PushSubscription.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-08-18 18:54:03 +02:00
Michael 6f6fe7fa25 Clarify the upcoming functionality 2021-08-18 10:27:45 +00:00
Michael Vogel 486328336f
Merge pull request #10611 from MrPetovan/task/feed-debug-contact
Allow contact creation in Module\Debug\Feed
2021-08-18 10:05:38 +02:00
Michael b521e45903 Merge remote-tracking branch 'upstream/develop' into improved-payload 2021-08-17 23:00:00 +00:00
Michael 5a9db1b3bc The push api payload content is improved 2021-08-17 22:53:52 +00:00
Hypolite Petovan 0a592fbf34 Abort early if owner isn't found in Module\RemoteFollow
- Address https://github.com/friendica/friendica/issues/10473#issuecomment-899099987
2021-08-17 09:38:35 -04:00
Hypolite Petovan 6f13663c45 Return early if body is empty in Network\Probe::updateFromFeed
- Address https://github.com/friendica/friendica/issues/10473#issuecomment-894815271
2021-08-17 09:35:44 -04:00
Hypolite Petovan a04944d443 Allow contact creation in Module\Debug\Feed
- This module only allowed existing contact feeeds to be debugged
2021-08-17 08:20:58 -04:00
Hypolite Petovan 64d6df659d
Merge pull request #10609 from tobiasd/20210816-10514
Issue 10514: add TLS check to the installer
2021-08-17 07:58:17 -04:00
Tobias Diekershoff e1c961cc64
Merge pull request #10607 from MrPetovan/task/advancecontentfilter-attachments
Add the attachments to the $item for the prepare_body_content_filter hook
2021-08-17 12:40:49 +02:00
Tobias Diekershoff ae6e13815d rewording the encouragement and regen of the messages.po 2021-08-17 08:38:06 +02:00
Tobias Diekershoff 6cd9f26771 add encuragement 2021-08-17 08:38:06 +02:00
Tobias Diekershoff e16e9bd929 typo 2021-08-17 08:38:06 +02:00
Tobias Diekershoff cafb91ec62 Issue 10514: add TLS check to the installer
This PR adds a check to the installer which tries to determine whether the
request to the installer was made over an HTTPS line or not.

I've only tested it with an Apache2 server, but there it works.

Addresses #10514
2021-08-17 08:38:06 +02:00
Philipp db6fded5d2
Update src/Core/StorageManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-08-16 23:32:32 +02:00
Philipp 99239e3d99
Fix usage 2021-08-16 23:27:43 +02:00
Philipp 1901716479
Lower complexity for valid backends (replace hashmap with a "simple" name array) 2021-08-16 23:27:43 +02:00
Philipp 02a4d30f7d
Add todo for later 2021-08-16 23:27:43 +02:00
Philipp 1df6225868
Update src/Model/Storage/Filesystem.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-08-16 23:27:42 +02:00
Philipp f4941b5b49
Update src/Model/Storage/IWritableStorage.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-08-16 23:27:42 +02:00
Philipp c17bc55158
Introduce InvalidClassStorageException and adapt the code for it 2021-08-16 23:27:42 +02:00
Philipp d0536ebea7
Rename ISelectableStorage to IWritableStorage 2021-08-16 23:27:42 +02:00
Philipp eb035771f1
Revert Photo::getImageDataForPhoto return-type change 2021-08-16 23:27:42 +02:00
Philipp 51ebb1541a
- Revert HTTPSignature change 2021-08-16 23:27:42 +02:00
Philipp 57438afbb3
- Moved the description for the specific storage exception first
- Introduced exceptions for try to get invalid storage
- ReferenceStorageException now extends StorageException
2021-08-16 23:27:42 +02:00
Philipp 470ba8b61b
Fixup Database behaviour 2021-08-16 23:27:42 +02:00
Philipp 90c99520bb
Fix Storage Exceptions 2021-08-16 23:27:42 +02:00
Philipp 29c7552df5
Refactor IStorage 2021-08-16 23:27:42 +02:00
Philipp 5dcdf2322e
Split IStorage and ISelectableStorage and make their behaviour homogenous 2021-08-16 23:27:41 +02:00
Hypolite Petovan e205bd450e
Merge pull request #10602 from annando/push
Transmit push subscriptions
2021-08-16 14:33:36 -04:00
Michael 7158b35f58 Added logging, removed superfluous comments 2021-08-16 15:23:34 +00:00
Hypolite Petovan 7082582655 Add the attachments to the $item for the prepare_body_content_filter hook
- Allows filtering on attachments that are added later to the post content
2021-08-16 05:28:08 -04:00
Michael ce9da778b9 Clarify XMPP profile field description 2021-08-16 06:15:18 +00:00
Michael c85ce2f6b0 Add a payload 2021-08-16 06:11:26 +00:00
Michael 69c816eb17 Trim whitespace 2021-08-15 22:09:32 +00:00
Michael e3f8f371a7 Use the existing VAPID key generation 2021-08-15 21:54:24 +00:00
Michael 2c1b33af87 Standards 2021-08-15 21:30:27 +00:00
Michael 69f11c4a84 Adding the VAPID keys 2021-08-15 21:24:23 +00:00
Michael d5e9253adb Standards again 2021-08-15 21:03:43 +00:00
Michael 5cf0da4140 Coding standards 2021-08-15 21:01:58 +00:00
Michael 977d28353c Transmit push subscriptions 2021-08-15 20:52:46 +00:00
Hypolite Petovan 414f20c529
Merge pull request #10600 from nupplaphil/bug/update_autoinstall_doc
AutomaticInstallation - Fix last example
2021-08-15 16:50:58 -04:00
Philipp b52c9215f6
AutomaticInstallation - Fix last example 2021-08-15 21:36:05 +02:00
Michael c78d490c2e Some more standards 2021-08-15 16:24:12 +00:00
Michael f29cef175e Remove spaces 2021-08-15 16:22:23 +00:00
Michael 19f3cad56c Preparation for creating push notification 2021-08-15 16:18:25 +00:00
Michael 5056376902 We need to create a vapid public and private key 2021-08-15 12:57:29 +00:00
Michael 74f3cbc383 Improved error check, added "put" 2021-08-15 07:28:26 +00:00
Michael 8b6ace6629 Don't continue when key couldn't be created 2021-08-15 06:45:48 +00:00
Michael 167a12ef54 Styling 2021-08-15 00:43:07 +00:00
Michael e28a4265c5 API: First steps to support subscriptions 2021-08-15 00:30:41 +00:00
Hypolite Petovan 1e305e748d
Merge pull request #10596 from annando/mark-file-star-for-all
Follow, file and star does now work for all items
2021-08-12 12:20:55 -04:00
Michael Vogel fa65c436f4
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-08-12 18:04:01 +02:00
Hypolite Petovan a364436623
Merge pull request #10597 from annando/warning
Fixes "PHP Warning:  key() expects parameter 1 to be array, string given"
2021-08-12 11:48:35 -04:00
Michael Vogel f7f79a240a Are the tests happy? 2021-08-12 15:12:41 +02:00
Michael Vogel e6ab4d9be9 Fixes "PHP Warning: key() expects parameter 1 to be array, string given" 2021-08-12 14:00:54 +02:00
Michael 81d9fc677f Updated messages.po 2021-08-12 06:33:08 +00:00
Michael 473adaf463 Mark, file and starring does now work for all items 2021-08-12 05:28:47 +00:00
Michael Vogel b855646097
Merge pull request #10580 from MrPetovan/bug/10019-peertube-embed
Simplify attachment processing in Protocol\ActivityPub\Receiver
2021-08-11 13:56:33 +02:00
Michael ce46ab2573 The Matrix and XMPP address is now transported via AP as well 2021-08-10 23:49:09 +00:00
Hypolite Petovan 56ee1a211f
Merge pull request #10592 from annando/event
Simplify event storing
2021-08-10 09:00:41 -04:00
Michael 8e074a5fe4 Simplify event storing 2021-08-10 10:24:14 +00:00
Michael 56c00ea42d Handles PHP Notice: Undefined index: addr in src/Protocol/Diaspora.php on line 3091 2021-08-10 03:50:43 +00:00
Hypolite Petovan d7e5814b12 Simplify attachment processing in Protocol\ActivityPub\Receiver
- Remove indexing attachments by mediatype for later sorting
2021-08-09 19:29:12 -04:00
Michael 28cfdec7c4 Some more renamed functions 2021-08-09 20:56:15 +00:00
Michael c81e81dc8d "getUserId" is now "getLoggedInUserId" 2021-08-09 20:33:46 +00:00
Michael 15b93b4459 "getUserNickname" is now "getLoggedInUserNickname" 2021-08-09 19:48:39 +00:00
Michael f5e84c1ff0 Use owner not profile 2021-08-09 15:38:22 +00:00
Michael 4495e83eca Merge remote-tracking branch 'upstream/develop' into app-user2 2021-08-09 15:32:32 +00:00
Michael b8fa75b2dd Changed function name 2021-08-09 15:29:07 +00:00
Hypolite Petovan 3e1e3c8b3e
Merge pull request #10588 from annando/matrix
Matrix addresses can be entered in the profile
2021-08-09 10:56:12 -04:00
Michael 51d549639d Fix profile probing via Pleroma 2021-08-09 06:56:41 +00:00
Michael bee04f86ee Matrix addresses can be entered in the profile 2021-08-09 01:39:09 +00:00
Michael 9f01052dd2 Removed some more unused "use" 2021-08-08 20:03:28 +00:00
Michael a9d7e5b29e Removed unused use 2021-08-08 19:43:15 +00:00
Michael 28090bd793 Get rid of App->user completely 2021-08-08 19:30:21 +00:00
Michael fc283ab928 Remove direct calls to App->user 2021-08-08 10:14:56 +00:00
Michael 9664efd66b Added some description 2021-08-07 20:09:25 +00:00
Michael 6a23b17c95 Respect the postopts values for scheduled posts 2021-08-06 18:49:17 +00:00
Tobias Diekershoff 266ee26240
Merge pull request #10579 from annando/http-errors
Avoid some HTTP errors
2021-08-06 08:11:35 +02:00
Michael a8442e41ab Improved error message for external resources 2021-08-06 04:02:42 +00:00
Michael 4bc3e8c141 Don't send "accept" when we accept anything 2021-08-06 04:02:22 +00:00
Tobias Diekershoff 0e54d35f65
Merge pull request #10575 from MrPetovan/bug/10019-peertube-embed
Extract MP4 video URL from PeerTube ActivityPub metadata to enable video embed
2021-08-05 18:11:07 +02:00
Hypolite Petovan f194d167b0 Extract MP4 video URL from PeerTube ActivityPub metadata to enable video embed
- This MP4 video URL is located in the tags of the streaming URL link element that we don't support yet
2021-08-05 10:51:42 -04:00
Michael d6c25dc63c Handle profile page detection without a type 2021-08-05 11:37:04 +00:00
Michael eec6cdf01b Avoid a database query when possible 2021-08-05 08:51:39 +00:00
Michael 835152d418 Simplified signature creation 2021-08-05 08:42:46 +00:00
Michael a26a2a0228 Make the system owner ready for Diaspora 2021-08-05 08:30:44 +00:00
Michael Vogel c73130aa6b Create the Diaspora signature for the correct user 2021-08-05 08:58:50 +02:00
Michael 1c5baddcd2 Don't use the system user for participation messages 2021-08-04 12:35:03 +00:00
Michael Vogel 25f0f0c439 Display the publish time in the local timezone 2021-08-04 07:58:07 +02:00
Michael ec3eead034 Don't set the pconfig values on manual mode 2021-08-03 05:39:04 +00:00
Hypolite Petovan 37d5bc1a51
Merge pull request #10566 from annando/manage-avatar
Use the general function ro create an avatar path
2021-08-02 18:50:15 -04:00
Michael 9f19adf8bb Use the general function ro create an avatar path 2021-08-02 22:28:42 +00:00
Michael 6c8a4a2552 Use a centralized function to delete delayed entries 2021-08-02 20:56:34 +00:00
Michael 88e276843e Using "post" when deleting, fixing deleting 2021-08-02 19:18:44 +00:00
Michael f87e41e206 Scheduled posts are now listed and can be deleted 2021-08-02 17:03:06 +00:00
Michael ec5ed0cf46 Placeholder page for scheduled posts 2021-08-02 12:10:03 +00:00
Michael 8214401b57 Merge remote-tracking branch 'upstream/develop' into scheduled-frontend 2021-08-01 13:12:25 +00:00
Michael 2e2d1bf81d Added option to define a schedule date when posting items 2021-08-01 13:01:31 +00:00
Hypolite Petovan 98803064eb
Merge pull request #10562 from nupplaphil/bug/storage_admin
Fix legacy storage config
2021-08-01 05:59:35 -04:00
Philipp 839b5b5859
Fix legacy storage config 2021-07-31 20:56:32 +02:00
Michael e89d0f2599 Style 2021-07-31 06:22:08 +00:00
Michael 13529fa97d Support the "media_attachments" field 2021-07-30 22:39:13 +00:00
Michael 9b609ba19d Space added 2021-07-30 14:06:18 +00:00
Michael 48f2790593 Spaces removed 2021-07-30 14:05:57 +00:00
Michael 929de9081e All needed fields are now filled 2021-07-30 13:22:06 +00:00
Michael 93263a820d Function renamed, documentation added 2021-07-30 10:24:08 +00:00
Michael bb37c41bd7 Scheduled posts can now be created 2021-07-30 06:22:32 +00:00
Michael 4137a6250b Delayed now return their id on insert 2021-07-30 06:20:10 +00:00
Michael 5e75ba3083 guid function is now public 2021-07-30 06:19:25 +00:00
Michael 432206bc5b Use router constants 2021-07-30 06:19:02 +00:00
Michael c9eca1edeb Fix array index 2021-07-29 15:01:09 +00:00
Michael a1828430e5 Fixing variables 2021-07-29 14:58:04 +00:00
Michael 20e69c1e71 Return as array 2021-07-29 10:46:40 +00:00
Michael 6ea3d4aa61 Added API calls, removed fields 2021-07-29 10:34:31 +00:00
Michael fbbe9a3c1f "wid" is not an item field 2021-07-29 03:57:37 +00:00
Michael 2951243b07 Preparation for delayed posts 2021-07-28 22:22:00 +00:00
Hypolite Petovan f89cc6bd45
Merge pull request #10553 from annando/issue-10545
Issue 10545: Convert complex zmg BBCode elements
2021-07-28 06:37:52 -04:00
Michael 6f40904ea1 Increased version 2021-07-28 10:18:34 +00:00
Michael d58eaa13d1 Issue 10545: Convert complex zmg BBCode elements 2021-07-27 21:44:02 +00:00
Hypolite Petovan dfb043ce60 Add Exception for empty User::getOwnerDataById(0 return case in Protocol\ActivityPub\Transmitter::getProfile()
- Address https://github.com/friendica/friendica/issues/10473#issuecomment-882781552
- Add try-catch blocks to all references of Protocol\ActivityPub\Transmitter::getProfile()
2021-07-27 16:46:08 -04:00
Michael ab24f58bad Parser is now session 2021-07-27 13:56:28 +00:00
Michael Vogel c03fb998f4
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-07-27 15:16:31 +02:00
Michael 8dd21d82f5 Fix possible fatal error when body is null 2021-07-27 12:25:38 +00:00
Michael 9226b98724 Performance: Moved filter call after content generation 2021-07-27 12:24:22 +00:00
Michael 72bc1238ba Tests 2021-07-27 06:17:24 +00:00
Michael c89533a70b Support for stacked profiler analysis 2021-07-27 04:57:29 +00:00
Hypolite Petovan 3cef3ab107
Merge pull request #10548 from annando/args
Replaced argv/argc with replacement functions
2021-07-26 18:43:47 -04:00
Hypolite Petovan e34795762d
Merge pull request #10544 from annando/router-lock
Lock before recreate / fix cache key misspelling
2021-07-26 03:57:30 -04:00
Michael 1539d76fda Forgotten variable 2021-07-25 20:39:03 +00:00
Michael 5a87ccf026 Getter/Setter for theme info 2021-07-25 19:39:10 +00:00
Michael c52b8595e8 theme infos are now bundled in a single array 2021-07-25 19:07:03 +00:00
Michael 0551648399 App->data is not needed anymore 2021-07-25 17:29:50 +00:00
Michael df558d4056 Completely removed argc/argv 2021-07-25 15:23:37 +00:00
Michael 540ddb9265 Hopefully making the tests to work 2021-07-25 14:27:13 +00:00
Hypolite Petovan 69c75daf4f
Merge pull request #10543 from annando/app-variables
App variables reduced and removed
2021-07-25 08:56:05 -04:00
Michael 9cc4682e0a Merge branch 'app-variables' of github.com:annando/friendica into app-variables 2021-07-25 05:08:33 +00:00
Michael fbac31edc5 Simplyfying code 2021-07-25 05:08:29 +00:00
Michael Vogel 1793513f46
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-07-25 07:04:48 +02:00
Michael 2aa2c61479 Lock before recreate / fix cache key misspelling 2021-07-25 04:31:48 +00:00
Michael 0bbe954316 Getter/Setter for queue 2021-07-24 22:08:33 +00:00
Michael 866dbf9f89 Use getter/setter for timezone value 2021-07-24 21:16:53 +00:00
Michael 40a42ccdb1 Defining default value 2021-07-24 20:51:55 +00:00
Michael eda2f95a66 Added documentation 2021-07-24 20:42:09 +00:00
Michael 8f46064430 Using getter/setter functions 2021-07-24 20:34:07 +00:00
Philipp 4be4498b13
Update UX for Storage administration 2021-07-24 19:01:01 +02:00
Philipp 1e4f9f62fe
Rename buttons 2021-07-24 19:01:00 +02:00
Philipp e19b9824cd
Allow setting & saving storages per type 2021-07-24 19:00:58 +02:00
Philipp 2fe28af74f
PHP-CS fixing 2021-07-24 19:00:58 +02:00
Philipp cbe522ee82
Fixings 2021-07-24 19:00:58 +02:00
Philipp 3647f6f031
Refactor storage admin setting 2021-07-24 19:00:58 +02:00
Philipp 97bafb3a59
Extract Storage admin section to own page 2021-07-24 19:00:58 +02:00
Michael 2420bf84db Simplified code 2021-07-24 13:29:58 +00:00
Michael d56793dd09 Fix field name 2021-07-24 13:24:26 +00:00
Michael b3b5599d27 Show the network icon for the contact 2021-07-24 12:21:33 +00:00
Michael 30aad250df App->contact is now removed 2021-07-24 11:49:11 +00:00
Michael 0fe5759d8a Fixed avatar fetching for mail and feed 2021-07-24 10:32:55 +00:00
Michael 2502a9192d Many more app-variables removed 2021-07-24 10:09:39 +00:00
Michael fae0f839bc Merge remote-tracking branch 'origin/develop' into profile 2021-07-23 13:29:36 +00:00
Michael 2fae93d8fd More standards 2021-07-23 13:09:12 +00:00
Michael 90d7360252 Standards 2021-07-23 13:08:41 +00:00
Michael c17e1d7e0b Removed unused code from the profile sidebar 2021-07-23 13:05:53 +00:00
Michael afe3c8954c Simplified functionality to load the profile in the sidebar 2021-07-23 12:39:37 +00:00
Michael 9a3a4def3d "hovercard" is "hcard" 2021-07-23 12:38:29 +00:00
Michael bb222209bc Some small performance tweaks 2021-07-22 15:35:30 +00:00
Hypolite Petovan 81e6e65bc8
Merge pull request #10535 from annando/mentions
Fix for Mastodon falsely adding previews to mentions
2021-07-22 07:46:14 -04:00
Michael 71f53c946f New function to replace mentions with nicknames 2021-07-22 09:13:39 +00:00
Michael c1f849c389 Unneeded legacy DFRN table removed 2021-07-22 07:11:26 +00:00
Michael bb5f738619 Fix for Mastodon falsely adding previews to mentions 2021-07-22 04:50:01 +00:00
Michael 08cd651a03 Improved performance for UpdateContacts 2021-07-21 15:12:30 +00:00
Hypolite Petovan e7880cd37d
Merge pull request #10528 from annando/db-error
Avoid "DB Error" messages
2021-07-21 10:30:06 -04:00
Hypolite Petovan 72ab57f067
Merge pull request #10530 from annando/api-mail
API: Support for fetching mails with more "statuses" calls
2021-07-21 09:52:26 -04:00
Michael 01fd128502 API: Support for fetching mails with more "statuses" calls 2021-07-21 05:58:22 +00:00
Michael ec08784aa3 API: Added dummy endpoint for featured tags 2021-07-21 05:22:56 +00:00
Michael 69c6a5f567 Avoid "DB Error" messages 2021-07-21 03:43:30 +00:00
Michael c01ca1583c Added permission check 2021-07-20 21:45:42 +00:00
Michael e199abc837 Removed unused use 2021-07-20 21:19:16 +00:00
Michael b5f59d5be0 API: Support for deprecated API endpoints and OAuth removal 2021-07-20 20:48:37 +00:00
Michael a8fb90f42f Merge remote-tracking branch 'upstream/develop' into legacy-oauth-removed 2021-07-20 17:44:05 +00:00
Michael 6668066099 The legacy OAuth server is removed 2021-07-20 17:41:04 +00:00
RealKinetix cf32a4b7cc Sanitize negative status count on APContact
Similar to PR #10499, Mastodon apparently has some counting flaws and
can present a negative status count for a user, causing Friendica to
fail (at least under PHP 8) with:

[20-Jul-2021 16:35:18 UTC] PHP Fatal error:  Uncaught PDOException: SQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'statuses_count' at row 1 in /home/friendicadev/friendica/src/Database/Database.php:560
Stack trace:
  thrown in /home/friendicadev/friendica/src/Database/Database.php on line 560

This change prevents values lower than 0 from being assigned to
statuses_count.
2021-07-20 10:11:04 -07:00
Hypolite Petovan f3131c6277 Manually add Persian to post body language detection 2021-07-19 14:00:31 -04:00
Michael 289a4dcba7 Added missing app class (avoid fatal error) 2021-07-19 16:15:06 +00:00
Michael d2408c1f1b Merge remote-tracking branch 'upstream/develop' into loop-prevention 2021-07-19 12:07:34 +00:00
Michael 64026ed979 Simplify code 2021-07-19 12:07:02 +00:00
Hypolite Petovan 0dd94e8fd5
Merge pull request #10515 from annando/event-handling
Improved event storing / improved performance when fetching events
2021-07-19 04:00:53 -04:00
Michael 58cec97358 Merge remote-tracking branch 'upstream/develop' into loop-prevention 2021-07-19 07:51:29 +00:00
Hypolite Petovan eb43a579ec
Merge pull request #10512 from annando/ap-endpoints
Move ActivityPub endpoints to an AP class
2021-07-19 03:30:23 -04:00
Michael f5a7b0141b Added todo 2021-07-19 06:55:23 +00:00
Michael fa00a4ee32 Simplyfied picture fetching 2021-07-19 06:19:13 +00:00
Michael 2647514603 Detection of local requests 2021-07-19 06:14:14 +00:00
Michael 01abea7c25 Don't probe non existing local contacts 2021-07-19 04:49:58 +00:00
Michael aa6313dee6 Improved detection for a local contact 2021-07-19 04:15:57 +00:00
Michael 424a85bb94 Fetch local data without HTTP requests 2021-07-18 18:54:25 +00:00
Michael d8bf9c4601 Prevent loop also when fetching the outbox 2021-07-18 16:42:55 +00:00
Michael 2030691f9f Improved event storing / improved performance when fetching events 2021-07-18 15:05:46 +00:00
Michael f62f82df75 Move ActivityPub endpoints to an AP class 2021-07-17 20:28:46 +00:00
Michael ea056b93fa Fix notice in events 2021-07-17 20:27:18 +00:00
Michael dd2abf254d Issue 10506 - again. Improved check for pictured in body 2021-07-17 07:55:19 +00:00
Michael 596bb9fa7c Fixed wrong parameter 2021-07-17 05:25:04 +00:00
Michael 89f7ee2cc5 Prevent endless loop when updating contact by probe 2021-07-17 04:57:21 +00:00
Michael feab53b58b Issue 10506: Fix for multiple picture posts 2021-07-17 04:32:46 +00:00
Michael 209d4d0d6a DFRN endpoints moved, changelog entry added 2021-07-16 14:45:29 +00:00
Hypolite Petovan 4dc6b29046
Merge pull request #10503 from annando/no-legacy-dfrn
Legacy DFRN transport layer is removed
2021-07-15 16:24:07 -04:00
Michael c1e681e007 Improved comment 2021-07-15 17:42:03 +00:00
Michael 3a5523820c Legacy DFRN transport layer is removed 2021-07-15 13:28:32 +00:00
RealKinetix a0107be2af Negative numbers in following is a thing too
Check & sanitize 'following' as well, as per:
https://mastodon.social/@BLUW
2021-07-14 13:51:30 -07:00
RealKinetix f16b1df83f Adjust where the code is to avoid empty warning
Shifted the code to avoid:
PHP Warning:  Undefined array key "totalItems" in /home/friendicadev/friendica/src/Model/APContact.php on line 277
2021-07-14 13:46:38 -07:00
RealKinetix c1db1c980e Fix indent to standards 2021-07-14 12:17:03 -07:00
RealKinetix 2ebebe9abc Sanitize negative followers count on APContact
Please see
https://github.com/friendica/friendica/issues/9498#issuecomment-818894106
and related discussion regarding this - it appears it's possible for AP
users, maybe just Mastodon users, to have a negative followers count.
This causes fatal errors in Friendica, so I think we should sanitize
this input.
2021-07-14 10:15:19 -07:00
Hypolite Petovan fd37a57678
Merge pull request #10496 from annando/subscribe
Subscribe to contacts from a remote AP account
2021-07-14 06:45:25 -04:00
Hypolite Petovan be18a59bd7 Make last status parameter actually optional in Object\Api\Mastodon\Conversation 2021-07-13 23:02:11 -04:00
Michael 0277589fbd Removed experimental code 2021-07-14 02:59:29 +00:00
Michael 6fceab0cc8 Merge remote-tracking branch 'upstream/develop' into subscribe 2021-07-14 02:54:12 +00:00
Hypolite Petovan 2b5f1f8bca
Merge pull request #10493 from annando/api
Improve how shared posting look on mobile apps
2021-07-13 22:48:31 -04:00
Michael 5526421607 Issue 10491: Possibility for simple shortening added 2021-07-13 22:37:22 -04:00
Michael b4e4378568 Merge remote-tracking branch 'upstream/develop' into api 2021-07-14 02:28:37 +00:00
Hypolite Petovan 999a394b4d
Merge pull request #10490 from annando/fatal
Fix Uncaught TypeError: Argument 1 passed to Friendica\Model\Item::storeForUserByUriId()
2021-07-13 21:01:53 -04:00
Michael ff8f350a42 Change the BBCode version 2021-07-13 20:37:06 +00:00
Michael 875a6b81ef Improve links for API 2021-07-13 14:40:10 +00:00
Michael 267b652857 Improve how shared posting look on mobile apps 2021-07-13 08:30:05 +00:00
Michael 1466afe3b2 Automatically subscribe to the followings of a given AP account 2021-07-13 06:06:08 +00:00
Michael 299cff8c50 Defining return value 2021-07-12 20:06:35 +00:00
Michael aee652117c Definiing parameter type 2021-07-12 14:28:13 +00:00
Michael e5c312a066 Issue 10491: Possibility for simple shortening added 2021-07-12 14:11:51 +00:00
Michael 002df6e8d1 Fix Uncaught TypeError: Argument 1 passed to Friendica\Model\Item::storeForUserByUriId() 2021-07-12 07:02:01 +00:00
Michael e151a2dc41 Fixes "Undefined index: nick" 2021-07-12 06:25:48 +00:00
Michael 219534e88c Accepting "null" as parameter value 2021-07-11 14:37:17 +00:00
Michael 7390791d21 Avoid problems with "null" values 2021-07-11 11:11:03 +00:00
Michael d267ba999c We now use the new account-user-view (and fixed the function name) 2021-07-11 09:39:34 +00:00
Michael b46b88cc10 Fix fatal error 2021-07-10 21:08:55 +00:00
Michael 07d2dfcd60 Some more "convertForUriId" replacements 2021-07-10 12:58:48 +00:00
Michael 161fa4a795 Post update: Set "uri-id" in the contact tables 2021-07-10 01:41:26 +00:00
Michael de39091a79 Revert some test changes 2021-07-09 19:32:06 +00:00
Michael 90897f36ca Fix notices because of unknown Hubzilla activity type 2021-07-09 19:30:41 +00:00
Michael d6c1e1fd1c Fix "Undefined index: reply-to-id" 2021-07-09 18:10:48 +00:00
Michael e0fdde3287 Fix the tests, hopefully 2021-07-09 17:13:54 +00:00
Michael 04580ad4fb Don't update automatically to make tests happy 2021-07-09 16:20:22 +00:00
Michael 0735a22cdd Fix notice "undefined index: uri" 2021-07-09 14:52:22 +00:00
Michael 9ac284ec3a Update on empty uri-id 2021-07-09 08:46:42 +00:00
Michael b50a92cf7a Contact tables added to expire function 2021-07-09 08:08:48 +00:00
Michael 6e79da0b0c The uri-id is now in all contact tables 2021-07-09 07:09:33 +00:00
Michael c63d3f4604 Fix tests 2021-07-09 06:37:45 +00:00
Michael d8974c9a2a Function renamed to better reflect the functionality 2021-07-09 06:29:24 +00:00
Michael 17ae9b71af Avoid error on empty content 2021-07-09 04:42:01 +00:00
Michael 88f147c6a7 Always update on missing uri-id, check for uri-id in contact before removal 2021-07-09 04:38:36 +00:00
Michael 377bb78cc2 Set "convertForItem" at more places 2021-07-08 20:01:52 +00:00
Michael 901c3f4855 we now have got an uri-id field for the contact table 2021-07-08 18:59:58 +00:00
Michael 178bc543e3 New founction to count threads 2021-07-08 17:32:41 +00:00
Michael c972cce740 Avoid notice 2021-07-08 16:38:02 +00:00
Michael e72e74f7db Fixed function name 2021-07-08 15:44:55 +00:00
Michael 165c6ddc63 "convert" changed to "convertForItem" 2021-07-08 15:41:46 +00:00
Michael f29bd23ea8 New function to convert BBCode for a given ID 2021-07-08 13:47:46 +00:00
Michael f3452d86c4 Improved logging, improved link check 2021-07-06 17:40:40 +00:00
Michael ecf0b67d9d Just look at HTTP links 2021-07-06 16:10:10 +00:00
Michael 234bdff7ab Improved link check 2021-07-06 15:06:15 +00:00
Michael 37a76e70ef Providing the uri-id to "convert" when possible 2021-07-06 12:34:48 +00:00
Michael 098cd543ea Cleaned code for contact avatars 2021-07-06 10:36:00 +00:00
Michael d0136222e7 Further simplification 2021-07-06 09:24:25 +00:00
Michael 12173df4d3 Replace proxy function 2021-07-06 09:22:41 +00:00
Michael 8bfa15cf23 Simplify the attachment handling 2021-07-06 08:57:49 +00:00
Michael b7a4ef0ec1 Modfy links for attachments 2021-07-06 08:40:59 +00:00
Michael 93309a3728 Quit on empty uri-id 2021-07-06 06:45:53 +00:00
Michael dac27ead7a Proxy settings removed 2021-07-06 06:44:18 +00:00
Michael cdc18387fd Use the uri-id directly in the bbcode converter 2021-07-06 05:25:30 +00:00
Michael f8ce59b411 Use the post uri-id for false reshares 2021-07-06 04:36:45 +00:00
Michael 3deb384c54 Replace the proxify function 2021-07-05 21:35:57 +00:00
Michael db90e3bf25 Remove attachment on plaintext conversion 2021-07-05 20:20:39 +00:00
Michael 903c646a62 Style 2021-07-05 19:42:17 +00:00
Michael aed5e4cc96 New struture for post related links 2021-07-05 18:45:49 +00:00
Michael 90588ddb8e Avoid proxyfying images that are removed or replaced later 2021-07-05 07:00:35 +00:00
Michael a5176cb841 Unused constant removed 2021-07-05 05:41:05 +00:00
Michael fccb725651 Unneeded workaround removed 2021-07-05 05:11:35 +00:00
Michael a06d699480 Item cache related functionality removed 2021-07-05 04:57:50 +00:00
Michael 844727dc19 Simplyfying code 2021-07-05 04:16:02 +00:00
Michael 7188ed745c Merge remote-tracking branch 'upstream/develop' into proxy 2021-07-05 03:44:15 +00:00
Michael b09f555f4f Merge remote-tracking branch 'upstream/develop' into notice 2021-07-05 03:03:41 +00:00
Michael 1b6d0f8b1f Fix notice "Undefined index: account-type" 2021-07-04 21:26:08 +00:00
Michael e519b782fd Simplified proxy handling 2021-07-04 21:24:49 +00:00
Michael dfc1b1e7a5 Allow search for only locally published contacts 2021-07-04 19:58:02 +00:00
Tobias Diekershoff 2b95a7e7cd Merge branch 'stable' into develop 2021-07-04 20:52:22 +02:00
Michael f0268b57be Use "getOwnerDataById" and "getOwnerDataByNick" to fetch owner data 2021-07-04 17:25:08 +00:00
Hypolite Petovan 638723ea1c
Merge pull request #10466 from annando/local-follow
Ensure that the network is set for "self" contacts
2021-07-04 12:21:21 -04:00
Michael 582fd613e0 Ensure that the network is set for "self" contac ts 2021-07-04 14:17:10 +00:00
Hypolite Petovan b84c68f024
Merge pull request #10465 from annando/local-follow
Fix local follow (and local contact data update)
2021-07-04 10:15:10 -04:00
Hypolite Petovan bedc8e1427
Merge pull request #10463 from annando/proxy-security
Proxy: Avoid access for not logged in users
2021-07-04 10:12:36 -04:00
Hypolite Petovan c0579bcad9
Merge pull request #10462 from annando/duplicate-avatars
Removal of duplicated photo entries for a contact
2021-07-04 09:56:47 -04:00
Michael 74a0bfc6da Ensure to not update the "self" contact 2021-07-04 12:38:35 +00:00
Michael 87cc17337b Fix local follow (and local contact data update) 2021-07-04 12:35:48 +00:00
Michael 24f013a654 Redirecting not logged in user instead of failing 2021-07-04 11:53:49 +00:00
Michael 4f6be0bd03 Function only needs to be private 2021-07-04 10:59:24 +00:00
Michael da484a48e3 Proxy: Avoid access for not logged in users 2021-07-04 10:55:32 +00:00
Michael 47904f99c2 Removal of duplicated photo entries for a contact 2021-07-04 10:40:03 +00:00
Michael 5ee0f6e5e1 Transmit preview link 2021-07-04 06:30:54 +00:00
Michael 1da6fa0043 Issue 10352: Fixing photo entries for contact avatars 2021-07-03 20:43:00 +00:00
Michael f37e808e02 Fix test 2021-07-03 15:47:11 +00:00
Michael c72abe48a8 Fixed fetching private local images 2021-07-03 15:29:27 +00:00
Michael 9cf39dbf00 Quickfix for hashtags in usernames in shared posts 2021-07-02 04:34:49 +00:00
Michael 8e9433f2e9 Fix: Fetching of non public photos 2021-07-01 18:05:54 +00:00
Hypolite Petovan c63dfa38c1
Merge pull request #10451 from annando/contact-path
Some more places changed to the new contact avatar path format
2021-06-30 21:24:27 -04:00
Hypolite Petovan 7a2038fc93
Merge pull request #10452 from annando/notice
Avoid Notice: Undefined index: field1 in /src/Module/Register.php on line 253
2021-06-30 21:23:12 -04:00
Hypolite Petovan dfd711d111
Merge pull request #10450 from annando/discoverable
AP: Support "discoverable"
2021-06-30 21:16:11 -04:00
Michael 16de3454bc Change logo path 2021-06-30 20:00:57 +00:00
Michael b46ad72651 Fix media size 2021-06-30 19:55:28 +00:00
Michael df9a69db01 Avoid Notice: Undefined index: field1 in /src/Module/Register.php on line 253 2021-06-30 19:13:27 +00:00
Michael 98dd4e889a Some more contact paths 2021-06-30 18:44:41 +00:00
Michael 09aa496387 Some more places changed to the new contact avatar path format 2021-06-30 16:58:46 +00:00
Michael e2dc36a691 AP: Support "discoverable" 2021-06-30 05:40:11 +00:00
Michael ec49afa116 Guess the mimetype in advance 2021-06-30 04:28:03 +00:00
Michael 39fe60744b Grammar 2021-06-30 03:49:43 +00:00
Michael d2b32a151e Detect the mimetype for external resources 2021-06-30 03:47:53 +00:00
Michael 19aef93560 Unified avatar paths 2021-06-29 20:26:58 +00:00
Michael 9edc75e29d Improved avatar handling (timestamps for caching) 2021-06-29 06:15:45 +00:00
Michael ebb9e0c2f5 Fix resizing 2021-06-28 19:38:03 +00:00
Michael ffdbac7e41 Issue 10443: Fix requesting media content 2021-06-28 18:53:10 +00:00
Michael 2f06d271bb Use a default value for "uid" 2021-06-28 13:58:06 +00:00
Michael a1a584f444 External resources are cacheable 2021-06-28 13:09:00 +00:00
Michael 4f95622d73 Only user the user with attached media. 2021-06-28 12:40:58 +00:00
Michael 8ac9b37176 Merge remote-tracking branch 'upstream/2021.06-rc' into proxy2 2021-06-28 10:11:41 +00:00
Michael 6f350c1e59 Use signed requests for fetching private images 2021-06-28 10:08:51 +00:00
Michael 7e200174d6 Replace attachment links in the body 2021-06-28 04:53:20 +00:00
Hypolite Petovan 681c7c0187 Add ExternalStorage dependency to StorageManager
- Since ExternalStorage isn't instantiated automatically by Dice, we have to provide the dependency manually in StorageManager->getByName
- This requires StorageManager to take one one additional dependency
- Tests are updated with this additional dependency
2021-06-27 23:15:46 -04:00
Hypolite Petovan faac5b71ce
Merge pull request #10437 from annando/reduce-proxy
Reduce the usage of the "proxifyUrl" function
2021-06-27 22:41:14 -04:00
Michael dbf9132ea6 Fixed indendation 2021-06-28 01:34:29 +00:00
Hypolite Petovan 005ba8c388
Merge pull request #10435 from nupplaphil/feat/di_cleanup
Add constructor injection for ExternalResource Storage
2021-06-27 21:02:03 -04:00
Michael c89547aead Only proxify images 2021-06-27 19:06:05 +00:00
Michael b46b7b08ba Reduce the usage of the "proxifyUrl" function 2021-06-27 11:50:10 +00:00
Philipp b5acc07eaf
Add todo for develop phase 2021-06-26 21:17:10 +02:00
Michael de2898988b Inverted condition 2021-06-26 11:31:37 +00:00
Michael 258d5fa695 Issue 10433: Only notify when there had been changes 2021-06-26 11:29:58 +00:00
Philipp f1f3fa7216
Add constructor injection for ExternalResource 2021-06-25 20:13:50 +02:00
Michael Vogel d9d30d9555
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-06-25 20:00:59 +02:00
Michael ed4a18f079 Function to return the avatar and header path for a given contact id 2021-06-25 17:03:35 +00:00
Michael e6e90abc77 AOI: Send "history" section for trends 2021-06-24 22:15:25 +00:00
Michael 89608d5844 Set CORS header fields to support Halcyon 2021-06-24 18:02:29 +00:00
Michael ee25246e41 Standards 2021-06-24 17:37:50 +00:00
Michael 9276f6823b New class for external resources 2021-06-24 17:30:22 +00:00
Michael 96809b3fdd API: Improved avatar handling 2021-06-24 07:08:38 +00:00
Tobias Diekershoff cfc08cbc11 console autoinstall used parameter U twice
The parameter "-U" was used twice for the database user and for the URL.
As all other database parameters are using the lowercase letter for the
parameter, this was adopted for the dbuser as well.
2021-06-23 18:05:39 +02:00
Michael df05d6b52a Transmit mediaType for headers as well / use blank image for empty header 2021-06-22 13:58:29 +00:00
Michael dd39b3203b Transmit mediaType, preparation for header image 2021-06-22 03:17:41 +00:00
Hypolite Petovan 47cb89967f
Merge pull request #10420 from annando/usercount
Don't count the system user as user
2021-06-21 08:46:56 -04:00
Michael 6b46fdb54e Don't count the system user as user 2021-06-21 04:03:20 +00:00
Michael d5e5a6ea23 Fix fatal error: Uncaught TypeError: Argument 1 passed to Friendica\Model\Post\Media::existsByURIId() must be of the type int, null given 2021-06-21 03:53:53 +00:00
Philipp 5a6c5e9a17
Fix wrong attachement index 2021-06-20 22:33:05 +02:00
Philipp d4387d45ee
Cleanup Code 2021-06-20 13:25:45 +02:00
Philipp 263774eb46
Satisfy PHP-CS 2021-06-20 13:25:45 +02:00
Philipp 322f0b3ecf
Cleanup Mastodon Factories 2021-06-20 13:25:45 +02:00
Michael 97891fe05b Context: use the correct "select functionality 2021-06-19 18:27:35 +00:00
Michael 7dd5ea42e9 An empty user id does not have children 2021-06-19 06:27:25 +00:00
Michael 09609c40a4 Classname fixed 2021-06-18 05:50:52 +00:00
Michael 7d835ad790 Unused "use" removed 2021-06-18 03:32:20 +00:00
Michael 0a5904a001 API: "created_at" is timestamp 2021-06-18 03:21:38 +00:00
Michael a2b1819721 Fix notice "Undefined index: url in .../src/Protocol/ActivityPub/Transmitter.php on line 611" 2021-06-17 18:48:23 +00:00
Michael Vogel b184df1108
Update src/Object/Api/Mastodon/Account.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-06-17 19:14:35 +02:00
Michael bd016dc680 Photos should point to the local system 2021-06-17 16:55:54 +00:00
Michael fe07dc828b Fix noscrape publishing and pulling, added header 2021-06-17 11:23:32 +00:00
Michael ebd4f59d02 Merge remote-tracking branch 'upstream/2021.06-rc' into public-timeline 2021-06-16 21:01:20 +00:00
Hypolite Petovan 7b91bd1d80
Merge pull request #10410 from annando/oauth
API: Added OAuth revoke, adding documentation to parameters
2021-06-16 16:32:45 -04:00
Michael Vogel a256f18159
Update src/Module/OAuth/Token.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-06-16 22:19:26 +02:00
Hypolite Petovan 59204d641d
Merge pull request #10409 from annando/api-link-header
Set the "Link" header
2021-06-16 16:16:35 -04:00
Michael 6b3476409a Check for REDIRECT_REMOTE_USER as well 2021-06-16 19:39:51 +00:00
Michael 5e22704f7e API: Added OAuth revoke, adding documentation to parameters 2021-06-16 19:24:44 +00:00
Michael 6e789ec19a No need for +1 and -1 2021-06-16 17:57:01 +00:00
Hypolite Petovan ead0cf370a
Merge pull request #10408 from annando/issue-10392
Issue 10392: Avoid "Friendica can't display this page at the moment"
2021-06-16 13:32:17 -04:00
Michael 78d4aff878 Set the "Link" header 2021-06-16 15:02:33 +00:00
Michael ae5f57233e Issue 10392: Avoid "Friendica can't display this page at the moment" 2021-06-16 13:23:07 +00:00
Michael 11d2440425 New functions for the post-view view 2021-06-16 10:16:01 +00:00
Michael 5211c12b0c Merge remote-tracking branch 'upstream/2021.06-rc' into public-timeline 2021-06-16 05:58:11 +00:00
Michael 3796e13142 Force a directory update if previously published 2021-06-16 05:23:43 +00:00
Michael 1ced04e54c Merge remote-tracking branch 'upstream/2021.06-rc' into profile-publish 2021-06-16 05:01:16 +00:00
Michael c17f23423f Chec for missing profile first 2021-06-15 22:01:30 +00:00
Michael e994d02791 Add a profile entry if missing 2021-06-15 21:39:28 +00:00
Michael 0ab24510ef Centzralized functionality to update and publish profile changes 2021-06-15 11:12:44 +00:00
Michael d348e4afca Possibly fixes notice "Undefined index: private in .../src/Model/Item.php on line 3115" 2021-06-14 18:34:11 +00:00
Hypolite Petovan c9ec2e21b3
Merge pull request #10403 from annando/doc-structure
Updated database structure documentation
2021-06-14 09:01:58 -04:00
Michael 7106106f11 Formatted index list 2021-06-14 12:15:10 +00:00
Michael 96f07c7288 Indexes and foreign keys added 2021-06-14 08:53:37 +00:00
Michael fd30df7300 Pad the header 2021-06-14 05:58:51 +00:00
Michael 4095e6c9be Pad the lengths of the columns 2021-06-14 05:33:47 +00:00
Michael a827f948c8 Reversed "null" 2021-06-14 05:14:09 +00:00
Michael 31db9dbef7 Added default value "NULL" 2021-06-14 05:08:01 +00:00
Michael bb5e6d248b Added sort order 2021-06-13 20:56:14 +00:00
Michael 84ab5d6159 Updates database structure documentation 2021-06-13 20:33:50 +00:00
Michael bf8cb39102 Diaspora relay functionality is removed 2021-06-13 11:15:04 +00:00
Simon Rupf 8b841ccc51 Reduce batch size for photo processing to reduce memory usage 2021-06-12 20:40:17 +02:00
Michael 24cc82f396 API: (hopefully) improves speed of the public timeline 2021-06-12 15:19:56 +00:00
Michael b7f12051a8 Small fixes 2021-06-12 11:19:23 +00:00
Michael c21cbd936e Changed sorting 2021-06-12 10:12:02 +00:00
Michael b8da971fac Server statistics: New section for relais and nomads 2021-06-12 08:08:35 +00:00
Michael 84028d7342 Proxify the media url 2021-06-11 03:51:11 +00:00
Michael 4ea30af752 Videos are now working as well 2021-06-10 19:55:43 +00:00
Michael 945f482ba3 API: Some more apps are now supported 2021-06-10 19:10:33 +00:00
Michael 6dc2988c0f Return the application fields 2021-06-10 08:05:21 +00:00
Michael 0b9c934cad Simplify the code 2021-06-10 07:02:06 +00:00
Michael d917ed58a8 API: Tests with various clients, small fixes 2021-06-10 06:26:34 +00:00
Michael 5e36d10730 Merge remote-tracking branch 'upstream/2021.06-rc' into http-options 2021-06-09 11:11:11 +00:00
Michael 4706d60b04 Added documentation 2021-06-09 07:44:19 +00:00
Michael c9b66d6e28 Deactivate CORS related headers 2021-06-09 07:42:23 +00:00
Michael 58a513cb30 Support HTTP OPTIONS requests 2021-06-09 07:27:42 +00:00
Michael 385c03364f The function is now protected again 2021-06-08 20:45:58 +00:00
Michael e4be1e0cd5 Get rid of "api_user()" function 2021-06-08 20:41:46 +00:00
Michael 8bf5dd187b Added "source" detection 2021-06-08 17:48:41 +00:00
Michael 0f0a301280 Move basic auth functionality to the new class 2021-06-08 17:32:41 +00:00
Michael 2a440c0bae Use "checkAllowedScope" instead of "login" 2021-06-08 12:00:22 +00:00
Michael 5853fe562d Login hasn't got a return value 2021-06-08 09:51:17 +00:00
Michael 9720ee2c20 Rearranged scope check 2021-06-08 09:11:56 +00:00
Michael 95cac04540 Rearranged function order 2021-06-08 08:56:01 +00:00
Michael 11c8dfe73a Unified request for uid 2021-06-08 08:28:14 +00:00
Michael 85217941e3 Simplified code 2021-06-08 08:04:12 +00:00
Michael 8cde7fe51f Standards 2021-06-08 07:37:28 +00:00
Michael 4b280a7279 Standards 2021-06-08 07:35:36 +00:00
Michael ca5e0eaaea Fix coding standards 2021-06-08 07:33:53 +00:00
Michael 126e281165 Improved documentation 2021-06-08 06:39:23 +00:00
Michael acbe9ebf9e API: New classes for OAuth and basic auth 2021-06-08 06:32:24 +00:00
Michael 265137ef44 Avoid PHP Warning: Illegal string offset 'type' in /src/Protocol/ActivityPub/Receiver.php on line 668 2021-06-07 10:21:48 +00:00
Michael 8e12c1d39b Added note about missing parameters 2021-06-07 07:45:20 +00:00
Michael dc9b5df072 API: The endpoints "followers" and "following" are swapped 2021-06-07 04:44:12 +00:00
Michael 038e505ca3 Improve forum delivery, avoid false distribution 2021-06-06 19:28:47 +00:00
Michael 3fd5c79025 Add the forum followers to forum posts 2021-06-06 13:25:42 +00:00
Michael 56f07d412b Addec comments on forum delivery 2021-06-06 10:07:21 +00:00
Michael 73b0af52fb Use "self" 2021-06-06 09:24:12 +00:00
Michael b269a2da87 Respect the "unlisted" setting for forum posts 2021-06-06 09:19:29 +00:00
Michael ace89197ff Display the forum posts in the new format. 2021-06-05 20:29:19 +00:00
Michael e2b8d5379b Public forums are now posting unlisted 2021-06-05 18:38:21 +00:00
Michael 8a9f633ce2 Merge remote-tracking branch 'upstream/2021.06-rc' into forum-handling 2021-06-05 06:14:06 +00:00
Michael 98c314599c Don't lose ownership on forum posting 2021-06-05 06:13:10 +00:00
Hypolite Petovan 11bc968294
Merge pull request #10368 from annando/more-api
API: some more endpoints added
2021-06-04 15:30:52 -04:00
Michael 5ddd2f3ab5 Coding standards 2021-06-03 05:18:22 +00:00
Michael 4206c5d363 API: some more endpoints added 2021-06-03 04:47:02 +00:00
Tobias Diekershoff ed3d32f0e2
Merge pull request #10367 from annando/old-api-oauth
Support OAuth for the legacy API
2021-06-03 06:36:03 +02:00
Michael 9c59bcb6a5 Support OAuth for the legacy API 2021-06-02 22:11:21 +00:00
Michael 5df1b59bb3 Fix "Undefined index: post-type in .../src/Model/Item.php on line 2888" 2021-06-02 17:43:30 +00:00
Hypolite Petovan 86d56c7f57
Merge pull request #10361 from annando/limit-context
Simplify the code
2021-06-02 09:11:11 -04:00
Hypolite Petovan b47ae829f7
Merge pull request #10360 from annando/limit-context
API: Limit the elements for the context
2021-06-02 07:13:39 -04:00
Michael 4d19a6f0e3 Simplify the code 2021-06-02 07:15:42 +00:00
Michael a2be7e386f API: Lim it the elements for the context 2021-06-02 07:11:18 +00:00
Michael e7bc908655 Renaming the date format to "JSON" 2021-06-02 03:32:42 +00:00
Michael 4e164690d5 Use the proper way to display milliseconds 2021-06-02 03:19:55 +00:00
Michael 5bd51b156a API: Fix date format 2021-06-01 22:32:05 +00:00
Michael d3833f63e0 Fix account id of notifications 2021-06-01 22:00:12 +00:00
Michael 842cbbaf09 Added notifications for follow requests 2021-06-01 21:13:16 +00:00
Michael 49459821be Renamed function 2021-06-01 14:23:12 +00:00
Michael 3f0937dd42 API: Show activity notifications 2021-06-01 05:51:03 +00:00
Hypolite Petovan d99286640d
Merge pull request #10348 from annando/fix-diaspora-comment
Fix commenting on mobile to Diaspora
2021-05-31 19:27:53 -04:00
Michael 58531a2748 Fix tests 2021-05-31 20:02:53 +00:00
Michael be7a01f086 Fix commenting on mobile to Diaspora 2021-05-31 19:39:50 +00:00
Hypolite Petovan 52cf924558 Check for post-type key existence in Model\Item::addVisualAttachments
- Address https://github.com/friendica/friendica/issues/10169#issuecomment-844324800
2021-05-31 08:29:50 -04:00
Hypolite Petovan 303c9d4a54 Check Content\Item::replaceTag return for false return value before using it
- Address https://github.com/friendica/friendica/issues/10169#issuecomment-835547443
- Remove unused code in Content\Item::replaceTag
2021-05-31 08:29:50 -04:00
Hypolite Petovan 302070875c Ensure nodeinfo-provided protocols are strings in Model\GServer::parseNodeinfo2
- https://github.com/friendica/friendica/issues/10168#issuecomment-828281803
2021-05-31 00:47:03 -04:00
Philipp bdc2cd000b
Update avatar after user creation 2021-05-30 20:47:21 +02:00
Michael 2df14fab3b Ensure that the public contact exists when a user is created 2021-05-30 12:04:26 +00:00
Hypolite Petovan 9b9449c03c
Merge pull request #10340 from annando/relevant-url
Add relevant link after media links had been removed
2021-05-30 07:50:43 -04:00
Hypolite Petovan 15581ba91f
Merge pull request #10338 from annando/issue-9923
Issue 9923: Fix DB Error 1055
2021-05-30 07:48:49 -04:00
Michael 6f730bd671 Add relevant link after media links had been removed 2021-05-30 06:13:20 +00:00
Michael c05c447d0f Avoid warning "array_merge(): Expected parameter 2 to be an array, null given" 2021-05-29 22:48:06 +00:00
Michael 4cdfcb5cfb Avoid DB Errors with "group by" 2021-05-29 21:51:33 +00:00
Michael 6c90005363 Issue 9923: Fix DB Error 1055 2021-05-29 21:28:40 +00:00
Michael da20b48651 Fix PHP Notice: Undefined index: isForum in /src/Protocol/ActivityPub/Processor.php on line 605 2021-05-29 19:09:41 +00:00
Hypolite Petovan 452ed8aa8c
Merge pull request #10332 from annando/calender-download
simplify the calendar download
2021-05-29 13:46:41 -04:00
Michael 0249048534 More logging for the contact discovery 2021-05-29 17:24:50 +00:00
Michael a9302c30c3 simplify the calendar download 2021-05-29 17:09:45 +00:00
Hypolite Petovan b621d2c714
Merge pull request #10329 from annando/unified-request
API: Unified request parameter handling
2021-05-29 10:53:16 -04:00
Michael Vogel 1ca58968f2
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-29 14:32:31 +02:00
Michael b28acc7dad Improved logging for local probing, avoid worker fork 2021-05-29 11:11:26 +00:00
Michael c3c6f3c8d3 Code style conventions 2021-05-29 10:40:47 +00:00
Michael 97356ed617 API: Unified request parameter handling 2021-05-28 06:10:32 +00:00
Michael ce8e5012e9 Fix reshare of Diaspora posts only with pictures 2021-05-27 19:58:18 +00:00
Hypolite Petovan 7af91bafec
Merge pull request #10324 from annando/issue-10262
Issue 10262: Don't accept BCC posts from non followers
2021-05-27 11:40:14 -04:00
Michael c076545e3b API: Only show "bookmarked" on top level post 2021-05-27 10:49:15 +00:00
Michael 8b3884b2de API: Bookmarked posts are starred, not pinned 2021-05-27 07:51:30 +00:00
Michael 403cce25c4 Follower is sharer instead 2021-05-27 04:00:38 +00:00
Michael a3c323b366 Issue 10262: Don't accept BCC posts from non followers 2021-05-26 20:52:39 +00:00
Hypolite Petovan 8c99d3acc1
Merge pull request #10323 from annando/issue-10306
Issue 10306: Improve local delivery
2021-05-26 14:24:24 -04:00
Michael c6a56985a8 Changed comments 2021-05-26 18:15:07 +00:00
Michael 76e6a71822 Setting the post reason 2021-05-26 14:29:50 +00:00
Michael 016911a20c Setting the post reason and causer 2021-05-26 14:21:28 +00:00
Michael 785f8124ed Issue 10306: Improve local delivery 2021-05-26 09:24:37 +00:00
Philipp 681f55315b
Downgrading PHP 7.4 incompatible fread/fwrite checks 2021-05-25 20:21:51 +02:00
Michael ee5209a847 Improved logging 2021-05-25 13:18:48 +00:00
Michael 09f29cd577 Avoid notices because of empty fields 2021-05-25 13:11:23 +00:00
Michael 4d4544ada3 Separate the char from the binary handling 2021-05-24 20:07:39 +00:00
Michael da8d5f5015 Issue 9926: Limit the length of data to store in the apcontact table 2021-05-24 19:44:24 +00:00
Hypolite Petovan 6ef9ccbb97
Merge pull request #10311 from fabrixxm/fix/consoleautoinstall
console autoinstall: handle `-f/--file` as single config file
2021-05-24 10:30:45 -04:00
fabrixxm c45a1d1e4d autoinstall: compact output 2021-05-24 15:27:23 +02:00
fabrixxm 613cdf7ee1 autoinstall: handle -f/--file as single config file
as help string says.
2021-05-24 15:21:24 +02:00
Michael 32d0d45adf Issue 10287: Don't show ignored and blocked posts 2021-05-24 10:51:21 +00:00
Hypolite Petovan de2c43ce4b
Merge pull request #10294 from annando/http-input-data
New class to process HTTP input data
2021-05-24 06:11:23 -04:00
Michael 6e1402f7bd Calling it static 2021-05-24 08:08:01 +00:00
Michael 3e303fb366 Test file uploads 2021-05-24 07:43:42 +00:00
Michael ca5fd01f75 Transmit encoding, deactivated file test 2021-05-24 05:33:34 +00:00
Michael 7b49117801 Return data should be array 2021-05-24 05:22:25 +00:00
Hypolite Petovan a24febb8b6
Merge pull request #10283 from very-ape/fix-message-button
Fix message button using a more targeted approach.
2021-05-23 18:49:21 -04:00
Philipp 15216266d9
Add ContentType Injection for HTTPInputData tests 2021-05-23 22:40:41 +02:00
very-ape 7776c5f690 Implement code changes from review. 2021-05-23 13:25:25 -07:00
Michael a69e128fe4 Merge remote-tracking branch 'upstream/2021.06-rc' into http-input-data 2021-05-23 20:17:50 +00:00
Philipp c064a39341
Adapt tests using a content file 2021-05-23 20:30:27 +02:00
Philipp a0da84b6b0
Enable testability for HTTPInputData and create a failing test for it :-) 2021-05-23 19:58:09 +02:00
Michael 4ac68394c3 Fix warning "reset() expects parameter 1 to be array, null given" 2021-05-23 16:37:34 +00:00
Hypolite Petovan 48a783c91a
Merge pull request #10300 from annando/issue-10264
Issue 10264: Remote comments for visitors
2021-05-23 12:00:53 -04:00
Tobias Diekershoff 0ca929dccd
Merge pull request #10304 from annando/fix-emptymissing-photos
Fix missing media on posts to Mastodon
2021-05-23 15:34:34 +02:00
Michael 36c5e360f6 Fix missing media on posts to Mastodon 2021-05-23 13:29:25 +00:00
Michael b7a7ae58e9 Issue 10232: Improved search for embedded media links 2021-05-23 12:35:05 +00:00
Hypolite Petovan 4d214bd9cb
Merge pull request #10292 from annando/fix-mail
Fix inserting mails
2021-05-23 07:39:00 -04:00
Hypolite Petovan 0238a15809
Merge pull request #10295 from nupplaphil/bug/php7_cs
Fix PHP 7.0 Coding Standards
2021-05-23 07:38:38 -04:00
Michael 050bc673aa Issue 10264: Remote comments for visitors 2021-05-23 10:39:11 +00:00
Michael 8f9033633c Issue 10287: Make block and ignore work for the API as well 2021-05-23 08:56:24 +00:00
Tobias Diekershoff 55dda47f39 Issue 10293: mention the required function in the error message 2021-05-23 07:50:32 +02:00
Michael Vogel d00a4eacdc
Update src/Model/Mail.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-23 07:37:17 +02:00
very-ape b2bc911eb2 Merge branch 'fix-message-button' of https://github.com/very-ape/friendica into fix-message-button 2021-05-22 15:32:08 -07:00
very-ape ceb409dae8 Replace $contact with $profile_contact in sidebar function. 2021-05-22 15:30:46 -07:00
Philipp 965cd8b096
Fix PHP 7.0 Coding Standards 2021-05-22 23:47:35 +02:00
Michael fd3706b72e Coding standards again 2021-05-22 20:33:26 +00:00
Michael 684f9cdb96 Coding standards 2021-05-22 20:31:50 +00:00
Michael 2c6db3ccac Coding standards 2021-05-22 20:29:15 +00:00
Michael 6f44476c56 Merge remote-tracking branch 'upstream/2021.06-rc' into http-input-data 2021-05-22 20:26:32 +00:00
Michael c18cbe95a6 Fix inserting mails 2021-05-22 18:20:11 +00:00
Tobias Diekershoff 83cb4edc36
Merge pull request #10291 from annando/no-summary
Don't create automated summaries
2021-05-22 18:17:43 +02:00
Michael 77092157fe Don't create automated summaries 2021-05-22 16:11:10 +00:00
Michael ede808f449 Fixes "Undefined index: upubkey" by replacing the profile load mechanism 2021-05-22 15:50:05 +00:00
Michael a5c8c4d8b7 Fixes notice 2021-05-22 15:41:25 +00:00
Michael 6fe916a390 API: improved mail handling 2021-05-22 13:37:04 +00:00
Michael 0c21588ab9 Don't delete local tombstone contacts 2021-05-22 08:25:30 +00:00
very-ape bd9a469392
Merge branch '2021.06-rc' into fix-message-button 2021-05-21 23:40:49 -07:00
very-ape 34eb81a187 Don't retrieve a contact record we've already been given. 2021-05-21 22:49:35 -07:00
Michael 9d4b29d9c0 Fix for empty profile pages 2021-05-22 05:34:10 +00:00
very-ape c22ef3e79e Fix message button using a more targeted approach. 2021-05-21 14:28:01 -07:00
Hypolite Petovan 26d3f5433b
Merge pull request #10280 from very-ape/fix-message-button
Fix Message button.
2021-05-21 14:57:28 -04:00
very-ape 97a9ec4e40 Bug fix: last commit results in logged-in user's contacts being displayed on contact profile sidebar. 2021-05-21 11:38:50 -07:00
Michael 081652e09a Wrong class path 2021-05-21 18:00:03 +00:00
Michael bcb2073c9a New class to process HTTP input data 2021-05-21 17:36:51 +00:00
very-ape 93926e99b8 Use getByNickname as suggested in code review. 2021-05-21 10:15:32 -07:00
very-ape fe52719d37 Fix Message button. 2021-05-20 23:30:42 -07:00
Hypolite Petovan 315dddbcb9
Merge pull request #10277 from very-ape/authenticate-hook
Bug fix: allow authentication addons to create users again.
2021-05-20 15:05:55 -04:00
very-ape e2d93b57da
Update src/Model/User.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-20 11:54:30 -07:00
very-ape d66f1e30ae Apply suggestions from code review
Also clean up some code, make it less needlessly verbose.

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-20 11:35:33 -07:00
Hypolite Petovan 0e368c4ba4 Fix display of RTL tags 2021-05-20 08:39:36 -04:00
Hypolite Petovan 93f3c511dc Fix wrong display of mentions in RTL context 2021-05-20 08:39:36 -04:00
very-ape c89241dbd8 Bug fix: add missing changes. 2021-05-20 00:19:09 -07:00
very-ape 9ab57de356 Bug fix: allow authentication addons to create users again. 2021-05-20 00:16:08 -07:00
Tobias Diekershoff 57ff3e3a07
Merge pull request #10276 from annando/api-conversations
API: Support for private mails
2021-05-20 09:13:50 +02:00
Michael f5f919aead Coding standards 2021-05-20 06:58:15 +00:00
Michael e10f3f26b9 Removed unused parameter 2021-05-20 04:44:45 +00:00
Michael db8b0b9666 The next mail endpoint is done 2021-05-20 04:39:45 +00:00
Michael 8a3db0226b Coding standards 2021-05-20 03:53:48 +00:00
Michael 66ad777f4b Supporting all parameters 2021-05-19 22:33:40 +00:00
Michael 3d65ef3af2 Indentions 2021-05-19 22:20:56 +00:00
Michael d46150f1dc Whitespaces ... 2021-05-19 22:18:30 +00:00
Michael ae6dae3b23 Whitespace removed 2021-05-19 22:10:05 +00:00
Michael c1212dce03 Indentions 2021-05-19 22:09:25 +00:00
Michael 70259965df API: Support for private mails 2021-05-19 21:56:50 +00:00
Hypolite Petovan 09cf32926d
Merge pull request #10275 from very-ape/authenticate-hook
Move the 'authenticate' hook deeper into the authentication flow so t…
2021-05-19 16:51:15 -04:00
very-ape 9ddaabc22d Move the 'authenticate' hook deeper into the authentication flow so that password authentication addons are consulted whenever a user's password needs confirming. 2021-05-19 13:11:31 -07:00
Michael fcc18de9c5 Unneeded spaces removed 2021-05-19 16:09:09 +00:00
Michael ab96e694df Removed unused use 2021-05-19 16:07:37 +00:00
Michael 1c7d1c7c47 New endpoint "verify_credentials" added 2021-05-19 09:35:08 +00:00
Michael 3172b0bcf2 Log API errors 2021-05-19 09:03:41 +00:00
Michael b3b9c51dbe Reduced log level 2021-05-19 07:02:12 +00:00
Michael 50ca38a0f7 Harmonized API parameters for all timeline endpoints 2021-05-19 06:55:08 +00:00
Michael e3d227f3c9 API: Parameter cleanup 2021-05-19 06:18:42 +00:00
Michael e5c1b90668 API: Reworked request parameter handling 2021-05-18 19:26:46 +00:00
Michael f935c1cf73 Restructured variable handling 2021-05-18 08:38:04 +00:00
Michael 724a61390f Coding standards 2021-05-18 07:23:18 +00:00
Michael 2252949bca Style stuff ... 2021-05-18 07:18:31 +00:00
Michael f31fdf4391 Spaces 2021-05-18 07:13:32 +00:00
Michael 8ae29eabe8 Min is max 2021-05-18 07:02:50 +00:00
Michael 0a6127ea6e Set maximum value 2021-05-18 07:01:23 +00:00
Michael ce427b248e Central function to process request parameters 2021-05-18 06:31:22 +00:00
Michael 32e7ddf21b Improved parameter assignment 2021-05-18 04:54:37 +00:00
Michael 71a398277d Improved query 2021-05-17 22:44:42 +00:00
Michael 59cff3511b Standards 2021-05-17 22:31:35 +00:00
Michael c9110e03e1 API: Search endpoint 2021-05-17 22:22:51 +00:00
Michael 916c51c630 Fix fatal errors / added some API todo 2021-05-17 19:20:31 +00:00
Michael d46db31475 Reverted context 2021-05-17 06:04:48 +00:00
Michael 48d703d278 Fiy missing "in" 2021-05-17 06:03:14 +00:00
Michael 2e6cf056c1 Whitespace removed 2021-05-17 06:01:47 +00:00
Michael cb7206d92f Reverted yesterdays panic coding 2021-05-17 05:59:41 +00:00
Michael ce6b4c27ea Use locally stored original w3c documents 2021-05-17 05:51:14 +00:00
Michael 96ae7ce525 Merge branch 'apcontact-no-normalize' of github.com:annando/friendica into apcontact-no-normalize 2021-05-16 20:58:19 +00:00
Michael c21d991208 Use local copy of the w3id security context 2021-05-16 20:58:11 +00:00
Hypolite Petovan a44cf44708
Remove duplicated conditions, improve variables names in Model\APContact 2021-05-16 16:10:22 -04:00
Michael 4b4218f516 Compact using a predefined context to fix content from Pleroma 2021-05-16 19:31:10 +00:00
Michael 6f2fcd2859 Don't use compacted data when parsing accounts 2021-05-16 16:41:07 +00:00
Hypolite Petovan a4a2f4616c
Merge pull request #10256 from annando/fix-ap
Quickfix for current Json-LD problems
2021-05-16 11:06:47 -04:00
Michael 5ea44960e0 Additional change to the quickfix 2021-05-16 14:59:02 +00:00
Michael 4c72d2c34a Quickfix for current Json-LD problems 2021-05-16 14:32:06 +00:00
Michael dd16bccbc8 Fix for sending content via connectors 2021-05-16 14:30:15 +00:00
Michael 14c1f7167a API: We now can upload photos 2021-05-16 09:56:02 +00:00
Michael 49207a8624 Added scope check 2021-05-16 07:37:11 +00:00
Michael 1cc341033f API: We now can post statuses via API 2021-05-15 22:40:57 +00:00
Michael f001f52e39 API: Fix relationships 2021-05-15 15:02:15 +00:00
Michael 78dab01696 "UpdateCredentials" dummy added (currently not working) 2021-05-15 12:13:03 +00:00
Michael 9c427cc05d Unused use 2021-05-15 10:59:22 +00:00
Michael 6a5083d918 Fixed message, relationships endpoint added 2021-05-15 10:55:41 +00:00
Michael b34ee320b0 API: Many item related endpoints added 2021-05-15 10:08:47 +00:00
Michael 45c2cc3887 API: Account actions 2021-05-14 21:51:32 +00:00
Michael 0aaaf8d6ef API: Support OAuth client credentials 2021-05-14 06:05:01 +00:00
Michael 55919dbd06 API: The instance record had got a malformatted value 2021-05-14 05:09:11 +00:00
Michael 6eb3874646 Merge remote-tracking branch 'upstream/develop' into api-lists-missing 2021-05-13 22:01:19 +00:00
Michael 8b841dfa50 Fix connection issues with AndStatus 2021-05-13 22:00:40 +00:00
Michael 3aa883f1e3 API: List handling, dummy endpoints 2021-05-13 21:15:32 +00:00
Tobias Diekershoff af1896f4d2
Merge pull request #10231 from MrPetovan/bug/warnings
Make birthday time comparison 32-bit safe in Protocol\DFRN
2021-05-13 17:58:59 +02:00
Michael 5219080149 Fix url comparism 2021-05-13 15:01:35 +00:00
Michael b18073d5a8 Repurposed OAuth frontend handling, store the scope 2021-05-13 14:58:55 +00:00
Michael 132e08edb8 Whitespaces ... 2021-05-13 11:33:07 +00:00
Michael 7975bc244d Refine OAuth flow 2021-05-13 11:26:56 +00:00
Michael 494e852c1a Removed old comment 2021-05-12 15:41:05 +00:00
Michael 9125d296a1 Improved error messages 2021-05-12 14:00:15 +00:00
Michael 8a5560ec8f Simplified null check 2021-05-12 12:40:45 +00:00
Michael 4a6d33e182 HTTP_AUTHORIZATION should be enough 2021-05-12 12:34:55 +00:00
Michael 8dccb66dec Display the application name 2021-05-12 12:19:15 +00:00
Michael 19a81d25d5 Added documentation headers 2021-05-12 12:08:30 +00:00
Michael 87f7e26638 Added documentation 2021-05-12 12:00:24 +00:00
Michael daa832fcf9 Formatting 2021-05-12 11:54:43 +00:00
Michael c3f28252ff Indention 2021-05-12 10:50:01 +00:00
Michael a23d108fa7 Session variable needs to be removed afterwards 2021-05-12 06:51:59 +00:00
Michael 6ca42512e9 OAuth connections now have to be ackknowledged 2021-05-12 06:50:27 +00:00
Michael c22846339a Improved error reporting 2021-05-12 05:30:21 +00:00
Michael d1e109d9be Improved error handling 2021-05-12 03:05:22 +00:00
Michael Vogel e99117ac22
Update src/Module/OAuth/Authorize.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-12 03:53:40 +02:00
Michael 4476634f6c Fix list of accounts 2021-05-11 23:39:08 +00:00
Michael 975c32116d Handling media in shared posts 2021-05-11 23:10:59 +00:00
Michael e9fe92a5d7 Merge remote-tracking branch 'upstream/develop' into api-again 2021-05-11 21:21:32 +00:00
Michael f5e98c8ecf Redirect at login does work 2021-05-11 21:04:45 +00:00
Hypolite Petovan cac038639d Capitalize post action translation strings 2021-05-11 16:01:07 -04:00
Michael 8eacfbc570 Fix context order / notice fixed 2021-05-11 19:53:19 +00:00
Michael bade0a2345 Improved cards handling, simplified Bearer handling 2021-05-11 19:15:05 +00:00
Michael 7d8c152aaf Check the start of the string 2021-05-11 13:17:48 +00:00
Michael 74f3c885bf use "random_bytes" instead of "openssl_random_pseudo_bytes" 2021-05-11 13:12:12 +00:00
Hypolite Petovan aeef4960a1 Make birthday time comparison 32-bit safe in Protocol\DFRN
- Address https://github.com/friendica/friendica/issues/10168#issuecomment-838221234
2021-05-11 08:10:25 -04:00
Michael cfb9b73205 Store creation date 2021-05-11 08:16:40 +00:00
Michael 0f4920dca8 Unused use 2021-05-11 06:34:31 +00:00
Michael a3d1423562 unused use 2021-05-11 06:33:18 +00:00
Michael c9e6fea74b Code style 2021-05-11 06:31:48 +00:00
Michael 82003bbe47 Login prototype 2021-05-11 06:30:20 +00:00
Tobias Diekershoff 7789ea2507
Merge pull request #10228 from MrPetovan/bug/warnings
[PHP 8] Fix undefined template variables
2021-05-11 06:10:29 +02:00
Hypolite Petovan 10e5630988 Don't assume $a->contact is populated in Object\Post::getCommentBox
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-837238584
- This might reveal some side-effect
2021-05-10 22:03:51 -04:00
Hypolite Petovan 48ac619599 Check unparseURL parameter type in APContact::getByURL
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-832421258
2021-05-10 21:52:26 -04:00
Hypolite Petovan 9ef9fc7c14 Skip URL-less mention terms in Object\Post::getDefaultText
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-830859710
- Added logging to troubleshoot deeper issue
2021-05-10 21:50:42 -04:00
Hypolite Petovan 412a0b3e1c Ensure JsonD data passed to ParseURL::parseParts is an array
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-827894961
2021-05-10 21:32:03 -04:00
Hypolite Petovan 43638fa29b Fix undefined variables in nav.tpl
- Reworked the nav_info hook to include the rest of the array keys defined in Nav::getInfo
- Replaced the theme-specific template variable nav.userinfo with the regular userinfo in frio nav.tpl
- Initialized all the nav array keys
2021-05-10 19:03:33 -04:00
Hypolite Petovan abc0616d33 Fix undefined variables in profile/vcard.tpl 2021-05-10 18:59:49 -04:00
Hypolite Petovan 2c6bf754d5 Fix undefined variables in wall_thread.tpl
- Remove unused "num_comments_text" template variable
- Remove unused "item.postops" template variable mention
2021-05-10 18:59:09 -04:00
Michael 6644d117f6 Indentions 2021-05-09 22:29:04 +00:00
Michael 1ee1507f3b Whitespaces ... 2021-05-09 22:26:32 +00:00
Michael 585d283ff9 Preparation for Oauth client registration 2021-05-09 22:23:21 +00:00
Michael a696b7f427 Renamed functions 2021-05-09 18:44:08 +00:00
Michael 591619e1d3 Unused use removed 2021-05-09 13:01:56 +00:00
Michael 1c6e915514 Media is now supported as well 2021-05-09 12:59:23 +00:00
Michael 6ac74f9cc9 Unused use removed 2021-05-09 12:05:22 +00:00
Michael 6cd7215d87 Formatting ... 2021-05-09 12:04:00 +00:00
Michael 6d3c82e54e Formatting 2021-05-09 12:01:44 +00:00
Michael 66be56e081 Some more formatting 2021-05-09 12:00:08 +00:00
Michael 6e9dd7641f Some more code styling 2021-05-09 11:58:27 +00:00
Michael 7a576111c7 Code styling 2021-05-09 11:56:34 +00:00
Michael f5c7f9670f Remove blanks 2021-05-09 11:54:34 +00:00
Michael cc5d4db6a3 Notifications are now supported as well 2021-05-09 11:50:05 +00:00
Michael 5bb5c44bd9 API: added account related endpoints 2021-05-09 09:35:51 +00:00
Michael 1e3182a896 And more formatting 2021-05-08 19:30:09 +00:00
Michael a0e455a493 Again formatting 2021-05-08 19:28:20 +00:00
Michael 4b4298b0f8 Some more formatting 2021-05-08 19:26:57 +00:00
Michael cce0d0c21b Formatting 2021-05-08 19:25:20 +00:00
Michael 3bbf543d25 API: Some more endpoints 2021-05-08 19:21:52 +00:00
Michael 7d1c43cf65 Formatting 2021-05-08 12:28:04 +00:00
Michael Vogel 31d70e02e0
Update src/Module/BaseApi.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-08 14:23:47 +02:00
Michael 054f6dedc1 /followes and /following is supported 2021-05-08 11:46:24 +00:00
Michael d842a4ff87 Suggestions are now supported as well 2021-05-08 11:03:50 +00:00
Michael c97cfd8a44 Removed unused use 2021-05-08 09:19:16 +00:00
Michael 6236870aa4 Add all required HTTP methods 2021-05-08 09:14:19 +00:00
Michael 4fdc1ae13a "/statuses/id" is now supported 2021-05-08 05:55:06 +00:00
Michael 9300395c6e "verify_credentials" is now partially supported 2021-05-08 02:52:44 +00:00
Michael d39983c8b7 We now support lists as well 2021-05-08 02:21:01 +00:00
Michael 0ea2241eed Support the "only_media" parameter 2021-05-08 01:52:23 +00:00
Michael 0468b7b3f9 Formatting 2021-05-07 21:35:07 +00:00
Michael 0a25349fbf Formatting 2021-05-07 21:33:42 +00:00
Michael dd38cc330f API: We now support two more timeline api endpoints 2021-05-07 21:28:48 +00:00
Michael 829a268faf Issue 10184: Fix directory search results 2021-05-07 18:38:04 +00:00
Michael 6be6803983 Improved code structure 2021-05-07 11:41:10 +00:00
Michael 95f741c427 Improve data of shared posts 2021-05-07 06:26:41 +00:00
Michael f683f791ee Avoid duplicated attachments / unwanted attachments 2021-05-05 16:46:55 +00:00
Michael 8f318e492e Don't transmit smiley links to external systems 2021-05-04 21:07:41 +00:00
Hypolite Petovan 53d4312903
Merge pull request #10202 from mexon/mat/contact-console-command
Add console contact command
2021-05-04 09:50:49 -04:00
Tobias Diekershoff 769834bf95
Merge pull request #10208 from MrPetovan/bug/10198-self-no-block-ignore
Prevent self block/ignore
2021-05-04 15:43:28 +02:00
Hypolite Petovan 0a1f4d81c8 Prevent self block/ignore in Module\Contact 2021-05-04 08:59:13 -04:00
Hypolite Petovan 98c2ca34f5 Remove block/ignore links from contact/item action menus for self 2021-05-04 08:45:27 -04:00