Commit Graph

1094 Commits

Author SHA1 Message Date
Philipp Holzer 03e149270b
bugfix 2019-04-14 14:40:26 +02:00
Philipp Holzer 58c9566c3d
code style & install-403 fix 2019-04-14 14:24:01 +02:00
Philipp Holzer d90eb6a811
Remove php_path duplicate in auto-install 2019-04-14 14:24:00 +02:00
Philipp Holzer 8fe606660d
trim whitespaces 2019-04-14 14:23:59 +02:00
Philipp Holzer 3a0664d827
fixing auto install tests 2019-04-14 14:23:58 +02:00
Philipp Holzer 677cb205f5
fix auto install 2019-04-14 14:23:58 +02:00
Philipp Holzer 90a38a00d8
Adding basepath, urlpath, hostname and ssl_policy to installation 2019-04-14 14:23:06 +02:00
Philipp Holzer fbd056327a
DBA-Logger fix 2019-04-13 20:46:58 +02:00
Hypolite Petovan 75387ea171
Merge pull request #6991 from fabrixxm/fix/invalid-storage-on-legacy
Allow set empty string storage class for legacy
2019-04-11 09:04:48 -04:00
Hypolite Petovan 9162f714e0 Add uri to missing session data logging context in Session handlers 2019-04-11 05:26:37 -04:00
Philipp Holzer dc48690ed5
Remove hostname blacklisting 2019-04-11 00:09:59 +02:00
fabrixxm 72bee45079 Revert b2794bb2c 'Allow set empty string storge class for legacy' 2019-04-10 08:35:44 +02:00
fabrixxm b2794bb2c9 Allow set empty string storge class for legacy
Legacy storage is defined by an empty string.
`StorageManager::setBackend()` now accept an empty string as a valid
backend storage.
2019-04-09 16:32:15 +02:00
Philipp Holzer 63660b6fc0
Removed unnecessary class 2019-04-09 08:31:19 +02:00
Philipp Holzer 318a3ca785
Create own base URL class which holds the whole base url business logic 2019-04-09 08:31:16 +02:00
Tobias Diekershoff c4fef79f32 Add subject to DB Update email 2019-04-08 10:55:18 +02:00
Michael 46a99a05a1 Remove the queue from the core 2019-04-05 18:04:39 +00:00
Hypolite Petovan cc64471e4c Sanitize addon path items 2019-03-31 21:53:08 -04:00
Hypolite Petovan b529c03a20 Sanitize theme path items
- Sanitize theme style/color/scheme path items
2019-03-31 21:52:48 -04:00
Hypolite Petovan 6aac84dc8e Add Theme::getAllowedList method 2019-03-31 21:41:38 -04:00
Philipp Holzer 363d6b72ae
wrong indent 2019-03-30 19:10:19 +01:00
Philipp Holzer 0a447cb61b
wrong indent 2019-03-30 19:08:47 +01:00
Philipp Holzer e0b1f4f251
Hardening ConfigUpgrade 2019-03-30 18:54:22 +01:00
Hypolite Petovan 09e03c9213
Merge branch 'develop' into task/6778-add-storage-move-to-cron 2019-03-27 14:13:42 -04:00
Hypolite Petovan ef0545645a
Merge pull request #6942 from annando/worker-fast-commands
Command based pre fetching of worker tasks
2019-03-27 09:28:15 -04:00
Michael 83ff2b0382 We don't need to escape values anymore 2019-03-26 21:58:03 +00:00
Michael 2e0697c70e Notifications do work now again 2019-03-26 21:55:48 +00:00
Hypolite Petovan 753b1e0f25
Merge pull request #6935 from nupplaphil/issue/missing_basepath
Fixing basepath issue
2019-03-26 08:23:50 -04:00
Philipp Holzer 040504dca9
fixing config value setting 2019-03-26 08:13:49 +01:00
Philipp Holzer 9ec29f1e8e
straight the config value check 2019-03-26 08:00:41 +01:00
Philipp Holzer 7d88b800b8
Fixing Basepath 2019-03-25 20:53:46 +01:00
Philipp Holzer d78598b64e
Fixing basepath issue 2019-03-25 09:39:33 +01:00
Hypolite Petovan 898f7e7e38 Add connector collapsible panel in permission
- Replace HTML string by structured array in jot_networks hook
- Add collapsed panel when there are more than two connectors
2019-03-24 22:40:50 -04:00
Hypolite Petovan 76414a5169
Merge pull request #6920 from nupplaphil/feature/basepath/hostname_config
Removing basepath/hostname from admin site settings
2019-03-24 20:15:13 -04:00
Philipp Holzer 23654ce566
Added Update checks
- Logging
- Console
- Admin overview
2019-03-24 22:51:30 +01:00
Philipp Holzer 3cf0cb71f1
Fixing tests 2019-03-24 20:41:11 +01:00
Philipp Holzer 49def0dc27
Adding ConfigFileSaver and tests 2019-03-24 13:47:35 +01:00
Hypolite Petovan 0c8c97171a Revert logic change in query in NotificationsManager->setSeen 2019-03-23 22:16:12 -04:00
Hypolite Petovan 410f34d7fd Add storage backend move cronjob
- Fix typos in Console\Storage and Worker\CronJobs
2019-03-23 21:47:33 -04:00
Philipp Holzer 383a6715c3
Added first version of ConfigCacheSaver 2019-03-23 19:34:54 +01:00
Michael a09c5b692c Command based pre fetching of worker tasks 2019-03-23 06:08:18 +00:00
Philipp c5cbba3416 Fix boolean value 2019-03-22 23:31:47 -04:00
Philipp Holzer 69fa6161e5 Refactor installer 2019-03-22 23:31:45 -04:00
Philipp Holzer 1a2527cdba Move AppMode 2019-03-22 23:22:32 -04:00
Jeroen De Meerleer 2d263b08e3 code style 2019-03-22 23:13:30 -04:00
Jeroen De Meerleer a01a53a9f0 Fixed notifications order 2019-03-22 23:13:29 -04:00
Philipp Holzer 25b6db6aca Moving Profiling to class 2019-03-22 23:07:39 -04:00
Philipp Holzer 8237e73e26 Adding REAMDEs to directories 2019-03-22 22:56:57 -04:00
Philipp Holzer 3261ffbd99 bugfix - mixed fields with condition 2019-03-22 22:56:56 -04:00
Philipp Holzer ec2c84a4e9 code lisibility & filter optimization 2019-03-22 22:55:48 -04:00
Philipp Holzer 4496df79ab Replace "q" calls 2019-03-22 22:55:48 -04:00
Philipp Holzer b2edb85588 Replace "q" calls 2019-03-22 22:55:48 -04:00
Hypolite Petovan 385e3a09f2 Add loop to console storage move
- Add timestamp to output messages
2019-03-20 00:42:50 -04:00
Hypolite Petovan 8ddbeb087f Add limit parameter to storage move query
- Fixes out-of-memory errors with large tables
- Add database statement closing
- Add meaningful variable names
- Remove useless DBA::isResult check
2019-03-20 00:41:57 -04:00
Hypolite Petovan 7e2e2f425e Check that provided class implements IStorage in StorageManager::setBackend
- Add notice in admin if setting value change failed
- Add notice in console if setting value change failed
2019-03-19 22:42:44 -04:00
Hypolite Petovan f225a6c51a Reformat code
- Reformat Console\Storage
- Reformat Core\StorageManager
- Simplify logic in Worker\CronJobs
2019-03-19 22:42:05 -04:00
Philipp Holzer b22ff7419e
refactor naming & superfluous check 2019-03-17 09:57:34 +01:00
Philipp Holzer 8c6e6b5dea
Fixing .htconfig 2019-03-16 20:31:10 +01:00
Philipp Holzer 1acd5c7d22
- Adding additional legacy .htconfig information 2019-03-16 20:06:53 +01:00
Philipp Holzer cf17c72fd7
Adapt Logging messages 2019-03-11 21:36:41 +01:00
Philipp Holzer 8a358d5c98
Add Logger entry 2019-03-11 21:27:36 +01:00
Philipp Holzer 9a60eab152
Skip update if already done 2019-03-11 21:21:01 +01:00
Hypolite Petovan a2ec9e676e
Revert "Avoid double update runs" 2019-03-09 18:28:48 -05:00
Philipp Holzer f7c7851c2d
replaced duplicate code with method 2019-03-09 20:50:06 +01:00
Philipp Holzer 20498d1d40
replaced duplicate code with method 2019-03-09 20:50:00 +01:00
Philipp Holzer 7047a13ffa
added phpdoc 2019-03-09 20:49:59 +01:00
Philipp Holzer e46a7cdf80
Avoid double update runs 2019-03-09 20:49:59 +01:00
Michael ea71a4e83a Refetch new jobs only once per execution loop 2019-03-08 20:39:58 +00:00
Tobias Diekershoff 5df246e9af
Merge pull request #6825 from annando/empty-spawn
Worker: Don't spawn without jobs
2019-03-08 07:26:22 +01:00
Michael d87abe9563 Worker: Don't spawn without jobs 2019-03-08 05:53:36 +00:00
Philipp Holzer 07bd4cec65
Fixing redis cachekey 2019-03-04 21:28:36 +01:00
Philipp Holzer d7426e697d
Fixing redis cachekey 2019-03-04 21:09:20 +01:00
Philipp Holzer 3e53dab817
Fixing redis cachekey 2019-03-04 21:00:41 +01:00
Michael f2560c42d1 Reduce the default maximum load for the worker to 20 2019-03-02 18:41:12 +00:00
Michael 9427d7f628 We have to fetch the data this way 2019-03-02 13:07:29 +00:00
Michael 16c2ae89e8 Sent update mails to administrators only once 2019-03-02 12:57:47 +00:00
Philipp Holzer 16ff5af221
Fix handling table name during storage move 2019-03-01 18:07:08 +01:00
Philipp Holzer 739449926c
'%' is deprecated 2019-02-27 20:30:08 +01:00
Philipp Holzer 4a47425bfd
admin mail list seems wrong escaped 2019-02-27 20:17:35 +01:00
Michael c3b12b63c8 Added some description, changed logger call 2019-02-27 09:49:26 +00:00
Michael 505a34d40e Log the time as decimal 2019-02-27 09:12:40 +00:00
Michael 78960d4bde Removed unneeded spaces 2019-02-27 09:11:37 +00:00
Michael 5e440aa035 The cron interval is minutes - so we have to convert it into seconds 2019-02-27 08:55:25 +00:00
Michael 0ee1ea5f29 The log text is now shorter 2019-02-27 08:41:45 +00:00
Michael 11e39da6cc And moving the block back to the old place 2019-02-27 07:08:44 +00:00
Michael e1cc7262de Respawing when quitting 2019-02-27 07:04:21 +00:00
Michael 528636c9f4 Using constants is nicer 2019-02-27 06:55:04 +00:00
Michael fb371e1048 Merge remote-tracking branch 'upstream/2019.03-RC' into worker2 2019-02-27 06:41:14 +00:00
Michael 40573120b9 Enhanced logging, stopping worker after cron lifetime 2019-02-27 06:36:19 +00:00
Hypolite Petovan 05d8bf6b54 Fix wrong use of array_shift in Core\Worker 2019-02-25 07:11:35 -05:00
Michael Vogel df5ea1fab0
Merge pull request #6732 from MrPetovan/bug/1777-fix-blocked-contact-group
Allow to remove blocked contact from groups
2019-02-24 14:30:36 +01:00
Hypolite Petovan 4e3f780621
Merge pull request #6740 from nupplaphil/issue/6503-force_update
Fixing force-flag for lock-release
2019-02-24 07:04:54 -05:00
Philipp Holzer d1c7815c4e
added whitespace 2019-02-24 12:51:58 +01:00
Philipp Holzer aae58815a8
Adjust update parameters:
-f|--force         Force the update command (Even if the database structure matches)
-o|--override      Override running or stalling updates
2019-02-24 12:24:09 +01:00
Michael 4bad2645e5 We should execute the worker job for normal situations ;-) 2019-02-24 10:52:40 +00:00
Michael ee300a7db6 Ensure that the database update will be processed anyway 2019-02-24 10:43:29 +00:00
Philipp Holzer 7ce549c294
fixing delete 2019-02-24 10:27:56 +01:00
Philipp Holzer 9b07132b80
Fixing force-flag for lock-releasing 2019-02-24 10:08:28 +01:00
Hypolite Petovan 7e499647e3 Add System::jsonError method for ajax call returns 2019-02-23 17:32:40 -05:00
Michael 7703875b55 Fixes "Undefined property: Friendica\App::$queue" 2019-02-23 16:08:02 +00:00
Hypolite Petovan 44953f045e
Merge pull request #6730 from nupplaphil/dba_reconnect
DBA::(re-)connect fix for basePath
2019-02-23 08:45:31 -05:00
Hypolite Petovan 1a0398a5b3
Merge pull request #6723 from nupplaphil/issue/6658-worker_id
Adding worker ID to log
2019-02-23 08:38:08 -05:00
Philipp Holzer a73235b6ee
Fixing DBA::(re-)connect() 2019-02-23 12:49:56 +01:00
Philipp Holzer 8760d89eb8
reverting back workerLogger to Logger 2019-02-23 10:24:22 +01:00
Philipp Holzer 5b2f394e3e
Fixing #issuecomment-456403983 2019-02-23 10:16:07 +01:00
Philipp Holzer 40e9bbeb88
cleanup 2019-02-23 00:53:31 +01:00
Philipp Holzer 13807129aa
fixing preload adapter 2019-02-23 00:23:41 +01:00
Philipp Holzer 1dee89f215
fixing tests and preload config 2019-02-23 00:09:57 +01:00
Philipp Holzer 8d56fb8fbe
bugfix marking of db-values 2019-02-22 23:57:04 +01:00
Philipp Holzer b47fc97b06
readded note 2019-02-22 23:55:13 +01:00
Philipp Holzer 16863c5d82
switched back to logger 2019-02-22 23:53:20 +01:00
Philipp Holzer 8c3aebc376
Bugfixings in Config
- replaced usage of "!<unset>!" with null-returns
- fixed bool settings (0/1)
- fixed overriding config-values
- fixed basepath problems
2019-02-22 23:51:13 +01:00
Philipp Holzer 9c12f3f226
Formatting logger to new style 2019-02-22 20:41:13 +01:00
Philipp Holzer cec6f49023
Removed unused code 2019-02-22 20:24:10 +01:00
Philipp Holzer ee37632695
Adding worker id & functionname to worker logs 2019-02-22 20:10:27 +01:00
Hypolite Petovan 4375edd63e
Merge pull request #6719 from annando/worker-scheduler
New scheduler mechanism - now to the correct branch
2019-02-21 16:12:19 -05:00
Michael 7810227040 Reverted test stuff 2019-02-21 19:34:12 +00:00
Michael 3450f12cba Changed log calls 2019-02-21 19:32:31 +00:00
Philipp Holzer c2176aad36
bugfix 2019-02-18 14:45:24 +01:00
Philipp Holzer 5127a113aa
set config_loaded with uid 2019-02-18 14:40:35 +01:00
Philipp Holzer 1194e9b41e
set config_loaded with uid 2019-02-18 14:34:30 +01:00
Philipp Holzer 5157084969
negative set 2019-02-18 14:10:04 +01:00
Philipp Holzer 2fc81898da
Preload Adapter Fix 2019-02-18 14:02:09 +01:00
Philipp Holzer f536107911
Fixing value check for configuration 2019-02-18 11:29:51 +01:00
Philipp Holzer 86aaa6565e
Fixing saveLog() 2019-02-18 11:29:51 +01:00
Philipp Holzer a3d6062476
check if value is set
get basepath with config instead cache
2019-02-18 11:29:42 +01:00
Hypolite Petovan 256e845c5d
Merge pull request #6641 from nupplaphil/config_followup
Config FollowUp
2019-02-17 17:56:31 -05:00
Philipp Holzer 0a318925a4
bugfixing adapter get() in case of no connection 2019-02-17 20:44:14 +01:00
Philipp Holzer ad1254c49c
performance improvement in case of db-load 2019-02-17 20:44:14 +01:00
Philipp Holzer e1d9d67632
renamed Logger::setLogger() to Logger::init() 2019-02-17 20:44:08 +01:00
Philipp Holzer 80f1feabe5
Refactoring Logging to use Configuration 2019-02-17 20:43:52 +01:00
Philipp Holzer eafcf3592d
Config FollowUp
- New Configuration (Config is now only holding the instance)
- New PConfiguration (PConfig is now only holding the instance)

- Config & PConfig-Adapter don't need "ConfigCache" anymore

- DB-Connection is now outside App->reload() for better dependency-chaining
2019-02-17 20:40:27 +01:00
Michael a1a1367d6e Added function description 2019-02-17 19:20:24 +00:00
Michael 061d959e7f Code cleanup 2019-02-17 18:55:17 +00:00
Michael 01d6ba85ff The number of workers per priority is now calculated dynamically 2019-02-17 03:22:29 +00:00
Philipp Holzer d87a6e5a67
fixed line intends 2019-02-17 02:09:39 +01:00
Philipp Holzer 88fd871844
refactoring & test fixing 2019-02-17 01:18:21 +01:00
Philipp Holzer 0a7861da65
Dependency of callstack moved one layer up 2019-02-16 23:17:10 +01:00
Philipp Holzer 5e6e1a8025
Introducing Profiler 2019-02-16 23:11:30 +01:00
Philipp Holzer 11a7f97fe7
friendica-6667 Installer needs to check fileinfo module 2019-02-16 22:17:34 +01:00
Michael 0845089a0f New scheduler mechanism 2019-02-16 15:03:37 +00:00
Philipp Holzer b321ef776d
added type-hint 2019-02-14 17:54:34 +01:00
Philipp Holzer 347d959f25
fixing #6652 Manual installer bricked 2019-02-14 17:44:17 +01:00
Michael ca529d9de7 The process id is currently not supported. 2019-02-14 13:30:41 +00:00
Michael e20a675953 The setting "worker_fetch_limit" now only has an impact on high priority processes 2019-02-14 06:53:04 +00:00
Michael f6e8246e75 Ensure that "strtotime" returns the correct timestamp 2019-02-12 06:42:45 +00:00
Hypolite Petovan 5cf5f33a1c
Merge pull request #6640 from annando/worker-stats
Fix worker statistics
2019-02-11 22:00:55 -05:00
Michael 742b472994 Fix: Workerqueue processes had been killed too early 2019-02-11 22:39:59 +00:00
Hypolite Petovan d6a82c6c2d
Merge pull request #6638 from Ixiter/develop-markdown-anchors
ACL network - fixed preselected acl items
2019-02-11 07:23:32 -05:00
Peter Liebetrau 3dede5dbd2 ACL network - fixed preselected acl items 2019-02-11 10:00:42 +01:00
Michael f65b35901e Fix worker statistics 2019-02-11 08:59:14 +00:00
Michael 5fc6c0ef38 Fix: Corected config value name 2019-02-11 04:39:24 +00:00
Philipp Holzer 199ceeadbf
Adding ConfigCacheLoaderTest 2019-02-10 13:39:48 +01:00
Philipp Holzer 2a42f8dded
Adding ConfigCacheTest 2019-02-10 12:30:13 +01:00
Hypolite Petovan b2c2971551
Merge pull request #6619 from annando/worker-again
Furtner improval of the worker speed
2019-02-09 19:50:35 -05:00
Michael 171cfe8f44 Furtner improval of the worker speed 2019-02-09 23:10:15 +00:00
Hypolite Petovan 337c02bd80 Cache config adapter connection status to reduce number of calls to DBA::isConnected() 2019-02-08 20:12:07 -05:00
Hypolite Petovan 3aa77685fc
Merge pull request #6611 from annando/worker-performance
Improved worker performance (changed keys, changed queries)
2019-02-08 17:46:04 -05:00
Michael 5e5a2c3cc1 Improved worker performance (changed keys, changed queries) 2019-02-08 21:48:41 +00:00
Philipp Holzer cb791024e4
Refactor ConfigMockTrait to mocked ConfigCache 2019-02-07 20:44:03 +01:00
Hypolite Petovan e6a7c52f7d
Add missing App parameter in addon (un)install calls
Follow-up to #6581 
Fixes https://github.com/friendica/friendica/issues/6386#issuecomment-461080531
2019-02-06 22:28:17 -05:00
Hypolite Petovan a0b14a46cb
Merge pull request #6581 from nupplaphil/config_refact
Config Refactoring
2019-02-06 09:57:41 -05:00
Michael b0411b46c4 Separate config options to display the worker jobs per minute 2019-02-06 07:37:45 +00:00
Philipp Holzer fcd7627c49
method refactoring & docblock 2019-02-06 00:02:25 +01:00
Philipp Holzer 7947db8537
codeblock updates 2019-02-05 23:58:38 +01:00
Philipp Holzer 3cd654e76f
bugfixing ini-loading 2019-02-05 23:47:40 +01:00
Philipp Holzer 62c79e1c4f
codeblock updates 2019-02-05 23:42:49 +01:00
Philipp Holzer d9e38be4df
Creating legacy config loading method 2019-02-05 23:36:01 +01:00
Philipp Holzer b79bd63231
move isDirectoryUsable to System 2019-02-05 22:30:18 +01:00
Philipp Holzer 6a9d73f7d9
Refactoring ConfigCacheLoader methods 2019-02-05 22:27:57 +01:00
Philipp Holzer 800dbc7f44
Removed implicit ::getApp() instance and added docblock 2019-02-05 21:54:55 +01:00
Philipp Holzer 4b82e47034
Moved addon directory constant 2019-02-04 09:33:55 +01:00
Philipp Holzer f779110154
Updating type-hints and some naming conventions 2019-02-04 09:32:13 +01:00
Philipp Holzer d78ac57514
Updating type-hints and some naming conventions 2019-02-04 09:30:48 +01:00
Philipp Holzer 1c51d7d22f
Typo at addon-directory-name ... 2019-02-04 02:21:23 +01:00
Philipp Holzer bdfe0c35fb
Typo at addon-directory-name ... 2019-02-04 02:14:20 +01:00
Philipp Holzer f2f8c97b7c
Bugfixing Addon-config 2019-02-04 02:06:15 +01:00
Philipp Holzer d6dd74690d
Bugfixing Config output for memcached_hosts[] 2019-02-04 01:19:01 +01:00
Philipp Holzer 90e88d6c35
Bugfixing AutomaticInstallation test 2019-02-04 00:04:16 +01:00
Philipp Holzer bc73d4bd2b
Adding descriptions 2019-02-03 23:39:30 +01:00
Philipp Holzer f3da5b3a2f
Bugfixing PConfig 2019-02-03 23:22:05 +01:00
Philipp Holzer 1e0e1674f2
4) Adding Factories to other entrypoints 2019-02-03 22:46:50 +01:00
Philipp Holzer 4af0119b73
3) Introducing ConfigFactory 2019-02-03 22:22:04 +01:00
Philipp Holzer 5c50684b50
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:32:31 +01:00
Philipp Holzer f40c57fc20
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:05:44 +01:00
Philipp Holzer d43a8184f4
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:04:41 +01:00
Philipp Holzer be6b229534
1) Refactor App->config[] into Core\Config 2019-02-03 18:54:25 +01:00
Philipp Holzer 433d6abe8c
Refactoring DBA-mocking tests
- Reducing DB-dependencies
- Creating DB-cache mocks
- Creating DB-lock mocks
- Switching to mocked dependencies for Cache/Lock/App
2019-02-02 19:03:15 +01:00
Hypolite Petovan 64847e7cc8 Fix types in doc blocks/prototypes 2019-01-23 09:06:58 -05:00
Hypolite Petovan 25b8628762 Fix missing new in throw calls in Core\StorageManager 2019-01-21 11:12:51 -05:00
Hypolite Petovan 78931afa6f Fix error message in Console\GlobalCommunityBlock 2019-01-21 11:12:50 -05:00
Hypolite Petovan 7f2dc40601 Fix potential bugs without expected behavior change
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Philipp Holzer 1b802548b2 revert phpdoc change 2019-01-21 10:54:41 -05:00
Philipp Holzer 9e0be97703 Bugfixing legacy loglevel 2019-01-21 10:54:41 -05:00
Philipp Holzer 282507922a Reset map function name 2019-01-21 10:54:41 -05:00
Philipp Holzer b5afd2a21d change regex for fail2ban 2019-01-21 10:54:40 -05:00
Philipp Holzer aa15c0e094 Bugfixing Monolog
- Default Loglevel for logs set to 'info'
- Default config level is set to 'notice'
- using 'notice' for auth-failures
- Bugfixing wrong usage of legacy 'log()'
2019-01-21 10:54:39 -05:00
Hypolite Petovan 4a95ca280d Remove unused code
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
Hypolite Petovan d1c6ec9718 Update namespaces declaration in include/
- Remove unused use statements
- Add required use statements
2019-01-21 10:44:45 -05:00
Hypolite Petovan 14e4ab544a Update namespace use calls in mod/ 2019-01-21 10:44:21 -05:00
Hypolite Petovan cb3f09ae4f Refactor namespaces
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
Hypolite Petovan 070aa016e0 Update more PHPDoc, including in include/ 2019-01-21 10:39:28 -05:00
Hypolite Petovan af9067a381 Update PHPDoc in mod/ 2019-01-21 10:39:27 -05:00
Hypolite Petovan 3282ce5389 Fix PHPDoc comments project-wide 2019-01-21 10:35:51 -05:00
Philipp Holzer 2e602afd3e Add Monolog 2019-01-21 10:10:40 -05:00
fabrixxm 518f28a7bf Small fixes
- Avoid an intermediate variable
- Use `rawContent()` in `Attach` module
- Small typo
2019-01-21 10:08:09 -05:00
Hypolite Petovan 2f49c4a058 Revert "Add monolog" 2019-01-21 10:08:09 -05:00
fabrixxm 24d7ffa3fe Update "storage" console command
add support to move data in 'attach' table
2019-01-21 10:00:48 -05:00
Philipp Holzer 6e48df2163 Refactor Loglevels 2019-01-21 10:00:46 -05:00
Philipp Holzer 6150c2fa9c Bugfixing 2019-01-21 09:59:11 -05:00
Philipp Holzer 8f9c0fe149 Adding Develop and normal Logging instances 2019-01-21 09:59:08 -05:00
Philipp Holzer fe8f0e0045 Add Monolog 2019-01-21 09:58:05 -05:00
Jeroen De meerleer 2bfc3d1a0c begone 2019-01-21 09:50:59 -05:00
Jeroen De Meerleer 33f7fd72ca Enable logged in users to force a certain language 2019-01-21 09:50:58 -05:00
Jeroen De Meerleer b440b4c338 Updated towards code standards 2019-01-21 09:50:58 -05:00
Jeroen De meerleer e0777b6bc9 forcing language by parameter 2019-01-21 09:50:58 -05:00
Hypolite Petovan 55e54bb950 Replace deprecated Addon::callHooks with Hook::callAll
- Update documentation
2019-01-21 09:50:56 -05:00
Hypolite Petovan 895b3abf32 Remove/replace killme() with *exit() 2019-01-21 09:49:17 -05:00
fabrixxm b2211d31b9 Fix StorageManager::move() 2019-01-21 09:12:37 -05:00
fabrixxm 8addcf9844 Fix storage backend class names
This should be tested on all supported PHP versions
2019-01-21 09:12:32 -05:00
fabrixxm 2f935a1fbf Fix unregister storage backend 2019-01-21 09:12:30 -05:00
fabrixxm f2b29f6591 Fix moving stored data 2019-01-21 09:12:30 -05:00
fabrixxm f7b6fef197 Code standards 2019-01-21 09:11:35 -05:00
fabrixxm 682456c7d1 Add move function to storage manager and console command 2019-01-21 09:11:35 -05:00
fabrixxm 4d9d62bcdb Add 'storage' console command
- list registered backend
- set backend
2019-01-21 09:11:34 -05:00
fabrixxm 6a0ed7c298 Add storage backend manager class 2019-01-21 09:11:34 -05:00
fabrixxm 7df3f117ac Photo model: fix docs, don't update "created" field
in store() if photo exists, don't update "created" timestamp
2019-01-21 09:10:47 -05:00
Michael c359c162a7 Issue 6282: Update the contact data regularly (including the network) 2019-01-16 21:39:56 +00:00
Hypolite Petovan a9b8eb4d56 Refactor Theme::getStylesheetPath to return faster if theme style.php doesn't exist 2019-01-12 02:26:16 -05:00
Hypolite Petovan abf20368b0 Rework Profile::getThemeUid to ignore query parameter and include $a->profile_uid
- Use new version in frio default.php file
- Use new version in Theme::getStylesheetPath
2019-01-12 02:23:01 -05:00
Hypolite Petovan 6d1bc974a0 Add time parameter for iOS Safari to stylesheet URL 2019-01-11 20:49:16 -05:00
Hypolite Petovan ffcd9fb78d
Revert "Change stylesheet path name for mobile browsers" 2019-01-11 20:01:42 -05:00
Tobias Diekershoff 6bc865ff4d
Merge pull request #6356 from MrPetovan/task/6355-add-password-rules
Add password rules
2019-01-10 10:37:32 +01:00
Michael 6ae6a8a983 Don't show deleted contacts, set new AP contacts as "pending" until they are accepted 2019-01-09 13:23:11 +00:00
Hypolite Petovan e447375cdd
Merge branch '2019.01-rc' into bug/6334-escape-get-app 2019-01-06 16:38:48 -05:00
Hypolite Petovan cb635fb3cb Change stylesheet path name for mobile browsers 2019-01-04 20:18:31 -05:00
Hypolite Petovan 5e1ceb57de Escape global namespaced get_app() calls
- Add deprecated status
2019-01-03 21:27:36 -05:00
Hypolite Petovan 61664ee659 Update usages of User::updatePassword
- Add password rules in mod/settings display
2019-01-01 01:15:52 -05:00
Tobias Diekershoff 7efde8e334
Merge pull request #6209 from MrPetovan/task/move-config-to-php-array
Remove util/ folder
2018-12-29 11:43:55 +01:00
Michael Vogel 94eca77041
Merge pull request #6315 from MrPetovan/bug/6309-add-fulltext-index-profile
Rework mod/match and mod/msearch
2018-12-27 18:04:06 +01:00
Hypolite Petovan fabc90e9dd
Merge branch '2018.12-rc' into task/move-config-to-php-array 2018-12-27 01:47:53 -05:00
Hypolite Petovan acaee626f5 Remove include/ requires that are now done directly from Composer 2018-12-24 09:56:25 -05:00
Michael 732308ce6d Hopefully this fixes the tests again 2018-12-22 22:04:47 +00:00
Michael 439afc89b6 Checks if JSON is enabled 2018-12-22 20:40:00 +00:00
Hypolite Petovan 38109665c7 Various improvements/fixes
- Fix potential missing variable
- Improve replaceMacros doc
- Fix CSS value in smoothly
2018-12-16 22:38:30 -05:00
Michael fb68b50139 Fix for exceptions on external redirects 2018-12-03 15:59:53 +00:00
Hypolite Petovan f7c9ed5108 Add DB connection status check in Update::check 2018-12-02 20:57:41 -05:00
Hypolite Petovan c5558cc459
Merge pull request #6224 from annando/dba-delete-contact
Avoid duplicated contacts, improve contact deletion, avoid memory issues
2018-12-02 16:16:59 -05:00
Hypolite Petovan 5e60fa8210
Merge pull request #6225 from annando/http-error
Using the standard function to return http errors
2018-12-02 16:15:04 -05:00
Michael 649228cd3d More detailled HTTP error explanations 2018-12-02 20:10:53 +00:00
Michael 066a040cc7 Avoid duplicated contacts, improve contact deletion, avoid memory issues 2018-12-02 16:25:25 +00:00
Hypolite Petovan 458981f75c Replace x() by isset(), !empty() or defaults()
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Hypolite Petovan 11a0dd4d4c Remove util directory 2018-11-28 23:10:21 -05:00
Hypolite Petovan e02295e8e8 Move testargs to bin 2018-11-28 23:10:05 -05:00
Hypolite Petovan 9102a37b37 Move master translation file away from util
- Rewrite translation documentation
- Delete unused util/strings.php
- Updated references to util/messages.po and util/strings.php
2018-11-28 22:57:55 -05:00
Hypolite Petovan c964e193b9 Replace *.ini.php by *.config.php in comments 2018-11-25 01:44:51 -05:00
Hypolite Petovan 98d90e131d Update install to generate config/local.config.php 2018-11-25 01:44:09 -05:00
Michael 88a4733e5f Forgotten "use" 2018-11-14 06:00:01 +00:00
Michael 9271b21d51 Create a new GUID on user import 2018-11-14 05:58:03 +00:00
Michael 109204032c Execute database update before post update is called 2018-11-12 10:36:10 +00:00
Hypolite Petovan a30876977d
Merge pull request #6108 from annando/fork-check
Add some hook to check if hook should be forked
2018-11-10 20:56:42 -05:00
Michael 033bf65f2c Some redesign 2018-11-10 15:20:23 +00:00
Michael 4a59a7ae7f Logger is not needed anymore 2018-11-10 15:16:48 +00:00
Michael e30d7cfc03 Add some hook to check if hook should be forked 2018-11-10 15:15:46 +00:00
Hypolite Petovan 8703fe4032 Accept data structure in Logger::devLog 2018-11-10 08:17:33 -05:00
Adam Magness ffc406d819 normalise_link calls
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness b73af72deb deindent calls
implement function in new class
2018-11-08 10:26:49 -05:00
Adam Magness b99925060a autoname calls
implement getRandomName function
2018-11-08 10:22:20 -05:00
Philipp Holzer 8ad721988b
Refactoring identities to Model\User::identities 2018-11-08 00:38:55 +01:00
Adam Magness 301cdd23dc coding standards 2018-11-06 10:28:18 -05:00
Adam Magness dfd48596d3 Add use statement
add use for core class
2018-11-06 09:55:14 -05:00
Adam Magness 1d571a527b Split text.php to L10n
move functions from text.php to L10n class
2018-11-06 09:52:58 -05:00
Philipp Holzer 6e10bdf361
Move random Digits to Crypto class 2018-11-05 21:02:54 +01:00
Michael e759497af3 Fix small typo / Workerqueue count now only counts non deferred entries 2018-11-04 10:51:01 +00:00
Hypolite Petovan 8a46c786f3
Merge pull request #6053 from zeroadam/CoreRenderer
Core Renderer Class
2018-10-31 13:57:12 -04:00
Adam Magness 70f01d6c00 Template Engine and props to Renderer
move methods and props from App to Renderer
2018-10-31 13:25:38 -04:00
Philipp Holzer 2a0a7cd42a
Add missing Logger::log() 2018-10-31 17:52:41 +01:00
Adam Magness 3f74ba88c2 Move delimiter props and functions
move left and right delimiter functions and properties to Render class.
2018-10-31 12:12:15 -04:00
Adam Magness 35abc4bb64 get markup template
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness 91facd2d0a replace macros
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
Philipp Holzer bf878d2ebb
Adding more Logger entries in case of update process 2018-10-31 15:22:44 +01:00
Adam Magness f6c86649c2 Create Core\Renderer Class
create new class and redirect old functions
2018-10-31 10:03:42 -04:00
Philipp Holzer 3f813d853b
introducing Logger::log 2018-10-31 14:48:19 +01:00
Philipp Holzer e5530dfa63
refactoring query 2018-10-31 14:44:43 +01:00
Philipp Holzer 9690dfc54e
Renamed Cache flag 2018-10-31 14:44:42 +01:00
Philipp Holzer 270e817954
Adding force to update routine
- Introduced Cache::NEVER Lock (never expiring lock)
- Force flag for dbstructure update
- Moving the business logic to central place in Update class
2018-10-31 14:44:40 +01:00
Philipp Holzer ffbad2dc81
moved check_db($via_worker) to Update::check($via_worker) 2018-10-31 14:44:23 +01:00
Philipp Holzer 87f3fe24f7
Moving UPDATE defines/constants out of boot 2018-10-31 14:44:23 +01:00
Philipp Holzer 4ae985e5ed
Setting update version & time on success 2018-10-31 14:44:23 +01:00
Philipp Holzer f2ca3e5be4
Using Locks for Updating and writing last success to config 2018-10-31 14:44:22 +01:00
Philipp Holzer e876adef8f
Moved the functions update_db and run_update_function to a Friendica\Core\Update class 2018-10-31 14:44:21 +01:00
Adam Magness 17ae53c9d7 Review Updates
create array, remove getConstants function, add self references.
2018-10-30 11:40:11 -04:00
Adam Magness 342e484533 Missing BaseObject
add use BaseObject
2018-10-30 10:02:52 -04:00
Adam Magness 50da89d861 Logger Levels
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness 91ef9f238c missing use and self
add use and self statements
2018-10-30 09:57:14 -04:00
Adam Magness 26fbe8dfba Review Modifications
make changes based on review.
2018-10-30 09:57:14 -04:00
Adam Magness 7138cc97ac Correct misspelling
correct misspelled use statement
2018-10-30 09:57:14 -04:00
Adam Magness 14fde5dc9b Log function
implement log() function.
2018-10-30 09:57:14 -04:00
Adam Magness d6d593d724 Create Logger class
Create Core\Logger class and point old functions to the new ones.
2018-10-30 09:57:14 -04:00
Philipp Holzer cf39c9df81
Bugfixings
- moved testargs.php to util directory
- Switch Environment check before config at automatic install
- checkPHP() is now finding the PHP binary too
- Bugfixing checkPHP() & required returned wrong status
- removing not used $_POST['phpath'] in web installer
2018-10-30 11:30:19 +01:00
Philipp Holzer f0382ab919
Refactoring Installation
- centralized installation
- renamed Core\Install to Core\Installer
- avoid using $a->data[] for states
- removed unnecessary code
2018-10-29 18:44:39 +01:00
Philipp Holzer 64149c41b4
Replacing error message 2018-10-29 14:40:50 +01:00
Philipp Holzer abb50fbf62
Install to Module
- Move Install to Module
- Some Bugfixings
2018-10-29 14:10:45 +01:00
Hypolite Petovan 14237a9599 Move $pager and $page_offset out of App
- Move infinite scroll data output in a module hook
- Use Pager instead of paginate() and alt_pager()
2018-10-25 00:07:15 -04:00
Hypolite Petovan a976a4cb68 Add new Hook::add method to enable module hooks 2018-10-25 00:07:15 -04:00
Hypolite Petovan c60a65c423 Fix unsetting non-existent index in Addon::$addons on uninstall 2018-10-24 20:44:05 -04:00
Michael 95dc030926 Show deferred worker tasks in the admin interface and workerqueue logs 2018-10-23 20:38:28 +00:00
vinzv cb75c40f4e adapted profile pic resize to 300px for whole system 2018-10-23 16:36:57 +02:00
Michael Vogel d61a98a995
Merge pull request #6008 from nupplaphil/fixing_tests_2
Fixing tests - part 2
2018-10-23 14:23:59 +02:00
Philipp Holzer a79daf3946
Fixing tests - part 2 2018-10-23 13:53:48 +02:00
Philipp Holzer 3e6ea9383b
Making redirect message more informative 2018-10-23 12:17:41 +02:00
Tobias Diekershoff dbe49a0c1a
Merge pull request #5998 from annando/ap-queue
Unsuccessful ActivitiyPub transmission are now deferred
2018-10-23 06:54:11 +02:00
Michael e3e714a45f Unsuccessful ActivitiyPub transmission are now deferred 2018-10-23 03:54:18 +00:00
Hypolite Petovan a22196edae Add/Fix Doxygen headers for classes 2018-10-22 16:50:55 -04:00
Hypolite Petovan 015e2a84b1 Remove obsolete require_once include/dba from Core\Addon and Core\Hook 2018-10-22 16:50:55 -04:00
Hypolite Petovan e511790d62 Move NULL_DATE from boot.php to DBA::NULL_DATETIME
- Add DBA::NULL_DATE constant
2018-10-22 16:50:55 -04:00
Hypolite Petovan ca9cad3491 Move hook-related methods from Core\Addon to Core\Hook 2018-10-22 16:50:54 -04:00
Hypolite Petovan 0aa7671119 Add new Core\Hook class 2018-10-22 16:49:53 -04:00
Philipp Holzer 3edad1591e
replaced $return_url to $return_path to make it more clear that it is a relative path to the Friendica baseurl 2018-10-22 22:13:37 +02:00
Philipp Holzer d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect() 2018-10-22 22:13:35 +02:00
Philipp Holzer 2ef81108b3
Renamed System::redirect() to $a->redirect() 2018-10-22 22:13:22 +02:00
Hypolite Petovan e3fe25383c Add static keyword for Core\L10n properties 2018-10-22 15:58:42 -04:00
Hypolite Petovan c6f0bea51d Move $strings from App to Core\L10n
- Add L10n::init() call in App constructor
- Improve pushLang/popLang
- Remove no longer needed references to App
2018-10-22 15:58:42 -04:00
Hypolite Petovan 279196959c Move index.php content to App->runFrontend
- Replace all x() by !empty() in App
- Replace all killme() with exit()
2018-10-21 22:24:47 -04:00
Hypolite Petovan ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security
Move and Split include/security
2018-10-19 08:55:08 -04:00
Jonny Tischbein f3fc1f36ca Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments 2018-10-17 21:30:41 +02:00
Jonny Tischbein ce2b1f5715 Rename function Authentication::authenticate_success to Authentication::success 2018-10-17 18:45:32 +02:00
Jonny Tischbein 05be2db725 Move include/security tp /src/Core/Authentication and /src/Util/Security 2018-10-17 14:19:58 +02:00
Hypolite Petovan b5fb81f535 Add Mastodon/Pleroma protocol guessing 2018-10-17 01:10:07 -04:00
Michael e2762e032c Poddibility to defer worker execution 2018-10-15 05:19:35 +00:00
Hypolite Petovan 6c80601a4a
Merge pull request #5902 from nupplaphil/Install_Class_to_methods
Install class bugfixing & tests & changed method signature
2018-10-14 06:23:33 -04:00
Philipp Holzer 248c1b8074
Type hinting & call bugfixing 2018-10-14 10:37:19 +02:00
Philipp Holzer 2c541afd47
Moved functions out of boot.php into class
- z_root() => $a->getBaseURL()
- absurl() => removed because no usage
- is_ajax() => $a->isAjax()
- current_load() => System::currentLoad()
- argc() => $a->argc
- argv($x) => $a->getArgumentValue($x)
2018-10-13 19:03:08 +02:00
Philipp Holzer c32ac7f194
Install Class to methods
- Bugfixing Install checks (worked not as expected)
- Changed static methods from Install to class functions
- Added tests
2018-10-13 18:09:53 +02:00
Philipp Holzer ffbc688797
Curl Response Refactoring
- refactored Network::getCurl()
- replaced every Network::getCur() execution with a Curl Response
2018-10-10 21:50:13 +02:00
Philipp Holzer 2dec8895a9
Curl Response Refactoring
- extended Curl to parse Curl Response
- refactored Network::curl()
- replaced every Network::curl() execution with the new Curl container
2018-10-10 21:08:43 +02:00
Philipp Holzer 307286fc47
parameters and getURLpath to getURLPath 2018-10-10 01:18:47 +02:00
Philipp Holzer 5a02e39a65
Rename App Methods
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
Hypolite Petovan 3bccaccede
Merge pull request #5848 from nupplaphil/friendica-5847
friendica-5847 Console Cache List command doesn't work
2018-10-07 17:47:51 -04:00
Philipp Holzer 7da6da6666
Bugfixings for getAllKeys() 2018-10-07 22:14:05 +02:00
Philipp Holzer 8491f8660f
Bugfixing Memcached 2018-10-07 10:38:45 +02:00
Philipp Holzer 1ec5c6b284
friendica-5847 Console Cache List command doesn't work
- filterPrefix => filterArrayKeysByPrefix()
- Logging failed Executions of getAllKeys and get from Memcached
2018-10-07 10:35:37 +02:00
Philipp Holzer 3f0f3b6ae6
friendica-5847 Console Cache List command doesn't work
- Added $prefix to all CacheDriver
- Moved hostname magic to CacheDriver
- Added test for getAllKeys()
2018-10-07 00:27:54 +02:00
Philipp Holzer 31148e25cf
Changing Friendica\App\Mode from static methods to public methods
- Changing from static methods to public methods
- Adding dev-composer-dependency Mockery for static method mocking (f.e. Config, DBA)
- Adding ModeTest with Mocking
- removing bootstrap from phpunit.xml because of double loading tests\bootstrap.php
2018-10-06 16:27:20 +02:00
Tobias Diekershoff 3b41535dfe
Merge pull request #5835 from annando/ap3
Some more AP stuff ...
2018-10-06 09:18:30 +02:00
Michael 09302367d5 Include AP in the contact search 2018-10-06 03:17:44 +00:00
Hypolite Petovan 3ed9e7fe1d Replace remaining $a->isInstallMode() instances 2018-10-05 20:31:32 -04:00
Hypolite Petovan 3564daf24d
Merge pull request #5828 from nupplaphil/mode_class
Creating Friendica\App\Mode for encapsulating the App Mode
2018-10-05 20:07:39 -04:00
Philipp Holzer eb1a257224
Used new select function 2018-10-06 01:21:05 +02:00
Philipp Holzer d72473fd51
moving boot::check_addons to Friendica\Core\Addon::check
And extending Addon from BaseObject because of self::getApp()
2018-10-06 01:13:29 +02:00
Philipp Holzer 065340dc32
Creating Friendica\App\Mode for encapsulating the App Mode 2018-10-05 22:36:09 +02:00
Philipp Holzer fe6e600dc5
Adding "FRIENDICA_URL_PATH" to the automatic installation 2018-10-05 19:42:08 +02:00
Michael Vogel ec898ecd2a
Merge pull request #5792 from MrPetovan/task/add-cache-console
Add Cache console
2018-10-03 11:17:43 +02:00
Hypolite Petovan 2a7327a41c
Fix spaces in Cache\Memcachedriver 2018-10-03 00:24:26 -04:00
Michael cb9be8a7ab UUID is now createUUID 2018-09-27 11:52:15 +00:00
Michael 60b0759b50 UUID instead of GUID 2018-09-26 20:03:46 +00:00
Hypolite Petovan c80045edaf Remove obsolete lines from Console\Config 2018-09-25 23:00:00 -04:00
Hypolite Petovan be0f71bedb Add new Cache console command 2018-09-25 22:59:22 -04:00
Hypolite Petovan d420a4dec2 Add informative public static members to Core\Cache 2018-09-25 22:58:04 -04:00
Hypolite Petovan 71c08a044f Add ICacheDriver->getAllKeys method 2018-09-25 22:52:32 -04:00
Hypolite Petovan 640f76b05a Improve doc blocks in cache drivers 2018-09-25 22:51:41 -04:00
Hypolite Petovan d1148f61ea Add missing "outdated" parameter to ICacheDriver->clear in Core\Cache 2018-09-25 22:46:45 -04:00
Hypolite Petovan a6996601d5
Merge pull request #5789 from friendica/master
Update develop from master-2019.09
2018-09-23 18:55:20 -04:00
Michael b3e3147697 Issue 5768: This logging should help finding the origin of the problem 2018-09-22 07:09:27 +00:00
Hypolite Petovan 9d0a6f90b6 Update "mrpetovan" email address
- Fix Tobias' email address
- Fix copypasted doc block in Console/PostUpdate
2018-09-15 19:28:38 -04:00
Philipp Holzer bd2b3b1ef5
LockDriverFixings
- release Locks in case of failures
- adding some cache tests
2018-09-06 08:11:18 +02:00
Hypolite Petovan 804cfa0320 Reorganize Protocol constants
- Add ActivityPub protocol constant
- Add Protocol::NATIVE_SUPPORT
- Sort/group constant names
2018-08-30 17:47:48 -04:00
Michael 67227570d8 "Does" is now "perform" 2018-08-29 13:06:56 +00:00
Michael d489712824 The post update version can now be set. 2018-08-29 11:48:40 +00:00
Philipp 2838e4ebaf Automatic Install Tests & Doku (#5674)
* Automatic Installation Testing
- New dev-library "mikey179/vfsStream"
- created "reload" method for App-Reloads
- ConsoleTest now using virtual directory
- Adding Automatic Installation Tests
- Fixing some probable install-failures

* Updating README for Automatic Installation

* Updating README for Automatic Installation

* Bugfix normal installation

* Fixing copying of config files
2018-08-27 00:15:55 -04:00
Michael 1280bb56df Removed notices in notifications 2018-08-26 05:27:50 +00:00
Michael Vogel dc3d2d5988 "dba" is now "DBA". This hadn't been respected at some places (#5655)
* "dba" is now "DBA". This hadn't been respected at some places

* Cleaning up unneeded stuff
2018-08-23 09:51:58 -04:00
Michael Vogel 54aee2aaa7 Removed notices that revealed themselfes over night ... (#5645)
* Removed notices that revealed themselfes over night ...

* And more notices removed that occured over night

* One more ..

* Some more notices of the day ...
2018-08-21 17:35:09 +02:00
Philipp d7395299fb Automatic Installation fix (#5565)
* Automatic Install Config Fix

* new unittest for AutomaticInstallation

* unittest for autoinstall
- removed password check

* removed bak-file

* automatic install
- always save environment variables
- just skip db environment if not `--savedb` is set

* fixed help (options)

* fixed help (options)

* Deleting Auto-Install tests until fix for proper DB restoring
2018-08-20 16:15:39 -04:00
Michael Vogel 060e887a31 And still there are notices that have to be removed ... (#5629)
* And still there are notices that have to be removed ...

* Notice removed in ACL part

* Fix missing fields for notifications

* Fixes issue 5630
2018-08-18 08:20:50 +02:00
Hypolite Petovan ea17370211 Fix bug with ACL and contact network page
- Require user array parameter in ACL::getFullSelectorHTML
- Change all wrong uses where user array was replaced by default
permissions array
2018-08-15 00:43:27 +02:00
Michael Vogel 1283b99c6f Removed notices in the frio theme (#5610)
* Removed notices in the frio theme

* And fixed notices in the notifications

* And some more in frio

* Null is the default value

* And some small notice in the probing removed

* Added note

* Clarified note

* And a removed notice in OStatus
2018-08-14 19:37:44 +00:00
Roland Häder e06fc2aa69 Stopped using deprecated constants NETWORK_* (#5537)
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...

* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
Michael 5037f9c460 Console script to ensure that all post updates are finished 2018-08-10 21:20:25 +00:00
Michael 0c56538cd5 Notice in tt fixed that happens with chinese translations 2018-08-08 12:17:49 +00:00
Michael Vogel 9eb2c2ec16 Fix for duplicated addon entries in the hook table (#5583) 2018-08-07 23:03:38 +02:00
Michael Vogel eaf81e5e66
Merge pull request #5563 from MrPetovan/bug/5470-fix-various-notices
Fix various notices
2018-08-07 21:34:47 +02:00
Michael Vogel 8c2efa6df4 Facebook and App.net is removed from nearly all places (#5581)
* Facebook is removed from nearly all places

* Remove app.net as well - it's dead for some time now
2018-08-07 17:06:51 +02:00
Michael Vogel 5e61caa34f Fix for not loading the translation / some more notice removed (#5569) 2018-08-06 12:11:17 +02:00
Hypolite Petovan 45de8a28cd Fix missing $_SESSION variable in src/App 2018-08-05 15:56:21 +02:00
Roland Häder 4d39164c1e [WIP] Rewrite to Proxy class: (#5507)
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
2018-07-30 22:06:22 -04:00
Michael Vogel a2cea16954 Some more notices (#5526)
* Some more notices

* Fixed nasty to find notice in DFRN and OStatus

* And more notices ...

* Yeah, some removed notices ... again ...
2018-07-30 06:41:20 +02:00
Roland Häder 592190892c Continued: (#5508)
- `App` is now "imported" to avoid having \Friendica\App::* everywhere
2018-07-26 22:27:28 -04:00
Roland Häder 37253656e3 Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace (#5490)
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
2018-07-24 22:53:46 -04:00
Michael 432eec770b Issue 5467: Cron jobs hadn't been executed 2018-07-24 06:15:58 +00:00
Hypolite Petovan a6fb3568f9 Rename dbesc to DBA::escape 2018-07-23 15:30:54 -04:00
Hypolite Petovan ecea7425f8 Rename DBA::is_result to DBA::isResult 2018-07-23 11:04:14 -04:00
Hypolite Petovan 0ec44f3e8a Rename DBM method calls to DBA method calls 2018-07-23 11:02:24 -04:00
Michael Vogel 2d0a749734
Merge pull request #5431 from MrPetovan/task/5410-rename-database-methods
Move DBA to src/ part 3.1: Rename DBA methods
2018-07-23 15:18:58 +02:00
Philipp cd52d0b3e9 Using getopt for CLI arguments (#5446)
* Adding Argument class to Friendica

* Adding Argument class to Friendica

* Adding Argument class to Friendica

* fixing arguments for `spawnWorker`

* Adding `use Friendica\BaseObject` to `ApiTest.php`

* Refactoring the argument-usages of Friendica

* Refactoring the argument-usages of Friendica

* removing superfluous []
2018-07-23 07:40:52 -04:00
Hypolite Petovan 415b982d39 Rename DBA::num_rows to DBA::numRows 2018-07-22 19:27:35 -04:00
Hypolite Petovan 4db98eb43d Rename DBA::inArray to DBA::toArray 2018-07-22 19:27:35 -04:00
Hypolite Petovan f051ae1698 Rename DBA::fetch_first to DBA::fetchFirst 2018-07-22 19:27:34 -04:00
Roland Häder d3144e2837 Need to load "verb" from notify table, too. This whole thing is a maintenance (#5459)
nightmare. Let's use the new database frontend/backend system and load all
columns anywhere the "entity" is requested.
2018-07-22 19:25:07 -04:00
Roland Häder c17adaf333 Uncommon logger levels in Friendica (#5453)
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)

* Used constants instead of values (MrPetovan)
2018-07-22 14:07:44 -04:00
Michael Vogel 6a6a805225 One more notice (#5429)
* Some more notices

* And some more notice in the worker
2018-07-20 20:43:21 -04:00
Michael Vogel 4bbcb61a9e We now have a pre update script (#5425)
* We now have a pre update script

* Some optimized stuff
2018-07-20 15:47:16 -04:00
Michael Vogel 7382be2766 Some more notices (#5424) 2018-07-20 14:07:54 -04:00
Hypolite Petovan af6dbc654f Rename Friendica\Database\dba to Friendica\Database\DBA 2018-07-20 08:19:26 -04:00
Hypolite Petovan daa1177e3a Update use statement lists with new Friendica\Database\dba class
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Roland Häder 36c6e35c7e Misc cleanups (#5417)
* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>

* reverted back

Signed-off-by: Roland Häder <roland@mxchange.org>

* Added type-hint 'array' as the method uses foreach() on it.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Tpzo fixed ...

Signed-off-by: Roland Häder <roland@mxchange.org>

* Added missing new-line at end of file, will make some POSIX parsers being lesser
confused ...

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 20:52:18 -04:00
Pierre Rudloff 6e1ed0b0d3 Fix tests (#5400)
* Avoid argc side-effects

* Fix undefined array keys in JITConfigAdapter::set()

* Avoid argv side effects in ApiTest
2018-07-18 16:30:55 -04:00
Michael Vogel 2fa6cc0000
Merge pull request #5394 from MrPetovan/bug/fix-config-set-return-value
Change (P)Config::set return value to bool
2018-07-18 11:07:10 +02:00
Hypolite Petovan 0f7c7cebeb Change (P)Config::set return value to bool 2018-07-18 02:32:35 -04:00
Hypolite Petovan 050ad68b9f Improve Console/Config display for array values
- Prevent setting a config key that is an array
2018-07-17 02:15:05 -04:00
Hypolite Petovan 7b8efcc23d Fix config value type in MemcachedCacheDriver
- Remove default config values set in CacheDriverFactory
2018-07-17 02:05:06 -04:00
Hypolite Petovan 763c66dd49 Improve console/config display
- Add visual distinction between get/set value
2018-07-16 19:38:18 -04:00
Hypolite Petovan c8d3067d0a Fix JITConfigAdapter to retrieve non-db config.* values 2018-07-16 19:38:17 -04:00
Hypolite Petovan d0780ccf7d Replace global $lang with system.language 2018-07-16 19:38:17 -04:00
Hypolite Petovan 6b03ae92b8 Fix Memached config value format usage 2018-07-16 19:38:16 -04:00
Hypolite Petovan 762a786611 Replace direct accesses to App->config by Config::get/set calls 2018-07-16 19:38:16 -04:00
Hypolite Petovan cd9b864045 Rework App modes
- Replace App mode constants with capability-based flags
- Add App->isInstallMode()
- Add file config fallback in (P)Config abstraction
- Removed logger disabling code
2018-07-16 19:38:15 -04:00
Hypolite Petovan d487c399dd Standards: Rename App methods
- Rename App->max_processes_reached to App->isMaxProcessesReached
- Rename App->maxload_reached to App->isMaxLoadReached
2018-07-16 19:38:14 -04:00
Hypolite Petovan 3fc21f0d64 Fix config mentions (no doc) 2018-07-16 19:38:14 -04:00
Hypolite Petovan 0448ca3897 Update install procedure
- Fix Notice messages in Core\Install and Database\DBStructure
- Move local config file template from htconfig.tpl to local.ini.tpl
- Remove htconfig.php
2018-07-16 19:38:14 -04:00
Hypolite Petovan e7c3d453c2 Update config console command 2018-07-16 19:38:14 -04:00
Hypolite Petovan fd7179ee6c Prevent infinite loops with Config when App is in install mode 2018-07-16 19:38:13 -04:00
Hypolite Petovan 3985a4bc43 Remove extraneous dba::connect calls 2018-07-16 19:38:13 -04:00
Hypolite Petovan e952d6677b Rename App->path to App->urlpath 2018-07-16 19:38:13 -04:00
Hypolite Petovan 2503660f97 Add new INI config files
- Add new local.ini.tpl template
- Change all references from .htconfig.php to config/local.ini.php
2018-07-16 19:38:13 -04:00
Michael Vogel d3a2ed85fe Next item structure works (#5380)
* Use "LEFT JOIN" to always fetch the item. Needed for update routines.

* New conversion routine that now covers every item

* Post update is now activated

* We now use a hash based upon RIPEMD-320 for content and activity

* The hash doesn't contain the plink anymore

* Legacy item fields are now "null"able

* New hash function for a server unique item hash

* Introduction of the legacy mode (usage of old item fields)

* Code simplification

* We don't need the "uri" fields anymore in item-activity and item-content

* Use the "created" and not the "received" date for the hash

* Avoiding several notices

* Some more warnings removed

* Improved uri-hash / Likes on Diaspora are now getting a creation date

* Corrected the post update version

* Ensure an unique uri-hash

* Don't delete orhaned item data at the moment

* Partly reworked, due to strange behaviour

* Some more parts reworked

* Using the uri currently seems to be more reliable

* Using the uri here as well

* Use the hash values again

* Grouped item fields in different categories

* Notices again

* use the gravity (we always should)

* Added hint for disabled post updates

* Notices ...

* Issue #5337: Personal notes are displayed again

* Use the gravity again
2018-07-15 14:36:20 -04:00
Tobias Diekershoff 26723623f4
Merge pull request #5363 from annando/daemin
Workaround for stalling worker processes when running the daemon
2018-07-11 08:26:09 +02:00
Michael 3cb7a7606e workaround for stalling worker processes when running the daemon 2018-07-11 06:05:22 +00:00
Roland Häder 8825728fa4 "Imported" name spaces (#5361)
* Fixes for #5355:
- let's import SPL/extension classes and then just use them without name spaces
  like we do it with our own classes/interfaces, too.
- need to add namespace \ (global)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Removed leading slashes from "import" lines.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Completed:
- "import" other classes, then use them

Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-10 18:55:01 -04:00
Michael Vogel 3792e2819d Use a process identifier for logging that contains the pid (#5359) 2018-07-10 18:32:47 -04:00
Philipp Holzer a84c94e94b
bugfix isempty... 2018-07-09 22:10:35 +02:00
Philipp Holzer d1eeaeead9
empty is not isset ... 2018-07-09 21:53:49 +02:00
Philipp Holzer c829e43725
moved get_guid to System::createGUID 2018-07-09 21:38:16 +02:00
Hypolite Petovan 7211fc4f1a
Merge pull request #5338 from annando/warnings
Remove warnings
2018-07-08 09:55:26 -04:00
Philipp Holzer be83696f02
Redis serialize instead of json because of objects 2018-07-08 13:35:28 +02:00
Michael 3e797547a3 Warnings fixed 2018-07-08 09:37:05 +00:00
Philipp Holzer 065b83d148
Fixed memcache & unittests 2018-07-07 20:07:07 +02:00
Philipp Holzer 80a4e6263f
Added Unittests for cache
fixed Lock & Cache bugs
2018-07-07 19:46:16 +02:00
Philipp Holzer 1dafaa69c5
bug in memcached clear function 2018-07-07 18:43:55 +02:00
Philipp Holzer f95c420801
bug in redis delete function 2018-07-07 18:39:33 +02:00
Philipp Holzer 1ffe0cfd81
Added Lock Unittests & Bugfixings
Added Redis Lock Unittests
Added Memcached Lock Unittests

Fixed a bug in dba
Fixed a bug in RedisLock
2018-07-07 16:15:03 +02:00
Michael Vogel 3eec97aa6e
Merge pull request #5314 from MrPetovan/task/4889-fix-tests
Fix tests after enabling PHP Notices
2018-07-06 22:14:01 +02:00
Philipp Holzer 5a28ad7377
AbstractCacheDriver now working for each CacheDriver 2018-07-05 22:01:33 +02:00
Philipp Holzer 749b167fd9
AbstractCacheDriver now working for each CacheDriver 2018-07-05 21:54:20 +02:00
Philipp Holzer 34cea93a8b
Bugfixings for Cache-Lock
- used wrong cachekey in set
- therefore added an abstraction to avoid wrong key concatenation
- forgot to increase the db-version to 1275
2018-07-05 21:47:52 +02:00
Philipp Holzer e41e7d2edd
Fixings
- fixed test for semaphore
- fixed some issues
- changed namespace in Tests back to "src/"
- changed namings
2018-07-05 20:57:31 +02:00
Philipp Holzer 906bb25972
code standards / simplifications 2018-07-05 07:59:56 +02:00
Philipp Holzer aac94d1d74
Adding multihost - locking
Adding Unit-Tests for it
2018-07-04 23:37:22 +02:00
Hypolite Petovan 6776c4e3f9 Fix some undefined variable/index notices in tests 2018-07-02 07:44:55 -04:00
Philipp Holzer ad5ee75159
Deleting parameter-types of methods (lack of support in PHP 5.6) 2018-06-28 23:06:14 +02:00