Commit Graph

31229 Commits

Author SHA1 Message Date
RealKinetix cf32a4b7cc Sanitize negative status count on APContact
Similar to PR #10499, Mastodon apparently has some counting flaws and
can present a negative status count for a user, causing Friendica to
fail (at least under PHP 8) with:

[20-Jul-2021 16:35:18 UTC] PHP Fatal error:  Uncaught PDOException: SQLSTATE[22003]: Numeric value out of range: 1264 Out of range value for column 'statuses_count' at row 1 in /home/friendicadev/friendica/src/Database/Database.php:560
Stack trace:
  thrown in /home/friendicadev/friendica/src/Database/Database.php on line 560

This change prevents values lower than 0 from being assigned to
statuses_count.
2021-07-20 10:11:04 -07:00
Hypolite Petovan b04471b9f0
Merge pull request #10523 from annando/issue-10519
Issue 10519: check for tables and fields before applying changes
2021-07-20 10:42:07 -04:00
Michael 110f8018eb Issue 10519: check for tables and fields before applying changes 2021-07-20 06:11:12 +00:00
Hypolite Petovan 814812675c
Merge pull request #10522 from annando/warning
Fix warning "class 'Friendica\Module\Objects' not found"
2021-07-19 19:21:45 -04:00
Michael 9947b2e6e3 Fix warning "class 'Friendica\Module\Objects' not found" 2021-07-19 23:14:16 +00:00
Michael Vogel 8b040f19a5
Merge pull request #10521 from MrPetovan/task/10511-add-persian-language-detection
Manually add Persian to post body language detection
2021-07-20 00:49:51 +02:00
Hypolite Petovan f3131c6277 Manually add Persian to post body language detection 2021-07-19 14:00:31 -04:00
Tobias Diekershoff 0eed813037
Merge pull request #10520 from annando/fatal
Added missing app class (avoid fatal error)
2021-07-19 19:06:09 +02:00
Michael 289a4dcba7 Added missing app class (avoid fatal error) 2021-07-19 16:15:06 +00:00
Hypolite Petovan 7cbe1e3ca2
Merge pull request #10508 from annando/loop-prevention
Prevent endless loop when updating contact by probe
2021-07-19 10:21:10 -04:00
Michael d2408c1f1b Merge remote-tracking branch 'upstream/develop' into loop-prevention 2021-07-19 12:07:34 +00:00
Michael 64026ed979 Simplify code 2021-07-19 12:07:02 +00:00
Hypolite Petovan 0dd94e8fd5
Merge pull request #10515 from annando/event-handling
Improved event storing / improved performance when fetching events
2021-07-19 04:00:53 -04:00
Michael 58cec97358 Merge remote-tracking branch 'upstream/develop' into loop-prevention 2021-07-19 07:51:29 +00:00
Hypolite Petovan eb43a579ec
Merge pull request #10512 from annando/ap-endpoints
Move ActivityPub endpoints to an AP class
2021-07-19 03:30:23 -04:00
Michael f5a7b0141b Added todo 2021-07-19 06:55:23 +00:00
Michael fa00a4ee32 Simplyfied picture fetching 2021-07-19 06:19:13 +00:00
Michael 2647514603 Detection of local requests 2021-07-19 06:14:14 +00:00
Michael 01abea7c25 Don't probe non existing local contacts 2021-07-19 04:49:58 +00:00
Michael aa6313dee6 Improved detection for a local contact 2021-07-19 04:15:57 +00:00
Michael 424a85bb94 Fetch local data without HTTP requests 2021-07-18 18:54:25 +00:00
Michael d8bf9c4601 Prevent loop also when fetching the outbox 2021-07-18 16:42:55 +00:00
Michael 2030691f9f Improved event storing / improved performance when fetching events 2021-07-18 15:05:46 +00:00
Tobias Diekershoff 41f6397cc9
Merge pull request #10513 from annando/notice
Fix notice in events
2021-07-18 08:26:06 +02:00
Tobias Diekershoff 0dd1d7256f
Merge pull request #10509 from annando/issue-10506a
Issue 10506 - again. Improved check for pictured in body
2021-07-18 07:03:09 +02:00
Michael f62f82df75 Move ActivityPub endpoints to an AP class 2021-07-17 20:28:46 +00:00
Michael ea056b93fa Fix notice in events 2021-07-17 20:27:18 +00:00
Michael dd2abf254d Issue 10506 - again. Improved check for pictured in body 2021-07-17 07:55:19 +00:00
Michael 596bb9fa7c Fixed wrong parameter 2021-07-17 05:25:04 +00:00
Michael 89f7ee2cc5 Prevent endless loop when updating contact by probe 2021-07-17 04:57:21 +00:00
Tobias Diekershoff 6331e1e71c
Merge pull request #10507 from annando/issue-10506
Issue 10506: Fix for multiple picture posts
2021-07-17 06:47:30 +02:00
Michael feab53b58b Issue 10506: Fix for multiple picture posts 2021-07-17 04:32:46 +00:00
Hypolite Petovan 2a873651c5
Merge pull request #10505 from annando/dfrn-endpoints
DFRN endpoints moved, changelog entry added
2021-07-16 14:32:53 -04:00
Michael 209d4d0d6a DFRN endpoints moved, changelog entry added 2021-07-16 14:45:29 +00:00
Hypolite Petovan 4dc6b29046
Merge pull request #10503 from annando/no-legacy-dfrn
Legacy DFRN transport layer is removed
2021-07-15 16:24:07 -04:00
Hypolite Petovan 8ae99fe711
Merge pull request #10499 from realkinetix/sanitize-ap-followers-count
Sanitize negative followers count on APContact
2021-07-15 15:14:22 -04:00
Michael c1e681e007 Improved comment 2021-07-15 17:42:03 +00:00
Michael bca5238b41 Removed test 2021-07-15 13:37:48 +00:00
Michael 3a5523820c Legacy DFRN transport layer is removed 2021-07-15 13:28:32 +00:00
RealKinetix a0107be2af Negative numbers in following is a thing too
Check & sanitize 'following' as well, as per:
https://mastodon.social/@BLUW
2021-07-14 13:51:30 -07:00
RealKinetix f16b1df83f Adjust where the code is to avoid empty warning
Shifted the code to avoid:
PHP Warning:  Undefined array key "totalItems" in /home/friendicadev/friendica/src/Model/APContact.php on line 277
2021-07-14 13:46:38 -07:00
RealKinetix c1db1c980e Fix indent to standards 2021-07-14 12:17:03 -07:00
RealKinetix 2ebebe9abc Sanitize negative followers count on APContact
Please see
https://github.com/friendica/friendica/issues/9498#issuecomment-818894106
and related discussion regarding this - it appears it's possible for AP
users, maybe just Mastodon users, to have a negative followers count.
This causes fatal errors in Friendica, so I think we should sanitize
this input.
2021-07-14 10:15:19 -07:00
Hypolite Petovan dde1d203f7 [frio] Move content of event_edit.js to mod_event.js to prevent an unsafe-eval 2021-07-14 08:13:24 -04:00
Hypolite Petovan fd37a57678
Merge pull request #10496 from annando/subscribe
Subscribe to contacts from a remote AP account
2021-07-14 06:45:25 -04:00
Michael Vogel b60396f306
Merge pull request #10497 from MrPetovan/bug/10494-api-last-status-optional
Make last status parameter actually optional in Object\Api\Mastodon\Conversation
2021-07-14 05:09:11 +02:00
Hypolite Petovan be18a59bd7 Make last status parameter actually optional in Object\Api\Mastodon\Conversation 2021-07-13 23:02:11 -04:00
Michael 0277589fbd Removed experimental code 2021-07-14 02:59:29 +00:00
Michael bbebbb662a spaces removed 2021-07-14 02:57:50 +00:00
Michael 097eb9e83b Updated messages.po 2021-07-14 02:56:15 +00:00