Hypolite Petovan
1467a02576
Fix namespace usage in include/enotify
2019-01-21 11:38:01 -05:00
Hypolite Petovan
ce177f22c8
Fix doc blocks and return value type
2019-01-21 11:36:01 -05:00
Hypolite Petovan
7f2dc40601
Fix potential bugs without expected behavior change
...
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Hypolite Petovan
ad9c67663d
Move Contact::Page_* constants to User::PAGE_FLAGS_*
2019-01-21 10:55:37 -05:00
Hypolite Petovan
070aa016e0
Update more PHPDoc, including in include/
2019-01-21 10:39:28 -05:00
Hypolite Petovan
cbda92f253
Add "on their post" label to notifications
...
- Align tag notifications on comment notifications
2019-01-21 10:12:52 -05:00
Hypolite Petovan
55e54bb950
Replace deprecated Addon::callHooks with Hook::callAll
...
- Update documentation
2019-01-21 09:50:56 -05:00
Hypolite Petovan
5e1ceb57de
Escape global namespaced get_app() calls
...
- Add deprecated status
2019-01-03 21:27:36 -05:00
Adam Magness
ffc406d819
normalise_link calls
...
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
991f259ecb
random_string calls
...
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness
e537f7d017
Function calls
...
update function calls to new class
2018-11-06 21:16:27 -05:00
Adam Magness
35abc4bb64
get markup template
...
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness
91facd2d0a
replace macros
...
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
Adam Magness
50da89d861
Logger Levels
...
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
14fde5dc9b
Log function
...
implement log() function.
2018-10-30 09:57:14 -04:00
Hypolite Petovan
a8d3a4d218
Add missing L10n::popLang calls
2018-10-20 09:02:10 -04:00
Michael Vogel
389685e099
Merge pull request #5920 from MrPetovan/bug/remove-password-from-register
...
Avoid storing plaintext password in register table
2018-10-17 21:04:11 +02:00
Hypolite Petovan
481b0ac138
Fix notices in include/enotify
2018-10-15 23:13:00 -04:00
Hypolite Petovan
f2bde919e5
Fix ignored show_in_notification_page parameter in notification()
2018-10-14 11:30:39 -04:00
Philipp Holzer
5a02e39a65
Rename App Methods
...
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
Michael Vogel
d29cb1acaf
Fix: Mail notifications arrive again ( #5654 )
...
* Fix: Mail notifications arrive again
* Ensure that user data is always there
2018-08-23 10:00:25 +02:00
Michael Vogel
7f3fb34c24
Some easy to replace "q" calls have been replaced by "DBA" calls ( #5632 )
...
* Some easy to replace "q" calls have been replaced by "DBA" calls
* Simplified the GUID creation
* And one in the API ...
* And OStatus has got some DBA calls more
* Just some more replaced database calls
* The event query is now simplified
* Events are now shown again
* subthread is now using the DBA calls as well
* Some more replaced database calls
* And some more replaced database calls and prevented notices
* Better use gravity
* Some more replaced database stuff
* Some more replaced database calls in DFRN.php
* The gcontact class now has got the new DBA functions as well
* The Contact class is now changed to new database functions as well
* Small correction
* We can now delete without cascade
* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
Michael
56443b53cb
Fix: We now are notified again when a new post had been created
2018-08-12 04:34:56 +00:00
Michael Vogel
276abfaba6
Issue 5158: Ignore all threads, even public ones ( #5588 )
...
* Issue 5158: Ignore all threads, even public ones
* Remove some notice
* Now it really should work
* Using "defaults"
2018-08-08 22:32:11 +02:00
Michael Vogel
c72c64a6d8
Notices again ( #5543 )
...
* And again notices
* Notices in the directory
* Much more places
* Fix some double $
* Notice in ping
* Missing field
* Fix: We now remove deleted users from the directory
* Some more stuff
* Notices when removing users
* Added logging
* More logging
* Two more
2018-08-02 07:21:01 +02:00
Michael Vogel
71b1638d9a
Once again, notices ... ( #5535 )
2018-07-31 18:39:23 +02:00
Roland Häder
4a22710b3b
Moved global PAGE_* to Profile class ( #5500 )
...
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*
* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`
* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Hypolite Petovan
a6fb3568f9
Rename dbesc to DBA::escape
2018-07-23 15:30:54 -04:00
Hypolite Petovan
ecea7425f8
Rename DBA::is_result to DBA::isResult
2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a
Rename DBM method calls to DBA method calls
2018-07-23 11:02:24 -04:00
Hypolite Petovan
af6dbc654f
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 08:19:26 -04:00
Hypolite Petovan
daa1177e3a
Update use statement lists with new Friendica\Database\dba class
...
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Hypolite Petovan
762a786611
Replace direct accesses to App->config by Config::get/set calls
2018-07-16 19:38:16 -04:00
Michael Vogel
0360f7197a
Several more warnings ... ( #5340 )
...
* Some more warnings removed
* Even more warnings ...
* Will it ever end? ;-)
* Avoid warning in dbstructure
* Origin and OStatus ...
* There are more warnings solved ... yeah!
* And again ...
* We are not done yet
* And more ...
* And some new places ...
* And more in the feeds
* Avoid some more
* And some backend stuff
* Notifications cleared
* Some more stuff
* and again ...
* It's getting fewer ...
* Some warnings had been hidden in the notifications
* Fix the fix
* And another missing one ...
* We need the owner here, not the user
* Forgotten user
* And more ...
* And some more warnings disappeared ...
* Some more frontend warnings
* Some backend warnings removed
* Fixed sidebar for "vier"
* And more ...
* Some more ...
* And something for "remote self"
* Am I stuck in an endless loop?
* Fix: Clear tag and file field on update
* Preset page content
2018-07-10 08:27:56 -04:00
Michael
0ab9f2e265
Preparations to not store the tags in the item table anymore
2018-06-30 13:54:01 +00:00
Michael
76dab3b2d7
Use gravity instead of verb
2018-06-27 18:09:33 +00:00
Michael
6e10de9284
New function to fetch item data especially for users
2018-06-17 17:05:17 +00:00
Michael
abef0cd46c
Don't use the author-link anymore - just author-id
2018-06-16 15:35:30 +00:00
Michael
bb79b8f4ac
More item calls have been replaced with the new functions
2018-06-15 22:30:49 +00:00
Hypolite Petovan
7469de29f1
Fix corrupt registration emails
...
- Use double quotes for line break-containing translation string
- Simplify HTML/plaintext email body conversion
2018-06-14 23:42:08 -04:00
Michael
5d9083c369
Bugfix in notifications / network and display are using the new functions now
2018-06-10 07:26:37 +00:00
Michael
baf316e898
The central item fetch does work now and the API now uses these functions
2018-06-09 16:56:37 +00:00
Michael
3f07d01dd1
Get rid of unneeded or redundant fields
2018-06-03 07:42:56 +00:00
Tobias Diekershoff
d149541dba
notify admin when user deletes account
2018-04-15 11:39:05 +02:00
Hypolite Petovan
32ca95a1b0
Use App->getSenderEmailAddress in include/enotify
2018-04-06 21:47:42 -04:00
Hypolite Petovan
27d94023ee
Merge branch 'master' into develop
2018-03-23 06:15:55 -04:00
fabrixxm
8a2a4510ec
Small fixes to translatable string
...
and some small cosmetic fixup to docstring for `notification()`
2018-03-19 10:15:09 +01:00
Hypolite Petovan
789561c7a2
Remove/Update references to include/html2*.php
2018-03-07 16:34:17 -05:00
Hypolite Petovan
9e3bae5caa
Remove references to include/bbcode.php
2018-02-14 22:01:14 -05:00
Hypolite Petovan
0c52866693
Refactor bbcode() into BBCode::convert()
2018-02-14 21:33:55 -05:00
Hypolite Petovan
5e7285b9ba
Move Temporal::convert() to DateTimeFormat::convert()
2018-02-03 08:56:55 -05:00
Hypolite Petovan
8aff8a76eb
Add Temporal::utcNow()
2018-02-03 08:56:52 -05:00
Hypolite Petovan
dc366bf1f7
Refactor datetime_convert into Temporal::convert
...
- Changed parameter order to save space
- Refactor select_timezone into Temporal::getTimezoneSelect
- Refactor field_timezone into Temporal::getTimezoneField
2018-02-03 08:56:51 -05:00
Hypolite Petovan
9cd3b17743
Fix translation strings for use with util/extract.php
...
- Change parentheses to “\x28” and “\x29”
- Remove leading commas
- Remove quotes before commas
2018-01-24 16:51:32 -05:00
Adam Magness
208a149a7b
Review sprintf
...
remove more sprintf calls
2018-01-23 21:59:16 -05:00
Adam Magness
f0725ae384
Hopefully all t()
...
hopefully the last of the t()
2018-01-22 18:03:26 -05:00
Adam Magness
83f1149d04
More missing t()
...
update t() calls
2018-01-22 18:03:26 -05:00
Adam Magness
d49f986d1e
Many t() calls
...
modify many t() calls.
2018-01-22 18:03:26 -05:00
Adam Magness
c8ecc31405
Update functions and calls
...
Update function names and calls.
2018-01-22 18:03:26 -05:00
Adam Magness
11cf36105c
Update Addon functions and calls
...
Update function names and calls for Addon class.
2018-01-20 07:48:22 -05:00
Hypolite Petovan
e36f2bb1fb
Use short form array syntax everywhere
...
- Add short form array syntax to po2php.php generation
2018-01-15 14:07:17 -05:00
Michael
6f1b1aee4b
Bugfix: The name of the item owner was empty in notifications
2018-01-11 22:07:41 +00:00
Hypolite Petovan
5fc4927764
Improve dba::selectFirst calls
...
- Fix remaining $r[0] references
- Rename $r to meaningful names
2018-01-11 03:43:57 -05:00
Hypolite Petovan
1fda0ae4ae
Replace select(limit => 1) by selectFirst() in Model\Term and include/enotify
...
- Add new array declaration syntax
- Add braces
2018-01-10 13:04:00 -05:00
Hypolite Petovan
ae66bcaff3
Rename selectOne to selectFirst
2018-01-10 12:57:21 -05:00
Hypolite Petovan
da60893590
Replace dba::select(limit => 1) by dba::selectOne
...
- Convert array declarations to new style
2018-01-10 12:57:21 -05:00
Michael
24d7b2af82
One more query
2018-01-07 18:11:48 +00:00
Michael
28d3980fab
Changed queries
2018-01-07 18:06:06 +00:00
Michael
708d034c6d
We have to check for the contacts uid not the item
s uid
2018-01-07 12:10:31 +00:00
Michael
f2efd58366
Sends notifications for public posts with "uid=0"
2018-01-07 11:08:36 +00:00
Hypolite Petovan
35a18f6825
Fix unused code in include (second pass)
2018-01-04 12:21:13 -05:00
Hypolite Petovan
3b23f89ca2
Fix unused code in include
...
- Fix local formatting
- Remove unused variable
- Fix unreached breaks
- Remove commented out code
- Add some documentation
2018-01-04 12:21:13 -05:00
Adam Magness
f21feb975d
Require Cleanup
...
Remove instances of require_once for email.php
2017-12-01 14:57:13 -05:00
Adam Magness
1726ededac
Emailer to src
...
Move emailer to src Friendica\Util namespace
2017-11-20 15:37:30 -05:00
Adam Magness
4ca68c7af0
Class file relocations
...
Issue #3878
2017-11-08 08:37:03 -05:00
Adam Magness
0dfa57948f
Issue-#3873
...
Replace deprecated functions with new syntax.
2017-11-07 06:24:39 -05:00
Michael
637eb0bfb4
Bugfix: Mails weren't sent
2017-09-08 15:14:33 +00:00
Michael
5adfeb0bd5
App::get_baseurl is now replaced with System::baseUrl
2017-08-26 07:32:10 +00:00
Michael
3c24bed412
New class "System"
2017-08-26 06:04:21 +00:00
Michael
51f6c46923
Issue 3616: Don't create notifications for forum accounts
2017-08-12 05:08:45 +00:00
Hypolite Petovan
ad4cdf2a9d
Replace lowercase operators
2017-06-08 21:03:44 -04:00
Hypolite Petovan
9c0d2c31e8
Replace AND and OR in PHP conditions by && and ||
2017-06-07 22:00:59 -04:00
Michael
05c890f256
Bugfix: The commit in dba::delete was never executed
2017-05-14 07:01:38 +00:00
Hypolite Petovan
20043914e6
Move App to src
...
- Add `use Friendica\App;` wherever needed
2017-05-02 22:59:36 -04:00
Roland Haeder
ec57babf89
added spaces + some curly braces + some usage of dbm::is_result()
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2017-04-20 22:59:08 +02:00
Hypolite Petovan
7b352f3f74
Revert "Coding convention applied - part 1"
2017-03-21 12:02:59 -04:00
Roland Häder
41a36606c6
added spaces + some curly braces
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2017-03-19 00:50:19 +01:00
Michael
c221376041
Some notification thingy
2017-01-04 23:12:28 +00:00
Roland Häder
884f44ce94
*much* more usage of App::get_baseurl() instead of $a->get_baseurl() (coding convention applied)
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2016-12-19 14:27:16 +01:00
Roland Häder
23d4db5149
Continued with #3010 :
...
- removed added debug messages (maybe they will come back in accordance to
code-style guidelines?)
- converted $a->get_baseurl() back to App::get_baseurl()
- reverted back other code I have touched/merged as this was double:
(substr($url, 0, 4) !== 'http') on $url = 'https://bla '; will be FALSE
(means found http at start), too.
Signed-off-by: Roland Häder <roland@mxchange.org>
2016-12-14 16:59:35 +01:00
Roland Häder
a905522eb5
Cleanup for #3010 - added spaces, thanks to @annando .
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2016-12-14 09:42:36 +01:00
Roland Häder
63610c7b73
Merge branch 'rewrites/dbm_is_result' of github.com:Quix0r/friendica into rewrites/dbm_is_result
...
Signed-off-by: Roland Häder <roland@mxchange.org>
Conflicts:
include/Photo.php
include/api.php
include/cache.php
include/dbstructure.php
include/enotify.php
include/items.php
include/onepoll.php
include/queue_fn.php
include/session.php
include/text.php
mod/contacts.php
mod/dfrn_request.php
mod/display.php
mod/events.php
mod/item.php
mod/message.php
mod/msearch.php
mod/photos.php
mod/poco.php
mod/profile.php
mod/proxy.php
mod/videos.php
update.php
view/theme/diabook/theme.php
view/theme/vier/theme.php
2016-12-13 11:00:44 +01:00
Roland Häder
6a8a36f12d
More usage of dbm::is_result($r) instead of count($r):
...
- count() returns very different results and never a boolean (not even false on
error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
done in PHP because of its lazyness. But it is discouraged if it comes to
more clean code.
Signed-off-by: Roland Häder <roland@mxchange.org>
2016-12-13 10:44:13 +01:00
Roland Häder
293436e5fd
Some rewrites:
...
- max_proccesses_reach() and maxload_reached() (why no _ behind max?) are called
both way, static and with object reference.
- this is strongly discouraged and should be avoided as its support (in PHP) may
be dropped in future releases.
- used $a = get_app(); to encapsulate code (even when the function does
currently the same, it may be changed later)
Signed-off-by: Roland Häder <roland@mxchange.org>
2016-12-13 10:16:36 +01:00
Tobias Diekershoff
3a2ec5e4db
missing placeholder for name_cache value
2016-11-03 14:00:20 +01:00
Hypolite Petovan
f1c855e755
ping.php performance: Cache notification bbcode
...
- Add two fields to notifiy table to store cached bbcode result
- Add bbcode conversion on notif creation
- Add postfact caching if cache field is empty on retrieval
2016-10-28 06:28:16 -04:00
Hypolite Petovan
f0382bb159
Restore admin notification email on register approval
...
- Reverted changes to mod/register.php
- Added "show_in_notification_page" flag to prevent `notify` DB
insertion
2016-09-30 08:57:16 -04:00
Roland Haeder
c825cc8d0d
This merge brings back dbm::is_result() where I could find it.
...
Merge branch 'develop' of github.com:friendica/friendica into rhaeder-develop
Signed-off-by: Roland Haeder <roland@mxchange.org>
2016-09-18 23:21:18 +02:00
Michael Vogel
a1691664f3
Bugfix: Under certain circumstances notifications were send
2016-05-21 13:19:30 +02:00
Roland Haeder
3e701b90ac
Continued rewriting:
...
- use dba::is_result() everywhere (where I found the old, bad way)
- converted some spaces -> tabs for code
- converted some CRLF -> LF as mixures of both is not good
Signed-off-by: Roland Haeder <roland@mxchange.org>
2016-05-01 14:24:44 +02:00