Commit Graph

7505 Commits

Author SHA1 Message Date
Hypolite Petovan d99286640d
Merge pull request #10348 from annando/fix-diaspora-comment
Fix commenting on mobile to Diaspora
2021-05-31 19:27:53 -04:00
Michael 58531a2748 Fix tests 2021-05-31 20:02:53 +00:00
Michael be7a01f086 Fix commenting on mobile to Diaspora 2021-05-31 19:39:50 +00:00
Hypolite Petovan 52cf924558 Check for post-type key existence in Model\Item::addVisualAttachments
- Address https://github.com/friendica/friendica/issues/10169#issuecomment-844324800
2021-05-31 08:29:50 -04:00
Hypolite Petovan 303c9d4a54 Check Content\Item::replaceTag return for false return value before using it
- Address https://github.com/friendica/friendica/issues/10169#issuecomment-835547443
- Remove unused code in Content\Item::replaceTag
2021-05-31 08:29:50 -04:00
Hypolite Petovan 302070875c Ensure nodeinfo-provided protocols are strings in Model\GServer::parseNodeinfo2
- https://github.com/friendica/friendica/issues/10168#issuecomment-828281803
2021-05-31 00:47:03 -04:00
Philipp bdc2cd000b
Update avatar after user creation 2021-05-30 20:47:21 +02:00
Michael 2df14fab3b Ensure that the public contact exists when a user is created 2021-05-30 12:04:26 +00:00
Hypolite Petovan 9b9449c03c
Merge pull request #10340 from annando/relevant-url
Add relevant link after media links had been removed
2021-05-30 07:50:43 -04:00
Hypolite Petovan 15581ba91f
Merge pull request #10338 from annando/issue-9923
Issue 9923: Fix DB Error 1055
2021-05-30 07:48:49 -04:00
Michael 6f730bd671 Add relevant link after media links had been removed 2021-05-30 06:13:20 +00:00
Michael c05c447d0f Avoid warning "array_merge(): Expected parameter 2 to be an array, null given" 2021-05-29 22:48:06 +00:00
Michael 4cdfcb5cfb Avoid DB Errors with "group by" 2021-05-29 21:51:33 +00:00
Michael 6c90005363 Issue 9923: Fix DB Error 1055 2021-05-29 21:28:40 +00:00
Michael da20b48651 Fix PHP Notice: Undefined index: isForum in /src/Protocol/ActivityPub/Processor.php on line 605 2021-05-29 19:09:41 +00:00
Hypolite Petovan 452ed8aa8c
Merge pull request #10332 from annando/calender-download
simplify the calendar download
2021-05-29 13:46:41 -04:00
Michael 0249048534 More logging for the contact discovery 2021-05-29 17:24:50 +00:00
Michael a9302c30c3 simplify the calendar download 2021-05-29 17:09:45 +00:00
Hypolite Petovan b621d2c714
Merge pull request #10329 from annando/unified-request
API: Unified request parameter handling
2021-05-29 10:53:16 -04:00
Michael Vogel 1ca58968f2
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-29 14:32:31 +02:00
Michael b28acc7dad Improved logging for local probing, avoid worker fork 2021-05-29 11:11:26 +00:00
Michael c3c6f3c8d3 Code style conventions 2021-05-29 10:40:47 +00:00
Michael 97356ed617 API: Unified request parameter handling 2021-05-28 06:10:32 +00:00
Michael ce8e5012e9 Fix reshare of Diaspora posts only with pictures 2021-05-27 19:58:18 +00:00
Hypolite Petovan 7af91bafec
Merge pull request #10324 from annando/issue-10262
Issue 10262: Don't accept BCC posts from non followers
2021-05-27 11:40:14 -04:00
Michael c076545e3b API: Only show "bookmarked" on top level post 2021-05-27 10:49:15 +00:00
Michael 8b3884b2de API: Bookmarked posts are starred, not pinned 2021-05-27 07:51:30 +00:00
Michael 403cce25c4 Follower is sharer instead 2021-05-27 04:00:38 +00:00
Michael a3c323b366 Issue 10262: Don't accept BCC posts from non followers 2021-05-26 20:52:39 +00:00
Hypolite Petovan 8c99d3acc1
Merge pull request #10323 from annando/issue-10306
Issue 10306: Improve local delivery
2021-05-26 14:24:24 -04:00
Michael c6a56985a8 Changed comments 2021-05-26 18:15:07 +00:00
Michael 76e6a71822 Setting the post reason 2021-05-26 14:29:50 +00:00
Michael 016911a20c Setting the post reason and causer 2021-05-26 14:21:28 +00:00
Michael 785f8124ed Issue 10306: Improve local delivery 2021-05-26 09:24:37 +00:00
Philipp 681f55315b
Downgrading PHP 7.4 incompatible fread/fwrite checks 2021-05-25 20:21:51 +02:00
Michael ee5209a847 Improved logging 2021-05-25 13:18:48 +00:00
Michael 09f29cd577 Avoid notices because of empty fields 2021-05-25 13:11:23 +00:00
Michael 4d4544ada3 Separate the char from the binary handling 2021-05-24 20:07:39 +00:00
Michael da8d5f5015 Issue 9926: Limit the length of data to store in the apcontact table 2021-05-24 19:44:24 +00:00
Hypolite Petovan 6ef9ccbb97
Merge pull request #10311 from fabrixxm/fix/consoleautoinstall
console autoinstall: handle `-f/--file` as single config file
2021-05-24 10:30:45 -04:00
fabrixxm c45a1d1e4d autoinstall: compact output 2021-05-24 15:27:23 +02:00
fabrixxm 613cdf7ee1 autoinstall: handle -f/--file as single config file
as help string says.
2021-05-24 15:21:24 +02:00
Michael 32d0d45adf Issue 10287: Don't show ignored and blocked posts 2021-05-24 10:51:21 +00:00
Hypolite Petovan de2c43ce4b
Merge pull request #10294 from annando/http-input-data
New class to process HTTP input data
2021-05-24 06:11:23 -04:00
Michael 6e1402f7bd Calling it static 2021-05-24 08:08:01 +00:00
Michael 3e303fb366 Test file uploads 2021-05-24 07:43:42 +00:00
Michael ca5fd01f75 Transmit encoding, deactivated file test 2021-05-24 05:33:34 +00:00
Michael 7b49117801 Return data should be array 2021-05-24 05:22:25 +00:00
Hypolite Petovan a24febb8b6
Merge pull request #10283 from very-ape/fix-message-button
Fix message button using a more targeted approach.
2021-05-23 18:49:21 -04:00
Philipp 15216266d9
Add ContentType Injection for HTTPInputData tests 2021-05-23 22:40:41 +02:00
very-ape 7776c5f690 Implement code changes from review. 2021-05-23 13:25:25 -07:00
Michael a69e128fe4 Merge remote-tracking branch 'upstream/2021.06-rc' into http-input-data 2021-05-23 20:17:50 +00:00
Philipp c064a39341
Adapt tests using a content file 2021-05-23 20:30:27 +02:00
Philipp a0da84b6b0
Enable testability for HTTPInputData and create a failing test for it :-) 2021-05-23 19:58:09 +02:00
Michael 4ac68394c3 Fix warning "reset() expects parameter 1 to be array, null given" 2021-05-23 16:37:34 +00:00
Hypolite Petovan 48a783c91a
Merge pull request #10300 from annando/issue-10264
Issue 10264: Remote comments for visitors
2021-05-23 12:00:53 -04:00
Tobias Diekershoff 0ca929dccd
Merge pull request #10304 from annando/fix-emptymissing-photos
Fix missing media on posts to Mastodon
2021-05-23 15:34:34 +02:00
Michael 36c5e360f6 Fix missing media on posts to Mastodon 2021-05-23 13:29:25 +00:00
Michael b7a7ae58e9 Issue 10232: Improved search for embedded media links 2021-05-23 12:35:05 +00:00
Hypolite Petovan 4d214bd9cb
Merge pull request #10292 from annando/fix-mail
Fix inserting mails
2021-05-23 07:39:00 -04:00
Hypolite Petovan 0238a15809
Merge pull request #10295 from nupplaphil/bug/php7_cs
Fix PHP 7.0 Coding Standards
2021-05-23 07:38:38 -04:00
Michael 050bc673aa Issue 10264: Remote comments for visitors 2021-05-23 10:39:11 +00:00
Michael 8f9033633c Issue 10287: Make block and ignore work for the API as well 2021-05-23 08:56:24 +00:00
Tobias Diekershoff 55dda47f39 Issue 10293: mention the required function in the error message 2021-05-23 07:50:32 +02:00
Michael Vogel d00a4eacdc
Update src/Model/Mail.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-23 07:37:17 +02:00
very-ape b2bc911eb2 Merge branch 'fix-message-button' of https://github.com/very-ape/friendica into fix-message-button 2021-05-22 15:32:08 -07:00
very-ape ceb409dae8 Replace $contact with $profile_contact in sidebar function. 2021-05-22 15:30:46 -07:00
Philipp 965cd8b096
Fix PHP 7.0 Coding Standards 2021-05-22 23:47:35 +02:00
Michael fd3706b72e Coding standards again 2021-05-22 20:33:26 +00:00
Michael 684f9cdb96 Coding standards 2021-05-22 20:31:50 +00:00
Michael 2c6db3ccac Coding standards 2021-05-22 20:29:15 +00:00
Michael 6f44476c56 Merge remote-tracking branch 'upstream/2021.06-rc' into http-input-data 2021-05-22 20:26:32 +00:00
Michael c18cbe95a6 Fix inserting mails 2021-05-22 18:20:11 +00:00
Tobias Diekershoff 83cb4edc36
Merge pull request #10291 from annando/no-summary
Don't create automated summaries
2021-05-22 18:17:43 +02:00
Michael 77092157fe Don't create automated summaries 2021-05-22 16:11:10 +00:00
Michael ede808f449 Fixes "Undefined index: upubkey" by replacing the profile load mechanism 2021-05-22 15:50:05 +00:00
Michael a5c8c4d8b7 Fixes notice 2021-05-22 15:41:25 +00:00
Michael 6fe916a390 API: improved mail handling 2021-05-22 13:37:04 +00:00
Michael 0c21588ab9 Don't delete local tombstone contacts 2021-05-22 08:25:30 +00:00
very-ape bd9a469392
Merge branch '2021.06-rc' into fix-message-button 2021-05-21 23:40:49 -07:00
very-ape 34eb81a187 Don't retrieve a contact record we've already been given. 2021-05-21 22:49:35 -07:00
Michael 9d4b29d9c0 Fix for empty profile pages 2021-05-22 05:34:10 +00:00
very-ape c22ef3e79e Fix message button using a more targeted approach. 2021-05-21 14:28:01 -07:00
Hypolite Petovan 26d3f5433b
Merge pull request #10280 from very-ape/fix-message-button
Fix Message button.
2021-05-21 14:57:28 -04:00
very-ape 97a9ec4e40 Bug fix: last commit results in logged-in user's contacts being displayed on contact profile sidebar. 2021-05-21 11:38:50 -07:00
Michael 081652e09a Wrong class path 2021-05-21 18:00:03 +00:00
Michael bcb2073c9a New class to process HTTP input data 2021-05-21 17:36:51 +00:00
very-ape 93926e99b8 Use getByNickname as suggested in code review. 2021-05-21 10:15:32 -07:00
very-ape fe52719d37 Fix Message button. 2021-05-20 23:30:42 -07:00
Hypolite Petovan 315dddbcb9
Merge pull request #10277 from very-ape/authenticate-hook
Bug fix: allow authentication addons to create users again.
2021-05-20 15:05:55 -04:00
very-ape e2d93b57da
Update src/Model/User.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-20 11:54:30 -07:00
very-ape d66f1e30ae Apply suggestions from code review
Also clean up some code, make it less needlessly verbose.

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-20 11:35:33 -07:00
Hypolite Petovan 0e368c4ba4 Fix display of RTL tags 2021-05-20 08:39:36 -04:00
Hypolite Petovan 93f3c511dc Fix wrong display of mentions in RTL context 2021-05-20 08:39:36 -04:00
very-ape c89241dbd8 Bug fix: add missing changes. 2021-05-20 00:19:09 -07:00
very-ape 9ab57de356 Bug fix: allow authentication addons to create users again. 2021-05-20 00:16:08 -07:00
Tobias Diekershoff 57ff3e3a07
Merge pull request #10276 from annando/api-conversations
API: Support for private mails
2021-05-20 09:13:50 +02:00
Michael f5f919aead Coding standards 2021-05-20 06:58:15 +00:00
Michael e10f3f26b9 Removed unused parameter 2021-05-20 04:44:45 +00:00
Michael db8b0b9666 The next mail endpoint is done 2021-05-20 04:39:45 +00:00
Michael 8a3db0226b Coding standards 2021-05-20 03:53:48 +00:00
Michael 66ad777f4b Supporting all parameters 2021-05-19 22:33:40 +00:00
Michael 3d65ef3af2 Indentions 2021-05-19 22:20:56 +00:00
Michael d46150f1dc Whitespaces ... 2021-05-19 22:18:30 +00:00
Michael ae6dae3b23 Whitespace removed 2021-05-19 22:10:05 +00:00
Michael c1212dce03 Indentions 2021-05-19 22:09:25 +00:00
Michael 70259965df API: Support for private mails 2021-05-19 21:56:50 +00:00
Hypolite Petovan 09cf32926d
Merge pull request #10275 from very-ape/authenticate-hook
Move the 'authenticate' hook deeper into the authentication flow so t…
2021-05-19 16:51:15 -04:00
very-ape 9ddaabc22d Move the 'authenticate' hook deeper into the authentication flow so that password authentication addons are consulted whenever a user's password needs confirming. 2021-05-19 13:11:31 -07:00
Michael fcc18de9c5 Unneeded spaces removed 2021-05-19 16:09:09 +00:00
Michael ab96e694df Removed unused use 2021-05-19 16:07:37 +00:00
Michael 1c7d1c7c47 New endpoint "verify_credentials" added 2021-05-19 09:35:08 +00:00
Michael 3172b0bcf2 Log API errors 2021-05-19 09:03:41 +00:00
Michael b3b9c51dbe Reduced log level 2021-05-19 07:02:12 +00:00
Michael 50ca38a0f7 Harmonized API parameters for all timeline endpoints 2021-05-19 06:55:08 +00:00
Michael e3d227f3c9 API: Parameter cleanup 2021-05-19 06:18:42 +00:00
Michael e5c1b90668 API: Reworked request parameter handling 2021-05-18 19:26:46 +00:00
Michael f935c1cf73 Restructured variable handling 2021-05-18 08:38:04 +00:00
Michael 724a61390f Coding standards 2021-05-18 07:23:18 +00:00
Michael 2252949bca Style stuff ... 2021-05-18 07:18:31 +00:00
Michael f31fdf4391 Spaces 2021-05-18 07:13:32 +00:00
Michael 8ae29eabe8 Min is max 2021-05-18 07:02:50 +00:00
Michael 0a6127ea6e Set maximum value 2021-05-18 07:01:23 +00:00
Michael ce427b248e Central function to process request parameters 2021-05-18 06:31:22 +00:00
Michael 32e7ddf21b Improved parameter assignment 2021-05-18 04:54:37 +00:00
Michael 71a398277d Improved query 2021-05-17 22:44:42 +00:00
Michael 59cff3511b Standards 2021-05-17 22:31:35 +00:00
Michael c9110e03e1 API: Search endpoint 2021-05-17 22:22:51 +00:00
Michael 916c51c630 Fix fatal errors / added some API todo 2021-05-17 19:20:31 +00:00
Michael d46db31475 Reverted context 2021-05-17 06:04:48 +00:00
Michael 48d703d278 Fiy missing "in" 2021-05-17 06:03:14 +00:00
Michael 2e6cf056c1 Whitespace removed 2021-05-17 06:01:47 +00:00
Michael cb7206d92f Reverted yesterdays panic coding 2021-05-17 05:59:41 +00:00
Michael ce6b4c27ea Use locally stored original w3c documents 2021-05-17 05:51:14 +00:00
Michael 96ae7ce525 Merge branch 'apcontact-no-normalize' of github.com:annando/friendica into apcontact-no-normalize 2021-05-16 20:58:19 +00:00
Michael c21d991208 Use local copy of the w3id security context 2021-05-16 20:58:11 +00:00
Hypolite Petovan a44cf44708
Remove duplicated conditions, improve variables names in Model\APContact 2021-05-16 16:10:22 -04:00
Michael 4b4218f516 Compact using a predefined context to fix content from Pleroma 2021-05-16 19:31:10 +00:00
Michael 6f2fcd2859 Don't use compacted data when parsing accounts 2021-05-16 16:41:07 +00:00
Hypolite Petovan a4a2f4616c
Merge pull request #10256 from annando/fix-ap
Quickfix for current Json-LD problems
2021-05-16 11:06:47 -04:00
Michael 5ea44960e0 Additional change to the quickfix 2021-05-16 14:59:02 +00:00
Michael 4c72d2c34a Quickfix for current Json-LD problems 2021-05-16 14:32:06 +00:00
Michael dd16bccbc8 Fix for sending content via connectors 2021-05-16 14:30:15 +00:00
Michael 14c1f7167a API: We now can upload photos 2021-05-16 09:56:02 +00:00
Michael 49207a8624 Added scope check 2021-05-16 07:37:11 +00:00
Michael 1cc341033f API: We now can post statuses via API 2021-05-15 22:40:57 +00:00
Michael f001f52e39 API: Fix relationships 2021-05-15 15:02:15 +00:00
Michael 78dab01696 "UpdateCredentials" dummy added (currently not working) 2021-05-15 12:13:03 +00:00
Michael 9c427cc05d Unused use 2021-05-15 10:59:22 +00:00
Michael 6a5083d918 Fixed message, relationships endpoint added 2021-05-15 10:55:41 +00:00
Michael b34ee320b0 API: Many item related endpoints added 2021-05-15 10:08:47 +00:00
Michael 45c2cc3887 API: Account actions 2021-05-14 21:51:32 +00:00
Michael 0aaaf8d6ef API: Support OAuth client credentials 2021-05-14 06:05:01 +00:00
Michael 55919dbd06 API: The instance record had got a malformatted value 2021-05-14 05:09:11 +00:00
Michael 6eb3874646 Merge remote-tracking branch 'upstream/develop' into api-lists-missing 2021-05-13 22:01:19 +00:00
Michael 8b841dfa50 Fix connection issues with AndStatus 2021-05-13 22:00:40 +00:00
Michael 3aa883f1e3 API: List handling, dummy endpoints 2021-05-13 21:15:32 +00:00
Tobias Diekershoff af1896f4d2
Merge pull request #10231 from MrPetovan/bug/warnings
Make birthday time comparison 32-bit safe in Protocol\DFRN
2021-05-13 17:58:59 +02:00
Michael 5219080149 Fix url comparism 2021-05-13 15:01:35 +00:00
Michael b18073d5a8 Repurposed OAuth frontend handling, store the scope 2021-05-13 14:58:55 +00:00
Michael 132e08edb8 Whitespaces ... 2021-05-13 11:33:07 +00:00
Michael 7975bc244d Refine OAuth flow 2021-05-13 11:26:56 +00:00
Michael 494e852c1a Removed old comment 2021-05-12 15:41:05 +00:00
Michael 9125d296a1 Improved error messages 2021-05-12 14:00:15 +00:00
Michael 8a5560ec8f Simplified null check 2021-05-12 12:40:45 +00:00
Michael 4a6d33e182 HTTP_AUTHORIZATION should be enough 2021-05-12 12:34:55 +00:00
Michael 8dccb66dec Display the application name 2021-05-12 12:19:15 +00:00
Michael 19a81d25d5 Added documentation headers 2021-05-12 12:08:30 +00:00
Michael 87f7e26638 Added documentation 2021-05-12 12:00:24 +00:00
Michael daa832fcf9 Formatting 2021-05-12 11:54:43 +00:00
Michael c3f28252ff Indention 2021-05-12 10:50:01 +00:00
Michael a23d108fa7 Session variable needs to be removed afterwards 2021-05-12 06:51:59 +00:00
Michael 6ca42512e9 OAuth connections now have to be ackknowledged 2021-05-12 06:50:27 +00:00
Michael c22846339a Improved error reporting 2021-05-12 05:30:21 +00:00
Michael d1e109d9be Improved error handling 2021-05-12 03:05:22 +00:00
Michael Vogel e99117ac22
Update src/Module/OAuth/Authorize.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2021-05-12 03:53:40 +02:00
Michael 4476634f6c Fix list of accounts 2021-05-11 23:39:08 +00:00
Michael 975c32116d Handling media in shared posts 2021-05-11 23:10:59 +00:00
Michael e9fe92a5d7 Merge remote-tracking branch 'upstream/develop' into api-again 2021-05-11 21:21:32 +00:00
Michael f5e98c8ecf Redirect at login does work 2021-05-11 21:04:45 +00:00
Hypolite Petovan cac038639d Capitalize post action translation strings 2021-05-11 16:01:07 -04:00
Michael 8eacfbc570 Fix context order / notice fixed 2021-05-11 19:53:19 +00:00
Michael bade0a2345 Improved cards handling, simplified Bearer handling 2021-05-11 19:15:05 +00:00
Michael 7d8c152aaf Check the start of the string 2021-05-11 13:17:48 +00:00
Michael 74f3c885bf use "random_bytes" instead of "openssl_random_pseudo_bytes" 2021-05-11 13:12:12 +00:00
Hypolite Petovan aeef4960a1 Make birthday time comparison 32-bit safe in Protocol\DFRN
- Address https://github.com/friendica/friendica/issues/10168#issuecomment-838221234
2021-05-11 08:10:25 -04:00
Michael cfb9b73205 Store creation date 2021-05-11 08:16:40 +00:00
Michael 0f4920dca8 Unused use 2021-05-11 06:34:31 +00:00
Michael a3d1423562 unused use 2021-05-11 06:33:18 +00:00
Michael c9e6fea74b Code style 2021-05-11 06:31:48 +00:00
Michael 82003bbe47 Login prototype 2021-05-11 06:30:20 +00:00
Tobias Diekershoff 7789ea2507
Merge pull request #10228 from MrPetovan/bug/warnings
[PHP 8] Fix undefined template variables
2021-05-11 06:10:29 +02:00
Hypolite Petovan 10e5630988 Don't assume $a->contact is populated in Object\Post::getCommentBox
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-837238584
- This might reveal some side-effect
2021-05-10 22:03:51 -04:00
Hypolite Petovan 48ac619599 Check unparseURL parameter type in APContact::getByURL
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-832421258
2021-05-10 21:52:26 -04:00
Hypolite Petovan 9ef9fc7c14 Skip URL-less mention terms in Object\Post::getDefaultText
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-830859710
- Added logging to troubleshoot deeper issue
2021-05-10 21:50:42 -04:00
Hypolite Petovan 412a0b3e1c Ensure JsonD data passed to ParseURL::parseParts is an array
- Address https://github.com/friendica/friendica/issues/10167#issuecomment-827894961
2021-05-10 21:32:03 -04:00
Hypolite Petovan 43638fa29b Fix undefined variables in nav.tpl
- Reworked the nav_info hook to include the rest of the array keys defined in Nav::getInfo
- Replaced the theme-specific template variable nav.userinfo with the regular userinfo in frio nav.tpl
- Initialized all the nav array keys
2021-05-10 19:03:33 -04:00
Hypolite Petovan abc0616d33 Fix undefined variables in profile/vcard.tpl 2021-05-10 18:59:49 -04:00
Hypolite Petovan 2c6bf754d5 Fix undefined variables in wall_thread.tpl
- Remove unused "num_comments_text" template variable
- Remove unused "item.postops" template variable mention
2021-05-10 18:59:09 -04:00
Michael 6644d117f6 Indentions 2021-05-09 22:29:04 +00:00