clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
22,240 Commits 3 Branches 0 Tags 183 MiB
Commit Graph

2579 Commits

Author SHA1 Message Date
Michael b043c7e0f2 Changed constant name to keep compatible with PHP 5 2018-09-28 15:25:20 +00:00
Michael da79566125 Relocated function 2018-09-28 03:56:41 +00:00
Michael 30f67d6e14 removed unneded line 2018-09-27 21:14:01 +00:00
Michael 793387e2b5 Only communicate with contacts that aren't pending 2018-09-27 15:26:20 +00:00
Michael c4994626e9 Corrected function names 2018-09-27 13:31:32 +00:00
Michael de8787dd5b Changed comment 2018-09-27 12:01:16 +00:00
Michael e01d5e4b31 Function naming ... 2018-09-27 11:56:05 +00:00
Michael cb9be8a7ab UUID is now createUUID 2018-09-27 11:52:15 +00:00
Michael 5639054699 Diaspora in AP - and changed function name 2018-09-27 11:39:17 +00:00
Michael fa868fbaf2 Some more documentation 2018-09-27 03:28:56 +00:00
Michael 897929ad40 Avoid warnings, added documentation 2018-09-26 22:45:13 +00:00
Michael 9c62727e1d Added doxygen data 2018-09-26 22:02:14 +00:00
Michael f7d7d94111 Added some doxygen headers 2018-09-26 21:38:37 +00:00
Michael dd38b7e329 Avoid warnings 2018-09-26 20:36:47 +00:00
Michael 60b0759b50 UUID instead of GUID 2018-09-26 20:03:46 +00:00
Michael 9ec30010c5 APContact stuff is moved to an own class 2018-09-26 17:24:29 +00:00
Michael f3814ae1fc Changed conversation url (used for AP) 2018-09-26 13:12:27 +00:00
Michael 4699741f00 Fix delivery only for comments to native networks 2018-09-26 13:00:48 +00:00
Michael 67d2f8594c Some more clean up 2018-09-26 07:42:40 +00:00
Hypolite Petovan c80045edaf Remove obsolete lines from Console\Config 2018-09-25 23:00:00 -04:00
Hypolite Petovan be0f71bedb Add new Cache console command 2018-09-25 22:59:22 -04:00
Hypolite Petovan d420a4dec2 Add informative public static members to Core\Cache 2018-09-25 22:58:04 -04:00
Hypolite Petovan 71c08a044f Add ICacheDriver->getAllKeys method 2018-09-25 22:52:32 -04:00
Hypolite Petovan 640f76b05a Improve doc blocks in cache drivers 2018-09-25 22:51:41 -04:00
Hypolite Petovan d1148f61ea Add missing "outdated" parameter to ICacheDriver->clear in Core\Cache 2018-09-25 22:46:45 -04:00
Michael e91a1dfa8e Cleaned code 2018-09-25 21:18:37 +00:00
Michael 834422d52f Merge remote-tracking branch 'upstream/develop' into ap1 2018-09-24 21:48:40 +00:00
Michael 5e3f71680c Disabled logging 2018-09-24 21:47:10 +00:00
Michael 59c137b946 Variable fix 2018-09-24 05:35:47 +00:00
Hypolite Petovan a6996601d5
Merge pull request #5789 from friendica/master 
Update develop from master-2019.09
 2018-09-23 18:55:20 -04:00
Michael b386add315 Switch contacts from OStatus to ActivityPub 2018-09-23 22:12:12 +00:00
Michael 094c27add6 Update person, undo activity and improved security checks 2018-09-23 19:25:20 +00:00
Michael 8c7e5bb776 all endpoints are now working 2018-09-23 17:29:31 +00:00
Michael feeec908d3 We can delete notes / changed credits 2018-09-23 09:20:25 +00:00
Michael 6df6d82427 We can now like and dislike 2018-09-23 08:52:07 +00:00
Michael a56565fa99 AP is enabled for all users 2018-09-22 23:49:27 +00:00
Michael ca574e1027 We can now like and dislike 2018-09-22 23:17:01 +00:00
Hypolite Petovan adbc1d3224 Missing $a to $this conversion in App 2018-09-22 12:45:49 -04:00
Michael c083ae047c Merge remote-tracking branch 'upstream/2018.08-rc' into ap1 2018-09-22 15:18:53 +00:00
Michael 214407bdc8 Improve communication 2018-09-22 14:12:54 +00:00
Tobias Diekershoff 684dfd5bbd
Merge pull request #5780 from annando/fix-relocation 
Hopefully fixes relocations that hadn't been executed
 2018-09-22 10:56:11 +02:00
Michael b3e3147697 Issue 5768: This logging should help finding the origin of the problem 2018-09-22 07:09:27 +00:00
Michael 0dbb6313a5 Hopefully fixes relocations that hadn't been executed 2018-09-22 06:47:35 +00:00
Michael b906b083bc The target inbox is now generated after the permission bloxk 2018-09-22 05:58:56 +00:00
Michael 71cbe56293 Use the follower collection 2018-09-22 04:49:16 +00:00
Michael b7744ae3eb Inherit the receivers from the previous post 2018-09-22 04:39:04 +00:00
Michael b44fc62708 Improvements to signature check, private posts do work now again 2018-09-21 22:31:33 +00:00
Benjamin Lorteau 489d5f41d2 Add Doxygen headers for multiple function in App 2018-09-21 09:54:40 -04:00
Benjamin Lorteau f0cdd25e34 Register Friendica stylesheet using App->registerStylesheet() 
- Remove mentions of {{$stylesheet}} in head.tpl templates
 2018-09-21 09:54:09 -04:00
Michael 4c224fbddd Deliver everything to all receivers in the thread 2018-09-21 12:06:36 +00:00
Michael 59cd6611ec Direkt delivery is done 2018-09-21 05:41:18 +00:00
Michael 5310d54c13 Fetch the receiver from the parent posting as well 2018-09-21 04:51:54 +00:00
Michael 355346298b LD signatures will now be checked when receiving messages 2018-09-21 03:39:32 +00:00
Hypolite Petovan 2ae6556b32 Add new 'head' hook 
- Add new App->registerStylesheet method
- Reworked App->init_pagehead into App->initHead
 2018-09-20 21:30:51 -04:00
Hypolite Petovan 1eaa523e61 Remove unused App->page['end'] 
- Remove unused empty templates
 2018-09-20 21:02:28 -04:00
Hypolite Petovan 55f1d7b90e Add new footer hook 
- Add new App->footerScripts array
- Add footer.tpl template
- Add documentation
- Rework App->init_page_end to App->initFooter
 2018-09-20 21:01:05 -04:00
Michael 752b5fe284 Outgoing posts are now signed 2018-09-20 21:45:23 +00:00
Michael 11310f4cf0 Relocated AP signature functions, reduced magic auth functions 2018-09-20 18:16:14 +00:00
Michael 0866fbaf8c Code cleaning / wrong table for flags 2018-09-20 09:50:03 +00:00
Michael 0d51474e73 Relocated function 2018-09-20 05:37:01 +00:00
Michael 34cb0aa406 JSON-LD stuff is now in a separate file 2018-09-20 05:30:07 +00:00
Michael f20bed67a9 Table "apcontact" is now in use / added functionality to handle JSON-LD 2018-09-20 05:00:49 +00:00
Jonny Tischbein 807ad14521 calculate form return_url for post and message instead of using SESSION var 2018-09-19 23:55:29 +02:00
Michael 5de4afecf1 Table for AP contacts, JSON-LD parser included 2018-09-18 22:09:27 +00:00
Michael cb073bea61 Private posts with Mastodon don't work - but this is expected 2018-09-18 19:36:27 +00:00
Michael Vogel bd0515714c
Merge pull request #5765 from MrPetovan/bug/php7-remove-pear-text_highlighter 
[php7] Remove PHP code highlighting
 2018-09-18 18:34:46 +00:00
Michael Vogel 1fa37586ca
Merge pull request #5764 from MrPetovan/task/update-mrpetovan-email-address 
Update "mrpetovan" email address
 2018-09-18 14:26:58 +00:00
Michael 464650d4d7 Public posts to Pleroma do work now, limited posts to Hubzilla and Mastodon as well 2018-09-18 07:28:35 +00:00
Hypolite Petovan 382a7f5acd Create new HTML::toMarkdown wrapper 2018-09-17 23:17:41 -04:00
Michael f772ece86f New delivery module for ap 2018-09-17 21:13:08 +00:00
Michael Vogel e68c48e88f
Merge pull request #5763 from MrPetovan/task/improve-getsiteinfo 
Use OEmbed data when available no matter the type
 2018-09-17 06:40:04 +00:00
Michael 91d1b4de5d We now use the conversation data with AP 2018-09-17 05:51:05 +00:00
Michael 699a4140f9 Now sending does finally work - and some AP standards are improved as well 2018-09-16 20:12:48 +00:00
Michael e4d28629e4 First posting tests 2018-09-16 17:47:00 +00:00
Hypolite Petovan 102adf86ae Restore partial condition in OEmbed block of ParseUrl::getSiteInfo 2018-09-16 09:18:31 -04:00
Hypolite Petovan 96ed7525b7 Improve whitespace display from/to BBCode/HTML 2018-09-16 09:05:54 -04:00
Hypolite Petovan ba4f368b45 Remove references to pear/Text_Highlighter 2018-09-16 09:05:00 -04:00
Hypolite Petovan d6adcb9734 Remove text highlighting from BBCode::convert 
- Move code blocks escaping from BBCode::toMarkdown to BBCode::convert
- Use "language-" class prefix for expected syntax highlighting
 2018-09-16 09:04:25 -04:00
Michael 629cca1963 Added function to fetch missing data, code bugfixing 2018-09-16 13:04:00 +00:00
Michael 6f3b2b6586 Handling of unlisted posts, better uid detection 2018-09-16 09:06:09 +00:00
Michael 1f98414bdd Some code cleanup 2018-09-16 05:49:13 +00:00
Hypolite Petovan 9d0a6f90b6 Update "mrpetovan" email address 
- Fix Tobias' email address
- Fix copypasted doc block in Console/PostUpdate
 2018-09-15 19:28:38 -04:00
Michael a7f5c1f4c6 Likes work now 2018-09-15 23:06:03 +00:00
Michael 2eabe45a8e Contact reject does work now as well 2018-09-15 22:25:58 +00:00
Michael e45206ae5d Merge remote-tracking branch 'upstream/2018.08-rc' into ap1 2018-09-15 20:49:46 +00:00
Michael f5104f3e46 Removed harcoded host names 2018-09-15 20:48:24 +00:00
Michael 86bd283705 The whole contact handling does work now, yeah ... 2018-09-15 20:31:05 +00:00
Michael 6a8ebc8639 Contact follow and unfollow workd partially 2018-09-15 18:54:45 +00:00
Michael 96f575fe28 Processing of personal inbox enabled 2018-09-15 10:14:56 +00:00
Michael 35854a0ad1 Adding "(AP)" to the server name when posted via AP 2018-09-15 10:13:41 +00:00
Michael 957c70d1c6 Several improvements 2018-09-15 07:40:19 +00:00
Michael fb5b6e4a14 New uri format for our posts that is AP compatible 2018-09-15 07:37:34 +00:00
Michael 2e7ca76e15 More fields to import / like could possibly work 2018-09-14 21:10:49 +00:00
Michael 61e2c7d20d Added AP to many network conditions / enabling inbox processing 2018-09-14 16:51:32 +00:00
Hypolite Petovan 5b5e5ef4db Use OEmbed data when available no matter the type 2018-09-13 21:50:52 -04:00
Michael 7b45bdea17 Preparation for adding more networks there 2018-09-13 22:12:33 +00:00
Michael c2f6b166c7 We now use the regular probing function 2018-09-13 21:57:41 +00:00
Michael 8c00e88f79 The endless saga of the fight against notices continues 2018-09-13 21:11:52 +00:00
Hypolite Petovan 70c94abd8e
Merge pull request #5759 from annando/issue-5733 
Issue 5733: Removing contacts does work now on the same machine as well
 2018-09-12 19:40:03 -04:00
Michael f7b03bc5f3 Missing $ 2018-09-12 21:33:44 +00:00
Michael 67fa0ed433 Signature check added 2018-09-12 21:30:10 +00:00
Michael 969311cb44 Replacing the non standard "title" with "name" 2018-09-12 18:48:18 +00:00
Michael 7daa46503d Don't risk incompatibilities 2018-09-12 06:13:04 +00:00
Michael 96d10c25e3 Issue 5733: Removing contacts does work now on the same machine as well 2018-09-12 06:05:14 +00:00
Michael 8c07baf54b Better http answers 2018-09-12 06:01:28 +00:00
Michael f566db52d3 And more notices ... 2018-09-11 08:04:14 +00:00
Michael 8b96a53fba Burn notices, burn 2018-09-11 04:10:11 +00:00
Michael 0a5476591d Activitity pub - first commit with much test code 2018-09-10 21:07:25 +00:00
Hypolite Petovan 791a77f441 Add overwrite parameter to App->loadConfigFile 2018-09-08 02:37:53 -04:00
Michael 99244d33f5 Fix for #5732 - too much links had been detected as photos 2018-09-07 06:10:33 +00:00
Hypolite Petovan 480d792356
Merge pull request #5732 from annando/fix-picture-posts 
Fix: Posts with pictures will now look good again on connector networks
 2018-09-06 19:00:44 -04:00
Michael 2592c3891c forgotten $ 2018-09-06 21:10:48 +00:00
Michael 1d4a5402ff Picture posts do work again - everything else should work as well 2018-09-06 20:30:16 +00:00
Hypolite Petovan e735a14db9
Merge pull request #5736 from annando/issue-5733 
Issue 5733: Changing relationship values does work now again with DFRN
 2018-09-06 13:19:24 -04:00
Hypolite Petovan d27cf0cb60
Merge pull request #5740 from annando/fix-fatal 
Fix fatal error due to missing "use"
 2018-09-06 11:58:07 -04:00
Michael e9a73e4480 Fix fatal error due to missing "use" 2018-09-06 13:27:03 +00:00
Michael 6113fdc940 Issue 5733: Changing relationship values does work now again with DFRN 2018-09-06 09:20:45 +00:00
Philipp Holzer bd2b3b1ef5
LockDriverFixings 
- release Locks in case of failures
- adding some cache tests
 2018-09-06 08:11:18 +02:00
Michael 04fb885857 Fix: Posts with pictures will now look good again on connector networks 2018-09-06 04:24:34 +00:00
rabuzarus 75a2576f78 use magic links in single event view 2018-09-06 01:42:35 +02:00
Michael 9ef1d827f3 Restore the behaviour to remove the remote contact upon termination 2018-09-05 05:02:06 +00:00
Hypolite Petovan 59d06b6c78
Merge pull request #5719 from annando/notices-yeah 
Good news, everyone - again somce notices removed
 2018-09-04 19:09:11 -04:00
Michael 821429fdf1 Good news, everyone - again somce notices removed 2018-09-04 17:48:09 +00:00
Hypolite Petovan 9744f0e780 Update ParseUrl::getSiteinfo type recognition 
- Added obsolete twitter card type provision
 2018-09-02 17:50:27 -04:00
Hypolite Petovan 8bcc3c6860 Fix formatting in Util/ParseUrl 
- Remove commented out code
- Replace double quotes with simple quotes
- Remove parentheses for language construct
- Add spaces around operators
- Rename variables
 2018-09-02 17:46:28 -04:00
Hypolite Petovan 69e7c7feca Fix photo attachment display 
- Remove double image display
- Add domain link display to all attachments
 2018-09-02 17:26:05 -04:00
Michael 5250552fe2 Removed obsolete post update that sometimes never finishes 2018-09-02 17:48:25 +00:00
Tobias Diekershoff deca48e39d
Merge pull request #5711 from annando/and-again 
The days are getting shorter, like the list of removed notices ...
 2018-09-02 14:48:47 +02:00
Michael 703c668a37 More notices ... 2018-09-02 08:01:13 +00:00
Michael fd7e45042a The days are getting shorter, like the list of removed notices ... 2018-09-02 07:47:48 +00:00
Michael 4fcae18289 Issue 5262: Comments to a forum post aren't distributed via push 2018-09-01 03:23:12 +00:00
Michael Vogel 196ef0111c
Merge pull request #5704 from MrPetovan/bug/fix-unfollow 
Fix unfollow sharing-only contacts (except connector protocols)
 2018-08-31 15:40:51 +00:00
Michael 380eeaab88 Still there had been notices - must have a good camouflage 2018-08-31 05:08:22 +00:00
Hypolite Petovan 804cfa0320 Reorganize Protocol constants 
- Add ActivityPub protocol constant
- Add Protocol::NATIVE_SUPPORT
- Sort/group constant names
 2018-08-30 17:47:48 -04:00
Michael a3570d0027 Fix: Missing gserver entries - show correct server platform 2018-08-30 09:52:38 +00:00
Tobias Diekershoff 070e1e73d6
Merge pull request #5702 from annando/and-a-notice 
and now for something completely different: A removed notice
 2018-08-30 06:37:39 +02:00
Michael 02da827560 and now for something completely different: A removed notice 2018-08-30 04:05:32 +00:00
Hypolite Petovan f18650f3b8
Merge pull request #5700 from annando/issue-5653 
Issue 5653: The mastodonemoji addon hadn't got all needed data.
 2018-08-29 20:17:15 -04:00
Michael c72d1bc8fd Issue 5653: The mastodonemoji addon hadn't got all needed data. 2018-08-29 20:46:52 +00:00
Michael 9bff31f18f Issue 5691: Post dates of feeds sometimes had been wrong 2018-08-29 19:11:43 +00:00
Michael Vogel c7f8f190b9 Oh no, even more notices ... (#5697) 2018-08-29 14:28:13 -04:00
Michael 67227570d8 "Does" is now "perform" 2018-08-29 13:06:56 +00:00
Michael Vogel 601851f3d0 Removed notice - pokes do now work mostly (#5693) 2018-08-29 09:00:01 -04:00
Michael d489712824 The post update version can now be set. 2018-08-29 11:48:40 +00:00
Michael Vogel cf6140e86f Ensure that the post update doesn't end prematurely (#5684) 2018-08-28 07:56:25 -04:00
Jeroen De Meerleer 9ddb6abe08 Added widget class to invitationsbox (#5675) 2018-08-27 13:36:44 -04:00
Tobias Diekershoff df3b1be3b7
Merge pull request #5679 from annando/neverending-notices 
The neverending story of removing notices continues ...
 2018-08-27 09:12:38 +02:00
Michael 8d911b1465 The neverending story of removing notices continues ... 2018-08-27 05:37:10 +00:00
Tobias Diekershoff 6c8ed888f5
Merge pull request #5676 from annando/issue-3501 
Issue 3501: Mail contacts can be added again
 2018-08-27 06:16:42 +02:00
Philipp 2838e4ebaf Automatic Install Tests & Doku (#5674) 
* Automatic Installation Testing
- New dev-library "mikey179/vfsStream"
- created "reload" method for App-Reloads
- ConsoleTest now using virtual directory
- Adding Automatic Installation Tests
- Fixing some probable install-failures

* Updating README for Automatic Installation

* Updating README for Automatic Installation

* Bugfix normal installation

* Fixing copying of config files
 2018-08-27 00:15:55 -04:00
Michael 2079caea14 Issue 3501: Mail contacts can be added again 2018-08-26 19:49:39 +00:00
Michael 5e82323456 Avoid useless contact updates 2018-08-26 07:56:33 +00:00
Michael 1280bb56df Removed notices in notifications 2018-08-26 05:27:50 +00:00
Michael Vogel 49dad00570 Issue 5260: Ensure that user data is really deleted (#5666) 
* Issue 5260: Ensure that user data is really deleted

* Missing files
 2018-08-25 17:48:50 -04:00
Michael 927e0ee0a2 Isse 4726: Fixes the condition for showing hidden contacts 2018-08-25 16:38:26 +00:00
Michael Vogel edcd0a3744 Issue 4960: Ignoring and blocking of contacts should work again (#5657) 
* Issue 4960: Ignoring and blocking of contacts should work again

* Renamed functions

* This function should be renamed as well.

* We now have a frontend to block and ignore public contacts

* Hide some parts for public contacts

* Removed notices, public contact is now accessible from dirfind as well

* We now show contact conversations and contact posts

* We now use a new conversation mode

* The update functionality is disabled until it will work completely

* Fixing tabs chaos

* Update after posts on the contacts page will now work

* Show connect link
 2018-08-25 09:48:00 -04:00
Tobias Diekershoff 6a549d4cfb
Merge pull request #5659 from annando/notices-oh-no 
Oh no ... there are still some notices that want to be removed ...
 2018-08-24 14:46:21 +02:00
Michael 82d097879b Oh no ... there are still some notices that want to be removed ... 2018-08-24 11:09:58 +00:00
Roland Häder 61693419e8 Cleanups: isResult() more used, readability improved (#5608) 
* [diaspora]: Maybe SimpleXMLElement is the right type-hint?

* Changes proposed + pre-renaming:
- pre-renamed $db -> $connection
- added TODOs for not allowing bad method invocations (there is a
  BadMethodCallException in SPL)

* If no record is found, below $r[0] will fail with a E_NOTICE and the code
doesn't behave as expected.

* Ops, one more left ...

* Continued:
- added documentation for Contact::updateSslPolicy() method
- added type-hint for $contact of same method
- empty lines added + TODO where the bug origins that $item has no element 'body'

* Added empty lines for better readability

* Cleaned up:
- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)

* Re-fixed DBM -> DBA switch

* Fixes/rewrites:
- use empty()/isset() instead of deprecated x()
- merged 2 nested if() blocks into one
- avoided nested if() block inside else block by rewriting it to elseif()
- $contact_id is an integer, let's test on > 0 here
- added a lot spaces and some empty lines for better readability

* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)

* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
- fixed mixure with "Contact::* rewrite"

* Ops, one still there (return is no function)

* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.

* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...

* Ops, was added accidentally ...

* Ops, why these wrong moves?

* Ops, one to much (thanks to MrPetovan)

* Ops, wrong moving ...

* moved back to original place ...

* spaces added

* empty lines add for better readability.

* convertered spaces -> tab for code indenting.

* CR request: Add space between if and brace.

* CR requests fixed + move reverted
- ops, src/Module/*.php has been moved to src/Network/ accidentally
- reverted some parts in src/Database/DBA.php as pointed out by Annando
- removed internal TODO items
- added some spaces for better readability
 2018-08-24 01:05:49 -04:00
Michael Vogel dc3d2d5988 "dba" is now "DBA". This hadn't been respected at some places (#5655) 
* "dba" is now "DBA". This hadn't been respected at some places

* Cleaning up unneeded stuff
 2018-08-23 09:51:58 -04:00
Michael Vogel 20127a77b3 Removing a small notice in the network.php (#5652) 2018-08-22 18:46:44 -04:00
Michael Vogel 54aee2aaa7 Removed notices that revealed themselfes over night ... (#5645) 
* Removed notices that revealed themselfes over night ...

* And more notices removed that occured over night

* One more ..

* Some more notices of the day ...
 2018-08-21 17:35:09 +02:00
Michael 334c628511 And again ... notices 2018-08-20 21:20:21 +00:00
Philipp d7395299fb Automatic Installation fix (#5565) 
* Automatic Install Config Fix

* new unittest for AutomaticInstallation

* unittest for autoinstall
- removed password check

* removed bak-file

* automatic install
- always save environment variables
- just skip db environment if not `--savedb` is set

* fixed help (options)

* fixed help (options)

* Deleting Auto-Install tests until fix for proper DB restoring
 2018-08-20 16:15:39 -04:00
Michael Vogel 16a081871c Improved profile page, improved "limit" handling (#5639) 
* Improved profile page, improved "limit" handling

* Update will now work again

* Update will work now
 2018-08-20 06:26:05 +02:00
Michael Vogel c1da44b7dc We now use a central function to fetch the importer (#5636) 2018-08-19 13:37:56 +00:00
Michael Vogel 7f3fb34c24 Some easy to replace "q" calls have been replaced by "DBA" calls (#5632) 
* Some easy to replace "q" calls have been replaced by "DBA" calls

* Simplified the GUID creation

* And one in the API ...

* And OStatus has got some DBA calls more

* Just some more replaced database calls

* The event query is now simplified

* Events are now shown again

* subthread is now using the DBA calls as well

* Some more replaced database calls

* And some more replaced database calls and prevented notices

* Better use gravity

* Some more replaced database stuff

* Some more replaced database calls in DFRN.php

* The gcontact class now has got the new DBA functions as well

* The Contact class is now changed to new database functions as well

* Small correction

* We can now delete without cascade

* One more functionality is safe for future changes
 2018-08-19 12:46:10 +00:00
Michael Vogel ab5cedfa50 placeholder for a funny commit description for removing some more notices (#5631) 2018-08-19 01:52:21 +00:00
Michael Vogel 060e887a31 And still there are notices that have to be removed ... (#5629) 
* And still there are notices that have to be removed ...

* Notice removed in ACL part

* Fix missing fields for notifications

* Fixes issue 5630
 2018-08-18 08:20:50 +02:00
Tobias Diekershoff d5c2c41b02
Merge pull request #5626 from annando/notices-oh-yeah 
Removed notices, will it ever end?
 2018-08-17 09:33:02 +02:00
Michael Vogel b6cb83ed4c
Merge pull request #5617 from MrPetovan/task/use-contact-network 
Fix bug with ACL and contact network page
 2018-08-17 05:31:06 +02:00
Michael 0342f9e084 Removed notices, will it ever end? 2018-08-17 03:19:42 +00:00
Michael bb0cf93374 Fix for storing posts of private forums 2018-08-15 20:13:10 +00:00
Tobias Diekershoff 3488b937ea
Merge pull request #5620 from annando/fix-remove 
Fix a fatal error when removing contacts
 2018-08-15 14:31:13 +02:00
Hypolite Petovan 84a3cd747f Revert "Change contact post link to contact network page" 
This reverts commit 4c32661022.
 2018-08-15 12:12:49 +02:00
Michael 6d852ff6fd Fix a fatal error when removing contacts 2018-08-15 09:27:25 +00:00
Michael e8334c4655 Use the Item class instead of DBA calls when possible 2018-08-15 04:41:49 +00:00
Hypolite Petovan 4c32661022 Change contact post link to contact network page 2018-08-15 00:43:45 +02:00
Hypolite Petovan ea17370211 Fix bug with ACL and contact network page 
- Require user array parameter in ACL::getFullSelectorHTML
- Change all wrong uses where user array was replaced by default
permissions array
 2018-08-15 00:43:27 +02:00
Michael Vogel 1283b99c6f Removed notices in the frio theme (#5610) 
* Removed notices in the frio theme

* And fixed notices in the notifications

* And some more in frio

* Null is the default value

* And some small notice in the probing removed

* Added note

* Clarified note

* And a removed notice in OStatus
 2018-08-14 19:37:44 +00:00
Tobias Diekershoff 1ca8d573e6
Merge pull request #5607 from annando/remove-contact 
Remove contacts in the background
 2018-08-13 06:42:08 +02:00
Michael 29aa90ec09 Remove contacts in the background 2018-08-12 17:15:47 +00:00
Michael b3931d066c Issue-5605: Fixes notice 2018-08-12 08:00:37 +00:00
Michael Vogel 880b7177c8 And again, and again, and again, ... some more notices removed (#5601) 
* And again, and again, and again, ... some more notices removed

* And some more notices ...

* Some more place
 2018-08-11 23:05:42 +02:00
Roland Häder e06fc2aa69 Stopped using deprecated constants NETWORK_* (#5537) 
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...

* Removed deprecated NETWORK_* constants as per code reviewer's request.
 2018-08-11 22:40:44 +02:00
Tobias Diekershoff bf5896d4e3
Merge pull request #5598 from annando/issue-3838 
Added a note concerning the question how to fix issue 3838
 2018-08-11 07:48:33 +02:00
Tobias Diekershoff 08fc86802a
Merge pull request #5599 from annando/postupdate 
Console script to ensure that all post updates are finished
 2018-08-11 07:47:28 +02:00
Michael 5037f9c460 Console script to ensure that all post updates are finished 2018-08-10 21:20:25 +00:00
Michael 7d945e8504 Added a note concerning the question how to fix issue 3838 2018-08-10 20:28:41 +00:00
Michael 170dd2a705 Some more removed notices 2018-08-10 19:39:43 +00:00
Michael 77e3e011e3 Hide deprecated networks 2018-08-10 04:59:26 +00:00
Michael f82580c2ef Avoid probing for contacts if we don't want to update 2018-08-09 06:19:23 +00:00
Michael Vogel 276abfaba6 Issue 5158: Ignore all threads, even public ones (#5588) 
* Issue 5158: Ignore all threads, even public ones

* Remove some notice

* Now it really should work

* Using "defaults"
 2018-08-08 22:32:11 +02:00
Michael 0c56538cd5 Notice in tt fixed that happens with chinese translations 2018-08-08 12:17:49 +00:00
Michael Vogel 9eb2c2ec16 Fix for duplicated addon entries in the hook table (#5583) 2018-08-07 23:03:38 +02:00
Michael Vogel eaf81e5e66
Merge pull request #5563 from MrPetovan/bug/5470-fix-various-notices 
Fix various notices
 2018-08-07 21:34:47 +02:00
Michael Vogel 8c2efa6df4 Facebook and App.net is removed from nearly all places (#5581) 
* Facebook is removed from nearly all places

* Remove app.net as well - it's dead for some time now
 2018-08-07 17:06:51 +02:00
Michael 4921303133 Issue 5541: Don't do magic things when the remote site doesn't support it 2018-08-06 19:59:41 +00:00
Michael 3f612e0641 Issue 5436: Don't store tags that are too long 2018-08-06 17:11:40 +00:00
Michael Vogel c032011143 Post update script for setting the uri-id (#5573) 
* Post update is working now

* Changed text.
 2018-08-06 18:40:41 +02:00
Michael Vogel 5e61caa34f Fix for not loading the translation / some more notice removed (#5569) 2018-08-06 12:11:17 +02:00
Hypolite Petovan c0e728e7e5 Fix query string parsing border case in Util\Proxy 2018-08-05 15:57:04 +02:00
Hypolite Petovan 6a57574091 Fix missing $profile['nickname'] in Model\Profile 2018-08-05 15:56:41 +02:00
Hypolite Petovan 45de8a28cd Fix missing $_SESSION variable in src/App 2018-08-05 15:56:21 +02:00
Michael Vogel ef1c73fb6b
Merge pull request #5561 from MrPetovan/bug/4584-fix-twitter-gif-still-image 
Restore source storing for Twitter conversations
 2018-08-05 14:00:19 +02:00
Hypolite Petovan ea45a78218 Increase Twitter parcel constant value 2018-08-05 13:59:33 +02:00
Michael Vogel fa46e97f27 We now store the uri data in a separate table (#5560) 
* We now have a item-uri table

* Fixing line endings

* New item uri table

* Rescued ItemURI.php file

* Reverting some git problem

* Corrected the dbstructure file

* Updated database.sql / we now store content in the new id fields
 2018-08-05 13:09:59 +02:00
Hypolite Petovan c4e69b7766 Add conversation storage for Twitter 2018-08-05 12:34:33 +02:00
Hypolite Petovan 6678208915 Add new Conversation::PARCEL_TWITTER constant 2018-08-05 12:25:47 +02:00
Hypolite Petovan c13dc549ed Rename PROTOCOL_* constants to Model\Conversation::PARCEL_* 
- Remove unused Conversation::PROTOCOL_GS_CONVERSATION constant
- Remove now renamed PROTOCOL_* constant declarations
 2018-08-05 12:24:42 +02:00
Michael Vogel 8dea36bd8f We shouldn't cascade this deletion as well (#5558) 2018-08-05 11:02:36 +02:00
Michael Vogel 2f2b134e58 Fixes issue 5321: Likes can be undone and comments can be deleted again (#5557) 2018-08-05 06:35:11 +02:00
Hypolite Petovan c9b756674a Add CW support to shared posts in Protocol\OStatus 2018-08-04 21:40:45 +02:00
Hypolite Petovan 36975d521f Remove plural from $activityobjects variable name in Protocol\OStatus 2018-08-04 21:39:54 +02:00
Michael Vogel 810c108297 Fix: Notes can be posted again. Never use "defaults" with "false" (#5551) 2018-08-04 16:06:36 +02:00
Hypolite Petovan 6a6695b167 Change DBStructure::definition to use config/dbstructure.json 2018-08-04 13:24:04 +02:00
Michael Vogel 2c8c803d64 Avid notices and warnings (#5546) 2018-08-02 19:07:20 +02:00
Michael Vogel 65d752d03c Notices what else? (#5545) 
* Poco isn't filled, so we cannot store it

* We should initialize our variables
 2018-08-02 16:11:21 +02:00
Michael Vogel c72c64a6d8 Notices again (#5543) 
* And again notices

* Notices in the directory

* Much more places

* Fix some double $

* Notice in ping

* Missing field

* Fix: We now remove deleted users from the directory

* Some more stuff

* Notices when removing users

* Added logging

* More logging

* Two more
 2018-08-02 07:21:01 +02:00
Hypolite Petovan 4d17fb36d1 Fix missing fields in event reminder (#5540) 2018-08-01 09:27:13 +02:00
Michael Vogel 1afc0ab028 Added logging and one more reason for a notice found (#5538) 
* Added logging and one more reason for a notice found

* And one more
 2018-08-01 08:47:18 +02:00
Michael Vogel 9d0f18c0b3 Yeah, and again notices ... (#5536) 
* Yeah, and again notices ...

* And some more

* Block access without given user name

* Reformatting
 2018-08-01 07:29:58 +02:00
Michael Vogel 71b1638d9a Once again, notices ... (#5535) 2018-07-31 18:39:23 +02:00
Michael Vogel b552b711ee And some more notices removed ... (#5533) 
* Fix for vanishing notes

* The field needs to be part of the selected fields ...

* And some more notes ...
 2018-07-31 07:54:25 +02:00
Michael Vogel c39e0dcf2a Fix for vanishing notes (#5531) 
* Fix for vanishing notes

* The field needs to be part of the selected fields ...
 2018-07-30 22:23:48 -04:00
Roland Häder 4d39164c1e [WIP] Rewrite to Proxy class: (#5507) 
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
 2018-07-30 22:06:22 -04:00
Roland Häder bf87ad4fcf Fixed E_NOTICE in listing worker queue and new utilities class added (#5521) 
* Fixes for E_NOTICE in workqueue:
- introduced class `Friendica\Util\Arrays` which will hold static methods for
  handling arrays that cannot be done with PHP's functions, like implode() on
  multi-dimensional arrays
- rewrote old-school for() loop to foreach()

* Added intial unit test with some tests on empty delimiters and/or sinle and
multi-dim array.

* Added test for for 3-dimensional arrays, thanks to  nupplaphil's feedback.
 2018-07-30 21:24:26 -04:00
Michael Vogel 1eb8f04274 Fixing SQL error when receiving DFRN posts (#5527) 
* Some more notices

* Fixed nasty to find notice in DFRN and OStatus

* And more notices ...

* Yeah, some removed notices ... again ...

* Fixing bad SQL query
 2018-07-30 07:06:32 +02:00
Michael Vogel a2cea16954 Some more notices (#5526) 
* Some more notices

* Fixed nasty to find notice in DFRN and OStatus

* And more notices ...

* Yeah, some removed notices ... again ...
 2018-07-30 06:41:20 +02:00
Roland Häder 650c3c18e1
Fixed fatal error about when returned 'body' field is empty: 
````
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Friendica\Protocol\PortableContact::discoverServer() must be of the type array, null given, called in /var/www/../src/Protocol/PortableContact.php on line 1664 and defined in /var/www/../src/Protocol/PortableContact.php:1765
Stack trace:
````
 2018-07-29 17:34:20 +02:00
Tobias Diekershoff 02d4b1098e
Merge pull request #5519 from annando/test-2 
Moved expiring of item content
 2018-07-29 11:45:50 +02:00
Michael 6add589c3f Removed some test logging 2018-07-29 04:38:14 +00:00
Michael bc38420801 Some more notices removed 2018-07-29 04:04:23 +00:00
Michael dc9b10fb09 Moved expiring of item content 2018-07-29 03:54:34 +00:00
Michael Vogel 489d3daa94 Trying to clean up a little bit more (#5517) 
* "post-type" replaces "bookmark" and "type"

* The permission set is now removed upon expiry

* Post update now stores the permission set

* We don't store the permissions in the item table anymore

* Postupdate now handles "postopts" as well

* "post-type" replaces "bookmark" and "type"

* "post-type" replaces "bookmark" and "type"

* "post-type" replaces "bookmark" and "type"

* The permission set is now removed upon expiry

* The permission set is now removed upon expiry

* We don't store the permissions in the item table anymore

* Postupdate now handles "postopts" as well

* Multiplicated update functions

* And some more duplicated functions ...

* Removed duplicate functions
 2018-07-28 16:04:56 -04:00
Michael Vogel 91db91d315 Fix for post update (#5513) 
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

* Fix for post update
 2018-07-28 13:12:35 -04:00
Michael Vogel 36d4516e7a Missing stuff in "develop"? (#5516) 
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

* "post-type" replaces "bookmark" and "type"

* The permission set is now stored

* The permission set is now removed upon expiry

* Postupdate now handles "postopts" as well
 2018-07-28 13:11:46 -04:00
Hypolite Petovan 0902ea508d
Fix parse error in Protocol\PortableContact (#5515) 2018-07-28 08:52:57 -04:00
Roland Häder c30ac30f29 Possible fix for #5470 - json_decode() (#5511) 
* Possible fix for #5470:
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability

* Rewrite:
- mixture of object/array was here, causing under newer PHP versions some E_NOTICE
- this has been now finally fixed by converting any `object` type to an
  associative `array`
- also changed `is_object()` to `is_array()`
 2018-07-28 01:35:27 -04:00
Roland Häder 4a22710b3b Moved global PAGE_* to Profile class (#5500) 
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class

* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*

* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`

* Ops, melting brain cells here ... :-/
 2018-07-27 19:25:57 -04:00
Michael Vogel 5f77e98d76 Postupdate is now working again (#5512) 
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again
 2018-07-27 19:24:26 -04:00
Michael Vogel 1e83261a88
Merge pull request #5509 from friendica/revert-5506-fixes/portable-contact 
Revert "Possible fix for #5470 and empty() usage"
 2018-07-27 08:04:19 +02:00
Michael Vogel 82e3163e5e Revert "Possible fix for #5470: (#5506)" 
This reverts commit 1e20fd84f7.
 2018-07-27 08:02:41 +02:00
Roland Häder 592190892c Continued: (#5508) 
- `App` is now "imported" to avoid having \Friendica\App::* everywhere
 2018-07-26 22:27:28 -04:00
Roland Häder 1e20fd84f7 Possible fix for #5470: (#5506) 
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability
 2018-07-26 18:27:12 -04:00
Michael Vogel 986106a8f7 Item storage: Permissions aren't stored in the items anymore (#5495) 
* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...
 2018-07-25 19:14:55 -04:00
Roland Häder 37253656e3 Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace (#5490) 
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
 2018-07-24 22:53:46 -04:00
Michael Vogel 69af69d1a0 Fallback to Diaspora if DFRN transmission fails (#5487) 2018-07-24 14:12:09 -04:00
Michael Vogel 5a8654194a
Merge pull request #5452 from MrPetovan/bug/5443-fix-worker-notices 
Fix notices in OEmbed et al.
 2018-07-24 17:11:53 +02:00
Hypolite Petovan 6771522167 Reduce cache time for OEmbed error 2018-07-24 11:05:09 -04:00
Michael Vogel be8b68aaaf Store guid and plink with event (#5485) 
* Store guid and plink with event

* One space too much
 2018-07-24 10:01:31 -04:00
Hypolite Petovan b6e3da8443 Move addLanguageToItemArray call when body is ensured 2018-07-24 08:52:25 -04:00
Hypolite Petovan df917251ff Fix undefined oembed properties 
- Add Object\OEmbed class
 2018-07-24 07:56:27 -04:00
Hypolite Petovan adc47fc8ea Fix Undefined index: nurl in Protocol\PortableContact 2018-07-24 07:55:42 -04:00
Hypolite Petovan 41fd5bef13 Fix by reference notice in Protocol\PortableContact 2018-07-24 07:54:12 -04:00
Hypolite Petovan 4e9ba728c4 Fix undefined index body in Model\Item 2018-07-24 07:54:12 -04:00
Hypolite Petovan d09ab35816 Fix getimagesizefromstring() read errors 2018-07-24 07:54:12 -04:00
Michael Vogel ca2c316de0 Some removed notices when viewing events (#5483) 2018-07-24 07:51:50 -04:00
Michael 432eec770b Issue 5467: Cron jobs hadn't been executed 2018-07-24 06:15:58 +00:00
Michael de984cdaa1 Issue 5467: Fix worker and daemon 2018-07-24 03:42:44 +00:00
Hypolite Petovan 30fff2077c Ad missing use statements after dbesc conversion 2018-07-23 18:44:05 -04:00
Hypolite Petovan a6fb3568f9 Rename dbesc to DBA::escape 2018-07-23 15:30:54 -04:00
Hypolite Petovan d3a598f589 Update DBA::escape to match dbesc() 2018-07-23 15:13:42 -04:00
Hypolite Petovan 538b81d10d Delete Database\DBM class file 2018-07-23 11:04:15 -04:00
Hypolite Petovan aa26943f92 Rename DBA::esc_array to DBA::escapeArray 
- Rename internal method DBA::esc_array_callback to
DBA::escapeArrayCallback
 2018-07-23 11:04:15 -04:00
Hypolite Petovan ecea7425f8 Rename DBA::is_result to DBA::isResult 2018-07-23 11:04:14 -04:00
Hypolite Petovan 0ec44f3e8a Rename DBM method calls to DBA method calls 2018-07-23 11:02:24 -04:00
Hypolite Petovan 8ddb94ef06 Use DateTimeFormat::utc() instead of DBM::date() 2018-07-23 10:57:47 -04:00
Hypolite Petovan c55e389bbc Add Database\DBM methods to Database\DBA 2018-07-23 10:57:47 -04:00
Hypolite Petovan 38f341e064
Add missing space between PHP path and script in App->proc_run (#5468) 2018-07-23 10:43:39 -04:00
Michael Vogel 2d0a749734
Merge pull request #5431 from MrPetovan/task/5410-rename-database-methods 
Move DBA to src/ part 3.1: Rename DBA methods
 2018-07-23 15:18:58 +02:00
Hypolite Petovan b685ef37c9
Fix Fatal errors in Protocol\OStatus (#5466) 2018-07-23 07:48:44 -04:00
Michael Vogel 53876abfda And some more removed notices in the core (#5465) 2018-07-23 07:43:18 -04:00
Philipp cd52d0b3e9 Using getopt for CLI arguments (#5446) 
* Adding Argument class to Friendica

* Adding Argument class to Friendica

* Adding Argument class to Friendica

* fixing arguments for `spawnWorker`

* Adding `use Friendica\BaseObject` to `ApiTest.php`

* Refactoring the argument-usages of Friendica

* Refactoring the argument-usages of Friendica

* removing superfluous []
 2018-07-23 07:40:52 -04:00
Roland Häder 4eb6707dc9 Cleanup: (#5463) 
- rewrote x() to empty() as it is deprecated
- fixed indending for some entries
 2018-07-22 21:18:21 -04:00
Hypolite Petovan cdd8e4fd9d Rename DBA::get_db to DBA::getConnection 
- Rename DBA::$db to DBA::$connection
 2018-07-22 19:28:29 -04:00
Hypolite Petovan 415b982d39 Rename DBA::num_rows to DBA::numRows 2018-07-22 19:27:35 -04:00
Hypolite Petovan 1f2c0b98b5 Rename DBA::server_info to DBA::serverInfo 2018-07-22 19:27:35 -04:00
Hypolite Petovan 4db98eb43d Rename DBA::inArray to DBA::toArray 2018-07-22 19:27:35 -04:00
Hypolite Petovan f051ae1698 Rename DBA::fetch_first to DBA::fetchFirst 2018-07-22 19:27:34 -04:00
Hypolite Petovan 591939dfc0 Rename DBA::database_name to DBA::databaseName 2018-07-22 19:27:34 -04:00
Hypolite Petovan abbaaf5aa5 Rename DBA::clean_query to DBA::cleanQuery 2018-07-22 19:27:34 -04:00
Hypolite Petovan 910e832dc2 Rename DBA::any_value_fallback to DBA::anyValueFallback 2018-07-22 19:27:34 -04:00
Hypolite Petovan e42cf4d4fc Rename DBA::affected_rows to DBA::affectedRows 2018-07-22 19:27:34 -04:00
Roland Häder d3144e2837 Need to load "verb" from notify table, too. This whole thing is a maintenance (#5459) 
nightmare. Let's use the new database frontend/backend system and load all
columns anywhere the "entity" is requested.
 2018-07-22 19:25:07 -04:00
Hypolite Petovan bb99ac8111
Fix Fatal error in Protocol\Diaspora (#5460) 2018-07-22 19:22:41 -04:00
Roland Häder 7876d6547b Fixed E_NOTICEs when uploading profile picture (#5456) 
* Fixed E_NOTICEs when uploading profile picture.

* Fixed E_NOTICEs when $_POST doesn't contain these fields.
 2018-07-22 16:01:14 -04:00
Roland Häder c17adaf333 Uncommon logger levels in Friendica (#5453) 
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)

* Used constants instead of values (MrPetovan)
 2018-07-22 14:07:44 -04:00
Hypolite Petovan a202962f03
Fix yet another Fatal Error in Protocol\OStatus (#5454) 2018-07-22 13:32:34 -04:00
Hypolite Petovan d6ccba79e0
Fix another Fatal error in Protocol\OStatus (#5451) 
* Fix Fatal error in Protocol\OStatus

* Fix another Fatal error in Protocol\OStatus
 2018-07-22 12:57:33 -04:00
Roland Häder 7d47152564 Fixed E_NOTICE in boot.php and DBA class (#5430) 
* Fixes:
- fixed missing variable $port (MySQL: 3306)
- "imported" mysqli class

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed:
- better use `false` and `$port > 0`

* And better only provide `$port` when larger zero.

* Initialize `$port` with zero value (int) and not `false` (bool).

* Removed duplicate mysqli "import".

* `$post_update` is no longer used. Instead `$prefix` needs to be checked.
 2018-07-22 12:53:46 -04:00
Hypolite Petovan 3500e50be9
Fix Fatal error in Protocol\OStatus (#5450) 2018-07-22 12:52:38 -04:00
Roland Häder 0a519f5001 Fixes/tye-hints (#5449) 
- added type-hints for DOMDocument, DOMXPath and array
- added missing documentation about optional parameter
- `if ($foo['bar'])` is not a good choice, better use
  `if (!empty($foo['bar']))` instead
 2018-07-22 12:35:20 -04:00
Roland Häder 2e332134d4 There is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either (#5448) 
declare it and push all other numbers higher or use LOGGER_NORMAL.
 2018-07-22 12:33:28 -04:00
Philipp c5cbf565d9 DBStructure enhancements (#5437) 
* Adding DBStructure enhancements

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 4ae06ec)

* Adding `pre_update_1279` method

- Added DBStructure::rename()
- Added DBStructure::existTable()
- Added DBStructure::existColumn()

(cherry picked from commit 8496d84)

* code standards

(cherry picked from commit 551d09b)

* simplify to `empty` instead `is_null`

(cherry picked from commit ce68835)
 2018-07-21 08:43:43 -04:00
Michael f02bcdba51 Automatically create a .htaccess when not existing 2018-07-21 05:41:19 +00:00
Tobias Diekershoff e4a652cae8
Merge pull request #5433 from annando/mysqli 
Forgotten "use"
 2018-07-21 07:18:10 +02:00
Michael 4ba91d4ea1 Forgotten "use" 2018-07-21 05:09:09 +00:00
Michael Vogel 6a6a805225 One more notice (#5429) 
* Some more notices

* And some more notice in the worker
 2018-07-20 20:43:21 -04:00
Michael Vogel 4bbcb61a9e We now have a pre update script (#5425) 
* We now have a pre update script

* Some optimized stuff
 2018-07-20 15:47:16 -04:00
Michael Vogel 7382be2766 Some more notices (#5424) 2018-07-20 14:07:54 -04:00
Hypolite Petovan af6dbc654f Rename Friendica\Database\dba to Friendica\Database\DBA 2018-07-20 08:19:26 -04:00
Tobias Diekershoff b6a1df0598
Merge pull request #5420 from annando/notices 
Just some more fixed notice
 2018-07-20 12:46:42 +02:00
Michael 045358cb88 Wrong "use" for config 2018-07-20 06:04:23 +00:00
Michael 5c63de1692 Just some more fixed notice 2018-07-20 05:31:26 +00:00
Michael 9a6a3bf1c1 Makes Diaspora working again 2018-07-20 05:10:16 +00:00
Hypolite Petovan 9c70a94589 Add missing PDO* use statements in Database\dba 2018-07-19 22:24:03 -04:00
Hypolite Petovan daa1177e3a Update use statement lists with new Friendica\Database\dba class 
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
 2018-07-19 22:15:21 -04:00
Hypolite Petovan c316c5ae30 Add new Friendica\Database\dba class 2018-07-19 22:06:13 -04:00
Roland Häder 36c6e35c7e Misc cleanups (#5417) 
* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>

* reverted back

Signed-off-by: Roland Häder <roland@mxchange.org>

* Added type-hint 'array' as the method uses foreach() on it.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Tpzo fixed ...

Signed-off-by: Roland Häder <roland@mxchange.org>

* Added missing new-line at end of file, will make some POSIX parsers being lesser
confused ...

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-19 20:52:18 -04:00
Michael Vogel 01b67c4eb3 Little fixes (#5414) 
* We now store the item delivery data in a separate table

* Reorganized table structure

* Fix  a notice when using the profiler / ensure that permissions are strings
 2018-07-19 18:40:39 -04:00
Roland Häder b2899d76cf Small cleanup (#5416) 
- added internal TODO to decide about is_result() usage
- removed semicolon (not needed here) from SQL query
- added empty line

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-19 18:39:05 -04:00
Michael Vogel ec49d004e3 We now store the item delivery data in a separate table (#5413) 
* We now store the item delivery data in a separate table

* Reorganized table structure
 2018-07-19 17:56:52 -04:00
Michael Vogel 5af9596dde New item field "Post-type" and new table "permissionset" (#5408) 
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* Changed documentation
 2018-07-19 09:52:05 -04:00
Roland Häder b05b96d04a Fixes: (#5404) 
- fixed E_NOTICE in mod/follow.php
- fixed 2 E_NOTICE in src/Protocol/Diaspora.php
- added more type-hints for `array` type where known

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-19 07:07:14 -04:00
Roland Häder 346790cbbc According to @annando and @MrPetovan, $emailcc is no item field (column) and (#5401) 
should be initialized empty (I did it above the `if()` block).

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-18 17:26:14 -04:00
Pierre Rudloff 6e1ed0b0d3 Fix tests (#5400) 
* Avoid argc side-effects

* Fix undefined array keys in JITConfigAdapter::set()

* Avoid argv side effects in ApiTest
 2018-07-18 16:30:55 -04:00
Michael Vogel 2fa6cc0000
Merge pull request #5394 from MrPetovan/bug/fix-config-set-return-value 
Change (P)Config::set return value to bool
 2018-07-18 11:07:10 +02:00
Michael Vogel 66a103e36a
Merge pull request #5295 from MrPetovan/task/4889-move-config-to-config 
Move configuration to config/
 2018-07-18 11:04:35 +02:00
Hypolite Petovan 0f7c7cebeb Change (P)Config::set return value to bool 2018-07-18 02:32:35 -04:00
Hypolite Petovan 1b6727fb9c Fix notice in Util\Network 2018-07-17 21:00:22 -04:00
Roland Häder a41e49c84a Fixes for E_NOTICE in mod/item.php (#5393) 
* Fixes applied:
- `if (is_array($some_array))` is better code style than `if ($some_array)` as
  the `if()` block really needs an array to be found
- same with `if ($some_id)`, maybe `if ($some_id > 0)` is a more proper check
- added missing field 'emailcc' to Item::ITEM_FIELDLIST

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes E_NOTICE of missing variable (PHP's lazyness again).

Signed-off-by: Roland Häder <roland@mxchange.org>

* Use !empty() to avoid accessing empty array.

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-17 18:18:42 -04:00
Roland Häder fd8897851f Fixes for OEmbed class (#5392) 
* Fixes:
- stdClass is clearly an object of `\stdClass`, so let's import it and set it
  as type-hint here
- if $o->type is not found, don't continue

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fix for a fix due to 02:51 a.m. (!) edits ...

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-17 16:28:20 -04:00
Hypolite Petovan 050ad68b9f Improve Console/Config display for array values 
- Prevent setting a config key that is an array
 2018-07-17 02:15:05 -04:00
Hypolite Petovan d993c8584c Add support for legacy $lang config in App->loadConfig 2018-07-17 02:05:52 -04:00
Hypolite Petovan 007ec92ae4 Remove exception for legacy config file in App->loadDatabase 2018-07-17 02:05:36 -04:00
Hypolite Petovan 7b8efcc23d Fix config value type in MemcachedCacheDriver 
- Remove default config values set in CacheDriverFactory
 2018-07-17 02:05:06 -04:00
Roland Häder 04b513ba95 Fixed E_NOTICE when 'title' is absent (uninitialized array key) (#5390) 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-17 01:13:22 -04:00
Hypolite Petovan bad2774817 Separate default config values between file-only and admin settings 2018-07-16 19:38:19 -04:00
Hypolite Petovan 67dc08d120 Enforce systen.register_policy value type 2018-07-16 19:38:19 -04:00
Hypolite Petovan 9b01a23c9b Code standards in App 2018-07-16 19:38:19 -04:00
Hypolite Petovan 763c66dd49 Improve console/config display 
- Add visual distinction between get/set value
 2018-07-16 19:38:18 -04:00
Hypolite Petovan 3001951075 Move the addon-specific config in config/addon.ini.php 
- Add sample addon.ini.php file
- Add config/addon.ini.php file to git ignore
 2018-07-16 19:38:18 -04:00
Hypolite Petovan c8d3067d0a Fix JITConfigAdapter to retrieve non-db config.* values 2018-07-16 19:38:17 -04:00
Hypolite Petovan bd04c03c9f Fix urlpath determination on the root page 2018-07-16 19:38:17 -04:00
Hypolite Petovan 0cbe3aa8e6 Remove global $db variable 2018-07-16 19:38:17 -04:00
Hypolite Petovan 820afa2284 Replace global $a with BaseObject::getApp() 2018-07-16 19:38:17 -04:00
Hypolite Petovan d0780ccf7d Replace global $lang with system.language 2018-07-16 19:38:17 -04:00
Hypolite Petovan 6b03ae92b8 Fix Memached config value format usage 2018-07-16 19:38:16 -04:00
Hypolite Petovan 762a786611 Replace direct accesses to App->config by Config::get/set calls 2018-07-16 19:38:16 -04:00
Hypolite Petovan 3255b2364b Fix dbesc as a constant notice message 2018-07-16 19:38:15 -04:00
Hypolite Petovan e98216b5bb Improve comparison in App->loadDatabase() 2018-07-16 19:38:15 -04:00
Hypolite Petovan d8096a402c Update use of environment variables in loadDatabase 2018-07-16 19:38:15 -04:00
Hypolite Petovan cd9b864045 Rework App modes 
- Replace App mode constants with capability-based flags
- Add App->isInstallMode()
- Add file config fallback in (P)Config abstraction
- Removed logger disabling code
 2018-07-16 19:38:15 -04:00
Hypolite Petovan d487c399dd Standards: Rename App methods 
- Rename App->max_processes_reached to App->isMaxProcessesReached
- Rename App->maxload_reached to App->isMaxLoadReached
 2018-07-16 19:38:14 -04:00
Hypolite Petovan 73b4e0552d Fix wrong urlpath determination 2018-07-16 19:38:14 -04:00
Hypolite Petovan 3fc21f0d64 Fix config mentions (no doc) 2018-07-16 19:38:14 -04:00
Hypolite Petovan 2e2930d770 Add addon config hook 2018-07-16 19:38:14 -04:00
Hypolite Petovan 0448ca3897 Update install procedure 
- Fix Notice messages in Core\Install and Database\DBStructure
- Move local config file template from htconfig.tpl to local.ini.tpl
- Remove htconfig.php
 2018-07-16 19:38:14 -04:00
Hypolite Petovan e7c3d453c2 Update config console command 2018-07-16 19:38:14 -04:00
Hypolite Petovan fd7179ee6c Prevent infinite loops with Config when App is in install mode 2018-07-16 19:38:13 -04:00
Hypolite Petovan 3985a4bc43 Remove extraneous dba::connect calls 2018-07-16 19:38:13 -04:00
Hypolite Petovan decfc553f7 Set BaseObject::setApp in App 2018-07-16 19:38:13 -04:00
Hypolite Petovan e952d6677b Rename App->path to App->urlpath 2018-07-16 19:38:13 -04:00
Hypolite Petovan 5fdff3d813 Centralize startup steps in Friendica\App 
- Add loadDatabase startup step
- Add loadConfigFiles startup step
- Remove startup() in boot.php
- Replace App::checkMaintenanceMode() with App::determineMode()
 2018-07-16 19:38:13 -04:00
Hypolite Petovan 2503660f97 Add new INI config files 
- Add new local.ini.tpl template
- Change all references from .htconfig.php to config/local.ini.php
 2018-07-16 19:38:13 -04:00
Michael 95fe08e5b9 Ensure that "follow" requests can be processed 2018-07-16 06:34:12 +00:00
Michael 78c9e29aa8 Don't accept posts from unknown owners 2018-07-16 05:48:51 +00:00
Michael Vogel d3a2ed85fe Next item structure works (#5380) 
* Use "LEFT JOIN" to always fetch the item. Needed for update routines.

* New conversion routine that now covers every item

* Post update is now activated

* We now use a hash based upon RIPEMD-320 for content and activity

* The hash doesn't contain the plink anymore

* Legacy item fields are now "null"able

* New hash function for a server unique item hash

* Introduction of the legacy mode (usage of old item fields)

* Code simplification

* We don't need the "uri" fields anymore in item-activity and item-content

* Use the "created" and not the "received" date for the hash

* Avoiding several notices

* Some more warnings removed

* Improved uri-hash / Likes on Diaspora are now getting a creation date

* Corrected the post update version

* Ensure an unique uri-hash

* Don't delete orhaned item data at the moment

* Partly reworked, due to strange behaviour

* Some more parts reworked

* Using the uri currently seems to be more reliable

* Using the uri here as well

* Use the hash values again

* Grouped item fields in different categories

* Notices again

* use the gravity (we always should)

* Added hint for disabled post updates

* Notices ...

* Issue #5337: Personal notes are displayed again

* Use the gravity again
 2018-07-15 14:36:20 -04:00
Hypolite Petovan ffc8b2a79a Rework smilies class and module 
- Add new replaceFromArray function to enable smilies replacement with
an arbitrary array
- Moved $sample logic from class to module
 2018-07-15 08:03:12 -04:00
Hypolite Petovan 065d10e587 Fix function comments in Util\Network 2018-07-15 08:03:12 -04:00
miqrogroove b5fe1c60a9 Fix Broken Profile Links (#5286) 
* Expose the block_public setting to head.tpl

* Do not include hovercard.js if block_public
 2018-07-14 16:31:46 -04:00
Roland Häder 6b5d90333f Fixes for some E_NOTICE and type-hints added (#5358) 
* Fixed http://github to https://github

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes for #4965:
- updated messages.po file

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed E_NOTICE where isset()/empty() was absent.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixed missing variable $sql_order causing E_NOTICE.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Continued:
- added array type-hint where known (some)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method

Signed-off-by: Roland Häder <roland@mxchange.org>

* reverted changes that are unintended

Signed-off-by: Roland Häder <roland@mxchange.org>

* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Removed if() block

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-13 15:47:14 -04:00
Tobias Diekershoff 26723623f4
Merge pull request #5363 from annando/daemin 
Workaround for stalling worker processes when running the daemon
 2018-07-11 08:26:09 +02:00
Michael 3cb7a7606e workaround for stalling worker processes when running the daemon 2018-07-11 06:05:22 +00:00
Roland Häder 8825728fa4 "Imported" name spaces (#5361) 
* Fixes for #5355:
- let's import SPL/extension classes and then just use them without name spaces
  like we do it with our own classes/interfaces, too.
- need to add namespace \ (global)

Signed-off-by: Roland Häder <roland@mxchange.org>

* Removed leading slashes from "import" lines.

Signed-off-by: Roland Häder <roland@mxchange.org>

* Completed:
- "import" other classes, then use them

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-07-10 18:55:01 -04:00
Michael Vogel 3792e2819d Use a process identifier for logging that contains the pid (#5359) 2018-07-10 18:32:47 -04:00
Michael Vogel 0360f7197a Several more warnings ... (#5340) 
* Some more warnings removed

* Even more warnings ...

* Will it ever end? ;-)

* Avoid warning in dbstructure

* Origin and OStatus ...

* There are more warnings solved ... yeah!

* And again ...

* We are not done yet

* And more ...

* And some new places ...

* And more in the feeds

* Avoid some more

* And some backend stuff

* Notifications cleared

* Some more stuff

* and again ...

* It's getting fewer ...

* Some warnings had been hidden in the notifications

* Fix the fix

* And another missing one ...

* We need the owner here, not the user

* Forgotten user

* And more ...

* And some more warnings disappeared ...

* Some more frontend warnings

* Some backend warnings removed

* Fixed sidebar for "vier"

* And more ...

* Some more ...

* And something for "remote self"

* Am I stuck in an endless loop?

* Fix: Clear tag and file field on update

* Preset page content
 2018-07-10 08:27:56 -04:00
Andreas Neustifter 32ef5623ab [frio] Improve Group Editing (#5349) 
* Improve group-editing and edit-navigation.

Use icons next to groups and header for navigation to editing groups and adding new groups.
Also use icon from group-sidebar for editing groups.

* Unify look&feel of contact search bars.

* Remove nogroup page and replace with /group/none.

* Make sure proper items are selected in aside.

* Use icon instead of link for 'View Contacs' on profile page.

* Fix none-working /group/none.

* Fix highlighting for everyone in group aside.
 2018-07-09 18:36:50 -04:00
Andreas Neustifter 09b7e217c7 [Suggestion] Move New User Tip Link (#5342) 
* Move new member tips to navigation bar.

The link looks so forlorn when its just somewhere in there. Put it in the nav bar.

* Style new member hints link propery.

* Make changes requested by @MrPetovan.
 2018-07-09 18:20:57 -04:00
Philipp Holzer a84c94e94b
bugfix isempty... 2018-07-09 22:10:35 +02:00
Philipp Holzer d1eeaeead9
empty is not isset ... 2018-07-09 21:53:49 +02:00
Philipp Holzer c829e43725
moved get_guid to System::createGUID 2018-07-09 21:38:16 +02:00
Hypolite Petovan 7211fc4f1a
Merge pull request #5338 from annando/warnings 
Remove warnings
 2018-07-08 09:55:26 -04:00
Michael 6d90751110 Added missing "use 2018-07-08 13:39:48 +00:00
Michael 1d745c25a7 Some more places ... 2018-07-08 12:58:43 +00:00
Michael 7d6933c898 Avoid "Trying to get property of non-object" 2018-07-08 11:46:05 +00:00
Philipp Holzer 269221f013
Merge branch 'develop' of https://github.com/friendica/friendica into redis_serialize 2018-07-08 13:36:05 +02:00
Philipp Holzer be83696f02
Redis serialize instead of json because of objects 2018-07-08 13:35:28 +02:00
Michael 3e797547a3 Warnings fixed 2018-07-08 09:37:05 +00:00
Michael c25c3b5981 urgent bugfix: Wrong function name for locks 2018-07-08 08:32:50 +00:00
Michael c2d4b557ae Only build tag and file when really needed 2018-07-08 05:44:35 +00:00
Michael 69db696ab1 Improve test behaviour 2018-07-08 05:29:06 +00:00
Michael 271b6cb8f9 Hopefully this fixes the tests 2018-07-08 05:10:45 +00:00
Michael 74d5eec571 Merge branch 'item-activities' of github.com:annando/friendica into item-activities 2018-07-08 04:56:35 +00:00
Michael 5ee2db8a16 Avoid undefined index 2018-07-08 04:55:45 +00:00
Michael Vogel ff5ee74ecf
Merge branch 'develop' into item-activities 2018-07-08 06:35:50 +02:00
Michael 75aa831b32 Better not check too strict 2018-07-07 23:31:30 +00:00
Michael 4673560c55 Don't use isset 2018-07-07 23:19:28 +00:00
Michael 4467dd4972 Clear legacy item fields 2018-07-07 23:03:28 +00:00
Michael afa194200b Fix: Ensure that the value is set. 2018-07-07 19:39:00 +00:00
Michael 4d35e228c4 More item abstraction / making remote deletion work again 2018-07-07 18:14:16 +00:00
Philipp Holzer 065b83d148
Fixed memcache & unittests 2018-07-07 20:07:07 +02:00
Philipp Holzer 80a4e6263f
Added Unittests for cache 
fixed Lock & Cache bugs
 2018-07-07 19:46:16 +02:00
Philipp Holzer 1dafaa69c5
bug in memcached clear function 2018-07-07 18:43:55 +02:00
Philipp Holzer f95c420801
bug in redis delete function 2018-07-07 18:39:33 +02:00
Michael d6af9515ba Avoid storing an icid value when iaid is stored/Fix item retraction 2018-07-07 16:38:01 +00:00
Philipp Holzer 1ffe0cfd81
Added Lock Unittests & Bugfixings 
Added Redis Lock Unittests
Added Memcached Lock Unittests

Fixed a bug in dba
Fixed a bug in RedisLock
 2018-07-07 16:15:03 +02:00
Michael 575662c2d7 Just some code cleanup 2018-07-07 11:39:37 +00:00
Michael 3389e9b213 Removing of likes should work now on comments as well 2018-07-07 10:43:43 +00:00
Michael b421e7708f Removing of orphaned activity and content data 2018-07-07 07:43:13 +00:00
Michael 9e262e6157 Better handling of empty content 2018-07-06 22:08:41 +00:00
Michael Vogel 3eec97aa6e
Merge pull request #5314 from MrPetovan/task/4889-fix-tests 
Fix tests after enabling PHP Notices
 2018-07-06 22:14:01 +02:00
Tobias Diekershoff a49e094308 added forgotten trim 2018-07-06 15:49:27 +02:00
Tobias Diekershoff 72638acac3 admins can forbid some nicknames from being registered 2018-07-06 15:32:56 +02:00
Michael 0c51159111 New index that is needed for the expiry 2018-07-06 06:46:44 +00:00
Michael 7f78540454 Expire does work now for activities as well 2018-07-06 06:45:30 +00:00
Michael 5a07042560 Added warning 2018-07-06 06:37:33 +00:00
Michael 32d398cc93 Unified content that is stored for a like 2018-07-06 05:39:25 +00:00
Michael da954b92c7 New post update to fill the item-activity table 2018-07-06 05:17:44 +00:00
Michael f33bd5fc8e Update does work now 2018-07-06 05:16:40 +00:00
Michael 5203f41d42 Set iaid after update 2018-07-05 22:50:33 +00:00
Michael 014eea8e12 Improve expire for item-content and item-activity 2018-07-05 22:07:50 +00:00
Michael 44e405d22b We now store activities in a separate table 2018-07-05 22:00:38 +00:00
Philipp Holzer 5a28ad7377
AbstractCacheDriver now working for each CacheDriver 2018-07-05 22:01:33 +02:00
Philipp Holzer 749b167fd9
AbstractCacheDriver now working for each CacheDriver 2018-07-05 21:54:20 +02:00
Philipp Holzer 34cea93a8b
Bugfixings for Cache-Lock 
- used wrong cachekey in set
- therefore added an abstraction to avoid wrong key concatenation
- forgot to increase the db-version to 1275
 2018-07-05 21:47:52 +02:00
Philipp Holzer e41e7d2edd
Fixings 
- fixed test for semaphore
- fixed some issues
- changed namespace in Tests back to "src/"
- changed namings
 2018-07-05 20:57:31 +02:00
Philipp Holzer 906bb25972
code standards / simplifications 2018-07-05 07:59:56 +02:00
Philipp Holzer 19209f6826
merged from develop and increased DB-version 2018-07-04 23:44:11 +02:00
Philipp Holzer aac94d1d74
Adding multihost - locking 
Adding Unit-Tests for it
 2018-07-04 23:37:22 +02:00
Michael 176ab7130f Fixes issue 5322 - events now again are having a plink 2018-07-04 19:53:02 +00:00
Michael f60da34357 Fix unliking liked 2018-07-04 19:07:53 +00:00
Philipp Holzer b07dfbb03f
Merge remote-tracking branch 'remotes/origin/develop' into lock_abstraction 2018-07-03 20:16:31 +02:00
Michael 9a9541809b Fix: Likes from OStatus got the gravity of comments 2018-07-03 04:58:34 +00:00
Hypolite Petovan 79ff49d716 Replace more is_null with empty in DBStructure 2018-07-02 22:42:15 -04:00
Hypolite Petovan e7d6b48bb3 Fix Undefined index: Collation in DBStructure 2018-07-02 22:28:27 -04:00
Hypolite Petovan 58e1470ddb Fix Undefined index: HTTP_USER_AGENT in App 2018-07-02 22:19:21 -04:00
Michael 80f9a45cba Fix: Twitter reshares hadn't been shown as this 2018-07-02 21:15:54 +00:00
Michael 4b3ae6a862 Only use query conditions in user mode 2018-07-02 18:22:27 +00:00
Hypolite Petovan 633a71ec97 Fix notice in Item::deleteById 2018-07-02 07:49:35 -04:00
Hypolite Petovan 07e06341df Simplify config.php_path access in App->proc_run 2018-07-02 07:48:33 -04:00
Hypolite Petovan 89e4629c16 Replace system.proc_windows config by PHP_OS test 2018-07-02 07:47:42 -04:00
Hypolite Petovan a380bcd1c1 Fix more undefined variable/index notice in tests 2018-07-02 07:45:25 -04:00
Hypolite Petovan 6776c4e3f9 Fix some undefined variable/index notices in tests 2018-07-02 07:44:55 -04:00
Hypolite Petovan 28741c8366 Remove startup() function 
- Enable notice errors
 2018-07-02 07:23:47 -04:00
Michael 717ca0b7eb Use already fetched data for magiclink 2018-07-02 05:41:55 +00:00
Michael 37bc19673d Empty owner and author data 2018-07-01 19:33:42 +00:00
Michael 38160a48b0 Post update script to move old content from the item table 2018-07-01 19:02:29 +00:00
Michael 32a639891f Improved logging for expired items 2018-07-01 09:08:58 +00:00
Michael bffdf96d87 The "file" variable isn't stored anymore in the item table 2018-07-01 07:57:59 +00:00
Michael 1905242a16 Added support for internal Diaspora links to accounts 2018-06-30 22:37:44 +00:00
Hypolite Petovan 0c553150ea
Merge pull request #5305 from annando/item-tags 
Tags aren't stored in the item table anymore
 2018-06-30 17:50:55 -04:00
Michael 60dcdd0b27 Preparation for not storing the file field into the item table. 2018-06-30 21:15:24 +00:00
Tobias Diekershoff bc3a569b2f Label for the Events happening in the next 7 days was wrong 2018-06-30 17:34:27 +02:00
Michael 5ba1427806 We don't store tags in the item table anymore 2018-06-30 15:21:32 +00:00
Michael 0ab9f2e265 Preparations to not store the tags in the item table anymore 2018-06-30 13:54:01 +00:00
Michael a8a189eec4 The detected language now moved to "item-content" as well 2018-06-30 05:18:43 +00:00
Michael 59f8cb16e5 Add item content before the transaction 2018-06-29 11:10:36 +00:00
Michael a82cf2ae29 Delete item content for older item records 2018-06-29 06:51:48 +00:00
Michael 4807797eaf New worker to fix empty icid 2018-06-29 06:24:18 +00:00
Michael 6b31e72905 Fix for: empty posts and comments that hadn't been transmitted to Diaspora 2018-06-29 06:20:04 +00:00
Philipp Holzer ad5ee75159
Deleting parameter-types of methods (lack of support in PHP 5.6) 2018-06-28 23:06:14 +02:00
Philipp Holzer 4b7be15560
Deleting return-types of methods 2018-06-28 23:02:00 +02:00
Philipp Holzer 3f7e4f5bb6
redesign of locking & caching 
- New Factory "CacheDriverFactory" for Cache and Locks
- Adding Redis/Memcached Locking
- Moved Lock to Core
- other improvements
 2018-06-28 22:57:17 +02:00
Michael b705a91ccd Standards and some more replace item calls 2018-06-28 03:31:10 +00:00
Michael 51a58ec2e2 Fix for fetching false fer... (sorry) verbs 2018-06-27 20:25:24 +00:00
Michael b3abe148a6 Remove comment 2018-06-27 20:11:09 +00:00
Michael 3918a31fc2 Remove unneeded logging 2018-06-27 20:08:02 +00:00
Michael 028c9f4da5 We now store the verb in the item-content as well 2018-06-27 19:37:13 +00:00
Michael 76dab3b2d7 Use gravity instead of verb 2018-06-27 18:09:33 +00:00
Michael 8c2f91573a Fix mail import 2018-06-27 18:09:13 +00:00
Philipp Holzer acf6a5cb9e
minor changes 2018-06-26 23:44:30 +02:00
Philipp Holzer d409a92ca2
minor changes 2018-06-26 23:43:43 +02:00
Philipp Holzer dd085ae592
minor changes 2018-06-26 23:42:26 +02:00
Philipp Holzer 130893673c
Bugfixing ILockDriver (forgot isLocked) 2018-06-26 23:33:02 +02:00
Philipp Holzer a57e6cfa1b
Moved Lock.php back to Utils 2018-06-26 23:28:07 +02:00
Philipp Holzer 2260b9c873
Merge branch 'develop' of https://github.com/friendica/friendica into develop 2018-06-26 22:56:08 +02:00
Philipp Holzer 0218d16335
Lock abstraction (like the Cache) 
- adding interface
- adding seperate drivers
- moving Lock to the Core package
 2018-06-26 22:31:04 +02:00
Hypolite Petovan e3584daef9
Merge pull request #5167 from VVelox/develop 
a domain name is unlikely to be both a CNAME and A record
 2018-06-26 08:05:34 -04:00
Zane C. Bowers-Hadley 8875cc7419 remove duplicate check 2018-06-26 05:03:45 -05:00
Michael f74a54b9bf Standard stuff 2018-06-26 03:58:12 +00:00
Michael 7aa880543f Fix shadow posts 2018-06-25 20:38:32 +00:00
Michael 6b568bb8fa Delete of item-content should work now 2018-06-25 20:23:32 +00:00
Michael 89f0eec261 Use a constant fieldlist 2018-06-25 18:49:36 +00:00
Michael c07b81c5b9 Added workarounds to fetch the complete item content 2018-06-25 16:11:27 +00:00
Michael 5f3f349006 "author-link" and "owner-link" aren't stored anymore in the item table 2018-06-25 06:45:05 +00:00
Michael 6dbbeaf8f6 Remove unneeded code 2018-06-25 06:33:12 +00:00
Michael 89fb28ae9b Content is now stored exclusively in item-content, connected via "icid" field 2018-06-25 04:56:32 +00:00
Michael 941bab1096 We now only store the content in item-content 2018-06-24 23:09:13 +00:00
Michael 58d61810ea We now store item content centrally 2018-06-24 21:41:49 +00:00
Michael d0c36d0e89 New table for storing item content 2018-06-24 14:33:07 +00:00
Michael b03db4643f The fetch function now centrally controls the content 2018-06-24 10:48:29 +00:00
Michael a7d2f126eb Fixes Issue 5276 and an endless loop in item::update 2018-06-23 10:32:53 +00:00
Tobias Diekershoff 585ba4c09f
Merge pull request #5279 from annando/issue-5278 
Issue 5278: Small corrections to the database definition
 2018-06-23 08:28:43 +02:00
Michael ca1add20a0 Small corrections to the database definition 2018-06-23 04:46:22 +00:00
rabuzarus 92a84275d4 fix hovercard for not logged in users 2018-06-21 22:46:10 +02:00
Hypolite Petovan 8a3cae686b
Merge pull request #5261 from annando/and-again-abstraction 
And again the item abstraction - and a fix for issue 5252
 2018-06-21 11:50:31 -04:00
miqrogroove 80e96bcf38
Workaround for Bugs in Class dba 2018-06-21 11:20:44 -04:00
Michael d643e00d33 Standards and a new function to fetch content 2018-06-21 15:14:01 +00:00
miqrogroove 7f4bce67a8
Update DBClean.php 2018-06-21 08:27:36 -04:00
miqrogroove f2463e327a
Update DBClean.php 2018-06-21 07:52:56 -04:00
miqrogroove cfe035f300
Update DBClean.php 2018-06-21 07:51:30 -04:00
miqrogroove 62e61a75f7
Make Conversation Cleanup Configurable 2018-06-21 07:43:40 -04:00
Michael 70af2cecf2 Some of the last direct SQL calls to the item table had been changed 2018-06-21 06:21:51 +00:00
Hypolite Petovan e84c48b979
Merge pull request #5259 from rabuzarus/20180616_-_magic_auth_test_2 
port hubzillas OpenWebAuth - don't initiate magic auth if the contact is allready authentificated
 2018-06-20 20:15:14 -04:00
rabuzarus 02d96623f2 port hubzillas OpenWebAuth - don't initiate magic auth if the contact is allready authentificated 2018-06-21 02:08:54 +02:00
Hypolite Petovan a5550b4702
Merge pull request #5253 from rabuzarus/20180616_-_magic_auth_test_2 
Port hubzillas OpenWebAuth - remote authentification
 2018-06-20 17:46:04 -04:00
rabuzarus 04fe3acb69 port hubzillas OpenWebAuth - fix method call 2018-06-20 23:29:36 +02:00
Roland Häder 8ad523fbc8
Continued a bit: 
- removed/fixed whitespaces and mixture of spaces/tabs (some)
- added new-line character at end of files (POSIX-compilant)
- reverted some code which I had messed up (compared to upstream/develop)
- removed duplicate dba::update() invocation in src/Protocol/DFRN.php
- also removed no longer valid TODO

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-06-20 22:19:54 +02:00
Michael f806fa91b1
Replace old database queries with the new ones 2018-06-20 22:02:17 +02:00
Roland Haeder 593d1feca6
was a bit confusing for me or I was not sleeping to much ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:17 +02:00
Roland Haeder 2d744fa189
PHP5 does not support native type-hints, except array + used dbm::is_result() 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:17 +02:00
Roland Haeder 4ca26fd3bc
fixed comment and explained one 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Haeder a5dba628c4
old behaviour restored 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Haeder 0e5daa86df
added curely branches + reverted back to old behaviour (may come back one day) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Haeder ad9bd7bb72
better comment added by @Hypolite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Häder fe77e1b538
added more curly braces + a bit more usage of dbm::is_result() 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-06-20 22:02:16 +02:00
Roland Haeder f89b999659
was a bit confusing for me or I was not sleeping to much ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
Roland Haeder f0b05838cb
fixed comment and explained one 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
Roland Haeder a95db714ca
added curely branches + reverted back to old behaviour (may come back one day) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
Roland Haeder 63f5598766
better comment added by @Hypolite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
Roland Haeder 9cc0d5479b
old behaviour restored 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-06-20 22:02:15 +02:00
rabuzarus 9f493357f4 port hubzillas OpenWebAuth - fix wrong table name + fix wrong method name 2018-06-20 20:11:26 +02:00
rabuzarus e4aaf8eb16 port hubzillas OpenWebAuth - fix some code standards violations 2018-06-20 19:32:26 +02:00
rabuzarus 149142b4bc port hubzillas OpenWebAuth - rename Verify class to OpenWebAuthToken 2018-06-20 19:24:02 +02:00
rabuzarus d5afbd3357 port hubzillas OpenWebAuth - rename verify table to openwebauth-token 2018-06-20 19:18:41 +02:00
rabuzarus 1ab3f7bfc8 port hubzillas OpenWebAuth - HTTPSignature - comment out some ActivityPub parts 2018-06-20 19:05:33 +02:00
rabuzarus 863a49d8e7 port hubzillas OpenWebAuth - rework the HTTPHeaders class 2018-06-20 18:52:37 +02:00
rabuzarus 1148c29916 port hubzillas OpenWebAuth - use random_bytes() in crypto class + bugfixes 2018-06-20 18:45:37 +02:00
rabuzarus f0235c4a98 port hubzillas OpenWebAuth - rename some methods and classes 2018-06-20 18:38:23 +02:00
miqrogroove 12d0f4bf3c
Add Comments to Worker Exponent Implementation 2018-06-20 06:43:57 -04:00
miqrogroove 9cde4aa109
Make Load Exponent Configurable 2018-06-20 06:22:53 -04:00
miqrogroove 97cabcecf2
Unify Worker Load Formulas 2018-06-20 06:06:20 -04:00
Michael 00124f9ac0 Makes the linear load calculation optional 2018-06-20 04:38:50 +00:00
miqrogroove 0dbddb240c
Update Worker.php 2018-06-19 18:55:55 -04:00
miqrogroove 7e4d7b9aac
Fix logic errors in tooMuchWorkers() 
There are probably a dozen different ways to do this, so this is not necessarily the "right" way.
 2018-06-19 18:53:02 -04:00
Hypolite Petovan 43ab1b2cf2
Merge pull request #5246 from annando/abstraction-encore 
Urgent bugfix: Non existing field / double "network" in field list
 2018-06-19 17:58:50 -04:00
Michael c540154f8e "shadow" does not exist 2018-06-19 21:41:38 +00:00
Michael 962fbc9166 Many "fetch_first" had been replaced 2018-06-19 21:33:07 +00:00
Michael 139d35438d Fix: network had been empty 2018-06-19 21:32:42 +00:00
miqrogroove 79446a625d
Update Emailer.php 2018-06-19 16:58:06 -04:00
miqrogroove 5b8619f501
Add Missing Fifth Argument to mail() Function Call 
This is desperately needed to fix Issue #5190.  In case of any unexpected problem, the admin can use

`$a->config['system']['sendmail_params'] = false;`
 2018-06-19 16:23:42 -04:00
rabuzarus b65e4b278b port hubzillas OpenWebAuth - use Contact::getIdForURL to query for contact entry 2018-06-19 16:15:28 +02:00
Michael ed00b63613 Typo 2018-06-19 13:26:03 +00:00
rabuzarus 9195ea26b1 port hubzillas OpenWebAuth - add some notes to the doxygen to refer to hubzilla's source code 2018-06-19 13:30:55 +02:00
rabuzarus af9116635b port hubzillas OpenWebAuth - readd some ActivityPup code to HTTPSig 2018-06-19 13:18:35 +02:00
Michael ebd76285d8 New item functions, improved feed cache behaviour 2018-06-19 05:39:56 +00:00
rabuzarus 1c7f4e3c63 port hubzillas OpenWebAuth - remote authentification 2018-06-18 23:05:44 +02:00
Michael 4714cb746b Use the item functions at many more places 2018-06-18 20:36:34 +00:00
Michael 507956818d Use the item classes where possible 2018-06-18 05:19:28 +00:00
Michael 2a76290d19 Using the constants 2018-06-17 21:55:01 +00:00
Michael 23aa9dffa0 New item functions are now used in the delivery process as well 2018-06-17 21:35:33 +00:00
Michael e42b934807 Item field list structure is unified 2018-06-17 17:14:52 +00:00
Michael 6e10de9284 New function to fetch item data especially for users 2018-06-17 17:05:17 +00:00
Michael 0280a46ab4 Use predefined field lists 2018-06-17 06:27:52 +00:00
Michael 1aec8f620d More item abstractions for DFRN and Diaspora 2018-06-16 22:32:57 +00:00
Hypolite Petovan 7d1bb9ecf4
Merge pull request #5230 from annando/new-item-uri 
New function for generating item URI
 2018-06-16 10:54:56 -04:00
Hypolite Petovan 133cd342d4
Merge pull request #5226 from annando/even-more-abstraction 
More item calls have been replaced with the new functions
 2018-06-16 07:57:00 -04:00
Tobias Diekershoff 7966c48e75
Merge pull request #5228 from annando/fix-5199 
Fix for PR 5199: Corrected check for empty object
 2018-06-16 09:42:36 +02:00
Michael d2da5d63c7 Fix for PR 5199: Corrected check for empty object 2018-06-16 07:26:09 +00:00
Michael 14cb128264 New function for generating item URI 2018-06-16 06:44:19 +00:00
Hypolite Petovan c651641856 Fix PHP 7.2 Warning in Model\Contact 2018-06-15 20:50:31 -04:00
Michael bb79b8f4ac More item calls have been replaced with the new functions 2018-06-15 22:30:49 +00:00
Michael e97a3c25e7 Multiple daemon improvements (foreground, faster spawning) 2018-06-15 18:18:20 +00:00
Tobias Diekershoff 71b017bfad
Merge pull request #5219 from annando/abstraction-2 
Reworked notifications / use of Item class to fetch data
 2018-06-15 09:54:50 +02:00
Michael 02fef0bcf5 Reworked notifications ("alt pager" added) / use of Item class to fetch data 2018-06-15 05:50:28 +00:00
Hypolite Petovan 6191fab4d7
Merge pull request #5216 from abanink/2337 
solves 2337 Smiley Pack 1.04: some smiley keywords aren't replaced correctly
 2018-06-14 15:36:21 -04:00
Pascal Deklerck ce4b793acf solves 2337 Smiley Pack 1.04: some smiley keywords aren't replaced correctly 2018-06-14 21:09:55 +02:00
Hypolite Petovan f0c2b77157
Merge pull request #5215 from rabuzarus/20180614_-_frio_contact_suggestion_template 
Frio: provide a template for received contact suggestions
 2018-06-14 13:56:30 -04:00
rabuzarus b8186ba98b Frio: provide a template for received contact suggestions 2018-06-14 17:05:23 +02:00
fabrixxm 574bfecdfd Create config keys if they not exists on set. 2018-06-14 13:18:01 +02:00
Michael 77c423ec04 Don't allow deletion of public posts 2018-06-13 19:19:17 +00:00
Hypolite Petovan 0bcf7b7c39 Fix PHP 7.2 sizeof notice messages in Protocol\PortableContact 2018-06-12 22:01:50 -04:00
Hypolite Petovan d71281e45b
Merge pull request #5193 from annando/dbstructure 
Fix: Avoid endlessly dbstructure changes
 2018-06-11 09:53:03 -04:00
Michael b9811f1bef Fix: Avoid endlessly dbstructure changes 2018-06-11 13:22:08 +00:00
Michael 5bfd424fd2 Clean up tag claud (remove "item_condition()" call) 2018-06-10 15:19:52 +00:00
Michael 4d4cce4867 The new function is now used here as well. 2018-06-10 10:14:53 +00:00
Michael 446a45003d Added documentation, some indention fixes 2018-06-09 19:12:13 +00:00
Michael baf316e898 The central item fetch does work now and the API now uses these functions 2018-06-09 16:56:37 +00:00
Michael 4874e589f1 New class function to fetch items 2018-06-07 06:03:12 +00:00
Michael 1304dae0d3 Bugfix: In the daemon mode we forgot to call the cron jobs 2018-06-06 03:48:04 +00:00
Hypolite Petovan 0a13ab6b9f
Merge pull request #5166 from annando/unsed-item-fields 
Remove unused, unneeded or redundant item fields
 2018-06-03 12:19:50 -04:00
Hypolite Petovan 973ece09c5
Merge pull request #5157 from annando/daemon 
Workers can now be started exclusively from the daemon and other workers
 2018-06-03 12:18:47 -04:00
Michael b654af28fa We need "global" 2018-06-03 09:40:32 +00:00
VVelox ea64ec21ac
a domain name is unlikely to be both a CNAME and A record 2018-06-03 04:29:06 -05:00
Michael d7c477d0f4 Don't probe anymore, but ensure that we got good contact data 2018-06-03 08:36:05 +00:00
Michael 3f07d01dd1 Get rid of unneeded or redundant fields 2018-06-03 07:42:56 +00:00
Hypolite Petovan 0eafea86ed
Merge pull request #5163 from annando/bugfix-user-item 
Fix SQL error in tagcloud
 2018-06-02 13:49:58 -04:00
Michael 41423e578a Fix SQL error in tagcloud 2018-06-02 17:07:28 +00:00
Michael c6c94b8cea Weird stuff 2018-06-02 13:00:47 +00:00
Michael 81c002370e Only redirections to the same host do make sense 2018-06-02 08:42:46 +00:00
Michael 723b5ae803 Use MagicLinkbyId when possible 2018-06-02 08:28:01 +00:00
Michael 8a34895a23 Use magicLink whenever possible 2018-06-02 08:05:06 +00:00
Michael 885f2b52d1 Merge remote-tracking branch 'upstream/develop' into public-redir 2018-06-02 06:18:45 +00:00
AndyHee 2b25bd48d4 Improved distinction between delete and remove 2018-06-02 12:40:41 +07:00
Michael 371f511954 Respect "don't fork" 2018-06-02 05:17:32 +00:00
Michael 3034170088 DBStruxture can now create "memory" tables as well 2018-06-02 05:03:23 +00:00
AndyHee a75d28e521 Rewording label 2018-06-02 11:23:27 +07:00
Michael 6d64667cdb Merge remote-tracking branch 'upstream/develop' into daemon 2018-06-02 04:03:55 +00:00
Michael 047c02371a Small corrections to the database descriptions 2018-06-01 22:12:35 +00:00
Michael 28f8beebfc Workers can now be started exclusively from the daemon and other workers 2018-06-01 22:09:27 +00:00
Michael b5b172500d Merge remote-tracking branch 'upstream/develop' into public-redir 2018-06-01 12:32:51 +00:00
Hypolite Petovan 93daf7883e Merge branch 'master' into develop 
- Updated new develop version label
- Incremented database build number
 2018-06-01 07:30:04 -04:00
Michael ae8d7267a0 "redir" is now centralized and works with the public contact 2018-06-01 06:46:34 +00:00
Tobias Diekershoff 9ea6d4b26d the detected language was not stored during user creation 2018-05-31 08:27:27 +02:00
Michael c86111d193 Coding standards 2018-05-29 19:00:26 +00:00
Pascal Deklerck 1853c5623b 4419 Update the comments in src/Database/DBStructure.php from doc/database/* 2018-05-29 10:24:36 +02:00
Michael 8329705eba New function to delete items for users 2018-05-29 05:22:57 +00:00
Michael deb015be12 Changed documentation 2018-05-27 10:42:47 +00:00
Michael c5a22f86c7 Merge remote-tracking branch 'upstream/2018.05-rc' into deleted-item 2018-05-27 10:38:49 +00:00
rabuzarus 32c3762989
Merge pull request #5138 from annando/optimize-workerqueue 
Possibly fixes 5137: Only execute "optimize table" when allowed
 2018-05-27 10:10:11 +02:00
Michael 04fd6eff01 Possibly fixes 5137: Only execute "optimize table" when allowed 2018-05-27 06:23:18 +00:00
Michael 708ddf2b02 Preparation for new deletion functionality 2018-05-26 20:23:49 +00:00
Michael a6396dde55 Removed useless line 2018-05-26 20:08:42 +00:00
Michael a50805c371 Grammar fix 2018-05-26 20:07:30 +00:00
Michael bdbc51229a Fix for not being able to delete items 2018-05-26 18:07:27 +00:00
rabuzarus c66d1f01a3 add missing database use statements 2018-05-25 09:05:16 +02:00
rabuzarus f013625382 fix typo in comment 2018-05-25 08:52:03 +02:00
rabuzarus 8174bfeb2b Bugfix: compute the current theme each time we want to know which theme is beeing used 2018-05-25 08:44:01 +02:00
Michael 4a67919be7 Issue 5010: Don't show removed users 2018-05-24 04:44:02 +00:00
Michael 89a20ddbd7 Nodeinfo: The number of comments is now calculated more reliable 2018-05-22 20:10:18 +00:00
Michael df531cd400 Don't proxy pictures when they are sent to other networks 2018-05-21 10:15:50 +00:00
Hypolite Petovan c41332364f
Merge pull request #5089 from tobiasd/20180519-tos 
privacy statement
 2018-05-20 08:20:16 -04:00
Tobias Diekershoff d78b1f5191
Merge pull request #5091 from annando/issue-4956 
Don't fail during installation because of a missing theme configuration
 2018-05-20 08:50:28 +02:00
Tobias Diekershoff f7c24a20ae cite: just some small styling thing 2018-05-20 08:43:43 +02:00
Michael 9d0ed1a2af Issue 4956: Don't fail during installation because of a missing theme configuration 2018-05-20 05:44:20 +00:00
Michael c70ebadd7d Issue-3412 related: Don't send connection posts anymore 2018-05-19 19:34:51 +00:00
Tobias Diekershoff 2798d4ea4d missing sign 2018-05-19 19:08:50 +02:00
Tobias Diekershoff 4f8530070b removed one line too much 2018-05-19 19:07:13 +02:00
Tobias Diekershoff e02093c7ea text of the priv. statement can now be shown outside of the module 2018-05-19 18:55:29 +02:00
Michael 3fe07cca57 Issue 2880: Editing post doesn't destroy mentions or hashtags anymore 2018-05-19 14:55:27 +00:00
Tobias Diekershoff 5ae9193aa7
Merge pull request #5084 from annando/dead-subscriber 
End subscription for unreachable subscribers
 2018-05-19 07:07:00 +02:00
Michael e9848d7b8f End subscription for unreachable subscribers 2018-05-19 03:56:29 +00:00
Michael 5d708fd9a9 Avaoid warning when no valid data could be read 2018-05-18 16:07:55 +00:00
Hypolite Petovan 83ff57777f
Merge pull request #5079 from annando/fix-self 
Fix: Sometimes the contact endpoints seem to be wrong
 2018-05-18 08:54:00 -04:00
Michael 8983c61023 Fix: Sometimes the contact endpoints seem to be wrong 2018-05-18 12:26:10 +00:00
Michael feb3d76a5b Fix: Subscriptions from GNU Social partially don't work 2018-05-18 12:18:12 +00:00
Hypolite Petovan 1d2b0c0a81
Merge pull request #5077 from annando/fix-blocking-ostatus 
Fix to OStatus delivery to be not so blocking to other tasks
 2018-05-17 19:59:08 -04:00
Michael 4355014492 Now it should work ... 2018-05-17 23:47:15 +00:00
Michael f4a71b76dd Dynamic priority handling 2018-05-17 23:43:44 +00:00
Michael 61824119e4 Moved functionality in new model class 2018-05-17 23:30:49 +00:00
Michael 5a1e1c1ec9 Fix to OStatus delivery to be not so blocking to other tasks 2018-05-17 22:17:03 +00:00
Tobias Diekershoff 41b7d75cca
Merge pull request #5072 from Alkarex/ru-plural-intval-bug 
i18n ru intval bug
 2018-05-17 09:43:25 +02:00
Alexandre Alapetite f980516545 Fix PoToPhp 
https://github.com/friendica/friendica/pull/5072#issuecomment-389754406
 2018-05-17 08:12:55 +02:00
Tobias Diekershoff ac67f3c154
Merge pull request #5071 from annando/fix-duplicated-posts 
Bugfix: Only send a notifier when the item was really edited
 2018-05-17 07:59:56 +02:00
Michael b333c7ae2e Bugfix: Only send a notifier when the item was really edited 2018-05-17 05:49:55 +00:00
Roland Häder 6129eb1623
OpenId possibly fixed: 
- The LightOpenId class' constructor now requires the hostname from where the
  requested started, added it now
- sometimes need to invoke get_app() as $a was not around

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-17 00:24:25 +02:00
Michael Vogel e8e93768db
Merge pull request #5065 from tobiasd/2018.05-rc 
added link to the TOS page if it is activated
 2018-05-16 14:21:24 +02:00
Tobias Diekershoff eec0826750 added link to the TOS page if it is activated 2018-05-16 11:57:06 +02:00
Michael 3b2752c2fe Follow up to PR 5060: Missing index update 2018-05-16 08:59:15 +00:00
Michael 84248ac4c1 Grammar stuff 2018-05-16 03:54:08 +00:00
Michael c9f55f6b3d Show "Remove from your screen" or "delete" depending of the impact of the deletion 2018-05-15 21:06:34 +00:00
Michael e77cd17495 We do the notify stuff now directly in the item class 2018-05-15 19:50:29 +00:00
Michael fe8a4d50c8 Merge branch 'item-delete' of github.com:annando/friendica into item-delete 2018-05-15 19:31:05 +00:00
Michael 4a1bbd114c Lower priority for "remote self" 2018-05-15 19:29:14 +00:00
Michael 82937189ba Only delete undeleted items 2018-05-15 19:25:35 +00:00
Michael fc60e23314 Added comments / hourly workerqueue deletion 2018-05-15 17:50:29 +00:00
Michael 3e475f3b82 Delete the shadow post when it is the last one 2018-05-15 16:40:13 +00:00
Michael 4a7bf95926 Fix: Delete all item copies if it is an original item 2018-05-15 15:51:58 +00:00
Tobias Diekershoff 0848cef605
Merge pull request #5055 from annando/worker-spawning 
Fix for the slow spawning of workers
 2018-05-15 08:22:33 +02:00
Tobias Diekershoff ba4f9b6136
Merge pull request #5054 from annando/diaspora-comments 
Fix: public comments weren't distributed to the followers.
 2018-05-15 07:30:34 +02:00
Michael 8564eeec4e Fix: public comments weren't distributed to the followers. 2018-05-15 04:33:28 +00:00
Roland Häder e409001dfb
Fixed "constant" result, maybe there is a $ missing? 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-15 03:26:20 +02:00
Roland Häder 538760d9da
No direct $a->config['foo'] needed when Config::get() is around ... 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Roland Häder 751394fc1d
Redis: 
- added support for redis server:

// Required to actually have this cache driver active:
$a->config['system']['cache_driver'] = 'redis';

// ---- OPTIONAL/DEFAULT: ----
$a->config['system']['redis_host'] = '127.0.0.1';
$a->config['system']['redis_port'] = 6379;

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Roland Häder 69ac6feff7
Continued: 
- you can directly use constant($var) instead of this switch()

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Roland Häder fe1e7b92f2
Continued: 
- system,worker_dont_fork may not be set, always set default to "false" to
  have it properly set as Config::get() may one day behave differently

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Roland Häder 57e668d9e0
Continued: 
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:05 +02:00
Michael 17a39340b5
"pending" shouldn't be set as well by default ... 2018-05-14 22:50:04 +02:00
Michael f28301e18f
Urgent bugfix: Public contacts had been blocked automatically when created 2018-05-14 22:50:04 +02:00
Michael 72f5b863d8
Reshares had been detected falsely so that were rejected by Diaspora 2018-05-14 22:50:04 +02:00
Michael f19066c6cf
Ensure that the link will be displayed correctly on Diaspora 2018-05-14 22:50:04 +02:00
Michael dcfd81e2ee
Some corrections 2018-05-14 22:50:04 +02:00
Michael d54c79a772
Replace old database queries with the new ones 2018-05-14 22:50:04 +02:00
Roland Haeder 11dcb31960
was a bit confusing for me or I was not sleeping to much ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder ce07c20130
PHP5 does not support native type-hints, except array + used dbm::is_result() 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder 6579396627
removed TODO, one day this all needs refacturizing ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder 7526afcf13
Continued: 
- converted multiple single-line comments into one multi-line comment (please
  stop abusing programming languages!)
- added more TODO tags for type-hints (upcoming rewrite)
- opps, one space was only fixed in develop branch, not in this PR branch

Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder f5f1650b62
fixed comment and explained one 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:02 +02:00
Roland Haeder 1fcd4f52e7
old behaviour restored 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:01 +02:00
Roland Haeder 87bb934f8f
added curely branches + reverted back to old behaviour (may come back one day) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:01 +02:00
Roland Haeder 116d0ee1e0
better comment added by @Hypolite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:50:01 +02:00
Roland Häder e5c4b0203a
added more curly braces + a bit more usage of dbm::is_result() 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:50:00 +02:00
Michael 7e54499856
"pending" shouldn't be set as well by default ... 2018-05-14 22:50:00 +02:00
Michael cd7c337134
Urgent bugfix: Public contacts had been blocked automatically when created 2018-05-14 22:50:00 +02:00
Michael 002a1d1f54
Reshares had been detected falsely so that were rejected by Diaspora 2018-05-14 22:50:00 +02:00
Michael d217d74081
Ensure that the link will be displayed correctly on Diaspora 2018-05-14 22:50:00 +02:00
Michael 3bb5a416f8
Some corrections 2018-05-14 22:50:00 +02:00
Michael 8b775d48f9
Replace old database queries with the new ones 2018-05-14 22:50:00 +02:00
Roland Häder dd6fd32883
rewrote based on CR by @Annando, thank you. It is now clear to me. 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:49:59 +02:00
Roland Häder 25fd270959
Continued: 
- added spaces and curly braces
- added more TODOs as there really more to be done

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-14 22:49:58 +02:00
Roland Haeder fc4d1296e3
was a bit confusing for me or I was not sleeping to much ... 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:49:57 +02:00
Roland Haeder 4d5c61395e
PHP5 does not support native type-hints, except array + used dbm::is_result() 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:49:57 +02:00
Roland Haeder 03f283ca36
fixed comment and explained one 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:49:56 +02:00
Roland Haeder d2d6200669
old behaviour restored 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:49:56 +02:00
Roland Haeder be3d0a90a5
added curely branches + reverted back to old behaviour (may come back one day) 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:49:56 +02:00
Roland Haeder b823708c50
better comment added by @Hypolite 
Signed-off-by: Roland Haeder <roland@mxchange.org>
 2018-05-14 22:49:56 +02:00
Michael f1b5e828db Fix for the slow spawning of workers 2018-05-14 05:02:18 +00:00
Hypolite Petovan f937dabc9e
Merge pull request #5044 from annando/no-feed-reshare 
We mustn't reshare a feed item (only DFRN and Diaspora)
 2018-05-13 18:31:58 -04:00
Michael Vogel 24ef818d0d
Merge pull request #5038 from tobiasd/20180519-3834 
dont delete but remove from your stream
 2018-05-13 22:24:59 +02:00
Michael 57bd073ffd We mustn't reshare a feed item (only DFRN and Diaspora) 2018-05-13 18:31:01 +00:00
Hypolite Petovan 288b508e2a
Merge pull request #5041 from M-arcus/patch-1 
[TASK] Automatic installation: Install theme
 2018-05-13 10:03:11 -04:00
Roland Häder 99440f3c56
Beatification: 
- added space after curly braces (MrPetovan)
- added TODO for possible rewrite candidate

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-13 14:21:53 +02:00
Marcus Müller 64a799198a
[TASK] Automatic installation: Install theme 2018-05-13 12:50:53 +02:00
Tobias Diekershoff 17dda0fc43 dont delete but remove from your stream 2018-05-13 11:10:34 +02:00
Hypolite Petovan ec626fb76c
Merge pull request #5036 from Alkarex/fix-constants 
Fix wrong use of class constants
 2018-05-13 04:38:32 -04:00
Alexandre Alapetite 736c76d068 Simplify constant names 
https://github.com/friendica/friendica/pull/5036#discussion_r187792865
 2018-05-13 10:34:33 +02:00
Alexandre Alapetite 41a8c62bee Fix wrong use of class constants 
http://php.net/manual/language.oop5.constants.php
 2018-05-13 10:07:15 +02:00
Roland Häder 445cc1cb99
Fixes: 
- brought back comment (ops)
- DBM is the class name (not dbm)

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-13 10:06:43 +02:00
Roland Häder 3191fee763
Ops, one to much ... 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-13 10:02:47 +02:00
Michael 926c9719e0 Avoid SQL error with empty "bd" field 2018-05-11 15:27:19 +00:00
Michael 79a343a69a Only set the "updated" value when it contains a value 2018-05-11 10:44:28 +00:00
Michael f9c695e78d Fix SQL error during postupdate 2018-05-11 09:20:59 +00:00
Michael 8d8f2a1845 Change the community value as well 2018-05-11 08:04:01 +00:00
Michael 78271e88f5 Insert a gcontact on probing, but not insert a contact 2018-05-11 05:44:31 +00:00
Michael 3d2bc7700e Fix SQL error 2018-05-10 20:14:51 +00:00
Michael 6d4f3e8ee2 Issue 4997: Avoid database duplicates 2018-05-10 12:49:28 +00:00
Roland Häder cf9fa51f2f
Continued: 
- added missing space/curly braces
- added TODOs for later adding a lot type-hints, without these (and they are
  long time around in PHP) anything can be handled over to the method/function.

Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-10 13:07:21 +02:00
Roland Häder f66cb9b0a3
added more curly braces + a bit more usage of dbm::is_result() 
Signed-off-by: Roland Häder <roland@mxchange.org>
 2018-05-10 13:07:21 +02:00
Michael 40d3e7982c Adopt the relay definition according to the suggestions from @jaywink 2018-05-10 11:04:18 +00:00
Michael ed664b1091 For feed items show the avatar of the local user 2018-05-09 21:09:16 +00:00
Tobias Diekershoff 7f7ccc3f51 the widget is not needed here 2018-05-09 12:49:29 +02:00
Tobias Diekershoff 21f9f74ad0 use Archives for the additional feature setting like it is used in the network sidebar 2018-05-09 12:32:47 +02:00
Michael 3eb0b795fc Bugfix: Avoid empty avatar photos when a public contact is created 2018-05-09 06:53:57 +00:00
Michael 74908c0125 Corrected placeholders 2018-05-08 20:22:21 +00:00
Michael 08bf19082c Ensure that there will always be an author-id and owner-id in the items 2018-05-08 20:20:15 +00:00
Michael e7e0bee0a9 Added maintenance notice 2018-05-08 18:46:47 +00:00
Michael 6c35f8ebf3 Update script for setting author-id and owner-id in item and thread table 2018-05-08 17:50:06 +00:00
Michael 7d6b1264ec Fix for issue 4994: Feed items now appear again 2018-05-08 06:11:46 +00:00
Michael eb4650ff23 dbclean settings are now available from the frontend 2018-05-07 05:37:20 +00:00
Michael c33df7a05e Fix video display problems with videos with parameters 2018-05-06 16:57:46 +00:00
Hypolite Petovan 3a3a4807a8
Merge pull request #4978 from annando/dba-2 
Diaspora: Fix person/contact retraction
 2018-05-04 18:04:38 -04:00
Hypolite Petovan 4e1441bb3e
Merge pull request #4981 from annando/remote-self 
"remote-self" is now working for Diaspora and Twitter as well
 2018-05-04 17:50:17 -04:00
Michael dfa0dbf33f Ups 2018-05-04 21:33:15 +00:00
Michael 1230ff146a "remote-self" is now working for Diaspora and Twitter as well 2018-05-04 21:12:13 +00:00
Philipp Holzer 7e28e3e5f4 using \PDO instead PDO (bugfix) 2018-05-04 19:48:01 +02:00
Michael 6dbf0de9f2 Removed activities that aren't in the Diaspora protocol 2018-05-04 06:34:02 +00:00
Michael d52b226a6e Reformat wrong expansion 2018-05-03 20:49:32 +00:00
Michael 321a36d4db Avoid SQL error with wrong formatted datetime value 2018-05-03 20:48:35 +00:00
Michael 08bfced11b "pending" shouldn't be set as well by default ... 2018-05-03 18:19:40 +00:00
Michael bce3b6f896 Urgent bugfix: Public contacts had been blocked automatically when created 2018-05-03 17:43:10 +00:00
Michael 53b7028d35 Reshares had been detected falsely so that were rejected by Diaspora 2018-05-03 13:03:41 +00:00
Michael aba93df94f Ensure that the link will be displayed correctly on Diaspora 2018-05-03 04:43:50 +00:00
Michael eecd1e47e4 Some corrections 2018-05-02 21:12:48 +00:00
Michael 4ad655ab80 Replace old database queries with the new ones 2018-05-02 19:26:15 +00:00
Hypolite Petovan 538143f628
Merge pull request #4967 from nupplaphil/4899-autoinstall-with-file 
AutomaticInstallation - use config file
 2018-05-01 08:19:02 -04:00
Philipp Holzer 559250b8b3 Updated help-text 
accidentaly changed `htconfig.php` (reverted)
 2018-05-01 13:21:42 +02:00
Philipp Holzer 95ef07d67b Updated help-text 2018-05-01 13:14:41 +02:00
Philipp Holzer fa78f148c8 AutomaticInstallation - use config file 
- added new parameter "-f config file" to `AutomaticInstallation.php`
 2018-05-01 13:11:25 +02:00
Michael 1e0200884f Fixed private messaging/relaying is controlled by the parent 2018-05-01 06:37:12 +00:00
Hypolite Petovan 352e136132
Merge pull request #4961 from annando/direct-dfrn 
Direct Relay is now working with DFRN as well
 2018-04-30 14:06:35 -04:00
Michael b72bc0735f Merge branch 'direct-dfrn' of github.com:annando/friendica into direct-dfrn 2018-04-30 16:52:44 +00:00
Michael a182dd3400 Improved logging, avoiding PHP warning 2018-04-30 16:46:49 +00:00
Michael 1a8d0a573e Bugfix: Contact wasn't added on probing 2018-04-30 16:45:00 +00:00
Michael 4909075321 Merge branch 'direct-dfrn' of github.com:annando/friendica into direct-dfrn 2018-04-30 13:09:11 +00:00
Michael 5588f0d2ae Improved logging 2018-04-30 13:08:48 +00:00
Michael b2b597288c Deliver with the new function when delivering to a "uid=0" contact 2018-04-30 13:07:40 +00:00
Michael bbbebb2b9c Don't spool relay deliveries 2018-04-30 05:56:40 +00:00
Michael d0dd5c44d9 Update or create relay contact from discovery / process new protocol values 2018-04-30 05:33:47 +00:00