clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
38,123 Commits 3 Branches 0 Tags 183 MiB
Commit Graph

3376 Commits

Author SHA1 Message Date
Michael Vogel 8f22b4f33d
Update src/Model/GServer.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-12-19 15:22:21 +01:00
Michael feb74b4d9a Don't perform a delivery to failing servers 2022-12-19 09:30:56 +00:00
Michael e057b39f68 Issue 12185: Problems adding contacts 2022-12-18 15:43:35 +00:00
Michael ed520a3f39 Fix image grid in shared Friendica posts 2022-12-17 22:07:14 +00:00
Hypolite Petovan cdf180c58d Add new calendar.default_view pconfig key 2022-12-17 12:20:43 -05:00
Hypolite Petovan 83e34ef8e7 Move first_day_of_week pconfig key to calendar category 2022-12-17 12:20:14 -05:00
Michael 8397ccf37c Merge remote-tracking branch 'upstream/2022.12-rc' into diaspora-reshare 2022-12-17 12:27:35 +00:00
Hypolite Petovan c69705d34e
Merge pull request #12446 from annando/preview-image 
Fix: Images must not be removed on preview
 2022-12-17 01:25:13 -05:00
Michael 2e6ab0e312 Fix: Images must not be removed on preview 2022-12-17 05:48:09 +00:00
Hypolite Petovan c60464a4be Catch exceptions in Model\Gserver::cleanURL 
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1354393419
 2022-12-16 17:39:40 -05:00
Hypolite Petovan 590f92ba42
Merge pull request #12434 from MarekBenjamin/issue_make_balancing_optional 
Removed balancing of image grid
 2022-12-15 15:49:20 -05:00
Marek Bachmann 91cc6d5a94 Add unbalanced imagegrid generation 2022-12-15 21:29:14 +01:00
Hypolite Petovan 8a6da56738 Remove obsolete <div class="clear"></div> from body-attach div 2022-12-14 22:35:12 -05:00
Michael 5041e92937 Merge remote-tracking branch 'upstream/2022.12-rc' into diaspora-reshare 2022-12-14 09:19:41 +00:00
Michael ca8a89ed1c Use reshare with Diaspora like with ActivityPub 2022-12-13 23:19:19 +00:00
Hypolite Petovan d9361f2b81 Improve code standards in Model\Item 2022-12-13 09:33:01 -05:00
Marek Bachmann 290b14a000 Fixed image grid when exactly ONE portrait and ONE landscape is attached 2022-12-13 00:39:39 +01:00
MarekBenjamin e4702ed464
Merge branch 'friendica:2022.12-rc' into new_image_presentation 2022-12-11 22:25:47 +01:00
Hypolite Petovan baf2f7565a
Merge pull request #12390 from annando/fixes 
Only reshare the author's posts on `MIRROR_NATIVE_RESHARE`
 2022-12-11 15:05:47 -05:00
Michael 2f3f41ed9c Merge remote-tracking branch 'origin/2022.12-rc' into fixes 2022-12-11 19:00:59 +00:00
Marek Bachmann eb1cfd09a9 added more sophisticated column balancing logic for portraits and landscapes 2022-12-11 18:25:19 +01:00
Marek Bachmann 58cc270da8 fixed bug in portrait iteration 
shortened var names

added some comments
 2022-12-11 17:09:28 +01:00
MarekBenjamin 23f31883f5
Merge branch 'friendica:2022.12-rc' into new_image_presentation 2022-12-11 16:56:33 +01:00
Michael Vogel 884a265c5a Some small fixes 2022-12-11 11:21:02 +01:00
Michael bf7df13855 Add more BlurHash to avoid not being able to display some picture 2022-12-11 09:56:30 +00:00
Michael 5e176b52a5 Issue 12285: Show sharing notification only once 2022-12-11 04:11:29 +00:00
MarekBenjamin 1454f3bc2a
Merge branch 'friendica:2022.12-rc' into new_image_presentation 2022-12-10 23:59:51 +01:00
Marek Bachmann fe2c4f7c4b Restored $s = $hook_data['html']; call which was removed on error 2022-12-10 23:47:37 +01:00
Marek Bachmann 412ba461e7 Removed unused imports 2022-12-10 23:45:42 +01:00
Marek Bachmann 2eb170bdbd Added some logic for image grid column balancing 2022-12-10 23:37:03 +01:00
Marek Bachmann cc048bca38 remove old code 2022-12-10 22:58:43 +01:00
Marek Bachmann d786f225ee Added image grid generation to addVisualAttachments 2022-12-10 22:54:50 +01:00
Michael 1a1e452fae Issue 11875: Fetch post on activity 2022-12-10 21:48:00 +00:00
MarekBenjamin c7811576cc
Merge branch 'friendica:2022.12-rc' into new_image_presentation 2022-12-10 22:17:26 +01:00
Michael Vogel 46660c9462
Merge pull request #12364 from MrPetovan/bug/warnings 
Address several warning messages
 2022-12-10 18:10:24 +01:00
Hypolite Petovan a71fb8d7f3 Check for existence of a public contact id before deleting related notifications in Model\Contact 
- Address part of https://github.com/friendica/friendica/issues/11993#issuecomment-1338134893
 2022-12-10 11:42:04 -05:00
Hypolite Petovan e78471c847 Throw exception when a few keys are missing from probe data array in Repository\DiasporaContact 
- Address part of https://github.com/friendica/friendica/issues/11993#issuecomment-1338134893
 2022-12-10 11:42:04 -05:00
Hypolite Petovan fc246424a9 Provide default host value to hash() in Model\Item::guidFromUri 
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1338133783
 2022-12-10 11:38:37 -05:00
Hypolite Petovan e7574356d8 Replace parse_url with UriInterface instantiation in Model\APContact 
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1338133783
 2022-12-10 11:38:02 -05:00
Michael 019bb56668 Issue 12373: Fix communication to Diaspora 2022-12-10 12:08:55 +00:00
MarekBenjamin 75d857c595
Merge branch 'friendica:2022.12-rc' into new_image_presentation 2022-12-08 20:40:58 +01:00
Marek Bachmann d270a98e86 Image grid logic 2022-12-08 20:39:51 +01:00
Michael 741469a5c5 Add images in a loop (preparation for a galery) 2022-12-08 07:16:25 +00:00
Michael 7d51fa47d5 Issue 12345: No link preview on DFRN posts 2022-12-08 05:49:25 +00:00
MarekBenjamin 74ff7bae59
Merge branch 'friendica:2022.12-rc' into new_image_presentation 2022-12-07 18:52:20 +01:00
Marek Bachmann d590df9a72 set character encoding to utf-8 for parsing rendered-html 2022-12-07 18:50:16 +01:00
Marek Bachmann 99e20d1b00 Temporary hack to remove images after last text line by DOM inspection 2022-12-07 13:22:28 +01:00
Michael 498a957009 The appearanxe of the link preview is now configurable 2022-12-07 07:02:04 +00:00
Michael e5ff71f839 Fix "Missing hidewall key" 2022-12-06 22:23:43 +00:00
Marek Bachmann 9778b60e64 cleaned up my git mess :-/ anyways, should work now 2022-12-06 01:14:15 +01:00
Marek Bachmann 2205ef0574 Merge remote-tracking branch 'origin/new_image_presentation' into new_image_presentation 
# Conflicts:
#	src/Model/Item.php
 2022-12-06 01:02:04 +01:00
Marek Bachmann 458f22d303 Support more than 2 images 2022-12-06 00:59:48 +01:00
Marek Bachmann 7fb0f018df First draft for using a image grid to display attached images. 2022-12-06 00:59:47 +01:00
Marek Bachmann 8145454707 Revert "Merge branch 'develop' into new_image_presentation" 
This reverts commit 76f4ba7685, reversing
changes made to 733543505b.
 2022-12-06 00:48:28 +01:00
Marek Bachmann 733543505b Merge branch 'develop' into new_image_presentation 2022-12-05 16:54:12 +01:00
Hypolite Petovan 818cdf83ca [Database version 1500] Remove obsolete table fcontact 2022-12-05 00:00:50 -05:00
Hypolite Petovan ce69026964 [Database version 1499] Create new paradigm classes for Diaspora Contact 
- Switch table fcontact for dcontact in views
 2022-12-05 00:00:50 -05:00
Michael 08d64f3c57 Fix the function description 2022-12-05 03:46:40 +00:00
Marek Bachmann fbd4b54656 Support more than 2 images 2022-12-05 04:23:34 +01:00
Marek Bachmann 6753eeab8b First draft for using a image grid to display attached images. 2022-12-05 03:27:51 +01:00
Michael 5bff6f38d7 Issue 12327: Convert avatars to static 2022-12-04 23:31:23 +00:00
Michael 5c74113bf6 Issue 12275: Banner upload via avatar does work now 2022-12-04 16:33:29 +00:00
Hypolite Petovan 552a30e1f3
Merge pull request #12329 from annando/blurhash 
Use the blurhash when the remote picture doesn't load
 2022-12-04 10:34:30 -05:00
Michael 1c8690a872 Fix calls for pictures without blurhash 2022-12-04 15:14:43 +00:00
Michael cfe5101b9b Use the blurhash when the remote picture doesn't load 2022-12-04 14:58:53 +00:00
Philipp b3ca1e2bfb
Merge pull request #12325 from annando/blurhash 
API: Support Blurhash
 2022-12-04 15:25:33 +01:00
Michael a5be5b27e3 Support Blurhash 2022-12-04 13:29:21 +00:00
Michael 1d8c9276f3 Issue 10518: "last-activity" instead of "login_date" 2022-12-04 07:03:11 +00:00
Michael e4dda7d2ca Issue 11553: Reliably return the user's contacts 2022-12-03 14:19:48 +00:00
Michael edc6851f0e Issue 12302: Remote self is working again 2022-12-03 07:15:29 +00:00
Matthias Moritz 7a39dfe23b Merge branch 'event-details-do-not-render-correctly-#12308' of https://github.com/matthiasmoritz/friendica into event-details-do-not-render-correctly-#12308 2022-12-02 21:01:20 +01:00
Matthias Moritz f27d9cb73e Update Event.php 2022-12-02 20:59:24 +01:00
Matthias Moritz 942d1e15f6
Merge branch 'friendica:develop' into event-details-do-not-render-correctly-#12308 2022-12-02 20:42:58 +01:00
Matthias Moritz 8b2a3805b6 Update Event.php 
fixing double encoding issue in event view.

fixes #12308
 2022-12-02 20:42:16 +01:00
Hypolite Petovan 98f4a68890 Ward against missing hidewall key in profile array in Model\Profile::getVCardHTML 
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1335124938
- Add logging to troubleshoot unexpected case
 2022-12-02 08:17:06 -05:00
Hypolite Petovan 84b2a35e05 Add new public_calendar additional feature 
- This gives anonymous access to public events
 2022-12-01 08:06:07 -05:00
Hypolite Petovan b83526ad0b Tighten profile restriction feature 
- Prevent feed access to restricted profiles
- Rework display of restricted profiles with a redirect to the profile/restricted route
- Normalize permission checking with IHandleUserSession->isAuthenticated
- Remove unusable "nocache" parameter in feed module because session isn't initialized
- Reword setting name and description
 2022-12-01 08:03:35 -05:00
Hypolite Petovan 2baa56d478
Merge pull request #12298 from annando/api-suggestions 
Contact suggestions are now cached
 2022-12-01 05:25:44 -05:00
Michael 1d00947bcd Don't fetch sugestions for the system user / catch error on contact timeline 2022-12-01 07:07:59 +00:00
Michael 146f874c2e Avoid 'Undefined array key "last-activity"' 2022-12-01 06:12:13 +00:00
Hypolite Petovan 8012968506 Check post existence before accessing its properties in Model\Post\UserNotification 2022-11-30 19:30:36 -05:00
Michael ed1a879b7b Use "utcNow" 2022-11-30 22:36:58 +00:00
Michael f905220923 New field to show the day of the last activity 2022-11-30 22:34:50 +00:00
MarekBenjamin 8f5d6fdf72
Merge branch 'friendica:develop' into show_image_upload_limit 2022-11-30 18:19:18 +01:00
Michael fbcc56d42d Changes after code review 2022-11-30 14:33:55 +00:00
Michael a01cdccb05 Check that an auto reshare is only done on the expected contact 2022-11-30 09:28:27 +00:00
Michael f31e617f5d Contact suggestions are now cached 2022-11-30 05:59:27 +00:00
Marek Bachmann 79235b6db1 Removed redundant maximagesize = INF statements 2022-11-30 05:17:48 +01:00
Hypolite Petovan 150c0e0750 Address some PHP 8.1 deprecation notices 
- Replace a strstr call by strpos in Model\APContact
- Simplify conditions in Protocol\DFRN
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1331012289
 2022-11-29 21:37:41 -05:00
Marek Bachmann 97a3587e58 Added handling as infinity if maxfilesize is set to 0 2022-11-30 02:44:48 +01:00
Marek Bachmann bbd1c34292 Wrapped all occurrences of DI::config()->get('system', 'maximagesize') with Strings::getBytesFromShorthand() 2022-11-30 02:26:56 +01:00
Michael 8b41d62a88 API: Speed improvements 2022-11-29 18:45:30 +00:00
Michael c00004f6ea API: Tredning statuses added 2022-11-28 09:30:41 +00:00
Hypolite Petovan db987999b5 Return only one result in case of exact match in Api\Mastodon\Search 2022-11-27 08:28:52 -05:00
Hypolite Petovan 9fbdcb5459
Merge pull request #12277 from nupplaphil/mod/fbrowser 
Move mod/fbrowser to src\Modules\Attachment|Photos\Browser
 2022-11-27 07:55:55 -05:00
Philipp b56e6f4b5b
Merge pull request #12280 from MrPetovan/bug/11804-delete-notifications-item 
Remove related notifications when marking an item for deletion
 2022-11-27 09:01:28 +01:00
Hypolite Petovan 25e1412174 Remove related notifications when marking an item for deletion 2022-11-26 21:48:26 -05:00
Philipp 3ac3b3d2af
Perfection! 2022-11-27 01:52:49 +01:00
Philipp 051253a745
Move FileBrowser to own namespace & Bugfix album usage 2022-11-27 01:34:58 +01:00
Philipp 3607aa32ca
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2022-11-27 01:34:58 +01:00
Hypolite Petovan a5f601718f Add a default value for $data['version'] in Model\GServer 
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1327320541
 2022-11-26 17:28:55 -05:00
Hypolite Petovan b6d62003a6 Have a default value for $item['contact-id'] in Model\Post\Delayed 
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1327030873
 2022-11-26 17:27:36 -05:00
Philipp d0b16b2fc1
Move mod/fbrowser to src\Modules\Attachment|Photos\Browser 2022-11-26 22:26:30 +01:00
Hypolite Petovan 0ec7238da4 Fix null value passed to string functions deprecation notices 
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513
 2022-11-25 08:13:05 -05:00
Michael fa5e7585a3 Fix "Argument #1 ($parts) must be of type array, bool given" 2022-11-25 06:08:56 +00:00
Michael a6ff817f47 Update added 2022-11-23 21:47:47 +00:00
Michael 8bbf3f3699 "MIRROR_FORWARDED" is no more 2022-11-23 21:10:57 +00:00
Michael 352b7a0ac3 "MIRROR_FORWARDED" is removed 2022-11-23 14:00:34 +00:00
Michael 25992b063a Merge remote-tracking branch 'upstream/develop' into no-api-post 2022-11-23 06:28:24 +00:00
Michael f600f68907 No more automated posts via mod/item.php 2022-11-23 06:27:40 +00:00
Hank Grabowski 548fd3201d The two endpoints for unfavoriting/liking (and related things) was failing because it wasn't using the correct uuid in item.php in processing the action. 2022-11-21 16:49:20 -05:00
Hypolite Petovan 77e87da441 Create /profile/{nickname}/photos route 
- Create new Profile\Photos\Index module class
- Update most references of the legacy /photos/{nickname} route
 2022-11-20 17:15:07 -05:00
Hypolite Petovan 6dcc964ed8 Fix string interpolation in Model\Photo::upload 2022-11-20 17:07:08 -05:00
Hypolite Petovan 99df11e99b Fix PHP 8 inheritance deprecation warnings in App\PAge and ParsedLogIterator 2022-11-19 19:30:48 -05:00
Hypolite Petovan 6f93ee7e49 Fix various PHP 8 deprecations 2022-11-19 19:15:47 -05:00
Hypolite Petovan 3d5b81e4ef
Merge pull request #12213 from Schnoop/bugfix/NodeInfo 
Fix that users property should be an object instead of array.
 2022-11-19 11:59:33 -05:00
Thorsten 877369d964 Fix that user property should be an object instead of array. 2022-11-19 16:48:07 +01:00
Hypolite Petovan 6460218c0e Ensure register records aren't created with uid = 0 
- uid = 0 matches system account and public contact records, giving unexpected display in pending user list. More importantly, the originally created user can't be approved since its user id is lost.
 2022-11-18 16:04:02 -05:00
Philipp 53f3454874
Merge pull request #12184 from annando/duplicated-media 
This fixes duplicated media in quoted posts
 2022-11-15 21:17:19 +01:00
Michael 348156dbcf Simplify the check 2022-11-15 19:55:03 +00:00
Michael eca52627c1 This fixes duplicated media in quoted posts 2022-11-15 19:48:43 +00:00
Philipp 3259bd17dc
Move mod/(update_)display.php to src\Module 2022-11-15 00:57:47 +01:00
Hypolite Petovan fe547b7851 Centralize config.admin_email management in Model\User 2022-11-14 17:02:42 -05:00
Hypolite Petovan 48b1dceb19 Don't send item notifications to deleted user accounts 2022-11-14 17:02:42 -05:00
Hypolite Petovan 6df187478d Fixed wrong reference to user.expire in Model\User::getActorName 
- Update field documentation to prevent further confusion
 2022-11-14 17:02:41 -05:00
Hypolite Petovan 10e48a34f2 Ensure Post::toArray returns an array 
- We don't handle query errors anyway
- Remove unused parameter do_close
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314245581
 2022-11-14 14:53:54 -05:00
Hypolite Petovan eb6b03b555 Add new OStatus\PortableContacts module class 
- Retain existing route /poco for backward compatibility
- Remove unsupported links to /poco/{nickname} route
 2022-11-14 13:48:46 -05:00
Michael 9506bf6989 Avoid duplicate media elements 2022-11-13 23:38:48 +00:00
Hypolite Petovan 4a626ef101 Create new Contact\Redir module class 
- Move /redir route to /contact/redir
 2022-11-08 20:12:23 -05:00
Hypolite Petovan 386c08aa05 Remove superfluous calls to DI::baseUrl in Contact:photoMenu 2022-11-08 19:31:09 -05:00
Hypolite Petovan a68c790c64 Create new Settings\RemoveMe module class 
- Moved route from /removeme to /settings/removeme
- Combined templates into one
 2022-11-08 18:33:54 -05:00
Michael 246021fdfa Store the source of incoming posts 2022-11-08 11:53:09 -05:00
Hypolite Petovan 561f22cdc4 Add title to homepage verified check mark 
- Decrease log level for not found Memcached keys
 2022-11-08 04:20:19 -05:00
Michael 664071a0b1 Quoted reshares containing quoted reshares should now look fine 2022-11-07 20:44:20 -05:00
Philipp 78a8ed6fe7
adhere feedback 2022-11-07 20:21:11 +01:00
Philipp f13c91b320
Move mod/cal.php and mod/events.php to Module 2022-11-07 19:52:24 +01:00
Michael 210200d330 Use different parser modes for Mastodon and Twitter-API 2022-11-06 20:02:43 +00:00
Hypolite Petovan 3e33ec0c0f Suppress InvalidArgument exceptions handling URLs in Model\Item::containsLink 2022-11-05 20:18:14 -04:00
Michael Vogel ea49ab6e04
Merge pull request #12114 from MrPetovan/bug/12112-unFollow 
Fix capitalization of unfollow links in Model\Contact
 2022-11-06 00:21:27 +01:00
Michael 70d0f087b7 Issue 12096: Improve account search 2022-11-05 22:08:28 +00:00
Hypolite Petovan e763f57d29 Fix capitalization of unfollow links in Model\Contact 2022-11-05 17:54:50 -04:00
Michael 4dd2d7ebab Transmit the quoted part in the source 2022-11-05 16:25:04 +00:00
Hypolite Petovan fa123bd765 Rename Repository\Notify->NotifyOnDesktop to shouldShowOnDesktop 
- New name better reflect the behavior
 2022-11-04 06:42:37 -04:00
Philipp 2c90ab69d6
Move event export to src/Module/Events/Export 2022-11-02 15:16:23 +01:00
Michael 1f1c2d8ca6 (Hopefully) query performance improvements 2022-11-01 08:45:25 -04:00
Philipp baa97febef
hopefully last feedback :) 2022-11-01 00:09:30 +01:00
Philipp 87291e30a4
Found some more follow-links 2022-10-31 20:58:34 +01:00
Philipp b5d01337d9
Move Follow to /contact namespace 2022-10-31 20:58:27 +01:00
Hypolite Petovan 58d6e7e2bb Create Contact\Unfollow module class 2022-10-31 15:31:44 -04:00
Hypolite Petovan a1e6e13a9f Move remote follow module to profile folder 2022-10-31 15:31:43 -04:00
Hypolite Petovan 5de8fe3a48 Fix unfollowing not showing on contact page 
- Deleted contact rows kept the relationship status which would keep showing
- Deleting contact rows would also not update the corresponding user-contact record
 2022-10-31 15:30:23 -04:00
Hypolite Petovan 9561910e83 Create Profile\UnkMail module class 2022-10-30 10:49:47 -04:00
Hypolite Petovan 3865733e18 Move Model\Profile::getMyUrl to UserSessions 2022-10-30 10:49:47 -04:00
Michael eae1383f48 Merge remote-tracking branch 'upstream/develop' into quote 2022-10-30 11:38:17 +00:00
Michael b402a760a8 Symplified code 2022-10-30 10:02:12 +00:00
Michael a183723254 Improved handling of contact links 2022-10-30 10:02:01 +00:00
Michael f569ccbbc2 Code is simplyfied 2022-10-29 22:55:39 +00:00
Michael 3c169b534e Improved handling of native quotes 2022-10-29 22:11:39 +00:00
Hypolite Petovan a2adb1cd93
Remove unused argument from L10n->tt() call in Model/Item.php 2022-10-28 13:45:09 -04:00
René Wagner b99e7a9e92
fix exception when adding an poll option without votes 2022-10-28 18:51:35 +02:00
Hypolite Petovan f418687a71
Merge pull request #12070 from annando/share 
Some more improvements for posts with shares
 2022-10-27 08:19:23 -04:00
Michael deccea0228 More functions moved to content class 2022-10-27 05:44:44 +00:00
Michael c65fff6f93 Some more improvements for posts with shares 2022-10-26 17:00:55 +00:00
Roland Häder 498d7f690a
Changes: 
- php-cs is now happy with it
 2022-10-26 17:59:10 +02:00
Roland Häder 2f1336339f
Changes: 
- added missing type-hints
- added missing documentation
- changed double-quotes to single
- Setters do ALWAYS return void
 2022-10-26 01:29:01 +02:00
Roland Häder 5306bb3e31
Changes: 
- added more missing type-hints (checked them in body of the method)
- reformatted code a little (code-style)
- moved '/.well-known/host-meta' to constant Probe::HOST_META
 2022-10-25 20:25:13 +02:00
Michael ebd175872d Improved description 2022-10-25 08:45:41 +00:00
Michael 1a0b63659b Merge remote-tracking branch 'upstream/develop' into share-rework 2022-10-25 08:31:01 +00:00
Michael f54a886a5e The "share" handling is improved 2022-10-25 06:37:23 +00:00
Philipp 8ad83e5d5c
Add missing DI 2022-10-21 19:16:25 +02:00
Philipp b4ffb0bde0
UserSession class [4] - Refactor src/Model/ files 2022-10-20 22:14:50 +02:00
Philipp 940619325d
Add SessionUsers class including tests 2022-10-20 20:27:34 +02:00
Michael ee1acba9eb old boot.php functions replaced in /src 2022-10-19 07:56:25 -04:00
Philipp 7ac86e49d1
Move Core\Session::get() to DI::session()->get() 2022-10-18 21:10:37 +02:00
Roland Häder 26e0469de7
Merge branch 'develop' into rewrite/gravity-constants 2022-10-18 16:34:40 +02:00
Michael 6f68679375 The EOL constant is removed 2022-10-18 12:29:50 +00:00
Michael fdfa1f8630 The notice and info have been moved 2022-10-17 18:55:22 +00:00
Michael 018858934b The priority is now a class constant 2022-10-17 05:49:55 +00:00
Michael f8f0dfa91a Detect linked posts and add them as quote 2022-10-16 21:37:05 +00:00
Michael 8e1af9277a Improve quite generation 2022-10-15 13:00:52 +00:00
Roland Häder da66730e4f
Rewrite: 
- moved constants GRAVITY_* from boot.php to Friendica\Model\Item
- also rewrote some array initialization:

From:
````
<?php
$arr = [];
$arr['foo'] = "FOO";
````

To:
````
<?php
$arr['foo'] = "FOO";
````
- added a few type-hints
 2022-10-15 00:44:06 +02:00
Michael 3e868416c7 Check for post existence 2022-10-14 22:02:25 +00:00
Michael 88aceeb27f Merge remote-tracking branch 'upstream/2022.09-rc' into quote-uri-id 2022-10-14 19:11:15 +00:00
Hypolite Petovan 0480d9aebd Add missing post keys to retrieve pLink in Model\Event::prepareListForTemplate() 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1275117722
 2022-10-11 22:18:52 -04:00
Michael 0e82f64d71 Only attach images 2022-10-11 21:39:28 +00:00
Hypolite Petovan 9e74a1bd06 Contact array can be empty in Model\Contact::getAvatarPath 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1274195844
 2022-10-11 08:26:00 -04:00
Michael aeb4645ba6 New field "quote-uri-id" for quoted posts 2022-10-10 22:39:30 +00:00
Hypolite Petovan a10f55bb85
Merge pull request #11979 from annando/issue-11853 
Notices
 2022-10-09 17:45:33 -04:00
Michael 0d3aa681b4 The quote functionality is simplified 2022-10-09 21:16:36 +00:00
Michael 4a37c978c2 Issue 11969: Simplified share 2022-10-08 09:36:35 +00:00
Michael 21bd2a8396 More whitespace 2022-10-07 07:57:20 +00:00
Michael ef934db614 Moved the share interpretation 2022-10-07 07:41:03 +00:00
Michael d7a9745ffd Simplified share element 2022-10-07 05:51:36 +00:00
Michael 48182a95fb Improve quote share ("message_id" added) 2022-10-06 21:50:20 +00:00
Michael c65f78e579 Only display reshared thread starting posts 2022-09-28 09:48:48 +00:00
Michael 2def5e9f02 Issue 11876: Fix local message distribution 2022-09-27 15:58:16 +00:00
Hypolite Petovan 02e9a867ae
Merge pull request #11926 from annando/sql-queries 
(Hopefully) SQL improvements
 2022-09-24 15:01:34 -04:00
Michael Vogel b00947025a
Merge pull request #11922 from MrPetovan/bug/notices 
Ward against missing keys in Model\APContact::isRelay
 2022-09-24 20:02:21 +02:00
Michael 3911c9450b (Hopefully) SQL improvements 2022-09-24 17:56:07 +00:00
Hypolite Petovan 6ca725e5b6 Check for network key existence before calling Probe::isProbable in Model\Contact 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1253225607
 2022-09-24 10:18:41 -04:00
Hypolite Petovan ded5a0ac6a Ward against missing keys in Model\APContact::isRelay 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1231904280
 2022-09-24 09:56:12 -04:00
Michael 36668dfdb1 Merge remote-tracking branch 'upstream/2022.09-rc' into duplicates 2022-09-21 03:46:25 +00:00
Michael Vogel 199d8bbf35 Merge remote-tracking branch 'upstream/2022.09-rc' into relay-languages 2022-09-20 06:05:15 +02:00
Michael Vogel 6ba2c4bb01 Added documentation 2022-09-19 12:49:37 +02:00
Michael Vogel 3650feb256 "Count" parameter added 2022-09-19 12:46:28 +02:00
Michael Vogel f08b08e0d8 Allow to reject specific languages on receiving posts via the relay 2022-09-19 12:36:12 +02:00
Michael Vogel e5c24f33f0 The fcontact table is now updated in the background to improve performance 2022-09-18 15:40:44 +02:00
Michael 79b64cc44f Detect and remove contact duplicates 2022-09-16 05:00:06 +00:00
Hypolite Petovan 7da43fe28a
Merge pull request #11892 from annando/pagecache 
Pagecache for frequently fetched pages
 2022-09-07 22:25:19 -04:00
Michael a0b99f61ea Use the cached activity function 2022-09-07 19:46:24 +00:00
Michael da658cbf1d Delete the cache entry when the post is changed or deleted 2022-09-06 21:51:47 +00:00
Michael ec8377a8c7 Issue 11893: Postupdate to fix wrong parents 2022-09-06 20:00:06 +00:00
Michael 6eb9dff807 Pagecache for frequently fetched pages 2022-09-06 06:04:41 +00:00
Hypolite Petovan 8f283985f0
Merge pull request #11884 from annando/language 
Improved language detection
 2022-09-04 15:52:29 -04:00
Michael e2cb705468 Merge remote-tracking branch 'upstream/2022.09-rc' into language 2022-09-04 17:04:13 +00:00
Michael 437c230a6f Merge remote-tracking branch 'upstream/2022.09-rc' into database 2022-09-04 17:03:14 +00:00
Michael 144547009b All URL fields are now binary and longer 2022-09-04 07:54:01 +00:00
Michael 4304aa9eec Improved language detection 2022-09-04 07:32:46 +00:00
Michael 9f2d3e6f88 Use AP data when possible 2022-09-04 07:15:04 +00:00
Michael cc43b567cb Some changes after code review 2022-08-31 19:03:37 +00:00
Michael f7b85092b0 Some more changed log levels 2022-08-31 05:01:22 +00:00
Michael 757a5c2de9 Loglevels are adjusted 2022-08-30 19:45:30 +00:00
Michael 3a840aa22d Some more warnings and erors are fixed 2022-08-28 19:27:21 +00:00
Michael 3052ae71b7 Avoid warnings 2022-08-28 09:12:36 +00:00
Michael 2173fb38e0 Issue 11853/11867: Fix reshare of public posts 2022-08-27 21:22:49 +00:00
Michael a0eaff8fd5 Fix issue 11865 2022-08-27 11:43:46 +00:00
Michael ceb88c10e6 Warnings/Errors reduced - improved relay processing 2022-08-27 08:08:58 +00:00
Michael dd8279afc2 Some more protection against database errors 2022-08-25 18:47:07 +00:00
Michael 15d975f143 Avoid some database errors 2022-08-25 04:57:41 +00:00
Michael 2a0ca80630 The contact-id of a wall posting is always the owner contact 2022-08-22 07:54:48 +00:00
Michael 51331ced9b Improved function to fetch the contact id 2022-08-18 10:13:46 +00:00
Michael a4f1df68e4 Improved contact-id detection 2022-08-18 07:48:39 +00:00
Michael 531085890a Fetch the parent only - thread parents only on reshares 2022-08-17 19:39:20 +00:00
Michael 6070221364 Improved checks in "storeForUserByUriId" to reduce recursion depth 2022-08-17 05:28:24 +00:00
Michael 4d617c9c48 This cache key doesn't exist anymore 2022-08-15 18:46:10 +00:00
Michael 5b3145d7ce Several performance improvements 2022-08-15 13:23:01 +00:00
Michael c6de91a8ec Don't delete the post when there is some undeleted post-user 2022-08-13 12:24:25 +00:00
Michael 5c5ae00370 Improved performance when updating contacts 2022-08-13 09:01:48 +00:00
Philipp a145712f04
Merge pull request #11837 from MrPetovan/task/remove-poke 
Remove poke feature
 2022-08-11 18:17:11 +02:00
Hypolite Petovan 809beeee9d
Merge pull request #11838 from annando/asynchronous-conversation 
Conversation entries will now be stored asynchronous if possible
 2022-08-10 10:42:19 -04:00
Michael d9aee0b3ea Conversation entries will now be stored asynchronous if possible 2022-08-10 09:28:18 +00:00
Hypolite Petovan 4a885a13a6 Remove poke feature 2022-08-09 14:55:55 -04:00
Hypolite Petovan f917286d6e Use L10n->tt instead of t() for plural strings for polls in Model\Item 2022-08-08 01:52:16 -04:00
Michael d60d2caef6 Improved queue processing 2022-08-07 19:24:50 +00:00
Michael 06f7244280 New option to disable the fetching of parents 2022-08-04 19:32:36 +00:00
Hypolite Petovan 196a1de7f2
Merge pull request #11812 from annando/ap-performance 
Hopefully fixes loops during message processing
 2022-08-03 03:00:50 -04:00
Michael f2eec66240 Hopefully fixes loops during message processing 2022-08-03 03:38:03 +00:00
Hypolite Petovan 49394aedeb Add password length limit if using the Blowfish hashing algorithm 
- Add new page to reset a password that would be too long
- Add support for pattern parameter in field_password
 2022-08-01 12:12:18 -04:00
Michael 3945de5e3b No blubb allowed 2022-08-01 00:58:56 +00:00
Michael 0347f4fc66 Remove test code 2022-07-31 16:01:56 +00:00
Michael b6da15557b The post-reason / protocol is now filled in most cases 2022-07-31 15:54:35 +00:00
Hypolite Petovan 2e75d442a5
Merge pull request #11793 from Quix0r/reformatted-arrays 
Reformatted some arrays for better readability
 2022-07-29 17:54:53 -04:00
Michael f9bf2424b1 Merge remote-tracking branch 'upstream/develop' into post-reason 2022-07-29 21:29:15 +00:00
Michael 699152e15e Add more post reasons 2022-07-29 21:28:22 +00:00
Michael 0971bcf165 Make the tests happy 2022-07-29 16:05:04 +00:00
Roland Häder 1210e235fb
Extracted as variable to have 2 more array fields moved to array initialization. 2022-07-29 17:20:09 +02:00
Roland Häder 676ca36c52
Changes: 
- reformatted arrays
 2022-07-29 17:20:07 +02:00
Michael 2c32429d8d Fix test 2022-07-29 14:56:40 +00:00
Michael 81aaacc67d Improvements for the "post-reason" 2022-07-29 14:17:53 +00:00
Roland Häder f8ed028013
Changed back to $cdata. 2022-07-29 12:41:08 +02:00
Hypolite Petovan a20d05ba39
Merge pull request #11792 from Quix0r/fixes/get-request-value 
Wrong variable name fixed (maybe copy-paste mistake) + used method instead of direct array access
 2022-07-28 21:17:34 -04:00
Roland Häder eaed3945d1
Changed: 
- used `$this->getRequestValue($request, 'foo', <bar>)` instead of `$request['foo'] ?? <bar>`
- fixed wrong variable naming
- changed double-quotes to single
- see https://github.com/friendica/friendica/issues/11631#issuecomment-1196410497
 2022-07-29 00:38:46 +02:00
Roland Häder 37bda3e5fb
Changes: 
- fixed wrong type-hint uid => int
- added returned type-hint
- added some documentation
- formatted arrays a bit
 2022-07-29 00:08:38 +02:00
Michael ff9dc1e291 Merge remote-tracking branch 'upstream/develop' into untrusted 2022-07-27 17:56:56 +00:00
Michael 86105635ca Improved message handling / new activity relay handling 2022-07-27 17:39:00 +00:00
Michael Vogel f9777ce0dc
Merge pull request #11770 from MrPetovan/bug/notices 
Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId
 2022-07-25 21:01:12 +02:00
Hypolite Petovan 488f4dcaa4 Handle rare case where contact doesn't exist in Model\Group::getIdsByContactId 
- Address https://github.com/friendica/friendica/issues/11632#issuecomment-1193953621
 2022-07-25 12:07:42 -04:00
Roland Häder d1b21eaf42
Changes: 
- use local variables
 2022-07-25 17:53:54 +02:00
Roland Häder 1ac1db6173
Changed: 
- rewrote to almost one block of array initialization
 2022-07-25 16:49:01 +02:00
Hypolite Petovan a5d679ea95
Merge pull request #11759 from annando/enqueue-posts 
Fetch missing posts via a queue
 2022-07-24 15:38:44 -04:00
Michael 6abb4d40d6 Handle changed parents 2022-07-24 13:09:35 +00:00
Roland Häder 86ef7c66d3
Changes: 
- added some missing type-hints, thanks to @MrPetovan
 2022-07-23 23:09:35 +02:00
Roland Häder ba1c1049d6
Changes: 
- added some type-hints
- added some documentation
- used self::exists() instead of DBA::exists('user', ['uid' => $uid])
 2022-07-23 21:58:00 +02:00
Roland Häder a2a7d04fa1
Changed double-quotes to single 2022-07-23 21:58:00 +02:00
Hypolite Petovan edc49ec9b4 Add expected "users" property to NodeInfo usage property for all versions 2022-07-23 13:21:44 -04:00
Michael abf39ff9cf Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-23 12:55:34 +00:00
Michael 8c602071c2 Bookwyrm posts now work 2022-07-23 12:50:15 +00:00
Michael 7eb410bed7 Conversation/context is now stored 2022-07-23 06:52:43 +00:00
Michael 1d13574225 Fetching of missing posts is reworked 2022-07-21 05:16:14 +00:00
Michael 7dcd02938d Remove entries from queue / relay detection 2022-07-20 05:37:40 +00:00
Roland Häder cf8698afe6
This is the correct way: 
<?php
if (!isset($foo['account_removed) || $foo['account_removed'])
?>
 2022-07-19 18:08:18 +02:00
Roland Häder cb2a052a70
Fixed E_NOTICE, for some strange reason 'account_removed' isn't around? 2022-07-18 23:49:58 +02:00
Michael af8e059990 Renamed platform definition file 2022-07-18 03:48:19 +00:00
Michael 46fdd9893c Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-17 15:42:09 +00:00
Michael 2ddf37f32d Emergency fixes to fix a bunch of fatal errors 2022-07-17 11:47:12 +00:00
Michael d52f52f45f Somed added documentation 2022-07-17 05:42:44 +00:00
Michael 0a19759e4f Fix wrong variable type 2022-07-16 13:44:35 +00:00
Michael 8b7cb5d9ef Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-16 12:44:21 +00:00
Michael 896fd3fc91 Use the redirect value 2022-07-14 05:39:25 +00:00
Philipp d74e57ef2c
include suggested changes 2022-07-13 00:23:12 +02:00
Philipp a910fd8864
Split DBStructure & View to avoid DB-calls and dependencies for basic operations 
- new "Definition" classes vor DB and Views
- new "Writer" classes to create SQL definitions for DB and Views
- DBStructure & View are responsible to execute DB-querys
 2022-07-12 23:40:31 +02:00
Michael dad05f1c76 Only fetch the first word for the platform 2022-07-10 13:52:38 +00:00
Michael 85c7bacb00 Improved server detection 2022-07-10 13:01:47 +00:00
Hypolite Petovan eb8237dd89 Remove unused uid parameter in Item::newURI 2022-07-09 07:39:51 -04:00
Michael cc75eb5d18 Improved server detection 2022-07-05 05:04:05 +00:00
Roland Häder a392a22eee
Changes: 
- added some type-hints
- fixed some documentation (void is lately returned, not null)
- added some documentation
 2022-06-27 15:16:17 +02:00
Roland Häder 98bc5216ef
A bit more documentation 2022-06-27 15:16:17 +02:00
Roland Häder 8e19998191
Fixes: 
- more "bool expected but null returned" errors
 2022-06-27 13:49:53 +02:00
Roland Häder 7c049abfda
Fixed: 
- Contact/User::isBlocked() needs to return boolean, but sometimes (strangely)
  a NULL can come from database, so let's cast it

This tries to fix:
TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
 2022-06-27 11:39:18 +02:00
Philipp e594656a48
Merge pull request #11684 from MrPetovan/bug/11651-ap-fetch-queue 
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
 2022-06-26 13:36:19 +02:00
Philipp 0223c030a9
Improve 2 factor usage 2022-06-25 23:04:00 +02:00
Hypolite Petovan da32fa8fa6 Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes 
- These classes are used to flatten the recursive missing activity fetch that can hit PHP's maximum function nesting limit
- The original caller is responsible for processing the remaining queue once the original activity has been fetched
 2022-06-25 12:40:54 -04:00
Hypolite Petovan 3c70d592f6
Merge pull request #11689 from Quix0r/rewrites/double-quotes-single 
Changed more double-quotes to single
 2022-06-25 12:02:01 -04:00
Hypolite Petovan a7d49877a8 Centralize share tag attribute extraction code in Content\Text\BBCode 2022-06-25 11:46:52 -04:00
Roland Häder 88870d18be
Changes: 
- added some type-hints
- added documentation
 2022-06-25 16:48:36 +02:00
Roland Häder 39675fe683
Space for the rescue. ;-) 2022-06-25 16:48:35 +02:00
Roland Häder f12cc9648e
Changes: 
- added some type-hints
- changed some double-quotes to single
 2022-06-25 16:48:35 +02:00
Hypolite Petovan aa133b5437 Add explicit gserver.site_name string truncate in Model\GServer 
- Avoids "Data too long for column 'site_name'" database errors
 2022-06-25 06:25:48 -04:00
Hypolite Petovan 636b84b41c Update return value type-hint of GServer::getProtocol 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1164880874
 2022-06-25 05:06:22 -04:00
Hypolite Petovan c5b46fe748
Merge pull request #11681 from Quix0r/fixes/item-guidfromuri-allow-null 
Allowing Item::getFromUri()'s 2nd parameter a null value
 2022-06-24 10:15:26 -04:00
Roland Häder 82bb36e13d
Changes: 
- Made Item::guidFromUri()'s $host parameter optional (allowing null)
- added some type-hints
- added documentation
- this may fix reported issue in #11630
 2022-06-24 03:17:57 +02:00
Philipp d441b90bda
Respect Forwarded-For headers 2022-06-23 22:42:35 +02:00
Roland Häder 202857ba7d
No need to log $tid here 2022-06-23 17:30:17 +02:00
Roland Häder fd8f4269ff
Reformatted code 2022-06-23 17:30:17 +02:00
Roland Häder 182c3db9b8
Changes: 
- added type-hints
- added missing documentation
 2022-06-23 17:30:15 +02:00
Roland Häder b8353a6eb7
Changes: 
- reformatted some array
- added missing documentation
- added type-hints
- changed double-quotes to single
 2022-06-23 17:30:14 +02:00
Roland Häder c6c936a80f
Added more type-hints 2022-06-23 17:30:14 +02:00
Roland Häder 2f3705f471
Continued: 
- renamed varibales to $camelCase
- added type-hints
- updated documentation
 2022-06-23 17:30:11 +02:00
Roland Häder 7eefb9aed8
Changed: 
- empty() is maybe superflous here, still I would prefer a code style that is
  written explicitly and not rely on "magic casting"
 2022-06-22 18:57:01 +02:00
Roland Häder 101cd2dd10
Changes: 
- added some documentation
- fixed some documentation
- changed more double-quotes to singl
 2022-06-22 16:14:14 +02:00
Roland Häder ee8d0ad619
Changes: 
- added more type-hints
- added some documentation
 2022-06-22 14:36:47 +02:00
Tobias Diekershoff 4650ff53d9
Merge pull request #11662 from MrPetovan/bug/11661-splitattachment-null 
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
 2022-06-21 06:48:52 +02:00
Roland Häder 752953e472
Changes: 
- as @MrPetovan pointed out, $actor can be NULL earlier and used later as NULL
- added some missing type-hints
- added missing documentation
- the added @TODO points out to avoid true|false|null for a boolean
 2022-06-20 21:00:19 +02:00
Hypolite Petovan 88eacbf66e Ensure parameter 4 of Post\Media::splitAttachment is a boolean value 2022-06-20 14:34:02 -04:00
Roland Häder 4fb03cf163
Changes: 
- fixed a null value handled over to Friendica\Model\APContact::getByURL()
- added missing type-hints
 2022-06-20 19:05:02 +02:00
Roland Häder e96a548286
Changes: 
- dumped default value for $input
- added unknown 'platform' which prevents an "Undefined index: platform in
  /var/www/.../src/Model/GServer.php on line 940" error
 2022-06-20 18:56:22 +02:00
Roland Häder c0d7f8944d
Some calls saved 2022-06-19 11:26:10 +02:00
Roland Häder 2c5685c89c
Changes: 
- changed to proper "use Foo\Bar;"
- added doctag
- added return type as this is fixed
 2022-06-19 01:11:30 +02:00
Roland Häder 39f2d197ea
Changed to suggestings (back to original) + fixed typo in scalar type 2022-06-18 23:30:37 +02:00
Roland Häder 6f1d52cf71
Changed back to suggestions by @MrPetovan 2022-06-18 23:24:08 +02:00
Roland Häder fa14a02a19
Changes: 
- added type-hints
- added documentation
- changed double-quotes to single
 2022-06-18 23:12:52 +02:00
Roland Häder f3b57008b5
Proper type is string 2022-06-18 18:41:16 +02:00
Roland Häder 41f34c4261
Maybe fix for: 
"Argument 1 passed to Friendica\Model\ItemURI::getIdByURI() must be of the type string, null given, called in Processor.php line 1219"
 2022-06-18 18:30:50 +02:00
Roland Häder 9691bb06fb
Changes: 
- added more type-hints
- added missing documentation
 2022-06-18 18:21:29 +02:00
Roland Häder 94eb426151
Nodeinfo::getOrganization() doesn't need configuration object being inserted 
when you have DI::config() around.
 2022-06-18 17:56:33 +02:00
Roland Häder c29c49797a
Added missing type-hints 2022-06-18 17:52:46 +02:00
Roland Häder 4e437190c5
Renamed variable, no need for "orig_" prefix 2022-06-18 17:50:11 +02:00
Roland Häder a1a81cdc6b
Continued: 
- changed some double-quotes to single
- added missing type-hints
- added missing documentation
- fixed indenting a bit
 2022-06-18 17:46:34 +02:00
Roland Häder 8fc710f82a
Continued: 
- added more type-hints
- added some missing documentation
- Return the result from DBA::delete() to let other methods know about it
 2022-06-18 17:22:50 +02:00
Roland Häder 8ba3f13fae
Changes: 
- added more type-hints
- added missing documentation
 2022-06-18 17:09:46 +02:00
Roland Häder 7ec07178c8
Changes: 
- added missing type-hints
- added missing documentation
 2022-06-18 16:59:23 +02:00
Roland Häder adb4aea6ad
Changes: 
- added some type-hints
- replaced most double-quotes (only Diaspora.php, later more) with single
- added some documentation
- normalized indenting in Diaspora.php (I hope I got all?)
 2022-06-18 05:03:10 +02:00
Roland Häder 36d56a4041 Continued: 
- changed back to 'return false;' as other methods heavily rely on false instead
  of an empty array as pointed out by @heluecht@pirati.ca
- $fetched_contact should be initialized as an empty array, let's not make this
  code more crazier than it already is (see APContact::getByURL())
 2022-06-17 17:18:31 +02:00
Roland Häder c467bff79f Some more type-hints added 2022-06-17 17:18:31 +02:00
Roland Häder 4f3321cc9f Nore fixes 2022-06-17 17:18:31 +02:00
Roland Häder 10bb7d5625 Possible fix for 
Uncaught Exception TypeError: "Return value of
Friendica\Model\APContact::getByURL() must be of the type array, bool returned"
 2022-06-17 17:18:31 +02:00
Roland Häder fdd237a090 Fix for "Uncaught Exception TypeError: "Argument 1 passed to 
Friendica\Model\APContact::unarchiveInbox() must be of the type string, null
given" error message
 2022-06-17 17:18:31 +02:00
Roland Häder 605e7d55b3 Continued: 
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
  changed it to -1 to have a proper type-hint
 2022-06-17 17:18:31 +02:00
Roland Häder 227bab43a8 Ops, wrong type-hint here, must be string ($nickname can never be an integer). 2022-06-17 17:18:31 +02:00
Roland Häder e484b6d6dc Continued: 
- added more type-hints
- added some documentation
- Contact::getAccountType() should only process string, not null
 2022-06-17 17:18:31 +02:00