Commit Graph

10913 Commits

Author SHA1 Message Date
Hypolite Petovan e73adde5fb Remove App dependency from Hook::callSingle
- This was causing a circular dependency with the logger_instance hook
2023-01-14 10:38:37 -05:00
Hypolite Petovan 2d555b60dd
Merge pull request #12670 from annando/fix-avatar-cache
Ensure to reset the avatar paths when deleting avatar cache
2023-01-14 09:47:21 -05:00
Michael 3e3f2555dc Ensure to reset the avatar paths when deleting avatar cache 2023-01-14 13:10:43 +00:00
Hypolite Petovan 91ff24b0e4
Merge pull request #12663 from nupplaphil/sec/xss_404
Security: Use htmlspecialchars() for user input in Arguments class
2023-01-13 13:57:41 -05:00
Philipp 0530755332
Security: Use htmlspecialchars() for user input in Arguments class 2023-01-12 20:24:39 +01:00
Hypolite Petovan a7d0355849
Merge pull request #12659 from DanielSiepmann/12658-fix-feed-urls-with-whitespace
Properly handle feed item urls with surrounding whitespace
2023-01-12 07:57:30 -05:00
Daniel Siepmann 6633b0af4b
Properly handle feed item urls with surrounding whitespace
Some feeds might have whitespace around the URLs of each item.
This can't be handled by parse_url.
Therefore the incoming url is trimmed to not contain any surrounding
whitespace for proper handling.

Relates: #12658
2023-01-12 13:47:57 +01:00
Michael 8a902afde5 Updated messages.po - again 2023-01-12 07:06:24 +00:00
Michael 6cdafb6b63 Fix "Undefined constant Friendica\Content\Conversation::PARCEL_DIASPORA" 2023-01-12 06:57:31 +00:00
Michael f542211189 Mode depending control for the behaviour with blocked contacts 2023-01-12 06:25:55 +00:00
Hypolite Petovan ec54b303c5
Merge pull request #12655 from annando/fix-communication
Fix: Forum posts from some contacts weren't distributed
2023-01-11 17:04:41 -05:00
Michael 53e8b21ca3 Fix: Forum posts from some contacts weren't distributed 2023-01-11 21:55:32 +00:00
Philipp fef10e8a57
Improve encapsulation 2023-01-11 22:00:29 +01:00
Philipp 11a8bd17e3
Assure that deleted cat/keys are working as expected
- A deleted cache-key would delete a merged cache-key as well
- Deleting a key in the Model results in reloading the config to assure any value from underlying files
2023-01-11 21:53:34 +01:00
Philipp fd882abd80
Revert Cache delete() behavior to stable version 2023-01-11 21:10:59 +01:00
Hypolite Petovan 5c8cd8fdd6 Replace remaining mentions of "Status" by "Conversations" or "Posts" 2023-01-11 09:01:29 -05:00
Hypolite Petovan d0648b10ef Convert Content\Nav to dynamic object
- Remove DI dependency in Module\Apps
2023-01-11 09:01:24 -05:00
Hypolite Petovan 3966b58965 Only show line number if it's provided in System::callstack
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1377373973
2023-01-10 10:41:20 -05:00
Hypolite Petovan 3fcafd1d50 Replace HTML regular expression by HTML::extractCharset in ParseUrl::getSiteInfo
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1374537440
2023-01-10 10:36:59 -05:00
Hypolite Petovan 5e2b655b43 Add implementation of HTTP Media Type
- Add charset extraction from DOMDocument
- TESTS!
2023-01-10 10:36:58 -05:00
Hypolite Petovan f4b5d22396
Merge pull request #12644 from annando/improve-ignore
Improve the ignore behaviour
2023-01-10 09:05:48 -05:00
Michael 20a2cec0b0 Moved permission assigning / simplified block check 2023-01-10 05:59:25 +00:00
Hypolite Petovan 14e4c0db8e Check image property is set in Object\Image
- Property was either an object or null, strict comparison with "false" was inaccurate
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1374888800
2023-01-09 16:06:22 -05:00
Hypolite Petovan b77f3a7525 Check for URI ID existence in Post\Media::insert
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1374538325
2023-01-09 16:06:22 -05:00
Hypolite Petovan 4d5d8e5b64 Add line number to output in System::callstack 2023-01-09 16:06:22 -05:00
Hypolite Petovan 670b518875 Include other unique key column in condition in Model\Tag:store
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1372640002
2023-01-09 16:06:22 -05:00
Michael 4e0da578fa Merge remote-tracking branch 'upstream/develop' into improve-ignore 2023-01-09 17:23:10 +00:00
Hypolite Petovan 6bee344681 Add yet another case to DateTimeFormat::fix
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1372637862
2023-01-09 11:38:25 -05:00
Michael 840f25cc5c Improve ignoring of messages 2023-01-09 16:23:39 +00:00
Michael cd3dbad2a8 Fix some warnings on item creation 2023-01-09 15:55:35 +00:00
Michael Vogel c1f9c1aaa5
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-08 23:13:31 +01:00
Michael 480d9f53c3 Added "collapsed" list 2023-01-08 18:28:19 +00:00
Michael 50746bad55 Merge remote-tracking branch 'upstream/develop' into collapse 2023-01-08 17:47:21 +00:00
Michael 50e43c530e Posts from contacts can now be collapsed 2023-01-08 17:40:05 +00:00
Hypolite Petovan 0ae7a53daa
Merge pull request #12637 from annando/ostatus-subscription
OStatus: Fix PubSubHubBub subscription
2023-01-08 07:58:22 -05:00
Michael Vogel 1ef9768b98
Apply suggestions from code review
Co-authored-by: Philipp <admin+Github@philipp.info>
2023-01-08 13:00:58 +01:00
Michael c3d836db63 OStatus: Fix PubSubHubBub subscription 2023-01-08 09:41:54 +00:00
Tobias Diekershoff 6bf670f64e
Merge pull request #12633 from MrPetovan/bug/12624-api-thumbnail
Change "thumbnail" for default Friendica banner image in Api\Mastodon\Instance
2023-01-08 08:28:24 +01:00
Hypolite Petovan 97642e770b Treat unsupported API call as HTTP error 2023-01-07 22:47:52 -05:00
Hypolite Petovan 8ad94fef9b Change "thumbnail" for default Friendica banner image in Api\Mastodon\Instance 2023-01-07 22:39:07 -05:00
Philipp 979672a3c1
Filter disabled addons with "null" 2023-01-08 02:49:56 +01:00
Philipp 5ea50a9e81
Fix "null" addon list 2023-01-08 02:49:56 +01:00
Philipp 2293ff6206
Add test for Addon failures 2023-01-08 02:49:56 +01:00
Philipp 0429a4e429
Fix loading empty node.config.php 2023-01-08 02:49:56 +01:00
Michael aa3dc7c40c Add configuration 2023-01-07 21:28:21 +00:00
Michael 49c1ad2cc0 Merge remote-tracking branch 'upstream/develop' into diaspora-item 2023-01-07 21:21:51 +00:00
Hypolite Petovan 5fd3d4bda3
Merge pull request #12628 from nupplaphil/bug/typeerror
Don't ksort() or loop without an addon array
2023-01-07 15:06:28 -05:00
Michael 24c32cff0d Merge remote-tracking branch 'upstream/develop' into diaspora-item 2023-01-07 19:52:23 +00:00
Philipp 6aaf1ea5d4
Fix addons problem more elegant 2023-01-07 20:49:29 +01:00
Philipp 9fb5b95b5e
Fix other foreach() troubles at Addon.php 2023-01-07 19:54:59 +01:00
Michael Vogel d5bc6d0006
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-07 19:54:13 +01:00
Philipp 6454c1dee7
Don't ksort() on null 2023-01-07 19:52:43 +01:00
Michael f5fd99f7ea Unbneeded strlen removed 2023-01-07 18:51:28 +00:00
Michael 4e4eab7548 Merge remote-tracking branch 'upstream/develop' into mod-item 2023-01-07 17:14:40 +00:00
Michael d86045058e Diaspora: Photos are now transmitted separately 2023-01-07 15:11:34 +00:00
Philipp 6bd1740a94
omg .. wrong assertion .. 2023-01-07 15:49:55 +01:00
Philipp 6e4e2c4a82
Fix warning text 2023-01-07 15:30:45 +01:00
Philipp b7a2b6b352
Update src/Module/Admin/Summary.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-07 15:28:49 +01:00
Philipp 6e0d16f22b
Add warning message in case node.config.php isn't writable 2023-01-07 15:16:55 +01:00
Hypolite Petovan 308618b559
Merge pull request #12622 from nupplaphil/bug/config
`node.config.php` bugfixings
2023-01-07 08:45:53 -05:00
Philipp 80e8f4aa34
Execute critical worker tasks, even if we're in daemon mode 2023-01-07 13:43:16 +01:00
Philipp abd3b2180f
Merge pull request #12619 from MrPetovan/task/12617-remove-no_auto_update
Remove system.no_auto_update personal config key and assume default value of true
2023-01-06 17:54:36 +01:00
Philipp 5b2e02889e
Fix Update::run() 2023-01-06 17:50:56 +01:00
Philipp baf3225916
Apply Update::check() suggestions 2023-01-06 12:50:14 +01:00
Philipp c35fd68ec2
Adapt doc 2023-01-06 12:47:00 +01:00
Philipp beb3d376b2
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:46:06 +01:00
Philipp 05048d4abf
Update src/Core/Config/ValueObject/Cache.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:43:04 +01:00
Philipp 70704ccb19
Update src/Core/Update.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:42:56 +01:00
Philipp 9462bfa763
Update src/Core/Config/Util/ConfigFileManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:42:43 +01:00
Philipp b3772163d8
Add doc 2023-01-06 03:06:11 +01:00
Philipp ce8c820221
add description 2023-01-06 02:54:34 +01:00
Philipp d53cb31869
Update src/Core/Config/Util/ConfigFileManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 02:16:35 +01:00
Philipp e14050491a
Config fixing
- unlock/close the `node.config.php` in every circumstances
2023-01-06 01:10:57 +01:00
Philipp 5aa8e8adf1
Config fixings
- Delete now really overwrites static default/setting.config.php keys
- Delete now really overwrites static default/setting.config.php categories
- The Update::check() routine is added to different places
- Merge the given config file with the new config before writing
- Remove ConfigTransaction::get() because it's no more reliable
2023-01-06 01:03:00 +01:00
Philipp cdd57275eb
Some improvements
- Move $_SERVER into ConfigFileManager constructor
- Rename "creatConfigFileLoader" to "createConfigFileManager"
- Rename variable "loader" to "manager" in all tests
2023-01-06 01:03:00 +01:00
Philipp b4096251ba
Check 'config' table as fallback for migrations 2023-01-06 01:03:00 +01:00
Hypolite Petovan 6685157f8a Cast alert types to boolean in Api\Mastodon\Subscription 2023-01-05 11:54:01 -05:00
Hypolite Petovan 3b9bf4d70d Remove system.no_auto_update personal config key and assume default value of true
- By popular request, the behavior with false was too perturbating
2023-01-05 10:27:03 -05:00
Hypolite Petovan dfcfae6bcc Replace $_GET references with $request in Update classes 2023-01-05 10:23:25 -05:00
Michael Vogel 2f28ec7af0
Merge pull request #12615 from MrPetovan/task/12601-update-gserver-block
Drop UpdateGServer worker task if domain is blocked
2023-01-05 12:37:00 +01:00
Philipp 4b17d6f3bf
Update src/Core/Addon.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-04 23:12:41 +01:00
Michael 9a1a406c03 Preview of attached links work again 2023-01-04 21:52:02 +00:00
Philipp 01403d15c4
sort addon array 2023-01-04 21:55:51 +01:00
Philipp 13b234d279
Use addons config entries instead of the addon table 2023-01-04 21:55:51 +01:00
Philipp cd11088cc4
Move 'addon' table into config 2023-01-04 21:55:51 +01:00
Hypolite Petovan 647ab1d04a Drop UpdateContact worker task if contact is blocked 2023-01-04 14:41:09 -05:00
Hypolite Petovan 1f3c07c06f Drop UpdateGServer worker task if domain is blocked 2023-01-04 14:41:09 -05:00
Hypolite Petovan a907d6c87b Add UriInterface-enabled isUriBlocked method in Util\Network 2023-01-04 14:41:08 -05:00
Hypolite Petovan a574146f04 Add UriInterface-enabled cleanUri method in Model\GServer
- Tests!
2023-01-04 14:41:08 -05:00
Philipp dce86be58e
Just commit config transactions if something changed 2023-01-04 19:55:22 +01:00
Philipp aabe39220d
Make flock writing easier 2023-01-04 08:16:40 +01:00
Philipp c057954896
Make BaseURL check/save transactional and make the whole process easier 2023-01-04 08:14:00 +01:00
Michael d1a951f0ac Post processing centralized 2023-01-04 06:52:40 +00:00
Michael 0d56f156f7 Code cleanup for mod/item.php 2023-01-04 05:44:52 +00:00
Philipp 17105cf7d1
Fix config read/write locking 2023-01-04 00:25:18 +01:00
Philipp 4c2fc3ea38
Reduce config->set() load for worker executions 2023-01-04 00:25:15 +01:00
Philipp 176af67e88
Fix empty fetchResult curResult at Link::fetchMimeType (thx to Marco R.) 2023-01-03 21:06:16 +01:00
Philipp 3110831131
Fix empty fetchResult at ExternalStorage (thx to Marco R.) 2023-01-03 21:05:58 +01:00
Philipp beff759c82
Update src/Core/Config/Model/ConfigTransaction.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-03 17:39:32 +01:00
Philipp a46cd2fb36
Remove get() from config transaction interface 2023-01-03 17:26:48 +01:00
Philipp b439df892a
Apply suggestions 2023-01-03 17:24:05 +01:00
Philipp dd88d193b9
Escape single quotes and backslashes 2023-01-03 15:36:36 +01:00
Philipp 65d79d4c93
Introduce ISetConfigValuesTransactional for transactional config behaviour 2023-01-03 14:22:07 +01:00
Philipp 4d4b4a8858
Revert BaseURL 2023-01-03 14:22:07 +01:00
Philipp 376e0a9397
Fix Admin\Site 2023-01-03 14:22:07 +01:00
Philipp ae1533e312
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-03 14:22:06 +01:00
Philipp 88b3effc18
Use toConfigValue in case of serialized, legacy data 2023-01-03 14:22:05 +01:00
Philipp 10f3de0aa2
Remove deprecated Mode::DBCONFIGAVAILABLE 2023-01-03 14:22:04 +01:00
Philipp 1e574d5383
Refactor IManageConfigValues interface 2023-01-03 14:22:04 +01:00
Philipp d272e8c3c7
Remove unnecessary classes 2023-01-03 14:22:03 +01:00
Philipp b871e1d264
Introduce lightweight Config model 2023-01-03 14:22:02 +01:00
Philipp 0f91d1cbde
Introduce ConfigFileManager for config files 2023-01-03 14:22:02 +01:00
Philipp fea4b202c1
Introduce ConfigFileTransformer for Config files 2023-01-03 14:22:02 +01:00
Hypolite Petovan 9c256ad76f Remove obsolete OExchange module and reference
- Protocol looks unsupported for a decade now
2023-01-01 19:20:42 -05:00
Hypolite Petovan 8bbf9e93c6 Remove dependency to the second parameter of XML::fromArray 2023-01-01 19:20:42 -05:00
Hypolite Petovan 931ccde90d
Merge pull request #12597 from annando/activity-distribution
Don't distribute unsigned remote activities
2023-01-01 19:19:25 -05:00
Michael Vogel 6b914ccc0f
Merge pull request #12586 from MrPetovan/task/entitize-delivery-queue
Add Entity-Factory-Repository for deliver-queue
2023-01-02 00:56:13 +01:00
Hypolite Petovan a786bd3777 Remove unused static methods related to delivery-queue 2023-01-01 18:50:21 -05:00
Hypolite Petovan a744b8b56f Replace direct database calls and anonymous arrays by repository calls and entity objects 2023-01-01 18:50:21 -05:00
Hypolite Petovan 49654c0d99 Create entity-related classes for delivery-queue table 2023-01-01 18:50:19 -05:00
Hypolite Petovan f9676c9ed2 Convert Directory Search results into contact-looking records
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1368216631
2023-01-01 18:47:45 -05:00
Hypolite Petovan 6e06a7f14c Remove dependency to DI in Search\Acl module 2023-01-01 18:47:44 -05:00
Michael 78c3c56ca5 Don't distribute unsigned remote activities 2023-01-01 23:37:17 +00:00
Philipp 4faf08c064
Merge pull request #12562 from MrPetovan/bug/notices
Ward againt contact_id = 0 in UpdateContact worker
2023-01-02 00:34:21 +01:00
Michael 24065d307b Fix communication to Diaspora when not in bulk mode 2023-01-01 19:52:08 +00:00
Michael f1bcf1ef66 Set the server status directly after transmission 2023-01-01 17:34:05 +00:00
Michael 12fac6e089 Close the database 2023-01-01 15:37:47 +00:00
Michael 360614d2cf Merge remote-tracking branch 'upstream/develop' into inbox-gsid 2023-01-01 15:25:28 +00:00
Michael df5305f384 Increase another forgotten year 2023-01-01 15:15:16 +00:00
Michael fe897c7ef4 Increase the year 2023-01-01 15:14:45 +00:00
Michael 7307646cf8 Use server id on direct delivery 2023-01-01 15:13:44 +00:00
Hypolite Petovan 1874a32728 Happy New Year 2023! 2023-01-01 09:36:24 -05:00
Michael 6bc9754b24 Add the server id for all Diaspora contacts 2023-01-01 10:52:22 +00:00
Michael 06403f1546 License updated 2023-01-01 07:52:28 +00:00
Michael 12d37835b4 Set "archive" status 2023-01-01 00:18:01 +00:00
Michael e21db0fe6d The inbox-status can now be archived for a whole server 2022-12-31 23:42:00 +00:00
Michael e0a5e32f8e Avoid undefined variable "$rendered" 2022-12-31 16:47:33 +00:00
Hypolite Petovan 319857edaa
Merge pull request #12583 from annando/delivery-queue
Bulk delivery added for all protocols
2022-12-31 11:36:54 -05:00
Michael 8e397b5849 Changes after review 2022-12-31 16:20:18 +00:00
Michael f022a49f9e New "Defunct" check 2022-12-31 16:01:40 +00:00
Michael dc528a020b Remove blank 2022-12-31 12:47:48 +00:00
Michael 259b99e6e9 Bulk delivery added for all protocols 2022-12-31 12:19:34 +00:00
Philipp 2844ea779d
Merge pull request #12579 from MrPetovan/bug/fatal-errors
Add previous exception to unexpected worker exception logging
2022-12-31 10:08:30 +01:00
Hypolite Petovan b0898ada29 Add previous exception to unexpected worker exception logging 2022-12-30 22:25:19 -05:00
Hypolite Petovan b6f3f298fe Add new case to DateTimeFormat::fix
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1368011436
2022-12-30 21:40:37 -05:00
Hypolite Petovan 19b5362f93 Return early when inbox-status row couldn't be inserted in HTTPSignature->setInboxStatus
- Address https://github.com/friendica/friendica/issues/12488?notification_referrer_id=NT_kwDOAA4e57E1MTM1MzE3MjU2OjkyNTQxNQ#issuecomment-1366991471
2022-12-30 17:23:23 -05:00
Hypolite Petovan 6e31b8d6a5 Avoid return type exeption in HTTPSignature->post
- Prefer passing the owner record array instead of just the uid
- +4/-7 calls to User::getOwnerDataById
2022-12-30 17:23:22 -05:00
Michael ce6845f44f Code standards 2022-12-30 21:44:12 +00:00
Michael 4eceb2d26f Merge remote-tracking branch 'upstream/develop' into move-delivery 2022-12-30 21:40:09 +00:00
Michael e4c5d9f62d Fix code standards 2022-12-30 21:37:09 +00:00
Hypolite Petovan bacf901d0e
Merge pull request #12574 from nupplaphil/feat/keyvalue_storage
Introduce key-value storage
2022-12-30 16:36:03 -05:00
Michael 9115ec5f0d Adjust class references to the new location 2022-12-30 21:20:28 +00:00
Michael 6d087ee455 Move delivery functionality to a new class 2022-12-30 21:19:55 +00:00
Hypolite Petovan e563de4de7 Ward againt contact_id = 0 in UpdateContact worker
- Add parameter validation in Worker\UpdateContact::add
- Address https://github.com/friendica/friendica/issues/12487#issuecomment-1366833644
2022-12-30 02:10:29 -05:00
Hypolite Petovan 12df6297d7 Remove attachment tags before checking for end of body images 2022-12-30 02:10:11 -05:00
Philipp f96aec18cc
Fixup maintenance mode 2022-12-29 23:38:14 +01:00
Philipp a330a3c22d
Make PHP-CS happy again 2022-12-29 22:38:01 +01:00
Philipp 86f80af432
Rename Interface 2022-12-29 22:37:12 +01:00
Philipp 8894b482dc
Find last "update_" config entry occurrence 2022-12-29 22:36:45 +01:00
Philipp 7c4c409060
Change key-value table
- Make "k" as primary key
- Added "updated_at"
2022-12-29 22:36:08 +01:00
Philipp f944a2a620
rollback unwanted change 2022-12-29 22:13:39 +01:00
Philipp 925c30280c
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-12-29 22:12:02 +01:00
Philipp 965caf98a5
Replace database "update_" config entries with key-value entries 2022-12-29 21:53:58 +01:00
Philipp 1ed67fba3d
Replace addon "last" config entries with key-value entries 2022-12-29 21:53:57 +01:00
Philipp b227d65dfc
Replace worker_daemon_mode config entry with key-value entry 2022-12-29 21:53:57 +01:00
Philipp 6b3265742a
Replace cron/worker "last" config entries with key-value entries 2022-12-29 21:53:57 +01:00
Philipp 10f8631cd9
Replace PostUpdate key-value config entries with key-value pair entries 2022-12-29 21:53:56 +01:00
Philipp 47764387b3
Introduce Key-Value Pair storage provider 2022-12-29 21:53:56 +01:00
Hypolite Petovan 44818ba556
Merge pull request #12572 from mexon/mat/network-failure-error
Return network match failure in error message instead of logging
2022-12-29 15:11:36 -05:00
Hypolite Petovan 03e03c126d
Merge pull request #12573 from mexon/mat/local-host
Allow HTTP requests to hosts in local hosts file
2022-12-29 14:40:10 -05:00
Matthew Exon 9c33074bdc Allow HTTP requests to hosts in local hosts file 2022-12-29 19:44:49 +01:00
Matthew Exon 119be35a79 Return network match failure in error message instead of logging 2022-12-29 19:42:22 +01:00
Matthew Exon 1dbbafa1af Allow adding local contacts via console 2022-12-29 19:39:27 +01:00
Hypolite Petovan 8b1947bd78 Add Core\Logger to the introspection skip class list
- Make class list explicit to avoid confusion between similar class names
- Update skipped class string match to a safer "starts with" condition
2022-12-28 17:54:37 -05:00
Hypolite Petovan 9dbcbe0482 Remove extraneous Introspection->isTraceClassOrSkippedFunction second parameter 2022-12-28 17:51:07 -05:00
Hypolite Petovan 59b5d080d5
Merge pull request #12558 from MarekBenjamin/fix-disorted-portraits
Fixed width and height not updated when image rotation is done by EXIF based orient method
2022-12-28 17:30:47 -05:00
MarekBenjamin 2d1d06c6d2
Update src/Object/Image.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-12-28 23:19:53 +01:00
MarekBenjamin ed05d6376d
Update src/Object/Image.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-12-28 23:19:48 +01:00
Hank Grabowski 4f0968a93c Make tag 'Names' Field have case-sensitive version 2022-12-28 17:01:06 -05:00
Marek Bachmann 19b8b389fd Fixed width and height not updated when image rotation is done by EXIF based orient method 2022-12-28 21:43:34 +01:00
Hypolite Petovan 689b6b015b
Merge pull request #12557 from annando/reduce-update-contacts
Reduce the amount of "UpdateContact" worker calls
2022-12-28 13:12:30 -05:00
Hypolite Petovan 21056ae587
Merge pull request #12548 from MarekBenjamin/doubled_code_for_scaling-dimensions
Replace duplicated code by Images::getScalingDimensions call in Object\Image->scaleDown
2022-12-28 11:48:21 -05:00
Michael 088a3b6bc4 Merge remote-tracking branch 'upstream/develop' into reduce-update-contacts 2022-12-28 16:06:08 +00:00
Michael 954b95b039 Updated logging 2022-12-28 16:04:31 +00:00
Marek Bachmann eb87a2afbe Merge remote-tracking branch 'origin/doubled_code_for_scaling-dimensions' into doubled_code_for_scaling-dimensions
# Conflicts:
#	src/Object/Image.php
2022-12-28 16:43:47 +01:00
Marek Bachmann 7b34fdc715 removed one redundant check for height and width beeing set 2022-12-28 16:42:38 +01:00
MarekBenjamin 2c509ac2b2
Update src/Object/Image.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-12-28 16:32:33 +01:00
Michael 54d308fb8a Fix indention 2022-12-28 15:16:07 +00:00
Michael e0e2e45b91 Reduce the amount of "UpdateContact" worker calls 2022-12-28 14:56:12 +00:00
Tobias Diekershoff 5c3cb63952
Merge pull request #12549 from MrPetovan/task/12490-fakelink-button
Turn fake link spans into full-fledged buttons
2022-12-28 07:39:56 +01:00
Hypolite Petovan a1dc6e2417 Switch rounding to flooring in Temporal::getRelativeDate
- Add tests for regression
2022-12-28 00:32:26 -05:00
Hypolite Petovan 53c0fffbec Add ClockInterface dependency to Temporal::getRelativeDate
- Remove unused $format parameter
2022-12-28 00:31:20 -05:00
Hypolite Petovan a1070f4818 Turn fake link spans into full-fledged buttons 2022-12-27 21:47:35 -05:00
Marek Bachmann 88a7dd1afb Replaced the doubled code in for getScalingDimension with Images::getScalingDimensions($width, $height,$max) 2022-12-28 03:30:56 +01:00
Philipp 7b42657d1e
Fix redirects 2022-12-27 20:08:33 +01:00
Hypolite Petovan 89705afa9d
Merge pull request #12540 from annando/forum-thread
Improved handling of forum mentions
2022-12-27 12:13:36 -05:00
Michael b7e461d2f3 Improved handling of forum mentions 2022-12-27 17:01:40 +00:00
Philipp e0fa557f18
Merge pull request #12539 from annando/forum-thread
Distribute forum comments only via the forum
2022-12-27 17:51:22 +01:00
Michael ca0e3e3db7 Distribute forum comments only via the forum 2022-12-27 16:14:04 +00:00
Hypolite Petovan 5c332af844
Merge pull request #12527 from nupplaphil/feat/request_id
Introduce Request::getRequestId()
2022-12-26 16:07:35 -05:00
Philipp 4f1bb0d274
Use X-REQUEST-ID for Error pages 2022-12-26 21:18:05 +01:00
Philipp 5584e7a4e5
Use X-REQUEST-ID for Logging 2022-12-26 21:18:04 +01:00
Philipp 10864e50c7
Adapt Logger\Introspection
- Create an interface
- Add it as constructor parameter
2022-12-26 21:18:04 +01:00
Philipp bfc1c157f1
Adapt UserSession
- Move from App methods to UserSession methods
- Deprecate corresponding App methods
2022-12-26 21:18:04 +01:00
Michael 7c4b320f30 Cleanup work with the activity types 2022-12-26 15:08:46 +00:00
Hypolite Petovan 74229fe230 Ward against empty $target_item array (relocation) in Worker\Delivery->deliverDFRN
- Address third part of https://github.com/friendica/friendica/issues/12488#issuecomment-1364487793
2022-12-26 09:22:44 -05:00
Hypolite Petovan 482eeb7109 Fix wrong square bracket position in Worker\Delivery->deliverDFRN
- Address second part of https://github.com/friendica/friendica/issues/12488#issuecomment-1364487793
2022-12-26 09:11:37 -05:00
Hypolite Petovan e8420dcb71 Query expected photo.type field in Protocol\DFRN::relocate
- Address first part of https://github.com/friendica/friendica/issues/12488#issuecomment-1364487793
2022-12-26 09:10:55 -05:00
Michael e718d39ef0 Fixes "E_WARNING: Undefined variable $subject" 2022-12-26 12:14:45 +00:00
Michael e05cbf46e1 Activity "Read" is now stored 2022-12-26 08:41:40 +00:00
Michael 46fdf696ee Issue 12524: Fix first day of week 2022-12-25 22:45:34 +00:00
Michael 5298cd73b3 We now store the violation as well 2022-12-25 10:44:06 +00:00
Michael cef4349421 Changed parameter order 2022-12-25 07:30:39 +00:00
Michael dc73cbe30c Simplified code 2022-12-24 23:33:21 +00:00
Michael 8a7d08ae28 Category added 2022-12-24 13:57:43 +00:00
Michael bf4d321aa3 Wrong variable 2022-12-24 08:09:23 +00:00
Michael 4c945850f4 Reports: The reporting contact id is added 2022-12-24 08:03:37 +00:00
Michael 8cb85368ff Added comment 2022-12-23 22:48:57 +00:00
Michael 72e1d5d417 Fix storing reports 2022-12-23 22:43:32 +00:00
Michael ca12d1549b AP: We can now store received reports 2022-12-23 22:11:50 +00:00
Philipp 8fd0d4cdc0
Merge pull request #12513 from MrPetovan/bug/12507-rel-meeee
Add call to HTML::checkRelMeLink in Worker\CheckRelMeProfileLink
2022-12-23 21:12:06 +01:00
Hypolite Petovan e4ac3c7922
Merge pull request #12510 from MarekBenjamin/email-notification_like-in-subject
Change email subject to "(...)like in conversation(...)" for likes in…
2022-12-23 07:57:28 -05:00
MarekBenjamin 3061cee083
Update src/Navigation/Notifications/Repository/Notify.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-12-23 11:14:38 +01:00
Hypolite Petovan b2f2fbc4d4 Flatten conditions and add call to HTML::checkRelMeLink in Worker\CheckRelMeProfileLink 2022-12-23 02:44:49 -05:00
Hypolite Petovan 91c4ab2359 Add new xpathQuote and checkRelMeLink methods to Content\Text\HTML class
- Add tests for both methods
2022-12-23 02:41:22 -05:00
Michael 998b05095b A server is only reachable when the network can be detected 2022-12-23 06:48:53 +00:00
Michael 1e888ad6a4 Always check whe verified 2022-12-23 06:26:58 +00:00
Michael 179d776d0a Only check the homepage for active users with a homepage 2022-12-23 06:22:12 +00:00
Marek Bachmann 8393975cbc Merge remote-tracking branch 'origin/email-notification_like-in-subject' into email-notification_like-in-subject 2022-12-23 02:38:15 +01:00
Marek Bachmann b876a9efcd Distinguish between comment likes and post likes. 2022-12-23 02:38:00 +01:00
MarekBenjamin d52c988ebc
Update src/Navigation/Notifications/Repository/Notify.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-12-23 01:22:21 +01:00
Marek Bachmann ef4f508f9b messages.po and and corrected typo in comment 2022-12-23 01:06:21 +01:00
Marek Bachmann 82eec270fa Change email subject to "(...)like in conversation(...)" for likes instead of "(...)new comment(...)" 2022-12-23 00:56:26 +01:00
Michael 99284222c1 Remove the activity 2022-12-22 22:08:42 +00:00
Michael 9fe70af85a AP: Support for "move" and "accept" from gup.pe 2022-12-22 21:58:51 +00:00
Michael d75cd8a00a The GNU-Social import is removed 2022-12-21 22:21:22 +00:00
Hypolite Petovan 31e8574006
Merge pull request #12494 from annando/blurhash-fix
Don't calculate the blurhash on images without a size
2022-12-20 20:19:32 -05:00
Michael e6f0e3c23e Don't calculate the blurhash on images without a size 2022-12-20 22:32:24 +00:00
Michael 69a9f9033d Three systems added to the federation statistics 2022-12-20 22:29:53 +00:00
Michael de1c0f4c13 Don't display Diaspora reshares 2022-12-20 19:25:57 +00:00
Michael 4db4d1843d Merge remote-tracking branch 'upstream/develop' into diaspora-reshare 2022-12-20 06:58:36 +00:00
Philipp 8b3a9fc58a
Merge pull request #12485 from annando/errors-warnings
Measures against several warnings and errors in the log
2022-12-20 07:48:59 +01:00
Michael bdc865afae Measures against several warnings and errors in the log 2022-12-20 06:22:11 +00:00
Tobias Diekershoff c84f18ef66 bump VERSION to 2023.03-dev 2022-12-20 06:52:15 +01:00
Tobias Diekershoff eeadc00e83 bump VERSION to 2022.12 2022-12-20 06:48:39 +01:00
Michael e733adcaae Issue 12419: Quickhack to make GoToSocial work 2022-12-19 21:21:06 +00:00
Michael d39f4014e4 Fix delivery problems with "reachable" test 2022-12-19 19:41:04 +00:00
Philipp 20374ab5a2
Merge pull request #12447 from MrPetovan/bug/12441-profile-contacts
Retrieve contact records for the page visitor in several modules
2022-12-19 17:14:43 +01:00
Philipp c9f92f41fb
Merge pull request #12479 from MrPetovan/bug/deprecated
Fix several Deprecated notices
2022-12-19 17:13:12 +01:00
Hypolite Petovan f2188835e7 Add logging and default value when JSON encode->decode fails in JsonLD::compact
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1357768936
2022-12-19 10:22:05 -05:00
Hypolite Petovan 06ea61f0ed Provide default value for system.banner config key
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1357768936
2022-12-19 10:17:57 -05:00
Hypolite Petovan 6a17223289 Ward against null value in language key of item array in Mastodon\Status object
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1357768936
2022-12-19 10:11:12 -05:00
Hypolite Petovan b1b0bfc280 Don't compute system.update_interval when it's -1 (disabled)
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1357768936
2022-12-19 10:05:21 -05:00
Hypolite Petovan eb9af005f0 Fix module instantiation in Profile\Index module
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1357441775
2022-12-19 09:50:42 -05:00
Hypolite Petovan 29330a4205 Remove DI dependency in Profile\Status module 2022-12-19 09:50:42 -05:00
Hypolite Petovan 9da21bf680 Remove fallback contact query from Model\Contact::photoMenu
- Correct contact is now supplied to the method
2022-12-19 09:50:18 -05:00
Hypolite Petovan 2d9633a595 Retrieve contact records for the page visitor in Profile\Common module 2022-12-19 09:50:18 -05:00
Hypolite Petovan 472bde99a4 Retrieve contact records for the page visitor in Contact\Contacts module 2022-12-19 09:50:17 -05:00
Hypolite Petovan fca1abbafe Retrieve contact records for the page visitor in Profile\Contacts module 2022-12-19 09:50:17 -05:00
Hypolite Petovan 36a8962333 Remove DI dependency in Contact\Hovercard module 2022-12-19 09:50:17 -05:00
Hypolite Petovan 7458721f9f Remove DI dependency in Profile\Common module 2022-12-19 09:50:16 -05:00
Hypolite Petovan a633532475 Remove DI dependency in Contact\Contacts module 2022-12-19 09:50:16 -05:00
Hypolite Petovan cef408c842 Remove DI dependency in Module\Profile\Contacts 2022-12-19 09:50:16 -05:00
Michael Vogel 8f22b4f33d
Update src/Model/GServer.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-12-19 15:22:21 +01:00
Michael feb74b4d9a Don't perform a delivery to failing servers 2022-12-19 09:30:56 +00:00
Tobias Diekershoff 86a486f62b
Merge pull request #12472 from MrPetovan/bug/12466-profile-photos-aside
Remove VCard for owner in Profile\Photos module
2022-12-19 07:38:13 +01:00
Tobias Diekershoff 9d38671ec9
Merge pull request #12471 from MrPetovan/bug/12468-bbcode-img-code
Skip literal text in ActivityPub\Transmitter::removePictures
2022-12-19 07:03:31 +01:00
Tobias Diekershoff b4db8fe8d2
Merge pull request #12469 from MrPetovan/bug/12462-tos-rules
Skip blank lines in Tos module
2022-12-19 06:58:42 +01:00
Hypolite Petovan 5392bafbb4 Remove VCard for owner in Profile\Photos module
- Remove unused remote contact retrieval
- Remove contact list from aside for non-owner visitors
2022-12-18 23:52:33 -05:00
Hypolite Petovan 2372e50e3b Skip literal text in ActivityPub\Transmitter::removePictures 2022-12-18 23:32:52 -05:00
Hypolite Petovan 39607b20e2 Convert custom profile field URL values to rel="me" links 2022-12-18 23:24:59 -05:00
Hypolite Petovan 76e9c4daa2 Fix link to profile page in custom profile fields settings
- Previous link was leading to conversations
2022-12-18 22:49:49 -05:00
Hypolite Petovan 07f7585e40 Remove DI dependency in Profile\Profile module 2022-12-18 22:49:18 -05:00
Hypolite Petovan 1cc0c1148e Skip blank lines in Tos module 2022-12-18 22:16:41 -05:00
Michael e057b39f68 Issue 12185: Problems adding contacts 2022-12-18 15:43:35 +00:00
Philipp 40777d08c1
Merge pull request #12459 from MrPetovan/bug/12454-link-preview-translation
Add missing t() call in Settings\Display module
2022-12-18 09:26:04 +01:00
Michael 1899c53516 API: Fix interoperability between Friendica and Mastodon part 2022-12-18 06:30:32 +00:00
Hypolite Petovan 52e3126cba Add missing t() call in Settings\Display module 2022-12-18 01:04:04 -05:00
Hypolite Petovan 9718484f9e Remove DI dependency in Settings\Display module 2022-12-18 01:04:04 -05:00
Hypolite Petovan c7e53cb9b4 Use account-user-view entry to instantiate Api\Mastodon\FollowRequest objects
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1354395861
2022-12-18 01:03:37 -05:00
Hypolite Petovan 43aa9cddc5 Trim terms of service rules before turning them to an array 2022-12-17 21:13:52 -05:00
Michael ed520a3f39 Fix image grid in shared Friendica posts 2022-12-17 22:07:14 +00:00
Hypolite Petovan cdf180c58d Add new calendar.default_view pconfig key 2022-12-17 12:20:43 -05:00
Hypolite Petovan 83e34ef8e7 Move first_day_of_week pconfig key to calendar category 2022-12-17 12:20:14 -05:00
Michael 8397ccf37c Merge remote-tracking branch 'upstream/2022.12-rc' into diaspora-reshare 2022-12-17 12:27:35 +00:00
Hypolite Petovan c69705d34e
Merge pull request #12446 from annando/preview-image
Fix: Images must not be removed on preview
2022-12-17 01:25:13 -05:00
Michael 2e6ab0e312 Fix: Images must not be removed on preview 2022-12-17 05:48:09 +00:00
Philipp 44b2b97e80
Merge pull request #12445 from MrPetovan/bug/12382-tag-attachment
Exclude [attachment] from tag search
2022-12-17 02:23:18 +01:00
Hypolite Petovan d609d70bd2 Exclude [attachment] from tag search 2022-12-16 20:06:37 -05:00
Hypolite Petovan c60464a4be Catch exceptions in Model\Gserver::cleanURL
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1354393419
2022-12-16 17:39:40 -05:00
Philipp b0cc0f0d7b
Add load(true) for ViewDefinitions as well 2022-12-16 22:05:32 +01:00
Philipp 1c789d487b
Include DBA definitions from Hooks again 2022-12-16 21:59:32 +01:00
Philipp 2ae3ae0b8a
Merge pull request #12436 from MrPetovan/bug/notices
Address a few notices
2022-12-16 08:52:04 +01:00
Hypolite Petovan 2497817c2a Ward against empty siteinfo in Text\BBCode::embedURL
- Address https://github.com/friendica/friendica/issues/11994#issuecomment-1349593196
2022-12-15 23:33:02 -05:00
Hypolite Petovan 060936d31e Ward against empty $contact array in Module\Photo::getPhotoById
- Address https://github.com/friendica/friendica/issues/11994#issuecomment-1349591039
2022-12-15 23:31:32 -05:00
Hypolite Petovan 0c5158b85d Check that $probed key exists before comparison in OStatus\Subscribe
- Address https://github.com/friendica/friendica/issues/11994#issuecomment-1349590054
2022-12-15 23:29:06 -05:00
Hypolite Petovan 777afb45fc Apply calendar owner custom theme 2022-12-15 23:14:45 -05:00
Hypolite Petovan 590f92ba42
Merge pull request #12434 from MarekBenjamin/issue_make_balancing_optional
Removed balancing of image grid
2022-12-15 15:49:20 -05:00
Marek Bachmann 91cc6d5a94 Add unbalanced imagegrid generation 2022-12-15 21:29:14 +01:00
Tobias Diekershoff f8b70ef9f0
Merge pull request #12424 from MrPetovan/task/10100-contact-relationship-prominence
Make relationship filter widget more prominent in Module\Contact
2022-12-15 06:24:32 +01:00