Commit Graph

5595 Commits

Author SHA1 Message Date
Michael e09965fcc5 Simplified code 2020-05-18 22:34:47 +00:00
Michael Vogel e315bc3eae
Merge pull request #8657 from MrPetovan/bug/8653-catch-template-engine-errors
Catch template engine errors
2020-05-19 00:22:45 +02:00
Hypolite Petovan 8b05af176c Add detailed error messages for admin user in Core\Renderer and Render\FriendicaSmartyEngine 2020-05-18 18:10:21 -04:00
Michael 2a56370cf4 Merge remote-tracking branch 'upstream/develop' into annando/issue8514 2020-05-18 21:38:17 +00:00
Michael 2f8c6f00b5 Improved item insert functionality 2020-05-18 21:34:57 +00:00
Hypolite Petovan 64e89a516d Restore default parameter value in Core\Renderer::replaceMacros 2020-05-18 10:01:51 -04:00
Hypolite Petovan ef9b51e631 Replace direct error output and exit by logger + exception in Core\Renderer
- Same in Render\FriendicaSmartyEngine
2020-05-18 01:21:58 -04:00
Hypolite Petovan 346f99b877 Add new TemplateEngine->testInstall method
- Add admin summary template engine error messages
2020-05-18 01:20:47 -04:00
Hypolite Petovan c6ba92c43d Refactor template engine code
- Convert ITemplateEngine interface to abstract class
- Remove dependency to App in FriendicaSmarty and FriendicaSmartyEngine
- Normalize replaceMacro parameter behavior using Smarty template string prefixes
- Remove obsolete FriendicaSmarty->parsed method
- Update unused Smarty directory paths
2020-05-18 01:18:41 -04:00
Hypolite Petovan 75a0b80888 Add new Strings::startsWith method
- Move previous method to Strings::startsWithChars and update every known call
2020-05-18 01:05:38 -04:00
Michael efb1c630fd Fix warnings ("Divide by zero" and "key parameter is not a valid public key") 2020-05-18 02:58:08 +00:00
Michael e737eea17d Issue 8458-2: Now all unicode emojis should work 2020-05-17 21:46:54 +00:00
Michael d7f0ffdbc1 Issue 8458: Display big emojis
Fixes #8458
2020-05-17 16:55:54 +00:00
Hypolite Petovan db63d1d501
Merge pull request #8652 from annando/annando/issue8582
Issue 8582: "cid" in "network" is now "contactid"
2020-05-17 11:41:53 -04:00
Hypolite Petovan 8a96fe6d7f
Merge pull request #8648 from annando/annando/issue8565
Issue 8565: Sanitize  input data
2020-05-17 11:40:18 -04:00
Michael 3b1d89252a Issue 8582: "cid" in "network" is now "contactid"
Fixes #8582
2020-05-17 15:01:27 +00:00
Michael bc26c980f0 Reverts test changes 2020-05-17 13:59:05 +00:00
Michael a3c4021f12 Issue 8514: Make paging for searcg items work again
Fixes #8514
2020-05-17 13:51:56 +00:00
Hypolite Petovan 90b1355555
Merge pull request #8649 from annando/annando/issue8550
Issue 8550: New experimental database configurations
2020-05-17 09:11:30 -04:00
Michael 7ace1049bb Issue 8572: Ensure to log database errors 2020-05-17 10:56:19 +00:00
Michael 4d4678ceb6 New experimental database configurations 2020-05-17 09:03:56 +00:00
Michael d771c50d63 Issue 8565: Sanitize input data
Fixes #8565
2020-05-17 06:13:58 +00:00
Michael ecde6b0066 Issue 8635: Create foreign keys without constraint name 2020-05-16 20:57:04 +00:00
Michael b625797591 issue 8642: Make hashtags more compatible 2020-05-16 18:38:50 +00:00
Hypolite Petovan 013d75c2ec
Merge pull request #8644 from annando/bbcode-constants
Use constants for the BBCode modes
2020-05-16 13:15:24 -04:00
Michael b192810288 Still more missing places replaced 2020-05-16 16:41:37 +00:00
Michael 76d845a138 Found another occurence replaced with constants 2020-05-16 16:39:44 +00:00
Michael 0da0580a82 use "self" 2020-05-16 16:32:37 +00:00
Michael 0cf517ad76 Use constants for the BBCode modes 2020-05-16 16:28:15 +00:00
Michael b8cf415f0d Issue 8635 - Handle weird default values
This handles an issue that occured in #8635 (But will not fix the issue behind this)
2020-05-16 14:23:17 +00:00
Michael 28e7564d79 Added some more sql commands to the list 2020-05-16 10:21:16 +00:00
Michael 8e12edc375 Improved code 2020-05-16 10:04:09 +00:00
Michael 4faef126ff Improved structure 2020-05-16 09:01:54 +00:00
Michael 4e1b1c0811 Issue 8635: Avoid concurrent database updates
Possibly helps with #8635
2020-05-16 08:15:51 +00:00
Michael 28e52f4db1 Fixed table name 2020-05-16 06:14:25 +00:00
Michael 14f814e6ba Issue 8636: Check and fix data before foreign key creation 2020-05-16 06:12:28 +00:00
Michael ec3290da3b We already have got a function to check if a table exists 2020-05-15 18:32:53 +00:00
Michael d70b77288d Call the initial value check in the test 2020-05-15 18:08:06 +00:00
Michael e333f45d0f Ensure that the initial values are set 2020-05-15 17:49:07 +00:00
Michael 89b47afb09 Testmode added 2020-05-15 15:41:50 +00:00
Michael d71c3e0812 Activate test mode for database 2020-05-15 15:05:17 +00:00
Michael 7a82171bfe The "term" table is removed 2020-05-15 06:50:20 +00:00
Hypolite Petovan f58d42e317
Merge pull request #8632 from annando/fix-fatal
Fix a fatal error when an undo doesn't contain an object
2020-05-14 09:06:42 -04:00
Michael 079738a8b5 Fix a fatal error when an undo doesn't contain an object 2020-05-14 04:53:56 +00:00
Michael Vogel cc8491223e
Merge pull request #8631 from MrPetovan/task/remove-item-tag-field
Remove references to obsolete virtual tag item.tag
2020-05-14 06:29:46 +02:00
Michael 3dc231ffd6 Code standards 2020-05-14 03:48:26 +00:00
Hypolite Petovan c2a76db290 Add type filter parameter to Tag::getCSVByURIId 2020-05-13 22:35:39 -04:00
Hypolite Petovan 75977ee72b Remove remaining references to cirtual field item.tag 2020-05-13 22:35:13 -04:00
Michael 04005f2878 Added documentation 2020-05-13 19:26:59 +00:00
Michael 7ea40ea796 Rearranged calls 2020-05-13 18:45:31 +00:00
Michael 13bd43f3f6 Store the diaspora signature differently 2020-05-13 05:48:26 +00:00
Michael c4062ddb3b Removed "insert" parameter 2020-05-12 21:49:12 +00:00
Michael 06da3084f5 Restructured item insert 2020-05-12 20:13:48 +00:00
Michael cd82c527f5 Removed useless error handling 2020-05-12 09:05:37 +00:00
Michael faaf3d89e3 The next boolean 2020-05-11 19:07:18 +00:00
Michael c5be1092d0 Use "quoteIdentifier" 2020-05-11 18:59:36 +00:00
Michael 57b4c70f9e Merge remote-tracking branch 'upstream/develop' into dbstructure 2020-05-11 18:54:19 +00:00
Michael ae2288bc7d Fix "Uncaught TypeError: Argument 1 passed to :incrementQueueDone()" 2020-05-11 18:28:41 +00:00
Michael a7f777ee43 DBStructure is now using "q(" nevermore 2020-05-10 20:23:58 +00:00
Michael 7f55e1b2bc We now support real foreign keys 2020-05-10 14:55:03 +00:00
Hypolite Petovan d35dc64660
Merge pull request #8611 from annando/issue-8610
Issue 8610: Implicit mentions work again
2020-05-09 16:03:45 -04:00
Hypolite Petovan 1e53f28b18
Merge pull request #8615 from annando/verb
We now store verbs in a new side table
2020-05-09 16:03:15 -04:00
Michael 258e9df064 Moved the check for a comment to a different place 2020-05-09 15:50:49 +00:00
Michael 19b5b83ac6 Forgotten "close" 2020-05-09 15:43:41 +00:00
Michael 5fe6a2dfcd We now store verbs in a new side table 2020-05-09 15:38:40 +00:00
Hypolite Petovan 184fa9f980 Skip user removal if it's already been removed in Console\User 2020-05-09 11:05:20 -04:00
Michael 9679fad5e2 Concentrating functionality 2020-05-09 08:55:10 +00:00
Michael a1fda8f74a Dant try to add mentions on starting posts 2020-05-09 08:39:21 +00:00
Michael eb4c14695c The implicit mentions are added in any case 2020-05-09 08:35:58 +00:00
Michael 556cc3fb13 Always mention the parent author 2020-05-09 08:08:33 +00:00
Michael bebc6615fc Removed unneeded functionality 2020-05-09 06:51:13 +00:00
Michael d5f64e1156 Issue 8610: Implicit mentions work again 2020-05-09 06:33:59 +00:00
Hypolite Petovan 55acb51148 Check $item_profile is populated in ActivityPub\Transmitter
- Address https://github.com/friendica/friendica/issues/8475#issuecomment-625716446
2020-05-08 09:31:36 -04:00
root 68b63ec647 avoid notice in probe.php 2020-05-08 13:06:40 +00:00
Michael 856cf7f664 Don't count and fetch "follow" activities 2020-05-07 18:39:39 +00:00
Hypolite Petovan 8abaac6d79 Account for missing location value in ActivityPub\Receiver 2020-05-07 10:14:38 -04:00
Michael Vogel 64f1bc8a68
Merge pull request #8589 from MrPetovan/task/8588-ap-contacts-endpoint
Only output ActivityPub contacts in /followers and /following AP endpoints
2020-05-07 10:37:46 +02:00
Hypolite Petovan 63e7996891 Improve formatting in ActivityPub\Transmitter 2020-05-07 03:47:45 -04:00
Hypolite Petovan eb8dcd43f3
Merge pull request #8597 from annando/notice
Fixed notice because of missing field
2020-05-07 03:46:38 -04:00
Michael e3c08215f6 Fixed notice because of missing field 2020-05-07 07:34:00 +00:00
Hypolite Petovan 3c0547c6e8 Ensure post location received through ActivityPub is in plaintext 2020-05-06 22:41:59 -04:00
Michael 065fad31f1 ignore "follow" activities that are not from the user 2020-05-06 21:19:48 +00:00
Michael be9519708e Don't relay participation messages 2020-05-06 20:43:00 +00:00
Hypolite Petovan 4e579e77f5 Only output ActivityPub contacts in /followers and /following
- Join contact table with apcontact to weed out non-AP contacts
2020-05-06 15:29:35 -04:00
Michael 806f4a0142 Added logging 2020-05-06 19:00:56 +00:00
Michael 7dea1ff6bd Issue 8586 again: Don't transmit participations 2020-05-06 17:30:21 +00:00
Michael b9ee46824f Added missing field 2020-05-06 15:37:04 +00:00
Michael 62a4638ea8 Don#t group 2020-05-06 15:27:13 +00:00
Michael 22be2cce8a Issue 8586: Reduce the amount of item receivers 2020-05-06 15:20:49 +00:00
Hypolite Petovan 36a7eceb89 Remove preemptive autolinker from Text\Markdown::toBBCode
- Autolinker is done centrally in Text\BBCode::convert
2020-05-05 23:41:35 -04:00
Hypolite Petovan ccb69414d2 Combine getFollowers and getFollowing into getContacts in ActivityPub\Transmitter 2020-05-05 22:32:45 -04:00
Hypolite Petovan f4083f6031
Merge pull request #8585 from annando/legacy-tag
Removed legacy usage of the "tag" field
2020-05-05 18:10:22 -04:00
Michael d33f6fc167 Renamed function 2020-05-05 21:58:25 +00:00
Michael 0f042b064a Fix warning, notice and DB Error 2020-05-05 21:49:48 +00:00
Michael 980de37047 Removed legacy usage of the "tag" field 2020-05-05 19:54:25 +00:00
Hypolite Petovan f7a45e4153
Merge pull request #8577 from annando/no-term2
File and category aren't using "term" anymore
2020-05-05 13:45:48 -04:00
Michael 3d4ace7a9d Merge branch 'no-term3' into no-term2 2020-05-05 16:09:50 +00:00
Michael d67b9cb693 Formula according to documentation 2020-05-05 16:01:20 +00:00
Michael 7de6e60328 Merge remote-tracking branch 'upstream/develop' into issue-8550 2020-05-05 15:56:24 +00:00
Michael 5725784055 Update database definition, cleaned code 2020-05-05 15:47:35 +00:00
Michael 59675c4f0b Merge remote-tracking branch 'upstream/develop' into no-term2 2020-05-05 15:44:24 +00:00
Michael d838dcbd8c Removed unused fields 2020-05-05 14:10:39 +00:00
Michael 2ee14bf5fe Merge remote-tracking branch 'upstream/develop' into post-delivery-data 2020-05-05 14:08:29 +00:00
Michael 84e3892955 Merge remote-tracking branch 'upstream/develop' into post-delivery-data 2020-05-05 13:16:01 +00:00
Michael 2f42e68dc8 Merge remote-tracking branch 'upstream/develop' into new-participation 2020-05-05 12:48:33 +00:00
Michael b7e25d16e7 Removed usage of "tag" field 2020-05-05 05:11:59 +00:00
Hypolite Petovan 340bc57952 Ensure Tag::getByURIId parameter value in OStatus;;entryFooter
- Address https://github.com/friendica/friendica/issues/8473#issuecomment-623701081
- $item['uri-id'] isn't present for follow entry pseudo-items
2020-05-04 18:51:03 -04:00
Michael 1362748f59 Merge remote-tracking branch 'upstream/develop' into no-term2 2020-05-04 15:20:30 +00:00
Michael 4c86f2a3ec Merge remote-tracking branch 'upstream/develop' into new-participation 2020-05-04 15:01:42 +00:00
Michael 16d486dd24 Merge remote-tracking branch 'upstream/develop' into post-delivery-data 2020-05-04 14:40:52 +00:00
Hypolite Petovan 05cac4c186
Merge pull request #8570 from annando/tag-notice
Fix for "Undefined index: uri-id""
2020-05-04 09:30:14 -04:00
Michael 4fa26c81e8 Fix for wrong table and wrong field name 2020-05-03 15:44:39 +00:00
Michael 875d6b36e9 File and category aren't using "term" anymore 2020-05-03 15:13:40 +00:00
Michael c141a3eb79 Corrected variable name 2020-05-02 22:02:29 +00:00
Michael 1a4beaf061 post update function added 2020-05-02 21:27:37 +00:00
Michael 098ba4a667 "item-delivery-data" is now "post-delivery-data" 2020-05-02 19:34:02 +00:00
Michael 2a1cdfa36b Diaspora participations are now atored as activities 2020-05-02 08:52:11 +00:00
Michael 233d6eea2b Tags are now added to the body again 2020-05-02 05:43:00 +00:00
Michael 11406fd3b6 Fix for "Undefined index: uri-id"" 2020-05-02 05:14:30 +00:00
Michael b0cb6536dd The old tag handling is removed 2020-05-02 05:08:05 +00:00
Michael 776a1dd7c3 Renamed function 2020-05-01 15:43:50 +00:00
Michael c3ecc19b41 Last "term" element renamed 2020-05-01 15:27:56 +00:00
Michael 729c6b67aa the "term" field now is called "name", workaround removed 2020-05-01 15:18:48 +00:00
Michael 74081a71ff Removed unused "use" 2020-05-01 13:26:13 +00:00
Michael ede69a8673 Function renamed 2020-05-01 13:13:58 +00:00
Michael 70022393b7 Fix notice for missing "uri-id" 2020-05-01 12:42:22 +00:00
Michael 2b1fef469a Notification moved to usage of the "tag" table 2020-05-01 12:41:17 +00:00
Michael 029a379060 Move "isType" to Tag.php 2020-05-01 12:39:41 +00:00
Michael ac2957c4dd Some more "term" to "tag" conversion 2020-05-01 10:57:32 +00:00
Michael 8602bbb3b9 "term" replaced with "tag" 2020-05-01 08:02:21 +00:00
Michael 3b2ae5c4a9 function names changed 2020-05-01 06:01:22 +00:00
Michael 6d4962a571 1,000 is better than 100 2020-04-30 12:13:13 +00:00
Michael bb0d6ce6f6 Better check for finished conversion 2020-04-30 09:03:05 +00:00
Michael 88931e5053 Post update functionality for tags 2020-04-30 06:09:57 +00:00
Michael Vogel e1d21e736a
Update src/Database/Database.php
Co-Authored-By: Hypolite Petovan <hypolite@mrpetovan.com>
2020-04-29 19:13:23 +02:00
Michael 136c6b644e Fix: Mentions had been stored as tags 2020-04-29 10:49:13 +00:00
Michael 6487daa4a9 Issue 8550: Check for a good table_definition cache value 2020-04-29 06:28:06 +00:00
Michael 8c44f535b7 Merge remote-tracking branch 'upstream/develop' into write-tags 2020-04-29 02:38:33 +00:00
Michael 00ef29fb97 It has to be "selectFirst" 2020-04-29 01:40:59 +00:00
Michael 1f9f321d54 Issue 8557: We have to fetch only a single row 2020-04-28 21:13:37 +00:00
Michael 10ffd3a374 Iissue 8560: Wrong value for parent in mail notification 2020-04-28 20:32:39 +00:00
Michael 6f3b46217e Fix for "Undefined index: profile_url" 2020-04-28 19:36:10 +00:00
Michael 70e5639e29 Merge 2020-04-28 13:33:03 +00:00
Hypolite Petovan a61f61a051
Merge pull request #8556 from annando/close-db-connection
Added forgotten DBA::close
2020-04-28 09:27:27 -04:00
Michael c2a9b3b9e9 Usage of the new tag tables 2020-04-28 11:52:51 +00:00
Michael 5367620467 Merge remote-tracking branch 'upstream/develop' into write-tags 2020-04-28 08:03:26 +00:00
Michael 238c079d11 Merge remote-tracking branch 'upstream/develop' into issue-8546 2020-04-28 08:01:33 +00:00
Michael e52e505a48 Merge 2020-04-28 08:00:38 +00:00
Michael f75009c20c Some more forgotten DBA::close 2020-04-28 07:10:18 +00:00
Tobias Diekershoff c853ea6aae
Merge pull request #8554 from annando/fix-8551
Fix issue 8551: Last item is now displayed again
2020-04-28 07:55:24 +02:00