Michael
b8a23369b6
Mail storing is now centralized
2019-05-08 05:44:22 +00:00
Hypolite Petovan
e6bf97777f
Remove /display/{nick}/{id} URL structure publishing
...
- Remove support for defunct Friendica F-Droid app
2019-05-02 17:04:17 -04:00
Philipp Holzer
318a3ca785
Create own base URL class which holds the whole base url business logic
2019-04-09 08:31:16 +02:00
Michael
4ff837488f
Issue 6167: Don't publish non visible content
2019-03-15 20:31:07 +00:00
Michael Vogel
4c6c5786ad
Merge pull request #6752 from MrPetovan/bug/notices
...
Fix various notices
2019-02-24 21:30:07 +01:00
Hypolite Petovan
e66768a058
Add empty entry author if contact query fails in DFRN
...
- Addresses https://github.com/friendica/friendica/issues/6338#issuecomment-462722599
2019-02-24 14:00:40 -05:00
Hypolite Petovan
0888850702
Fix missing avatar key in DFRN
...
- Addresses https://github.com/friendica/friendica/issues/6338#issuecomment-456839092
2019-02-24 13:40:04 -05:00
Hypolite Petovan
458064ddde
Merge pull request #6749 from nupplaphil/6386-php_fatal
...
Fixing appending child at DFRN without a parent id.
2019-02-24 12:55:34 -05:00
Philipp Holzer
5d13b94761
update phpdoc
2019-02-24 16:31:16 +01:00
Philipp Holzer
bf6a765beb
Fixing appending child at DFRN without a parent id.
2019-02-24 16:30:09 +01:00
Hypolite Petovan
8c1db51a76
Improve Logger calls
...
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
Michael
ebb84f5e43
DFRN comments are now stored as comments again
2019-01-24 18:54:45 +00:00
Michael
0fdab4ed10
Fix for several fatal errors
2019-01-23 21:54:20 +00:00
Hypolite Petovan
a6786ac814
Update array notation in Protocol\DFRN
2019-01-23 09:07:00 -05:00
Hypolite Petovan
64847e7cc8
Fix types in doc blocks/prototypes
2019-01-23 09:06:58 -05:00
Hypolite Petovan
7f2dc40601
Fix potential bugs without expected behavior change
...
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Hypolite Petovan
3d839bb176
Move Contact::ACCOUNT_TYPE_* constants to User::ACCOUNT_TYPE_*
...
- Keep Contact::TYPE_* constants for comparison with contact.contact-type
2019-01-21 10:56:27 -05:00
Hypolite Petovan
ad9c67663d
Move Contact::Page_* constants to User::PAGE_FLAGS_*
2019-01-21 10:55:37 -05:00
Hypolite Petovan
4a95ca280d
Remove unused code
...
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
Hypolite Petovan
3282ce5389
Fix PHPDoc comments project-wide
2019-01-21 10:35:51 -05:00
Hypolite Petovan
55e54bb950
Replace deprecated Addon::callHooks with Hook::callAll
...
- Update documentation
2019-01-21 09:50:56 -05:00
Hypolite Petovan
895b3abf32
Remove/replace killme() with *exit()
2019-01-21 09:49:17 -05:00
Michael
297a549590
Issue 6282: Update the forum status of contacts
2019-01-12 16:09:27 +00:00
Hypolite Petovan
5e1ceb57de
Escape global namespaced get_app() calls
...
- Add deprecated status
2019-01-03 21:27:36 -05:00
Hypolite Petovan
3095d4aa70
Add parent to private message notifications
...
- Fix item id for Diaspora private message notification
2018-12-30 01:10:10 -05:00
Hypolite Petovan
acaee626f5
Remove include/ requires that are now done directly from Composer
2018-12-24 09:56:25 -05:00
Hypolite Petovan
458981f75c
Replace x() by isset(), !empty() or defaults()
...
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Hypolite Petovan
de5ee56d2f
Move DFRN::birthdayEvent() to Event::createBirthday
2018-11-22 00:15:09 -05:00
Hypolite Petovan
d71e856535
Replace remaining occurrences of "0001-01-01" with DBA::NULL_DATE
2018-11-21 23:53:45 -05:00
Adam Magness
218f0734be
Rename removeTags to escapeTags
...
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
ffc406d819
normalise_link calls
...
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
5276c28a78
link_compare calls
...
implement compareLink function.
2018-11-08 10:46:50 -05:00
Adam Magness
6fc9c6de3b
base64url calls
...
implement base64UrlEncode and base64UrlDecode functions
2018-11-08 10:37:08 -05:00
Adam Magness
0efcbe5d15
protect_sprintf calls
...
implement protectSprintf function
2018-11-08 10:30:45 -05:00
Adam Magness
a0f65ca7a1
notags calls
...
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb
random_string calls
...
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness
4f07ebb52f
Rename properly
...
rename function properly this time!
2018-11-06 06:34:32 -05:00
Adam Magness
3eecd108c5
rename function
...
rename function and update calls.
2018-11-06 06:31:48 -05:00
Adam Magness
a71eb1d127
functions moved to HTML class
...
update function calls to moved class.
2018-11-05 21:06:26 -05:00
Adam Magness
9e51be7554
Revert "Update function calls"
...
This reverts commit 748fb8b946
.
2018-11-05 13:07:07 -05:00
Adam Magness
748fb8b946
Update function calls
...
update function calls to new class
2018-11-05 07:40:18 -05:00
Adam Magness
b07d47b0f7
Update function calls
...
update function calls to new names
2018-11-05 07:24:14 -05:00
Adam Magness
61bc9facc8
Implement functions
...
implement functions relocated to xml class
2018-11-05 07:24:14 -05:00
Adam Magness
d9b558a8ed
Update function calls
...
update function calls to new class.
2018-10-30 14:51:45 -04:00
Adam Magness
50da89d861
Logger Levels
...
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
14fde5dc9b
Log function
...
implement log() function.
2018-10-30 09:57:14 -04:00
vinzv
cb75c40f4e
adapted profile pic resize to 300px for whole system
2018-10-23 16:36:57 +02:00
Philipp Holzer
d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect()
2018-10-22 22:13:35 +02:00
Philipp Holzer
2ef81108b3
Renamed System::redirect() to $a->redirect()
2018-10-22 22:13:22 +02:00
Hypolite Petovan
a2666b0d02
Remove reference to deleted include/security.php
2018-10-19 15:11:51 -04:00
Philipp Holzer
7c73e8634c
Curl Response Refactoring
...
- refactored Network::post()
- replaced every Network::post() execution with the new Curl container
2018-10-10 21:15:26 +02:00
Philipp Holzer
2dec8895a9
Curl Response Refactoring
...
- extended Curl to parse Curl Response
- refactored Network::curl()
- replaced every Network::curl() execution with the new Curl container
2018-10-10 21:08:43 +02:00
Philipp Holzer
5a02e39a65
Rename App Methods
...
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
Michael
acf31ab64b
Additional check to ensure that the owner of an activity is always the author
2018-10-06 09:38:51 +00:00
Michael
0dbb6313a5
Hopefully fixes relocations that hadn't been executed
2018-09-22 06:47:35 +00:00
Michael
9ef1d827f3
Restore the behaviour to remove the remote contact upon termination
2018-09-05 05:02:06 +00:00
Michael
380eeaab88
Still there had been notices - must have a good camouflage
2018-08-31 05:08:22 +00:00
Michael Vogel
601851f3d0
Removed notice - pokes do now work mostly ( #5693 )
2018-08-29 09:00:01 -04:00
Michael
5e82323456
Avoid useless contact updates
2018-08-26 07:56:33 +00:00
Roland Häder
61693419e8
Cleanups: isResult() more used, readability improved ( #5608 )
...
* [diaspora]: Maybe SimpleXMLElement is the right type-hint?
* Changes proposed + pre-renaming:
- pre-renamed $db -> $connection
- added TODOs for not allowing bad method invocations (there is a
BadMethodCallException in SPL)
* If no record is found, below $r[0] will fail with a E_NOTICE and the code
doesn't behave as expected.
* Ops, one more left ...
* Continued:
- added documentation for Contact::updateSslPolicy() method
- added type-hint for $contact of same method
- empty lines added + TODO where the bug origins that $item has no element 'body'
* Added empty lines for better readability
* Cleaned up:
- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)
* Re-fixed DBM -> DBA switch
* Fixes/rewrites:
- use empty()/isset() instead of deprecated x()
- merged 2 nested if() blocks into one
- avoided nested if() block inside else block by rewriting it to elseif()
- $contact_id is an integer, let's test on > 0 here
- added a lot spaces and some empty lines for better readability
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class
* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
- fixed mixure with "Contact::* rewrite"
* Ops, one still there (return is no function)
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
will do this for us
- renamed those proxy_*() functions to better names:
+ proxy_init() -> Proxy::init() (public)
+ proxy_url() -> Proxy::proxifyUrl() (public)
+ proxy_parse_html() -> Proxy::proxifyHtml() (public)
+ proxy_is_local_image() -> Proxy::isLocalImage() (private)
+ proxy_parse_query() -> Proxy::parseQuery() (private)
+ proxy_img_cb() -> Proxy::replaceUrl() (private)
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* Ops, need to set $a here ...
* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule
* Ops, no need for own instance of $a when self::getApp() is around.
* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module
* No instances from utility classes
* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`
* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.
* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.
* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Ops, was added accidentally ...
* Ops, why these wrong moves?
* Ops, one to much (thanks to MrPetovan)
* Ops, wrong moving ...
* moved back to original place ...
* spaces added
* empty lines add for better readability.
* convertered spaces -> tab for code indenting.
* CR request: Add space between if and brace.
* CR requests fixed + move reverted
- ops, src/Module/*.php has been moved to src/Network/ accidentally
- reverted some parts in src/Database/DBA.php as pointed out by Annando
- removed internal TODO items
- added some spaces for better readability
2018-08-24 01:05:49 -04:00
Michael Vogel
c1da44b7dc
We now use a central function to fetch the importer ( #5636 )
2018-08-19 13:37:56 +00:00
Michael Vogel
7f3fb34c24
Some easy to replace "q" calls have been replaced by "DBA" calls ( #5632 )
...
* Some easy to replace "q" calls have been replaced by "DBA" calls
* Simplified the GUID creation
* And one in the API ...
* And OStatus has got some DBA calls more
* Just some more replaced database calls
* The event query is now simplified
* Events are now shown again
* subthread is now using the DBA calls as well
* Some more replaced database calls
* And some more replaced database calls and prevented notices
* Better use gravity
* Some more replaced database stuff
* Some more replaced database calls in DFRN.php
* The gcontact class now has got the new DBA functions as well
* The Contact class is now changed to new database functions as well
* Small correction
* We can now delete without cascade
* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
Michael
0342f9e084
Removed notices, will it ever end?
2018-08-17 03:19:42 +00:00
Roland Häder
e06fc2aa69
Stopped using deprecated constants NETWORK_* ( #5537 )
...
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
Hypolite Petovan
c13dc549ed
Rename PROTOCOL_* constants to Model\Conversation::PARCEL_*
...
- Remove unused Conversation::PROTOCOL_GS_CONVERSATION constant
- Remove now renamed PROTOCOL_* constant declarations
2018-08-05 12:24:42 +02:00
Michael Vogel
71b1638d9a
Once again, notices ... ( #5535 )
2018-07-31 18:39:23 +02:00
Michael Vogel
b552b711ee
And some more notices removed ... ( #5533 )
...
* Fix for vanishing notes
* The field needs to be part of the selected fields ...
* And some more notes ...
2018-07-31 07:54:25 +02:00
Roland Häder
4a22710b3b
Moved global PAGE_* to Profile class ( #5500 )
...
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*
* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`
* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Michael Vogel
986106a8f7
Item storage: Permissions aren't stored in the items anymore ( #5495 )
...
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
2018-07-25 19:14:55 -04:00
Roland Häder
37253656e3
Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace ( #5490 )
...
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class
* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
2018-07-24 22:53:46 -04:00
Michael Vogel
be8b68aaaf
Store guid and plink with event ( #5485 )
...
* Store guid and plink with event
* One space too much
2018-07-24 10:01:31 -04:00
Hypolite Petovan
a6fb3568f9
Rename dbesc to DBA::escape
2018-07-23 15:30:54 -04:00
Hypolite Petovan
ecea7425f8
Rename DBA::is_result to DBA::isResult
2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a
Rename DBM method calls to DBA method calls
2018-07-23 11:02:24 -04:00
Hypolite Petovan
8ddb94ef06
Use DateTimeFormat::utc() instead of DBM::date()
2018-07-23 10:57:47 -04:00
Michael Vogel
53876abfda
And some more removed notices in the core ( #5465 )
2018-07-23 07:43:18 -04:00
Roland Häder
c17adaf333
Uncommon logger levels in Friendica ( #5453 )
...
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)
* Used constants instead of values (MrPetovan)
2018-07-22 14:07:44 -04:00
Roland Häder
2e332134d4
There is no LOGGER_WARNING (triggering E_NOTICE about absent constant). Either ( #5448 )
...
declare it and push all other numbers higher or use LOGGER_NORMAL.
2018-07-22 12:33:28 -04:00
Michael Vogel
7382be2766
Some more notices ( #5424 )
2018-07-20 14:07:54 -04:00
Hypolite Petovan
af6dbc654f
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 08:19:26 -04:00
Hypolite Petovan
daa1177e3a
Update use statement lists with new Friendica\Database\dba class
...
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Roland Häder
b2899d76cf
Small cleanup ( #5416 )
...
- added internal TODO to decide about is_result() usage
- removed semicolon (not needed here) from SQL query
- added empty line
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-19 18:39:05 -04:00
Michael Vogel
5af9596dde
New item field "Post-type" and new table "permissionset" ( #5408 )
...
* "post-type" replaces "bookmark" and "type"
* Removed some more type
* Added index to permission set
* The permission set is now stored
* The permission set is now removed upon expiry
* Post update now stores the permission set
* New file
* Permissions are now sorted
* Changed documentation
2018-07-19 09:52:05 -04:00
Michael
95fe08e5b9
Ensure that "follow" requests can be processed
2018-07-16 06:34:12 +00:00
Michael
78c9e29aa8
Don't accept posts from unknown owners
2018-07-16 05:48:51 +00:00
Michael Vogel
0360f7197a
Several more warnings ... ( #5340 )
...
* Some more warnings removed
* Even more warnings ...
* Will it ever end? ;-)
* Avoid warning in dbstructure
* Origin and OStatus ...
* There are more warnings solved ... yeah!
* And again ...
* We are not done yet
* And more ...
* And some new places ...
* And more in the feeds
* Avoid some more
* And some backend stuff
* Notifications cleared
* Some more stuff
* and again ...
* It's getting fewer ...
* Some warnings had been hidden in the notifications
* Fix the fix
* And another missing one ...
* We need the owner here, not the user
* Forgotten user
* And more ...
* And some more warnings disappeared ...
* Some more frontend warnings
* Some backend warnings removed
* Fixed sidebar for "vier"
* And more ...
* Some more ...
* And something for "remote self"
* Am I stuck in an endless loop?
* Fix: Clear tag and file field on update
* Preset page content
2018-07-10 08:27:56 -04:00
Michael
1d745c25a7
Some more places ...
2018-07-08 12:58:43 +00:00
Michael
7d6933c898
Avoid "Trying to get property of non-object"
2018-07-08 11:46:05 +00:00
Michael
3e797547a3
Warnings fixed
2018-07-08 09:37:05 +00:00
Michael
4d35e228c4
More item abstraction / making remote deletion work again
2018-07-07 18:14:16 +00:00
Michael
38160a48b0
Post update script to move old content from the item table
2018-07-01 19:02:29 +00:00
Michael
028c9f4da5
We now store the verb in the item-content as well
2018-06-27 19:37:13 +00:00
Michael
76dab3b2d7
Use gravity instead of verb
2018-06-27 18:09:33 +00:00
Michael
d643e00d33
Standards and a new function to fetch content
2018-06-21 15:14:01 +00:00
Michael
70af2cecf2
Some of the last direct SQL calls to the item table had been changed
2018-06-21 06:21:51 +00:00
Roland Häder
8ad523fbc8
Continued a bit:
...
- removed/fixed whitespaces and mixture of spaces/tabs (some)
- added new-line character at end of files (POSIX-compilant)
- reverted some code which I had messed up (compared to upstream/develop)
- removed duplicate dba::update() invocation in src/Protocol/DFRN.php
- also removed no longer valid TODO
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:19:54 +02:00
Michael
f806fa91b1
Replace old database queries with the new ones
2018-06-20 22:02:17 +02:00
Roland Haeder
593d1feca6
was a bit confusing for me or I was not sleeping to much ...
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:17 +02:00
Roland Haeder
2d744fa189
PHP5 does not support native type-hints, except array
+ used dbm::is_result()
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:17 +02:00
Roland Haeder
4ca26fd3bc
fixed comment and explained one
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
Roland Haeder
a5dba628c4
old behaviour restored
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
Roland Haeder
0e5daa86df
added curely branches + reverted back to old behaviour (may come back one day)
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
Roland Haeder
ad9bd7bb72
better comment added by @Hypolite
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
Roland Häder
fe77e1b538
added more curly braces + a bit more usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-06-20 22:02:16 +02:00
Roland Haeder
f89b999659
was a bit confusing for me or I was not sleeping to much ...
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:15 +02:00
Roland Haeder
f0b05838cb
fixed comment and explained one
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:15 +02:00
Roland Haeder
a95db714ca
added curely branches + reverted back to old behaviour (may come back one day)
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:15 +02:00
Roland Haeder
63f5598766
better comment added by @Hypolite
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:15 +02:00
Roland Haeder
9cc0d5479b
old behaviour restored
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-06-20 22:02:15 +02:00
Michael
962fbc9166
Many "fetch_first" had been replaced
2018-06-19 21:33:07 +00:00
Michael
2a76290d19
Using the constants
2018-06-17 21:55:01 +00:00
Michael
6e10de9284
New function to fetch item data especially for users
2018-06-17 17:05:17 +00:00
Michael
1aec8f620d
More item abstractions for DFRN and Diaspora
2018-06-16 22:32:57 +00:00
Hypolite Petovan
93daf7883e
Merge branch 'master' into develop
...
- Updated new develop version label
- Incremented database build number
2018-06-01 07:30:04 -04:00
Michael
c86111d193
Coding standards
2018-05-29 19:00:26 +00:00
Michael
8329705eba
New function to delete items for users
2018-05-29 05:22:57 +00:00
Michael
b333c7ae2e
Bugfix: Only send a notifier when the item was really edited
2018-05-17 05:49:55 +00:00
Michael
e77cd17495
We do the notify stuff now directly in the item class
2018-05-15 19:50:29 +00:00
Roland Häder
57e668d9e0
Continued:
...
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
Michael
dcfd81e2ee
Some corrections
2018-05-14 22:50:04 +02:00
Michael
d54c79a772
Replace old database queries with the new ones
2018-05-14 22:50:04 +02:00
Roland Haeder
11dcb31960
was a bit confusing for me or I was not sleeping to much ...
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Haeder
ce07c20130
PHP5 does not support native type-hints, except array
+ used dbm::is_result()
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Haeder
6579396627
removed TODO, one day this all needs refacturizing ...
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Haeder
7526afcf13
Continued:
...
- converted multiple single-line comments into one multi-line comment (please
stop abusing programming languages!)
- added more TODO tags for type-hints (upcoming rewrite)
- opps, one space was only fixed in develop branch, not in this PR branch
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Haeder
f5f1650b62
fixed comment and explained one
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:02 +02:00
Roland Haeder
1fcd4f52e7
old behaviour restored
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
Roland Haeder
87bb934f8f
added curely branches + reverted back to old behaviour (may come back one day)
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
Roland Haeder
116d0ee1e0
better comment added by @Hypolite
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:50:01 +02:00
Roland Häder
e5c4b0203a
added more curly braces + a bit more usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:00 +02:00
Michael
3bb5a416f8
Some corrections
2018-05-14 22:50:00 +02:00
Michael
8b775d48f9
Replace old database queries with the new ones
2018-05-14 22:50:00 +02:00
Roland Häder
dd6fd32883
rewrote based on CR by @Annando, thank you. It is now clear to me.
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:59 +02:00
Roland Häder
25fd270959
Continued:
...
- added spaces and curly braces
- added more TODOs as there really more to be done
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
Roland Haeder
fc4d1296e3
was a bit confusing for me or I was not sleeping to much ...
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:57 +02:00
Roland Haeder
4d5c61395e
PHP5 does not support native type-hints, except array
+ used dbm::is_result()
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:57 +02:00
Roland Haeder
03f283ca36
fixed comment and explained one
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:56 +02:00
Roland Haeder
d2d6200669
old behaviour restored
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:56 +02:00
Roland Haeder
be3d0a90a5
added curely branches + reverted back to old behaviour (may come back one day)
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:56 +02:00
Roland Haeder
b823708c50
better comment added by @Hypolite
...
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:56 +02:00
Roland Häder
99440f3c56
Beatification:
...
- added space after curly braces (MrPetovan)
- added TODO for possible rewrite candidate
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-13 14:21:53 +02:00
Alexandre Alapetite
736c76d068
Simplify constant names
...
https://github.com/friendica/friendica/pull/5036#discussion_r187792865
2018-05-13 10:34:33 +02:00
Alexandre Alapetite
41a8c62bee
Fix wrong use of class constants
...
http://php.net/manual/language.oop5.constants.php
2018-05-13 10:07:15 +02:00
Roland Häder
445cc1cb99
Fixes:
...
- brought back comment (ops)
- DBM is the class name (not dbm)
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-13 10:06:43 +02:00
Roland Häder
3191fee763
Ops, one to much ...
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-13 10:02:47 +02:00
Roland Häder
cf9fa51f2f
Continued:
...
- added missing space/curly braces
- added TODOs for later adding a lot type-hints, without these (and they are
long time around in PHP) anything can be handled over to the method/function.
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-10 13:07:21 +02:00
Roland Häder
f66cb9b0a3
added more curly braces + a bit more usage of dbm::is_result()
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-10 13:07:21 +02:00
Michael
dfa0dbf33f
Ups
2018-05-04 21:33:15 +00:00
Michael
1230ff146a
"remote-self" is now working for Diaspora and Twitter as well
2018-05-04 21:12:13 +00:00
Michael
eecd1e47e4
Some corrections
2018-05-02 21:12:48 +00:00
Michael
4ad655ab80
Replace old database queries with the new ones
2018-05-02 19:26:15 +00:00
Michael
a182dd3400
Improved logging, avoiding PHP warning
2018-04-30 16:46:49 +00:00
Hypolite Petovan
bd21fc3751
Import posts from ignored contacts
2018-04-27 21:08:19 -04:00
Michael
9f5a6c05fb
Preparation for relay posts with DFRN
2018-04-27 05:11:52 +00:00
Michael
5019d46071
We only need the uid
2018-04-24 14:58:39 +00:00
Michael
5cf745af44
Item distribution is now done via the public post
2018-04-24 13:21:25 +00:00
Michael
b3d24f0ff2
DFRN: mark for archival at different places
2018-04-23 06:03:55 +00:00
Michael
8f2db61538
Receiving of public posts is now working
2018-04-22 10:58:03 +00:00
Michael
c59b28a8c4
create public endpoint
2018-04-22 10:04:30 +00:00
Michael Vogel
39edd086e0
Merge pull request #4893 from MrPetovan/bug/4879-remove-backslash-in-birthday-events
...
Fix quoting style in DFRN::birthdayEvent()
2018-04-22 07:54:07 +02:00
Hypolite Petovan
851c5d841f
Fix quoting style in DFRN::birthdayEvent()
2018-04-21 21:03:12 -04:00
Michael
16beab4652
Better working with private forums
2018-04-21 21:59:02 +00:00
Michael
d0dfe2aa64
Fix: Empty answers in DFRN can be okay
2018-04-07 10:02:43 +00:00
Michael
1a2c771f24
DFRN: Improvements to delivery. Logging and marking as not reachable
2018-04-03 12:18:05 +00:00
Michael
d668b967c9
Misspelling
2018-04-02 22:06:31 +00:00
Michael
becc86a960
Changed logging text
2018-04-02 22:02:43 +00:00
Michael
8ff6a31512
Sending does now work
2018-04-02 21:59:30 +00:00
Michael
eeadd2f9d6
The Diaspora transport layer is now the default for DFRN
2018-04-02 21:46:10 +00:00
Michael
f89904ed77
Treatment, Treating, whatever :-)
2018-04-02 13:44:45 +00:00
Michael
0594f13c35
Receiving was tested, sending is implemented and tested as well, currently unused
2018-04-02 12:53:48 +00:00
Michael
f51a254ed0
Public contacts are not permitted for suggestions or mails
2018-04-01 05:07:35 +00:00
Michael
1613f2a1c4
Ensure that public contacts can't create toplevel posts
2018-03-30 06:20:00 +00:00
Hypolite Petovan
6e7c6ab0fa
Remove references to include/event
2018-03-23 06:32:34 -04:00
Hypolite Petovan
f7e2071117
Replace include/event function with method calls
...
- Updated scope of Model\Event methods
- Updated use list
2018-03-23 06:32:34 -04:00
Hypolite Petovan
27d94023ee
Merge branch 'master' into develop
2018-03-23 06:15:55 -04:00
Michael
9930c61263
Same same but different
2018-03-17 20:56:56 +00:00
Michael
8700d2a8ad
Avoid storing "null" values
2018-03-17 13:09:21 +00:00
Michael
c438e47827
Bugfix: Avoid "Class not found" error
2018-03-08 19:58:35 +00:00
Hypolite Petovan
789561c7a2
Remove/Update references to include/html2*.php
2018-03-07 16:34:17 -05:00
Hypolite Petovan
b5666bd27f
Replace html2bbcode calls by HTML::toBBCode
2018-03-07 16:24:13 -05:00
Michael
0cc121cf44
Bugfix: Deleting comments via DFRN had only partly worked
2018-03-01 21:52:36 +00:00
Michael
d4c95e0032
Contact updates should now work more reliable
2018-02-26 21:53:42 +00:00
Hypolite Petovan
9e3bae5caa
Remove references to include/bbcode.php
2018-02-14 22:01:14 -05:00
Hypolite Petovan
0c52866693
Refactor bbcode() into BBCode::convert()
2018-02-14 21:33:55 -05:00
Michael
2f71a6f80f
DFRN: Bugfix for not storing mails
2018-02-14 22:08:16 +00:00
Michael
43b1eccbcd
Bugfix and improvements for unmarking potentially archived contacts
2018-02-14 21:18:16 +00:00
Hypolite Petovan
d8e9ed5ff8
[Scrutinizer] Fix undeclared variables in src/Protocol/
...
- Use dba::selectFirst to remove intermediate variables `$r`
- Remove unused variable `$sender` in Protocol\Email
- Simplify Protocol\OStatus:fetchAuthor cascading queries
2018-02-13 23:58:46 -05:00
Michael
30cfca40d8
Use a more simple HTML for API output
2018-02-10 13:33:15 +00:00
Michael
a2f172e084
Bugfix for check that the DFRN entry already exists
2018-02-09 06:20:01 +00:00
Tobias Diekershoff
85c8bf0228
Merge pull request #4399 from MrPetovan/task/3878-move-include-bbcode-to-src
...
Move include/bbcode to src/ part 1 : Everything but bbcode()
2018-02-07 07:18:39 +01:00
Michael
e609de2957
Many item calls are now isolated in a single function
2018-02-06 12:40:22 +00:00
Adam Magness
db8ef98537
Rename functions
...
rename functions from review comments
2018-02-05 12:48:22 -05:00
Adam Magness
4be49e706b
Remove requires
...
remove require_once for old file
2018-02-05 12:47:37 -05:00
Adam Magness
7ffcb25321
Update function names and calls
...
update function names and calls from other files
2018-02-05 12:47:04 -05:00
Hypolite Petovan
d75bb8e970
Rename BBCode::removeAbstract() to BBCode::stripAbstract()
2018-02-04 23:38:40 -05:00
Hypolite Petovan
010cf3b1e8
Update references to BBCode methods
...
- Resolve name conflicts with Util\Network
2018-02-04 19:26:22 -05:00
Hypolite Petovan
2a5431a59e
Rename Model\Term methods
2018-02-04 16:48:50 -05:00
Hypolite Petovan
2a486903d1
Remove references to include/tags.php
2018-02-03 23:59:31 -05:00
Hypolite Petovan
9f3acceac7
Replace references to include/tags functions
2018-02-03 23:57:47 -05:00
Hypolite Petovan
0abe4158d2
Rename Term methods ahead of the move
...
- Rename createFromItemURI() to insertFromItemFileByUri()
- Rename createFromItem() to insertFromItemFileById()
2018-02-03 22:42:31 -05:00
Hypolite Petovan
5e7285b9ba
Move Temporal::convert() to DateTimeFormat::convert()
2018-02-03 08:56:55 -05:00
Hypolite Petovan
35d06bd9eb
Add Temporal::utc() shorthand to Temporal::convert()
2018-02-03 08:56:53 -05:00
Hypolite Petovan
8aff8a76eb
Add Temporal::utcNow()
2018-02-03 08:56:52 -05:00
Hypolite Petovan
b854905150
Move ATOM_TIME to Temporal::ATOM
2018-02-03 08:56:52 -05:00
Hypolite Petovan
dc366bf1f7
Refactor datetime_convert into Temporal::convert
...
- Changed parameter order to save space
- Refactor select_timezone into Temporal::getTimezoneSelect
- Refactor field_timezone into Temporal::getTimezoneField
2018-02-03 08:56:51 -05:00
Michael
6871481a78
Moved "limitBodySize"
2018-01-28 17:36:37 +00:00
Michael
bdbfffafea
Renamed the contact relationship functions
2018-01-28 17:26:39 +00:00
Michael
7b27dda784
Most functions now moved from include/items.php
2018-01-28 11:18:08 +00:00
Adam Magness
f04d40a37e
Review update
...
Rename function, move others
2018-01-27 11:13:41 -05:00
Adam Magness
ca76e49c23
Move remaining functions
...
update remaining function calls
2018-01-27 08:25:54 -05:00
Adam Magness
a32ba32ff4
Move post_url
...
move post_url function
2018-01-26 23:24:23 -05:00
Adam Magness
2f9642392d
Move z_fetch_url
...
move z_fetch_url method
2018-01-26 23:18:38 -05:00
Michael
1828f25db8
Function renamed
2018-01-24 22:22:31 +00:00
Michael
3ace5d0d1d
Some functions had been moved away from include/items.php
2018-01-24 20:27:32 +00:00
Adam Magness
208a149a7b
Review sprintf
...
remove more sprintf calls
2018-01-23 21:59:16 -05:00
Adam Magness
f0725ae384
Hopefully all t()
...
hopefully the last of the t()
2018-01-22 18:03:26 -05:00
Michael
efa8dbcfb3
Relocate functions in items.php into several classes
2018-01-20 23:52:54 +00:00
Adam Magness
11cf36105c
Update Addon functions and calls
...
Update function names and calls for Addon class.
2018-01-20 07:48:22 -05:00
Hypolite Petovan
98344a9d08
Remove reference to RINO version 2
2018-01-19 12:06:09 -05:00
Hypolite Petovan
2c284f30c2
Revert bumping the site RSA key strength to 2048
2018-01-19 11:58:26 -05:00
Hypolite Petovan
dd07c47ab2
Code cleanup in Protocol\DFRN
...
- Remove commented out code
- Fix mixed quote style
2018-01-19 11:50:43 -05:00
Hypolite Petovan
035394cbf2
RINO code cleanup
...
- Restore original use Friendica\Util\Crypto
- Remove RINO1 deprecation comments
- Fix undefined variable $rino_remote_version
2018-01-19 11:34:56 -05:00
Hypolite Petovan
5bc7f4a442
Remove RINO2 and RINO3
2018-01-19 11:27:53 -05:00
Hypolite Petovan
cadf8c5e5d
Bump new users RSA key strength
2018-01-19 11:27:53 -05:00
Hypolite Petovan
7af6cc8454
Add RINO version 3 encrypt/decrypt
...
- Add legacy decrypt of RINO2
- Add fallback to RINO1 to encrypt
2018-01-19 11:27:53 -05:00
Michael
034d46196f
"last-child" is not used anymore
2018-01-18 06:54:44 +00:00
Hypolite Petovan
e36f2bb1fb
Use short form array syntax everywhere
...
- Add short form array syntax to po2php.php generation
2018-01-15 14:07:17 -05:00
Adam Magness
771163e860
Move auto_redir function
...
move function into dfrn, rename and update a db insert
2018-01-13 09:36:21 -05:00
Adam Magness
dc175b8e12
Update functions and calls
...
Change function names, calls and use dba functions.
2018-01-10 12:05:20 -05:00
Hypolite Petovan
9a3e773a9a
Merge branch 'develop' into task/3954-move-auth-to-src
2018-01-02 19:30:41 -05:00
Hypolite Petovan
eb1b6605b7
Remove include/oembed and mod/oembed
2017-12-31 20:58:32 -05:00
Hypolite Petovan
e7c53af6fa
Add Module\Oembed and Content\OEmbed
2017-12-31 20:58:09 -05:00
Adam Magness
9e6bf79380
Crypto to src
...
move Crypto to src and Friendica\Util namespace
2017-12-30 11:51:49 -05:00
Hypolite Petovan
e16852c2f5
Replace init_groups_visitor with Group::getIdsByContactId
2017-12-29 21:55:12 -05:00
Michael
fba40b8761
Removed unneeded code
2017-12-21 08:58:36 +00:00
Michael
f9307c4665
Oops
2017-12-19 17:38:33 +00:00
Michael
b457ed6876
Preparation for being able to comment every public item
2017-12-19 17:15:56 +00:00
Hypolite Petovan
2978b1eef0
Fix undefined variable/wrong parameter count/unknown functions
2017-12-17 15:33:45 -05:00
Hypolite Petovan
916236ce2f
Fix docblocks types
2017-12-17 15:27:50 -05:00
Hypolite Petovan
10b72b0e9e
PHPStan: Fix missing requires/namespaces
2017-12-17 15:26:43 -05:00
Hypolite Petovan
bc58e8d3be
Rename Model\GlobalContact to Model\GContact
2017-12-07 23:57:56 -05:00
Hypolite Petovan
a42595a30c
Move Object\Contact to Model\Contact
2017-12-07 23:56:12 -05:00
Hypolite Petovan
3fc3e67b70
Separate Object\Photo into Model\Photo and Object\Image
...
- Renamed a bunch of functions to shorter or clearer names
2017-12-07 23:54:51 -05:00
Michael Vogel
5747cfc79c
Revert "Move Objects to Model"
2017-12-08 05:21:51 +01:00
Hypolite Petovan
cd84bf8963
Rename Model\GlobalContact to Model\GContact
2017-12-07 09:09:28 -05:00
Hypolite Petovan
18d93cddf6
Move Object\Contact to Model\Contact
2017-12-07 09:04:24 -05:00
Hypolite Petovan
52bddd580c
Separate Object\Photo into Model\Photo and Object\Image
...
- Renamed a bunch of functions to shorter or clearer names
2017-12-07 08:56:11 -05:00
Adam Magness
0373056448
Review and Use statements
...
use statements and review changes.
2017-11-29 17:29:11 -05:00
Adam Magness
0091d318e5
Function names
...
Update function names and corresponding function calls
2017-11-29 12:17:12 -05:00
Adam Magness
609a4de5d0
src Standards
...
This basically completes coding standards changes for the entire src directory, with the exception of App.php
2017-11-23 14:01:58 -05:00