Commit Graph

734 Commits

Author SHA1 Message Date
Philipp Holzer 8a358d5c98
Add Logger entry 2019-03-11 21:27:36 +01:00
Philipp Holzer 9a60eab152
Skip update if already done 2019-03-11 21:21:01 +01:00
Hypolite Petovan a2ec9e676e
Revert "Avoid double update runs" 2019-03-09 18:28:48 -05:00
Philipp Holzer f7c7851c2d
replaced duplicate code with method 2019-03-09 20:50:06 +01:00
Philipp Holzer 20498d1d40
replaced duplicate code with method 2019-03-09 20:50:00 +01:00
Philipp Holzer 7047a13ffa
added phpdoc 2019-03-09 20:49:59 +01:00
Philipp Holzer e46a7cdf80
Avoid double update runs 2019-03-09 20:49:59 +01:00
Michael ea71a4e83a Refetch new jobs only once per execution loop 2019-03-08 20:39:58 +00:00
Tobias Diekershoff 5df246e9af
Merge pull request #6825 from annando/empty-spawn
Worker: Don't spawn without jobs
2019-03-08 07:26:22 +01:00
Michael d87abe9563 Worker: Don't spawn without jobs 2019-03-08 05:53:36 +00:00
Philipp Holzer 07bd4cec65
Fixing redis cachekey 2019-03-04 21:28:36 +01:00
Philipp Holzer d7426e697d
Fixing redis cachekey 2019-03-04 21:09:20 +01:00
Philipp Holzer 3e53dab817
Fixing redis cachekey 2019-03-04 21:00:41 +01:00
Michael f2560c42d1 Reduce the default maximum load for the worker to 20 2019-03-02 18:41:12 +00:00
Michael 9427d7f628 We have to fetch the data this way 2019-03-02 13:07:29 +00:00
Michael 16c2ae89e8 Sent update mails to administrators only once 2019-03-02 12:57:47 +00:00
Philipp Holzer 16ff5af221
Fix handling table name during storage move 2019-03-01 18:07:08 +01:00
Philipp Holzer 739449926c
'%' is deprecated 2019-02-27 20:30:08 +01:00
Philipp Holzer 4a47425bfd
admin mail list seems wrong escaped 2019-02-27 20:17:35 +01:00
Michael c3b12b63c8 Added some description, changed logger call 2019-02-27 09:49:26 +00:00
Michael 505a34d40e Log the time as decimal 2019-02-27 09:12:40 +00:00
Michael 78960d4bde Removed unneeded spaces 2019-02-27 09:11:37 +00:00
Michael 5e440aa035 The cron interval is minutes - so we have to convert it into seconds 2019-02-27 08:55:25 +00:00
Michael 0ee1ea5f29 The log text is now shorter 2019-02-27 08:41:45 +00:00
Michael 11e39da6cc And moving the block back to the old place 2019-02-27 07:08:44 +00:00
Michael e1cc7262de Respawing when quitting 2019-02-27 07:04:21 +00:00
Michael 528636c9f4 Using constants is nicer 2019-02-27 06:55:04 +00:00
Michael fb371e1048 Merge remote-tracking branch 'upstream/2019.03-RC' into worker2 2019-02-27 06:41:14 +00:00
Michael 40573120b9 Enhanced logging, stopping worker after cron lifetime 2019-02-27 06:36:19 +00:00
Hypolite Petovan 05d8bf6b54 Fix wrong use of array_shift in Core\Worker 2019-02-25 07:11:35 -05:00
Michael Vogel df5ea1fab0
Merge pull request #6732 from MrPetovan/bug/1777-fix-blocked-contact-group
Allow to remove blocked contact from groups
2019-02-24 14:30:36 +01:00
Hypolite Petovan 4e3f780621
Merge pull request #6740 from nupplaphil/issue/6503-force_update
Fixing force-flag for lock-release
2019-02-24 07:04:54 -05:00
Philipp Holzer d1c7815c4e
added whitespace 2019-02-24 12:51:58 +01:00
Philipp Holzer aae58815a8
Adjust update parameters:
-f|--force         Force the update command (Even if the database structure matches)
-o|--override      Override running or stalling updates
2019-02-24 12:24:09 +01:00
Michael 4bad2645e5 We should execute the worker job for normal situations ;-) 2019-02-24 10:52:40 +00:00
Michael ee300a7db6 Ensure that the database update will be processed anyway 2019-02-24 10:43:29 +00:00
Philipp Holzer 7ce549c294
fixing delete 2019-02-24 10:27:56 +01:00
Philipp Holzer 9b07132b80
Fixing force-flag for lock-releasing 2019-02-24 10:08:28 +01:00
Hypolite Petovan 7e499647e3 Add System::jsonError method for ajax call returns 2019-02-23 17:32:40 -05:00
Michael 7703875b55 Fixes "Undefined property: Friendica\App::$queue" 2019-02-23 16:08:02 +00:00
Hypolite Petovan 44953f045e
Merge pull request #6730 from nupplaphil/dba_reconnect
DBA::(re-)connect fix for basePath
2019-02-23 08:45:31 -05:00
Hypolite Petovan 1a0398a5b3
Merge pull request #6723 from nupplaphil/issue/6658-worker_id
Adding worker ID to log
2019-02-23 08:38:08 -05:00
Philipp Holzer a73235b6ee
Fixing DBA::(re-)connect() 2019-02-23 12:49:56 +01:00
Philipp Holzer 8760d89eb8
reverting back workerLogger to Logger 2019-02-23 10:24:22 +01:00
Philipp Holzer 5b2f394e3e
Fixing #issuecomment-456403983 2019-02-23 10:16:07 +01:00
Philipp Holzer 40e9bbeb88
cleanup 2019-02-23 00:53:31 +01:00
Philipp Holzer 13807129aa
fixing preload adapter 2019-02-23 00:23:41 +01:00
Philipp Holzer 1dee89f215
fixing tests and preload config 2019-02-23 00:09:57 +01:00
Philipp Holzer 8d56fb8fbe
bugfix marking of db-values 2019-02-22 23:57:04 +01:00
Philipp Holzer b47fc97b06
readded note 2019-02-22 23:55:13 +01:00
Philipp Holzer 16863c5d82
switched back to logger 2019-02-22 23:53:20 +01:00
Philipp Holzer 8c3aebc376
Bugfixings in Config
- replaced usage of "!<unset>!" with null-returns
- fixed bool settings (0/1)
- fixed overriding config-values
- fixed basepath problems
2019-02-22 23:51:13 +01:00
Philipp Holzer 9c12f3f226
Formatting logger to new style 2019-02-22 20:41:13 +01:00
Philipp Holzer cec6f49023
Removed unused code 2019-02-22 20:24:10 +01:00
Philipp Holzer ee37632695
Adding worker id & functionname to worker logs 2019-02-22 20:10:27 +01:00
Hypolite Petovan 4375edd63e
Merge pull request #6719 from annando/worker-scheduler
New scheduler mechanism - now to the correct branch
2019-02-21 16:12:19 -05:00
Michael 7810227040 Reverted test stuff 2019-02-21 19:34:12 +00:00
Michael 3450f12cba Changed log calls 2019-02-21 19:32:31 +00:00
Philipp Holzer c2176aad36
bugfix 2019-02-18 14:45:24 +01:00
Philipp Holzer 5127a113aa
set config_loaded with uid 2019-02-18 14:40:35 +01:00
Philipp Holzer 1194e9b41e
set config_loaded with uid 2019-02-18 14:34:30 +01:00
Philipp Holzer 5157084969
negative set 2019-02-18 14:10:04 +01:00
Philipp Holzer 2fc81898da
Preload Adapter Fix 2019-02-18 14:02:09 +01:00
Philipp Holzer f536107911
Fixing value check for configuration 2019-02-18 11:29:51 +01:00
Philipp Holzer 86aaa6565e
Fixing saveLog() 2019-02-18 11:29:51 +01:00
Philipp Holzer a3d6062476
check if value is set
get basepath with config instead cache
2019-02-18 11:29:42 +01:00
Hypolite Petovan 256e845c5d
Merge pull request #6641 from nupplaphil/config_followup
Config FollowUp
2019-02-17 17:56:31 -05:00
Philipp Holzer 0a318925a4
bugfixing adapter get() in case of no connection 2019-02-17 20:44:14 +01:00
Philipp Holzer ad1254c49c
performance improvement in case of db-load 2019-02-17 20:44:14 +01:00
Philipp Holzer e1d9d67632
renamed Logger::setLogger() to Logger::init() 2019-02-17 20:44:08 +01:00
Philipp Holzer 80f1feabe5
Refactoring Logging to use Configuration 2019-02-17 20:43:52 +01:00
Philipp Holzer eafcf3592d
Config FollowUp
- New Configuration (Config is now only holding the instance)
- New PConfiguration (PConfig is now only holding the instance)

- Config & PConfig-Adapter don't need "ConfigCache" anymore

- DB-Connection is now outside App->reload() for better dependency-chaining
2019-02-17 20:40:27 +01:00
Michael a1a1367d6e Added function description 2019-02-17 19:20:24 +00:00
Michael 061d959e7f Code cleanup 2019-02-17 18:55:17 +00:00
Michael 01d6ba85ff The number of workers per priority is now calculated dynamically 2019-02-17 03:22:29 +00:00
Philipp Holzer d87a6e5a67
fixed line intends 2019-02-17 02:09:39 +01:00
Philipp Holzer 88fd871844
refactoring & test fixing 2019-02-17 01:18:21 +01:00
Philipp Holzer 0a7861da65
Dependency of callstack moved one layer up 2019-02-16 23:17:10 +01:00
Philipp Holzer 5e6e1a8025
Introducing Profiler 2019-02-16 23:11:30 +01:00
Philipp Holzer 11a7f97fe7
friendica-6667 Installer needs to check fileinfo module 2019-02-16 22:17:34 +01:00
Michael 0845089a0f New scheduler mechanism 2019-02-16 15:03:37 +00:00
Philipp Holzer b321ef776d
added type-hint 2019-02-14 17:54:34 +01:00
Philipp Holzer 347d959f25
fixing #6652 Manual installer bricked 2019-02-14 17:44:17 +01:00
Michael ca529d9de7 The process id is currently not supported. 2019-02-14 13:30:41 +00:00
Michael e20a675953 The setting "worker_fetch_limit" now only has an impact on high priority processes 2019-02-14 06:53:04 +00:00
Michael f6e8246e75 Ensure that "strtotime" returns the correct timestamp 2019-02-12 06:42:45 +00:00
Hypolite Petovan 5cf5f33a1c
Merge pull request #6640 from annando/worker-stats
Fix worker statistics
2019-02-11 22:00:55 -05:00
Michael 742b472994 Fix: Workerqueue processes had been killed too early 2019-02-11 22:39:59 +00:00
Hypolite Petovan d6a82c6c2d
Merge pull request #6638 from Ixiter/develop-markdown-anchors
ACL network - fixed preselected acl items
2019-02-11 07:23:32 -05:00
Peter Liebetrau 3dede5dbd2 ACL network - fixed preselected acl items 2019-02-11 10:00:42 +01:00
Michael f65b35901e Fix worker statistics 2019-02-11 08:59:14 +00:00
Michael 5fc6c0ef38 Fix: Corected config value name 2019-02-11 04:39:24 +00:00
Philipp Holzer 199ceeadbf
Adding ConfigCacheLoaderTest 2019-02-10 13:39:48 +01:00
Philipp Holzer 2a42f8dded
Adding ConfigCacheTest 2019-02-10 12:30:13 +01:00
Hypolite Petovan b2c2971551
Merge pull request #6619 from annando/worker-again
Furtner improval of the worker speed
2019-02-09 19:50:35 -05:00
Michael 171cfe8f44 Furtner improval of the worker speed 2019-02-09 23:10:15 +00:00
Hypolite Petovan 337c02bd80 Cache config adapter connection status to reduce number of calls to DBA::isConnected() 2019-02-08 20:12:07 -05:00
Hypolite Petovan 3aa77685fc
Merge pull request #6611 from annando/worker-performance
Improved worker performance (changed keys, changed queries)
2019-02-08 17:46:04 -05:00
Michael 5e5a2c3cc1 Improved worker performance (changed keys, changed queries) 2019-02-08 21:48:41 +00:00
Philipp Holzer cb791024e4
Refactor ConfigMockTrait to mocked ConfigCache 2019-02-07 20:44:03 +01:00
Hypolite Petovan e6a7c52f7d
Add missing App parameter in addon (un)install calls
Follow-up to #6581 
Fixes https://github.com/friendica/friendica/issues/6386#issuecomment-461080531
2019-02-06 22:28:17 -05:00
Hypolite Petovan a0b14a46cb
Merge pull request #6581 from nupplaphil/config_refact
Config Refactoring
2019-02-06 09:57:41 -05:00
Michael b0411b46c4 Separate config options to display the worker jobs per minute 2019-02-06 07:37:45 +00:00
Philipp Holzer fcd7627c49
method refactoring & docblock 2019-02-06 00:02:25 +01:00
Philipp Holzer 7947db8537
codeblock updates 2019-02-05 23:58:38 +01:00
Philipp Holzer 3cd654e76f
bugfixing ini-loading 2019-02-05 23:47:40 +01:00
Philipp Holzer 62c79e1c4f
codeblock updates 2019-02-05 23:42:49 +01:00
Philipp Holzer d9e38be4df
Creating legacy config loading method 2019-02-05 23:36:01 +01:00
Philipp Holzer b79bd63231
move isDirectoryUsable to System 2019-02-05 22:30:18 +01:00
Philipp Holzer 6a9d73f7d9
Refactoring ConfigCacheLoader methods 2019-02-05 22:27:57 +01:00
Philipp Holzer 800dbc7f44
Removed implicit ::getApp() instance and added docblock 2019-02-05 21:54:55 +01:00
Philipp Holzer 4b82e47034
Moved addon directory constant 2019-02-04 09:33:55 +01:00
Philipp Holzer f779110154
Updating type-hints and some naming conventions 2019-02-04 09:32:13 +01:00
Philipp Holzer d78ac57514
Updating type-hints and some naming conventions 2019-02-04 09:30:48 +01:00
Philipp Holzer 1c51d7d22f
Typo at addon-directory-name ... 2019-02-04 02:21:23 +01:00
Philipp Holzer bdfe0c35fb
Typo at addon-directory-name ... 2019-02-04 02:14:20 +01:00
Philipp Holzer f2f8c97b7c
Bugfixing Addon-config 2019-02-04 02:06:15 +01:00
Philipp Holzer d6dd74690d
Bugfixing Config output for memcached_hosts[] 2019-02-04 01:19:01 +01:00
Philipp Holzer 90e88d6c35
Bugfixing AutomaticInstallation test 2019-02-04 00:04:16 +01:00
Philipp Holzer bc73d4bd2b
Adding descriptions 2019-02-03 23:39:30 +01:00
Philipp Holzer f3da5b3a2f
Bugfixing PConfig 2019-02-03 23:22:05 +01:00
Philipp Holzer 1e0e1674f2
4) Adding Factories to other entrypoints 2019-02-03 22:46:50 +01:00
Philipp Holzer 4af0119b73
3) Introducing ConfigFactory 2019-02-03 22:22:04 +01:00
Philipp Holzer 5c50684b50
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:32:31 +01:00
Philipp Holzer f40c57fc20
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:05:44 +01:00
Philipp Holzer d43a8184f4
2) Refactor App->config[] into Core\PConfig 2019-02-03 19:04:41 +01:00
Philipp Holzer be6b229534
1) Refactor App->config[] into Core\Config 2019-02-03 18:54:25 +01:00
Philipp Holzer 433d6abe8c
Refactoring DBA-mocking tests
- Reducing DB-dependencies
- Creating DB-cache mocks
- Creating DB-lock mocks
- Switching to mocked dependencies for Cache/Lock/App
2019-02-02 19:03:15 +01:00
Hypolite Petovan 64847e7cc8 Fix types in doc blocks/prototypes 2019-01-23 09:06:58 -05:00
Hypolite Petovan 25b8628762 Fix missing new in throw calls in Core\StorageManager 2019-01-21 11:12:51 -05:00
Hypolite Petovan 78931afa6f Fix error message in Console\GlobalCommunityBlock 2019-01-21 11:12:50 -05:00
Hypolite Petovan 7f2dc40601 Fix potential bugs without expected behavior change
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Philipp Holzer 1b802548b2 revert phpdoc change 2019-01-21 10:54:41 -05:00
Philipp Holzer 9e0be97703 Bugfixing legacy loglevel 2019-01-21 10:54:41 -05:00
Philipp Holzer 282507922a Reset map function name 2019-01-21 10:54:41 -05:00
Philipp Holzer b5afd2a21d change regex for fail2ban 2019-01-21 10:54:40 -05:00
Philipp Holzer aa15c0e094 Bugfixing Monolog
- Default Loglevel for logs set to 'info'
- Default config level is set to 'notice'
- using 'notice' for auth-failures
- Bugfixing wrong usage of legacy 'log()'
2019-01-21 10:54:39 -05:00
Hypolite Petovan 4a95ca280d Remove unused code
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
Hypolite Petovan d1c6ec9718 Update namespaces declaration in include/
- Remove unused use statements
- Add required use statements
2019-01-21 10:44:45 -05:00
Hypolite Petovan 14e4ab544a Update namespace use calls in mod/ 2019-01-21 10:44:21 -05:00
Hypolite Petovan cb3f09ae4f Refactor namespaces
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
Hypolite Petovan 070aa016e0 Update more PHPDoc, including in include/ 2019-01-21 10:39:28 -05:00
Hypolite Petovan af9067a381 Update PHPDoc in mod/ 2019-01-21 10:39:27 -05:00
Hypolite Petovan 3282ce5389 Fix PHPDoc comments project-wide 2019-01-21 10:35:51 -05:00
Philipp Holzer 2e602afd3e Add Monolog 2019-01-21 10:10:40 -05:00
fabrixxm 518f28a7bf Small fixes
- Avoid an intermediate variable
- Use `rawContent()` in `Attach` module
- Small typo
2019-01-21 10:08:09 -05:00
Hypolite Petovan 2f49c4a058 Revert "Add monolog" 2019-01-21 10:08:09 -05:00
fabrixxm 24d7ffa3fe Update "storage" console command
add support to move data in 'attach' table
2019-01-21 10:00:48 -05:00
Philipp Holzer 6e48df2163 Refactor Loglevels 2019-01-21 10:00:46 -05:00
Philipp Holzer 6150c2fa9c Bugfixing 2019-01-21 09:59:11 -05:00