Commit Graph

1536 Commits

Author SHA1 Message Date
Hypolite Petovan 9788984b06 Move calls to json_encode from Smarty templates to variable lists
- Address https://github.com/friendica/friendica/issues/12011#issuecomment-1518577079
2023-04-23 00:29:08 -04:00
Hypolite Petovan 261ba161a2 Convert ContactResult->url parameter to UriInterface 2023-04-20 07:43:17 -04:00
Michael f0d8b109fe Preparation for Tumblr 2023-04-18 19:30:28 +00:00
Philipp 97e897a9ca
Update System.php 2023-04-01 23:00:43 +02:00
Philipp 1d328f4c76
Adapt logging & temppath creation 2023-04-01 20:12:02 +02:00
Hypolite Petovan 508807af1c Fix namespace issue with posix function in Worker\Repository\Process
- [Composer] Add ext-posix dependency
- [Composer] Sort latest added dependencies alphabetically
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1492842672
2023-04-01 09:25:19 -04:00
Philipp c77266de98
Merge pull request #12952 from MrPetovan/bug/fatal-errors
Address a few fatal errors
2023-03-31 14:35:37 +02:00
Hypolite Petovan bc7bf77096
Merge pull request #12956 from annando/server-blocked
Don't search for contacts on blocked or failed systems
2023-03-29 14:58:12 -04:00
Michael f0743e4e12 Allow the search for contacts on blocked servers via web 2023-03-29 18:39:21 +00:00
Michael e6ce165bb5 Use the correct ids for the search results 2023-03-28 10:06:41 +00:00
Hypolite Petovan b268fa60e7 Add explicit parameter to IHandleUserSession->setvisitorContacts
- Convert some remaining $_SESSION references to object calls
- Address part of https://github.com/friendica/friendica/issues/12486#issuecomment-1428489772
2023-03-27 21:31:54 -04:00
Philipp c2d11328cc
adapt minor changers / fix tests 2023-03-27 19:36:14 +02:00
Philipp 36e21cacc9
Apply suggestions from code review
Switch to `isWritable`

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-03-27 19:36:14 +02:00
Philipp e072c9985e
Fixup and adding tests 2023-03-27 19:36:13 +02:00
Philipp fa9c3d40be
Add conditional help text for disabled fields 2023-03-27 19:36:13 +02:00
Philipp 76f3b07033
Disable setting fields in case we use environment variables 2023-03-27 19:36:13 +02:00
Josh Soref 04cbbcd2ff spelling: phppath
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 20:04:07 -04:00
Josh Soref a4a95d0b41 spelling: enabled
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 20:03:51 -04:00
Josh Soref 3f34b0633f spelling: type
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:14:16 -04:00
Josh Soref 4206a8de3b spelling: targeting
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:14:16 -04:00
Josh Soref 3fcd546151 spelling: structure
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:14:16 -04:00
Josh Soref 7dfdcf66e4 spelling: recipient
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:14:16 -04:00
Josh Soref 035f3fed25 spelling: intended
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref 0da14c11c6 spelling: highly
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref f6fda5840d spelling: failure
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref 9369691713 spelling: existence
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref 23f2bd1a2d spelling: encouraged
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref 4139134cfd spelling: effectiveness
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref c7b358f446 spelling: attachment
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:22 -04:00
Josh Soref abbea6f002 spelling: and
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:22 -04:00
Michael 72952d2c92 Issue 11535: Automatically open and close the registration 2023-03-21 21:44:26 +00:00
Hypolite Petovan 241a512589 Ensure FactorySession->create returns an object no matter what
- Rename redundant method name createSession
- Add exception logging
2023-03-18 23:36:07 -04:00
Michael 54d5f2df43 More reliable system variables 2023-03-15 21:16:21 +00:00
Michael bd3120d6cb Use non static logger call 2023-02-27 07:02:06 +00:00
Michael 2b513a48c7 Catch all errors thrown by "fetchRaw" 2023-02-26 14:08:33 +00:00
Philipp 41251458a0
language and static 2023-02-20 17:23:01 +01:00
Philipp d772331b91
Fix multiple serialized values 2023-02-20 17:22:59 +01:00
Philipp f0c29edcde
Adapt BaseURL calls to new UriInterface 2023-02-18 21:12:21 +01:00
Philipp dbb7022ca5
Refactor Installer due new BaseURL logic 2023-02-18 21:12:20 +01:00
Michael baf75adfca Some loglevels are adjusted to more reasonablöe levels 2023-02-16 20:47:37 +00:00
Philipp 3894b6fa41
Fix logic 2023-02-13 11:34:32 +01:00
Philipp 4dc164a5a1
manually check and create the Config table before running the update 2023-02-12 16:44:56 +01:00
Philipp aeb3c7e96c
don't try to use the Config table if it doesn't exist 2023-02-12 16:23:51 +01:00
Philipp a9c0636573
remove maybeSerialize (always serialize) 2023-02-12 15:48:41 +01:00
Philipp 2d090f0d80
adhere php-cs 2023-02-12 13:17:55 +01:00
Philipp a153c3f594
Fix and adapt tests 2023-02-12 13:09:14 +01:00
Philipp 23742c22c3
suppress E_WARNING at tests with vfs:// 2023-02-12 11:41:20 +01:00
Philipp 7895024e75
add license 2023-02-10 14:54:17 +01:00
Philipp 513ef03421
Revert node.config.php into Config table 2023-02-10 14:06:22 +01:00
Philipp 98857f8d7a
Add exception if lock wasn't successful 2023-02-10 14:06:21 +01:00
Philipp 9627af924a
Add support for toString/Serializable 2023-01-21 19:42:48 +01:00
Philipp 5358e195d7
Fix Introspection 2023-01-17 20:11:48 +01:00
Philipp 8eed43a7dd
Add whitespace .. 2023-01-17 19:23:20 +01:00
Philipp 3b262f44a3
Adhere feedback 2023-01-17 19:15:37 +01:00
Philipp eed6db2465
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-17 19:12:33 +01:00
Philipp 293c121c48
Adhere PHP-CS.. 2023-01-16 22:25:26 +01:00
Philipp f609e38600
Introduce new Hook logic
- InstanceManager for computing strategies and to allow decorators
- Adapting Core\Logger to use it
2023-01-16 22:20:33 +01:00
Philipp ab6efea9b2
Replace Config-Cache dependency with Config-Model (no more DB-waiting necessary) 2023-01-15 16:17:08 +01:00
Hypolite Petovan 21f172c585
Merge pull request #12674 from nupplaphil/bug/config_typesafe
Config: Improve the node.config.php transformation
2023-01-15 09:38:29 -05:00
Philipp bc60eb6cb7
Apply feedback and describe the encoding method 2023-01-15 11:57:43 +01:00
Philipp 4c28f9cf9c
Config: Improve the node.config.php transformation
- Add more types
- Improvement for assoziative arrays and key-value arrays
- Add a lot more tests
2023-01-15 00:53:51 +01:00
Hypolite Petovan e73adde5fb Remove App dependency from Hook::callSingle
- This was causing a circular dependency with the logger_instance hook
2023-01-14 10:38:37 -05:00
Philipp fef10e8a57
Improve encapsulation 2023-01-11 22:00:29 +01:00
Philipp 11a8bd17e3
Assure that deleted cat/keys are working as expected
- A deleted cache-key would delete a merged cache-key as well
- Deleting a key in the Model results in reloading the config to assure any value from underlying files
2023-01-11 21:53:34 +01:00
Philipp fd882abd80
Revert Cache delete() behavior to stable version 2023-01-11 21:10:59 +01:00
Hypolite Petovan 3966b58965 Only show line number if it's provided in System::callstack
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1377373973
2023-01-10 10:41:20 -05:00
Hypolite Petovan 4d5d8e5b64 Add line number to output in System::callstack 2023-01-09 16:06:22 -05:00
Philipp 979672a3c1
Filter disabled addons with "null" 2023-01-08 02:49:56 +01:00
Philipp 5ea50a9e81
Fix "null" addon list 2023-01-08 02:49:56 +01:00
Philipp 2293ff6206
Add test for Addon failures 2023-01-08 02:49:56 +01:00
Philipp 0429a4e429
Fix loading empty node.config.php 2023-01-08 02:49:56 +01:00
Philipp 6aaf1ea5d4
Fix addons problem more elegant 2023-01-07 20:49:29 +01:00
Philipp 9fb5b95b5e
Fix other foreach() troubles at Addon.php 2023-01-07 19:54:59 +01:00
Philipp 6454c1dee7
Don't ksort() on null 2023-01-07 19:52:43 +01:00
Philipp 6bd1740a94
omg .. wrong assertion .. 2023-01-07 15:49:55 +01:00
Philipp 6e4e2c4a82
Fix warning text 2023-01-07 15:30:45 +01:00
Philipp 6e0d16f22b
Add warning message in case node.config.php isn't writable 2023-01-07 15:16:55 +01:00
Philipp 80e8f4aa34
Execute critical worker tasks, even if we're in daemon mode 2023-01-07 13:43:16 +01:00
Philipp 5b2e02889e
Fix Update::run() 2023-01-06 17:50:56 +01:00
Philipp baf3225916
Apply Update::check() suggestions 2023-01-06 12:50:14 +01:00
Philipp c35fd68ec2
Adapt doc 2023-01-06 12:47:00 +01:00
Philipp beb3d376b2
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:46:06 +01:00
Philipp 05048d4abf
Update src/Core/Config/ValueObject/Cache.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:43:04 +01:00
Philipp 70704ccb19
Update src/Core/Update.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:42:56 +01:00
Philipp 9462bfa763
Update src/Core/Config/Util/ConfigFileManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:42:43 +01:00
Philipp b3772163d8
Add doc 2023-01-06 03:06:11 +01:00
Philipp ce8c820221
add description 2023-01-06 02:54:34 +01:00
Philipp d53cb31869
Update src/Core/Config/Util/ConfigFileManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 02:16:35 +01:00
Philipp e14050491a
Config fixing
- unlock/close the `node.config.php` in every circumstances
2023-01-06 01:10:57 +01:00
Philipp 5aa8e8adf1
Config fixings
- Delete now really overwrites static default/setting.config.php keys
- Delete now really overwrites static default/setting.config.php categories
- The Update::check() routine is added to different places
- Merge the given config file with the new config before writing
- Remove ConfigTransaction::get() because it's no more reliable
2023-01-06 01:03:00 +01:00
Philipp cdd57275eb
Some improvements
- Move $_SERVER into ConfigFileManager constructor
- Rename "creatConfigFileLoader" to "createConfigFileManager"
- Rename variable "loader" to "manager" in all tests
2023-01-06 01:03:00 +01:00
Philipp b4096251ba
Check 'config' table as fallback for migrations 2023-01-06 01:03:00 +01:00
Philipp 4b17d6f3bf
Update src/Core/Addon.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-04 23:12:41 +01:00
Philipp 01403d15c4
sort addon array 2023-01-04 21:55:51 +01:00
Philipp 13b234d279
Use addons config entries instead of the addon table 2023-01-04 21:55:51 +01:00
Philipp dce86be58e
Just commit config transactions if something changed 2023-01-04 19:55:22 +01:00
Philipp aabe39220d
Make flock writing easier 2023-01-04 08:16:40 +01:00
Philipp c057954896
Make BaseURL check/save transactional and make the whole process easier 2023-01-04 08:14:00 +01:00
Philipp 17105cf7d1
Fix config read/write locking 2023-01-04 00:25:18 +01:00
Philipp 176af67e88
Fix empty fetchResult curResult at Link::fetchMimeType (thx to Marco R.) 2023-01-03 21:06:16 +01:00