Commit Graph

786 Commits

Author SHA1 Message Date
Michael Vogel 449305e527 Fix the processing of event activities 2019-06-23 00:38:52 +02:00
Hypolite Petovan f0849b0a93
Merge pull request #7284 from annando/fix-fatal
Don't send activities to "null" endpoints
2019-06-19 23:42:21 -04:00
Michael 2e4e8bdf0a Don't send activities to "null" endpoints 2019-06-20 03:06:34 +00:00
Michael 4ab772ed67 Issue 6477: Automatically repair self contact avatar 2019-06-19 17:05:29 +00:00
Michael 496910e750 Issue #5983: Ignore reshares from blocked and ignored contacts 2019-06-17 11:55:19 +00:00
Michael Vogel 097ecdd106
Merge pull request #7266 from MrPetovan/bug/notices
Add type-hint in ActivityPub\Receiver::fetchObject to catch wrong type coercion
2019-06-14 15:03:30 +02:00
Michael e4efddbabb Avoid a notice in AP Receiver 2019-06-14 02:58:40 +00:00
Hypolite Petovan 66d4f1d40b Add type-hint in ActivityPub\Receiver::fetchObject to catch wrong type coercion 2019-06-13 19:07:39 -04:00
Hypolite Petovan 94a70f54d1 Normalize the datetime format of received activity before DB insertion in ActivityPub\Processor
- Restore private message storage
2019-06-12 21:02:37 -04:00
Hypolite Petovan 9e24b8c55f Fix formatting and PHPDoc in ActivityPub\Processor
Add expected return value to postMail method
2019-06-12 21:01:44 -04:00
Michael a11b258fd6 Issue 7223: Don't strip links 2019-06-11 20:34:21 +00:00
Michael 9d8f01c49c Fix another fatal error 2019-06-11 06:02:18 +00:00
Philipp 32b8c6f65e
Merge pull request #7200 from annando/tag-process
Process incoming tag add requests
2019-05-28 19:43:23 +02:00
Michael ecf4789cc4 Process incoming tag add requests 2019-05-26 11:20:03 +00:00
Philipp 6ceb74c365
Merge pull request #7184 from annando/add-tag
AP: We now transmit "add tag" activity
2019-05-26 08:14:18 +02:00
Michael 32b1f75ece AP: We now transmit "add tag" activity / On Diaspora this is now supressed 2019-05-25 19:33:58 +00:00
Hypolite Petovan 7bbaf0757f Revert sending ActivityPub follow reject on Model\Contact::addRelationship failure 2019-05-20 16:33:09 -04:00
Hypolite Petovan ea77f214d7 Add return value to Model\Contact::addRelationship to remove protocol-specific code from it 2019-05-20 15:29:20 -04:00
Hypolite Petovan 10dfe4347b Ensure follow reject/accept object IDs are strings to avoid JsonLD normalize errors in ActivityPub\Transmitter 2019-05-20 15:29:20 -04:00
Hypolite Petovan 3114754f4b Refactor Model\Contact::addRelationship
- Remove unused parameter $item
- Replace q() call with DBA::insert
- Update check on $contact that can only be an array now
- Add moethod doc block
2019-05-20 15:29:20 -04:00
Hypolite Petovan fc312e4c98
Merge pull request #7153 from annando/ap-mail-delivery
Fix receiver list for mails
2019-05-18 11:50:10 -04:00
Michael Vogel 69e38c2bbd Missing arrrrr! 2019-05-18 17:34:44 +02:00
Michael Vogel f3c2eb5b11 Fix receiver list for mails / only deliver mail via DFRN to legacy contacts 2019-05-18 11:09:13 +02:00
Michael 490e850b48 Fix for receiving direct messages from Mastodon 2019-05-18 07:00:57 +00:00
Michael d81b7c840e Adding missing spaces 2019-05-17 18:00:00 +00:00
Michael f6fc70c4e2 Make AP "direct messages" more compatible to Mastodon 2019-05-17 17:58:42 +00:00
Hypolite Petovan 1cf9a1ab7c Allow null $tags parameter in ActivityPub\Processor::constructTagString 2019-05-16 18:10:42 -04:00
Michael 3f55f93606 AP: We can now receive "direct messages" (aka "mails") as well 2019-05-16 05:44:59 +00:00
Michael 87b98b8249 Sending direct messages via AP does work now - receiving is pending 2019-05-14 17:50:45 +00:00
Michael 9e31b1b486 Don't attach images to the body if it was from a Friendica system 2019-05-13 19:56:46 +00:00
Michael 55557a8f18 Contacts with protocol = AP are now delivered only via AP 2019-05-11 05:58:22 +00:00
Michael 74a25707e1 Filling the protocol on ap contact action 2019-05-05 11:02:19 +00:00
Michael Vogel 2365193691 AP: Support of request messages 2019-05-05 11:17:45 +02:00
Michael Vogel 56d2df04f0 Don't switch Friendica contacts to AP 2019-05-03 07:10:02 +02:00
Michael 9941c33123 Removing a contact request needn't to be one not approved requests 2019-05-02 20:04:15 +00:00
Michael 8adf0e6e5c Removed test logging 2019-05-02 13:46:12 +00:00
Michael 28f316b7e4 Replace the legacy DFRN connection process with AP 2019-05-02 13:05:31 +00:00
Michael Vogel 581895c07d Preparation for switching the connect mechanism from DFRN to AP 2019-04-30 20:07:20 +02:00
Michael eef85584c2 AP: Parsing of messages from Pleroma should work now again 2019-04-26 06:17:37 +00:00
Michael Vogel c439cb656a
Merge pull request #6957 from MrPetovan/bug/6943-add-tombstone
Send AP Tombstone activity on deleted profiles
2019-04-04 22:27:49 +02:00
Hypolite Petovan 5b12bccb45 Move user tombstone activity data to ActivityPub\Transmitter 2019-04-04 07:38:40 -04:00
Michael e66e2adf5f AP: Incoming announces are now stored as activities 2019-04-02 21:10:49 +00:00
Michael 198e150ba8 Archive inboxes after 5 days of delivery failures 2019-03-25 21:51:32 +00:00
Michael 2788995ab0 The "summary" field seems to be interpreted as plain text only 2019-03-18 22:38:10 +00:00
Michael 2cdd5a4940 Fixes errors/notices 2019-03-17 22:13:17 +00:00
Michael f78c148013 Clarified return values 2019-03-17 15:49:21 +00:00
Michael 75ec384fc3 Added logging since this exixted before 2019-03-17 13:56:47 +00:00
Michael cec094c5b1 Centralise the item content processing in a single function 2019-03-17 13:50:14 +00:00
Michael 0104da3c93 Summary has to be converted to HTML / Don't use summary when we have the source 2019-03-17 00:06:31 +00:00
Michael dfcf1b1e6f We now send a summary via AP. This partially fixes the problem with Mastodon and Articles 2019-03-16 08:46:33 +00:00
Michael 4ff837488f Issue 6167: Don't publish non visible content 2019-03-15 20:31:07 +00:00
Michael cd0d6cb626 Forums now are working with AP as well 2019-03-14 18:44:41 +00:00
Hypolite Petovan d0b2ed7966 Remove test code in ActivityPub\Processor 2019-03-09 09:04:43 -05:00
Hypolite Petovan 70782b3977 Fix implicit mention detection regular expression flags in ActivityPub\Processor 2019-03-09 09:04:11 -05:00
Michael a911baf8e5 Avoid transmitting a deletion message when we don't have a key 2019-03-04 06:52:43 +00:00
Hypolite Petovan 3e290da8c2 Code standards: Add missing space in ActivityPub\Processor 2019-02-25 03:16:18 -05:00
Hypolite Petovan 1f6e0f168c Add missing author contact in ActivityPub\Processor
- Add logging for future occurrences
- Addresses https://github.com/friendica/friendica/issues/6338#issuecomment-466812104
2019-02-24 15:52:03 -05:00
Hypolite Petovan 67aa188830 Improve Logger calls
- Add context in various calls
- Remove deprecated Logger::log call in Processor
2019-02-23 17:32:13 -05:00
Hypolite Petovan cb78e77850 Fix implicit mentions in outgoing ActivityPub posts
- Add usage of system.disable_implicit_mentions to disable implicit mention behavior
- Add usage of item own implicit mentions to be prepended to the outgoing body
2019-02-23 17:32:12 -05:00
Hypolite Petovan 3ac8576c8e Fix implicit mentions in incoming ActivityPub posts
- Use thr-parent instead of parent-uri to retrieve implicit mentions to remove from body
- Add potential implicit mentions to 'tags' array for storage in Processor::convertImplicitMentionsInTags()
- Add usage of system.disable_implicit_mentions to disable implicit mention behavior
2019-02-23 17:32:12 -05:00
Hypolite Petovan 0cc0df9e3e Rename system.disable_mentions_removal config key to system.disable_implicit_mentions
- Update configuration key description
2019-02-23 17:32:11 -05:00
Hypolite Petovan 8c1db51a76 Improve Logger calls
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
Michael ca7ceb6fe2 We should return something ;-) 2019-02-13 17:26:54 +00:00
Michael d4baa25349 New configuration to disable the automatic mentions removal 2019-02-13 17:23:23 +00:00
Hypolite Petovan 63f083f6fb Include new lines in implicit mention regular expression 2019-02-13 08:08:46 -05:00
Michael 3b7e9cc3a2 This now should really prevent sending the follow requests only once 2019-02-10 18:59:05 +00:00
Michael 04f34de3a1 Multiples follows shouldn't be send anymore 2019-02-10 18:42:51 +00:00
Michael 58eaf0ba1c Prevent multiple send follow requests 2019-02-10 18:03:01 +00:00
Hypolite Petovan ed89a22995 Add context to some logger calls in ActivityPub\Processor 2019-02-09 08:34:54 -05:00
Hypolite Petovan e514ecb6fa Prepend implicit mentions to outgoing ActivityPub messages
- Add Transmitter::prependMentions method
- Fix Transmitter::mentionCallback return value when contact isn't found
2019-02-08 23:09:02 -05:00
Hypolite Petovan e352408876 Remove implicit mentions from incoming ActivityPub messages
- Add Processor::getImplicitMentionList and Processor::removeImplicitMentionsFromBody methods
- Rename Processor::constructTagList to Processor::constructTagString
- Add implicit mention skip in Processor::constructTagString
- Invert parameter order in Processor::replaceEmojis
2019-02-08 22:57:35 -05:00
Michael ebe767b290 Hopefully final fix for false notifications 2019-02-07 05:38:43 +00:00
Michael 16bf9c771d The automatic follow request is currently deactivated, due to false notifications 2019-02-06 21:34:44 +00:00
Michael a7963fe18a AP: Automatically send follow requests for reshared items 2019-01-30 21:33:23 +00:00
Michael fc0acd7b1f AP: Debug option to deliver via AP first 2019-01-30 19:33:08 +00:00
Michael fce46f5124 AP: Follow a note to receive all upcoming activities 2019-01-30 16:30:01 +00:00
Michael 2c0ee72064 Ap: Clarify message distribution for forum posts 2019-01-30 13:07:23 +00:00
Michael 030c0b5dc6 Another preparation for forum posts via AP 2019-01-28 06:23:06 +00:00
Hypolite Petovan f8c782380f Remove unused code/use statements 2019-01-23 09:06:58 -05:00
Hypolite Petovan 7f2dc40601 Fix potential bugs without expected behavior change
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
Hypolite Petovan 3d839bb176 Move Contact::ACCOUNT_TYPE_* constants to User::ACCOUNT_TYPE_*
- Keep Contact::TYPE_* constants for comparison with contact.contact-type
2019-01-21 10:56:27 -05:00
Hypolite Petovan ad9c67663d Move Contact::Page_* constants to User::PAGE_FLAGS_* 2019-01-21 10:55:37 -05:00
Hypolite Petovan 4a95ca280d Remove unused code
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
Hypolite Petovan cb3f09ae4f Refactor namespaces
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
Hypolite Petovan af9067a381 Update PHPDoc in mod/ 2019-01-21 10:39:27 -05:00
Hypolite Petovan 3282ce5389 Fix PHPDoc comments project-wide 2019-01-21 10:35:51 -05:00
Michael 70c183b495 AP Bugfix: We hadn't transmitted an tag url at all ... 2019-01-20 23:13:55 +00:00
Michael e2427eb9da We only need to fetch the content once 2019-01-20 22:56:33 +00:00
Michael 9e7c59481f Improved ID detection 2019-01-20 22:19:53 +00:00
Michael e5d694f7fa AP: Only reshare stuff that is AP content 2019-01-20 21:52:43 +00:00
Michael 809e556009 Transmit via BCC if contact is hidden, don't store announces 2019-01-19 16:44:15 +00:00
Michael d813d72b1a Simplyfies AP relaying, fixes relaying of public contacts 2019-01-17 23:06:27 +00:00
Michael aa4aaf1971 Enable communication with Peertube 2019-01-14 12:10:11 +00:00
Michael d113ccd93c Making Friendica compatible to Nextcloud Social 2019-01-13 09:38:01 +00:00
Michael 28f14c7d60 Don't show deleted contacts, changed "pending" behaviour 2019-01-12 13:28:14 +00:00
Michael e3576fa0bd Don't accept private answers to public parents 2019-01-10 22:51:03 +00:00
Michael 1a702359f1 Unfollow should now work with Pleroma again 2019-01-10 07:24:12 +00:00
Michael defc89fa9a Fixing the Accepting of contact requests 2019-01-09 22:30:26 +00:00
Michael fd6c64f9c1 Warning and notice fixed 2018-12-29 09:53:31 +00:00
Hypolite Petovan a8b0aa8c8d Normalize expected format for event fields summary, desc and location
- Remove unnecessary HTML escaping on event submit
- Add HTML escaping on event display
- Add HTML to BBCode conversion for received ActivityPub events
2018-12-24 23:00:35 -05:00
Michael 51bce11b69 Issue 5911: Fix for fetching the correct user 2018-12-03 06:16:25 +00:00
Michael 2fd65503da Avoid database error that the field "guid" is not present in the contact table 2018-12-02 15:01:08 +00:00
Michael ea5ba309dc Some more AP blocking 2018-11-22 22:31:48 +00:00
Michael 2f7b138b09 Block AP delivery 2018-11-22 22:23:31 +00:00
Michael 27d1da0468 One space too much 2018-11-20 20:49:06 +00:00
Michael 5c39779b45 AP: Security check against forged "create" activities 2018-11-20 20:40:47 +00:00
Adam Magness ffc406d819 normalise_link calls
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Michael 077a96fb28 Using CSS for custom emojis 2018-11-08 07:42:19 +00:00
Michael cd2c7f782f We now directly support the custom emojis from Mastodon 2018-11-07 20:34:03 +00:00
Michael e759497af3 Fix small typo / Workerqueue count now only counts non deferred entries 2018-11-04 10:51:01 +00:00
Michael 8f27e3aeb1 Support for fetching non-public content / preparations for forum posts 2018-11-03 21:37:08 +00:00
Michael 1395bdc188 Preparations for a relocation message / fix for notice 2018-11-02 21:57:06 +00:00
Adam Magness 50da89d861 Logger Levels
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness 14fde5dc9b Log function
implement log() function.
2018-10-30 09:57:14 -04:00
Michael 4831688dc0 Diaspora signatures are now stored and transmitted correctly 2018-10-27 14:35:22 +00:00
Michael 73f596cc46 Fixes duplicated transmissions and not working undo of like/dislike 2018-10-27 11:09:23 +00:00
Michael f2ddcbe632 AP: Event participation and editing of posts are now supported 2018-10-27 06:17:17 +00:00
Michael cbc417114d AP: We now transmit and process events 2018-10-26 04:13:26 +00:00
Michael 7f11b2e4e9 Deactivated BCC 2018-10-24 21:04:21 +00:00
Michael f300c8953a We now use bcc for the acl block 2018-10-24 20:06:57 +00:00
Michael 58f82e084d Preparations to work with BCC 2018-10-24 19:19:51 +00:00
Michael c25d60e107 Removed finished work from the comments 2018-10-24 04:51:37 +00:00
Michael e3e714a45f Unsuccessful ActivitiyPub transmission are now deferred 2018-10-23 03:54:18 +00:00
Michael bb3f07b0b7 We now send the previous followers collection as well 2018-10-21 20:49:50 +00:00
Michael 1c54c27784 Bugfix: We hadn't deliverd AP posts to all intended receivers 2018-10-21 06:10:24 +00:00
Philipp Holzer 4392858662
Move Global Functions - Part 3
- Replaced every CACHE definition
- Moved check_url to App->checkURL()
- Removed unused definition "ZCURL_TIMEOUT"
2018-10-20 18:19:55 +02:00
Michael fea48fa85e AP: Transmitting and receiving with non AP contacts 2018-10-20 07:53:45 +00:00
Michael bedab33e0b Fix function naming 2018-10-19 13:08:46 +00:00
Michael cdeb4682ef Use nickname based mentions for AP 2018-10-19 05:27:54 +00:00
Michael 688174e6c0 AP: Fix "null" receiver 2018-10-18 12:25:57 +00:00
Michael 8035bad8e2 AP: Fix a notice / avoid an error when fetched content hadn't been an array 2018-10-18 05:54:44 +00:00
Hypolite Petovan 341b83d1df Fix Undefined index: photo in ActivityPub/Receiver 2018-10-16 18:29:28 -04:00
Hypolite Petovan ce74a4d9a1
Merge pull request #5921 from annando/ap-video
ActivityPub: Rudimentary support for videos
2018-10-14 14:05:51 -04:00
Michael 37ad4a7d22 ActivityPub: Rudimentary support for videos 2018-10-14 17:57:44 +00:00
Hypolite Petovan 59d6dd809d
Merge pull request #5906 from annando/ap-switch
OStatus contacts are now automatically converted to AP
2018-10-14 12:04:52 -04:00
Michael 6be04a73e3 The outbox is now more complete / No more duplicates in the receiver array 2018-10-14 07:47:04 +00:00
Michael e829e074fc Location, coord and app are now processed as well 2018-10-13 21:37:39 +00:00
Michael aab4fa0c31 The instrument is now added, updating AP contacts is now enabled 2018-10-13 20:36:44 +00:00
Michael f60468677e We now transmit location and application as well. 2018-10-13 19:49:20 +00:00
Michael 8b9aa80aad "to" is now used for mentions, "cc" for everything else 2018-10-13 18:59:39 +00:00
Michael efad4936b0 OStatus contacts are now automatically converted to AP 2018-10-13 18:13:01 +00:00
Michael 3c48a1f787 AP: Announce will now work 2018-10-13 16:41:29 +00:00
Michael 5af0ee1b95 We can now store it without any problem 2018-10-12 18:53:13 +00:00
Hypolite Petovan 986528b77f
Revert "We now store the diaspora comment data as well" 2018-10-12 10:35:43 -04:00
Michael 8268288953 We now store the diaspora comment data as well 2018-10-11 20:38:57 +00:00
Michael 1bf7521af8 Store conversation data directly from the AP receiver 2018-10-11 20:08:04 +00:00
Hypolite Petovan 5f9dd11cfb
Merge pull request #5867 from annando/ap-fix-follow
AP: Switchting existing contacts to AP when receiving activities
2018-10-09 16:08:38 -04:00
Michael 0994aaf875 AP: Avoid a misleading log entry / unneeded field removed 2018-10-09 20:00:57 +00:00
Michael c0f26ace2e AP: Switchting existing contacts to AP when receiving activities 2018-10-09 19:58:15 +00:00
Michael b5d73f840c AP fixes: LD-signature, wrong owner for completed thres, account removal 2018-10-09 05:04:24 +00:00
Michael 4047952703 AP: Avoid an empty avatar field 2018-10-08 03:28:49 +00:00
Michael 46f77f3486 Detect the object type 2018-10-07 20:36:15 +00:00
Michael 93866b477a Several fixes 2018-10-07 19:42:04 +00:00
Michael bd6ba98e8d Some more cleanup 2018-10-07 18:41:45 +00:00
Michael 1efca1b75d owner is now actor 2018-10-07 17:35:43 +00:00
Michael 616c4a89bd The new parsing is now active 2018-10-07 17:17:06 +00:00
Michael 36c31e4091 Switching to parsing the JSON-LD 2018-10-07 15:34:51 +00:00
Michael 3a74f3364d Switch to parsing compacted JSON data 2018-10-07 13:37:05 +00:00
Michael 192c6c8d4f Preparation for suggestions under AP 2018-10-06 18:42:26 +00:00
Michael 389a651005 Transmit the Diaspora GUID with activities (Like, Dislike, ...) 2018-10-06 14:02:23 +00:00
Michael a413ce15aa "name" must be plaintext 2018-10-06 13:28:17 +00:00
Michael 6b374c32a2 Improved AP distribution / Only process trusted content 2018-10-06 13:16:52 +00:00
Michael 41123162f1 No @brief anymore 2018-10-06 04:18:40 +00:00
Hypolite Petovan 13c5bc807b
Merge pull request #5829 from annando/develop
Cache the AP delivery process
2018-10-06 00:06:47 -04:00
Michael 9dbf8d0b9d Spaces 2018-10-06 02:09:27 +00:00
Michael 51dbffd396 Cache the AP delivery process 2018-10-05 21:00:40 +00:00
Michael 5d7968bdf3 Avoid to do the follow stuff for the public user 2018-10-05 20:10:10 +00:00
Michael 5ed1c12349 Send a follow request upon contact switch to AP 2018-10-05 19:48:48 +00:00
Michael fa7cddc669 AP Bugfix: Following a soapbox now works / rapid follow/unfollow should work now 2018-10-05 06:35:50 +00:00
Michael 3d74d412b2 Changed attachment handling to improve Mastodon compatibility 2018-10-05 04:04:37 +00:00
Michael 4368c922fb is sensitive 2018-10-04 13:08:11 +00:00
Michael 0ebfa6fc12 Added to-do 2018-10-04 12:57:42 +00:00
Michael 1c615f80c4 Improved return values 2018-10-04 12:53:41 +00:00
Michael 9171b2a0f3 It's possibly better to use context links that do exist 2018-10-04 09:46:29 +00:00
Michael 72fc89d033 Simplified attachment handling 2018-10-04 05:26:00 +00:00
Michael f6277970fa Added some to-do 2018-10-03 19:35:01 +00:00
Michael 11a7f6c3e1 Unused "use" removed 2018-10-03 19:17:40 +00:00
Michael cbfc3d0c28 Fix error / "about" is now converted to BBCode 2018-10-03 19:00:32 +00:00
Michael 221e197658 Tags are now transmitted as expected 2018-10-03 18:27:01 +00:00
Michael a9a1ac808b Attachments do work now 2018-10-03 17:36:55 +00:00
Michael 78a7e130ae Another renamed function 2018-10-03 15:50:21 +00:00
Michael 8841519c0d Renamed functions 2018-10-03 15:41:51 +00:00
Michael 1fe55679fc Moved documentation 2018-10-03 09:53:12 +00:00
Michael acd1caa114 The function is only needed in the same class 2018-10-03 09:45:54 +00:00
Michael 3ab837f3c7 Functionality is now split 2018-10-03 09:15:38 +00:00
Michael 4d2e5c2bbe AP class will be split in processor, receiver and transmitter 2018-10-03 06:15:07 +00:00