Commit Graph

4126 Commits

Author SHA1 Message Date
Philipp Holzer 4733b1e5e0
Fixing PHP Fatal Error for Model\Contact (usage of non available contact) 2019-08-28 01:40:28 +02:00
Philipp Holzer 8688053a08
remove superfluous comment 2019-08-28 01:02:23 +02:00
Michael Vogel 9b7432781b Don't transmit content to already archived contacts 2019-08-27 21:01:11 +02:00
Philipp Holzer df7ec0cdf7
php notice fixings
addons:
- bufferapp (missing errorcode)
- twitter (wrong field name 'nickname')
core:
- bbcode (incomplete attachementdata)
- crypto (uninitialized key)
2019-08-27 08:27:07 +02:00
Tobias Diekershoff 1c3a5e1e6f added USE statement and changed statement as requested in #7305#discussion_r296461181 2019-08-27 07:10:51 +02:00
Philipp Holzer 62f7510aa7
Fixed wrong app reference 2019-08-27 00:03:05 +02:00
Philipp Holzer de7c026590
Some code hardenings for semaphore locking 2019-08-26 23:55:54 +02:00
Michael 7d50a086e0 Issue 7559: Merge contact duplicates 2019-08-26 15:51:56 +00:00
Philipp b914900ff5
Merge pull request #7553 from annando/fatal
Prevent a fatal error for an empty parameter in "unparseURL"
2019-08-23 08:44:51 +02:00
Michael Vogel a892156052 Output better comparable log entries for the worker 2019-08-23 07:23:32 +02:00
Michael Vogel 74d93269da Prevent a fatal error for an empty parameter in "unparseURL" 2019-08-23 07:19:08 +02:00
Hypolite Petovan 20a6b368fb Replace mb_convert_encoding with html_entity_decode for feed item title conversion
- Prevents already UTF-8 strings to be corrupted
2019-08-22 06:00:21 -04:00
Jeroen De Meerleer cf95e0f856 Translating the vcard 2019-08-20 16:38:46 +02:00
Michael 5a1a5a54dc Delivery count now counts the failed delivery attempts as well 2019-08-20 07:39:13 +00:00
Hypolite Petovan 2736aac678 Add missing use statement in Search\Directory
- Fixes https://github.com/friendica/friendica/issues/7297#issuecomment-522346804
2019-08-18 15:21:36 -04:00
Hypolite Petovan 9de59d5c4d Add entry title HTML entities conversion in Protocol\Feed
- Prevents literal entities display in generated post title
2019-08-18 09:37:36 -04:00
Philipp 0f32ab10d8
Merge pull request #7524 from MrPetovan/bug/7337-check-dead-enumeratePermissions
Prune unavailable contacts from AP envelope
2019-08-18 15:17:11 +02:00
Hypolite Petovan 77b754862b
Merge pull request #7533 from nupplaphil/bug/friendica-7299
Fixing wrong defaults() usage
2019-08-18 09:16:25 -04:00
Philipp Holzer bff427174b
Fix parameters for Source 2019-08-18 15:14:03 +02:00
Philipp Holzer b5cb3bc783
Fixing https://github.com/friendica/friendica/issues/7299#issuecomment-521745931 2019-08-18 15:12:10 +02:00
Philipp Holzer b63b1570d6
removed superfluous comment 2019-08-18 15:04:36 +02:00
Philipp Holzer 9d3ad8f435
Fix https://github.com/friendica/friendica/issues/7298#issuecomment-522215746 2019-08-18 14:55:24 +02:00
Hypolite Petovan 1a2628f210
Merge pull request #7528 from nupplaphil/bug/fix_locks
Fix Locks
2019-08-17 14:41:32 -04:00
Philipp Holzer d39a6ba444
Auto-remove duplicated, allowed themes during reload 2019-08-17 20:00:11 +02:00
Philipp Holzer 7e82f8dc2e
fix Admin Theme reload 2019-08-17 19:55:14 +02:00
Philipp Holzer 46655eac70
Remove unnecessary parameter 2019-08-17 19:41:59 +02:00
Philipp Holzer c803dcb6c5
Fix Locks
- Wrong return of lock releasing with DBA provider
- It's not possible to maintain Semaphore locks, since they aren't accessible by other processes
Should solve https://github.com/friendica/friendica/issues/7298#issuecomment-521996540
2019-08-17 19:33:36 +02:00
Philipp Holzer 566889fbc0
fix alignment 2019-08-17 11:08:57 +02:00
Philipp Holzer 2c73377b39
Create Core\Process as a base for followup work 2019-08-17 09:09:13 +02:00
Philipp Holzer 90b438e082
Move mode settings to App\Mode
- Move isAjax() to App\Mode
- Move isTablet() to App\Mode
- Move isMobile() to App\Mode
- Refactor last usage of App->isBackend()
2019-08-17 09:09:13 +02:00
Hypolite Petovan cf8177461e Prune unavailable contacts from AP envelope 2019-08-17 00:00:49 -04:00
Hypolite Petovan 828368267c Add check_dead parameter to Item::enumeratePermissions 2019-08-16 23:59:48 -04:00
Michael Vogel aba23abfaa
Merge pull request #7520 from MrPetovan/bug/7468-contact-search-fan
Suppress relationship string in template vars for public contact
2019-08-17 04:42:59 +02:00
Hypolite Petovan 7a73445503
Merge pull request #7519 from nupplaphil/task/add_page
Add Page class (Frontend code)
2019-08-16 07:30:06 -04:00
Hypolite Petovan e463df6418 Add existence check for contact.uid and contact.rel fields in Contact::getContactTemplateVars 2019-08-16 07:29:34 -04:00
Philipp Holzer eaed327c07
fix indentation 2019-08-16 09:10:05 +02:00
Hypolite Petovan 98b0f97639 Suppress relationship string in template vars for public contact 2019-08-15 21:24:33 -04:00
Michael Vogel 6f944f1e53
Merge pull request #7514 from MrPetovan/bug/7507-allow-protocolless
Allow protocol-less links
2019-08-15 22:07:09 +02:00
Philipp Holzer 30b69f1fc4
some fixings 2019-08-15 20:58:57 +02:00
Philipp Holzer 9f68e6b589
Add Page class for Frontend
- Move frontend logic (stylesheet, footerscript, content) to Page class
2019-08-15 20:52:42 +02:00
Hypolite Petovan feb720a3ee
Merge pull request #7518 from nupplaphil/bug/lock_unlink
Fix Lock-Unlink
2019-08-15 12:11:01 -04:00
Philipp Holzer 2369ea1d50
Fix Lock-Unlink
- Check if .sem file exists before unlinking it
- Fixing https://github.com/friendica/friendica/issues/7298#issuecomment-521670482
2019-08-15 17:55:17 +02:00
Philipp Holzer 822ba67105
Fixing https://github.com/friendica/friendica/pull/7508#issuecomment-521679624 2019-08-15 17:47:08 +02:00
Philipp Holzer 290dd2ab39
moved rest of BaseURL 2019-08-15 17:36:07 +02:00
Philipp Holzer ccbb0241bf
Removed unnecessary auto-initializing 2019-08-15 17:27:05 +02:00
Philipp Holzer 956439a9f2
reverted wrong indentation 2019-08-15 17:25:03 +02:00
Philipp Holzer 734b63adba
Fixed wrong "BaseUrl" class (=> "BaseURL") 2019-08-15 17:23:35 +02:00
Philipp Holzer 08be92a862
Moved BaseURL to App namespace (because similar type as Arguments/Modules/Modes) 2019-08-15 17:23:00 +02:00
Philipp Holzer fa1b783052
removed static Logger usage 2019-08-15 17:10:14 +02:00
Philipp Holzer 4f0ee4df27
Move $page initialization into constructor 2019-08-15 17:04:36 +02:00
Philipp Holzer 55f9dba230
Prepare App for further usage 2019-08-15 17:00:07 +02:00
Hypolite Petovan 48caf55cff
Merge pull request #7515 from nupplaphil/task/console_lock
New Console Command: Lock
2019-08-15 10:31:34 -04:00
Philipp Holzer 9abfd55d37
modified hint 2019-08-15 16:25:34 +02:00
Philipp Holzer 689a2145f6
Add @see for SO link 2019-08-15 16:24:11 +02:00
Philipp Holzer f3269bf826
Add hint for getClass 2019-08-15 16:19:23 +02:00
Philipp Holzer cba9fa2467
Move isBackend logic to App\Mode 2019-08-15 15:51:15 +02:00
Philipp Holzer d95457cf61
Add Lock test 2019-08-15 14:26:05 +02:00
Philipp Holzer e2e109b8c1
Fix getAllKeys() method for memcache instances 2019-08-15 14:26:05 +02:00
Philipp Holzer 41e2031e6b
Console Lock
WIP
2019-08-15 14:26:04 +02:00
Hypolite Petovan 0f9520f520 Increase specificity of default allowed protocols 2019-08-14 21:42:00 -04:00
Hypolite Petovan f88435fa4c Add support for protocol-less URLs in BBCode::convert 2019-08-14 21:40:51 -04:00
Hypolite Petovan 425876316f
Merge pull request #7508 from nupplaphil/task/arguments_module_class_2
Add Arguments & Module class (again)
2019-08-14 07:52:55 -04:00
Philipp Holzer 6546bf5ad6
fix isBackend() 2019-08-13 19:05:32 +02:00
Philipp 23da053cf8
Merge pull request #7512 from annando/cid-forum
Use the contact id whenever we are following the contact
2019-08-13 18:50:10 +02:00
Michael aab6b739d8 Use the contact id whenever we are following the contact 2019-08-13 15:54:47 +00:00
Philipp Holzer b1ae58cdc5
fix tests & remove superfluous parameter 2019-08-13 16:29:16 +02:00
Philipp Holzer 4089e17f85
re-add App::isBackend() 2019-08-13 16:29:12 +02:00
Philipp Holzer 0af9747c6c
Add Arguments & Modules class 2019-08-13 16:29:11 +02:00
Hypolite Petovan f068d00645
Merge pull request #7510 from nupplaphil/bug/Fix_Redis_test
Fix Redis test
2019-08-13 06:41:07 -04:00
Hypolite Petovan 8b00f48c47
Merge pull request #7509 from annando/admin-queue
Improved calculation of deferred tasks
2019-08-13 06:40:21 -04:00
Philipp Holzer b28e11fee8
- Remove deprecated Redis::delete() function 2019-08-13 08:54:26 +02:00
Philipp Holzer 31cfac1cfa
Fix Redis test
- Check if $redis_port is null
2019-08-13 08:32:08 +02:00
Michael Vogel afac4b7698 Improved calculation of deferred tasks 2019-08-13 06:43:08 +02:00
Hypolite Petovan 2f752b18e1
Merge pull request #7505 from annando/admin-queue
Queue numbers corrected, only display 999 queue items
2019-08-12 19:30:57 -04:00
Michael Vogel 3b0767764b Queue numbers corrected, only display 999 queue items 2019-08-12 07:30:33 +02:00
Hypolite Petovan fcb1a78352
Revert "Introduce Arguments / Module class" 2019-08-11 18:01:11 -04:00
Philipp e9fc2af1c3
Merge pull request #7499 from annando/new_defer
Worker: The retrial value can now skip retrial levels
2019-08-11 23:27:54 +02:00
Philipp 541cdcd515
Merge pull request #7503 from MrPetovan/bug/fix-private-permissions
Use contact.network field instead of contact.protocol in Group::expand
2019-08-11 23:26:34 +02:00
Michael Vogel e07a17daf6 Added config value 2019-08-11 23:07:06 +02:00
Hypolite Petovan feb2d94972
Merge pull request #7500 from nupplaphil/task/arguments_module_class
Introduce Arguments / Module class
2019-08-11 16:45:31 -04:00
Hypolite Petovan 5feeffbe79 Use network field instead of protocol in Group::expand
- contact.protocol field isn't systematically populated
2019-08-11 16:41:00 -04:00
Philipp Holzer 11752d7059
move backend constant 2019-08-11 14:33:25 +02:00
Philipp Holzer 2c5ba7fc15
Introduce Arguments / Module class
- move from App
- add tests for Arguments/Module class
2019-08-11 14:24:05 +02:00
Michael Vogel 5c72aeb8d7 Worker: The retrial value can now skip retrial levels 2019-08-11 10:28:52 +02:00
Michael Vogel 35a487ae30 Don't fork worker on frontend by default 2019-08-08 22:42:12 +02:00
Tobias Diekershoff 48b1e172b9
Merge pull request #7487 from MrPetovan/task/7473-trending-tags
Fix trending tags variable name mistakes in Model\Term
2019-08-07 06:44:37 +02:00
Hypolite Petovan 66d4e5ce5f Remove wrap length in Babel HTML::toPlaintext display 2019-08-06 21:23:09 -04:00
Hypolite Petovan 246894f233 Ensure trimmed HTML nodes are text nodes in HTML::toBBCode 2019-08-06 21:22:19 -04:00
Hypolite Petovan 19adb9a1a0 Fix trending tags variable name mistakes in Model\Term 2019-08-06 20:52:54 -04:00
Tobias Diekershoff dc85451b78
Merge pull request #7483 from MrPetovan/task/7474-html-to-bbcode
Fix bug removing spaces between hashtag links in HTML::toPlaintext
2019-08-06 16:50:00 +02:00
Hypolite Petovan 79374dbf7a Fix DOMNodeList length compatibility with PHP <7.2 in Content\Text\HTML 2019-08-06 09:00:32 -04:00
Hypolite Petovan 5dbf319e06 Fix bug removing spaces between hashtag links in HTML::toPlaintext 2019-08-06 08:20:48 -04:00
Hypolite Petovan 3e2f0e9ffa Feedback changes
- Import namespaces in mod/community
- Fix alignment in Content\Feature
- Add phpDoc to Widget\TrendingTags
2019-08-06 07:37:48 -04:00
Hypolite Petovan 9e8ae520b8 Move trending tags queries to Model\Term 2019-08-06 07:36:51 -04:00
Hypolite Petovan 4c45cb864a Update master translation strings file
- Fix gettext warning for empty string in Module\Item\Compose
2019-08-06 07:09:05 -04:00
Hypolite Petovan c399e40618 Add trending_tags additional feature + usage in mod/community 2019-08-06 07:09:04 -04:00
Hypolite Petovan a947bd0889 Add Trending Tags widget + template 2019-08-06 07:09:04 -04:00
Hypolite Petovan 6b7dfd0c71
Merge pull request #7465 from nupplaphil/task/dice_cache_lock
Refactor Cache/Lock to DICE
2019-08-06 07:05:07 -04:00
Tobias Diekershoff 951444e715
Merge pull request #7482 from annando/image-description
Support for multiple picture posts in API and connectors
2019-08-06 08:21:54 +02:00
Michael 27006f577c Support for multiple picture posts 2019-08-06 05:35:21 +00:00
Hypolite Petovan 2ab43f94d8 Revert using LIBXML_NOBLANKS
- This removed all self-closing tags (img, br, etc...) from HTML sources
2019-08-05 20:57:03 -04:00
Michael cbee91a61b Avoid a notice 2019-08-05 16:48:58 +00:00
Michael bdc07b4213 Added support for image descriptions and multiple image posts to external services 2019-08-05 16:27:45 +00:00
Michael Vogel a507963c7f
Merge pull request #7474 from MrPetovan/bug/7457-html-bbcode-plaintext
Fix HTML/BBCode::toPlaintext
2019-08-04 22:08:53 +02:00
Philipp Holzer a66580444f
Fixing sort of BaseURL usage for App & Cache usage 2019-08-04 20:01:15 +02:00
Hypolite Petovan 4a85de4c19 Add HTML output panel to babel module 2019-08-04 10:22:49 -04:00
Hypolite Petovan c3e3e83a52 Improve BBCode:toPlaintext
- Fix issue where matching literal square brackets were removed with their content
- Fix issue where content without line feeds between BBCode tags would end up compacted in plain text
- Update extr calls to BBCode::toPlaintext in api
2019-08-04 10:22:23 -04:00
Philipp Holzer 3834d5e129
Renamed __toString() to getName() 2019-08-04 16:14:19 +02:00
Hypolite Petovan a0f77e1800 Improve HTML::toPlaintext
- Ignore empty trimmed text nodes
- Ignore anchor links
- Ignore blank tags and avoids adding a doctype to transitional DOM objects
2019-08-04 10:11:59 -04:00
Philipp Holzer d2211bd6dd
Removed some leftovers 2019-08-04 15:58:53 +02:00
Philipp Holzer 7cdcad9f6c
Remove unused class variable 2019-08-04 15:54:37 +02:00
Philipp Holzer 19777baa79
- Move constants to the "Cache" class (more transparent than inside the interface) 2019-08-04 15:53:28 +02:00
Philipp Holzer 34e4968c06
Adding possibility to use a different cache-backend for locking and caching
- Renaming *LockDriver to *Lock since it isn't a "driver" anymore
2019-08-04 15:42:39 +02:00
Michael d2b551a616 Merge remote-tracking branch 'upstream/develop' into alt-description 2019-08-04 12:07:21 +00:00
Philipp Holzer 86bf2ee45a
Rename *CacheDriver to *Cache because they don't act as driver anymore 2019-08-04 10:26:53 +02:00
Michael 1b7f96dac8 Partly reverted, real problem fixed 2019-08-04 04:29:52 +00:00
Michael cb77b1af8c API: We now transmit the text description there as well 2019-08-04 03:45:23 +00:00
Philipp Holzer d56bd28a07
Refactor Cache/Lock to DICE
- Refactor Cache classes
- Refactor Lock classes
- Improved test speed (removed some seperate class annotations)
2019-08-03 20:51:58 +02:00
Michael 6e8057a1c3 Respecting the "alt" description of images during import from HTML 2019-08-03 11:48:47 +00:00
Michael 764c70720c Moved several database stuff out of the transaction to avoid error 1205 2019-08-03 10:36:21 +00:00
Hypolite Petovan e5321ecc7f
Merge pull request #7458 from annando/fix-7449
Fix issue 7449: Image permissions are now set like before
2019-08-02 13:26:57 -04:00
Michael bcadf19289 "contact-id" has to be set, after "author-id" had been set 2019-08-02 17:17:51 +00:00
Michael 7c10807d1d Clarified description 2019-08-02 16:59:26 +00:00
Michael 9819d31591 Merge remote-tracking branch 'upstream/develop' into contact-id-new 2019-08-02 16:52:34 +00:00
Michael 418009ffea Improved PR 7452: We now respect the "self" contact 2019-08-02 16:46:26 +00:00
Michael 01ef630322 Fixed description 2019-08-02 16:42:24 +00:00
Michael d95ef96cca Fix issue 7449: Image permissions are now set like before 2019-08-02 16:38:50 +00:00
Hypolite Petovan 2e6b72ba62
Revert "Reworked contact-id generation" 2019-08-01 20:39:42 -04:00
Michael Vogel e8459cce34
Merge pull request #7381 from MrPetovan/task/7309-frio-compose
[frio] New Compose page
2019-08-01 08:15:02 +02:00
Hypolite Petovan e9f0c4dbfb
Merge pull request #7444 from nupplaphil/task/dice_console
Use DICE for Console
2019-07-31 14:07:45 -04:00
Philipp Holzer 5935e69d33
Adding Configuration dependency 2019-07-31 19:43:00 +02:00
Philipp Holzer a60eb9e33d
Use DICE for Console
- Use Friendica\Core\Console as Controller for DI-library
- Refactor every console command to use DICE (when possible)
- Adjusting tests
2019-07-31 19:37:42 +02:00
Michael 88aa777410 Moved user block 2019-07-31 16:09:03 +00:00
Michael c936232575 Added header 2019-07-31 16:07:50 +00:00
Michael cdc44e26de Log level changed 2019-07-31 16:05:28 +00:00
Michael b377906b77 Merge remote-tracking branch 'upstream/develop' into tag-deliver-delete 2019-07-31 14:11:06 +00:00
Michael 0696026380 Improved logging when item had been deliberately deleted after creation 2019-07-31 14:09:27 +00:00
Hypolite Petovan b8a336cc0d
Merge pull request #7452 from annando/contact-id
Reworked contact-id generation
2019-07-31 08:12:00 -04:00
Michael b4c673a620 We now use a central function for fetching the postdata 2019-07-30 22:26:01 +00:00
Michael 8ddcd8417d Reworked contact-id generation 2019-07-30 22:02:32 +00:00
Michael 7d79d48f6e Fix: The field "contact-id" now contains the correct contact id again 2019-07-30 13:08:14 +00:00
Hypolite Petovan 0b6f231ad3 Replace removed Contact::select method with Contact::selectToArray in Compose module 2019-07-29 20:31:50 -04:00
Hypolite Petovan f010beaa95 Fix formatting in Model\Group
- Improve logging call
- Replace removed App->getDatabase call
2019-07-29 20:31:50 -04:00
Hypolite Petovan cb38fe4e72 Develop one-liner in Item\Compose 2019-07-29 20:31:49 -04:00
Hypolite Petovan 361958ad04 Replace removed Contact::select by Contact::selectToArray
- Add explicit DBA::close in Model\Group
2019-07-29 20:31:49 -04:00
Hypolite Petovan c149ba2d59 Replace $uid parameter by $obj['uid'] in Item::enumeratePermissions 2019-07-29 20:31:49 -04:00
Hypolite Petovan 9d20705700 Improve compose page template
- Update title and description of the limited/private panel
- Move CC email addresses outside of the visibility panels
2019-07-29 20:31:49 -04:00
Hypolite Petovan 3e6018b3f2 Add meta protocol group for private post support 2019-07-29 20:31:48 -04:00
Hypolite Petovan 4e427f615b Only include natively supported protocol contacts in meta-groups 2019-07-29 20:31:48 -04:00
Hypolite Petovan 4f4b538bcf [frio] Add jotnet fields to compose page
- Move hardcoded descriptions to translation strings
2019-07-29 20:31:47 -04:00