Commit Graph

29473 Commits

Author SHA1 Message Date
Hypolite Petovan b5d3fcb8d4 Move top-level permission check outside of Model\Item::getTopLevelParentData
- It wasn't checked when the direct parent was also the top-level parent
2020-11-14 10:11:26 -05:00
Hypolite Petovan cb963a3259 Retrieve local top level parent item separately to check permissions in Model\Item::getTopLevelParentData 2020-11-14 10:11:26 -05:00
Hypolite Petovan c98da63041 [Database version 1375] Add update method to populate missing item.thr-parent values 2020-11-14 10:11:26 -05:00
Hypolite Petovan 2e7c505ac0 Revert wrong item.thr-parent field usage in Protocol\OStatus 2020-11-14 10:08:52 -05:00
Hypolite Petovan 042f6b98ac Remove unnecessary data array assignment in Protocol\Feed 2020-11-14 10:08:51 -05:00
Hypolite Petovan 5ce8cc24de Clarify parameter type in DFRN::mail 2020-11-14 10:08:51 -05:00
Hypolite Petovan ff66633a44 Remove references to item.parent-uri in Worker\OnePoll 2020-11-14 10:08:51 -05:00
Hypolite Petovan a9d114316d Ensure the parent field isn't set during Item insertion
- Avoid a database error if a null value is provided
2020-11-14 10:08:51 -05:00
Hypolite Petovan c36ca3cffe Fix null value for item.parent column 2020-11-14 10:08:51 -05:00
Hypolite Petovan d3708cf1c2 Fix wrong variable use in Model\Item::getTopLevelParent
- It was preventing items at levels 3 and beyond to be inserted
- Logging for missing top level parent has been bumped to notice
2020-11-14 10:08:51 -05:00
Hypolite Petovan eebcf1ae86 Separate $parent_item and $toplevel_item in mod/item 2020-11-14 10:08:51 -05:00
Hypolite Petovan 355cd401ae Replace uri fields conditions by gravity condition in Model\Item::insert 2020-11-14 10:08:51 -05:00
Hypolite Petovan ffc364f2a4 Reject replies when author is blocked by thread owner in Model\Item::insert
- Move user-level item permission to Model\Item::isAllowedByUser
- Add user-level check for comments on top-level item
2020-11-14 10:08:50 -05:00
Hypolite Petovan 5e76def1ff Clarify item.parent-uri use in database field comment 2020-11-14 10:08:50 -05:00
Hypolite Petovan 0f2a5daf09 Replace confusing uses of item.parent-uri with expected item.thr-parent 2020-11-14 10:08:50 -05:00
Hypolite Petovan 0c3a5c815e Remove obsolete references to item.parent-uri 2020-11-14 10:08:50 -05:00
Hypolite Petovan d7e1ce47bb Use item.thr-parent as expected in Model\Item::insert()
- Rework Model\Item::getTopLevelParent
- Backward compatibility with item.parent-uri is ensured
2020-11-14 10:08:50 -05:00
Hypolite Petovan 37a122bf7c
Merge pull request #9532 from Quix0r/fixes/pconfig-k-cat-varchar
Some fixes: not needed varbinary and missing UPDATE::SUCCESS
2020-11-14 10:03:22 -05:00
Roland Häder c4a20613a8
Ops!
Signed-off-by: Roland Häder <roland@mxchange.org>
2020-11-14 15:50:50 +01:00
Roland Häder 32e9a4d4d7
Some fixes:
- varbinary() is not needed when clear-text words like 'xmpp' are used for them,
  it also hinders using external tools like Adminer/phpMyAdmin to search for
  them as e.g. Adminer wraps a HEX() call (SQL) around `k` and `cat` (see table
  `pconfig`)
- added missing UPDATE::SUCCESS

Signed-off-by: Roland Häder <roland@mxchange.org>
2020-11-14 15:29:41 +01:00
Hypolite Petovan 490ce976c1
Merge pull request #9531 from annando/fatal
Check for empty body to prevent a fatal error
2020-11-12 13:41:26 -05:00
Michael ae363b74ad Check for empty body to prevent a fatal error 2020-11-12 16:52:55 +00:00
Hypolite Petovan 6dee10f340
Merge pull request #9530 from annando/fatal
Fix fatal errors
2020-11-12 07:57:53 -05:00
Michael 36c65643fb Fix fatal errors 2020-11-12 05:17:48 +00:00
Michael Vogel acae3df0a2
Merge pull request #9526 from MrPetovan/bug/9525-mastodon-emojis-tag
Restore expected implementation of JsonLD::fetchElementArray
2020-11-12 05:47:46 +01:00
Hypolite Petovan a8f16788f4 Prevent multiple replacements for the same emoji in Protocol\ActivityPub\Processor::replaceEmojis 2020-11-11 18:28:26 -05:00
Hypolite Petovan d7ea4ea425
Merge pull request #9529 from annando/api-not-found
API: Not implemented stuff should return 404
2020-11-11 16:15:24 -05:00
Michael 5598f7d6ba Fix test 2020-11-11 20:49:34 +00:00
Michael e895d3b1eb API: Not implemented stuff should return 404 2020-11-11 20:28:36 +00:00
Hypolite Petovan 42db861759
Merge pull request #9527 from annando/fetch-object-by-url
Fix: Fetch object by URL
2020-11-11 13:14:20 -05:00
Michael ba38ab2c55 Fix: Fetch object by URL 2020-11-11 17:55:33 +00:00
Hypolite Petovan 9e4a0bf212 Added new test for JsonLD::fetchElementArray type matching 2020-11-11 11:19:27 -05:00
Hypolite Petovan fa003eaa84 Fix expected implementation of JsonLD::fetchElementArray
- Added expected field value matching
2020-11-11 11:19:08 -05:00
Michael Vogel 61dcd62921
Merge pull request #9522 from MrPetovan/bug/ap-blocked-followers
Prevent ActivityPub message transmission to blocked followers
2020-11-11 15:28:04 +01:00
Hypolite Petovan 0de8319c15 Filter blocked contacts out from Protocol\ActivityPub\Transmitter::getContacts 2020-11-11 09:18:51 -05:00
Michael Vogel f41139bd05
Merge pull request #9523 from MrPetovan/bug/notices
Suppress notice when network page is empty
2020-11-11 15:16:58 +01:00
Hypolite Petovan 4fce6a919f Suppress notice when network page is empty 2020-11-11 03:05:12 -05:00
Hypolite Petovan 6b8c8b03c6 Prevent ActivityPub message transmission to blocked followers 2020-11-11 02:52:23 -05:00
Hypolite Petovan 7fcaa1f239
Merge pull request #9521 from annando/issue-9520
Issue 9520: Fix resharer hovercard
2020-11-10 15:07:01 -05:00
Michael 553369d8b5 Issue 9520: Fix resharer hovercard 2020-11-10 19:43:12 +00:00
Hypolite Petovan 978208baa3
Merge pull request #9519 from annando/fix-contact-import
Fix contact import with Frio
2020-11-10 10:28:35 -05:00
Michael 52c88ae414 Fix contact import with Frio 2020-11-10 06:37:27 +00:00
Michael Vogel 7765bd8e43
Merge pull request #9512 from MrPetovan/bug/9501-admin-users-fixes
[frio] Improve admin user list display
2020-11-10 07:07:59 +01:00
Hypolite Petovan b1bc8ebbfa
Merge pull request #9517 from annando/no-duplicated
Improve duplicate check
2020-11-09 16:00:52 -05:00
Michael c4f1719e8d Improve duplicate check 2020-11-09 20:29:42 +00:00
Michael Vogel 0031b4e18c
Merge pull request #9509 from MrPetovan/task/5616-clear-notifications-display
Set thread notifications as seen in mod/display
2020-11-09 21:01:36 +01:00
Hypolite Petovan 8fe5da930a Only set the current notify as seen when user enabled detailed notifications 2020-11-09 11:41:21 -05:00
Hypolite Petovan c053d128a2 [frio] Improve admin user list display 2020-11-09 10:08:33 -05:00
Hypolite Petovan a35707ec8f Improve admin user field is_deletable to check user.account_removed 2020-11-09 10:08:33 -05:00
Hypolite Petovan 62358104a2 Update source translation file after adding strings 2020-11-09 10:08:14 -05:00