clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #12920 from annando/issue-12701 

Issue 12701: Fix Markdown problems with Quotes
This commit is contained in:
Philipp 2023-03-21 07:23:37 +01:00 committed by GitHub
parent 5f52981255 7e6ba0b4d2
commit fd5914011c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Content/Text/BBCode.php
View File

@ -1567,8 +1567,13 @@ class BBCode
"/\[[iz]mg\=(.*?)\](.*?)\[\/[iz]mg\]/ism", "/\[[iz]mg\=(.*?)\](.*?)\[\/[iz]mg\]/ism",
function ($matches) use ($simple_html, $uriid) { function ($matches) use ($simple_html, $uriid) {
$matches[1] = self::proxyUrl($matches[1], $simple_html, $uriid); $matches[1] = self::proxyUrl($matches[1], $simple_html, $uriid);
$matches[2] = htmlspecialchars($matches[2], ENT_COMPAT); $alt = htmlspecialchars($matches[2], ENT_COMPAT);
return '<img src="' . $matches[1] . '" alt="' . $matches[2] . '" title="' . $matches[2] . '">'; // Fix for Markdown problems with Diaspora, see issue #12701
if (($simple_html != self::DIASPORA) || strpos($matches[2], '"') === false) {
return '<img src="' . $matches[1] . '" alt="' . $alt . '" title="' . $alt . '">';
} else {
return '<img src="' . $matches[1] . '" alt="' . $alt . '">';
}
}, },
$text $text
); );

10
tests/src/Content/Text/BBCodeTest.php
View File

@ -317,6 +317,14 @@ Karl Marx - Die ursprüngliche Akkumulation
'expected' => '&amp;`&`', 'expected' => '&amp;`&`',
'text' => '&[code]&[/code]', 'text' => '&[code]&[/code]',
], ],
'bug-12701-quotes' => [
'expected' => '[![abc"fgh](https://domain.tld/photo/86912721086415cdc8e0a03226831581-1.png)](https://domain.tld/photos/user/image/86912721086415cdc8e0a03226831581)',
'text' => '[url=https://domain.tld/photos/user/image/86912721086415cdc8e0a03226831581][img=https://domain.tld/photo/86912721086415cdc8e0a03226831581-1.png]abc"fgh[/img][/url]'
],
'bug-12701-no-quotes' => [
'expected' => '[![abcfgh](https://domain.tld/photo/86912721086415cdc8e0a03226831581-1.png "abcfgh")](https://domain.tld/photos/user/image/86912721086415cdc8e0a03226831581)',
'text' => '[url=https://domain.tld/photos/user/image/86912721086415cdc8e0a03226831581][img=https://domain.tld/photo/86912721086415cdc8e0a03226831581-1.png]abcfgh[/img][/url]'
],
]; ];
} }
@ -331,7 +339,7 @@ Karl Marx - Die ursprüngliche Akkumulation
* *
* @throws InternalServerErrorException * @throws InternalServerErrorException
*/ */
public function testToMarkdown(string $expected, string $text, $for_diaspora = false) public function testToMarkdown(string $expected, string $text, $for_diaspora = true)
{ {
$actual = BBCode::toMarkdown($text, $for_diaspora); $actual = BBCode::toMarkdown($text, $for_diaspora);