clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

added spaces + curly braces and TODOs for upcoming type-hint rewrite. Please 

note that PHP5 allows 'array' as type-hint already (+ interface/class name).

Signed-off-by: Roland Haeder <roland@mxchange.org>
This commit is contained in:
Roland Haeder 2017-04-08 19:05:50 +02:00
parent 8191bcc402
commit a0e5f7a59a
No known key found for this signature in database
GPG Key ID: B72F8185C6C7BD78
1 changed files with 209 additions and 180 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

255
include/conversation.php
View File

@ -1,12 +1,14 @@
<?php <?php
require_once("include/bbcode.php"); require_once "include/bbcode.php";
require_once("include/acl_selectors.php"); require_once "include/acl_selectors.php";
// Note: the code in 'item_extract_images' and 'item_redir_and_replace_images' /*
// is identical to the code in mod/message.php for 'item_extract_images' and * Note: the code in 'item_extract_images' and 'item_redir_and_replace_images'
// 'item_redir_and_replace_images' * is identical to the code in mod/message.php for 'item_extract_images' and
* 'item_redir_and_replace_images'
*/
if (! function_exists('item_extract_images')) { if (! function_exists('item_extract_images')) {
function item_extract_images($body) { function item_extract_images($body) {
@ -30,14 +32,16 @@ function item_extract_images($body) {
$new_body = $new_body . substr($orig_body, 0, $img_start) . '[!#saved_image' . $cnt . '#!]'; $new_body = $new_body . substr($orig_body, 0, $img_start) . '[!#saved_image' . $cnt . '#!]';
$cnt++; $cnt++;
} } else {
else
$new_body = $new_body . substr($orig_body, 0, $img_end + strlen('[/img]')); $new_body = $new_body . substr($orig_body, 0, $img_end + strlen('[/img]'));
}
$orig_body = substr($orig_body, $img_end + strlen('[/img]')); $orig_body = substr($orig_body, $img_end + strlen('[/img]'));
if ($orig_body === false) // in case the body ends on a closing image tag if ($orig_body === false) {
// in case the body ends on a closing image tag
$orig_body = ''; $orig_body = '';
}
$img_start = strpos($orig_body, '[img'); $img_start = strpos($orig_body, '[img');
$img_st_close = ($img_start !== false ? strpos(substr($orig_body, $img_start), ']') : false); $img_st_close = ($img_start !== false ? strpos(substr($orig_body, $img_start), ']') : false);
@ -79,17 +83,17 @@ function item_redir_and_replace_images($body, $images, $cid) {
$cnt = 0; $cnt = 0;
foreach ($images as $image) { foreach ($images as $image) {
// We're depending on the property of 'foreach' (specified on the PHP website) that /*
// it loops over the array starting from the first element and going sequentially * We're depending on the property of 'foreach' (specified on the PHP website) that
// to the last element * it loops over the array starting from the first element and going sequentially
* to the last element.
*/
$newbody = str_replace('[!#saved_image' . $cnt . '#!]', '[img]' . $image . '[/img]', $newbody); $newbody = str_replace('[!#saved_image' . $cnt . '#!]', '[img]' . $image . '[/img]', $newbody);
$cnt++; $cnt++;
} }
return $newbody; return $newbody;
}} }}
/** /**
* Render actions localized * Render actions localized
*/ */
@ -109,7 +113,9 @@ function localize_item(&$item){
$r = q("SELECT * from `item`,`contact` WHERE $r = q("SELECT * from `item`,`contact` WHERE
`item`.`contact-id`=`contact`.`id` AND `item`.`uri`='%s';", `item`.`contact-id`=`contact`.`id` AND `item`.`uri`='%s';",
dbesc($item['parent-uri'])); dbesc($item['parent-uri']));
if (!dbm::is_result($r)) return; if (!dbm::is_result($r)) {
return;
}
$obj = $r[0]; $obj = $r[0];
$author = '[url=' . $item['author-link'] . ']' . $item['author-name'] . '[/url]'; $author = '[url=' . $item['author-link'] . ']' . $item['author-name'] . '[/url]';
@ -128,7 +134,8 @@ function localize_item(&$item){
default: default:
if ($obj['resource-id']) { if ($obj['resource-id']) {
$post_type = t('photo'); $post_type = t('photo');
$m=array(); preg_match("/\[url=([^]]*)\]/", $obj['body'], $m); $m = array();
preg_match("/\[url=([^]]*)\]/", $obj['body'], $m);
$rr['plink'] = $m[1]; $rr['plink'] = $m[1];
} else { } else {
$post_type = t('status'); $post_type = t('status');
@ -468,9 +475,9 @@ function item_condition() {
if (!function_exists('conversation')) { if (!function_exists('conversation')) {
function conversation(App $a, $items, $mode, $update, $preview = false) { function conversation(App $a, $items, $mode, $update, $preview = false) {
require_once('include/bbcode.php'); require_once 'include/bbcode.php';
require_once('include/Contact.php'); require_once 'include/Contact.php';
require_once('mod/proxy.php'); require_once 'mod/proxy.php';
$ssl_state = ((local_user()) ? true : false); $ssl_state = ((local_user()) ? true : false);
@ -497,10 +504,11 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
$profile_owner = local_user(); $profile_owner = local_user();
$page_writeable = true; $page_writeable = true;
if (!$update) { if (!$update) {
// The special div is needed for liveUpdate to kick in for this page. /*
// We only launch liveUpdate if you aren't filtering in some incompatible * The special div is needed for liveUpdate to kick in for this page.
// way and also you aren't writing a comment (discovered in javascript). * We only launch liveUpdate if you aren't filtering in some incompatible
* way and also you aren't writing a comment (discovered in javascript).
*/
$live_update_div = '<div id="live-network"></div>' . "\r\n" $live_update_div = '<div id="live-network"></div>' . "\r\n"
. "<script> var profile_uid = " . $_SESSION['uid'] . "<script> var profile_uid = " . $_SESSION['uid']
. "; var netargs = '" . substr($a->cmd, 8) . "; var netargs = '" . substr($a->cmd, 8)
@ -520,8 +528,7 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
. "'; var profile_page = " . $a->pager['page'] . "; </script>\r\n"; . "'; var profile_page = " . $a->pager['page'] . "; </script>\r\n";
} }
} } elseif ($mode === 'profile') {
else if ($mode === 'profile') {
$profile_owner = $a->profile['profile_uid']; $profile_owner = $a->profile['profile_uid'];
$page_writeable = can_write_wall($a,$profile_owner); $page_writeable = can_write_wall($a,$profile_owner);
@ -529,16 +536,17 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
$tab = notags(trim($_GET['tab'])); $tab = notags(trim($_GET['tab']));
$tab = ( $tab ? $tab : 'posts' ); $tab = ( $tab ? $tab : 'posts' );
if ($tab === 'posts') { if ($tab === 'posts') {
// This is ugly, but we can't pass the profile_uid through the session to the ajax updater, /*
// because browser prefetching might change it on us. We have to deliver it with the page. * This is ugly, but we can't pass the profile_uid through the session to the ajax updater,
* because browser prefetching might change it on us. We have to deliver it with the page.
*/
$live_update_div = '<div id="live-profile"></div>' . "\r\n" $live_update_div = '<div id="live-profile"></div>' . "\r\n"
. "<script> var profile_uid = " . $a->profile['profile_uid'] . "<script> var profile_uid = " . $a->profile['profile_uid']
. "; var netargs = '?f='; var profile_page = " . $a->pager['page'] . "; </script>\r\n"; . "; var netargs = '?f='; var profile_page = " . $a->pager['page'] . "; </script>\r\n";
} }
} }
} } elseif ($mode === 'notes') {
else if ($mode === 'notes') {
$profile_owner = local_user(); $profile_owner = local_user();
$page_writeable = true; $page_writeable = true;
if (!$update) { if (!$update) {
@ -546,8 +554,7 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
. "<script> var profile_uid = " . local_user() . "<script> var profile_uid = " . local_user()
. "; var netargs = '/?f='; var profile_page = " . $a->pager['page'] . "; </script>\r\n"; . "; var netargs = '/?f='; var profile_page = " . $a->pager['page'] . "; </script>\r\n";
} }
} } elseif ($mode === 'display') {
else if ($mode === 'display') {
$profile_owner = $a->profile['uid']; $profile_owner = $a->profile['uid'];
$page_writeable = can_write_wall($a,$profile_owner); $page_writeable = can_write_wall($a,$profile_owner);
if (!$update) { if (!$update) {
@ -555,26 +562,25 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
. "<script> var profile_uid = " . $_SESSION['uid'] . ";" . "<script> var profile_uid = " . $_SESSION['uid'] . ";"
. " var profile_page = 1; </script>"; . " var profile_page = 1; </script>";
} }
} } elseif ($mode === 'community') {
else if ($mode === 'community') {
$profile_owner = 0; $profile_owner = 0;
$page_writeable = false; $page_writeable = false;
if (!$update) { if (!$update) {
$live_update_div = '<div id="live-community"></div>' . "\r\n" $live_update_div = '<div id="live-community"></div>' . "\r\n"
. "<script> var profile_uid = -1; var netargs = '/?f='; var profile_page = " . $a->pager['page'] . "; </script>\r\n"; . "<script> var profile_uid = -1; var netargs = '/?f='; var profile_page = " . $a->pager['page'] . "; </script>\r\n";
} }
} } elseif ($mode === 'search') {
else if ($mode === 'search') {
$live_update_div = '<div id="live-search"></div>' . "\r\n"; $live_update_div = '<div id="live-search"></div>' . "\r\n";
} }
$page_dropping = ((local_user() && local_user() == $profile_owner) ? true : false); $page_dropping = ((local_user() && local_user() == $profile_owner) ? true : false);
if ($update) if ($update) {
$return_url = $_SESSION['return_url']; $return_url = $_SESSION['return_url'];
else } else {
$return_url = $_SESSION['return_url'] = $a->query_string; $return_url = $_SESSION['return_url'] = $a->query_string;
}
$cb = array('items' => $items, 'mode' => $mode, 'update' => $update, 'preview' => $preview); $cb = array('items' => $items, 'mode' => $mode, 'update' => $update, 'preview' => $preview);
call_hooks('conversation_start',$cb); call_hooks('conversation_start',$cb);
@ -615,9 +621,10 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
break; break;
} }
} }
if ($blocked) if ($blocked) {
continue; continue;
} }
}
$threadsid++; $threadsid++;
@ -632,19 +639,19 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
&& ($item['id'] != $item['parent'])) && ($item['id'] != $item['parent']))
continue; continue;
$nickname = $item['nickname']; $nickname = $item['nickname'];
} } else {
else
$nickname = $a->user['nickname']; $nickname = $a->user['nickname'];
}
// prevent private email from leaking. // prevent private email from leaking.
if ($item['network'] === NETWORK_MAIL && local_user() != $item['uid']) if ($item['network'] === NETWORK_MAIL && local_user() != $item['uid']) {
continue; continue;
}
$profile_name = ((strlen($item['author-name'])) ? $item['author-name'] : $item['name']); $profile_name = ((strlen($item['author-name'])) ? $item['author-name'] : $item['name']);
if ($item['author-link'] && (! $item['author-name'])) if ($item['author-link'] && (! $item['author-name'])) {
$profile_name = $item['author-link']; $profile_name = $item['author-link'];
}
$tags = array(); $tags = array();
$hashtags = array(); $hashtags = array();
@ -655,8 +662,9 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
foreach ($taglist as $tag) { foreach ($taglist as $tag) {
if ($tag["url"] == "") if ($tag["url"] == "") {
$tag["url"] = $searchpath . strtolower($tag["term"]); $tag["url"] = $searchpath . strtolower($tag["term"]);
}
if ($tag["type"] == TERM_HASHTAG) { if ($tag["type"] == TERM_HASHTAG) {
$hashtags[] = "#<a href=\"" . $tag["url"] . "\" target=\"_blank\">" . $tag["term"] . "</a>"; $hashtags[] = "#<a href=\"" . $tag["url"] . "\" target=\"_blank\">" . $tag["term"] . "</a>";
@ -670,28 +678,33 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
$sp = false; $sp = false;
$profile_link = best_link_url($item,$sp); $profile_link = best_link_url($item,$sp);
if ($profile_link === 'mailbox') if ($profile_link === 'mailbox') {
$profile_link = ''; $profile_link = '';
if ($sp) }
if ($sp) {
$sparkle = ' sparkle'; $sparkle = ' sparkle';
else } else {
$profile_link = zrl($profile_link); $profile_link = zrl($profile_link);
}
if (!isset($item['author-thumb']) OR ($item['author-thumb'] == "")) { if (!isset($item['author-thumb']) OR ($item['author-thumb'] == "")) {
$author_contact = get_contact_details_by_url($item['author-link'], $profile_owner); $author_contact = get_contact_details_by_url($item['author-link'], $profile_owner);
if ($author_contact["thumb"]) if ($author_contact["thumb"]) {
$item['author-thumb'] = $author_contact["thumb"]; $item['author-thumb'] = $author_contact["thumb"];
else } else {
$item['author-thumb'] = $item['author-avatar']; $item['author-thumb'] = $item['author-avatar'];
} }
}
if (!isset($item['owner-thumb']) OR ($item['owner-thumb'] == "")) { if (!isset($item['owner-thumb']) OR ($item['owner-thumb'] == "")) {
$owner_contact = get_contact_details_by_url($item['owner-link'], $profile_owner); $owner_contact = get_contact_details_by_url($item['owner-link'], $profile_owner);
if ($owner_contact["thumb"]) if ($owner_contact["thumb"]) {
$item['owner-thumb'] = $owner_contact["thumb"]; $item['owner-thumb'] = $owner_contact["thumb"];
else } else {
$item['owner-thumb'] = $item['owner-avatar']; $item['owner-thumb'] = $item['owner-avatar'];
} }
}
$locate = array('location' => $item['location'], 'coord' => $item['coord'], 'html' => ''); $locate = array('location' => $item['location'], 'coord' => $item['coord'], 'html' => '');
call_hooks('render_location',$locate); call_hooks('render_location',$locate);
@ -699,11 +712,11 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
$location = ((strlen($locate['html'])) ? $locate['html'] : render_location_dummy($locate)); $location = ((strlen($locate['html'])) ? $locate['html'] : render_location_dummy($locate));
localize_item($item); localize_item($item);
if ($mode === 'network-new') if ($mode === 'network-new') {
$dropping = true; $dropping = true;
else } else {
$dropping = false; $dropping = false;
}
$drop = array( $drop = array(
'dropping' => $dropping, 'dropping' => $dropping,
@ -721,7 +734,6 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
$body = prepare_body($item, true, $preview); $body = prepare_body($item, true, $preview);
list($categories, $folders) = get_cats_and_terms($item); list($categories, $folders) = get_cats_and_terms($item);
if ($a->theme['template_engine'] === 'internal') { if ($a->theme['template_engine'] === 'internal') {
@ -733,8 +745,7 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
$mentions_e = template_escape($mentions); $mentions_e = template_escape($mentions);
$location_e = template_escape($location); $location_e = template_escape($location);
$owner_name_e = template_escape($owner_name); $owner_name_e = template_escape($owner_name);
} } else {
else {
$profile_name_e = $profile_name; $profile_name_e = $profile_name;
$item['title_e'] = $item['title']; $item['title_e'] = $item['title'];
$body_e = $body; $body_e = $body;
@ -745,8 +756,9 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
$owner_name_e = $owner_name; $owner_name_e = $owner_name;
} }
if ($item['item_network'] == "") if ($item['item_network'] == "") {
$item['item_network'] = $item['network']; $item['item_network'] = $item['network'];
}
$tmp_item = array( $tmp_item = array(
'template' => $tpl, 'template' => $tpl,
@ -803,38 +815,35 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
$threads[$threadsid]['items'] = array($arr['output']); $threads[$threadsid]['items'] = array($arr['output']);
} }
} } else {
else
{
// Normal View // Normal View
$page_template = get_markup_template("threaded_conversation.tpl"); $page_template = get_markup_template("threaded_conversation.tpl");
require_once('object/Conversation.php'); require_once 'object/Conversation.php';
require_once('object/Item.php'); require_once 'object/Item.php';
$conv = new Conversation($mode, $preview); $conv = new Conversation($mode, $preview);
// get all the topmost parents /*
// this shouldn't be needed, as we should have only them in our array * get all the topmost parents
// But for now, this array respects the old style, just in case * this shouldn't be needed, as we should have only them in our array
* But for now, this array respects the old style, just in case
*/
$threads = array(); $threads = array();
foreach ($items as $item) { foreach ($items as $item) {
if ($arr_blocked) { if ($arr_blocked) {
$blocked = false; $blocked = false;
foreach ($arr_blocked as $b) { foreach ($arr_blocked as $b) {
if ($b && link_compare($item['author-link'],$b)) { if ($b && link_compare($item['author-link'],$b)) {
$blocked = true; $blocked = true;
break; break;
} }
} }
if ($blocked) if ($blocked) {
continue; continue;
} }
}
// Can we put this after the visibility check? // Can we put this after the visibility check?
builtin_activity_puller($item, $conv_responses); builtin_activity_puller($item, $conv_responses);
@ -843,6 +852,7 @@ function conversation(App $a, $items, $mode, $update, $preview = false) {
if ($item['network'] === NETWORK_MAIL && local_user() != $item['uid']) { if ($item['network'] === NETWORK_MAIL && local_user() != $item['uid']) {
continue; continue;
} }
if (! visible_activity($item)) { if (! visible_activity($item)) {
continue; continue;
} }
@ -890,25 +900,25 @@ function best_link_url($item,&$sparkle,$ssl_state = false) {
if (local_user()) { if (local_user()) {
$r = q("SELECT `id` FROM `contact` WHERE `network` = '%s' AND `uid` = %d AND `nurl` = '%s' AND NOT `pending` LIMIT 1", $r = q("SELECT `id` FROM `contact` WHERE `network` = '%s' AND `uid` = %d AND `nurl` = '%s' AND NOT `pending` LIMIT 1",
dbesc(NETWORK_DFRN), intval(local_user()), dbesc(normalise_link($clean_url))); dbesc(NETWORK_DFRN), intval(local_user()), dbesc(normalise_link($clean_url)));
if ($r) { if (dbm::is_result($r)) {
$best_url = 'redir/' . $r[0]['id']; $best_url = 'redir/' . $r[0]['id'];
$sparkle = true; $sparkle = true;
} }
} }
if (! $best_url) { if (! $best_url) {
if (strlen($item['author-link'])) if (strlen($item['author-link'])) {
$best_url = $item['author-link']; $best_url = $item['author-link'];
else } else {
$best_url = $item['url']; $best_url = $item['url'];
} }
}
return $best_url; return $best_url;
} }
if (! function_exists('item_photo_menu')) { if (! function_exists('item_photo_menu')) {
function item_photo_menu($item) function item_photo_menu($item) {
{
$ssl_state = false; $ssl_state = false;
if (local_user()) { if (local_user()) {
@ -939,7 +949,7 @@ function item_photo_menu($item)
$rel = 0; $rel = 0;
$r = q("SELECT `id`, `network`, `rel` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' LIMIT 1", $r = q("SELECT `id`, `network`, `rel` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' LIMIT 1",
intval(local_user()), dbesc(normalise_link($item['author-link']))); intval(local_user()), dbesc(normalise_link($item['author-link'])));
if ($r) { if (dbm::is_result($r)) {
$cid = $r[0]['id']; $cid = $r[0]['id'];
$network = $r[0]['network']; $network = $r[0]['network'];
$rel = $r[0]['rel']; $rel = $r[0]['rel'];
@ -1005,6 +1015,7 @@ function item_photo_menu($item)
return $o; return $o;
}} }}
if (! function_exists('builtin_activity_puller')) {
/** /**
* @brief Checks item to see if it is one of the builtin activities (like/dislike, event attendance, consensus items, etc.) * @brief Checks item to see if it is one of the builtin activities (like/dislike, event attendance, consensus items, etc.)
* Increments the count of each matching activity and adds a link to the author as needed. * Increments the count of each matching activity and adds a link to the author as needed.
@ -1013,7 +1024,6 @@ function item_photo_menu($item)
* @param array &$conv_responses (already created with builtin activity structure) * @param array &$conv_responses (already created with builtin activity structure)
* @return void * @return void
*/ */
if (! function_exists('builtin_activity_puller')) {
function builtin_activity_puller($item, &$conv_responses) { function builtin_activity_puller($item, &$conv_responses) {
foreach ($conv_responses as $mode => $v) { foreach ($conv_responses as $mode => $v) {
$url = ''; $url = '';
@ -1045,27 +1055,31 @@ function builtin_activity_puller($item, &$conv_responses) {
if ((local_user()) && (local_user() == $item['uid']) && ($item['network'] === NETWORK_DFRN) && (! $item['self']) && (link_compare($item['author-link'],$item['url']))) { if ((local_user()) && (local_user() == $item['uid']) && ($item['network'] === NETWORK_DFRN) && (! $item['self']) && (link_compare($item['author-link'],$item['url']))) {
$url = 'redir/' . $item['contact-id']; $url = 'redir/' . $item['contact-id'];
$sparkle = ' class="sparkle" '; $sparkle = ' class="sparkle" ';
} } else {
else
$url = zrl($url); $url = zrl($url);
}
$url = '<a href="'. $url . '"'. $sparkle .'>' . htmlentities($item['author-name']) . '</a>'; $url = '<a href="'. $url . '"'. $sparkle .'>' . htmlentities($item['author-name']) . '</a>';
if (! $item['thr-parent']) if (! $item['thr-parent']) {
$item['thr-parent'] = $item['parent-uri']; $item['thr-parent'] = $item['parent-uri'];
}
if (! ((isset($conv_responses[$mode][$item['thr-parent'] . '-l'])) if (! ((isset($conv_responses[$mode][$item['thr-parent'] . '-l']))
&& (is_array($conv_responses[$mode][$item['thr-parent'] . '-l'])))) && (is_array($conv_responses[$mode][$item['thr-parent'] . '-l'])))) {
$conv_responses[$mode][$item['thr-parent'] . '-l'] = array(); $conv_responses[$mode][$item['thr-parent'] . '-l'] = array();
}
// only list each unique author once // only list each unique author once
if (in_array($url,$conv_responses[$mode][$item['thr-parent'] . '-l'])) if (in_array($url,$conv_responses[$mode][$item['thr-parent'] . '-l'])) {
continue; continue;
}
if (! isset($conv_responses[$mode][$item['thr-parent']])) if (! isset($conv_responses[$mode][$item['thr-parent']])) {
$conv_responses[$mode][$item['thr-parent']] = 1; $conv_responses[$mode][$item['thr-parent']] = 1;
else } else {
$conv_responses[$mode][$item['thr-parent']] ++; $conv_responses[$mode][$item['thr-parent']] ++;
}
if (public_contact() == $item['author-id']) { if (public_contact() == $item['author-id']) {
$conv_responses[$mode][$item['thr-parent'] . '-self'] = 1; $conv_responses[$mode][$item['thr-parent'] . '-self'] = 1;
@ -1079,15 +1093,16 @@ function builtin_activity_puller($item, &$conv_responses) {
} }
}} }}
// Format the vote text for a profile item
// $cnt = number of people who vote the item
// $arr = array of pre-linked names of likers/dislikers
// $type = one of 'like, 'dislike', 'attendyes', 'attendno', 'attendmaybe'
// $id = item id
// returns formatted text
if (! function_exists('format_like')) { if (! function_exists('format_like')) {
function format_like($cnt,$arr,$type,$id) { /**
* Format the vote text for a profile item
* @param int $cnt = number of people who vote the item
* @param array $arr = array of pre-linked names of likers/dislikers
* @param string $type = one of 'like, 'dislike', 'attendyes', 'attendno', 'attendmaybe'
* @param int $id = item id
* @return formatted text
*/
function format_like($cnt, array $arr, $type, $id) {
$o = ''; $o = '';
$expanded = ''; $expanded = '';
@ -1170,11 +1185,10 @@ function format_like($cnt,$arr,$type,$id) {
return $o; return $o;
}} }}
function status_editor($a,$x, $notes_cid = 0, $popup = false) { function status_editor($a,$x, $notes_cid = 0, $popup = false) {
$o = ''; $o = '';
$geotag = (($x['allow_location']) ? replace_macros(get_markup_template('jot_geotag.tpl'), array()) : ''); $geotag = (x($x, 'allow_location') ? replace_macros(get_markup_template('jot_geotag.tpl'), array()) : '');
$tpl = get_markup_template('jot-header.tpl'); $tpl = get_markup_template('jot-header.tpl');
$a->page['htmlhead'] .= replace_macros($tpl, array( $a->page['htmlhead'] .= replace_macros($tpl, array(
@ -1212,22 +1226,25 @@ function status_editor($a,$x, $notes_cid = 0, $popup=false) {
// Private/public post links for the non-JS ACL form // Private/public post links for the non-JS ACL form
$private_post = 1; $private_post = 1;
if ($_REQUEST['public']) if ($_REQUEST['public']) {
$private_post = 0; $private_post = 0;
}
$query_str = $a->query_string; $query_str = $a->query_string;
if (strpos($query_str, 'public=1') !== false) if (strpos($query_str, 'public=1') !== false) {
$query_str = str_replace(array('?public=1', '&public=1'), array('', ''), $query_str); $query_str = str_replace(array('?public=1', '&public=1'), array('', ''), $query_str);
}
// I think $a->query_string may never have ? in it, but I could be wrong /*
// It looks like it's from the index.php?q=[etc] rewrite that the web * I think $a->query_string may never have ? in it, but I could be wrong
// server does, which converts any ? to &, e.g. suggest&ignore=61 for suggest?ignore=61 * It looks like it's from the index.php?q=[etc] rewrite that the web
if (strpos($query_str, '?') === false) * server does, which converts any ? to &, e.g. suggest&ignore=61 for suggest?ignore=61
*/
if (strpos($query_str, '?') === false) {
$public_post_link = '?public=1'; $public_post_link = '?public=1';
else } else {
$public_post_link = '&public=1'; $public_post_link = '&public=1';
}
// $tpl = replace_macros($tpl,array('$jotplugins' => $jotplugins)); // $tpl = replace_macros($tpl,array('$jotplugins' => $jotplugins));
$tpl = get_markup_template("jot.tpl"); $tpl = get_markup_template("jot.tpl");
@ -1293,7 +1310,6 @@ function status_editor($a,$x, $notes_cid = 0, $popup=false) {
if ($popup==true){ if ($popup==true){
$o = '<div id="jot-popup" style="display: none;">'.$o.'</div>'; $o = '<div id="jot-popup" style="display: none;">'.$o.'</div>';
} }
return $o; return $o;
@ -1308,15 +1324,15 @@ function get_item_children($arr, $parent) {
if (get_config('system', 'thread_allow') && $a->theme_thread_allow) { if (get_config('system', 'thread_allow') && $a->theme_thread_allow) {
// Fallback to parent-uri if thr-parent is not set // Fallback to parent-uri if thr-parent is not set
$thr_parent = $item['thr-parent']; $thr_parent = $item['thr-parent'];
if ($thr_parent == '') if ($thr_parent == '') {
$thr_parent = $item['parent-uri']; $thr_parent = $item['parent-uri'];
}
if ($thr_parent == $parent['uri']) { if ($thr_parent == $parent['uri']) {
$item['children'] = get_item_children($arr, $item); $item['children'] = get_item_children($arr, $item);
$children[] = $item; $children[] = $item;
} }
} } elseif ($item['parent'] == $parent['id']) {
else if ($item['parent'] == $parent['id']) {
$children[] = $item; $children[] = $item;
} }
} }
@ -1324,6 +1340,7 @@ function get_item_children($arr, $parent) {
return $children; return $children;
} }
/// @TODO Add type-hint
function sort_item_children($items) { function sort_item_children($items) {
$result = $items; $result = $items;
usort($result, 'sort_thr_created_rev'); usort($result, 'sort_thr_created_rev');
@ -1335,6 +1352,7 @@ function sort_item_children($items) {
return $result; return $result;
} }
/// @TODO Add type-hint
function add_children_to_list($children, &$arr) { function add_children_to_list($children, &$arr) {
foreach ($children as $y) { foreach ($children as $y) {
$arr[] = $y; $arr[] = $y;
@ -1344,6 +1362,7 @@ function add_children_to_list($children, &$arr) {
} }
} }
/// @TODO Add type-hint
function conv_sort($arr, $order) { function conv_sort($arr, $order) {
if ((!(is_array($arr) && count($arr)))) { if ((!(is_array($arr) && count($arr)))) {
@ -1382,6 +1401,7 @@ function conv_sort($arr,$order) {
} }
} }
/// @TODO Old-lost code?
/*foreach ($arr as $x) { /*foreach ($arr as $x) {
if ($x['id'] != $x['parent']) { if ($x['id'] != $x['parent']) {
$p = find_thread_parent_index($parents,$x); $p = find_thread_parent_index($parents,$x);
@ -1393,6 +1413,7 @@ function conv_sort($arr,$order) {
foreach ($parents as $k => $v) { foreach ($parents as $k => $v) {
if (count($parents[$k]['children'])) { if (count($parents[$k]['children'])) {
$parents[$k]['children'] = sort_item_children($parents[$k]['children']); $parents[$k]['children'] = sort_item_children($parents[$k]['children']);
/// @TODO Old-lost code?
/*$y = $parents[$k]['children']; /*$y = $parents[$k]['children'];
usort($y,'sort_thr_created_rev'); usort($y,'sort_thr_created_rev');
$parents[$k]['children'] = $y;*/ $parents[$k]['children'] = $y;*/
@ -1406,6 +1427,7 @@ function conv_sort($arr,$order) {
$ret[] = $x; $ret[] = $x;
if (count($x['children'])) { if (count($x['children'])) {
add_children_to_list($x['children'], $ret); add_children_to_list($x['children'], $ret);
/// @TODO Old-lost code?
/*foreach ($x['children'] as $y) /*foreach ($x['children'] as $y)
$ret[] = $y;*/ $ret[] = $y;*/
} }
@ -1415,19 +1437,22 @@ function conv_sort($arr,$order) {
return $ret; return $ret;
} }
/// @TODO Add type-hint
function sort_thr_created($a, $b) { function sort_thr_created($a, $b) {
return strcmp($b['created'], $a['created']); return strcmp($b['created'], $a['created']);
} }
/// @TODO Add type-hint
function sort_thr_created_rev($a, $b) { function sort_thr_created_rev($a, $b) {
return strcmp($a['created'], $b['created']); return strcmp($a['created'], $b['created']);
} }
/// @TODO Add type-hint
function sort_thr_commented($a, $b) { function sort_thr_commented($a, $b) {
return strcmp($b['commented'], $a['commented']); return strcmp($b['commented'], $a['commented']);
} }
/// @TODO Add type-hint
function find_thread_parent_index($arr, $x) { function find_thread_parent_index($arr, $x) {
foreach ($arr as $k => $v) { foreach ($arr as $k => $v) {
if ($v['id'] == $x['parent']) { if ($v['id'] == $x['parent']) {
@ -1437,14 +1462,18 @@ function find_thread_parent_index($arr,$x) {
return false; return false;
} }
/// @TODO Add type-hint
function render_location_dummy($item) { function render_location_dummy($item) {
if ($item['location'] != "") if ($item['location'] != "") {
return $item['location']; return $item['location'];
if ($item['coord'] != "")
return $item['coord'];
} }
if ($item['coord'] != "") {
return $item['coord'];
}
}
/// @TODO Add type-hint
function get_responses($conv_responses, $response_verbs, $ob, $item) { function get_responses($conv_responses, $response_verbs, $ob, $item) {
$ret = array(); $ret = array();
foreach ($response_verbs as $v) { foreach ($response_verbs as $v) {