clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Increase cache lifespan / clear cache upon changes

This commit is contained in:
Michael 2022-05-17 12:32:25 +00:00
parent a880d8b982
commit 73019284ce
7 changed files with 46 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/Model/Contact.php
View File

@ -797,11 +797,13 @@ class Contact
public static function remove($id) public static function remove($id)
{ {
// We want just to make sure that we don't delete our "self" contact // We want just to make sure that we don't delete our "self" contact
$contact = DBA::selectFirst('contact', ['uri-id', 'photo', 'thumb', 'micro'], ['id' => $id, 'self' => false]); $contact = DBA::selectFirst('contact', ['uri-id', 'photo', 'thumb', 'micro', 'uid'], ['id' => $id, 'self' => false]);
if (!DBA::isResult($contact)) { if (!DBA::isResult($contact)) {
return; return;
} }
self::clearFollowerFollowingEndpointCache($contact['uid']);
// Archive the contact // Archive the contact
self::update(['archive' => true, 'network' => Protocol::PHANTOM, 'deleted' => true], ['id' => $id]); self::update(['archive' => true, 'network' => Protocol::PHANTOM, 'deleted' => true], ['id' => $id]);
@ -899,6 +901,15 @@ class Contact
self::remove($contact['id']); self::remove($contact['id']);
} }
private static function clearFollowerFollowingEndpointCache(int $uid)
{
if (empty($uid)) {
return;
}
DI::cache()->delete(ActivityPub\Transmitter::CACHEKEY_CONTACTS . 'followers:' . $uid);
DI::cache()->delete(ActivityPub\Transmitter::CACHEKEY_CONTACTS . 'following:' . $uid);
}
/** /**
* Marks a contact for archival after a communication issue delay * Marks a contact for archival after a communication issue delay
@ -1764,7 +1775,7 @@ class Contact
break; break;
default: default:
/** /**
* Use a random picture. * Use a random picture.
* The service provides random pictures from Unsplash. * The service provides random pictures from Unsplash.
* @license https://unsplash.com/license * @license https://unsplash.com/license
*/ */
@ -2321,7 +2332,7 @@ class Contact
Worker::add(PRIORITY_LOW, 'FetchFeaturedPosts', $ret['url']); Worker::add(PRIORITY_LOW, 'FetchFeaturedPosts', $ret['url']);
} }
} }
$ret['last-item'] = Probe::getLastUpdate($ret); $ret['last-item'] = Probe::getLastUpdate($ret);
Logger::info('Fetched last item', ['id' => $id, 'probed_url' => $ret['url'], 'last-item' => $ret['last-item'], 'callstack' => System::callstack(20)]); Logger::info('Fetched last item', ['id' => $id, 'probed_url' => $ret['url'], 'last-item' => $ret['last-item'], 'callstack' => System::callstack(20)]);
} }
@ -2707,6 +2718,8 @@ class Contact
$contact = DBA::selectFirst('contact', [], ['id' => $cid]); $contact = DBA::selectFirst('contact', [], ['id' => $cid]);
} }
self::clearFollowerFollowingEndpointCache($importer['uid']);
if (!empty($contact)) { if (!empty($contact)) {
if (!empty($contact['pending'])) { if (!empty($contact['pending'])) {
Logger::info('Pending contact request already exists.', ['url' => $url, 'uid' => $importer['uid']]); Logger::info('Pending contact request already exists.', ['url' => $url, 'uid' => $importer['uid']]);
@ -2830,6 +2843,8 @@ class Contact
return; return;
} }
self::clearFollowerFollowingEndpointCache($contact['uid']);
$cdata = self::getPublicAndUserContactID($contact['id'], $contact['uid']); $cdata = self::getPublicAndUserContactID($contact['id'], $contact['uid']);
DI::notification()->deleteForUserByVerb($contact['uid'], Activity::FOLLOW, ['actor-id' => $cdata['public']]); DI::notification()->deleteForUserByVerb($contact['uid'], Activity::FOLLOW, ['actor-id' => $cdata['public']]);
@ -2844,6 +2859,8 @@ class Contact
*/ */
public static function removeSharer(array $contact) public static function removeSharer(array $contact)
{ {
self::clearFollowerFollowingEndpointCache($contact['uid']);
if ($contact['rel'] == self::SHARING || in_array($contact['network'], [Protocol::FEED, Protocol::MAIL])) { if ($contact['rel'] == self::SHARING || in_array($contact['network'], [Protocol::FEED, Protocol::MAIL])) {
self::remove($contact['id']); self::remove($contact['id']);
} else { } else {

4
src/Model/Item.php
View File

@ -1223,6 +1223,10 @@ class Item
self::updateDisplayCache($posted_item['uri-id']); self::updateDisplayCache($posted_item['uri-id']);
} }
if ($posted_item['origin'] && ($posted_item['uid'] != 0) && in_array($posted_item['gravity'], [GRAVITY_PARENT, GRAVITY_COMMENT])) {
DI::cache()->delete(ActivityPub\Transmitter::CACHEKEY_OUTBOX . $posted_item['uid']);
}
return $post_user_id; return $post_user_id;
} }

16
src/Model/Post/Collection.php
View File

@ -24,6 +24,8 @@ namespace Friendica\Model\Post;
use Friendica\Database\DBA; use Friendica\Database\DBA;
use BadMethodCallException; use BadMethodCallException;
use Friendica\Database\Database; use Friendica\Database\Database;
use Friendica\DI;
use Friendica\Protocol\ActivityPub;
class Collection class Collection
{ {
@ -34,14 +36,19 @@ class Collection
* *
* @param integer $uri_id * @param integer $uri_id
* @param integer $type * @param integer $type
* @param integer $cache_uid If set to a non zero value, the featured cache is cleared
*/ */
public static function add(int $uri_id, int $type) public static function add(int $uri_id, int $type, int $cache_uid = 0)
{ {
if (empty($uri_id)) { if (empty($uri_id)) {
throw new BadMethodCallException('Empty URI_id'); throw new BadMethodCallException('Empty URI_id');
} }
DBA::insert('post-collection', ['uri-id' => $uri_id, 'type' => $type], Database::INSERT_IGNORE); DBA::insert('post-collection', ['uri-id' => $uri_id, 'type' => $type], Database::INSERT_IGNORE);
if (!empty($cache_uid) && ($type == self::FEATURED)) {
DI::cache()->delete(ActivityPub\Transmitter::CACHEKEY_FEATURED . $cache_uid);
}
} }
/** /**
@ -49,14 +56,19 @@ class Collection
* *
* @param integer $uri_id * @param integer $uri_id
* @param integer $type * @param integer $type
* @param integer $cache_uid If set to a non zero value, the featured cache is cleared
*/ */
public static function remove(int $uri_id, int $type) public static function remove(int $uri_id, int $type, int $cache_uid = 0)
{ {
if (empty($uri_id)) { if (empty($uri_id)) {
throw new BadMethodCallException('Empty URI_id'); throw new BadMethodCallException('Empty URI_id');
} }
DBA::delete('post-collection', ['uri-id' => $uri_id, 'type' => $type]); DBA::delete('post-collection', ['uri-id' => $uri_id, 'type' => $type]);
if (!empty($cache_uid) && ($type == self::FEATURED)) {
DI::cache()->delete(ActivityPub\Transmitter::CACHEKEY_FEATURED . $cache_uid);
}
} }
/** /**

2
src/Module/Api/Mastodon/Statuses/Pin.php
View File

@ -46,7 +46,7 @@ class Pin extends BaseApi
DI::mstdnError()->RecordNotFound(); DI::mstdnError()->RecordNotFound();
} }
Post\Collection::add($this->parameters['id'], Post\Collection::FEATURED); Post\Collection::add($this->parameters['id'], Post\Collection::FEATURED, $uid);
System::jsonExit(DI::mstdnStatus()->createFromUriId($this->parameters['id'], $uid)->toArray()); System::jsonExit(DI::mstdnStatus()->createFromUriId($this->parameters['id'], $uid)->toArray());
} }

2
src/Module/Api/Mastodon/Statuses/Unpin.php
View File

@ -46,7 +46,7 @@ class Unpin extends BaseApi
DI::mstdnError()->RecordNotFound(); DI::mstdnError()->RecordNotFound();
} }
Post\Collection::remove($this->parameters['id'], Post\Collection::FEATURED); Post\Collection::remove($this->parameters['id'], Post\Collection::FEATURED, $uid);
System::jsonExit(DI::mstdnStatus()->createFromUriId($this->parameters['id'], $uid)->toArray()); System::jsonExit(DI::mstdnStatus()->createFromUriId($this->parameters['id'], $uid)->toArray());
} }

4
src/Module/Item/Pin.php
View File

@ -60,9 +60,9 @@ class Pin extends BaseModule
$pinned = !$item['featured']; $pinned = !$item['featured'];
if ($pinned) { if ($pinned) {
Post\Collection::add($item['uri-id'], Post\Collection::FEATURED); Post\Collection::add($item['uri-id'], Post\Collection::FEATURED, local_user());
} else { } else {
Post\Collection::remove($item['uri-id'], Post\Collection::FEATURED); Post\Collection::remove($item['uri-id'], Post\Collection::FEATURED, local_user());
} }
// See if we've been passed a return path to redirect to // See if we've been passed a return path to redirect to

8
src/Protocol/ActivityPub/Transmitter.php
View File

@ -205,7 +205,7 @@ class Transmitter
if (!$show_contacts) { if (!$show_contacts) {
if (!empty($cachekey)) { if (!empty($cachekey)) {
DI::cache()->set($cachekey, $data, Duration::QUARTER_HOUR); DI::cache()->set($cachekey, $data, Duration::DAY);
} }
return $data; return $data;
@ -233,7 +233,7 @@ class Transmitter
} }
if (!empty($cachekey)) { if (!empty($cachekey)) {
DI::cache()->set($cachekey, $data, Duration::QUARTER_HOUR); DI::cache()->set($cachekey, $data, Duration::DAY);
} }
return $data; return $data;
@ -323,7 +323,7 @@ class Transmitter
} }
if (!empty($cachekey)) { if (!empty($cachekey)) {
DI::cache()->set($cachekey, $data, Duration::QUARTER_HOUR); DI::cache()->set($cachekey, $data, Duration::DAY);
} }
return $data; return $data;
@ -407,7 +407,7 @@ class Transmitter
$data['orderedItems'] = $list; $data['orderedItems'] = $list;
if (!empty($cachekey)) { if (!empty($cachekey)) {
DI::cache()->set($cachekey, $data, Duration::QUARTER_HOUR); DI::cache()->set($cachekey, $data, Duration::DAY);
} }
return $data; return $data;