More usage of dbm::is_result($r) instead of count($r):

- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder
2016-12-13 10:44:13 +01:00
parent 293436e5fd
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
+3 -3
View File
@@ -13,7 +13,7 @@ function profile_init(&$a) {
$which = htmlspecialchars($a->argv[1]);
else {
$r = q("select nickname from user where blocked = 0 and account_expired = 0 and account_removed = 0 and verified = 1 order by rand() limit 1");
if(count($r)) {
if(dbm::is_result($r)) {
goaway($a->get_baseurl() . '/profile/' . $r[0]['nickname']);
}
else {
@@ -136,7 +136,7 @@ function profile_content(&$a, $update = 0) {
intval($contact_id),
intval($a->profile['profile_uid'])
);
if(count($r)) {
if(dbm::is_result($r)) {
$contact = $r[0];
$remote_contact = true;
}
@@ -258,7 +258,7 @@ function profile_content(&$a, $update = 0) {
intval($a->profile['profile_uid'])
);
if(count($r)) {
if(dbm::is_result($r)) {
$a->set_pager_total($r[0]['total']);
}
}