clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove probing in magic link construction 

- Use Contact::getProbeDataFromDatabase and Contact::magicLinkByContact instead of Contact::getIdForURL and Contact::magicLinkbyId in Contact::magicLink
- Add default value for $cid parameter in Contact::getProbeDataFromDatabase
This commit is contained in:
Hypolite Petovan 2019-04-12 08:50:44 -04:00
parent 2133decf4c
commit 49d12b5fae
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Model/Contact.php
View File

@ -1127,7 +1127,7 @@ class Contact extends BaseObject
* *
* @return array Contact array in the "probe" structure * @return array Contact array in the "probe" structure
*/ */
private static function getProbeDataFromDatabase($url, $cid) private static function getProbeDataFromDatabase($url, $cid = null)
{ {
// The link could be provided as http although we stored it as https // The link could be provided as http although we stored it as https
$ssl_url = str_replace('http://', 'https://', $url); $ssl_url = str_replace('http://', 'https://', $url);
@ -2249,12 +2249,12 @@ class Contact extends BaseObject
return $url ?: $contact_url; // Equivalent to: ($url != '') ? $url : $contact_url; return $url ?: $contact_url; // Equivalent to: ($url != '') ? $url : $contact_url;
} }
$cid = self::getIdForURL($contact_url, 0, true); $data = self::getProbeDataFromDatabase($contact_url);
if (empty($cid)) { if (empty($data)) {
return $url ?: $contact_url; // Equivalent to: ($url != '') ? $url : $contact_url; return $url ?: $contact_url; // Equivalent to: ($url != '') ? $url : $contact_url;
} }
return self::magicLinkbyId($cid, $url); return self::magicLinkByContact($data, $contact_url);
} }
/** /**