Restore support for Mastodon profile short-form URLs

- Running these URLs through WebFinger first allows to retrieve the canonical ActivityPub profile URL
This commit is contained in:
Hypolite Petovan 2023-10-03 20:46:17 -04:00
parent 8640afc82e
commit 1df5003643

View File

@ -157,7 +157,10 @@ class APContact
$apcontact = []; $apcontact = [];
$webfinger = empty(parse_url($url, PHP_URL_SCHEME)); // Mastodon profile short-form URL https://domain.tld/@user doesn't return AP data when queried
// with HTTPSignature::fetchRaw, but returns the correct data when provided to WebFinger
// @see https://github.com/friendica/friendica/issues/13359
$webfinger = empty(parse_url($url, PHP_URL_SCHEME)) || strpos($url, '@') !== false;
if ($webfinger) { if ($webfinger) {
$apcontact = self::fetchWebfingerData($url); $apcontact = self::fetchWebfingerData($url);
if (empty($apcontact['url'])) { if (empty($apcontact['url'])) {
@ -197,7 +200,7 @@ class APContact
$curlResult = HTTPSignature::fetchRaw($url); $curlResult = HTTPSignature::fetchRaw($url);
$failed = empty($curlResult) || empty($curlResult->getBody()) || $failed = empty($curlResult) || empty($curlResult->getBody()) ||
(!$curlResult->isSuccess() && ($curlResult->getReturnCode() != 410)); (!$curlResult->isSuccess() && ($curlResult->getReturnCode() != 410));
if (!$failed) { if (!$failed) {
$data = json_decode($curlResult->getBody(), true); $data = json_decode($curlResult->getBody(), true);
$failed = empty($data) || !is_array($data); $failed = empty($data) || !is_array($data);