clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Just some added logging to the proxy functionality to better analyze problems

This commit is contained in:
Michael 2019-10-06 18:48:33 +00:00
parent 919727eacd
commit 1c8dd457cc
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Module/Proxy.php
View File

@ -8,6 +8,7 @@ namespace Friendica\Module;
use Friendica\BaseModule; use Friendica\BaseModule;
use Friendica\Core\L10n; use Friendica\Core\L10n;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Core\Logger;
use Friendica\Model\Photo; use Friendica\Model\Photo;
use Friendica\Object\Image; use Friendica\Object\Image;
use Friendica\Util\HTTPSignature; use Friendica\Util\HTTPSignature;
@ -92,7 +93,8 @@ class Proxy extends BaseModule
$img_str = $fetchResult->getBody(); $img_str = $fetchResult->getBody();
// If there is an error then return a blank image // If there is an error then return a blank image
if ((substr($fetchResult->getReturnCode(), 0, 1) == '4') || (!$img_str)) { if ((substr($fetchResult->getReturnCode(), 0, 1) == '4') || empty($img_str)) {
Logger::info('Error fetching image', ['image' => $request['url'], 'return' => $fetchResult->getReturnCode(), 'empty' => empty($img_str)]);
self::responseError(); self::responseError();
// stop. // stop.
} }
@ -104,6 +106,7 @@ class Proxy extends BaseModule
$image = new Image($img_str, $mime); $image = new Image($img_str, $mime);
if (!$image->isValid()) { if (!$image->isValid()) {
Logger::info('The image is invalid', ['image' => $request['url'], 'mime' => $mime]);
self::responseError(); self::responseError();
// stop. // stop.
} }
@ -305,6 +308,7 @@ class Proxy extends BaseModule
private static function responseImageHttpCache(Image $img) private static function responseImageHttpCache(Image $img)
{ {
if (is_null($img) || !$img->isValid()) { if (is_null($img) || !$img->isValid()) {
Logger::info('The cached image is invalid');
self::responseError(); self::responseError();
// stop. // stop.
} }