clones/friendica
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #12094 from MrPetovan/task/hide-reply-counts-ping 

Remove non-top-level posts from notification labels when network sort order is "received"
This commit is contained in:
Philipp 2022-11-04 18:00:15 +01:00 committed by GitHub
parent 16b3db343b 6c745c8522
commit 119f9d9d27
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 128 additions and 95 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Core/Config/Capability/IManageConfigValues.php
View File

@ -51,7 +51,7 @@ interface IManageConfigValues
* *
* @param string $cat The category of the configuration value * @param string $cat The category of the configuration value
* @param string $key The configuration key to query * @param string $key The configuration key to query
* @param mixed $default_value optional, The value to return if key is not set (default: null) * @param mixed $default_value Deprecated, use `Config->get($cat, $key, null, $refresh) ?? $default_value` instead
* @param boolean $refresh optional, If true the config is loaded from the db and not from the cache (default: false) * @param boolean $refresh optional, If true the config is loaded from the db and not from the cache (default: false)
* *
* @return mixed Stored value or null if it does not exist * @return mixed Stored value or null if it does not exist

2
src/Core/PConfig/Capability/IManagePersonalConfigValues.php
View File

@ -51,7 +51,7 @@ interface IManagePersonalConfigValues
* @param int $uid The user_id * @param int $uid The user_id
* @param string $cat The category of the configuration value * @param string $cat The category of the configuration value
* @param string $key The configuration key to query * @param string $key The configuration key to query
* @param mixed $default_value optional, The value to return if key is not set (default: null) * @param mixed $default_value Deprecated, use `PConfig->get($uid, $cat, $key, null, $refresh) ?? $default_value` instead
* @param boolean $refresh optional, If true the config is loaded from the db and not from the cache (default: false) * @param boolean $refresh optional, If true the config is loaded from the db and not from the cache (default: false)
* *
* @return mixed Stored value or null if it does not exist * @return mixed Stored value or null if it does not exist

4
src/Core/Session/Capability/IHandleSessions.php
View File

@ -48,7 +48,7 @@ interface IHandleSessions
* Handle the case where session_start() hasn't been called and the super global isn't available. * Handle the case where session_start() hasn't been called and the super global isn't available.
* *
* @param string $name * @param string $name
* @param mixed $defaults * @param mixed $defaults Deprecated, use `Session->get($name) ?? $defaults` instead
* *
* @return mixed * @return mixed
*/ */
@ -58,7 +58,7 @@ interface IHandleSessions
* Retrieves a value from the provided key if it exists and removes it from session * Retrieves a value from the provided key if it exists and removes it from session
* *
* @param string $name * @param string $name
* @param mixed $defaults * @param mixed $defaults Deprecated, use `Session->pop($name) ?? $defaults` instead
* *
* @return mixed * @return mixed
*/ */

2
src/Model/Subscription.php
View File

@ -141,7 +141,7 @@ class Subscription
{ {
$type = NotificationFactory::getType($notification); $type = NotificationFactory::getType($notification);
if (DI::notify()->NotifyOnDesktop($notification, $type)) { if (DI::notify()->shouldShowOnDesktop($notification, $type)) {
DI::notify()->createFromNotification($notification); DI::notify()->createFromNotification($notification);
} }

18
src/Module/Conversation/Network.php
View File

@ -29,7 +29,9 @@ use Friendica\Content\Widget;
use Friendica\Content\Text\HTML; use Friendica\Content\Text\HTML;
use Friendica\Core\ACL; use Friendica\Core\ACL;
use Friendica\Core\Hook; use Friendica\Core\Hook;
use Friendica\Core\PConfig\Capability\IManagePersonalConfigValues;
use Friendica\Core\Renderer; use Friendica\Core\Renderer;
use Friendica\Core\Session\Capability\IHandleUserSessions;
use Friendica\Database\DBA; use Friendica\Database\DBA;
use Friendica\DI; use Friendica\DI;
use Friendica\Model\Contact; use Friendica\Model\Contact;
@ -306,7 +308,7 @@ class Network extends BaseModule
self::$forumContactId = $this->parameters['contact_id'] ?? 0; self::$forumContactId = $this->parameters['contact_id'] ?? 0;
self::$selectedTab = DI::session()->get('network-tab', DI::pConfig()->get(DI::userSession()->getLocalUserId(), 'network.view', 'selected_tab', '')); self::$selectedTab = self::getTimelineOrderBySession(DI::userSession(), DI::pConfig());
if (!empty($get['star'])) { if (!empty($get['star'])) {
self::$selectedTab = 'star'; self::$selectedTab = 'star';
@ -486,4 +488,18 @@ class Network extends BaseModule
return $items; return $items;
} }
/**
* Returns the selected network tab of the currently logged-in user
*
* @param IHandleUserSessions $session
* @param IManagePersonalConfigValues $pconfig
* @return string
*/
public static function getTimelineOrderBySession(IHandleUserSessions $session, IManagePersonalConfigValues $pconfig): string
{
return $session->get('network-tab')
?? $pconfig->get($session->getLocalUserId(), 'network.view', 'selected_tab')
?? '';
}
} }

145
src/Module/Notifications/Ping.php
View File

@ -25,16 +25,21 @@ use Friendica\App;
use Friendica\BaseModule; use Friendica\BaseModule;
use Friendica\Contact\Introduction\Repository\Introduction; use Friendica\Contact\Introduction\Repository\Introduction;
use Friendica\Content\ForumManager; use Friendica\Content\ForumManager;
use Friendica\Core\Cache\Capability\ICanCache;
use Friendica\Core\Cache\Enum\Duration; use Friendica\Core\Cache\Enum\Duration;
use Friendica\Core\Config\Capability\IManageConfigValues;
use Friendica\Core\Hook; use Friendica\Core\Hook;
use Friendica\Core\L10n; use Friendica\Core\L10n;
use Friendica\Core\PConfig\Capability\IManagePersonalConfigValues;
use Friendica\Core\Session\Capability\IHandleUserSessions;
use Friendica\Core\System; use Friendica\Core\System;
use Friendica\Database\Database;
use Friendica\Database\DBA; use Friendica\Database\DBA;
use Friendica\DI;
use Friendica\Model\Group; use Friendica\Model\Group;
use Friendica\Model\Post; use Friendica\Model\Post;
use Friendica\Model\User; use Friendica\Model\User;
use Friendica\Model\Verb; use Friendica\Model\Verb;
use Friendica\Module\Conversation\Network;
use Friendica\Module\Register; use Friendica\Module\Register;
use Friendica\Module\Response; use Friendica\Module\Response;
use Friendica\Navigation\Notifications\Entity; use Friendica\Navigation\Notifications\Entity;
@ -59,8 +64,22 @@ class Ping extends BaseModule
private $introductionRepo; private $introductionRepo;
/** @var Factory\FormattedNavNotification */ /** @var Factory\FormattedNavNotification */
private $formattedNavNotification; private $formattedNavNotification;
/** @var IHandleUserSessions */
private $session;
/** @var IManageConfigValues */
private $config;
/** @var IManagePersonalConfigValues */
private $pconfig;
/** @var Database */
private $database;
/** @var ICanCache */
private $cache;
/** @var Repository\Notify */
private $notify;
/** @var App */
private $app;
public function __construct(SystemMessages $systemMessages, Repository\Notification $notificationRepo, Introduction $introductionRepo, Factory\FormattedNavNotification $formattedNavNotification, L10n $l10n, App\BaseURL $baseUrl, App\Arguments $args, LoggerInterface $logger, Profiler $profiler, Response $response, array $server, array $parameters = []) public function __construct(App $app, Repository\Notify $notify, ICanCache $cache, Database $database, IManagePersonalConfigValues $pconfig, IManageConfigValues $config, IHandleUserSessions $session, SystemMessages $systemMessages, Repository\Notification $notificationRepo, Introduction $introductionRepo, Factory\FormattedNavNotification $formattedNavNotification, L10n $l10n, App\BaseURL $baseUrl, App\Arguments $args, LoggerInterface $logger, Profiler $profiler, Response $response, array $server, array $parameters = [])
{ {
parent::__construct($l10n, $baseUrl, $args, $logger, $profiler, $response, $server, $parameters); parent::__construct($l10n, $baseUrl, $args, $logger, $profiler, $response, $server, $parameters);
@ -68,11 +87,18 @@ class Ping extends BaseModule
$this->notificationRepo = $notificationRepo; $this->notificationRepo = $notificationRepo;
$this->introductionRepo = $introductionRepo; $this->introductionRepo = $introductionRepo;
$this->formattedNavNotification = $formattedNavNotification; $this->formattedNavNotification = $formattedNavNotification;
$this->session = $session;
$this->config = $config;
$this->pconfig = $pconfig;
$this->database = $database;
$this->cache = $cache;
$this->notify = $notify;
$this->app = $app;
} }
protected function rawContent(array $request = []) protected function rawContent(array $request = [])
{ {
$regs = []; $registrations = [];
$navNotifications = []; $navNotifications = [];
$intro_count = 0; $intro_count = 0;
@ -90,20 +116,29 @@ class Ping extends BaseModule
$today_birthday_count = 0; $today_birthday_count = 0;
if (DI::userSession()->getLocalUserId()) { if ($this->session->getLocalUserId()) {
if (DI::pConfig()->get(DI::userSession()->getLocalUserId(), 'system', 'detailed_notif')) { if ($this->pconfig->get($this->session->getLocalUserId(), 'system', 'detailed_notif')) {
$notifications = $this->notificationRepo->selectDetailedForUser(DI::userSession()->getLocalUserId()); $notifications = $this->notificationRepo->selectDetailedForUser($this->session->getLocalUserId());
} else { } else {
$notifications = $this->notificationRepo->selectDigestForUser(DI::userSession()->getLocalUserId()); $notifications = $this->notificationRepo->selectDigestForUser($this->session->getLocalUserId());
} }
$condition = [ $condition = [
"`unseen` AND `uid` = ? AND NOT `origin` AND (`vid` != ? OR `vid` IS NULL)", "`unseen` AND `uid` = ? AND NOT `origin` AND (`vid` != ? OR `vid` IS NULL)",
DI::userSession()->getLocalUserId(), Verb::getID(Activity::FOLLOW) $this->session->getLocalUserId(), Verb::getID(Activity::FOLLOW)
]; ];
$items = Post::selectForUser(DI::userSession()->getLocalUserId(), ['wall', 'uid', 'uri-id'], $condition, ['limit' => 1000]);
if (DBA::isResult($items)) { // No point showing counts for non-top-level posts when the network page is ordered by received field
$items_unseen = Post::toArray($items, false); if (Network::getTimelineOrderBySession($this->session, $this->pconfig) == 'received') {
$condition = DBA::mergeConditions($condition, ["`parent` = `id`"]);
}
$items_unseen = $this->database->toArray(Post::selectForUser(
$this->session->getLocalUserId(),
['wall', 'uid', 'uri-id'],
$condition,
['limit' => 1000],
));
$arr = ['items' => $items_unseen]; $arr = ['items' => $items_unseen];
Hook::callAll('network_ping', $arr); Hook::callAll('network_ping', $arr);
@ -114,83 +149,67 @@ class Ping extends BaseModule
$network_count++; $network_count++;
} }
} }
}
DBA::close($items);
$compute_group_counts = DI::config()->get('system','compute_group_counts'); $compute_group_counts = $this->config->get('system','compute_group_counts');
if ($network_count && $compute_group_counts) { if ($network_count && $compute_group_counts) {
// Find out how unseen network posts are spread across groups // Find out how unseen network posts are spread across groups
$group_counts = Group::countUnseen(); foreach (Group::countUnseen() as $group_count) {
if (DBA::isResult($group_counts)) {
foreach ($group_counts as $group_count) {
if ($group_count['count'] > 0) { if ($group_count['count'] > 0) {
$groups_unseen[] = $group_count; $groups_unseen[] = $group_count;
} }
} }
}
$forum_counts = ForumManager::countUnseenItems(); foreach (ForumManager::countUnseenItems() as $forum_count) {
if (DBA::isResult($forum_counts)) {
foreach ($forum_counts as $forum_count) {
if ($forum_count['count'] > 0) { if ($forum_count['count'] > 0) {
$forums_unseen[] = $forum_count; $forums_unseen[] = $forum_count;
} }
} }
} }
}
$intros = $this->introductionRepo->selectForUser(DI::userSession()->getLocalUserId()); $intros = $this->introductionRepo->selectForUser($this->session->getLocalUserId());
$intro_count = $intros->count(); $intro_count = $intros->count();
$myurl = DI::baseUrl() . '/profile/' . DI::app()->getLoggedInUserNickname(); $myurl = $this->session->getMyUrl();
$mail_count = DBA::count('mail', ["`uid` = ? AND NOT `seen` AND `from-url` != ?", DI::userSession()->getLocalUserId(), $myurl]); $mail_count = $this->database->count('mail', ["`uid` = ? AND NOT `seen` AND `from-url` != ?", $this->session->getLocalUserId(), $myurl]);
if (intval(DI::config()->get('config', 'register_policy')) === Register::APPROVE && DI::app()->isSiteAdmin()) { if (intval($this->config->get('config', 'register_policy')) === Register::APPROVE && $this->app->isSiteAdmin()) {
$regs = \Friendica\Model\Register::getPending(); $registrations = \Friendica\Model\Register::getPending();
$register_count = count($registrations);
if (DBA::isResult($regs)) {
$register_count = count($regs);
}
} }
$cachekey = 'ping:events:' . DI::userSession()->getLocalUserId(); $cachekey = 'ping:events:' . $this->session->getLocalUserId();
$ev = DI::cache()->get($cachekey); $events = $this->cache->get($cachekey);
if (is_null($ev)) { if (is_null($events)) {
$ev = DBA::selectToArray('event', ['type', 'start'], $events = $this->database->selectToArray('event', ['type', 'start'],
["`uid` = ? AND `start` < ? AND `finish` > ? AND NOT `ignore`", ["`uid` = ? AND `start` < ? AND `finish` > ? AND NOT `ignore`",
DI::userSession()->getLocalUserId(), DateTimeFormat::utc('now + 7 days'), DateTimeFormat::utcNow()]); $this->session->getLocalUserId(), DateTimeFormat::utc('now + 7 days'), DateTimeFormat::utcNow()]);
DI::cache()->set($cachekey, $ev, Duration::HOUR); $this->cache->set($cachekey, $events, Duration::HOUR);
} }
if (DBA::isResult($ev)) { $now_date = DateTimeFormat::localNow('Y-m-d');
$all_events = count($ev); foreach ($events as $event) {
$is_birthday = false;
if ($all_events) { if ($event['type'] === 'birthday') {
$str_now = DateTimeFormat::localNow('Y-m-d');
foreach ($ev as $x) {
$bd = false;
if ($x['type'] === 'birthday') {
$birthday_count++; $birthday_count++;
$bd = true; $is_birthday = true;
} else { } else {
$event_count++; $event_count++;
} }
if (DateTimeFormat::local($x['start'], 'Y-m-d') === $str_now) {
if ($bd) { if (DateTimeFormat::local($event['start'], 'Y-m-d') === $now_date) {
if ($is_birthday) {
$today_birthday_count++; $today_birthday_count++;
} else { } else {
$today_event_count++; $today_event_count++;
} }
} }
} }
}
}
$owner = User::getOwnerDataById(DI::userSession()->getLocalUserId()); $owner = User::getOwnerDataById($this->session->getLocalUserId());
$navNotifications = array_map(function (Entity\Notification $notification) use ($owner) { $navNotifications = array_map(function (Entity\Notification $notification) use ($owner) {
if (!DI::notify()->NotifyOnDesktop($notification)) { if (!$this->notify->shouldShowOnDesktop($notification)) {
return null; return null;
} }
if (($notification->type == Post\UserNotification::TYPE_NONE) && in_array($owner['page-flags'], [User::PAGE_FLAGS_NORMAL, User::PAGE_FLAGS_PRVGROUP])) { if (($notification->type == Post\UserNotification::TYPE_NONE) && in_array($owner['page-flags'], [User::PAGE_FLAGS_NORMAL, User::PAGE_FLAGS_PRVGROUP])) {
@ -213,31 +232,29 @@ class Ping extends BaseModule
$navNotifications[] = $this->formattedNavNotification->createFromIntro($intro); $navNotifications[] = $this->formattedNavNotification->createFromIntro($intro);
} }
if (DBA::isResult($regs)) { if (count($registrations) <= 1 || $this->pconfig->get($this->session->getLocalUserId(), 'system', 'detailed_notif')) {
if (count($regs) <= 1 || DI::pConfig()->get(DI::userSession()->getLocalUserId(), 'system', 'detailed_notif')) { foreach ($registrations as $reg) {
foreach ($regs as $reg) {
$navNotifications[] = $this->formattedNavNotification->createFromParams( $navNotifications[] = $this->formattedNavNotification->createFromParams(
[ [
'name' => $reg['name'], 'name' => $reg['name'],
'url' => $reg['url'], 'url' => $reg['url'],
], ],
DI::l10n()->t('{0} requested registration'), $this->l10n->t('{0} requested registration'),
new \DateTime($reg['created'], new \DateTimeZone('UTC')), new \DateTime($reg['created'], new \DateTimeZone('UTC')),
new Uri(DI::baseUrl()->get(true) . '/admin/users/pending') new Uri($this->baseUrl->get(true) . '/admin/users/pending')
); );
} }
} else { } elseif (count($registrations) > 1) {
$navNotifications[] = $this->formattedNavNotification->createFromParams( $navNotifications[] = $this->formattedNavNotification->createFromParams(
[ [
'name' => $regs[0]['name'], 'name' => $registrations[0]['name'],
'url' => $regs[0]['url'], 'url' => $registrations[0]['url'],
], ],
DI::l10n()->t('{0} and %d others requested registration', count($regs) - 1), $this->l10n->t('{0} and %d others requested registration', count($registrations) - 1),
new \DateTime($regs[0]['created'], new \DateTimeZone('UTC')), new \DateTime($registrations[0]['created'], new \DateTimeZone('UTC')),
new Uri(DI::baseUrl()->get(true) . '/admin/users/pending') new Uri($this->baseUrl->get(true) . '/admin/users/pending')
); );
} }
}
// sort notifications by $[]['date'] // sort notifications by $[]['date']
$sort_function = function (ValueObject\FormattedNavNotification $a, ValueObject\FormattedNavNotification $b) { $sort_function = function (ValueObject\FormattedNavNotification $a, ValueObject\FormattedNavNotification $b) {

2
src/Navigation/Notifications/Repository/Notify.php
View File

@ -664,7 +664,7 @@ class Notify extends BaseRepository
return false; return false;
} }
public function NotifyOnDesktop(Entity\Notification $Notification, string $type = null): bool public function shouldShowOnDesktop(Entity\Notification $Notification, string $type = null): bool
{ {
if (is_null($type)) { if (is_null($type)) {
$type = NotificationFactory::getType($Notification); $type = NotificationFactory::getType($Notification);