Ensure Post::toArray returns an array

- We don't handle query errors anyway
- Remove unused parameter do_close
- Address https://github.com/friendica/friendica/issues/11993#issuecomment-1314245581
This commit is contained in:
Hypolite Petovan 2022-11-14 14:53:54 -05:00
parent 0eaa2eae84
commit 10e48a34f2

View File

@ -102,26 +102,25 @@ class Post
} }
/** /**
* Fills an array with data from an post query * Fills an array with data from a post query
* *
* @param object $stmt statement object * @param object|bool $stmt Return value from Database->select
* @param bool $do_close
* @return array Data array * @return array Data array
* @todo Find proper type-hint for $stmt and maybe avoid boolean * @throws \Exception
*/ */
public static function toArray($stmt, bool $do_close = true) public static function toArray($stmt): array
{ {
if (is_bool($stmt)) { if (is_bool($stmt)) {
return $stmt; return [];
} }
$data = []; $data = [];
while ($row = self::fetch($stmt)) { while ($row = self::fetch($stmt)) {
$data[] = $row; $data[] = $row;
} }
if ($do_close) {
DBA::close($stmt); DBA::close($stmt);
}
return $data; return $data;
} }