Return early if an URI id cannot be obtained in ActivityPub\Processor::createItem

- Address https://github.com/friendica/friendica/issues/9250#issuecomment-743769813
2020-12-13 13:42:08 -05:00
parent 61aa4efa89
commit 0441b912ac
2 changed files with 6 additions and 2 deletions
--- a/src/Protocol/ActivityPub/Processor.php
+++ b/src/Protocol/ActivityPub/Processor.php
@@ -327,6 +327,10 @@ class Processor
 		$item['guid'] = $activity['diaspora:guid'] ?: $guid;

 		$item['uri-id'] = ItemURI::insert(['uri' => $item['uri'], 'guid' => $item['guid']]);
+		if (empty($item['uri-id'])) {
+			Logger::warning('Unable to get a uri-id for an item uri', ['uri' => $item['uri'], 'guid' => $item['guid']]);
+			return [];
+		}

 		$item = self::processContent($activity, $item);
 		if (empty($item)) {