Commit Graph

3239 Commits

Author SHA1 Message Date
Michael 06c6bfc88d And some more notices ... 2018-07-31 18:10:34 +00:00
Tobias Diekershoff c0ecafcfdc
Merge pull request #678 from annando/notices
And now for something complete different ... notices
2018-07-31 18:41:09 +02:00
Michael 7f02ca32c9 And now for something complete different ... notices 2018-07-31 16:22:05 +00:00
Michael Vogel 53a3c85d4f
Merge pull request #673 from Quix0r/global/mod-proxy-to-class
[global]: Proxy class has been introduced, need to fix these as well.
2018-07-31 07:33:33 +02:00
Tobias Diekershoff e9f5008e2b
Merge pull request #677 from annando/notices
Notice fix: The variabe had never been defined
2018-07-31 06:26:49 +02:00
Michael 8e77528e23 Notice fix: The variabe had never been defined 2018-07-31 02:04:45 +00:00
Roland Häder 9695138ba1
[global] Renamed class ProxyUtils -> Proxy and aliased it back to ProxyUtils 2018-07-31 03:20:29 +02:00
Roland Häder e269589c65
[global] CR request: Moved proxify*() methods to separate class 2018-07-31 03:20:04 +02:00
Roland Häder 7032e088f7
[global] Moved to Module\Proxy 2018-07-31 03:20:04 +02:00
Roland Häder 265a2c498e
[global]: Proxy class has been introduced, need to fix these as well. 2018-07-31 03:20:04 +02:00
Michael Vogel fc2a367dae
Merge pull request #676 from Quix0r/dwpost/fixes-curly-spaces
[dwpost] Cleanups and type-hint rewrite
2018-07-30 06:22:37 +02:00
Michael Vogel a52933c57a
Merge pull request #675 from Quix0r/buglink/fixes-curly-spaces
[buglink]: Added type-hint 'App'
2018-07-30 06:11:22 +02:00
Roland Häder 24c2f06e85
[dwpost] Cleanups:
- used type-hint `App` and no call-by-reference
- converted spaces -> tab for indenting
- DBA::isResult() used instead of empty/count/...
- added curly braces and spaces for better readability
- opening curly brace after function/method/class belongs into new line
2018-07-29 22:34:40 +02:00
Roland Häder bc5aa4015b
[buglink]: Added type-hint 'App' 2018-07-29 22:23:16 +02:00
Michael Vogel 80a0d6a974
Merge pull request #674 from Quix0r/tumblr/fixes-curly-spaces
[tumblr] Type-hints, curly braces and spaces added
2018-07-29 19:57:48 +02:00
Roland Häder f9784d7095
[tumblr]
- added type-hints for `App`
- added curly braces + spaces for better readability
- avoided to use deprecated x(), replaced with empty()
- converted multi single-line comment to single multi-line comment
- opening curly brace behind a function/method/class belongs into next line
2018-07-29 19:43:53 +02:00
Roland Häder 93fb5a6151 [cross] Moved CONTACT_* constants to class Friendica\Model\Contact (#670)
* [cross] Moved CONTACT_* constants to class Friendica\Model\Contact

* Other PR request:
- renamed Contact::CONTACT_IS_* to just plain Contact::* :-) (MrPetovan)
2018-07-28 01:34:38 -04:00
Roland Häder 05bea7c61d [forumdirectory] Fixes, type-hints and PAGE_* moval (#671)
* Rewrite:
- moved PAGE_* constants to class Friendica\Model\Profile

* Rewrites:
- added type-hint `App`
- added type-hint `array` to $b
- used empty() instead of deprecated x()

* [forumdirectory] CR request:
- moved constants PAGE_* from Profile to Contact class

* [forumdirectory] CR request: Removed superfluous == 1
2018-07-28 01:33:39 -04:00
Michael Vogel 31d0fac64a Some more notices fixed (#672) 2018-07-26 15:20:12 -04:00
Roland Häder f4763f67ad [curweather] x() no longer used and more (#669)
* [curweather] Fixes/rewrites:
- Added `App` as type-hint for $a and no & (call-by-reference) anymore
- use empty() instead of deprecated x()
- opening curly brace belongs into new line after function/method declaration
- added a lot other curly braces for better readability
- added spaces and empty lines

* [curweather] CR request:
- added/removed spaces
- added missing line-feed after opening curly brace

* [curweather] Another new line-feed added

* [curweather] CR request:
- added/removed extra spaces
- removed trailing spaces
- nicely indented code block with `'$foo' => 'bar'`

* [curweather] CR request:
- removed stray space
2018-07-24 20:18:59 -04:00
Roland Häder 40f01ae601 [xmpp] Fixes: (#668)
- rewrote from deprecated x() to empty()
- added some empty lines for better readability
- used single quotes
2018-07-24 17:54:00 -04:00
Roland Häder 9d74809504 [bufffer] Cleanups: (#667)
- purged deprecated x() and used !empty() instead
- add App as type-hint where missing
- added curly braces and spaces for better readability/code convention
- open curly brace after method/function should be next line
2018-07-24 07:44:42 -04:00
Tobias Diekershoff 26800cddb3
Merge pull request #660 from annando/notices-again
And again some removed notices
2018-07-24 06:34:51 +02:00
Michael Vogel 429b9c9f4a
Merge branch 'develop' into notices-again 2018-07-24 04:19:48 +02:00
Michael Vogel f33a6b44c5
Merge pull request #663 from MrPetovan/task/5410-add-missing-use-statement
[widgets] Add missing use statement after dbesc conversion
2018-07-24 03:51:08 +02:00
Roland Häder 95a98faeec [diaspora]: Ops, fixed parser error. Followup to #665 (#666) 2018-07-23 19:31:44 -04:00
Roland Häder 280e835481 [diaspora] Cleanups and type-hinting (#665)
* [diaspora] Fixes/cleanups:
- added curly braces/spaces for better readability
- don't use count() when you can use DBM::is_result()
- used proper type-hints `App` and `array`
- "imported" Friendica\App

* [diaspora]: Fixed parser error, ops

* [diaspora]:
- DBA::isResult() is now the new name (MrPetovan)
- added spaces for nice indending and better readability
- changed 4-spaces to tab
2018-07-23 19:04:06 -04:00
Roland Häder ea4de38223 [mailstream]: Fixed logger level NORMAL -> INFO (#664) 2018-07-23 18:54:14 -04:00
Hypolite Petovan c4c2514f3b [widgets] Add missing use statement after dbesc conversion 2018-07-23 18:46:16 -04:00
Andreas Neustifter b058ac39df [curweather] Fix widget layout. [friendica#5473] (#662)
See issue [friendica#5473](https://github.com/friendica/friendica/issues/5473) and PR#653.
2018-07-23 17:06:09 -04:00
Michael Vogel 76a9630d40
Merge pull request #659 from MrPetovan/task/5410-remove-dbesc
Remove dbesc()
2018-07-23 21:51:20 +02:00
Hypolite Petovan 522e8e58c2 [multiple] Rename dbesc to DBA::escape 2018-07-23 15:35:22 -04:00
Michael Vogel d9ec1ef80d
Merge pull request #658 from MrPetovan/task/5410-remove-dbm-class
Remove DBM class
2018-07-23 21:05:13 +02:00
Hypolite Petovan f4ad0d3721 Rename DBA::is_result to DBA::isResult 2018-07-23 15:02:59 -04:00
Hypolite Petovan 332ea212b5 Rename DBM method calls to DBA method calls 2018-07-23 15:02:10 -04:00
Michael Vogel 8cdacf34b1
Merge pull request #657 from MrPetovan/task/5410-rename-database-methods
[advancedcontentfilter] Rename DBA::inArray to DBA::toArray
2018-07-23 15:19:05 +02:00
Roland Häder a9da9db7eb [pumpio] Fixes/imports: (#661)
* [pumpio] Fixes/imports:
- added curly braces and spaces for better readability
- merged 2 `if()` blocks into one for lesser nested code blocks
- added type-hint `App` and `array` where applyable
- better "import" (`use` under PHP) classes and not reference them directly,
  reducing and improving readability

* [pumpio] Fixes:
- x() is deprecated, let's use !empty() instead
- added spaces for better readability

* [pumpio] Fixes:
- added missing App "imports" (thanks to MrPetovan)
- added type-hint array for $b
- added some spaces
2018-07-22 12:01:05 -04:00
Michael a10a8361a7 This will work 2018-07-22 06:50:34 +00:00
Michael 1f9c353bae And again some removed notices 2018-07-22 06:41:30 +00:00
Roland Häder c7764068cc [blogger] Cleanups: (#656)
* [blogger] Cleanups:
- used `use Friendica\App;`
- added type-hints for `App` and `array` where applyable
- removed extra space
- added other spaces

* [blogger]:
- ops, curly brace in new line in function/method declaration
- proper way for x() replacement
2018-07-20 22:21:06 -04:00
Hypolite Petovan 2d2167c146 [advancedcontentfilter] Rename DBA::inArray to DBA::toArray 2018-07-20 22:16:16 -04:00
Roland Häder aaab504eb2 [blockem] Cleanups: (#655)
* [blockem] Cleanups:
- used `use Friendica\App;`
- used proper type-hints
- added spaces and curly braces for better readability

* [blockem] Moved open curly braces to new line

* [blockem]:
- changed checking condition (CR request)
- added/removed more spaces

* [blockem]: converted 4 spaces -> tab
2018-07-20 21:51:15 -04:00
Andreas Neustifter 81e57250e8 [curweather] Only shown notice about unavailable weather once per session. (#653)
* [curweather] Only shown notice about unavailable weather once per session.

* Fix even more whitespace.

As requested by @MrPetovan.

* [curweather] Reset session's curweather_notice_shown when weather available again.
2018-07-20 15:58:53 -04:00
Andreas Neustifter aa1a542396 [js_upload] Better wording for mass-upload photos button. (#654) 2018-07-20 15:15:09 -04:00
Michael Vogel 4168bff3b9
Merge pull request #652 from MrPetovan/task/5410-rename-dba-to-DBA
[multiple] Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 19:45:26 +02:00
Hypolite Petovan 57505bdf82 [multiple] Rename Friendica\Database\dba to Friendica\Database\DBA 2018-07-20 08:20:48 -04:00
Tobias Diekershoff 9463696159
Merge pull request #650 from annando/post-type
We don't store the "type" parameter anymore
2018-07-20 12:53:12 +02:00
Tobias Diekershoff a4c4bbc7b0
Merge pull request #651 from annando/notices
Fixes some notice
2018-07-20 12:49:55 +02:00
Michael 9616e770f3 Fixes some notice 2018-07-20 05:36:55 +00:00
Michael Vogel 18e43c0138
Merge pull request #649 from MrPetovan/task/5410-move-dba-to-src
[multiple] Move \dba to \Friendica\Database\dba
2018-07-20 06:50:49 +02:00