Commit Graph

7002 Commits

Author SHA1 Message Date
nupplaPhil 3291728059
Extract System emails from enotify
- Removed every SYSTEM_EMAIL occurrence in enotify
- Introduced a "SystemMailBuilder" for build system emails
- Replaced every SYSTEM_EMAIL usage in the classes with calling this builder
- Added tests for this new Builder
- Split the email templates between "base" template for email and concrete usages for different use cases
2020-02-02 22:43:35 +01:00
nupplaPhil 74490d6594
Cleanup enotify email
- Removing unused fields
- Move notify template to email subdirectory
2020-02-02 22:43:34 +01:00
Philipp 0406fe7ade
Merge pull request #8163 from MrPetovan/task/7817-custom-fields-part-3
New custom profile fields feature part 3: Updating the API
2020-01-31 22:39:11 +01:00
nupplaPhil abbf036685
improve exception handling 2020-01-31 22:25:09 +01:00
nupplaPhil 7909d9c417
Notifications cleared for a whole thread in case of one mark seen 2020-01-31 21:34:12 +01:00
Hypolite Petovan dd24b3bac0 Move api/profile/show to src/Module
- Update API documentation
- Update BaseApi::format to include headers by format
2020-01-29 23:31:37 -05:00
Hypolite Petovan b2143cae53 [frio] Add new asynchronous submission of modal form
- Add loading state for jot submit buttons
2020-01-29 22:50:10 -05:00
nupplaPhil c2b8c65104
Merge "notification" routes 2020-01-28 23:21:24 +01:00
nupplaPhil 91707a530c
Add default values for inserts 2020-01-28 22:26:23 +01:00
nupplaPhil 582f6bd4a3
Refactor API notification usage
- Remove "mapFields()" from BaseModel
- Add new Notification API entity (including collection)
- Add new NotificationFactory method "getApiList()"
2020-01-28 21:28:57 +01:00
nupplaPhil ff9eb20663
Fix enotify item link 2020-01-28 18:41:46 +01:00
nupplaPhil 443e106105
Fix missing notifications:
- Add namecache in enotify
- Add "unset()" in notify repository for additional field "abort"
- Add possibility for additional, non-saved fields in model
2020-01-28 18:41:45 +01:00
Hypolite Petovan a607656607 Replace profile tab GET parameter by route 2020-01-27 19:21:18 -05:00
Philipp 9827e933a2
Merge pull request #8179 from MrPetovan/bug/notices
Various notice fixes
2020-01-26 23:10:56 +01:00
nupplaPhil 765a0d8892
Some Renames:
- EMail => EMail
- toEmail => toAddress
- fromEmail => fromAddress
2020-01-26 23:47:16 +01:00
Hypolite Petovan dde2cf6ac0 Throw not found exception when photo item doesn't exist in prepare_photo_data()
- Addresses part of https://github.com/friendica/friendica/issues/8000#issuecomment-573883153
2020-01-26 16:43:14 -05:00
nupplaPhil 2b8f067715
Introduce interface for emailing and create email classes 2020-01-26 21:35:04 +01:00
nupplaPhil 915abe8a33
Add explicit parameters to Sender::send() method signature 2020-01-26 21:35:03 +01:00
nupplaPhil ea9d3b7438
Make EMailer util dynamic 2020-01-26 21:35:03 +01:00
Philipp 9269221825
Merge pull request #8175 from MrPetovan/task/revert-profile-default-tab
Revert profile base URL behavior
2020-01-26 20:33:27 +01:00
Hypolite Petovan e5ab4f1889 Re-enable pinned items in profile wall 2020-01-26 14:21:20 -05:00
nupplaPhil 0840938dff
Rename classes
- Repository/Model Notification => Notify
- Factory/Object Notification => Notification
2020-01-26 20:30:24 +01:00
nupplaPhil b85511b00d
Improvements:
- Fix API-select
- Introduce OTYPE-constants
- Rename `IntroductionFactory` methods
2020-01-26 14:33:10 +01:00
nupplaPhil 74f3a2f90c
Fix API result, add PHPDoc and cleanup object construction
Fix missing getters
fix data array
fix missing "$" for template-variables
Remove lazy-loaded parent notification instance (for now..)
2020-01-25 21:15:01 +01:00
nupplaPhil 0850fb88dd
ReWork Notification Model/Module/Object/Repository/Factory
- Introduce Repository for interaction with "notify" table
- Introduce Factory for read-only notification objects (they're just loosely based on notification the table!)
- Introduce Objects for type-safe usage at the presentation layer
- Reworked Model, which is now fully based on the notify table, including generated fields (cache, ..)
2020-01-25 19:58:22 +01:00
nupplaPhil 0f932ae723
Notify => Notification
Notifs => Notifications
2020-01-24 18:32:38 +01:00
Hypolite Petovan 6d7f0a6fd8 Remove duplicate profile_uid key in App->profile array 2020-01-20 07:32:46 -05:00
nupplaPhil ed9392469e
Remove unneeded Config namespace usages 2020-01-19 22:50:44 +01:00
nupplaPhil 6c36fd9e01
Move Config::get() to DI::config()->get() 2020-01-19 21:21:13 +01:00
nupplaPhil d6efc90194
cleanup namespace usages for L10n 2020-01-19 16:31:33 +01:00
nupplaPhil d3255afa66
Move L10n::withLang() calls to DI::l10n()->withLang() calls 2020-01-19 16:31:18 +01:00
nupplaPhil a9a36fb302
Move L10n::tt() calls to DI::l10n()->tt() calls 2020-01-19 16:31:17 +01:00
nupplaPhil 5dfee31108
Move L10n::t() calls to DI::l10n()->t() calls 2020-01-19 16:31:16 +01:00
Michael 0a4119adaf @brief is removed completely 2020-01-19 06:05:23 +00:00
nupplaPhil 800694e9b3
Remove unused use statements & remove PConfig class 2020-01-18 17:02:59 +01:00
nupplaPhil 9e9429b56d
Move PConfig::get() to DI::pConfig()->get() 2020-01-18 16:50:57 +01:00
Michael b83f328983 Remove "f" parameter / network page parameter cleanup 2020-01-13 20:10:13 +00:00
Michael ad11579eaa API: Use NOTIF_DIRECT_THREAD_COMMENT for the API mentions as well 2020-01-09 17:58:22 +00:00
Michael 469eefdc5b Notifications: Now declare direct thread answers as replies 2020-01-09 17:53:17 +00:00
Michael 3bf7664ee3 changed priority of messages 2020-01-08 22:36:31 +00:00
Michael d9ea0fea87 Use "replied" 2020-01-08 21:59:12 +00:00
Michael cabaea38ac Improved notification messages 2020-01-08 21:48:59 +00:00
Michael 4d5e15709c The item notifications now are based upon the "user-item" field 2020-01-06 00:59:18 +00:00
Michael 6670a2409f Fix condition creation 2020-01-05 19:48:01 +00:00
Michael f134903fcf API: We now use the "notification-type" field for mentions 2020-01-05 19:32:39 +00:00
nupplaPhil f0eea6f875
Remove get_app() in favor of DI::app() 2020-01-04 23:42:01 +01:00
Hypolite Petovan ebaf726744 Rework Feed::import parameters
- Remove unused $hub
- Replace $simulate with an implicit condition
2020-01-03 09:26:28 -05:00
nupplaPhil a4a7f19df1
Move redundant System::removedBaseUrl() to DI::baseUrl()->remove() calls 2019-12-30 23:03:56 +01:00
nupplaPhil 3f34229752
Move redundant System::baseUrl() to DI::baseUrl() calls 2019-12-30 23:00:08 +01:00
nupplaPhil 6d7362da41
Replace deprecated $a->page with DI::page() 2019-12-30 20:02:09 +01:00
nupplaPhil 4835f1185f
Remove deprecated App::module - replace with DI::module()->getName() 2019-12-29 20:17:52 +01:00
nupplaPhil 33674808dc
Remove deprecated App::cmd - replace with DI::args()->getCommand() 2019-12-29 20:17:51 +01:00
nupplaPhil e6f61c2cc7
Remove deprecated App::query_string - replace with DI::args()->getQueryString() 2019-12-29 20:17:50 +01:00
nupplaPhil 50be94aa5e
Remove deprecated App::getHostName() - process methods to DI::baseUrl()->getHostName() 2019-12-29 20:17:47 +01:00
nupplaPhil 8e6973b774
Refactor deprecated App::internalRedirect() to DI::baseUrl()->redirect() 2019-12-29 20:17:43 +01:00
nupplaPhil 181529f3df
Refactor dynamic App::getProfiler() to static DI::profiler() 2019-12-29 20:17:42 +01:00
nupplaPhil e2b2778e0a
Refactor dynamic App::getLogger() to static DI::logger() 2019-12-29 20:17:41 +01:00
nupplaPhil 388b963714
Replace BaseObject class with DI::* calls 2019-12-29 20:17:38 +01:00
nupplaPhil 1de3f186d7
Introduce new DI container
- Adding Friendica\DI class for getting dynamic classes
- Replacing BaseObject::getApp() with this class
2019-12-29 20:16:55 +01:00
nupplaPhil 7a2f4dc54e
Make L10n immutable
- Remove Push/Pop
- Add "withLang($lang)" method
2019-12-28 23:12:01 +01:00
Michael c037e9143c Additionally display the protocol together with the network 2019-12-27 17:24:29 +00:00
Tobias Diekershoff 00756737b5 Merge branch 'master' 2019.12 into develop 2019-12-23 20:03:47 +01:00
Michael 30dfbb95d9 Remove legacy function 2019-12-20 06:40:41 +00:00
Michael 295ee82a61 Changed "??" to "?:" 2019-12-19 12:39:30 +00:00
Michael 6dbaf34290 Issue 7685: Just forward on remoteauth for non legacy-DFRN and other contacts 2019-12-19 11:02:50 +00:00
Michael 1c7bc56cb3 API: Missing endpoint for reshares had been added 2019-12-19 07:19:03 +00:00
Michael 3a6a78ca46 Issue 7664: Don't notify every time a contact posted something 2019-12-18 06:36:43 +00:00
Michael 533f07e874 Issue 6867: Only display direct mentions in the corresponding API endpoint 2019-12-15 13:14:55 +00:00
Michael Vogel b2ae39db1a
Merge pull request #7943 from MrPetovan/bug/7920-api-fix-followers-friends-ids
Add relationship filter to api_friends_ids and api_followers_ids
2019-12-13 21:34:09 +01:00
Hypolite Petovan c2233e3416
Merge pull request #7947 from annando/api-attachments
API: Improved handling of quoted posts and attachments
2019-12-13 15:15:34 -05:00
Hypolite Petovan c9c30e4a23 Add relationship filter to api_friends_ids and api_followers_ids 2019-12-13 11:43:45 -05:00
Hypolite Petovan 81b9d25906 Add relationship filter to api_ff_ids() 2019-12-13 11:43:20 -05:00
Michael b42262f206 API: Improved handling of quoted posts and attachments 2019-12-13 10:12:40 +00:00
Hypolite Petovan 5a15e6bc59 Support post URL search term in api_search() 2019-12-12 20:59:19 -05:00
Hypolite Petovan 0069bb022d Support user profile URL search term in api_users_search() 2019-12-12 17:04:47 -05:00
nupplaPhil 54392fab81
Move Cookie to own class (with tests)
Move Authentication to App namespace
2019-12-08 22:45:34 +01:00
nupplaPhil 96555a7385
Refactor "Authentication" class with four main methods:
- withSession() - for auto authentication with Session/Cookie variables
- withOpenId() - for authentication with an OpenID account
- withPassword() - for authentication with Password
- setForUser() - for setting the user auth context of the current session

Refactor "Session" class - contains now "native" Session Management methods
2019-12-05 23:02:51 +01:00
Michael 043df55bc5 Make tests happy 2019-12-05 06:46:00 +00:00
Michael eeb8bee1b7 Use the new function to fetch shared information 2019-12-05 06:16:27 +00:00
Michael abf841ff79 Handle resharing of items with title via the API 2019-12-05 05:24:29 +00:00
Hypolite Petovan 4403aeeda5
Merge pull request #7901 from annando/disable-smart-threading
Changed the option to enable the smart threading with the option to disable this
2019-12-04 15:25:53 -05:00
Michael Vogel 9cf1aea8c9 Changed the option to enable the smart threading with the option to disable this 2019-12-04 21:21:20 +01:00
Michael 164e6b350d API: Improve attachment removal functionality for the status text 2019-12-02 21:19:47 +00:00
Michael d3e12c58e2 Fix some notices/warnings again 2019-11-21 22:40:54 +00:00
Michael Vogel bd6774bd9b Fix fatal errors, caused by an empty "verb" 2019-11-18 07:39:56 +01:00
Hypolite Petovan 35ece9924d
Merge pull request #7829 from annando/picture-links
Fix image links with descriptions in API and AP transmission
2019-11-12 07:14:27 -05:00
Michael 1b5fa55bdc Fix image links with descriptions in API and AP transmission 2019-11-11 22:37:50 +00:00
Hypolite Petovan f2c31ef1c0
Merge pull request #7828 from nupplaphil/task/move_enotify
Remove unnecessary code in "include/enotify"
2019-11-09 16:48:26 -05:00
Philipp Holzer dbbe3ec031
Remove deprecated method to find duplicates (issue from 2013) 2019-11-09 22:00:04 +01:00
Philipp Holzer f9e3ff4b55
Remove unnecessary hash function.
- Was introduced for getting the last inserted ID before "lastInstertID()" was possible
- See b821399f00 (diff-a8e86a3c07531e66a3b0b4c8b4b07879R148)
2019-11-09 21:50:52 +01:00
Michael fc94cad5f2 Pinned posts now work for visitors in the intended way 2019-11-08 06:52:44 +00:00
Michael 806e6a230e Added description, removed sorting 2019-11-07 07:41:54 +00:00
Michael 91ad7936f3 Only sort the profile after pinned 2019-11-07 07:39:50 +00:00
Michael 463c9131b6 Pinned items are always at the top 2019-11-07 07:09:46 +00:00
Hypolite Petovan 26b5de9a76 Rename Photo::newResource() result variable from $hash to $resource_id 2019-11-02 07:48:45 -04:00
Hypolite Petovan 03bf1dcbd3 Move Object\Image static methods to Util\Images
- Optimize imports in modified files
2019-11-02 07:48:45 -04:00
Philipp Holzer a72e65a760
Adapt class structure
- Introduce constants
- Add constructor parameters
- Add typehints
- Renamed fields more meaningful
- Renamed method names to match identifier
- Adjust PHP doc
- Add GetClass call at used places
2019-10-26 04:03:27 +02:00
Philipp Holzer 1f368d469f
Move Friendica\Core\NotificationsManager to Friendica\Model\Notify 2019-10-26 02:01:46 +02:00
Philipp Holzer 3897c74deb
Add docs 2019-10-25 00:10:20 +02:00
Philipp Holzer 07cea24430
Move Activity/Namespaces defines to constants 2019-10-24 21:40:12 +02:00
Philipp Holzer edf006905b
Move (last) get_cats_and_terms to Content\Item::determineCategoriesTerms()
- Added incomplete test
2019-10-23 02:48:46 +02:00
Philipp Holzer ad67fd3aa8
Move is_a_date_arg to DateTimeFormat::isYearMonth
- Improved functionality
- Added tests
2019-10-23 02:39:28 +02:00
Philipp Holzer 52c42491c4
Move activity_match() to Protocol\Activity::match()
- With tests
2019-10-23 02:05:11 +02:00
Philipp Holzer 9e94e8b48c
Remove function prepare_text and use BBCode::convert() instead 2019-10-23 00:58:13 +02:00
Philipp Holzer 2c31916757
Remove unused function qp() 2019-10-23 00:55:14 +02:00
Philipp Holzer 5843a80b6c
Move perms2str to ACLFormatter::aclToString()
- including new tests
2019-10-23 00:54:34 +02:00
Philipp Holzer f65f7f11c3
Move expand_acl to ACLFormatter::expand()
- including tests
2019-10-23 00:40:14 +02:00
Philipp Holzer 7a9c5d10ee
Remove unused function attribute_contains 2019-10-23 00:22:39 +02:00
Philipp Holzer a3e350313d
Move redir_private_images to Item::addRedirLinkToImageLinks() 2019-10-23 00:20:44 +02:00
Philipp Holzer 4704bf6394
Remove unused function return_bytes 2019-10-23 00:15:17 +02:00
Philipp Holzer 2870f42ca2
Move bb_translate_video
- To new Class BBCode\Video
- Adding tests
- Make BaseObject::getClass() public
2019-10-23 00:14:47 +02:00
Philipp Holzer 7f49c73730
Move undo_post_tagging to mod/editpost because of the only occurrence 2019-10-22 23:57:44 +02:00
Hypolite Petovan 8b836189d4 Replace deprecated defaults() calls with ?? and ?: in include/ and view/ 2019-10-16 08:51:03 -04:00
Hypolite Petovan f498068b0f Replace deprecated defaults() calls in include/api and boot 2019-10-12 22:01:34 -04:00
Hypolite Petovan cb4950a3be Replace duplicated authentication code in FKOAuth1 with Session::setAuthenticatedForUser 2019-10-06 11:17:30 -04:00
Hypolite Petovan 2333526b8a
Merge pull request #7678 from annando/remote-rework
Reworked the remote authentication
2019-09-30 09:18:43 -04:00
Philipp Holzer d5dd12b8f8
Add Drone CI
- Add drone test environment
- Add drone config
- apt phpunit
- Fix api.php
- Fix item.php
- Fix DBStructure
- Check if caching is possible during tests
2019-09-30 14:03:12 +02:00
Michael 83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
Michael 6e9026e033 Renamed function, beginning to replace the "remote_user" function 2019-09-28 09:36:41 +00:00
Michael ec66553032 Reworked "remote" cookie handling 2019-09-25 22:24:17 +00:00
Michael 461c3169b1 Issue 6521: Don't send notifications for deleted items 2019-09-10 05:44:09 +00:00
Michael 8fc8e26e23 Replace not working "redir" link with a working one 2019-09-09 21:37:26 +00:00
Michael a7d23a1196 API Support "friendica_html" 2019-09-03 21:11:33 +00:00
Michael 9cbf320c86 Issue 7563: Use icons instead of names on posts 2019-08-28 06:38:35 +00:00
Michael ae3c9eceed Support for posting multiple pictures via API 2019-08-06 05:34:04 +00:00
Hypolite Petovan c3e3e83a52 Improve BBCode:toPlaintext
- Fix issue where matching literal square brackets were removed with their content
- Fix issue where content without line feeds between BBCode tags would end up compacted in plain text
- Update extr calls to BBCode::toPlaintext in api
2019-08-04 10:22:23 -04:00
Michael 1b7f96dac8 Partly reverted, real problem fixed 2019-08-04 04:29:52 +00:00
Michael cb77b1af8c API: We now transmit the text description there as well 2019-08-04 03:45:23 +00:00
Michael fc59aa6bc7 The "contact-uid" is now a reliable proof for contacts that we follow 2019-08-03 10:44:16 +00:00
Hypolite Petovan 6c4fea5e6c
Merge pull request #7459 from annando/notice
Fix a notice when setting a picture description via API
2019-08-02 13:26:47 -04:00
Michael 5dc74513cc Fix a notice when setting a picture description via API 2019-08-02 16:43:36 +00:00
Michael Vogel e8459cce34
Merge pull request #7381 from MrPetovan/task/7309-frio-compose
[frio] New Compose page
2019-08-01 08:15:02 +02:00
Michael b4c673a620 We now use a central function for fetching the postdata 2019-07-30 22:26:01 +00:00
Michael 223cb8f037 We can now set image descriptions via API 2019-07-30 05:02:26 +00:00
Hypolite Petovan 0579252362 Add user meta-groups for followers and mutual contacts
- Both Group::expand and Item::enumeratePermissions now have a user id parameter to expand meta-groups
2019-07-29 20:31:46 -04:00
Hypolite Petovan b684fffcb7 Replace last instance of Contact::select 2019-07-27 23:51:04 -04:00
Philipp Holzer 2f5928f43a
Refactoring Profile:: selectors 2019-07-28 00:19:38 +02:00
Philipp Holzer 46211de037
Fix DBA::fetch in API 2019-07-27 23:54:15 +02:00
Philipp Holzer b7f1de1e64
Revert $term DB result check 2019-07-27 23:54:14 +02:00
Philipp Holzer 2a87464c97
Replace q() call with Profile::get() method 2019-07-27 23:54:12 +02:00
Michael 5120c27d10 Fix displaying of reshared items 2019-07-27 20:21:11 +00:00
hlad c8ee4cc49f we work with utf8 string so we should use multibyte functions 2019-07-26 12:57:39 +02:00
Hypolite Petovan cd257dc7e8 Enable app-specific password authentication for API login 2019-07-22 07:56:36 -04:00
Michael 23830dc45f Preparation for quoted reshares on AP 2019-07-20 21:32:19 +00:00
Philipp Holzer 8f0aa0ca5a
bugfix: add missing group by parameters 2019-07-14 22:12:14 +02:00
Michael 6bb418c5a7 Use "received" instead of "created" when displaying posts in creation order 2019-07-07 21:30:33 +00:00
Michael 6041f74df6 New constant for federated protocols 2019-07-01 18:00:55 +00:00
Michael Vogel 26accbe3ef
Merge pull request #7296 from MrPetovan/task/smilies-replace
Limit smilies replacement to BBCode::convert
2019-06-24 22:05:37 +02:00
Philipp Holzer 082634adbc
Moving from DBA to Database 2019-06-24 09:36:07 +02:00
Hypolite Petovan b51fb8c994 Fix typo in docblock in include/text 2019-06-23 17:53:25 -04:00