Commit Graph

1096 Commits

Author SHA1 Message Date
Michael 3fc3ded750 Useless info messages removed 2020-07-23 06:11:21 +00:00
nupplaPhil 1124090dbc Cleanup dependencies 2020-07-21 03:19:04 -04:00
nupplaPhil 657d08f09f Rename "fetchUrl" and "fetchUrlFull" to "fetch" and "fetchFull" 2020-07-21 03:15:53 -04:00
nupplaPhil 7029012f27 Rename "HTTPRequest::curl()" to HTTPRequest::get() 2020-07-21 03:14:01 -04:00
nupplaPhil 1aa07f87a4 Make "HTTPRequest::fetchUrl" dynamic 2020-07-21 03:04:58 -04:00
nupplaPhil 3b4cf87c95 Make "HTTPRequest::fetchUrlFull" dynamic 2020-07-21 03:02:52 -04:00
nupplaPhil 2973ed6448 Make "HTTPRequest::curl" dynamic 2020-07-21 03:01:12 -04:00
nupplaPhil 5344efef71 Move post/curl/fetchUrl/fetchUrlFull to own class "Network\HTTPRequest" 2020-07-21 02:56:10 -04:00
Michael 5bf813d0ec Use "failed" field 2020-07-19 11:42:23 +00:00
Michael 70699878ee Replaced more calls of "Probe::uri" with "Contact::getByURL" 2020-07-16 19:22:38 +00:00
Michael b8682190de Fix fallback on unknown contact 2020-07-16 04:18:33 +00:00
Hypolite Petovan 631095eefd
Merge pull request #8883 from annando/replace-getdetails
Replaced "getDetailsByURL" with "getByURL/getByURLForUser"
2020-07-15 13:49:27 -04:00
Michael 6d3949d54a Changed default value 2020-07-15 17:29:52 +00:00
Michael e374aecc46 Changed parameter order for "getbyURLForUser" 2020-07-15 17:22:12 +00:00
Michael d9c6a46ffe Replaced "getDetailsByURL" with "getByURL/getByURLForUser" 2020-07-15 04:42:04 +00:00
Hypolite Petovan 059087f998 Suppress all emails when Update::run is ran with $sendEmail = false
- Address Renderer crash in the App-less context of Console
2020-07-13 17:22:21 -04:00
Michael bbb2f1fcf5 Use "0" as default 2020-07-13 16:24:44 +00:00
Michael 5a6887fb2e Use "jsonexit" 2020-07-13 13:26:09 +00:00
Michael fcb37449f3 Fix unneeded database functions in the callstack 2020-07-10 07:01:28 +00:00
Hypolite Petovan 20a4799902 Update references to the friendica/friendica-directory stable branch 2020-06-30 15:25:17 -04:00
Hypolite Petovan 9c6fbc6a74 Update references to the friendica/friendica stable branch 2020-06-30 15:25:16 -04:00
Hypolite Petovan 779099a491 Improve language of console globalcommunitysilence help line 2020-06-03 00:03:58 -04:00
Michael e374e5752a Changed deprecated log calls 2020-06-01 13:51:58 +00:00
Michael Vogel e315bc3eae
Merge pull request #8657 from MrPetovan/bug/8653-catch-template-engine-errors
Catch template engine errors
2020-05-19 00:22:45 +02:00
Hypolite Petovan 8b05af176c Add detailed error messages for admin user in Core\Renderer and Render\FriendicaSmartyEngine 2020-05-18 18:10:21 -04:00
Hypolite Petovan 64e89a516d Restore default parameter value in Core\Renderer::replaceMacros 2020-05-18 10:01:51 -04:00
Hypolite Petovan ef9b51e631 Replace direct error output and exit by logger + exception in Core\Renderer
- Same in Render\FriendicaSmartyEngine
2020-05-18 01:21:58 -04:00
Hypolite Petovan c6ba92c43d Refactor template engine code
- Convert ITemplateEngine interface to abstract class
- Remove dependency to App in FriendicaSmarty and FriendicaSmartyEngine
- Normalize replaceMacro parameter behavior using Smarty template string prefixes
- Remove obsolete FriendicaSmarty->parsed method
- Update unused Smarty directory paths
2020-05-18 01:18:41 -04:00
Michael a3c4021f12 Issue 8514: Make paging for searcg items work again
Fixes #8514
2020-05-17 13:51:56 +00:00
Michael 6f3b46217e Fix for "Undefined index: profile_url" 2020-04-28 19:36:10 +00:00
Michael 9ccdbd9349 Added forgotten DBA::close 2020-04-28 05:55:17 +00:00
Hypolite Petovan 1b0a8ec5c0
Merge pull request #8545 from nupplaphil/bug/subdir
Template Engine with Subdirectory
2020-04-26 14:31:30 -04:00
Philipp f5f62d3f42
Template Engine with Subdirectory
- Use explicit root path for template engine
- Replace "__DIR__" calls in addons with subdirectories
- Fixes local tests, where call is made out of '/' and not '/vagrant/'
2020-04-26 15:45:25 +02:00
Michael 1c980c5b29 The workerqueue is now using a view as well 2020-04-24 18:50:36 +00:00
Michael d4480ae4be Simplified code 2020-03-10 13:13:43 +00:00
Michael 8e421f0893 Fix uninstall of installed addons 2020-03-09 23:28:37 +00:00
Hypolite Petovan 39a87b1f54 Add check for semi-colon existence in theme file comment lines
- Address https://github.com/friendica/friendica/issues/8000#issuecomment-592946450
2020-03-01 14:19:46 -05:00
nupplaPhil f3f764bc39
Add new possibility to add a user per console 2020-02-29 17:10:27 +01:00
nupplaPhil 4d436c10df
Move "NewPassword" to a common "user" console command 2020-02-29 17:10:26 +01:00
Michael 1b87a97a81 Remove "hidewall" check from ACL 2020-02-22 08:54:28 +00:00
Hypolite Petovan 1a8110234f Move /settings/display module to src/ 2020-02-20 05:37:06 -05:00
Michael Vogel b6b567fc97
Merge pull request #8315 from MrPetovan/task/8310-improve-manifest
Update manifest output with config/theme info
2020-02-20 09:34:36 +01:00
Michael 7ee9aad6ca Some more unneeded settings removed 2020-02-19 19:31:55 +00:00
Hypolite Petovan b9325251e8 Add Theme::getBackgroundColor and Theme::getThemeColor methods 2020-02-19 10:28:57 -05:00
Hypolite Petovan 5d169a4098 Add System::htmlUpdateExit() method to refactor update modules 2020-02-16 04:32:56 -05:00
nupplaPhil 23c64b9a11
Add license info at Friendica classes 2020-02-09 15:45:36 +01:00
nupplaPhil 0b94b84dc7
simplify mail creation 2020-02-04 21:05:33 +01:00
nupplaPhil 262c94f12f
Fix indents 2020-02-02 22:43:43 +01:00
nupplaPhil ed9756225d
improvements 2020-02-02 22:43:42 +01:00
nupplaPhil 97e708f2e2
Remove DI::app() dependency again 2020-02-02 22:43:41 +01:00
nupplaPhil 9428466d1d
Set Sitename / site email as sender for system emails 2020-02-02 22:43:39 +01:00
nupplaPhil 3291728059
Extract System emails from enotify
- Removed every SYSTEM_EMAIL occurrence in enotify
- Introduced a "SystemMailBuilder" for build system emails
- Replaced every SYSTEM_EMAIL usage in the classes with calling this builder
- Added tests for this new Builder
- Split the email templates between "base" template for email and concrete usages for different use cases
2020-02-02 22:43:35 +01:00
nupplaPhil d4e836855b
Remove deprecated code 2020-02-01 00:05:27 +01:00
Hypolite Petovan b03796957b Improve logging in mod/item
- Set legacy Logger constants as deprecated
2020-01-29 22:42:49 -05:00
Hypolite Petovan 451596f5b3 Rename migration method for clarity in Repository\ProfileField 2020-01-23 14:00:42 -05:00
Hypolite Petovan e8bf74914b Update user import/export with profile fields
- Account for backward compatibility when exporting: add values for profile.is-default and profile.profile-name fields
- Account for forward compatibility when importing: migrate legacy profiles to custom profile fields
2020-01-22 19:42:37 -05:00
Hypolite Petovan 1c50bc58e4 Move Permission Set over to DDD
- Add Permission Set Repository, Model and Collection
- Mark static PermissionSet method as deprecated
2020-01-20 07:35:05 -05:00
Hypolite Petovan f0474c07ce Add "Yourself" ACL choice and allow multiple ACL selectors on a single page 2020-01-20 07:32:48 -05:00
Hypolite Petovan f97a358a9b Normalize the return value type of Session::getRemoteContactID 2020-01-20 07:32:46 -05:00
Hypolite Petovan 04d620fc2f
Merge pull request #8142 from nupplaphil/task/di_config
CleanUp Config namespace
2020-01-19 22:22:57 -05:00
nupplaPhil d5a473abda
Shorten "PConfiguration" to "PConfig" again, since the Wrapper is gone 2020-01-19 22:23:44 +01:00
Michael dcbd44ab88 Removed the rest of the @brief fields 2020-01-19 20:44:01 +00:00
nupplaPhil cb80108957
Shorten "Configuration" to "Config" again, since the Wrapper is gone 2020-01-19 21:29:36 +01:00
nupplaPhil 2204016071
Delete Core\Config 2020-01-19 21:23:00 +01:00
nupplaPhil a6a2efa18a
Move Config::delete() to DI::config()->delete() 2020-01-19 21:22:33 +01:00
nupplaPhil 3411ced833
Move Config::set() to DI::config()->set() 2020-01-19 21:21:53 +01:00
nupplaPhil 6c36fd9e01
Move Config::get() to DI::config()->get() 2020-01-19 21:21:13 +01:00
nupplaPhil 5d294e8be8
Move Config::load() to DI::config()->load() 2020-01-19 21:20:10 +01:00
nupplaPhil 8138b05032
fix L10n path after move 2020-01-19 17:11:48 +01:00
nupplaPhil 174129af94
add missing namespaces/fix wrong class-names 2020-01-19 16:31:35 +01:00
nupplaPhil 0e6a675cb5
cleanups 2020-01-19 16:31:33 +01:00
nupplaPhil 2838635d64
Move L10n class from L10n subdir to Core (replacing old wrapper) 2020-01-19 16:31:30 +01:00
nupplaPhil d3255afa66
Move L10n::withLang() calls to DI::l10n()->withLang() calls 2020-01-19 16:31:18 +01:00
nupplaPhil a9a36fb302
Move L10n::tt() calls to DI::l10n()->tt() calls 2020-01-19 16:31:17 +01:00
nupplaPhil 5dfee31108
Move L10n::t() calls to DI::l10n()->t() calls 2020-01-19 16:31:16 +01:00
Michael cdbc94a9e1 Some more added lines 2020-01-19 09:51:37 +00:00
Michael 0a4119adaf @brief is removed completely 2020-01-19 06:05:23 +00:00
Hypolite Petovan 8536b313a1
Merge pull request #8131 from nupplaphil/task/cleanup_lock
CleanUp Lock namespace
2020-01-18 14:13:14 -05:00
nupplaPhil 41ff43dcdd
CleanUp Lock namespace
- introduce enum Lock - "Type"
- Move Lock/Lock to BaseLock
2020-01-18 20:15:46 +01:00
Hypolite Petovan 58f69481e6
Merge pull request #8130 from nupplaphil/task/di_pconfig
Move PConfig to DI::pConfig()
2020-01-18 13:57:57 -05:00
nupplaPhil 800694e9b3
Remove unused use statements & remove PConfig class 2020-01-18 17:02:59 +01:00
nupplaPhil b5c0df439f
Move PConfig::delete() to DI::pConfig()->delete() 2020-01-18 16:56:46 +01:00
nupplaPhil 88bb66371c
Move PConfig::set() to DI::pConfig()->set() 2020-01-18 16:54:50 +01:00
nupplaPhil 9e9429b56d
Move PConfig::get() to DI::pConfig()->get() 2020-01-18 16:50:57 +01:00
nupplaPhil 6e2880c679
Move PConfig::load() to DI::pConfig()->load() 2020-01-18 15:59:01 +01:00
nupplaPhil 424c87195b
CleanUp Cache namespace
- Introduce enum "Duration"
- Introduce enum "Type"
- Move "Cache\Cache" to "BaseCache"
2020-01-18 15:41:19 +01:00
nupplaPhil ca8ca05051
Add legacy backend storage functionality 2020-01-17 23:55:19 +01:00
nupplaPhil 732992a296
Improve impossible exception-handler for storage move 2020-01-17 23:55:18 +01:00
nupplaPhil 0af83e6f7c
Rename bool flag for user backend 2020-01-17 23:55:08 +01:00
nupplaPhil 9bb5891645
Fix loading SystemResource files 2020-01-17 19:31:34 +01:00
Hypolite Petovan 36190d1e79
Merge pull request #8072 from nupplaphil/task/Cache_to_DI
Replace Core\Cache wrapper with DI::cache() method
2020-01-10 08:46:03 -05:00
nupplaPhil bfae6766bf
Implement Hook::callAll('storage_instance') call for addons and add a description for it.
- Remove implicit Dice usage
- Add concrete instance creating
- Adding Hook call for addon instance creating
- Updating doc for Hook
- Updating tests
2020-01-10 13:22:03 +01:00
nupplaPhil dbd5b5bb6e
- Fixing SystemResource
- Adding tests for StorageManager
- Updating doc
2020-01-10 13:21:58 +01:00
nupplaPhil 08edeae2f9
Make Storage testable & add tests
- Making StorageManager dynamic (DI::facStorage())
- Making concrete Storage dynamic (DI::storage())
- Add tests for Storage backend and failure handling
- Bumping Level-2/Dice to "dev-master" until new release
- Using Storage-Names instead of Storage-Classes in config (includes migration)
2020-01-10 13:21:57 +01:00
nupplaPhil a38b0f7eaf
Move remaining namespaces and delete Core\Cache.php 2020-01-07 00:51:02 +01:00
nupplaPhil fe078410a1
Move Cache::get() to DI::cache()->get() 2020-01-07 00:45:49 +01:00
nupplaPhil f68929633b
Move Cache::set() to DI::cache()->set() 2020-01-07 00:41:20 +01:00
nupplaPhil 3369dfaad9
Remove unused function Cache::delete() 2020-01-07 00:37:01 +01:00
nupplaPhil 182f390520
Move Cache::clear() to DI::cache()->clear() 2020-01-07 00:36:07 +01:00
nupplaPhil f7ca437ba6
Remove unused method Cache::getAllKeys() 2020-01-07 00:36:06 +01:00
nupplaPhil 31457b8566
Replace Lock::release() with DI::lock()->release() and remove Core\Lock 2020-01-07 00:24:10 +01:00
nupplaPhil 634e657d23
Replace Lock::acquire() with DI::lock()->acquire() 2020-01-07 00:20:31 +01:00
Hypolite Petovan 64c8855407 Allow special groups in default user permissions
- Use ACLFormatter in ACL::getDefaultUserPermissions
- Remove ACL::fixACL
- Add return value to Contact::pruneUnavailable
2020-01-05 17:09:14 -05:00
Hypolite Petovan 393a671501
Merge pull request #8055 from nupplaphil/task/remove_get_server
Remove get_server() in favor of Search::getGlobalDirectory()
2020-01-04 20:10:50 -05:00
nupplaPhil 48baa0be4b
Remove get_server() in favor of Search::getGlobalDirectory() 2020-01-05 00:04:55 +01:00
nupplaPhil 244f440d97
Remove unused killme() 2020-01-04 23:43:13 +01:00
nupplaPhil f0eea6f875
Remove get_app() in favor of DI::app() 2020-01-04 23:42:01 +01:00
Michael fb550a0172 Relocated functions from PortableContact to GServer 2020-01-01 21:29:36 +00:00
nupplaPhil e2dc1d7477
Remove deprecated call 2019-12-30 23:08:06 +01:00
nupplaPhil 3f34229752
Move redundant System::baseUrl() to DI::baseUrl() calls 2019-12-30 23:00:08 +01:00
Hypolite Petovan 6f199ab7b3
Add missing return statement in Core\L10n
- Addresses https://github.com/friendica/friendica/issues/7998#issuecomment-569560492
2019-12-29 22:47:32 -05:00
nupplaPhil c1dbb25656
Creating interfaces for Config/PConfig & fix tests 2019-12-29 20:18:19 +01:00
nupplaPhil 4835f1185f
Remove deprecated App::module - replace with DI::module()->getName() 2019-12-29 20:17:52 +01:00
nupplaPhil e944d7bed6
Remove deprecated App::getBaseURL() - process methods to DI::baseUrl()->get() 2019-12-29 20:17:48 +01:00
nupplaPhil 50be94aa5e
Remove deprecated App::getHostName() - process methods to DI::baseUrl()->getHostName() 2019-12-29 20:17:47 +01:00
nupplaPhil e93fba5136
Remove deprecated App::removeBaseURL - process methods to DI::baseUrl()->remove() 2019-12-29 20:17:45 +01:00
nupplaPhil 5609e94b05
Refactor deprecated App - process methods to DI::process()->*() 2019-12-29 20:17:45 +01:00
nupplaPhil 8e6973b774
Refactor deprecated App::internalRedirect() to DI::baseUrl()->redirect() 2019-12-29 20:17:43 +01:00
nupplaPhil 9cec293ccc
Refactor dynamic App::getMode() to static DI::mode() 2019-12-29 20:17:42 +01:00
nupplaPhil 181529f3df
Refactor dynamic App::getProfiler() to static DI::profiler() 2019-12-29 20:17:42 +01:00
nupplaPhil e2b2778e0a
Refactor dynamic App::getLogger() to static DI::logger() 2019-12-29 20:17:41 +01:00
nupplaPhil fceb4f3823
Refactor dynamic App::getConfig() to static DI::config() 2019-12-29 20:17:40 +01:00
nupplaPhil 388b963714
Replace BaseObject class with DI::* calls 2019-12-29 20:17:38 +01:00
nupplaPhil 1de3f186d7
Introduce new DI container
- Adding Friendica\DI class for getting dynamic classes
- Replacing BaseObject::getApp() with this class
2019-12-29 20:16:55 +01:00
Hypolite Petovan a9220aa83b
Merge pull request #8026 from nupplaphil/task/l10n_immutable
Make L10n immutable
2019-12-29 13:54:32 -05:00
nupplaPhil 71a38180e9
Check for same language 2019-12-29 16:39:25 +01:00
nupplaPhil 673c4537e4
Session - Remove unneeded cookie parameter 2019-12-29 00:03:58 +01:00
nupplaPhil 7a2f4dc54e
Make L10n immutable
- Remove Push/Pop
- Add "withLang($lang)" method
2019-12-28 23:12:01 +01:00
Hypolite Petovan 94954c810b
Merge pull request #7996 from annando/poco-cleanup
The PoCo-Workers had been split
2019-12-24 05:13:36 -05:00
Tobias Diekershoff 00756737b5 Merge branch 'master' 2019.12 into develop 2019-12-23 20:03:47 +01:00
Michael 37f0519514 'SearchDirectory' created (moved out of 'DiscoverPoco' mess) 2019-12-20 20:30:13 +00:00
Hypolite Petovan 77e00f11a7 Add type-hint to debug null value fatal error
- Part of https://github.com/friendica/friendica/issues/7675#issuecomment-566076500
2019-12-16 11:05:08 -05:00
Hypolite Petovan 6e4a428c73
Merge pull request #7907 from nupplaphil/task/reduce_app_deps
Cleanup Session/Authentication
2019-12-14 09:53:40 -05:00
Hypolite Petovan fe5b80b9ba Return early if user.uid isn't present in ACL::getFullSelectorHTML
- Addresses https://github.com/friendica/friendica/issues/7675#issuecomment-565533824
2019-12-13 13:29:18 -05:00
nupplaPhil 1408908c84
Refactor Session Handling (make it more simple & handler are now handler again) 2019-12-11 20:30:31 +01:00
nupplaPhil 02c40ad1cb
Overwrite constructor of Memory session handling so no session ini-setting in backend/testing environments are possible 2019-12-10 23:35:16 +01:00
nupplaPhil b9f8762eb3
Use Native Session functions (global "$_SESSION" variable) for Memory class because of the direct usage of the $_SESSION class all around the codebase 2019-12-10 22:29:49 +01:00
nupplaPhil ce2610000b
Renaming class 2019-12-10 08:49:33 +01:00
nupplaPhil 26bd956912
Optimize L10n usage for Session (reduce "App" complexity even more) 2019-12-10 00:56:49 +01:00
nupplaPhil cad7e534a4
Add phpdoc 2019-12-10 00:50:05 +01:00
nupplaPhil 555513e4b4
Add Session Management instances (including Depenency Injection)
- Prerequesite for mocking Sessions
- Reduce "App" class complexity
2019-12-10 00:44:56 +01:00
nupplaPhil 009a8bb939
Initializing SessionHandlers with Dependency Injection 2019-12-09 23:09:18 +01:00
nupplaPhil 54392fab81
Move Cookie to own class (with tests)
Move Authentication to App namespace
2019-12-08 22:45:34 +01:00
Michael b1fa0e8e26 ACL: Contact list is now sorted, forums reappeared 2019-12-06 07:25:21 +00:00
Hypolite Petovan 7cfe05f849 Restore correct test for hidewall in ACL::getFullSelectorHTML 2019-12-05 20:05:47 -05:00
nupplaPhil 96555a7385
Refactor "Authentication" class with four main methods:
- withSession() - for auto authentication with Session/Cookie variables
- withOpenId() - for authentication with an OpenID account
- withPassword() - for authentication with Password
- setForUser() - for setting the user auth context of the current session

Refactor "Session" class - contains now "native" Session Management methods
2019-12-05 23:02:51 +01:00
nupplaPhil 18a3d18ba6
Move Authentication methods to class "Authentication" 2019-12-05 23:02:50 +01:00
Hypolite Petovan f989c331a3 Fix warnings about unexpected parameter array values type in ACL::getFullSelectorHTML
- Addresses https://github.com/friendica/friendica/issues/7676#issuecomment-560503744
2019-12-03 06:59:51 -05:00
Philipp 6531819971
Merge pull request #7884 from MrPetovan/bug/7834-ignore-reload
Restore post reload after (un)ignore
2019-12-02 09:40:31 +01:00
Hypolite Petovan 01b81f7bba
Merge pull request #7885 from nupplaphil/bug/7881_allowed_themes
Themes are now saved just once
2019-12-01 08:12:20 -05:00