From e04b679e6a70e296c162412511e7d5c1e0c25b40 Mon Sep 17 00:00:00 2001
From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Tue, 5 Nov 2019 08:20:27 -0500
Subject: [PATCH] Improve ForumManager::profileAdvanced logic
---
src/Content/ForumManager.php | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/src/Content/ForumManager.php b/src/Content/ForumManager.php
index f3f3392ec1..ce945aa1d6 100644
--- a/src/Content/ForumManager.php
+++ b/src/Content/ForumManager.php
@@ -5,8 +5,8 @@
*/
namespace Friendica\Content;
-use Friendica\Core\Protocol;
use Friendica\Content\Text\HTML;
+use Friendica\Core\Protocol;
use Friendica\Core\Renderer;
use Friendica\Database\DBA;
use Friendica\DI;
@@ -152,8 +152,8 @@ class ForumManager
public static function profileAdvanced($uid)
{
$profile = intval(Feature::isEnabled($uid, 'forumlist_profile'));
- if (! $profile) {
- return;
+ if (!$profile) {
+ return '';
}
$o = '';
@@ -167,19 +167,15 @@ class ForumManager
$contacts = self::getList($uid, $lastitem, false, false);
$total_shown = 0;
- $forumlist = '';
foreach ($contacts as $contact) {
- $forumlist .= HTML::micropro($contact, true, 'forumlist-profile-advanced');
- $total_shown ++;
+ $o .= HTML::micropro($contact, true, 'forumlist-profile-advanced');
+ $total_shown++;
if ($total_shown == $show_total) {
break;
}
}
- if (count($contacts) > 0) {
- $o .= $forumlist;
- return $o;
- }
+ return $o;
}
/**