From a7b2db5db9e4cc244ed14a22c4640432e02fbd06 Mon Sep 17 00:00:00 2001
From: Michael <heluecht@pirati.ca>
Date: Thu, 11 Jan 2018 21:31:44 +0000
Subject: [PATCH] When no OEmbedding is wanted, the links are now created fine
 again

---
 include/bbcode.php     | 4 ++--
 src/Content/OEmbed.php | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/bbcode.php b/include/bbcode.php
index 08bfab3ed7..d389f302b7 100644
--- a/include/bbcode.php
+++ b/include/bbcode.php
@@ -75,7 +75,7 @@ function bb_attachment($return, $simplehtml = false, $tryoembed = true)
 		$return = sprintf('<a href="%s" target="_blank">%s</a><br>', $data["url"], $data["title"]);
 	} else {
 		try {
-			if ($tryoembed) {
+			if ($tryoembed && OEmbed::isAllowedURL($data['url'])) {
 				$return = OEmbed::getHTML($data['url'], $data['title']);
 			} else {
 				throw new Exception('OEmbed is disabled for this attachment.');
@@ -94,7 +94,7 @@ function bb_attachment($return, $simplehtml = false, $tryoembed = true)
 			if (($data["type"] == "photo") && ($data["url"] != "") && ($data["image"] != "")) {
 				$return .= sprintf('<a href="%s" target="_blank"><img src="%s" alt="" title="%s" class="attachment-image" /></a>', $data["url"], proxy_url($data["image"]), $data["title"]);
 			} else {
-				$return .= sprintf('[bookmark=%s]%s[/bookmark]', $data['url'], $data['title']);
+				$return .= sprintf('<h4><a href="%s">%s</a></h4>', $data['url'], $data['title']);
 			}
 
 			if (trim($data["description"]) != "") {
diff --git a/src/Content/OEmbed.php b/src/Content/OEmbed.php
index 1b21dbf036..ff02563457 100644
--- a/src/Content/OEmbed.php
+++ b/src/Content/OEmbed.php
@@ -322,7 +322,7 @@ class OEmbed
 		$url = str_replace(array("http://www.youtube.com/", "http://player.vimeo.com/"),
 					array("https://www.youtube.com/", "https://player.vimeo.com/"), $url);
 
-		$o = OEmbed::fetchURL($url);
+		$o = self::fetchURL($url);
 
 		if (!is_object($o) || $o->type == 'error') {
 			throw new Exception('OEmbed failed for URL: ' . $url);
@@ -332,7 +332,7 @@ class OEmbed
 			$o->title = $title;
 		}
 
-		$html = OEmbed::formatObject($o);
+		$html = self::formatObject($o);
 
 		return $html;
 	}