From 3d97170ad0c1b5d3aace4120b6727118f08c2a4a Mon Sep 17 00:00:00 2001
From: Raroun <Raroun@users.noreply.github.com>
Date: Sun, 12 Nov 2023 11:03:33 +0100
Subject: [PATCH 1/5] Update wall_thread.tpl to match feature request

---
 view/theme/frio/templates/wall_thread.tpl | 58 +++++++++++------------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/view/theme/frio/templates/wall_thread.tpl b/view/theme/frio/templates/wall_thread.tpl
index 14ce750fab..8defb82348 100644
--- a/view/theme/frio/templates/wall_thread.tpl
+++ b/view/theme/frio/templates/wall_thread.tpl
@@ -125,16 +125,11 @@ as the value of $top_child_total (this is done at the end of this file)
 			{{* contact info header*}}
 		<div class="contact-info">
 			<div class="preferences">
-				{{if $item.network_icon != ""}}
-					<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>
+				{{if $item.network_icon != "" && $item.plink}}
+					<span class="wall-item-network"><a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" target="_blank"><i class="fa fa-{{$item.network_icon}} fakelink" title="{{$item.network_name}} - {{$item.plink.title}}" aria-hidden="true"></i></span>
 				{{else}}
 					<span class="wall-item-network" title="{{$item.app}}">{{$item.network_name}}</span>
 				{{/if}}
-				{{if $item.plink}}	{{*link to the original source of the item *}}
-					<a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" title="{{$item.plink.title}}" target="_blank">
-						<i class="fa fa-external-link"></i>
-					</a>
-				{{/if}}
 			</div>
 		{{if $item.thread_level==1}}
 			<div class="hidden-sm hidden-xs media-body"><!-- <= For computer -->
@@ -148,13 +143,6 @@ as the value of $top_child_total (this is done at the end of this file)
 						<span class="wall-item-name {{$item.osparkle}}" id="wall-item-ownername-{{$item.id}}">{{$item.owner_name}}</span>
 					</a>
 				{{/if}}
-				{{if $item.connector}}
-					<small><i class="fa fa-plug" title="{{$item.connector}}" aria-hidden="true"></i></small>
-				{{else}}
-					<span class="navicon lock fakelink" onClick="lockview(event, 'item', {{$item.id}});" title="{{$item.privacy}}" data-toggle="tooltip">
-						&nbsp;<small><i class="fa {{if $item.private == 1}}fa-lock{{elseif $item.private == 0}}fa-globe{{else}}fa-low-vision{{/if}}" aria-hidden="true"></i></small>
-					</span>
-				{{/if}}
 				</h4>
 
 				<div class="additional-info text-muted">
@@ -173,7 +161,15 @@ as the value of $top_child_total (this is done at the end of this file)
 								&bull; <i class="fa fa-thumb-tack" aria-hidden="true" title="{{$item.pinned}}"></i>
 								<span class="sr-only">{{$item.pinned}}</span>
 							{{/if}}
-
+							{{if $item.connector}}
+								&bull;
+								<small><i class="fa fa-plug" title="{{$item.connector}}" aria-hidden="true"></i></small>
+							{{else}}
+								&bull;	
+								<span class="navicon lock fakelink" onClick="lockview(event, 'item', {{$item.id}});" title="{{$item.privacy}}" data-toggle="tooltip">
+									<small><i class="fa {{if $item.private == 1}}fa-lock{{elseif $item.private == 0}}fa-globe{{else}}fa-low-vision{{/if}}" aria-hidden="true"></i></small>
+								</span>
+							{{/if}}
 						</small>
 					</div>
 
@@ -190,13 +186,6 @@ as the value of $top_child_total (this is done at the end of this file)
 			<div class="contact-info-xs hidden-lg hidden-md"><!-- <= For smartphone (responsive) -->
 				<h5 class="media-heading">
 					<a href="{{$item.profile_url}}" title="{{$item.linktitle}}" class="wall-item-name-link userinfo hover-card"><span>{{$item.name}}</span></a>
-                {{if $item.connector}}
-					<small><i class="fa fa-plug" title="{{$item.connector}}" aria-hidden="true"></i></small>
-                {{else}}
-					<span class="navicon lock fakelink" onClick="lockview(event, 'item', {{$item.id}});" title="{{$item.privacy}}" data-toggle="tooltip">
-						<small><i class="fa {{if $item.private == 1}}fa-lock{{elseif $item.private == 0}}fa-globe{{else}}fa-low-vision{{/if}}" aria-hidden="true"></i></small>
-					</span>
-                {{/if}}
 					<p class="text-muted">
 						<small>
 							<a href="{{$item.plink.orig}}">
@@ -209,6 +198,15 @@ as the value of $top_child_total (this is done at the end of this file)
 							{{if $item.direction}}
 								{{include file="sub/direction.tpl" direction=$item.direction}}
 							{{/if}}
+							{{if $item.connector}}
+								&bull;
+								<small><i class="fa fa-plug" title="{{$item.connector}}" aria-hidden="true"></i></small>
+							{{else}}
+								&bull;
+								<span class="navicon lock fakelink" onClick="lockview(event, 'item', {{$item.id}});" title="{{$item.privacy}}" data-toggle="tooltip">
+								<i class="fa {{if $item.private == 1}}fa-lock{{elseif $item.private == 0}}fa-globe{{else}}fa-low-vision{{/if}}" aria-hidden="true"></i>
+								</span>
+							{{/if}}
 						</small>
 					</p>
 				</h5>
@@ -218,13 +216,6 @@ as the value of $top_child_total (this is done at the end of this file)
 			<div class="contact-info-comment">
 				<h5 class="media-heading">
 					<a href="{{$item.profile_url}}" title="{{$item.linktitle}}" class="wall-item-name-link userinfo hover-card"><span class="fakelink">{{$item.name}}</span></a>
-					{{if $item.connector}}
-						<small><i class="fa fa-plug" title="{{$item.connector}}" aria-hidden="true"></i></small>
-					{{else}}
-						<span class="navicon lock fakelink" onClick="lockview(event, 'item', {{$item.id}});" title="{{$item.privacy}}" data-toggle="tooltip">
-							&nbsp;<small><i class="fa {{if $item.private == 1}}fa-lock{{elseif $item.private == 0}}fa-globe{{else}}fa-low-vision{{/if}}" aria-hidden="true"></i></small>
-						</span>
-					{{/if}}
 					<span class="text-muted">
 				</h5>
 				<small>
@@ -251,6 +242,15 @@ as the value of $top_child_total (this is done at the end of this file)
 					{{if $item.direction}}
 						{{include file="sub/direction.tpl" direction=$item.direction}}
 					{{/if}}
+					{{if $item.connector}}
+						&bull;
+						<small><i class="fa fa-plug" title="{{$item.connector}}" aria-hidden="true"></i></small>
+					{{else}}
+						<span class="navicon lock fakelink" onClick="lockview(event, 'item', {{$item.id}});" title="{{$item.privacy}}" data-toggle="tooltip">
+							&bull;
+							<small><i class="fa {{if $item.private == 1}}fa-lock{{elseif $item.private == 0}}fa-globe{{else}}fa-low-vision{{/if}}" aria-hidden="true"></i></small>
+						</span>
+					{{/if}}
 				</small>
 			</span>
 			</div>

From 0dbb864d7db5179881c61edcb52d06be03971732 Mon Sep 17 00:00:00 2001
From: Raroun <Raroun@users.noreply.github.com>
Date: Sun, 12 Nov 2023 14:43:48 +0100
Subject: [PATCH 2/5] Update wall_thread.tpl

Changes for code review
---
 view/theme/frio/templates/wall_thread.tpl | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/view/theme/frio/templates/wall_thread.tpl b/view/theme/frio/templates/wall_thread.tpl
index 8defb82348..4ef23931fd 100644
--- a/view/theme/frio/templates/wall_thread.tpl
+++ b/view/theme/frio/templates/wall_thread.tpl
@@ -128,7 +128,16 @@ as the value of $top_child_total (this is done at the end of this file)
 				{{if $item.network_icon != "" && $item.plink}}
 					<span class="wall-item-network"><a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" target="_blank"><i class="fa fa-{{$item.network_icon}} fakelink" title="{{$item.network_name}} - {{$item.plink.title}}" aria-hidden="true"></i></span>
 				{{else}}
-					<span class="wall-item-network" title="{{$item.app}}">{{$item.network_name}}</span>
+					{{if $item.network_icon != ""}}
+						<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>
+					{{else}}
+						<span class="wall-item-network" title="{{$item.app}}">{{$item.network_name}}</span>
+					{{/if}}
+					{{if $item.plink}}	{{*link to the original source of the item *}}
+						<a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" title="{{$item.plink.title}}" target="_blank">
+							<i class="fa fa-external-link"></i>
+						</a>
+					{{/if}}
 				{{/if}}
 			</div>
 		{{if $item.thread_level==1}}

From dbc9efd62be29b32e3abd5a543a671880cc751cf Mon Sep 17 00:00:00 2001
From: Raroun <Raroun@users.noreply.github.com>
Date: Mon, 13 Nov 2023 18:29:26 +0100
Subject: [PATCH 3/5] Update wall_thread.tpl

Update for code review
---
 view/theme/frio/templates/wall_thread.tpl | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/view/theme/frio/templates/wall_thread.tpl b/view/theme/frio/templates/wall_thread.tpl
index 4ef23931fd..ed4f92f5ec 100644
--- a/view/theme/frio/templates/wall_thread.tpl
+++ b/view/theme/frio/templates/wall_thread.tpl
@@ -122,22 +122,19 @@ as the value of $top_child_total (this is done at the end of this file)
 		<div class="media-body">{{*this is the media body for comments - this div must be closed at the end of the file *}}
 	{{/if}}
 
-			{{* contact info header*}}
+		{{* contact info header*}}
 		<div class="contact-info">
 			<div class="preferences">
 				{{if $item.network_icon != "" && $item.plink}}
-					<span class="wall-item-network"><a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" target="_blank"><i class="fa fa-{{$item.network_icon}} fakelink" title="{{$item.network_name}} - {{$item.plink.title}}" aria-hidden="true"></i></span>
+   					 <span class="wall-item-network"><a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" target="_blank"><i class="fa fa-{{$item.network_icon}} fakelink" title="{{$item.network_name}} - {{$item.plink.title}}" aria-hidden="true"></i></a></span>
 				{{else}}
-					{{if $item.network_icon != ""}}
-						<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>
-					{{else}}
-						<span class="wall-item-network" title="{{$item.app}}">{{$item.network_name}}</span>
-					{{/if}}
-					{{if $item.plink}}	{{*link to the original source of the item *}}
-						<a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" title="{{$item.plink.title}}" target="_blank">
-							<i class="fa fa-external-link"></i>
-						</a>
-					{{/if}}
+   					{{if $item.plink}}
+       						 <a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" title="{{$item.network_name}} - {{$item.plink.title}}" target="_blank">{{$item.network_name}}</a>
+   					{{elseif $item.network_icon != ""}}
+       						<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>
+    					{{else}}
+        					<span class="wall-item-network" title="{{$item.app}}">{{$item.network_name}}</span>
+    					{{/if}}
 				{{/if}}
 			</div>
 		{{if $item.thread_level==1}}

From 72817daa3b0b9e8681909010015a20a07afe7f15 Mon Sep 17 00:00:00 2001
From: Raroun <Raroun@users.noreply.github.com>
Date: Mon, 13 Nov 2023 18:47:34 +0100
Subject: [PATCH 4/5] Update wall_thread.tpl - fix indentation

---
 view/theme/frio/templates/wall_thread.tpl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/view/theme/frio/templates/wall_thread.tpl b/view/theme/frio/templates/wall_thread.tpl
index ed4f92f5ec..74254d2a75 100644
--- a/view/theme/frio/templates/wall_thread.tpl
+++ b/view/theme/frio/templates/wall_thread.tpl
@@ -126,10 +126,10 @@ as the value of $top_child_total (this is done at the end of this file)
 		<div class="contact-info">
 			<div class="preferences">
 				{{if $item.network_icon != "" && $item.plink}}
-   					 <span class="wall-item-network"><a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" target="_blank"><i class="fa fa-{{$item.network_icon}} fakelink" title="{{$item.network_name}} - {{$item.plink.title}}" aria-hidden="true"></i></a></span>
-				{{else}}
-   					{{if $item.plink}}
-       						 <a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" title="{{$item.network_name}} - {{$item.plink.title}}" target="_blank">{{$item.network_name}}</a>
+   					<span class="wall-item-network"><a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" target="_blank"><i class="fa fa-{{$item.network_icon}} fakelink" title="{{$item.network_name}} - {{$item.plink.title}}" aria-hidden="true"></i></a></span>
+				{{else}
+					{{if $item.plink}}
+       						<a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" title="{{$item.network_name}} - {{$item.plink.title}}" target="_blank">{{$item.network_name}}</a>
    					{{elseif $item.network_icon != ""}}
        						<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>
     					{{else}}

From 98f26cb9d665c47172d46d1265d03614a4bcaa0b Mon Sep 17 00:00:00 2001
From: Raroun <Raroun@users.noreply.github.com>
Date: Mon, 13 Nov 2023 19:04:13 +0100
Subject: [PATCH 5/5] Update view/theme/frio/templates/wall_thread.tpl

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
---
 view/theme/frio/templates/wall_thread.tpl | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/view/theme/frio/templates/wall_thread.tpl b/view/theme/frio/templates/wall_thread.tpl
index 74254d2a75..f63a8a478a 100644
--- a/view/theme/frio/templates/wall_thread.tpl
+++ b/view/theme/frio/templates/wall_thread.tpl
@@ -125,17 +125,15 @@ as the value of $top_child_total (this is done at the end of this file)
 		{{* contact info header*}}
 		<div class="contact-info">
 			<div class="preferences">
-				{{if $item.network_icon != "" && $item.plink}}
+				{{if $item.network_icon && $item.plink}}
    					<span class="wall-item-network"><a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" target="_blank"><i class="fa fa-{{$item.network_icon}} fakelink" title="{{$item.network_name}} - {{$item.plink.title}}" aria-hidden="true"></i></a></span>
-				{{else}
-					{{if $item.plink}}
-       						<a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" title="{{$item.network_name}} - {{$item.plink.title}}" target="_blank">{{$item.network_name}}</a>
-   					{{elseif $item.network_icon != ""}}
-       						<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>
-    					{{else}}
-        					<span class="wall-item-network" title="{{$item.app}}">{{$item.network_name}}</span>
-    					{{/if}}
-				{{/if}}
+				{{elseif $item.plink}}
+       					<a href="{{$item.plink.href}}" class="plink u-url" aria-label="{{$item.plink.title}}" title="{{$item.network_name}} - {{$item.plink.title}}" target="_blank">{{$item.network_name}}</a>
+   				{{elseif $item.network_icon}}
+       					<span class="wall-item-network"><i class="fa fa-{{$item.network_icon}}" title="{{$item.network_name}}" aria-hidden="true"></i></span>
+    				{{else}}
+        				<span class="wall-item-network" title="{{$item.app}}">{{$item.network_name}}</span>
+    				{{/if}}
 			</div>
 		{{if $item.thread_level==1}}
 			<div class="hidden-sm hidden-xs media-body"><!-- <= For computer -->