From 251a3791ddd26f619f014f1a012c05f513c70df5 Mon Sep 17 00:00:00 2001
From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Tue, 23 Jun 2020 07:52:38 -0400
Subject: [PATCH 1/2] Keep spaces after non-tags in Content\BBCode::convert

- Added test case
---
 src/Content/Text/BBCode.php           | 6 +++---
 tests/src/Content/Text/BBCodeTest.php | 6 +++++-
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/Content/Text/BBCode.php b/src/Content/Text/BBCode.php
index 1cd8e438cd..95484de720 100644
--- a/src/Content/Text/BBCode.php
+++ b/src/Content/Text/BBCode.php
@@ -1299,9 +1299,9 @@ class BBCode
 				// Remove the abstract element. It is a non visible element.
 				$text = self::stripAbstract($text);
 
-				// Move all spaces out of the tags
-				$text = preg_replace("/\[(\w*)\](\s*)/ism", '$2[$1]', $text);
-				$text = preg_replace("/(\s*)\[\/(\w*)\]/ism", '[/$2]$1', $text);
+				// Move new lines outside of tags
+				$text = preg_replace("#\[(\w*)](\n*)#ism", '$2[$1]', $text);
+				$text = preg_replace("#(\n*)\[/(\w*)]#ism", '[/$2]$1', $text);
 
 				// Extract the private images which use data urls since preg has issues with
 				// large data sizes. Stash them away while we do bbcode conversion, and then put them back
diff --git a/tests/src/Content/Text/BBCodeTest.php b/tests/src/Content/Text/BBCodeTest.php
index 35dff87d9f..82e2853e71 100644
--- a/tests/src/Content/Text/BBCodeTest.php
+++ b/tests/src/Content/Text/BBCodeTest.php
@@ -236,7 +236,11 @@ class BBCodeTest extends MockedTest
 			'bug-7808-code-amp' => [
 				'expectedHtml' => '<code>&amp;</code>',
 				'text' => '[code]&[/code]',
-			]
+			],
+			'task-8800-pre-spaces-notag' => [
+				'expectedHtml' => '[test] Space',
+				'text' => '[test] Space',
+			],
 		];
 	}
 

From faeffff8a39aae0d8e0ca6c07a9ad6724570b5a7 Mon Sep 17 00:00:00 2001
From: Hypolite Petovan <hypolite@mrpetovan.com>
Date: Tue, 23 Jun 2020 07:53:18 -0400
Subject: [PATCH 2/2] [pre] blocks now preserve spaces

- Added test case
- Added English documentation
---
 doc/BBCode.md                         | 8 ++++++++
 src/Content/Text/BBCode.php           | 6 +++++-
 tests/src/Content/Text/BBCodeTest.php | 4 ++++
 3 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/doc/BBCode.md b/doc/BBCode.md
index 59f7414491..08c43636f8 100644
--- a/doc/BBCode.md
+++ b/doc/BBCode.md
@@ -633,6 +633,14 @@ On Mastodon this field is used for the content warning.
   </td>
   <td>@user@domain.tld #hashtag</td>
 </tr>
+<tr>
+  <td>Additionally, [pre] blocks preserve spaces:
+    <ul>
+      <li>[pre]&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Spaces[/pre]</li>
+    </ul>
+  </td>
+  <td>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Spaces</td>
+</tr>
 <tr>
   <td>[nosmile] is used to disable smilies on a post by post basis<br>
     <br>
diff --git a/src/Content/Text/BBCode.php b/src/Content/Text/BBCode.php
index 95484de720..ba5bde045d 100644
--- a/src/Content/Text/BBCode.php
+++ b/src/Content/Text/BBCode.php
@@ -1878,7 +1878,11 @@ class BBCode
 			// Remove escaping tags
 			$text = preg_replace("/\[noparse\](.*?)\[\/noparse\]/ism", '\1', $text);
 			$text = preg_replace("/\[nobb\](.*?)\[\/nobb\]/ism", '\1', $text);
-			$text = preg_replace("/\[pre\](.*?)\[\/pre\]/ism", '\1', $text);
+
+			// Additionally, [pre] tags preserve spaces
+			$text = preg_replace_callback("/\[pre\](.*?)\[\/pre\]/ism", function ($match) {
+				return str_replace(' ', '&nbsp;', $match[1]);
+			}, $text);
 
 			return $text;
 		}); // Escaped code
diff --git a/tests/src/Content/Text/BBCodeTest.php b/tests/src/Content/Text/BBCodeTest.php
index 82e2853e71..77613e891a 100644
--- a/tests/src/Content/Text/BBCodeTest.php
+++ b/tests/src/Content/Text/BBCodeTest.php
@@ -241,6 +241,10 @@ class BBCodeTest extends MockedTest
 				'expectedHtml' => '[test] Space',
 				'text' => '[test] Space',
 			],
+			'task-8800-pre-spaces' => [
+				'expectedHtml' => '&nbsp;&nbsp;&nbsp;&nbsp;Spaces',
+				'text' => '[pre]    Spaces[/pre]',
+			],
 		];
 	}