From 0e157150882bda71e3ba9c2ba56162db8cd897e3 Mon Sep 17 00:00:00 2001
From: Michael <heluecht@pirati.ca>
Date: Sun, 16 Jan 2022 19:38:59 +0000
Subject: [PATCH] Simplifying extension access

---
 src/Module/Api/Friendica/Activity.php              | 2 +-
 src/Module/Api/Friendica/Notification.php          | 2 +-
 src/Module/Api/Friendica/Profile/Show.php          | 2 +-
 src/Module/Api/GNUSocial/Help/Test.php             | 2 +-
 src/Module/Api/Twitter/Account/RateLimitStatus.php | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/Module/Api/Friendica/Activity.php b/src/Module/Api/Friendica/Activity.php
index 70aeee613f..3915c2089e 100644
--- a/src/Module/Api/Friendica/Activity.php
+++ b/src/Module/Api/Friendica/Activity.php
@@ -52,7 +52,7 @@ class Activity extends BaseApi
 		$res = Item::performActivity($request['id'], $this->parameters['verb'], $uid);
 
 		if ($res) {
-			if (!empty($this->parameters['extension']) && ($this->parameters['extension'] == 'xml')) {
+			if ($this->parameters['extension'] ?? '' == 'xml') {
 				$ok = 'true';
 			} else {
 				$ok = 'ok';
diff --git a/src/Module/Api/Friendica/Notification.php b/src/Module/Api/Friendica/Notification.php
index 1f5ac9b488..d16e0e2b0d 100644
--- a/src/Module/Api/Friendica/Notification.php
+++ b/src/Module/Api/Friendica/Notification.php
@@ -43,7 +43,7 @@ class Notification extends BaseApi
 			$notifications[] = new ApiNotification($Notify);
 		}
 
-		if (!empty($this->parameters['extension']) && ($this->parameters['extension'] == 'xml')) {
+		if ($this->parameters['extension'] ?? '' == 'xml') {
 			$xmlnotes = [];
 			foreach ($notifications as $notification) {
 				$xmlnotes[] = ['@attributes' => $notification->toArray()];
diff --git a/src/Module/Api/Friendica/Profile/Show.php b/src/Module/Api/Friendica/Profile/Show.php
index 60f4f024b0..2507b7e275 100644
--- a/src/Module/Api/Friendica/Profile/Show.php
+++ b/src/Module/Api/Friendica/Profile/Show.php
@@ -48,7 +48,7 @@ class Show extends BaseApi
 		$profile = self::formatProfile($profile, $profileFields);
 
 		$profiles = [];
-		if (!empty($this->parameters['extension']) && ($this->parameters['extension'] == 'xml')) {
+		if ($this->parameters['extension'] ?? '' == 'xml') {
 			$profiles['0:profile'] = $profile;
 		} else {
 			$profiles[] = $profile;
diff --git a/src/Module/Api/GNUSocial/Help/Test.php b/src/Module/Api/GNUSocial/Help/Test.php
index 4cfeda6aba..44a31ba880 100644
--- a/src/Module/Api/GNUSocial/Help/Test.php
+++ b/src/Module/Api/GNUSocial/Help/Test.php
@@ -31,7 +31,7 @@ class Test extends BaseApi
 {
 	protected function rawContent(array $request = [])
 	{
-		if (!empty($this->parameters['extension']) && ($this->parameters['extension'] == 'xml')) {
+		if ($this->parameters['extension'] ?? '' == 'xml') {
 			$ok = 'true';
 		} else {
 			$ok = 'ok';
diff --git a/src/Module/Api/Twitter/Account/RateLimitStatus.php b/src/Module/Api/Twitter/Account/RateLimitStatus.php
index 7a48f4f0e0..60cee6ce34 100644
--- a/src/Module/Api/Twitter/Account/RateLimitStatus.php
+++ b/src/Module/Api/Twitter/Account/RateLimitStatus.php
@@ -31,7 +31,7 @@ class RateLimitStatus extends BaseApi
 {
 	protected function rawContent(array $request = [])
 	{
-		if (!empty($this->parameters['extension']) && ($this->parameters['extension'] == 'xml')) {
+		if ($this->parameters['extension'] ?? '' == 'xml') {
 			$hash = [
 				'remaining-hits'        => '150',
 				'@attributes'           => ["type" => "integer"],